GNU logs - #72092, boring messages

Message sent to bug-guile@HIDDEN:

Subject: bug#72092: popen creates "/dev/null" fds and never closes them
Resent-From: jakub-w@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Sat, 13 Jul 2024 12:09:02 +0000
Resent-Message-ID: <handler.72092.B.172087250028292 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72092 <at> debbugs.gnu.org
MIME-Version: 1.0
Date: Sat, 13 Jul 2024 12:07:52 +0000
From: jakub-w@HIDDEN
Message-ID: <77cbc4b2a48a74957cc02fcc53238b29@HIDDEN>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=198.252.153.129; envelope-from=jakub-w@HIDDEN;
 helo=mx1.riseup.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Consider the following example:

(use-modules (ice-9 popen))

(parameterize ((current-error-port (%make-void-port OPEN_BOTH)))
  (while #t
    (close-pipe (open-pipe* OPEN_READ "free"))
    (sleep 1)))

This opens a new "/dev/null" file descriptor every second and doesn't
close it when close-pipe is called.
If current ports are all fd ports, this doesn't happen.

AFAICT the problem was introduced by the commit
36fd2b4920ae926c79b936c29e739e71a6dff2bc in Guile 3.0.10.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: jakub-w@HIDDEN
Subject: bug#72092: Acknowledgement (popen creates "/dev/null" fds and
 never closes them)
Message-ID: <handler.72092.B.172087250028292.ack <at> debbugs.gnu.org>
References: <77cbc4b2a48a74957cc02fcc53238b29@HIDDEN>
X-Gnu-PR-Message: ack 72092
X-Gnu-PR-Package: guile
Reply-To: 72092 <at> debbugs.gnu.org
Date: Sat, 13 Jul 2024 12:09:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guile@HIDDEN

If you wish to submit further information on this problem, please
send it to 72092 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72092: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72092
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guile@HIDDEN:

Subject: bug#72092: [PATCH] fix file descriptor leak in piped_process/system*/popen/etc
References: <77cbc4b2a48a74957cc02fcc53238b29@HIDDEN>
In-Reply-To: <77cbc4b2a48a74957cc02fcc53238b29@HIDDEN>
Resent-From: nathan <nathan_mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Sat, 13 Jul 2024 18:24:02 +0000
Resent-Message-ID: <handler.72092.B72092.17208949831917 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72092 <at> debbugs.gnu.org, jakub-w@HIDDEN
Content-Type: multipart/mixed; boundary="------------Jb0SC31Q05tuixOe1BZ7vzWj"
Message-ID: <0ea0f005-32be-2fa1-b96a-e67d3e4ec3f6@HIDDEN>
Date: Sat, 13 Jul 2024 18:22:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
From: nathan <nathan_mail@HIDDEN>
Content-Language: en-US
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------Jb0SC31Q05tuixOe1BZ7vzWj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

fix is attached

test code:
(use-modules (ice-9 ftw))
(use-modules (ice-9 popen))
(define (print-open)
    (format #t "~a\n" (length (scandir "/proc/self/fd"))))
(let ((p (%make-void-port "rw")))
    (print-open)
    (parameterize ((current-output-port p) (current-input-port p) (current-error-port p))
      (system* "ls"))
    (close-port p)
    (print-open))
(parameterize ((current-error-port (%make-void-port OPEN_BOTH)))
      (while
       #t
       (close-pipe (open-pipe* OPEN_READ "free"))
       (print-open)
       (sleep 1)))

there's still a one-time increase in the file descriptors, but it seems unrelated. or at least much harder to find.

(by the way, ignoring current-output-port and using /dev/null is bad. it would be nice to open a pipe in that case and forward whatever the child writes to the scheme port.
but that would require a separate thread, and it may be impossible to do something like that for current-input-port)
--------------Jb0SC31Q05tuixOe1BZ7vzWj
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-fix-file-descriptor-leak-in-piped_process-system-pop.patch"
Content-Disposition: attachment;
 filename*0="0001-fix-file-descriptor-leak-in-piped_process-system-pop.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA0NjZlNGFiMmMyY2IxZjkzYWY0ODEyOTBjMWQzNmRiMDA5NzZiOGNlIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBuYXRoYW4gPG5hdGhhbl9tYWlsQG5ib3JnaGVzZS5j
b20+CkRhdGU6IFNhdCwgMTMgSnVsIDIwMjQgMTM6MjU6MDggLTA0MDAKU3ViamVjdDogW1BB
VENIXSBmaXggZmlsZSBkZXNjcmlwdG9yIGxlYWsgaW4gcGlwZWRfcHJvY2Vzcy9zeXN0ZW0q
L3BvcGVuL2V0YwoKKiBsaWJndWlsZS9wb3NpeC5jIChwaXBlZF9wcm9jZXNzKTogY2xvc2Ug
YXV0b21hdGljYWxseSBvcGVuZWQgL2Rldi9udWxsCiAgRml4IGJ1ZyAjNzIwOTIKLS0tCiBs
aWJndWlsZS9wb3NpeC5jIHwgMzMgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t
CiAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvbGliZ3VpbGUvcG9zaXguYyBiL2xpYmd1aWxlL3Bvc2l4LmMKaW5kZXgg
OWE4NzNiNWExLi44MDI4YjQ5M2YgMTAwNjQ0Ci0tLSBhL2xpYmd1aWxlL3Bvc2l4LmMKKysr
IGIvbGliZ3VpbGUvcG9zaXguYwpAQCAtMTUzNSwzMiArMTUzNSwzMiBAQCBzdGF0aWMgaW50
CiBwaXBlZF9wcm9jZXNzIChwaWRfdCAqcGlkLCBTQ00gcHJvZywgU0NNIGFyZ3MsIFNDTSBm
cm9tLCBTQ00gdG8pCiAjZGVmaW5lIEZVTkNfTkFNRSAicGlwZWQtcHJvY2VzcyIKIHsKLSAg
aW50IHJlYWRpbmcsIHdyaXRpbmc7CiAgIGludCBjMnBbMl07IC8qIENoaWxkIHRvIHBhcmVu
dC4gICovCiAgIGludCBwMmNbMl07IC8qIFBhcmVudCB0byBjaGlsZC4gICovCiAgIGludCBp
biA9IC0xLCBvdXQgPSAtMSwgZXJyID0gLTE7CiAgIGNoYXIgKmV4ZWNfZmlsZTsKICAgY2hh
ciAqKmV4ZWNfYXJndjsKICAgY2hhciAqKmV4ZWNfZW52ID0gZW52aXJvbjsKKyAgaW50IHRv
X2Nsb3NlWzNdOworICBpbnQgbnVtX3RvX2Nsb3NlPTA7CiAKICAgZXhlY19maWxlID0gc2Nt
X3RvX2xvY2FsZV9zdHJpbmcgKHByb2cpOwogICBleGVjX2FyZ3YgPSBzY21faV9hbGxvY2F0
ZV9zdHJpbmdfcG9pbnRlcnMgKHNjbV9jb25zIChwcm9nLCBhcmdzKSk7CiAKLSAgcmVhZGlu
ZyA9IHNjbV9pc19wYWlyIChmcm9tKTsKLSAgd3JpdGluZyA9IHNjbV9pc19wYWlyICh0byk7
Ci0KLSAgaWYgKHJlYWRpbmcpCisgIGlmIChzY21faXNfcGFpciAoZnJvbSkpCiAgICAgewog
ICAgICAgYzJwWzBdID0gc2NtX3RvX2ludCAoc2NtX2NhciAoZnJvbSkpOwogICAgICAgYzJw
WzFdID0gc2NtX3RvX2ludCAoc2NtX2NkciAoZnJvbSkpOwogICAgICAgb3V0ID0gYzJwWzFd
OworICAgICAgdG9fY2xvc2VbbnVtX3RvX2Nsb3NlKytdID0gb3V0OwogICAgIH0KIAotICBp
ZiAod3JpdGluZykKKyAgaWYgKHNjbV9pc19wYWlyICh0bykpCiAgICAgewogICAgICAgcDJj
WzBdID0gc2NtX3RvX2ludCAoc2NtX2NhciAodG8pKTsKICAgICAgIHAyY1sxXSA9IHNjbV90
b19pbnQgKHNjbV9jZHIgKHRvKSk7CiAgICAgICBpbiA9IHAyY1swXTsKKyAgICAgIHRvX2Ns
b3NlW251bV90b19jbG9zZSsrXSA9IGluOwogICAgIH0KIAogICB7CkBAIC0xNTY5LDMwICsx
NTY5LDM3IEBAIHBpcGVkX3Byb2Nlc3MgKHBpZF90ICpwaWQsIFNDTSBwcm9nLCBTQ00gYXJn
cywgU0NNIGZyb20sIFNDTSB0bykKICAgICBpZiAoU0NNX09QT1VURlBPUlRQICgocG9ydCA9
IHNjbV9jdXJyZW50X2Vycm9yX3BvcnQgKCkpKSkKICAgICAgIGVyciA9IFNDTV9GUE9SVF9G
REVTIChwb3J0KTsKICAgICBlbHNlCi0gICAgICBlcnIgPSBvcGVuICgiL2Rldi9udWxsIiwg
T19XUk9OTFkgfCBPX0NMT0VYRUMpOworICAgICAgeworICAgICAgICBlcnIgPSBvcGVuICgi
L2Rldi9udWxsIiwgT19XUk9OTFkgfCBPX0NMT0VYRUMpOworICAgICAgICB0b19jbG9zZVtu
dW1fdG9fY2xvc2UrK10gPSBlcnI7CisgICAgICB9CiAgICAgaWYgKG91dCA9PSAtMSkKICAg
ICAgIHsKICAgICAgICAgaWYgKFNDTV9PUE9VVEZQT1JUUCAoKHBvcnQgPSBzY21fY3VycmVu
dF9vdXRwdXRfcG9ydCAoKSkpKQogICAgICAgICAgIG91dCA9IFNDTV9GUE9SVF9GREVTIChw
b3J0KTsKICAgICAgICAgZWxzZQotICAgICAgICAgIG91dCA9IG9wZW4gKCIvZGV2L251bGwi
LCBPX1dST05MWSB8IE9fQ0xPRVhFQyk7CisgICAgICAgICAgeworICAgICAgICAgICAgb3V0
ID0gb3BlbiAoIi9kZXYvbnVsbCIsIE9fV1JPTkxZIHwgT19DTE9FWEVDKTsKKyAgICAgICAg
ICAgIHRvX2Nsb3NlW251bV90b19jbG9zZSsrXSA9IG91dDsKKyAgICAgICAgICB9CiAgICAg
ICB9CiAgICAgaWYgKGluID09IC0xKQogICAgICAgewogICAgICAgICBpZiAoU0NNX09QSU5G
UE9SVFAgKChwb3J0ID0gc2NtX2N1cnJlbnRfaW5wdXRfcG9ydCAoKSkpKQogICAgICAgICAg
IGluID0gU0NNX0ZQT1JUX0ZERVMgKHBvcnQpOwogICAgICAgICBlbHNlCi0gICAgICAgICAg
aW4gPSBvcGVuICgiL2Rldi9udWxsIiwgT19SRE9OTFkgfCBPX0NMT0VYRUMpOworICAgICAg
ICAgIHsKKyAgICAgICAgICAgIGluID0gb3BlbiAoIi9kZXYvbnVsbCIsIE9fUkRPTkxZIHwg
T19DTE9FWEVDKTsKKyAgICAgICAgICAgIHRvX2Nsb3NlW251bV90b19jbG9zZSsrXSA9IGlu
OworICAgICAgICAgIH0KICAgICAgIH0KICAgfQogCiAgICpwaWQgPSBkb19zcGF3biAoZXhl
Y19maWxlLCBleGVjX2FyZ3YsIGV4ZWNfZW52LCBpbiwgb3V0LCBlcnIsIDEpOwogICBpbnQg
ZXJybm9fc2F2ZSA9ICgqcGlkIDwgMCkgPyBlcnJubyA6IDA7CiAKLSAgaWYgKHJlYWRpbmcp
Ci0gICAgY2xvc2UgKGMycFsxXSk7Ci0gIGlmICh3cml0aW5nKQotICAgIGNsb3NlIChwMmNb
MF0pOworICB3aGlsZSAobnVtX3RvX2Nsb3NlPjApCisgICAgY2xvc2UgKHRvX2Nsb3NlWy0t
bnVtX3RvX2Nsb3NlXSk7CiAKICAgaWYgKCpwaWQgPT0gLTEpCiAgICAgc3dpdGNoIChlcnJu
b19zYXZlKQotLSAKMi40NS4yCgo=

--------------Jb0SC31Q05tuixOe1BZ7vzWj--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 27 Sep 2024 20:34:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 27 16:34:41 2024
Received: from localhost ([127.0.0.1]:54649 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1suHfl-0007vH-3P
	for submit <at> debbugs.gnu.org; Fri, 27 Sep 2024 16:34:41 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:28980)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1suHfk-0007up-17
 for control <at> debbugs.gnu.org; Fri, 27 Sep 2024 16:34:40 -0400
Authentication-Results: mail2-relais-roc.national.inria.fr;
 dkim=none (message not signed) header.i=none;
 spf=SoftFail smtp.mailfrom=ludo@HIDDEN;
 dmarc=fail (p=none dis=none) d=gnu.org
X-IronPort-AV: E=Sophos;i="6.11,159,1725314400"; d="scan'208";a="185610514"
Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201])
 by mail2-relais-roc.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2024 22:31:02 +0200
Date: Fri, 27 Sep 2024 22:31:01 +0200
Message-Id: <871q14n8je.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #72092
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

severity 72092 important
quit

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.