GNU bug report logs - #72097
30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72097 in the body.
You can then email your comments to 72097 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.60; [PATCH] Don't add to Eshell history when aborting
 'eshell-command'
Date: Sat, 13 Jul 2024 11:51:46 -0700

[Message part 1 (text/plain, inline)]

Steps to reproduce:

  emacs -Q
  M-x eshell-command RET oops C-g
  M-x eshell
  <up>

This will show the most-recent command in the Eshell history as "oops". 
That's because it was adding to the history in 'minibuffer-exit-hook', 
which runs regardless of *how* you exit the minibuffer. This regressed 
from 093a360251, and I misunderstood the conditions where 
'minibuffer-exit-hook' runs.

Attached is a patch to fix this. Is this ok for the release branch?

[0001-Don-t-save-to-history-from-eshell-command-when-abort.patch (text/plain, attachment)]

Message #8 received at 72097 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 72097 <at> debbugs.gnu.org
Subject: Re: bug#72097: 30.0.60;
 [PATCH] Don't add to Eshell history when aborting 'eshell-command'
Date: Sun, 14 Jul 2024 07:42:29 +0300

> Date: Sat, 13 Jul 2024 11:51:46 -0700
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
>    emacs -Q
>    M-x eshell-command RET oops C-g
>    M-x eshell
>    <up>
> 
> This will show the most-recent command in the Eshell history as "oops". 
> That's because it was adding to the history in 'minibuffer-exit-hook', 
> which runs regardless of *how* you exit the minibuffer. This regressed 
> from 093a360251, and I misunderstood the conditions where 
> 'minibuffer-exit-hook' runs.
> 
> Attached is a patch to fix this. Is this ok for the release branch?

Yes, thanks.

Message #13 received at 72097-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72097-done <at> debbugs.gnu.org
Subject: Re: bug#72097: 30.0.60; [PATCH] Don't add to Eshell history when
 aborting 'eshell-command'
Date: Mon, 15 Jul 2024 09:12:38 -0700

On 7/13/2024 9:42 PM, Eli Zaretskii wrote:
>> Attached is a patch to fix this. Is this ok for the release branch?
> 
> Yes, thanks.

Thanks. Merged to the release branch as 3407e274999, and closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.