GNU bug report logs - #72101
[PATCH 0/2] Add perl-minimumversion.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72101 in the body.
You can then email your comments to 72101 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH 0/2] Add perl-minimumversion.
Date: Sun, 14 Jul 2024 11:57:29 +0900

gemmaro (2):
  gnu: Add perl-ppix-utils.
  gnu: Add perl-minimumversion.

 gnu/packages/perl.scm | 64 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 63 insertions(+), 1 deletion(-)


base-commit: c1d367f57e89c3f2efd964e6d638bd89b0b1df97
prerequisite-patch-id: 62fc54ed554df985530503c8e8c5b718c16b709b
prerequisite-patch-id: c22785847e70bf2f4c94547dd7851ad7de06b92a
prerequisite-patch-id: 36850492cd3b84d7f353cc8c923a667c1b0271bc
prerequisite-patch-id: 4cf00e93b12f66ef5e385a693bfdb81e4b558388
-- 
2.45.2

Message #8 received at 72101 <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: 72101 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH 1/2] gnu: Add perl-ppix-utils.
Date: Sun, 14 Jul 2024 12:10:15 +0900

* gnu/packages/perl.scm (perl-ppix-utils): New variable.

Change-Id: Idaa31e9eb628d5175a2b20ee6fac67427e6cf425
---
 gnu/packages/perl.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 0abf3f7fd1..fe75ffa4c4 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -33,7 +33,7 @@
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
 ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
 ;;; Copyright © 2022, 2023 Evgeny Pisemsky <evgeny <at> pisemsky.com>
-;;; Copyright © 2022, 2023 gemmaro <gemmaro.dev <at> gmail.com>
+;;; Copyright © 2022, 2023, 2024 gemmaro <gemmaro.dev <at> gmail.com>
 ;;; Copyright © 2023 Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>
 ;;; Copyright © 2023 Andreas Enge <andreas <at> enge.fr>
 ;;; Copyright © 2023 Jake Leporte <jakeleporte <at> outlook.com>
@@ -9148,6 +9148,28 @@ (define-public perl-ppix-utilities
 in @code{PPIx::Utilities::Node}.")
     (license license:perl-license)))
 
+(define-public perl-ppix-utils
+  (package
+    (name "perl-ppix-utils")
+    (version "0.003")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/D/DB/DBOOK/PPIx-Utils-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "04dszlp7yas3yi7gm1l2g47h88i52n7gwj3jnq0vw0xdivycr6ra"))))
+    (build-system perl-build-system)
+    (propagated-inputs (list perl-b-keywords perl-ppi))
+    (home-page "https://metacpan.org/release/PPIx-Utils")
+    (synopsis "Utility functions for Perl PPI")
+    (description
+     "@samp{PPIx::Utils} is a collection of utility functions for working
+with @samp{PPI} documents.  The functions are organized into
+submodules, and may be imported from the appropriate submodules or via
+this module.")
+    (license license:perl-license)))
+
 (define-public perl-probe-perl
   (package
     (name "perl-probe-perl")
-- 
2.45.2

Message #11 received at 72101 <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: 72101 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH 2/2] gnu: Add perl-minimumversion.
Date: Sun, 14 Jul 2024 12:10:16 +0900

* gnu/packages/perl.scm (perl-minimumversion): New variable.

Change-Id: I731567f257d8415b4cf834ab22c7e64699a8b28f
---
 gnu/packages/perl.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index fe75ffa4c4..bbc06d320c 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6877,6 +6877,46 @@ (define-public perl-mime-types
 knowledge of Apache.")
     (license (package-license perl))))
 
+(define-public perl-minimumversion
+  (package
+    (name "perl-minimumversion")
+    (version "1.40")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DB/DBOOK/Perl-MinimumVersion-"
+             version ".tar.gz"))
+       (sha256
+        (base32 "145yl4qv14xcrr74w1qvdb6s0h5lj8smnfawfnj0rmv0rdwab2bm"))))
+    (build-system perl-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'install 'wrap-programs
+                     (lambda _
+                       (wrap-program (string-append #$output "/bin/perlver")
+                         (list "PERL5LIB" ":"
+                               'prefix
+                               (list (string-append (getenv "PERL5LIB") ":"
+                                                    #$output
+                                                    "/lib/perl5/site_perl")))))))))
+    (inputs (list bash-minimal))
+    (propagated-inputs (list perl-file-find-rule
+                             perl-file-find-rule-perl
+                             perl-params-util
+                             perl-ppi
+                             perl-ppix-regexp
+                             perl-ppix-utils))
+    (home-page "https://metacpan.org/release/Perl-MinimumVersion")
+    (synopsis "Find a minimum required version of perl for Perl code")
+    (description
+     "@samp{Perl::MinimumVersion} takes Perl source code and calculates the
+minimum version of perl required to be able to run it.  Because it is
+based on @samp{PPI}, it can do this without having to actually load
+the code.  The distribution comes with a script called @samp{perlver}.")
+    (license license:perl-license)))
+
 (define-public perl-mixin-linewise
   (package
     (name "perl-mixin-linewise")
-- 
2.45.2

Message #14 received at 72101 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: control <at> debbugs.gnu.org,72101 <at> debbugs.gnu.org
Subject: QA review for 72101
Date: Thu, 15 Aug 2024 15:48:27 +0200

user guix
usertag 72101 + reviewed-looks-good
thanks

Guix QA review form submission:
Looks good to me. 
A nitpick: Maybe you can use also use "PPI documents" in the description of perl-minimumversion to make that a bit clearer. 

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests, New package synopsis and descriptions

-- 
Best regards,
Nicolas Graves

Message #17 received at 72101 <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: 72101 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH v2 1/2] gnu: Add perl-ppix-utils.
Date: Wed, 21 Aug 2024 20:59:25 +0900

* gnu/packages/perl.scm (perl-ppix-utils): New variable.

Change-Id: I9548c693aa6f54bd53662374f77b2fbd1ca3f485
---
 gnu/packages/perl.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index a0eec2baed..46de612234 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -33,7 +33,7 @@
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
 ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
 ;;; Copyright © 2022, 2023 Evgeny Pisemsky <mail <at> pisemsky.site>
-;;; Copyright © 2022, 2023 gemmaro <gemmaro.dev <at> gmail.com>
+;;; Copyright © 2022, 2023, 2024 gemmaro <gemmaro.dev <at> gmail.com>
 ;;; Copyright © 2023 Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>
 ;;; Copyright © 2023 Andreas Enge <andreas <at> enge.fr>
 ;;; Copyright © 2023 Jake Leporte <jakeleporte <at> outlook.com>
@@ -9148,6 +9148,28 @@ (define-public perl-ppix-utilities
 in @code{PPIx::Utilities::Node}.")
     (license license:perl-license)))
 
+(define-public perl-ppix-utils
+  (package
+    (name "perl-ppix-utils")
+    (version "0.003")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/D/DB/DBOOK/PPIx-Utils-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "04dszlp7yas3yi7gm1l2g47h88i52n7gwj3jnq0vw0xdivycr6ra"))))
+    (build-system perl-build-system)
+    (propagated-inputs (list perl-b-keywords perl-ppi))
+    (home-page "https://metacpan.org/release/PPIx-Utils")
+    (synopsis "Utility functions for Perl PPI")
+    (description
+     "@samp{PPIx::Utils} is a collection of utility functions for working
+with @samp{PPI} documents.  The functions are organized into
+submodules, and may be imported from the appropriate submodules or via
+this module.")
+    (license license:perl-license)))
+
 (define-public perl-probe-perl
   (package
     (name "perl-probe-perl")

base-commit: 127592bc0fd7f5deb79ea05dd9e7d3bfdb3c2a1d
-- 
2.45.2

Message #20 received at 72101 <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: 72101 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH v2 2/2] gnu: Add perl-minimumversion.
Date: Wed, 21 Aug 2024 20:59:26 +0900

* gnu/packages/perl.scm (perl-minimumversion): New variable.

Change-Id: Iad3c22936c07b7430525ad9827b6703d4ea9ce9c
---
I added "Perl Parsing Interface"[1] in the description to make it clearer.

[1] https://metacpan.org/pod/PPI#What-Does-PPI-Stand-For?

 gnu/packages/perl.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 46de612234..816aca2d59 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6877,6 +6877,46 @@ (define-public perl-mime-types
 knowledge of Apache.")
     (license (package-license perl))))
 
+(define-public perl-minimumversion
+  (package
+    (name "perl-minimumversion")
+    (version "1.40")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DB/DBOOK/Perl-MinimumVersion-"
+             version ".tar.gz"))
+       (sha256
+        (base32 "145yl4qv14xcrr74w1qvdb6s0h5lj8smnfawfnj0rmv0rdwab2bm"))))
+    (build-system perl-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'install 'wrap-programs
+                     (lambda _
+                       (wrap-program (string-append #$output "/bin/perlver")
+                         (list "PERL5LIB" ":"
+                               'prefix
+                               (list (string-append (getenv "PERL5LIB") ":"
+                                                    #$output
+                                                    "/lib/perl5/site_perl")))))))))
+    (inputs (list bash-minimal))
+    (propagated-inputs (list perl-file-find-rule
+                             perl-file-find-rule-perl
+                             perl-params-util
+                             perl-ppi
+                             perl-ppix-regexp
+                             perl-ppix-utils))
+    (home-page "https://metacpan.org/release/Perl-MinimumVersion")
+    (synopsis "Find a minimum required version of perl for Perl code")
+    (description
+     "@samp{Perl::MinimumVersion} takes Perl source code and calculates the minimum
+version of perl required to be able to run it.  Because it is based on the @samp{PPI}
+(Perl Parsing Interface), it can do this without loading the code.  The distribution
+comes with a script called @samp{perlver}.")
+    (license license:perl-license)))
+
 (define-public perl-mixin-linewise
   (package
     (name "perl-mixin-linewise")
-- 
2.45.2

Message #25 received at 72101-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: gemmaro <gemmaro.dev <at> gmail.com>
Cc: 72101-done <at> debbugs.gnu.org, Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#72101] [PATCH v2 1/2] gnu: Add perl-ppix-utils.
Date: Wed, 21 Aug 2024 19:00:37 +0200

gemmaro <gemmaro.dev <at> gmail.com> skribis:

> * gnu/packages/perl.scm (perl-ppix-utils): New variable.
>
> Change-Id: I9548c693aa6f54bd53662374f77b2fbd1ca3f485

[...]

> * gnu/packages/perl.scm (perl-minimumversion): New variable.
>
> Change-Id: Iad3c22936c07b7430525ad9827b6703d4ea9ce9c

Applied!  Thank you, and thanks Nicolas.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.