GNU bug report logs - #72104
[PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: George Huebner <george@HIDDEN>; Keywords: patch; merged with #72848; Done: Eli Zaretskii <eliz@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Forcibly Merged 72104 72848. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 72104 <at> debbugs.gnu.org:


Received: (at 72104) by debbugs.gnu.org; 24 Feb 2025 21:20:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 24 16:20:27 2025
Received: from localhost ([127.0.0.1]:43005 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tmfsJ-0006HO-2D
	for submit <at> debbugs.gnu.org; Mon, 24 Feb 2025 16:20:27 -0500
Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]:57461)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tmfsF-0006GX-BM
 for 72104 <at> debbugs.gnu.org; Mon, 24 Feb 2025 16:20:24 -0500
Received: by mail-ej1-x635.google.com with SMTP id
 a640c23a62f3a-ab78e6edb99so685825466b.2
 for <72104 <at> debbugs.gnu.org>; Mon, 24 Feb 2025 13:20:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740432017; x=1741036817; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=L25CRlKApi/cjbHTWCZAnYjHuNMbI/JOuWxoRW/CIl4=;
 b=T7kh0jTrM4rCQQUKkHo99XKyESeTcYo7NnYzFmQ0XVXsmblfHkt/2uZpU6Jl4EuhNF
 bvoITRUw554jYKDIbry5GbX3RW4ZUWgCHmiv/qsYU1fmffuvNLUEPNJKSco2eRwkWvLg
 cvYmvKSsdfPPjWJfCxjLjyexZNo6fof+0moPY4TMuXG6Pw/MX8d9dzVmT5HYpl0eddRc
 c0J4sUe85x7g6fIc1MkA5ZGS6arT/QQVFPPlKKOJ6FBgGmIWP2QAB3elKAQwOrxcJFyu
 FSvYt8dj6aAKTZD5YxZ6LG88R6xxMBUl5i2PeVQykjCH4V9dJR6yLTN/OL3vlPcXT/ZV
 qL5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740432017; x=1741036817;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=L25CRlKApi/cjbHTWCZAnYjHuNMbI/JOuWxoRW/CIl4=;
 b=b7XirydSbRuhRVLEfUkMOc/EbPuwKKmVcdt4/P0RaAI8PMyqpW5zJAWjL7xCQPWOxF
 MHdmpQvJNiZRafFIv2DAmuXjzPl3glMSVBiTp99GfDPW8YxwnBqjGOEN83PokhNUDpss
 ERW9CMwueIlm+7gUOBrDBWurFSaglKIwo2ZuPKr5+lvTrMah88oTihmlygiAah43vbMT
 e5fH5RAObyfoMk1SbUhr3RVfsItS/bu1Si7ggwWn+JBs3u0WDUN62L234/d/wiRep1oH
 bK8utiRCK6lRI70gMkaO2DEI/AnKmebDCPys2xklIWiBHhN3HpAdaeKKcOM3sxqjad6U
 RREA==
X-Gm-Message-State: AOJu0YxyoiwktfIYK3TsFeIYYQGqWgLe9fBsaCFiVYZgEUq9qgytnJbK
 BBu1UvcYz86BTA5IT29++gXDWs5l5JC6xm6kBKNp8uix4rcS44R2L5/xFKbIAegLJYQYVMCavuw
 Lm+JBeMomAwy8t8PRWXZ4lChIv90=
X-Gm-Gg: ASbGncvQhZm1yDqpFALmFQvZzbYqEOIVZuTCjQmOUN6rAK8uQWC8mMxpyKB7LGGHTK+
 UEHXWhrFleduI8O4e7sCFLDUYBBpMw7tyrOkSiNzMhi6GBkm3J1hFX3ohvNulYprthE8RLwCmjp
 8rK/Y5NiAsbQ==
X-Google-Smtp-Source: AGHT+IGYVZZA+ZSGQHrPe16haLUI63XcY7xZuZO2PQCdg22jUI0Aw3Nq/KefuqHxLNv0B9WNhBB8XQogWv4UG7L6bWg=
X-Received: by 2002:a17:906:5a52:b0:abe:ce46:6231 with SMTP id
 a640c23a62f3a-abece4677fdmr110881166b.16.1740432016898; Mon, 24 Feb 2025
 13:20:16 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 24 Feb 2025 15:20:16 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <m27c5fxfaf.fsf@HIDDEN>
References: <m2r0bw30g4.fsf@HIDDEN>
 <CADwFkmkLo1Y6R-F5=rT8y=+z9=ykzu=ECYu1dd0FRDPOzOSZ-Q@HIDDEN>
 <m27c5fxfaf.fsf@HIDDEN>
MIME-Version: 1.0
Date: Mon, 24 Feb 2025 15:20:16 -0600
X-Gm-Features: AWEUYZnlyfulIpjxAN7BtIX8PJGozwqhQtAy-RzmZ9eLIEbhb_l32Zsgm86eA5A
Message-ID: <CADwFkmnfQTTPkzsFLnELGuE0b28OC1uGP96bFsKkD+PMZnMV_w@HIDDEN>
Subject: Re: bug#72104: [PATCH] xwidget: Fix xwidget-at misinterpreting
 non-xwidget text-properties
To: George Huebner <george@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72104
Cc: Po Lu <luangruo@HIDDEN>, 72104 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

forcemerge 72848 72104
thanks

George Huebner <george@HIDDEN> writes:

> This patch was already accepted in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72848.
> Thank you for following up though!

OK, thanks.  I'm therefore merging these two bugs.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#72104; Package emacs. Full text available.

Message received at 72104 <at> debbugs.gnu.org:


Received: (at 72104) by debbugs.gnu.org; 24 Feb 2025 20:24:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 24 15:24:02 2025
Received: from localhost ([127.0.0.1]:42902 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tmezh-0000KU-VU
	for submit <at> debbugs.gnu.org; Mon, 24 Feb 2025 15:24:02 -0500
Received: from mail-qt1-f175.google.com ([209.85.160.175]:56585)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <ghubs25@HIDDEN>) id 1tmezf-0000K4-Tu
 for 72104 <at> debbugs.gnu.org; Mon, 24 Feb 2025 15:24:00 -0500
Received: by mail-qt1-f175.google.com with SMTP id
 d75a77b69052e-471f16f4b73so44008481cf.1
 for <72104 <at> debbugs.gnu.org>; Mon, 24 Feb 2025 12:23:59 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740428634; x=1741033434;
 h=content-transfer-encoding:mime-version:message-id:date:user-agent
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=34ucyhyPJJGMxhzqygYV72xVKuBdBjnOq5qH5lafPEY=;
 b=LsCIRbPY859Ry9XJbZBRRf+kKwFeZaz+Rgoknrf92HlvVt6gALN0FNUhUhb2od5MnT
 zpDiQjIqlz6Xt9DkSHaooetK8DdzeTPYzD/E3/zg/mK+vTL7o5cBE1Es0RMs4ao6vnw9
 Wp3VDEEpbiVrcl9i02E5rgM+1O4ZJHDEVZhPonFehcNdb6aSjw6EE+u/CzjBPFVhajbo
 dGTL5HTOZveh02ovxBE5aOAvx8SZId3tuPdEthkyZV7OZUOgOuYgNcTWPsCZ5pEjoSPP
 9et5BymseO7vg3rxBrzNqkM+VB/TPHapHM6qG2eMmqxaAS28W0HNUt/1CEUPp3B8mojW
 stbA==
X-Gm-Message-State: AOJu0YwP7bLlaTl7UKF4tagOnqqPd59q5sS5g2UeCFFhcXi5Zfaqwwhg
 NaLj79Pci1h6WRg0XyveQqc1Ma9SzJm32u1MXDgSFvNu2xO5rBTn
X-Gm-Gg: ASbGncvJEp0vOgyRGaLOKEUxevojFq2dMik/Ni7Q2fJuPlBUifYVkjOV3+8+QRuN45q
 x63z0oAF+9M61gGqvkx3y0+xPR6F1DYdKQFpdivH9yulkt5rT194f9U30FayNr1mwPO6I6j3qqp
 iFbiXxZ1T0OKWWZiR3JUQbf0KWCwJBo2gs53oLOH+kMqWdxZZtH2nDUPyg7UVRDtmqSXjPyeKpb
 Zx+uF0ieYrPz45x0j52Oo7Y8n0jPYhwXOV1CeiEZpnEzUjI9P1VRtqXWjNL6gfpFlfZufWLAV9O
 5q2wVn7I7Jqj0tNAqPzzBV+YU2ZZbYisze0x6iIIHDqI
X-Google-Smtp-Source: AGHT+IFEdg8m8kAjDyepvX68n09Qguybfz+klP8LuRxoMIG4bwACq9NT3eB7JP8nOuL0fpkz5uI0XA==
X-Received: by 2002:ac8:58c3:0:b0:472:744:e26d with SMTP id
 d75a77b69052e-47222944f84mr208267251cf.39.1740428634146; 
 Mon, 24 Feb 2025 12:23:54 -0800 (PST)
Received: from localhost (s-29-3.flex.volo.net. [76.191.29.3])
 by smtp.gmail.com with ESMTPSA id
 d75a77b69052e-47378083893sm458641cf.72.2025.02.24.12.23.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 24 Feb 2025 12:23:53 -0800 (PST)
From: George Huebner <george@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#72104: [PATCH] xwidget: Fix xwidget-at misinterpreting
 non-xwidget text-properties
In-Reply-To: <CADwFkmkLo1Y6R-F5=rT8y=+z9=ykzu=ECYu1dd0FRDPOzOSZ-Q@HIDDEN>
 (Stefan Kangas's message of "Sun, 23 Feb 2025 00:51:58 +0000")
References: <m2r0bw30g4.fsf@HIDDEN>
 <CADwFkmkLo1Y6R-F5=rT8y=+z9=ykzu=ECYu1dd0FRDPOzOSZ-Q@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 29.1
Date: Mon, 24 Feb 2025 14:23:52 -0600
Message-ID: <m27c5fxfaf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 72104
Cc: Po Lu <luangruo@HIDDEN>, 72104 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

This patch was already accepted in=20
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72848.
Thank you for following up though!

On Sat, Feb 22, 2025 at 18:51:58 EST Stefan Kangas wrote:

> George Huebner <george@HIDDEN> writes:
>
>> xwidget-at assumes the text-property at `point-min` either=20
>> doesn't exist or is
>> an xwidget, and can improperly access fields. This patch just=20
>> returns nil if the
>> text-property isn't an xwidget.
>>
>> This is definitely an edge case; I use a package called=20
>> org-modern where
>> headlines are formatted with text-properties, which is how I=20
>> found the bug:
>> Debugger entered--Lisp error: (wrong-type-argument listp #("=E2=97=89"=20
>> 0 1 (face
>> org-modern-symbol)))
>>  xwidget-at(1)
>>  xwidget-webkit-current-session()
>
> Po Lu, any comments on this patch?
>
>>>From 48a662563bc6e7c5bc63dc63da4e0c36909b6cc2 Mon Sep 17=20
>>>00:00:00 2001
>> From: George Huebner <george@HIDDEN>
>> Date: Sun, 14 Jul 2024 01:46:07 -0500
>> Subject: [PATCH] xwidget: Fix xwidget-at misinterpreting=20
>> non-xwidget
>>  text-properties
>>
>> xwidget-open wrongly assumes the the text-property at=20
>> min-position is an
>> xwidget, if it exists; the fix is just returning nil if the
>> text-property isn't an xwidget.
>> ---
>>  lisp/xwidget.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/xwidget.el b/lisp/xwidget.el
>> index bf5987d..c5a84db 100644
>> --- a/lisp/xwidget.el
>> +++ b/lisp/xwidget.el
>> @@ -81,7 +81,7 @@ This returns the result of `make-xwidget'."
>>  (defun xwidget-at (pos)
>>    "Return xwidget at POS."
>>    (let* ((disp (get-text-property pos 'display))
>> -         (xw (car (cdr (cdr disp)))))
>> +         (xw (ignore-errors (car (cdr (cdr disp))))))
>>      (when (xwidget-live-p xw) xw)))
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#72104; Package emacs. Full text available.

Message received at 72104 <at> debbugs.gnu.org:


Received: (at 72104) by debbugs.gnu.org; 23 Feb 2025 00:52:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 19:52:08 2025
Received: from localhost ([127.0.0.1]:58052 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tm0E4-0000RA-7w
	for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 19:52:08 -0500
Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:47350)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tm0E1-0000QW-6B
 for 72104 <at> debbugs.gnu.org; Sat, 22 Feb 2025 19:52:05 -0500
Received: by mail-ed1-x535.google.com with SMTP id
 4fb4d7f45d1cf-5e0573a84fcso4574649a12.2
 for <72104 <at> debbugs.gnu.org>; Sat, 22 Feb 2025 16:52:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740271919; x=1740876719; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=2w3pn8jF9GzNCMWi3Ska/ocsGCTZDbkz2srwctPTfus=;
 b=UmXEBbyD7q2lgWiD/j2DsHEt5e6FqF91m7XF1/T5ojnJlBwN6gINkmk/pxsP+Fko6c
 D7r/aMZfjb5kWYRmdvefcP1KHEbku2h63KdtCvNJWN79dQUJLdo31XUJQpN5c2hjvEZy
 TQZH17RDZxhgowWKeHHQCs12amDjHFxYZ2g4PDmi/hnn9NYZOFYQxv4F4KUa9PJjap/k
 CyELml6NajflB3CyadGGhNAuoJwMwiSs8MfYZGadUVX38kSxGbDYZSIom33mph34oHpI
 B0cLtEivnL9hALoCzqo45z3rFWdmRbHWK+h4QDz63kLV/2i+YH6qXlcTyRAthRdUffKm
 WV3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740271919; x=1740876719;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=2w3pn8jF9GzNCMWi3Ska/ocsGCTZDbkz2srwctPTfus=;
 b=upxXSVYYO0LLaU1l8SQBRDTyRnYB/rZgauUTazyGwvFdvHj1hMauEKZIY9weiDDW39
 oGJN5eQchm6tUY+OMow+/iSyjQKFFZpdx1xXJ7x8wf0sFghkbdmsMMUvWM9MQQ5ZLQta
 lTPh1S2uY8s8IIY+DkkWbXMK0EGPFf7eD+44xZsUEyIhcyKxslLCyKEWz4Lwk/y/4YBp
 4MRs6fVzPNGY/rv6Gh9Wn38FIi/rExRuAD0myWpzDJ5oukJrKfSAuFNpZBArO8R4Sslc
 EP83AcwqxTzPYmo5vLHMDMQ3qsH9JNy+bB9lQO5afA/fnvI454sXxONV0CVEWmMT9bq8
 vi7Q==
X-Gm-Message-State: AOJu0YwdvAw0kOtp3fTMVG5rg8sDVJWyCYKo/qqL0IZhTPHrPWU47QQ9
 dLJlC3YkABolLAIxXGp04uNP7SqTHg9zskKqWSJV6IhXzmaJoVoUbc4VmT0et6PYHTr3/Dm0Zeu
 8Klc2bU213jjWgMkg9Lyk7uTipzP6gSspsGI=
X-Gm-Gg: ASbGnct11scVM7sYYiMVX7i7L7aNBwebLGOoTxjS5XrCGOMVcJnuueO3RxkUnUzbjnc
 gact+8jNYynf/5y7/z9iambVgGBptvHR4fByyCRKW+myCSn0/rKXDoQb52kGf6OfBnhwrU8HkGW
 zvrDzOiHk2
X-Google-Smtp-Source: AGHT+IHsKJ8If68VY9v78iHyS0/8XZdJCeLZ94H9NErWGsHVfk5qWnHwqHHy202p+jVYDCmqR/OBXUREO/m64prLrYQ=
X-Received: by 2002:a05:6402:4617:b0:5e0:4c2d:b827 with SMTP id
 4fb4d7f45d1cf-5e0b7235b41mr6828893a12.31.1740271918900; Sat, 22 Feb 2025
 16:51:58 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 23 Feb 2025 00:51:58 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <m2r0bw30g4.fsf@HIDDEN>
References: <m2r0bw30g4.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sun, 23 Feb 2025 00:51:58 +0000
X-Gm-Features: AWEUYZlmCFtlDKItPQzGUcR7AXbQ5_vaT1xNwnNBJeV0iJeOp85f2VENyPCz-0w
Message-ID: <CADwFkmkLo1Y6R-F5=rT8y=+z9=ykzu=ECYu1dd0FRDPOzOSZ-Q@HIDDEN>
Subject: Re: bug#72104: [PATCH] xwidget: Fix xwidget-at misinterpreting
 non-xwidget text-properties
To: George Huebner <george@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72104
Cc: Po Lu <luangruo@HIDDEN>, 72104 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

George Huebner <george@HIDDEN> writes:

> xwidget-at assumes the text-property at `point-min` either doesn't exist =
or is
> an xwidget, and can improperly access fields. This patch just returns nil=
 if the
> text-property isn't an xwidget.
>
> This is definitely an edge case; I use a package called org-modern where
> headlines are formatted with text-properties, which is how I found the bu=
g:
> Debugger entered--Lisp error: (wrong-type-argument listp #("=E2=97=89" 0 =
1 (face
> org-modern-symbol)))
>  xwidget-at(1)
>  xwidget-webkit-current-session()

Po Lu, any comments on this patch?

>>From 48a662563bc6e7c5bc63dc63da4e0c36909b6cc2 Mon Sep 17 00:00:00 2001
> From: George Huebner <george@HIDDEN>
> Date: Sun, 14 Jul 2024 01:46:07 -0500
> Subject: [PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget
>  text-properties
>
> xwidget-open wrongly assumes the the text-property at min-position is an
> xwidget, if it exists; the fix is just returning nil if the
> text-property isn't an xwidget.
> ---
>  lisp/xwidget.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/xwidget.el b/lisp/xwidget.el
> index bf5987d..c5a84db 100644
> --- a/lisp/xwidget.el
> +++ b/lisp/xwidget.el
> @@ -81,7 +81,7 @@ This returns the result of `make-xwidget'."
>  (defun xwidget-at (pos)
>    "Return xwidget at POS."
>    (let* ((disp (get-text-property pos 'display))
> -         (xw (car (cdr (cdr disp)))))
> +         (xw (ignore-errors (car (cdr (cdr disp))))))
>      (when (xwidget-live-p xw) xw)))
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#72104; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 Jul 2024 07:19:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 14 03:19:33 2024
Received: from localhost ([127.0.0.1]:57059 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sStW9-0002zW-3d
	for submit <at> debbugs.gnu.org; Sun, 14 Jul 2024 03:19:33 -0400
Received: from lists.gnu.org ([209.51.188.17]:45444)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ghubs25@HIDDEN>) id 1sStW6-0002zN-7D
 for submit <at> debbugs.gnu.org; Sun, 14 Jul 2024 03:19:32 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ghubs25@HIDDEN>) id 1sStW4-000422-MG
 for bug-gnu-emacs@HIDDEN; Sun, 14 Jul 2024 03:19:28 -0400
Received: from mail-qv1-f49.google.com ([209.85.219.49])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <ghubs25@HIDDEN>) id 1sStW2-0005XW-UU
 for bug-gnu-emacs@HIDDEN; Sun, 14 Jul 2024 03:19:28 -0400
Received: by mail-qv1-f49.google.com with SMTP id
 6a1803df08f44-6b5db7936b3so20384106d6.1
 for <bug-gnu-emacs@HIDDEN>; Sun, 14 Jul 2024 00:19:26 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1720941565; x=1721546365;
 h=mime-version:message-id:date:subject:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=Yz6NhucEQm6pzXx+lHCxMl0Sgi1ITLYokOqhP3b/wp0=;
 b=C7yV3ZSfbJGqtICW0mUHDqJRT17EmELwW/x7Kwu/Px1hYcoHwM76GECBvywlm9o9oI
 vYRLtTNpy2d2tYbErQ7Lq/dQEsS6sN3Xzw7IhnrRU+MH7nwNkPab/4SZAtqKF/Lm/WyT
 TuvO+hnDcJMqY01KXoIi6Xg/yp4O9i1tXgRC8maHbFFjb2hXotyN379/APTGOytusubk
 meU+wZd8lyVObcYoH3AjwaZwimYhbNCROqWUCP+xSrU1YydxLa0RB/b0JVQrhRfJkKvP
 HGOtCrwSeNYLdgGQyuhWl580RdStm/5VltXxC/4SpZPAWooQC0dzn9/Aowr6L3gjtlja
 PBJQ==
X-Gm-Message-State: AOJu0YxLcgM1Xs/GY439he0aNdOOXWXHKGum4xud1s6xcqWyNMbZwGwR
 9WTl7TpPHNxj7MGqF1OZ70oq91BKcB/gCYOT8hrG1YVd4s9bSyU/jNpRzg==
X-Google-Smtp-Source: AGHT+IFbguDnFAXH7IRN0iYYi/cVTVcadEnzZhesitMS7N4OJkncz072iXVggt23GX0aW2mTH/4BxA==
X-Received: by 2002:a05:6214:f01:b0:6b0:86f9:64ad with SMTP id
 6a1803df08f44-6b61c1ddc08mr226678346d6.52.1720941565309; 
 Sun, 14 Jul 2024 00:19:25 -0700 (PDT)
Received: from localhost (s-29-93.flex.volo.net. [76.191.29.93])
 by smtp.gmail.com with ESMTPSA id
 6a1803df08f44-6b761a10d8fsm11082256d6.99.2024.07.14.00.19.24
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 14 Jul 2024 00:19:25 -0700 (PDT)
From: George Huebner <george@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget
 text-properties
Date: Sun, 14 Jul 2024 02:19:23 -0500
Message-ID: <m2r0bw30g4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=209.85.219.49; envelope-from=ghubs25@HIDDEN;
 helo=mail-qv1-f49.google.com
X-Spam_score_int: -15
X-Spam_score: -1.6
X-Spam_bar: -
X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25,
 FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001,
 HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Tags: patch

xwidget-at assumes the text-property at `point-min` either doesn't=20
exist or is an xwidget, and can improperly access fields. This=20
patch just returns nil if the text-property isn't an xwidget.

This is definitely an edge case; I use a package called org-modern=20
where headlines are formatted with text-properties, which is how I=20
found the bug:
Debugger entered--Lisp error: (wrong-type-argument listp #("=E2=97=89" 0 1=
=20
(face org-modern-symbol)))
  xwidget-at(1)
  xwidget-webkit-current-session()


In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.4.0, Carbon=20
Version
170 AppKit 2487.5)
Windowing system distributor 'Apple Inc.', version 14.4.0
System Description:  macOS 14.4

Configured using:
 'configure
 --prefix=3D/nix/store/ismv7jzf3hcqziq5bpjfs54zd4qfjjn7-emacs-mac-macport-2=
9.1
 --disable-build-details --with-modules --without-gif=20
 --without-jpeg
 --without-png --without-tiff --without-x --without-xpm
 '--enable-mac-app=3D$$out/Applications' --with-gnutls --with-mac
 --with-xml2 --without-ns --with-compress-install
 --with-toolkit-scroll-bars --with-native-compilation
 --without-imagemagick --with-mailutils --without-small-ja-dic
 --with-tree-sitter --without-xinput2 --without-xwidgets=20
 --without-dbus
 --without-selinux --with-xwidgets'

--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
 filename=0001-xwidget-Fix-xwidget-at-misinterpreting-non-xwidget-t.patch

From 48a662563bc6e7c5bc63dc63da4e0c36909b6cc2 Mon Sep 17 00:00:00 2001
From: George Huebner <george@HIDDEN>
Date: Sun, 14 Jul 2024 01:46:07 -0500
Subject: [PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget
 text-properties

xwidget-open wrongly assumes the the text-property at min-position is an
xwidget, if it exists; the fix is just returning nil if the
text-property isn't an xwidget.
---
 lisp/xwidget.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index bf5987d..c5a84db 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -81,7 +81,7 @@ This returns the result of `make-xwidget'."
 (defun xwidget-at (pos)
   "Return xwidget at POS."
   (let* ((disp (get-text-property pos 'display))
-         (xw (car (cdr (cdr disp)))))
+         (xw (ignore-errors (car (cdr (cdr disp))))))
     (when (xwidget-live-p xw) xw)))
 
 
-- 
2.44.1


--=-=-=--
Acknowledgement sent to George Huebner <george@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#72104; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 24 Feb 2025 21:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.