GNU bug report logs - #72130
test-driver.scm produces .trs file with undefined behavior

Previous Next

To reply to this bug, email your comments to 72130 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: bug-guix <at> gnu.org
Cc: Mathieu Lirzin <mthl <at> gnu.org>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: test-driver.scm produces .trs file with undefined behavior
Date: Mon, 15 Jul 2024 23:39:38 +0200

[Message part 1 (text/plain, inline)]

Hello,

currently there are two issues with build-aux/test-driver.scm.

1. :test-global-result: is mistyped as :global-test-result:.
2. Summarizing metadata are outputted on end of each test-group, meaning they
   will be present multiple times, if there is more than one test group.

First is somewhat fine, since, per the manual page, unknown keys are (for now)
ignored.  However second is explicitly stated to be undefined behavior, so it
should be fixed.

I am CC-ing both authors listed in the test-driver.scm, since I have no idea
where the upstream is (it seems to be just copied around between projects?).

You can find fixes for the first (0001) and second (0002) issues attached to
this email.

I am also including two additional patches (0003 refining :test-global-result:
for XPASS as XXX mentioned, 0005 improving support for test group since it was
somewhat lacking) which I consider useful and I have applied them to my local
copy of test-driver.scm file.  Feel free to apply them, or ignore them, as you
see fit.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[0001-build-test-driver.scm-Fix-test-global-result-.trs-me.patch (text/plain, attachment)]

[0002-build-test-driver.scm-Output-singleton-metadata-just.patch (text/plain, attachment)]

[0003-build-test-driver.scm-Refine-the-global-test-result.patch (text/plain, attachment)]

[0005-build-test-driver.scm-Utilize-test-runner-group-path.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.