GNU bug report logs - #72136
[PATCH 0/2] Guard against producing derivations for platforms with no system

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Tue, 16 Jul 2024 08:43:02 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 72136 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#72136; Package guix-patches. (Tue, 16 Jul 2024 08:43:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christopher Baines <mail <at> cbaines.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 16 Jul 2024 08:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Guard against producing derivations for platforms with
 no system
Date: Tue, 16 Jul 2024 09:42:23 +0100
[Message part 1 (text/plain, inline)]
Christopher Baines (2):
  gnu: coreutils-minimal: Don't support targets with no system.
  gnu: bash-minimal: Don't support targets with no system.

 gnu/packages/base.scm | 15 ++++++++++++++-
 gnu/packages/bash.scm | 16 +++++++++++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)
[signature.asc (application/pgp-signature, inline)]

Information forwarded to ludo <at> gnu.org, guix-patches <at> gnu.org:
bug#72136; Package guix-patches. (Tue, 16 Jul 2024 08:46:01 GMT) Full text and rfc822 format available.

Message #8 received at 72136 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 72136 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: coreutils-minimal: Don't support targets with no
 system.
Date: Tue, 16 Jul 2024 09:45:08 +0100
Since I believe coreutils-minimal will fail to build for these targets, this
will catch this early and display a clear message for both this package and
packages using it as an input.

* gnu/packages/base.scm (coreutils-minimal)[native-inputs]: Check the target
if there is one.

Change-Id: Id37cf6ac0b63226261a85a00699dfd06188c1475
---
 gnu/packages/base.scm | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 66c5b7d237..05c3278e2e 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -67,6 +67,7 @@ (define-module (gnu packages base)
   #:use-module (guix utils)
   #:use-module (guix gexp)
   #:use-module (guix packages)
+  #:use-module (guix platform)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
@@ -76,6 +77,8 @@ (define-module (gnu packages base)
   #:use-module (ice-9 optargs)
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-26)
+  #:use-module (srfi srfi-34)
+  #:use-module (srfi srfi-35)
   #:export (glibc
             libc-for-target
             libc-locales-for-target
@@ -537,7 +540,17 @@ (define-public coreutils-minimal
     (inherit coreutils)
     (name "coreutils-minimal")
     (outputs '("out"))
-    (native-inputs '())
+    (native-inputs
+     (begin
+       (let ((target (%current-target-system)))
+         (when target
+           (unless (platform-system (lookup-platform-by-target target))
+             (raise
+              (condition
+               (&package-unsupported-target-error
+                (package this-package)
+                (target target)))))))
+       '()))
     (inputs '())))
 
 (define-public coreutils-8.30

base-commit: bf6ab0e0f5066d999e027a7eb8ecf05db71123ce
-- 
2.45.2





Information forwarded to guix-patches <at> gnu.org:
bug#72136; Package guix-patches. (Tue, 16 Jul 2024 08:46:02 GMT) Full text and rfc822 format available.

Message #11 received at 72136 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 72136 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: bash-minimal: Don't support targets with no system.
Date: Tue, 16 Jul 2024 09:45:09 +0100
Since I believe bash-minimal will fail to build for these targets, this will
catch this early and display a clear message for both this package and
packages using it as an input.

* gnu/packages/base.scm (bash-minimal)[inputs]: Check the target if there is
one.

Change-Id: I3768c7fa05f5375a1227551e2b7ae66a741ef93d
---
 gnu/packages/bash.scm | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
index 9ecec0a484..c29400c1e4 100644
--- a/gnu/packages/bash.scm
+++ b/gnu/packages/bash.scm
@@ -41,6 +41,7 @@ (define-module (gnu packages bash)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages less)
   #:use-module (guix packages)
+  #:use-module (guix platform)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix utils)
@@ -57,6 +58,8 @@ (define-module (gnu packages bash)
 
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-26)
+  #:use-module (srfi srfi-34)
+  #:use-module (srfi srfi-35)
   #:use-module (ice-9 format))
 
 (define (patch-url seqno)
@@ -226,7 +229,18 @@ (define-public bash-minimal
   ;; A stripped-down Bash for non-interactive use.
   (package (inherit bash)
     (name "bash-minimal")
-    (inputs '())                                ; no readline, no curses
+    (inputs
+     (begin
+       (let ((target (%current-target-system)))
+         (when target
+           (unless (platform-system (lookup-platform-by-target target))
+             (raise
+              (condition
+               (&package-unsupported-target-error
+                (package this-package)
+                (target target)))))))
+
+       '()))                            ; no readline, no curses
 
     ;; No "include" output because there's no support for loadable modules.
     (outputs (delete "include" (package-outputs bash)))
-- 
2.45.2





Information forwarded to guix-patches <at> gnu.org:
bug#72136; Package guix-patches. (Thu, 18 Jul 2024 09:37:02 GMT) Full text and rfc822 format available.

Message #14 received at 72136 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 72136 <at> debbugs.gnu.org
Subject: Re: [bug#72136] [PATCH 1/2] gnu: coreutils-minimal: Don't support
 targets with no system.
Date: Thu, 18 Jul 2024 11:33:49 +0200
Hello,

Christopher Baines <mail <at> cbaines.net> skribis:

> Since I believe coreutils-minimal will fail to build for these targets, this
> will catch this early and display a clear message for both this package and
> packages using it as an input.
>
> * gnu/packages/base.scm (coreutils-minimal)[native-inputs]: Check the target
> if there is one.
>
> Change-Id: Id37cf6ac0b63226261a85a00699dfd06188c1475

[...]

> +    (native-inputs
> +     (begin
> +       (let ((target (%current-target-system)))
> +         (when target
> +           (unless (platform-system (lookup-platform-by-target target))
> +             (raise
> +              (condition
> +               (&package-unsupported-target-error
> +                (package this-package)
> +                (target target)))))))
> +       '()))

I understand the rationale, but this raises a few issues IMO:

  1. This is abusing the ‘native-inputs’ field.

  2. It’s the kind of thing that should be purely declarative, much like
     ‘supported-systems’.

  3. So far, we do not keep track of the supported cross-compilation
     targets of each package, and I think it’s probably better that way:
     the set of cross-compilation targets is pretty much open-ended and
     we only check them on a best-effort basis, for select packages
     (typically those listed in ‘packages-to-cross-build’ in (gnu ci)
     and/or ‘etc/release-manifest.scm’).  I think we’d rather not start
     annotating packages for supported cross-compilation target.

That said, the initial problem remains: how can we ensure that the Data
Service does not attempt to compute cross-build derivations that don’t
make sense, such as Coreutils on bare-metal targets like ‘avr’?

My take is that we should bake knowledge about what makes sense to be
tested somewhere.  It could be either arranging so (gnu ci) can be used
by the Data Service (it’s currently used by Cuirass), or
‘etc/release-manifest.scm’, or even just a hard-coded listed of
supported targets—we’re talking about a list of ten triplets or so,
that’s okay.

Or perhaps there’s room for something nicer in (guix platforms), but I
don’t see how we could determine whether a given package is eligible for
a bare-metal target.

Thoughts?

Ludo’.




This bug report was last modified 217 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.