GNU bug report logs - #72138
30.0.50; [PATCH] Fix ring size in comint-read-input-ring

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72138 in the body.
You can then email your comments to 72138 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liu Hui <liuhui1610 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Fix ring size in comint-read-input-ring
Date: Tue, 16 Jul 2024 18:10:00 +0800

[Message part 1 (text/plain, inline)]

Hi,

When comint-read-input-ring reads history to the ring, the global
value of comint-input-ring-size (i.e. 500) is used regardless of the
local value due to the use of temp buffer. For example:

1. HISTSIZE=10 emacs -Q
2. M-x shell

The buffer-local value of comint-input-ring-size is correctly set to
10, but C-c C-l shows 500 commands.

The attached patch fixes the problem that comint-read-input-ring
ignores the buffer-local comint-input-ring-size. Thanks.

[0001-lisp-comint.el-comint-read-input-ring-Fix-ring-size.patch (text/x-patch, attachment)]

Message #10 received at 72138-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: 72138-done <at> debbugs.gnu.org
Subject: Re: bug#72138: 30.0.50;
 [PATCH] Fix ring size in comint-read-input-ring
Date: Sat, 27 Jul 2024 10:13:52 +0300

> From: Liu Hui <liuhui1610 <at> gmail.com>
> Date: Tue, 16 Jul 2024 18:10:00 +0800
> 
> When comint-read-input-ring reads history to the ring, the global
> value of comint-input-ring-size (i.e. 500) is used regardless of the
> local value due to the use of temp buffer. For example:
> 
> 1. HISTSIZE=10 emacs -Q
> 2. M-x shell
> 
> The buffer-local value of comint-input-ring-size is correctly set to
> 10, but C-c C-l shows 500 commands.
> 
> The attached patch fixes the problem that comint-read-input-ring
> ignores the buffer-local comint-input-ring-size. Thanks.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.