GNU logs - #72156, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72156: 31.0.50; defcustom set issue
Resent-From: Ergus <spacibba@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Jul 2024 12:10:01 +0000
Resent-Message-ID: <handler.72156.B.172121816229198 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72156 <at> debbugs.gnu.org
From: Ergus <spacibba@HIDDEN>
Date: Wed, 17 Jul 2024 14:08:59 +0200
Message-ID: <87le206x0k.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
References: <87le206x0k.fsf.ref@HIDDEN>
Content-Length: 8957
Received-SPF: pass client-ip=74.6.135.123; envelope-from=spacibba@HIDDEN;
 helo=sonic310-13.consmr.mail.bf2.yahoo.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)



Hi:

I have this defcustom:

```
(defcustom gtags-mode-features '(control meta)
  "HELLO WORLD"
  :type '(set (const control)
              (const meta)
              (const shift)
              (const hyper)
              (const super)
              (const alt)))
```

When I try the customize-variable I get this:

```
Hide Gtags Mode Features:
Set:
[X] control
[X] meta
[ ] shift
[ ] hyper
[ ] super
[ ] alt
   [ State ]: EDITED, shown value does not take effect until you set or save it.
   HELLO WORLD
Groups: [Gtags Mode]
```

But, if I do the next change and save


```
Hide Gtags Mode Features:
Set:
[X] control
[X] meta
[X] shift
[ ] hyper
[ ] super
[ ] alt
   [ State ]: EDITED, shown value does not take effect until you set or save it.
   HELLO WORLD
Groups: [Gtags Mode]
```

The customize variable value saved is:

'(gtags-mode-features3 '(shift))

it only saved the "new" value and ignores the previous
existing ones.

When I restart and check the variable's value I get as expected '(shift)
and lost the control and meta.

Going to customize-variable again I get:

```
Hide Gtags Mode Features:
Set:
[ ] control
[ ] meta
[X] shift
[ ] hyper
[ ] super
[ ] alt
   [ State ]: EDITED, shown value does not take effect until you set or save it.
   HELLO WORLD
Groups: [Gtags Mode]
```

Consistent with the variable value, but inconsistent with what was
actually saved before.

IF instead of selecting a new value I un-select some, then variable
saves nil and will be nil.





In GNU Emacs 31.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.0) of 2024-07-17 built on RTX
Repository revision: 438a7da5530a32d20de769e3450e4fc3a74e9236
Repository branch: project
System Description: Arch Linux

Configured using:
 'configure --prefix=/home/ergo/.local/ --with-mailutils --with-pgtk
 --with-modules --with-cairo --with-harfbuzz
 --with-native-compilation=aot
 '--program-transform-name=s/^ctags$/ctags.emacs/''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK
PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP XIM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Custom

Minor modes in effect:
  fancy-compilation-mode: t
  global-auto-revert-mode: t
  diff-hl-margin-mode: t
  corfu-terminal-mode: t
  global-corfu-mode: t
  corfu-mode: t
  project-multi-mode: t
  gtags-mode: t
  repeat-mode: t
  xterm-mouse-mode: t
  xclip-mode: t
  override-global-mode: t
  winner-mode: t
  save-place-mode: t
  delete-selection-mode: t
  savehist-mode: t
  global-display-fill-column-indicator-mode: t
  display-fill-column-indicator-mode: t
  global-display-line-numbers-mode: t
  display-line-numbers-mode: t
  which-key-mode: t
  show-paren-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  context-menu-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/mnt/casa/gits/emacs_clones/cuda-mode/cuda-mode hides /home/ergo/.config/emacs/elpa/cuda-mode-20240716.1936/cuda-mode
/mnt/casa/gits/emacs_clones/gtags-mode/gtags-mode hides /home/ergo/.config/emacs/elpa/gtags-mode-1.8/gtags-mode
/home/ergo/.config/emacs/elpa/transient-20240713.2102/transient hides /home/ergo/.local/share/emacs/31.0.50/lisp/transient

Features:
(shadow sort fancy-compilation compile comint ansi-osc ansi-color
comp-run comp-common mail-extr emacsbug message mailcap yank-media puny
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util
text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils time-date tabify help-fns radix-tree
cus-edit pp cus-start cus-load wid-edit find-func autorevert filenotify
ffap thingatpt url-parse auth-source eieio eieio-core icons
password-cache json map url-vars vc-git elec-pair whitespace
flyspell-correct flyspell ispell completion-preview diff-hl-margin
diff-hl-dired citre-lang-fileref citre-tags citre-ctags citre-readtags
citre-readtags-tables citre-backend-interface citre-common-tag rx
citre-common-util dired-x dired dired-loaddefs diff-hl log-view
pcvs-util vc-dir ewoc vc vc-dispatcher diff-mode track-changes
corfu-terminal popon corfu project-multi-mode gtags-mode cl-macs subr-x
files-x xref project term/tmux term/xterm xterm init repeat cape compat
use-package-ensure use-package-diminish xt-mouse xclip edmacro kmacro
byte-opt gv use-package-bind-key bind-key cl-extra help-mode
simple-16-theme winner ring saveplace delsel savehist easy-mmode
display-fill-column-indicator display-line-numbers diminish which-key
cl-seq use-package-core cl-loaddefs cl-lib bytecomp byte-compile
disp-table info ac-emoji-autoloads ac-haskell-process-autoloads
ac-html-autoloads arduino-cli-mode-autoloads auctex-autoloads tex-site
auto-complete-autoloads avy-zap-autoloads avy-autoloads
better-shell-autoloads caml-autoloads cape-autoloads citre-autoloads
clang-format-autoloads cobol-mode-autoloads compile-multi-autoloads
corfu-terminal-autoloads corfu-autoloads crdt-autoloads
csv-mode-autoloads cuda-mode-autoloads d-mode-autoloads
deadgrep-autoloads debbugs-autoloads diff-hl-autoloads
diminish-autoloads dired-sidebar-autoloads dired-subtree-autoloads
dired-hacks-utils-autoloads dumb-jump-autoloads e2ansi-autoloads
emamux-autoloads esup-autoloads evil-collection-autoloads
annalist-autoloads evil-leader-autoloads evil-autoloads
face-explorer-autoloads fancy-compilation-autoloads flx-autoloads
flycheck-julia-autoloads flycheck-rust-autoloads flycheck-autoloads
flymake-nasm-autoloads flymake-quickdef-autoloads
flyspell-correct-autoloads git-modes-autoloads git-timemachine-autoloads
gnuplot-autoloads google-c-style-autoloads goto-chg-autoloads
groovy-mode-autoloads gtags-mode-autoloads haskell-mode-autoloads
highlight-indent-guides-autoloads i3wm-config-mode-autoloads
ibuffer-sidebar-autoloads iedit-autoloads imenu-list-autoloads
julia-ts-mode-autoloads julia-mode-autoloads languagetool-autoloads
lice-autoloads lorem-ipsum-autoloads lua-mode-autoloads magit-autoloads
git-commit-autoloads magit-section-autoloads markdown-mode-autoloads
modern-cpp-font-lock-autoloads move-dup-autoloads
multiple-cursors-autoloads mutt-mode-autoloads nasm-mode-autoloads
neotree-autoloads nftables-mode-autoloads nginx-mode-autoloads
notmuch-autoloads objed-autoloads opencl-mode-autoloads
paradox-autoloads phi-search-autoloads pkg-info-autoloads epl-autoloads
pkgbuild-mode-autoloads platformio-mode-autoloads async-autoloads
popon-autoloads popup-autoloads projectile-autoloads
projection-autoloads protobuf-mode-autoloads protobuf-ts-mode-autoloads
ptemplate-templates-autoloads ptemplate-autoloads scopeline-autoloads
shell-command+-autoloads slime-autoloads macrostep-autoloads
sphinx-mode-autoloads f-autoloads dash-autoloads s-autoloads
spinner-autoloads ssh-config-mode-autoloads string-inflection-autoloads
sudo-edit-autoloads systemd-autoloads tmux-mode-autoloads
transient-autoloads tsc-autoloads urgrep-autoloads vdiff-autoloads
hydra-autoloads lv-autoloads vterm-toggle-autoloads vterm-autoloads
vundo-autoloads with-editor-autoloads xclip-autoloads
yasnippet-snippets-autoloads yasnippet-autoloads early-init rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win
term/common-win touch-screen pgtk-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo gtk pgtk
lcms2 multi-tty move-toolbar make-network-process native-compile emacs)

Memory information:
((conses 16 218529 26550) (symbols 48 17046 3) (strings 32 56773 7397)
 (string-bytes 1 1882457) (vectors 16 20651)
 (vector-slots 8 239085 7886) (floats 8 102 151) (intervals 56 1573 0)
 (buffers 992 18))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ergus <spacibba@HIDDEN>
Subject: bug#72156: Acknowledgement (31.0.50; defcustom set issue)
Message-ID: <handler.72156.B.172121816229198.ack <at> debbugs.gnu.org>
References: <87le206x0k.fsf@HIDDEN>
X-Gnu-PR-Message: ack 72156
X-Gnu-PR-Package: emacs
Reply-To: 72156 <at> debbugs.gnu.org
Date: Wed, 17 Jul 2024 12:10:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 72156 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72156: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72156
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72156: 31.0.50; defcustom set issue
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 20 Jul 2024 08:51:01 +0000
Resent-Message-ID: <handler.72156.B72156.172146545924918 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ergus <spacibba@HIDDEN>, Mauro Aranda <maurooaranda@HIDDEN>
Cc: 72156 <at> debbugs.gnu.org
Date: Sat, 20 Jul 2024 11:50:47 +0300
Message-Id: <86le1we9aw.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87le206x0k.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
References: <87le206x0k.fsf.ref@HIDDEN> <87le206x0k.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Wed, 17 Jul 2024 14:08:59 +0200
> From:  Ergus via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> I have this defcustom:
> 
> ```
> (defcustom gtags-mode-features '(control meta)
>   "HELLO WORLD"
>   :type '(set (const control)
>               (const meta)
>               (const shift)
>               (const hyper)
>               (const super)
>               (const alt)))
> ```
> 
> When I try the customize-variable I get this:
> 
> ```
> Hide Gtags Mode Features:
> Set:
> [X] control
> [X] meta
> [ ] shift
> [ ] hyper
> [ ] super
> [ ] alt
>    [ State ]: EDITED, shown value does not take effect until you set or save it.
>    HELLO WORLD
> Groups: [Gtags Mode]
> ```
> 
> But, if I do the next change and save
> 
> 
> ```
> Hide Gtags Mode Features:
> Set:
> [X] control
> [X] meta
> [X] shift
> [ ] hyper
> [ ] super
> [ ] alt
>    [ State ]: EDITED, shown value does not take effect until you set or save it.
>    HELLO WORLD
> Groups: [Gtags Mode]
> ```
> 
> The customize variable value saved is:
> 
> '(gtags-mode-features3 '(shift))
> 
> it only saved the "new" value and ignores the previous
> existing ones.
> 
> When I restart and check the variable's value I get as expected '(shift)
> and lost the control and meta.
> 
> Going to customize-variable again I get:
> 
> ```
> Hide Gtags Mode Features:
> Set:
> [ ] control
> [ ] meta
> [X] shift
> [ ] hyper
> [ ] super
> [ ] alt
>    [ State ]: EDITED, shown value does not take effect until you set or save it.
>    HELLO WORLD
> Groups: [Gtags Mode]
> ```
> 
> Consistent with the variable value, but inconsistent with what was
> actually saved before.
> 
> IF instead of selecting a new value I un-select some, then variable
> saves nil and will be nil.

This seems to be some bug in handling the 'set' type of defcustoms.  I
see the same problem when customizing completions-merging-modes from
completion.el.  Perhaps Mauro (CC'ed) could chime in and suggest how
to solve this.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72156: 31.0.50; defcustom set issue
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 04 Aug 2024 07:40:01 +0000
Resent-Message-ID: <handler.72156.B72156.172275715515947 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: spacibba@HIDDEN, maurooaranda@HIDDEN
Cc: 72156 <at> debbugs.gnu.org, Stephen Berman <stephen.berman@HIDDEN>
Date: Sun, 04 Aug 2024 10:38:42 +0300
Message-Id: <86bk28u48t.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86le1we9aw.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 20
 Jul 2024 11:50:47 +0300)
References: <87le206x0k.fsf.ref@HIDDEN> <87le206x0k.fsf@HIDDEN>
 <86le1we9aw.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

merge 72156 72404
thanks

> Cc: 72156 <at> debbugs.gnu.org
> Date: Sat, 20 Jul 2024 11:50:47 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > Date: Wed, 17 Jul 2024 14:08:59 +0200
> > From:  Ergus via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> > 
> > I have this defcustom:
> > 
> > ```
> > (defcustom gtags-mode-features '(control meta)
> >   "HELLO WORLD"
> >   :type '(set (const control)
> >               (const meta)
> >               (const shift)
> >               (const hyper)
> >               (const super)
> >               (const alt)))
> > ```
> > 
> > When I try the customize-variable I get this:
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [X] control
> > [X] meta
> > [ ] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > But, if I do the next change and save
> > 
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [X] control
> > [X] meta
> > [X] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > The customize variable value saved is:
> > 
> > '(gtags-mode-features3 '(shift))
> > 
> > it only saved the "new" value and ignores the previous
> > existing ones.
> > 
> > When I restart and check the variable's value I get as expected '(shift)
> > and lost the control and meta.
> > 
> > Going to customize-variable again I get:
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [ ] control
> > [ ] meta
> > [X] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > Consistent with the variable value, but inconsistent with what was
> > actually saved before.
> > 
> > IF instead of selecting a new value I un-select some, then variable
> > saves nil and will be nil.
> 
> This seems to be some bug in handling the 'set' type of defcustoms.  I
> see the same problem when customizing completions-merging-modes from
> completion.el.  Perhaps Mauro (CC'ed) could chime in and suggest how
> to solve this.

This actually seems to be the same problem as bug#72404, since the fix
proposed by Stephen there fixes this one as well.  So I'm merging them.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 4 Aug 2024 07:39:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 04 03:39:15 2024
Received: from localhost ([127.0.0.1]:55348 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1saVpj-00049A-0r
	for submit <at> debbugs.gnu.org; Sun, 04 Aug 2024 03:39:15 -0400
Received: from eggs.gnu.org ([209.51.188.92]:36154)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>)
 id 1saVpg-00048a-Dp; Sun, 04 Aug 2024 03:39:13 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1saVpF-0006sI-Ar; Sun, 04 Aug 2024 03:38:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=v1o6ioM0VtfFyZzgoC6hgaatW3wFyAHnDNIEPkNfFXE=; b=eL44wtJqrhPo
 nEbEqbKxI2nmaO8wbunhZrd+1pfN15FmJaan867SlqsarGnR2RxmSIU/kpyxlz+d8pkwbsciZjIf5
 WkfLQ5IEhxiPzJWym5VgLJEKpgvtxZB2xkCBEPCpgskCqp8PA1G1eZjgkReeJ9S2ltTXKbp9XG1Uw
 MTdMQiMItXDFjLh0m3INVSdpdj2lEJc8aMbIPLNfy8ebA8h3TLlQb7/1jk5Dqr3s19h7Y3EMWJFO4
 CJqQfmD7VrDxRT0QAEGNTUkcbauhwn+BQ6yYRjWxyGMJ+8DSIKr+krlUhcv0jVqb7j/sGljkPgZBo
 rUNM/Asa4l2N61FlUIpV7Q==;
Date: Sun, 04 Aug 2024 10:38:42 +0300
Message-Id: <86bk28u48t.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: spacibba@HIDDEN, maurooaranda@HIDDEN
In-Reply-To: <86le1we9aw.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 20
 Jul 2024 11:50:47 +0300)
Subject: Re: bug#72156: 31.0.50; defcustom set issue
References: <87le206x0k.fsf.ref@HIDDEN> <87le206x0k.fsf@HIDDEN>
 <86le1we9aw.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
Cc: 72156 <at> debbugs.gnu.org, Stephen Berman <stephen.berman@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

merge 72156 72404
thanks

> Cc: 72156 <at> debbugs.gnu.org
> Date: Sat, 20 Jul 2024 11:50:47 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > Date: Wed, 17 Jul 2024 14:08:59 +0200
> > From:  Ergus via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> > 
> > I have this defcustom:
> > 
> > ```
> > (defcustom gtags-mode-features '(control meta)
> >   "HELLO WORLD"
> >   :type '(set (const control)
> >               (const meta)
> >               (const shift)
> >               (const hyper)
> >               (const super)
> >               (const alt)))
> > ```
> > 
> > When I try the customize-variable I get this:
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [X] control
> > [X] meta
> > [ ] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > But, if I do the next change and save
> > 
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [X] control
> > [X] meta
> > [X] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > The customize variable value saved is:
> > 
> > '(gtags-mode-features3 '(shift))
> > 
> > it only saved the "new" value and ignores the previous
> > existing ones.
> > 
> > When I restart and check the variable's value I get as expected '(shift)
> > and lost the control and meta.
> > 
> > Going to customize-variable again I get:
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [ ] control
> > [ ] meta
> > [X] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > Consistent with the variable value, but inconsistent with what was
> > actually saved before.
> > 
> > IF instead of selecting a new value I un-select some, then variable
> > saves nil and will be nil.
> 
> This seems to be some bug in handling the 'set' type of defcustoms.  I
> see the same problem when customizing completions-merging-modes from
> completion.el.  Perhaps Mauro (CC'ed) could chime in and suggest how
> to solve this.

This actually seems to be the same problem as bug#72404, since the fix
proposed by Stephen there fixes this one as well.  So I'm merging them.

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.