GNU bug report logs - #72180
[PATCH 0/2] gnu: mpv: Update to 0.38.0 and include sixel support.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72180 in the body.
You can then email your comments to 72180 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Laparie <matf <at> disr.it>
To: guix-patches <at> gnu.org
Cc: Mathieu Laparie <matf <at> disr.it>
Subject: [PATCH 0/2] gnu: mpv: Update to 0.38.0 and include sixel support.
Date: Thu, 18 Jul 2024 19:55:22 +0200

I needed sixel support in mpv and noticed our package did not include it, and updated to 0.38.0 while I was at it. This inmplied upgrading libplacebo to 6.338.2, but 7.349.0 is available and works too, so I jumped to that version. mpv 0.38.0 comes with a number of improvements on top of the sixel support included here, among which better playlist display in terminal (was previously garbled with broken character sequences hardcoded from the OSD), support for --input-commands to run commands at startup, zooming on Ctrl+wheel, etc.

The pkg-config name of libsixel seems to be gdk-pixbuf, and it appeared that adding just libsixel in inputs was not enough for mpv to build with sixel support.

Mathieu Laparie (2):
  gnu: libplacebo: Update to 7.349.0.
  gnu: mpv: Update to 0.38.0, include sixel support.

 gnu/packages/video.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.45.2

Message #8 received at 72180 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Laparie <matf <at> disr.it>
To: 72180 <at> debbugs.gnu.org
Cc: Mathieu Laparie <mathieu.laparie <at> inrae.fr>
Subject: [PATCH 1/2]     gnu: libplacebo: Update to 7.349.0.
Date: Thu, 18 Jul 2024 19:57:48 +0200

From: Mathieu Laparie <mathieu.laparie <at> inrae.fr>

    * gnu/pacakges/video.scm (libplacebo): Update to 7.349.0.
---
 gnu/packages/video.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 8728da1775..c7470284dc 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1549,7 +1549,7 @@ (define-public libmatroska
 (define-public libplacebo
   (package
     (name "libplacebo")
-    (version "6.338.1")
+    (version "7.349.0")
     (source
      (origin
        (method git-fetch)
@@ -1558,7 +1558,7 @@ (define-public libplacebo
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1miqk3gfwah01xkf4a6grwq29im0lfh94gp92y7js855gx3v169m"))))
+        (base32 "1q12yf04z570a2l3vkig2iqm7bgqr90hdxmn78sk2injrsyx124q"))))
     (build-system meson-build-system)
     (arguments
      (list #:configure-flags
-- 
2.45.2

Message #11 received at 72180 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Laparie <matf <at> disr.it>
To: 72180 <at> debbugs.gnu.org
Cc: Mathieu Laparie <mathieu.laparie <at> inrae.fr>
Subject: [PATCH 2/2]     gnu: mpv: Update to 0.38.0, include sixel support.
Date: Thu, 18 Jul 2024 19:58:03 +0200

From: Mathieu Laparie <mathieu.laparie <at> inrae.fr>

    * gnu/packages/video.scm (mpv): Update to 0.38.0, include sixel support.
    [inputs] Add gdk-pixbuf, libsixel.
---
 gnu/packages/video.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index c7470284dc..3a715cce6a 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2618,7 +2618,7 @@ (define-public mplayer
 (define-public mpv
   (package
     (name "mpv")
-    (version "0.37.0")
+    (version "0.38.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -2626,7 +2626,7 @@ (define-public mpv
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
-               (base32 "1xcyfpd543lbmg587wi0mahrz8vhyrlr4432054vp6wsi3s36c4b"))))
+               (base32 "11l8b9cka81xwrcc148g6avj7jcz8khz3h3xpyadm5265afa6mkl"))))
     (build-system meson-build-system)
     (arguments
      (list
@@ -2658,9 +2658,11 @@ (define-public mpv
     ;; Missing features: libguess, V4L2.
     (inputs
      (list enca
+           gdk-pixbuf
            ladspa
            lcms
            libbs2b
+           libsixel
            mpg123
            rsound
            vulkan-headers
-- 
2.45.2

Message #14 received at 72180 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: Mathieu Laparie <matf <at> disr.it>
Cc: 72180 <at> debbugs.gnu.org
Subject: Re: [bug#72180] [PATCH 0/2] gnu: mpv: Update to 0.38.0 and include
 sixel support.
Date: Fri, 19 Jul 2024 23:55:20 +0800

[Message part 1 (text/plain, inline)]

Mathieu Laparie <matf <at> disr.it> writes:

> I needed sixel support in mpv and noticed our package did not include it, and updated to 0.38.0 while I was at it. This inmplied upgrading libplacebo to 6.338.2, but 7.349.0 is available and works too, so I jumped to that version. mpv 0.38.0 comes with a number of improvements on top of the sixel support included here, among which better playlist display in terminal (was previously garbled with broken character sequences hardcoded from the OSD), support for --input-commands to run commands at startup, zooming on Ctrl+wheel, etc.
>
> The pkg-config name of libsixel seems to be gdk-pixbuf, and it appeared that adding just libsixel in inputs was not enough for mpv to build with sixel support.

I think should move gdk-pixbuf to libsixel's propagated-inputs, and add
a comment say gdk-pixbuf pkg-config's “Requires.private” need
gdk-pixbuf, and add a TODO for "remove it when we use pkgconf."

>
> Mathieu Laparie (2):
>   gnu: libplacebo: Update to 7.349.0.
>   gnu: mpv: Update to 0.38.0, include sixel support.
>
>  gnu/packages/video.scm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 72180-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 72180-done <at> debbugs.gnu.org
Cc: Z572 <873216071 <at> qq.com>, Mathieu Laparie <matf <at> disr.it>
Subject: Re: [PATCH 0/2] gnu: mpv: Update to 0.38.0 and include sixel support.
Date: Thu, 05 Sep 2024 22:24:15 +0200

Hello,

> Mathieu Laparie <matf <at> disr.it> writes:
> 
> > I needed sixel support in mpv and noticed our package did not include it, and updated to 0.38.0 while I was at it. This inmplied upgrading libplacebo to 6.338.2, but 7.349.0 is available and works too, so I jumped to that version. mpv 0.38.0 comes with a number of improvements on top of the sixel support included here, among which better playlist display in terminal (was previously garbled with broken character sequences hardcoded from the OSD), support for --input-commands to run commands at startup, zooming on Ctrl+wheel, etc.
> >
> > The pkg-config name of libsixel seems to be gdk-pixbuf, and it appeared that adding just libsixel in inputs was not enough for mpv to build with sixel support.
> 
> I think should move gdk-pixbuf to libsixel's propagated-inputs, and add
> a comment say gdk-pixbuf pkg-config's “Requires.private” need
> gdk-pixbuf, and add a TODO for "remove it when we use pkgconf."

Thank you. I applied the patch with the suggestions above. MPV had
already been updated, tho.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.