GNU bug report logs - #72181
[PATCH] gnu: services: power-profiles-daemon: Beautify service.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72181 in the body.
You can then email your comments to 72181 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dariqq <dariqq <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Dariqq <dariqq <at> posteo.net>
Subject: [PATCH] gnu: services: power-profiles-daemon: Beautify service.
Date: Thu, 18 Jul 2024 19:28:06 +0000

* gnu/services/pm.scm (power-profiles-daemon-shepherd-service): Change indentation.
[requirement]: Add user-processes.
[documentation]: Change name to Power Profiles Daemon.

(power-profiles-daemon-service-type)
[description]: Change name to Power Profiles Daemon.

Change-Id: Ibbd06cf1fbadd812ad3f0eac92b9772e3387f875
---

Addressing some of the feedpack I got after the original patch #70460 was already pushed: Changing power-profiles-daemon to Power Profiles Daemon in descriptons and make the service require user-processes. Also let the indentation of the shepherd service match other services.

 gnu/services/pm.scm | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm
index 47f0bf7812..5e8e7efda2 100644
--- a/gnu/services/pm.scm
+++ b/gnu/services/pm.scm
@@ -52,14 +52,15 @@ (define (power-profiles-daemon-shepherd-service config)
   (match-record
       config <power-profiles-daemon-configuration>
       (power-profiles-daemon)
-    (list (shepherd-service
-           (provision '(power-profiles-daemon))
-           (requirement '(dbus-system))
-           (documentation "Run the power-profiles-daemon.")
-           (start #~(make-forkexec-constructor
-                     (list #$(file-append power-profiles-daemon
-                                          "/libexec/power-profiles-daemon"))))
-           (stop #~(make-kill-destructor))))))
+    (list
+     (shepherd-service
+      (provision '(power-profiles-daemon))
+      (requirement '(user-processes dbus-system))
+      (documentation "Run the Power Profiles Daemon.")
+      (start #~(make-forkexec-constructor
+                (list #$(file-append power-profiles-daemon
+                                     "/libexec/power-profiles-daemon"))))
+      (stop #~(make-kill-destructor))))))
 
 (define %power-profiles-daemon-activation
   #~(begin
@@ -83,7 +84,7 @@ (define power-profiles-daemon-service-type
                   (service-extension activation-service-type
                                      (const %power-profiles-daemon-activation))))
      (default-value (power-profiles-daemon-configuration))
-     (description "Run the power-profiles-daemon"))))
+     (description "Run the Power Profiles Daemon"))))
 
 
 

base-commit: e3dfed59d39ac60dd2e2b9ef9f4ef63a2a081f41
-- 
2.45.2

Message #10 received at 72181-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Dariqq <dariqq <at> posteo.net>
Cc: 72181-done <at> debbugs.gnu.org
Subject: Re: [bug#72181] [PATCH] gnu: services: power-profiles-daemon:
 Beautify service.
Date: Wed, 20 Nov 2024 23:43:23 +0100

Dariqq <dariqq <at> posteo.net> skribis:

> * gnu/services/pm.scm (power-profiles-daemon-shepherd-service): Change indentation.
> [requirement]: Add user-processes.
> [documentation]: Change name to Power Profiles Daemon.
>
> (power-profiles-daemon-service-type)
> [description]: Change name to Power Profiles Daemon.
>
> Change-Id: Ibbd06cf1fbadd812ad3f0eac92b9772e3387f875

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.