GNU bug report logs - #72206
[PATCH] lint: check-inputs-should-not-be-an-input-at-all: Add more packages.

Previous Next

To reply to this bug, email your comments to 72206 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH] lint: check-inputs-should-not-be-an-input-at-all: Add more
 packages.
Date: Sat, 20 Jul 2024 11:09:31 +0000

* guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
python-pyflakes, python-pylint, python-pytest-cov, python-yapf.

Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
---
There are several flake8 extensions too which could be added.

 guix/lint.scm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/guix/lint.scm b/guix/lint.scm
index 7612832a5a..49e9b73676 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -586,9 +586,18 @@ (define (check-inputs-should-be-native package)
 (define (check-inputs-should-not-be-an-input-at-all package)
   ;; Emit a warning if some inputs of PACKAGE are likely to should not be
   ;; an input at all.
-  (let ((input-names '("python-setuptools"
+  (let ((input-names '("python-black"
+                       "python-coverage"
+                       "python-flake8"
+                       "python-mypy"
                        "python-pip"
-                       "python-pre-commit")))
+                       "python-pre-commit"
+                       "python-pycodestyle"
+                       "python-pyflakes"
+                       "python-pylint"
+                       "python-pytest-cov"
+                       "python-setuptools"
+                       "python-yapf")))
     (map (lambda (input)
            (make-warning
             package

base-commit: 9df5289c6687cd5688c275d16417389fbab6d384
-- 
2.39.2

Message #8 received at 72206 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 72206 <at> debbugs.gnu.org
Subject: Re: [bug#72206] [PATCH] lint:
 check-inputs-should-not-be-an-input-at-all: Add more packages.
Date: Thu, 05 Sep 2024 08:43:13 +0200

Hi Vinicius,

Vinicius Monego <monego <at> posteo.net> skribis:

> * guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
> python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
> python-pyflakes, python-pylint, python-pytest-cov, python-yapf.
>
> Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
> ---
> There are several flake8 extensions too which could be added.

I’m not a Python person but I this looks reasonable to me.  I think you
can go ahead and push.

Ludo’.

Message #11 received at 72206 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 72206 <at> debbugs.gnu.org
Subject: Re: [bug#72206] [PATCH] lint:
 check-inputs-should-not-be-an-input-at-all: Add more packages.
Date: Thu, 05 Sep 2024 08:43:23 +0200

Hi Vinicius,

Vinicius Monego <monego <at> posteo.net> skribis:

> * guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
> python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
> python-pyflakes, python-pylint, python-pytest-cov, python-yapf.
>
> Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
> ---
> There are several flake8 extensions too which could be added.

I’m not a Python person but this looks reasonable to me.  I think you
can go ahead and push.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.