GNU bug report logs - #72225
[PATCH] _AM_PROG_CC_C_O: clean up after .dSYM directories properly

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72225 in the body.
You can then email your comments to 72225 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Gallager <egall <at> gwmail.gwu.edu>
To: automake-patches <at> gnu.org
Subject: [PATCH] _AM_PROG_CC_C_O: clean up after .dSYM directories properly
Date: Sun, 21 Jul 2024 05:20:10 -0400

[Message part 1 (text/plain, inline)]

On darwin, the compiler will generate .dSYM directories (for debug
info) alongside executables when invoked, leading to messages like the
following in configure output:

checking whether /usr/local/bin/gcc understands -c and -o together...
rm: conftest.dSYM: is a directory
yes

The attached patch ought to fix this by passing the -r flag to the rm
invocation that's meant to clean up the conftests. One concern,
though, is that in the same invocation, it also tries to remove
anything called "core", so I worry what might happen with this change
if "core" happens to be a directory... should I handle that
separately?
Thanks,
Eric Gallager

[patch-m4_prog-cc-c-o.m4.diff (application/octet-stream, attachment)]

Message #8 received at 72225 <at> debbugs.gnu.org (full text, mbox):

From: "Zack Weinberg" <zack <at> owlfolio.org>
To: "Eric Gallager" <egall <at> gwmail.gwu.edu>, 72225 <at> debbugs.gnu.org
Subject: Re: [bug#72225] [PATCH] _AM_PROG_CC_C_O: clean up after .dSYM
 directories properly
Date: Sun, 21 Jul 2024 10:16:04 -0400

On Sun, Jul 21, 2024, at 5:20 AM, Eric Gallager via Patches for Automake wrote:
> On darwin, the compiler will generate .dSYM directories (for debug
> info) alongside executables when invoked, leading to messages like the
> following in configure output:
>
> checking whether /usr/local/bin/gcc understands -c and -o together...
> rm: conftest.dSYM: is a directory
> yes
>
> The attached patch ought to fix this by passing the -r flag to the rm
> invocation that's meant to clean up the conftests. One concern,
> though, is that in the same invocation, it also tries to remove
> anything called "core", so I worry what might happen with this change
> if "core" happens to be a directory... should I handle that
> separately?

Tests generated by autoconf proper use this formula for cleaning up after
link tests:

rm -f -r a.out a.exe b.out conftest.$ac_ext conftest.o conftest.obj conftest.dSYM

I'd suggest that _AM_PROG_CC_C_O should be aligned with this - which means
*not* deleting anything named 'core'.  You may or may not have $ac_ext available;
even if you don't I'd suggest that you also make the 'conftest*' glob more
specific (without having looked at the rest of am-prog-cc-c-o.m4, something
like 'conftest.c conftest.o conftest.obj conftest.dSYM' is probably close).

zw

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Gallager <egall <at> gwmail.gwu.edu>
To: Zack Weinberg <zack <at> owlfolio.org>
Cc: automake-patches <at> gnu.org, 72225 <at> debbugs.gnu.org
Subject: Re: [bug#72225] [PATCH] _AM_PROG_CC_C_O: clean up after .dSYM
 directories properly
Date: Sat, 10 Aug 2024 02:38:07 -0400

[Message part 1 (text/plain, inline)]

On Sun, Jul 21, 2024 at 10:16 AM Zack Weinberg <zack <at> owlfolio.org> wrote:
>
> On Sun, Jul 21, 2024, at 5:20 AM, Eric Gallager via Patches for Automake wrote:
> > On darwin, the compiler will generate .dSYM directories (for debug
> > info) alongside executables when invoked, leading to messages like the
> > following in configure output:
> >
> > checking whether /usr/local/bin/gcc understands -c and -o together...
> > rm: conftest.dSYM: is a directory
> > yes
> >
> > The attached patch ought to fix this by passing the -r flag to the rm
> > invocation that's meant to clean up the conftests. One concern,
> > though, is that in the same invocation, it also tries to remove
> > anything called "core", so I worry what might happen with this change
> > if "core" happens to be a directory... should I handle that
> > separately?
>
> Tests generated by autoconf proper use this formula for cleaning up after
> link tests:
>
> rm -f -r a.out a.exe b.out conftest.$ac_ext conftest.o conftest.obj conftest.dSYM
>
> I'd suggest that _AM_PROG_CC_C_O should be aligned with this - which means
> *not* deleting anything named 'core'.  You may or may not have $ac_ext available;

ac_ext is used just a few lines above in the call to AM_RUN_LOG on line 26.

> even if you don't I'd suggest that you also make the 'conftest*' glob more
> specific (without having looked at the rest of am-prog-cc-c-o.m4, something
> like 'conftest.c conftest.o conftest.obj conftest.dSYM' is probably close).
>
> zw

Attached is a new patch that removes 'core' from the list of files to
be deleted, and adds some of your suggestions instead.

[patch-m4_prog-cc-c-o.m4.diff (application/octet-stream, attachment)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Gallager <egall <at> gwmail.gwu.edu>
To: Zack Weinberg <zack <at> owlfolio.org>
Cc: automake-patches <at> gnu.org, 72225 <at> debbugs.gnu.org
Subject: Re: [bug#72225] [PATCH] _AM_PROG_CC_C_O: clean up after .dSYM
 directories properly [PING]
Date: Tue, 3 Sep 2024 14:22:55 -0400

[Message part 1 (text/plain, inline)]

On Sat, Aug 10, 2024 at 2:38 AM Eric Gallager <egall <at> gwmail.gwu.edu> wrote:
>
> On Sun, Jul 21, 2024 at 10:16 AM Zack Weinberg <zack <at> owlfolio.org> wrote:
> >
> > On Sun, Jul 21, 2024, at 5:20 AM, Eric Gallager via Patches for Automake wrote:
> > > On darwin, the compiler will generate .dSYM directories (for debug
> > > info) alongside executables when invoked, leading to messages like the
> > > following in configure output:
> > >
> > > checking whether /usr/local/bin/gcc understands -c and -o together...
> > > rm: conftest.dSYM: is a directory
> > > yes
> > >
> > > The attached patch ought to fix this by passing the -r flag to the rm
> > > invocation that's meant to clean up the conftests. One concern,
> > > though, is that in the same invocation, it also tries to remove
> > > anything called "core", so I worry what might happen with this change
> > > if "core" happens to be a directory... should I handle that
> > > separately?
> >
> > Tests generated by autoconf proper use this formula for cleaning up after
> > link tests:
> >
> > rm -f -r a.out a.exe b.out conftest.$ac_ext conftest.o conftest.obj conftest.dSYM
> >
> > I'd suggest that _AM_PROG_CC_C_O should be aligned with this - which means
> > *not* deleting anything named 'core'.  You may or may not have $ac_ext available;
>
> ac_ext is used just a few lines above in the call to AM_RUN_LOG on line 26.
>
> > even if you don't I'd suggest that you also make the 'conftest*' glob more
> > specific (without having looked at the rest of am-prog-cc-c-o.m4, something
> > like 'conftest.c conftest.o conftest.obj conftest.dSYM' is probably close).
> >
> > zw
>
> Attached is a new patch that removes 'core' from the list of files to
> be deleted, and adds some of your suggestions instead.

Hi, I'd just like to ping this patch from earlier:
https://lists.gnu.org/archive/html/automake-patches/2024-08/msg00003.html

[patch-m4_prog-cc-c-o.m4.diff (application/octet-stream, attachment)]

Message #23 received at 72225 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: egall <at> gwmail.gwu.edu
Cc: zack <at> owlfolio.org, 72225 <at> debbugs.gnu.org
Subject: Re: [bug#72225] [PATCH] _AM_PROG_CC_C_O: clean up after .dSYM
 directories properly [PING]
Date: Tue, 3 Sep 2024 15:41:56 -0600

    Hi, I'd just like to ping this patch from earlier:
    https://lists.gnu.org/archive/html/automake-patches/2024-08/msg00003.html

Thank you Eric! I hope I will manage to apply it soonly. -k

Message #26 received at 72225 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: egall <at> gwmail.gwu.edu
Cc: 72852 <at> debbugs.gnu.org, 72225 <at> debbugs.gnu.org
Subject: Re: bug#72852: Testsuite summary for GNU Automake 1.17 on
 x86_64-apple-darwin20.6.0
Date: Sat, 7 Sep 2024 11:16:04 -0600

Hi Eric - I applied the patch from 72225, which hopefully also fixes
your report in 72852. Closing both, with fingers crossed. Thanks!! -k

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.