GNU logs - #72229, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 21 Jul 2024 14:49:02 +0000
Resent-Message-ID: <handler.72229.B.172157332029232 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72229 <at> debbugs.gnu.org
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Date: Sun, 21 Jul 2024 16:49:21 +0200
Message-ID: <87r0bmer66.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
UI-OutboundReport: notjunk:1;M01:P0:bfwuTdrVSm0=;BK+gJ48vcPupzLkCo5nZP3vTOee
 C08rDh2HTB97q6SJU1pB829bg+jivF+KgmZfMTcgN1qs4rwNkfak5p+Mmcf+ZcENTpaY+OIaa
 OqkDQYhp9VyGUZMvAUOJqpIHVxMo5S2dT5o+vEyL+hiT+uqUY69zRGLYwB5H1Jzu47zcxK65S
 QUxI73zp+/YKgsnNUkLu+a89IHg6PDBj6/J6Sn9VwFsKEoJmjDwcFVzQyiU9ROQawjKyS3SiH
 FKRRo0ZKumnORl6h2l7UGmYVAACrKkyQPndXopV1m3o578WWGrRBPfGD3Fjtml8u0r87UTF8h
 Iq1/4WfonVpI+fZ8PncVgWcYCAj1jMg3q1S+jKq+U4TdSJ34M1PvJGFsfyRp1qN5V5+8FVJMt
 xewnsIxABS4AKUlFq/0sXTKpeJ9QkNLSErv1h0C8o5jRBJCC6ORZ1HHOttw03p1J1XWZQ1/Yx
 W/h2MHwZ9Jg5XBDMz5HeTf/fD9yxUmSeDiH30ja4xw9OzZOEcwx+mcI8jn3IOCJLURAx9Kwpw
 XUx/Z3CHNMccn4/SC8Mh7olDeXPl98fsW/jyz3Orxpxcc6GTBVwg8zSWAnGL3Hv7Y38qI2hN6
 Ia5mIe68uyU9MRsIgCkUwwReki5AtUVt6yI1BsSuCtWpa0fJpGg/HXjgJCO3LfUYU8MKLDThy
 XoXfWdbY+EvWqoZEpBMhtonNytZWiRXp7WlIXvrkjq6Rr2kJSSQ+cM+T4vOQsM7j6HzAehvvp
 xclad0ZaO6/aoE/bLq7iNKA2pFmDpHqfxTmApACsgP4GKp2rdX21G7CWKsZ+iPguwR6BwOr1q
 9zkxD/XBz3eHr51+JKslntWg==
Received-SPF: pass client-ip=212.227.15.4;
 envelope-from=michael_heerdegen@HIDDEN; helo=mout.web.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


Hello,

exiting isearch always explicitly sets `overriding-terminal-local-map'
to nil.  This will interfere with any other users of
`overriding-terminal-local-map', including any active transient maps.

Wouldn't a less radical means suffice?  If isearch really must _set_,
i.e., completely override that variable, why not restore the original
value?


TIA,

Michael.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: bug#72229: Acknowledgement ((setq overriding-terminal-local-map
 nil) in isearch-done)
Message-ID: <handler.72229.B.172157332029232.ack <at> debbugs.gnu.org>
References: <87r0bmer66.fsf@HIDDEN>
X-Gnu-PR-Message: ack 72229
X-Gnu-PR-Package: emacs
Reply-To: 72229 <at> debbugs.gnu.org
Date: Sun, 21 Jul 2024 14:49:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 72229 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72229: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72229
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to juri@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: juri@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 22 Jul 2024 12:49:01 +0000
Resent-Message-ID: <handler.72229.B72229.17216525413640 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72229 <at> debbugs.gnu.org
Cc: Juri Linkov <juri@HIDDEN>
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <87r0bmer66.fsf@HIDDEN> (Michael Heerdegen via's message of "Sun, 
 21 Jul 2024 16:49:21 +0200")
References: <87r0bmer66.fsf@HIDDEN>
Date: Mon, 22 Jul 2024 14:49:34 +0200
Message-ID: <87sew17fs1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
UI-OutboundReport: notjunk:1;M01:P0:ZAFgcVQEIAk=;+LjFkpte7OE/MRGGvO/xZBf9t6k
 wvXfhzJi7OKFY6jLJHzPcKDS7f6px7h53aOy+tvqT3OgNOQ8S6lRQrZCMdxMUbiWp8DQOCmor
 JUZq2owHXIWeAJQrH0FqGZj1eA3fK6Y0mBozw/EbLzX6wrE0ZJiV1UfrqYHK4V2ohHXzxQ5h6
 X1Mn67QgI8UOV7ZjEy8r5Mu2fc4EsJAyr7t9G8cRGOIrYy3fQEn4zdWhJpquYgEgqkBAnlIM6
 NZP+mBNkSeeC0kXnKqpjgpxjeG/0HcRX3bzMOJEzeEZci7u5rKnqecxwp8/cG+fK9Wz+a0luh
 evtLAkIWgbIETf6wssdAPUZghz0+PaBetjP/VZwjTsO2Xcsfdi+wWWoC6BCIMpYFl5LjZQg1/
 MA8TYR6dfP2XND4Du4JEH2rf/92s905F7Wg3S0ICjBHr7/GTWAq1KyzNiu1ylWYb/LFsEPMbR
 /HjE0x3V28dXbNmTfj04s585pd0oqa0AagHVaDiCfkmNw7UVu4F6GlLEjGQcognnrBZ9uVXX6
 Hf5kt8L7SRpZk9gHDePRvkfrafuUAkgmuMwdIsgOSrZdi7NfmOukvo1SaSCu9GdvriAtJC/S2
 DmL3QQfCqxcyKna8dymVEUis6JcaAPxudbCIeXdpdRiV8kHPJ1y9bxyf8s5Qj0178vWoBGhr5
 04f0lxeqV3X6c/6nBXuqE9ZSeoZs54LllooYKP5NbrgRibJ+XI99nZZcCVqMRC6heN9Iz7yls
 jWGQfcyER2LVTBbkZONzMCG42UY8vqNlyn4Qk9d2GuCzgssSE/ObGxjcDO4Gj+2TVfND9PsQp
 +WJWQrqHMQLdsD3Y+mog+9sw==
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife
of text editors" <bug-gnu-emacs@HIDDEN> writes:

> exiting isearch always explicitly sets `overriding-terminal-local-map'
> to nil.  This will interfere with any other users of
> `overriding-terminal-local-map', including any active transient maps.
>
> Wouldn't a less radical means suffice?  If isearch really must _set_,
> i.e., completely override that variable, why not restore the original
> value?

Juri, what's your opinion on this?


A little more forward looking:

In such situations I often get this thought: if the variable was
replaced with a function accepting zero arguments, then we could use
`add-function' and `remove-function' to control the return value of the
"binding".

I know the advice mechanism has the reputation of only being suitable
for end user customization/hacks, but in cases like this one we could
make the modification of the value more explicit and controllable.
Dealing with interferences would be forced to be taken into account more
directly , and we would get some useful mechanisms like priorities or
looking at the context out of the box.

We could also invent some even better mechanism, maybe.  But in this
case binding variables doesn't look like an optimal approach at least.


Michael.

Message sent to juri@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: juri@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 22 Jul 2024 12:50:02 +0000
Resent-Message-ID: <handler.72229.B.17216525963741 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72229 <at> debbugs.gnu.org
Cc: Juri Linkov <juri@HIDDEN>
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <87r0bmer66.fsf@HIDDEN> (Michael Heerdegen via's message of "Sun, 
 21 Jul 2024 16:49:21 +0200")
References: <87r0bmer66.fsf@HIDDEN>
Date: Mon, 22 Jul 2024 14:49:34 +0200
Message-ID: <87sew17fs1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
UI-OutboundReport: notjunk:1;M01:P0:ZAFgcVQEIAk=;+LjFkpte7OE/MRGGvO/xZBf9t6k
 wvXfhzJi7OKFY6jLJHzPcKDS7f6px7h53aOy+tvqT3OgNOQ8S6lRQrZCMdxMUbiWp8DQOCmor
 JUZq2owHXIWeAJQrH0FqGZj1eA3fK6Y0mBozw/EbLzX6wrE0ZJiV1UfrqYHK4V2ohHXzxQ5h6
 X1Mn67QgI8UOV7ZjEy8r5Mu2fc4EsJAyr7t9G8cRGOIrYy3fQEn4zdWhJpquYgEgqkBAnlIM6
 NZP+mBNkSeeC0kXnKqpjgpxjeG/0HcRX3bzMOJEzeEZci7u5rKnqecxwp8/cG+fK9Wz+a0luh
 evtLAkIWgbIETf6wssdAPUZghz0+PaBetjP/VZwjTsO2Xcsfdi+wWWoC6BCIMpYFl5LjZQg1/
 MA8TYR6dfP2XND4Du4JEH2rf/92s905F7Wg3S0ICjBHr7/GTWAq1KyzNiu1ylWYb/LFsEPMbR
 /HjE0x3V28dXbNmTfj04s585pd0oqa0AagHVaDiCfkmNw7UVu4F6GlLEjGQcognnrBZ9uVXX6
 Hf5kt8L7SRpZk9gHDePRvkfrafuUAkgmuMwdIsgOSrZdi7NfmOukvo1SaSCu9GdvriAtJC/S2
 DmL3QQfCqxcyKna8dymVEUis6JcaAPxudbCIeXdpdRiV8kHPJ1y9bxyf8s5Qj0178vWoBGhr5
 04f0lxeqV3X6c/6nBXuqE9ZSeoZs54LllooYKP5NbrgRibJ+XI99nZZcCVqMRC6heN9Iz7yls
 jWGQfcyER2LVTBbkZONzMCG42UY8vqNlyn4Qk9d2GuCzgssSE/ObGxjcDO4Gj+2TVfND9PsQp
 +WJWQrqHMQLdsD3Y+mog+9sw==
Received-SPF: pass client-ip=212.227.17.12;
 envelope-from=michael_heerdegen@HIDDEN; helo=mout.web.de
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife
of text editors" <bug-gnu-emacs@HIDDEN> writes:

> exiting isearch always explicitly sets `overriding-terminal-local-map'
> to nil.  This will interfere with any other users of
> `overriding-terminal-local-map', including any active transient maps.
>
> Wouldn't a less radical means suffice?  If isearch really must _set_,
> i.e., completely override that variable, why not restore the original
> value?

Juri, what's your opinion on this?


A little more forward looking:

In such situations I often get this thought: if the variable was
replaced with a function accepting zero arguments, then we could use
`add-function' and `remove-function' to control the return value of the
"binding".

I know the advice mechanism has the reputation of only being suitable
for end user customization/hacks, but in cases like this one we could
make the modification of the value more explicit and controllable.
Dealing with interferences would be forced to be taken into account more
directly , and we would get some useful mechanisms like priorities or
looking at the context out of the box.

We could also invent some even better mechanism, maybe.  But in this
case binding variables doesn't look like an optimal approach at least.


Michael.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Jul 2024 06:40:02 +0000
Resent-Message-ID: <handler.72229.B72229.172171678929084 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72229
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: 72229 <at> debbugs.gnu.org
Received: via spool by 72229-submit <at> debbugs.gnu.org id=B72229.172171678929084
          (code B ref 72229); Tue, 23 Jul 2024 06:40:02 +0000
Received: (at 72229) by debbugs.gnu.org; 23 Jul 2024 06:39:49 +0000
Received: from localhost ([127.0.0.1]:59018 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sW9Bc-0007Z2-M2
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 02:39:49 -0400
Received: from relay1-d.mail.gandi.net ([217.70.183.193]:45955)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1sW9Ba-0007Ym-JW
 for 72229 <at> debbugs.gnu.org; Tue, 23 Jul 2024 02:39:48 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 575BF240005;
 Tue, 23 Jul 2024 06:39:34 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <87sew17fs1.fsf@HIDDEN> (Michael Heerdegen's message of "Mon, 22
 Jul 2024 14:49:34 +0200")
Organization: LINKOV.NET
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
Date: Tue, 23 Jul 2024 09:32:21 +0300
Message-ID: <864j8gsk4i.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain

> Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife
> of text editors" <bug-gnu-emacs@HIDDEN> writes:
>
>> exiting isearch always explicitly sets `overriding-terminal-local-map'
>> to nil.  This will interfere with any other users of
>> `overriding-terminal-local-map', including any active transient maps.
>>
>> Wouldn't a less radical means suffice?  If isearch really must _set_,
>> i.e., completely override that variable, why not restore the original
>> value?
>
> Juri, what's your opinion on this?

Indeed, you are right, `isearch-done' should restore the original value.
The existing variable `isearch--saved-overriding-local-map' can't be used,
so a similar variable should be added like in this patch:


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=isearch--saved-local-map.patch

diff --git a/lisp/isearch.el b/lisp/isearch.el
index dc9edf267f2..697dcdbb3d8 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -972,6 +972,7 @@ isearch-hidden
 ;; The value of input-method-function when isearch is invoked.
 (defvar isearch-input-method-function nil)
 
+(defvar isearch--saved-local-map nil)
 (defvar isearch--saved-overriding-local-map nil)
 
 ;; Minor-mode-alist changes - kind of redundant with the
@@ -1321,6 +1322,7 @@ isearch-mode
   (setq	isearch-mode " Isearch")  ;; forward? regexp?
   (force-mode-line-update)
 
+  (setq isearch--saved-local-map overriding-terminal-local-map)
   (setq overriding-terminal-local-map isearch-mode-map)
   (run-hooks 'isearch-mode-hook)
   ;; Remember the initial map possibly modified
@@ -1439,10 +1444,12 @@ isearch-update
 
 (defun isearch-done (&optional nopush edit)
   "Exit Isearch mode.
+Called by all commands that terminate isearch-mode.
 For successful search, pass no args.
 For a failing search, NOPUSH is t.
 For going to the minibuffer to edit the search string,
-NOPUSH is t and EDIT is t."
+NOPUSH is t and EDIT is t.
+If NOPUSH is non-nil, we don't push the string on the search ring."
 
   (when isearch-resume-in-command-history
     (add-to-history 'command-history
@@ -1460,9 +1467,7 @@ isearch-done
       (setq isearch--current-buffer nil)
       (setq cursor-sensor-inhibit (delq 'isearch cursor-sensor-inhibit))))
 
-  ;; Called by all commands that terminate isearch-mode.
-  ;; If NOPUSH is non-nil, we don't push the string on the search ring.
-  (setq overriding-terminal-local-map nil)
+  (setq overriding-terminal-local-map isearch--saved-local-map)
   ;; (setq pre-command-hook isearch-old-pre-command-hook) ; for lemacs
   (setq minibuffer-message-timeout isearch-original-minibuffer-message-timeout)
   (isearch-dehighlight)
@@ -2676,7 +2681,7 @@ isearch-mouse-2
 is bound to outside of Isearch."
   (interactive "e")
   (let ((w (posn-window (event-start click)))
-        (binding (let ((overriding-terminal-local-map nil)
+        (binding (let ((overriding-terminal-local-map isearch--saved-local-map)
                        ;; Key search depends on mode (bug#47755)
                        (isearch-mode nil))
                    (key-binding (this-command-keys-vector) t))))

--=-=-=
Content-Type: text/plain


> A little more forward looking:
>
> In such situations I often get this thought: if the variable was
> replaced with a function accepting zero arguments, then we could use
> `add-function' and `remove-function' to control the return value of the
> "binding".
>
> I know the advice mechanism has the reputation of only being suitable
> for end user customization/hacks, but in cases like this one we could
> make the modification of the value more explicit and controllable.
> Dealing with interferences would be forced to be taken into account more
> directly , and we would get some useful mechanisms like priorities or
> looking at the context out of the box.
>
> We could also invent some even better mechanism, maybe.  But in this
> case binding variables doesn't look like an optimal approach at least.

This mechanism looks like a variable watcher enabled by `add-variable-watcher'.
So you could add a watcher that conditionally controls variable modifications.

--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Jul 2024 11:31:01 +0000
Resent-Message-ID: <handler.72229.B72229.17217342177533 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72229
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Juri Linkov <juri@HIDDEN>
Cc: michael_heerdegen@HIDDEN, 72229 <at> debbugs.gnu.org
Received: via spool by 72229-submit <at> debbugs.gnu.org id=B72229.17217342177533
          (code B ref 72229); Tue, 23 Jul 2024 11:31:01 +0000
Received: (at 72229) by debbugs.gnu.org; 23 Jul 2024 11:30:17 +0000
Received: from localhost ([127.0.0.1]:59359 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWDii-0001ws-Sa
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 07:30:17 -0400
Received: from eggs.gnu.org ([209.51.188.92]:37178)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sWDih-0001a6-Gk
 for 72229 <at> debbugs.gnu.org; Tue, 23 Jul 2024 07:30:16 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sWDiW-0001UF-M3; Tue, 23 Jul 2024 07:30:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=jWFEEFWsL/BglGZAMT78RrSX3axabfTBpDTs/ldKSVg=; b=gOHsEOzWRIzm
 5r2oHUYT6nvpg1Uzh/DOs2KZittsUk2baxLl1MG17yXqORk0/EG1Z8o3aueU8dZbxS2+BWPFghRNk
 kuMggvd4Jw/q1KAKyqLzzx4bk+bYaA1EfrKYleGrA3U8koSQHWfL2B/1AmEa1cv49Yhm45TIYtVnr
 vYi0EW8jJZg4pdOxhOLOcwC9cWhz1qDEYiow4rdY2ikZp/q9vjzvMkTIhCvPX4BVV1x6XRNIB45S6
 hxVTQK1JCDWUcsPHqKER8/5Vh8aZHrWDGAFFVo/I5X7jW01UE7rymWN2cLhRuGRpnKhpQiE/46p2T
 YoVIzOywWDYXrwm6p8hGEQ==;
Date: Tue, 23 Jul 2024 14:29:25 +0300
Message-Id: <868qxs9wiy.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <864j8gsk4i.fsf@HIDDEN> (message from Juri Linkov on
 Tue, 23 Jul 2024 09:32:21 +0300)
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
 <864j8gsk4i.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 72229 <at> debbugs.gnu.org
> From: Juri Linkov <juri@HIDDEN>
> Date: Tue, 23 Jul 2024 09:32:21 +0300
> 
> > Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife
> > of text editors" <bug-gnu-emacs@HIDDEN> writes:
> >
> >> exiting isearch always explicitly sets `overriding-terminal-local-map'
> >> to nil.  This will interfere with any other users of
> >> `overriding-terminal-local-map', including any active transient maps.
> >>
> >> Wouldn't a less radical means suffice?  If isearch really must _set_,
> >> i.e., completely override that variable, why not restore the original
> >> value?
> >
> > Juri, what's your opinion on this?
> 
> Indeed, you are right, `isearch-done' should restore the original value.
> The existing variable `isearch--saved-overriding-local-map' can't be used,
> so a similar variable should be added like in this patch:

Thanks.  If this is deemed the right solution, please install on
master, not on emacs-30 (as we have lived with this issue since 1995).

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Jul 2024 16:06:02 +0000
Resent-Message-ID: <handler.72229.B72229.172175070911372 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72229
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Juri Linkov <juri@HIDDEN>
Cc: 72229 <at> debbugs.gnu.org
Received: via spool by 72229-submit <at> debbugs.gnu.org id=B72229.172175070911372
          (code B ref 72229); Tue, 23 Jul 2024 16:06:02 +0000
Received: (at 72229) by debbugs.gnu.org; 23 Jul 2024 16:05:09 +0000
Received: from localhost ([127.0.0.1]:60597 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWI0i-0002xM-VP
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 12:05:09 -0400
Received: from mout.web.de ([212.227.15.4]:57589)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1sWI0e-0002wk-9y
 for 72229 <at> debbugs.gnu.org; Tue, 23 Jul 2024 12:05:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de;
 s=s29768273; t=1721750687; x=1722355487;
 i=michael_heerdegen@HIDDEN;
 bh=E3EtNT9OBYBHQCZNBaO1AYVH30DvaF5zDTIAqhHWhiU=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
 Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
 content-type:date:from:message-id:mime-version:reply-to:subject:
 to;
 b=CxYwPQHAfm4uUbP84+JkhD872bQidDdgCAplVaRXwk0yPCWP9BJ8zlYYbVNhEnwG
 6NsDi+JHl2yTehrkwmE0Uawrgqj78po7vkv6TBBhiX3zaROTxSeN53ptUPUI1l+wc
 sV5Tvdlzq62gYKt3CFbq5lOSnAjL5w8aKBUjt4RTq1cLc53LW4xBPnGFg7q1J8zEq
 UsMtreNboQFGitoJMU+uvc9ytbRU07u+ItpfyVLVThhvZ4Dzx7Smik0OosHKnk6BQ
 H74ZuPIGi71GUAhuhY6koDNzUr4eEZIjE6ac7ELo0teRjcsH1NNuR0+iVwTNuo82D
 vzAmONnWrjFNPqjjCg==
X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6
Received: from drachen.dragon ([84.59.210.113]) by smtp.web.de (mrweb005
 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MxYbN-1s7bNO1FRR-0131JC; Tue, 23
 Jul 2024 18:04:47 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <864j8gsk4i.fsf@HIDDEN> (Juri Linkov's message of "Tue, 
 23 Jul 2024 09:32:21 +0300")
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
 <864j8gsk4i.fsf@HIDDEN>
Date: Tue, 23 Jul 2024 18:05:31 +0200
Message-ID: <87h6cg856c.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:VKhPdYwtPOKCOe4mwF2h2R2k3RJliUacafHyYrAFgTfBkg9ff0c
 q4b/N7QkAL17tsH5yXZzrwf67ykFJ9RepXtLrPkcBZKwk/J3HeYX7La46mHAMXjAAlithm2
 5a2lswPCdIV9kd5YMuKpzo42uqrf3iIOoqYK6oam26EgBlhcIjjf1PxxT4sZ9uBnZdYctRj
 SOJtVaFPDLj+3SEA65mFQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:wWcGfI0I4KI=;vFU80vrHlqCduo8ah282UvIC+Bw
 VWjWu2DMYZg+24/2gN/lvVUu3H3BPogNW3FAMNZ5aP16iet6x888IX5X4fIojxKKf4ZaElRqP
 15mwaiZCMXqgWHRXhQA+Z18sDbLO28Hlx85QFAjy+C3lDxt4z3cvVspwG2/6wF50vOazBV7rn
 YlrsffJ2Cm/xwZOYlPgeQm1D/gCBmwiCRY4cx5wCYZK7seEOob+2wr8Dtrot8PF2uwhIzhrjL
 MPKNjTzar2wLL5NHDNJFPk8d71/UjPH4jvcExZDgvgDZjqlG8mwM5q8Fxgo7eZQkaCVVxmXTw
 kqoffoG+Kf06TMR5CE78i1+/icqkhU6Vu0be/2bpGSaEWGK72LAfpGMoP4FzRoMkFnUL1d0o5
 HvPtG84qAcJac8ZrL8AUb5Hk813YFx7VkU/WXvfQt2mZMkeVXmbekzSHa7js+adVgWwlmXr9M
 84gXXMXtLcieGB4oR0YC4RLTfCMnFV3Qs6mkpIuu/lP0gD811i3PFl/itBw0ikTm7/c5qgZ99
 SVx7cukvui+lj2egWSLqAsUGytNd8BxRyu5haqXqQRSpJzaM0NRHkSAd6kcPkrM46AxIv+x4V
 p1jd+xxc2zyrqyU9bIhdOidz0YbD5puIcqSHfJUNcnltr7hiKOfYPz9bfRf1Lej1fBvKJLWJJ
 RqaINFZX5SYZdDrdRfQwJo/vvodh7lzKoPTednKQyOJPEri30Tsi6Bxwe4Ma4w6c1jJqxrD1G
 deXF5fQoFxX0ZKrs2S2S0DJik82NSBf7r/XHcptmulhMeIhbiPcz+JoaA/xBtF0sjuiwEzHIO
 xGBR+Cmzr6JKckDAG5/2NoQQ==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Juri Linkov <juri@HIDDEN> writes:

> Indeed, you are right, `isearch-done' should restore the original value.
> The existing variable `isearch--saved-overriding-local-map' can't be used,
> so a similar variable should be added like in this patch:

LGTM for master - thank you.


> This mechanism looks like a variable watcher enabled by
> `add-variable-watcher'.
> So you could add a watcher that conditionally controls variable
> modifications.

I don't think variable watchers are very helpful here.  They don't solve
the underlying problem: potentially infinite variables of the same name
can exist, shadowing each other, with values partly sharing structures.


Using variable watchers I can see whether a variable value gets shadowed
or unassigned using a set operation - but I can't know whether the
previous value still exists, as binding of some other variable, and if
it will be stored back into the variable.  Nor do I have access to old
bindings and their values until the program assigns it back to the
variable.

I saw that in Bug#70938.  Manipulations of a variable can interfere in
annoying ways.

Functions are different.  You have only one dynamic binding (unless in
the rare case of using `cl-letf', which is extremely rare).  And you
always have access to it to undo any prior modification.


Michael.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Jul 2024 17:53:02 +0000
Resent-Message-ID: <handler.72229.B72229.172175715721297 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72229
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: 72229 <at> debbugs.gnu.org
Received: via spool by 72229-submit <at> debbugs.gnu.org id=B72229.172175715721297
          (code B ref 72229); Tue, 23 Jul 2024 17:53:02 +0000
Received: (at 72229) by debbugs.gnu.org; 23 Jul 2024 17:52:37 +0000
Received: from localhost ([127.0.0.1]:60680 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWJgj-0005XR-JR
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 13:52:37 -0400
Received: from relay1-d.mail.gandi.net ([217.70.183.193]:47549)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1sWJgg-0005X0-Ea
 for 72229 <at> debbugs.gnu.org; Tue, 23 Jul 2024 13:52:35 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 3C3E8240003;
 Tue, 23 Jul 2024 17:52:21 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <87h6cg856c.fsf@HIDDEN> (Michael Heerdegen's message of "Tue, 23
 Jul 2024 18:05:31 +0200")
Organization: LINKOV.NET
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
 <864j8gsk4i.fsf@HIDDEN> <87h6cg856c.fsf@HIDDEN>
Date: Tue, 23 Jul 2024 20:46:33 +0300
Message-ID: <86jzhcyqb2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> This mechanism looks like a variable watcher enabled by
>> `add-variable-watcher'.
>> So you could add a watcher that conditionally controls variable
>> modifications.
>
> I don't think variable watchers are very helpful here.  They don't solve
> the underlying problem: potentially infinite variables of the same name
> can exist, shadowing each other, with values partly sharing structures.
>
> Using variable watchers I can see whether a variable value gets shadowed
> or unassigned using a set operation - but I can't know whether the
> previous value still exists, as binding of some other variable, and if
> it will be stored back into the variable.  Nor do I have access to old
> bindings and their values until the program assigns it back to the
> variable.
>
> I saw that in Bug#70938.  Manipulations of a variable can interfere in
> annoying ways.
>
> Functions are different.  You have only one dynamic binding (unless in
> the rare case of using `cl-letf', which is extremely rare).  And you
> always have access to it to undo any prior modification.

I remember Stefan M suggested to use function variables as much as possible
such as (defvar isearch-filter-predicate #'isearch-filter-visible), then
it's easy to add more filters with add-function.

But I'm not sure is it possible to do the same with a variable
getter function?  I mean that instead of (funcall isearch-filter-predicate)
such a getter function could be called (get-value isearch-filter-predicate)
to access the variable value.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Jul 2024 17:55:02 +0000
Resent-Message-ID: <handler.72229.B72229.172175730021570 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72229
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: michael_heerdegen@HIDDEN, 72229 <at> debbugs.gnu.org
Received: via spool by 72229-submit <at> debbugs.gnu.org id=B72229.172175730021570
          (code B ref 72229); Tue, 23 Jul 2024 17:55:02 +0000
Received: (at 72229) by debbugs.gnu.org; 23 Jul 2024 17:55:00 +0000
Received: from localhost ([127.0.0.1]:60690 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWJj2-0005bo-GQ
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 13:55:00 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57719)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>)
 id 1sWJj0-0005bQ-Sg; Tue, 23 Jul 2024 13:54:59 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 38EEDFF804;
 Tue, 23 Jul 2024 17:54:46 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <868qxs9wiy.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 23 Jul
 2024 14:29:25 +0300")
Organization: LINKOV.NET
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
 <864j8gsk4i.fsf@HIDDEN> <868qxs9wiy.fsf@HIDDEN>
Date: Tue, 23 Jul 2024 20:54:19 +0300
Message-ID: <86v80wxad0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 72229 31.0.50
thanks

>> Indeed, you are right, `isearch-done' should restore the original value.
>> The existing variable `isearch--saved-overriding-local-map' can't be used,
>> so a similar variable should be added like in this patch:
>
> Thanks.  If this is deemed the right solution, please install on
> master, not on emacs-30 (as we have lived with this issue since 1995).

Now installed on master.  I need to dust off an old patch
that obsoletes overriding-terminal-local-map in isearch
by enabling buffer-local isearch-mode.  I guess it will go
to master as well.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 23 Jul 2024 17:55:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 23 13:55:01 2024
Received: from localhost ([127.0.0.1]:60692 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWJj2-0005bq-Pt
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 13:55:01 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57719)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>)
 id 1sWJj0-0005bQ-Sg; Tue, 23 Jul 2024 13:54:59 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 38EEDFF804;
 Tue, 23 Jul 2024 17:54:46 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#72229: (setq overriding-terminal-local-map nil) in
 isearch-done
In-Reply-To: <868qxs9wiy.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 23 Jul
 2024 14:29:25 +0300")
Organization: LINKOV.NET
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
 <864j8gsk4i.fsf@HIDDEN> <868qxs9wiy.fsf@HIDDEN>
Date: Tue, 23 Jul 2024 20:54:19 +0300
Message-ID: <86v80wxad0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: control
Cc: michael_heerdegen@HIDDEN, 72229 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 72229 31.0.50
thanks

>> Indeed, you are right, `isearch-done' should restore the original value.
>> The existing variable `isearch--saved-overriding-local-map' can't be used,
>> so a similar variable should be added like in this patch:
>
> Thanks.  If this is deemed the right solution, please install on
> master, not on emacs-30 (as we have lived with this issue since 1995).

Now installed on master.  I need to dust off an old patch
that obsoletes overriding-terminal-local-map in isearch
by enabling buffer-local isearch-mode.  I guess it will go
to master as well.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 24 Jul 2024 16:43:01 +0000
Resent-Message-ID: <handler.72229.B72229.172183932218253 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72229
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Juri Linkov <juri@HIDDEN>
Cc: 72229 <at> debbugs.gnu.org
Received: via spool by 72229-submit <at> debbugs.gnu.org id=B72229.172183932218253
          (code B ref 72229); Wed, 24 Jul 2024 16:43:01 +0000
Received: (at 72229) by debbugs.gnu.org; 24 Jul 2024 16:42:02 +0000
Received: from localhost ([127.0.0.1]:34385 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWf3x-0004kA-I4
	for submit <at> debbugs.gnu.org; Wed, 24 Jul 2024 12:42:01 -0400
Received: from mout.web.de ([212.227.17.11]:33255)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1sWf3u-0004jm-BQ
 for 72229 <at> debbugs.gnu.org; Wed, 24 Jul 2024 12:41:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de;
 s=s29768273; t=1721839304; x=1722444104;
 i=michael_heerdegen@HIDDEN;
 bh=l+YexvZQFhRq9SS0Pa9XMAgW1JuqcUP2GHUINLhnI6k=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
 Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
 content-type:date:from:message-id:mime-version:reply-to:subject:
 to;
 b=CF+0LCWkpQS2baN1JyswsiIqkpRTeu3S2pbJDzML6zeOsOxP9VxHphOR9EXyrqJ9
 4aVDl5fhqqMlORl1NGX9e7O2AUzeR6XgcYv8tCA0gavanzZQa9AHOC9jdAcT67tIh
 auQ2jkTxBZmADccX8XhUAlhC2kN7nWtseeVUl4dVHj88d7ugLj16G4Hf6MgW/MaJp
 /c6Iv+YzmTUamxEgyVwtwLz0EwPRQG5oBUhuxAGiX9K0L0/pZI9WbSy1sOlpq2Cgb
 gMzE9H1oVJAt087nwC7uFkNxkkYcfetjBu6nUH5rm11yamrlR5QXsYuVY3ghlSYpW
 oV+sqeAi8kunTPAyEQ==
X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6
Received: from drachen.dragon ([84.59.210.113]) by smtp.web.de (mrweb106
 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MnG2Q-1rprX21zNc-00l14p; Wed, 24
 Jul 2024 18:41:44 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <86jzhcyqb2.fsf@HIDDEN> (Juri Linkov's message of "Tue, 
 23 Jul 2024 20:46:33 +0300")
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
 <864j8gsk4i.fsf@HIDDEN> <87h6cg856c.fsf@HIDDEN>
 <86jzhcyqb2.fsf@HIDDEN>
Date: Wed, 24 Jul 2024 18:42:31 +0200
Message-ID: <87ikwu213c.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:ELO3IXnFypQFfjR8XQxhxl8IiFdjsPUdiPSqIlPaVrtpQktbdAc
 a1prhZ4AHaXkDEPkhFz/BLu4rJDSnPvUMN3q67lUWjTT7DAMS1jRy9vpn6pVO+lND4qwFeA
 nzMgPu7jJnURmaTtZbqDruAb1azMsmn7NYNZM82AvACJdowK1/jCGbyb6zKijJJmjYbz4Pt
 bDCXyQHUek9TqFNf5BaMg==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:LWUdB7WpjZk=;+6ddOh8kxqI9CriicG9Prq12uhi
 JtBZJDlPt/52wGD1R8gomdOarKg/ur0XysZROcTJiyAP+9NPLTMVEYfZ02Hv99ozQpU7W5Klu
 7plGA92wgzh+3EuD80JuHgFw5UvWBbi9htKaBzUdPKn0If/GQawXT82oe5gCQtpTWUqJdEofn
 3AJ+mb7fa7OjhOnpPbLyTCVglCgreWf3T3lXZWjYBfHBcUU/dhlu1t1LE2wdehBshc191Wbmy
 jfXnR/3jS5m/tpwPRdFyVMppR2kkwNML3DiFX70V3IaoLs+w6BGkqNe+P+owS6AEJSrCrrPBg
 EoQms3BVz3zd0/V854YslpE2H/v/WhCcAkvyIqChCunOoe2pzrELSqpKboVm5oNIosrpdFMpV
 /fhM9ewraPyKn7UWXux/3qs2D6Ujf5thyPv30kW/MjVDvRp8hi7ilxa5HB6B+En28srGLy+dK
 y9EY6zgH6a0hWsYaDrctAf4daA1ASniU2bEKEM29Jt8bnpjWNJTkhI2tioLKl4TVJkeAhGtPa
 JfV3bOPPhtiC+7ose397l/9mh2BdVNQQCj5oRi/+8Oq9a1Xv25dyGMO4em7j26/Qp/NYQhru4
 nlL/4X8ltYDueeYGAV6lvezqHHbJS2oQ9HZG+U74skv0XcOiR09DmumzBsBf6ZjF33Q6PvG0V
 brQlH7LN70hId6z9EA5q42R1Vv3MvVOLOfDn8dPP+if/14DVTL92Q/qr0eQRpmH3tBmjsJ9DX
 I42tD2md+GSKkEr7ajMRlG+drYdHUveXkRoUov79HKeqM2zRH9VfjZ/EeKVH0cR7BGl+DUlYK
 sYpityofymWYs0WSlObTrEPg==
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Juri Linkov <juri@HIDDEN> writes:

> But I'm not sure is it possible to do the same with a variable
> getter function?

I think it would be unavoidable to change all code places where the
variable is referenced, including those in C, to call the function value
stored in the variable instead of referencing the variable binding.


Michael.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Drew Adams <drew.adams@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 24 Jul 2024 17:28:01 +0000
Resent-Message-ID: <handler.72229.B72229.172184204622947 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72229
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>, Juri Linkov <juri@HIDDEN>
Cc: "72229 <at> debbugs.gnu.org" <72229 <at> debbugs.gnu.org>
Received: via spool by 72229-submit <at> debbugs.gnu.org id=B72229.172184204622947
          (code B ref 72229); Wed, 24 Jul 2024 17:28:01 +0000
Received: (at 72229) by debbugs.gnu.org; 24 Jul 2024 17:27:26 +0000
Received: from localhost ([127.0.0.1]:34413 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWflu-0005y3-3m
	for submit <at> debbugs.gnu.org; Wed, 24 Jul 2024 13:27:26 -0400
Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:42654)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1sWflo-0005xr-QO
 for 72229 <at> debbugs.gnu.org; Wed, 24 Jul 2024 13:27:24 -0400
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46OFXWEi026916;
 Wed, 24 Jul 2024 17:27:13 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=
 from:to:cc:subject:date:message-id:references:in-reply-to
 :content-type:content-transfer-encoding:mime-version; s=
 corp-2023-11-20; bh=snu/0fNbXnqc3TignvjzKRjdN8mILYzG2A7Z9x2Grh4=; b=
 NGjRuzhyOMXfPi0YbH76KC7mZgU0pQ1agavwzlKYLGXoizdezp4iFnARiCBLV80R
 wksJ12x+FQ5dRtqiXefYRF7VB29JkV2m39jr6VGLSLDyfTwZl82DNljagr6Lr8wa
 AJi9BxXqt7/+TkBhgSeJdD9V73vNoKhd+ctW5UxbSKxVnfh3Ufx5HTtTk/2y0F2h
 vhhGLbo8bVJUIwYoxTOU5zSpd/8Go3mKdXcR8qEu0srSjnk5aSMKktVd67wHLs+v
 WJJokO9UaKmmmx6pQm4GNtKkYnlVWKDVo6gY7Zf1LJLCoqm0+DO9uhgz0xhPFHLb
 tzzNq9KbW0LkfZkcRzG+Bw==
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40hft0hha8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 24 Jul 2024 17:27:12 +0000 (GMT)
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19)
 with ESMTP id 46OG4Oqg034388; Wed, 24 Jul 2024 17:27:12 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2049.outbound.protection.outlook.com [104.47.55.49])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id
 40h27pcx7d-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 24 Jul 2024 17:27:12 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=vnPllNgal7DH1KAGU+Qhh3Bbg2ktJY2wXJq5Z8HQuwgNBjnIoM94vm4MfjqcWSG0tbVOKi5MJYyiZPCprsifFQacHHYs5EWVUIYRSVdW1uFAXpdQKZsPbHVjjpsbUviu6RCPjS6Dz9B/JRJNBTUsO5JpRz1LqDwTk3wWbt42gWUFpWT9SMIKYBXv7m85uyBBShcS2dhrShCfNGjbsVDCa4VYCsd1O2BvE9CoYMA+ac3Lr3fHRntSCqdYs4ENA6PqJ//igGqFGgdChXHfOzkjhDSSsiZ/uIrSE+b+aZjlmAQfJt/Gs8UtzfsmNhRRSwlyUX7U6h79ip5KycINjd5piQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=snu/0fNbXnqc3TignvjzKRjdN8mILYzG2A7Z9x2Grh4=;
 b=IyzebOef2Ec8z8+YIgKVSvYRvJNv55Oxm1slMv6qEvCDtngt8f4pxY3aZgo6RDOp0ralX+kQVo5VumGYa0KaZW6mhPN/h6xVJxUwwHnMScrBydddIMMx/o8lg6E6LuZ4M5LjfugeB/JLLhRpZ8m0y7l4Pu6DTEEcTXPr77hHYCDvZ/sPMNYHgqQHqfDFYbR4LjjlWZCCfJas32v+gsaLMlTPeFhs7qPV2Ea/nJOdMayco3FqVQcxJB55+/RIS5fqDAwGe+L9mkWYo2ImEHxefW5OJYSceFW0DvLeh2CSx+NDEy/sOeyFrKsclgqv81+j98tJqpqD60GB5dYWzXgNpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=snu/0fNbXnqc3TignvjzKRjdN8mILYzG2A7Z9x2Grh4=;
 b=A5MIP3ZMhG5EoiFFBsBcOqET6v2PMUifYMs6vkxalsP9dTNZ12V6wnkFhhcV4d9WGt9NVrocUbtcy3jiOteHhUvZa64KVAfsA7t1IiA6J0OJZ6ELxCr6YMMw0raj50UV9qebklWabmScYi32FgIJtDZAy5WTRjWvSFS4WlNY+Ms=
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19)
 by SJ0PR10MB4416.namprd10.prod.outlook.com (2603:10b6:a03:2ae::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20; Wed, 24 Jul
 2024 17:27:09 +0000
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::b75a:ef76:884a:dd27]) by SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::b75a:ef76:884a:dd27%6]) with mapi id 15.20.7784.016; Wed, 24 Jul 2024
 17:27:06 +0000
From: Drew Adams <drew.adams@HIDDEN>
Thread-Topic: [External] : bug#72229: (setq overriding-terminal-local-map nil)
 in isearch-done
Thread-Index: AQHa3eieu+5l6G6nFUC8ezJdNqSFArIGHpkw
Date: Wed, 24 Jul 2024 17:27:06 +0000
Message-ID: <SJ0PR10MB5488F4A66A3542A5DEDCFEA1F3AA2@HIDDEN>
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
 <864j8gsk4i.fsf@HIDDEN> <87h6cg856c.fsf@HIDDEN>
 <86jzhcyqb2.fsf@HIDDEN> <87ikwu213c.fsf@HIDDEN>
In-Reply-To: <87ikwu213c.fsf@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|SJ0PR10MB4416:EE_
x-ms-office365-filtering-correlation-id: dee32fd1-c52f-441f-7534-08dcac05d736
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018;
x-microsoft-antispam-message-info: aIwUh71aNM93dgkBMHtgVuPKKhrKXnqdQTQ2OPdMO5mogsRwgUrnKEC2LVaIWilmQGdkdBv2zl92FYYp8cCPjVZIlC6N6pxBZlQ5uAxKsxiUFU2nuGFa8jZa+QIPUBQdR1iuaJQ/wvvXtfc/35p0LIMvV89xOxTFtSPrTssc0UuroKEuEAeterUhY4B4qG7VOoKxn7h5Naii3vfL36akMZsO0T8xpjbLkfbXkey/pti4loYWjatyLSldwADq0Cn67QFPdDf1gMOt3Jx/QumBU7QCNIMOfklVM59oBaJZCHNRgnEk+MicddH+573hhZvQAY1VDyc+IN3+MFE43PYOzXRnWMJ85LqjYEDnRPHmbWNQCjaie0oyZCXKZRKaDFqVKgVSb058F6kLS4P9nqm8xUBsobfJLIyzGJCA5mlpddeg9r+6DXxHP9hLJNm9w8Ub8oT37Y8+oRqPlQZgljYmLniNpdAf0gZ5N6KHD0QnlRxV84puFxn99rReoI8mkUyDgVA+FfoLofVrvMj1gYDh/obuCFeJHA20IeBv/OkkHDukYjTtNGG+3ZS3ZrW5wQp2GVqY7fGUxmIpNbfAdqx6kvhqhTcuP+IVoqa7Ug54IEd/hQsoMMfmyVeJDdLdV6miisOXFFv9Qm5vCHoP4rhukNW4rz4k77fKLfiGQdD8p9GX3J79EiN/43JVC8PwQMG4gRxFCnfAzZBo4E2Q0EnhMhgZUeaXv1BSXcpJyKG3idgD4qLpbT2w20pV3Kbq6LacCggdMxpN7pfmg8um2m8wQZkqC0db0tefFZ5irNldpBRCeZ3i9VQyEh0JeWngw+A5ejCh2hjgyh8na8GP4H9y8u7RFQgwjEyMyR72Z08eycQOtyrqq2u6EAg7D0dXbQs7tDvEfCbC3B/9zOuRRWM4v03sZUmtoOfOCtytTykupJylQX8zDVgk5PIbj9ncw5rg0ISM4DwJkT78Oor9Vf16ltkX7PPgOsKKk1meVDlySOnEsdk1H6XoOlKKE9lSiPMlgFd+itE8msoj1T1N763/ZFoBdpWRQgelfAx36CoZ5PcIvJqQpD/RIjnBhZ9CFHiX0+Z4k3/pOFSTk+9Z+YdD47GO/vEPfg9Sh7hU1VQvpIvNzhcEffCHBoXhtb3CfuQKqOWZfGtT04VLr/EBzPcZa+DIBUigyPLdWrufqTaRaz/A6ozaZgfG22wixQ1LW12mzwQX4PuEEJR+M7GF4q6mArzx12a3jKUg78O4xtPTJop7ptG8BE2m7dhhz9EMLJus65Z7YapYP/XPC8vK/8oEp1KuXdz5tIb3r1CX63WEyPnDE/KbHEH1AEn4n9EGjHw07ZdtVb+vk8BAckS6CT5ByTwrKUX6chMTPwvLTPYg4QE=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: HgD9135xAzTyXbTkIJUJUkOHMO9+uBX6AqplNnukPUQHJdUvRWuHHoKANqOG78QtYpKMgK9o94YfIHxghJx3ZmZ6jZpkA3rRPeJk+SGenNZMjThxd3c4Moen0G8kxCz74GkermtGyW5PwghmQv5THUE+MGYrMCmbDJ1/SXGXGNMKDB7vHfatJOYsQKqDlarcT+pmJ7AFsP/U9op2DWQfMVmXMJrq4rRiu4J9MpEzoaHdGrxPslkPm4/byVQdLyBI+HidpMM7soAS/aQtXDNlLYiOShAMM9it8HS6oF54f2HLHV9D9P0VNyMXg90fulEat69huV7xKKrJhBbY22n1P+VVANu2S8SeN9IEmfm2h7tecEsjfcRLwnEPa/F41Tywxsnks7qtxsLkPpAaxE7DKQCUI/fcoVQ103538eLKsu0EPL1YLqHHFCZNpu3T1aoC3Xp5H70xqUerbti6zmjtIQ2qmh3t6/QzNMAAPqa0q+j7I1BbGHqR02I548maUSxepdq4VAGmP9e9U+LkGd0bTreQiOkuENiVm5Ln12YPHRx6SXaZ6RRDcF7RHTiUe9FpYk5cerGds7uDpiCG1mbu6XKeX4SwBcpiJsbHoQ3Q/nF29RGZt9I204fn0zLOoDGf7h4lLCe6WJ9xlD4N5vq7Hxg+2UOpKrA85SIH7TCGZ39PXE3xoZvg6mZK21Exs43pFC2CdImp2D/ViBOYT/rnclXHyW7E8g68w9FIXjDfcQIonD5OeN/VvVHDUYjbUwvuC0LJK5jWQW8p5aG9wnDo8fUYUoxdxM/aqnjALJT9on1o11UIibbUZtwUP3wQpsQzDCx/Bnt56WW/Aa0pZqq7bPeFFgCqXAi5pifvDYmMQv5QMY5Nda4a3X+z8du15I6IWwucf+CTamdywIjqle9nUPTTNV+8H4qaU/8swogkNEurRynzRZODPkb3xKhPCm8wXaCyvSBdG49+yhW/4maUzuKxf7JQD/Iii2kT+YujcaByQr+vt+W6OJGwpavgQCI4sB+HDteQ82zSJD5FvDbQZFHoDTI6cCtlScJWeifgZv6uStFr/o9H0TSSEFYj35xJYVWlHMEIzHYIfV6k81Y8X5HfkPnmVS5GJEcN+eOO2rkYmKAWOKlZnFi7JM/7k2C3LCEIwQufzCWaKtrFWwJTlaBblbr000CoHBX2S2EOo+5x1fqGzSOsHFe9bomFhSe8g7AU/IYPMqRZz8GTw3x7MFrA7jMdLswHtiKCHkF2Wu/hn+ZNJk34AKx5zgdSQumS3eetB0ADmRh+1xlS9IhfBzGDTvhU1KXbu6lVKXfWAwNXMQz/eBN9DlPZLe+oP88nLrFzE48iuTI0L0lnRu4xTnkQ+EUEOaF087NtBbpCjeFK+w/9xEBmzViFqds/AgpyJlsPFT/aWUUJ4uibNDLxLOzk6/qYBLEqR2YYQ/izKBYf0HifSciYcYxLWfCRWbpyXhfT+5vU9FhwPz5wwLrY/iXdl1k0hFHhb3SfZyehkItslU1/FMRTu3tlVL5OqyD0951zShs4qbN/tfIKubRc8szQx07wM1NR6XO508xxrkcGk528kwrQOmuCDil5sscY
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CSripBZuF7ATtoCqUUiDAPjvx/7p6yB3AQ44JXKjbftZg+3buKilhQVepH2z3qygmiw7G8Sn+7oWCOMq/pJv8GF0AcHpUyWbQaiAqpMmJsY3QdlpCLGEopGhxl7u/JUgKoMHko+8FWX97mcaVM9VBNYcbDOPphbHyQ2s7pGrs6rTkMvskk9tNoxMToIcCCcBQSj5219OG5JF/ICY2M30N6u8Vm0UOjHxiKx/JIW32lT/5rslmIY6nfHBx6tFR9ZkgpJIXX8XD6WzUWmrY4m66k+H3gOeViHC15F71frxR27oAP+T1aS9ImZwPym/+SdnMGkpKqvqV/yYHUqUCtzs5V96XcOMC1bku/5WqmRHD1ToY7uXdd8OaFe8222fbwNP1z1CgoDKD88VB3GSMvtMBGzm7MWItVEPBCzd7C2c+RpWsn/W3cBQBsCBvyHGK8S6RNtKtLvsj377N3/zPWKCYkT4qCv9fmAl4ac6/4LeVTRpggtvoJHFNV+hLe96M2ZiX0fgZz8bjVO7oaFhsg/SmMLsOz+hNmo0q7I5A+q87eKgOjEdmIn8Gw1HA+Qw5kBZbD/MDx20FufDf+LAiQbmPcKR6E8rpLIsogSuO3ysWZ4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dee32fd1-c52f-441f-7534-08dcac05d736
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2024 17:27:06.5155 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ULcnQ9bQ7s1rns1QXZj82XLVCwd1RHEca/C84NGneXbhrZZmbaaFvAXEuUTOA2i185jbUPD1sn7MgYkIJjg6YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4416
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-07-24_18,2024-07-24_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000
 definitions=main-2407240126
X-Proofpoint-GUID: zxZemnaWQgLVSRq6z-js8vuf8vBmA5ZJ
X-Proofpoint-ORIG-GUID: zxZemnaWQgLVSRq6z-js8vuf8vBmA5ZJ
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> > But I'm not sure is it possible to do the same with a variable
> > getter function?
>=20
> I think it would be unavoidable to change all code places where the
> variable is referenced, including those in C, to call the function value
> stored in the variable instead of referencing the variable binding.

I'm not knowledgeable in this area, and I'm not
sure what you're discussing (I think it's the
possibility of substituting a function for a var),
but would defining a symbol macro help?

We at least have `cl-symbol-macrolet', even if we
don't (yet) have `define-symbol-macro'.

https://lisp-docs.github.io/cl-language-reference/chap-3/d-i-dictionary/def=
ine-symbol-macro_macro

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 24 Jul 2024 20:13:02 +0000
Resent-Message-ID: <handler.72229.B72229.17218519396712 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72229
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Drew Adams <drew.adams@HIDDEN>
Cc: "72229 <at> debbugs.gnu.org" <72229 <at> debbugs.gnu.org>, Juri Linkov <juri@HIDDEN>
Received: via spool by 72229-submit <at> debbugs.gnu.org id=B72229.17218519396712
          (code B ref 72229); Wed, 24 Jul 2024 20:13:02 +0000
Received: (at 72229) by debbugs.gnu.org; 24 Jul 2024 20:12:19 +0000
Received: from localhost ([127.0.0.1]:34551 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWiLS-0001kC-Ng
	for submit <at> debbugs.gnu.org; Wed, 24 Jul 2024 16:12:19 -0400
Received: from mout.web.de ([212.227.17.11]:54701)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1sWiLQ-0001jv-7u
 for 72229 <at> debbugs.gnu.org; Wed, 24 Jul 2024 16:12:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de;
 s=s29768273; t=1721851885; x=1722456685;
 i=michael_heerdegen@HIDDEN;
 bh=KNlea7DEoTw4Y5kCXWbX7wOmgDn/TAqOeIoyysg/NwA=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
 Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
 content-type:date:from:message-id:mime-version:reply-to:subject:
 to;
 b=spaVQnMcTgrgtFlyXsymbVZa5T92xSPze9v5b52ddbSUo5Cn/At/g0Uiv6VPF1wo
 QyKEn1eFhd1ZVpf79a/Su8Z4XkDssouLLKQYlgpnTXdTPzbu5fbe473CXljgIH6U6
 rmkNA8t7SC2dPxveKr5FHkB/6x9PHK9PWZEq88ooHR4hiLbG17Lb9a/NmIOwQVf4T
 nryUPouMO3FaGwQCox40oezwdXLl48TDZFg94litLzcYlNJsPztsj02hSpyEiJMXU
 YVIw1AG+nW5KDqyK9VX4JXri9kI57QL4DF2hKUyAnJuVbxqng2WKJiVc85qTSg9o3
 5JUHwa9PJ9BnX6e/ew==
X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6
Received: from drachen.dragon ([84.59.210.113]) by smtp.web.de (mrweb105
 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N4eGT-1s7mkU26el-011Vdv; Wed, 24
 Jul 2024 22:11:25 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <SJ0PR10MB5488F4A66A3542A5DEDCFEA1F3AA2@HIDDEN>
 (Drew Adams's message of "Wed, 24 Jul 2024 17:27:06 +0000")
References: <87r0bmer66.fsf@HIDDEN> <87sew17fs1.fsf@HIDDEN>
 <864j8gsk4i.fsf@HIDDEN> <87h6cg856c.fsf@HIDDEN>
 <86jzhcyqb2.fsf@HIDDEN> <87ikwu213c.fsf@HIDDEN>
 <SJ0PR10MB5488F4A66A3542A5DEDCFEA1F3AA2@HIDDEN>
Date: Wed, 24 Jul 2024 22:12:10 +0200
Message-ID: <87o76mzh0l.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:MR9pAkBaOmp4T8Ds3xLDnXqTyraoXWBuJXN4m/jRH8AvzLOIRj0
 GM6xS5+gBlNgCqn2LO6N2osvEN0QXeosHV1Qs/Z1T6mHac4Skq1gcw3m/PbwbAStkH1Mqv8
 IxiqOHNYJCJ4lE9YpexJHqLvfFz5oD9Ws5Mlh/pGMWQv54yg2v2Gb3KHv/gsybvyGCppyNB
 yid29K3zR5minCnUUHe2Q==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:aHqQqGT3nqc=;2v6GBqLEr8ZTLc27l2Z7em3C50e
 Kr/dNYLw3kKPlbrINxhyiVpn1QxXDEe9d8e6TGTs2RU0oy3rKdnSsIY0T3khLqGT/7QXasNGw
 8krZAJ95bdujFzf8tK6guKpNcXGUNaKuaK+7FxgUdO2uVPw1luIZoio4ovYp8vs3yH4DD32P7
 TSDCv+3fH9Huwt4Jm/X2p9QI/Jz9uApCIOfmaShkFqZcP0WGZ703JXEPLue+FFtPxUcnTfhQp
 1hb+M7+c9OcvEjdrHVP5nLEUX5fTWpZHWHEQ9eCYgCaFc7zEAzV9vvy+3kQHD7Keo7yDD3KAr
 TQsR3UKw5nEWpdyro9Jri/Do4t9cOHRS90F8BKmImpPKm+2yqsSq9HYK7jhhKxGg9Vr2Id1GD
 9fm34eyLP5sIdwYoBNw0x6qjZWeHnQHBsvXz0xokk5ObnPSFF7OprNDMeafw52KAyqimRnJsh
 0GuRsGZasCc+LaunYbKgab5AZ6ezsGjIXBRqDwLn7uFh7M7GT72P5pNtU1v9rzbuCjC6wkm9p
 1C1N4JCKxiXepZo/6bU/pLV52SaBGJiaI1IAZb4CzLnC5YLdJRUVBr2oYYwsvpjiDyxz/4WGe
 uPPk2NjUpCiHb03+Nu0Oobr4w5kHBssr5OvccyzNs3nz4QWiCgCpdkEvag6m7+3eN8+vSFJNj
 2JeZd5CjoHv97gq42N0ZcSTvJbQJI16Hv1XirsiXmg1H2Eq1fhWr2xIFeBYCNxj4W6uMpMOq3
 DovLvnRHXGqxm/1o/5B2lSKqe+QCBp3YtpXhA4Lpen2UoUrdUL6gL9O+lY2Q3Oj49ovwkXXpz
 HpTG2HVDQ+Uh3jnNREYXIENg==
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Drew Adams <drew.adams@HIDDEN> writes:

> I'm not knowledgeable in this area, and I'm not
> sure what you're discussing (I think it's the
> possibility of substituting a function for a var),
> but would defining a symbol macro help?
>
> We at least have `cl-symbol-macrolet', even if we
> don't (yet) have `define-symbol-macro'.
>
> https://lisp-docs.github.io/cl-language-reference/chap-3/d-i-dictionary/define-symbol-macro_macro

We would need global symbol macros.  But even these would not be able to
affect variable references from C I think.

Symbol macros are also a bit fragile in Elisp, and some completely
dislike them (Richard for example).

So, yes, this is suggesting itself but would make the problem to solve
even harder, unfortunately.



Michael.

Last modified: Wed, 24 Jul 2024 20:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.