Gerd Möllmann <gerd.moellmann@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 72230) by debbugs.gnu.org; 23 Jul 2024 06:19:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 23 02:19:07 2024
Received: from localhost ([127.0.0.1]:59000 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sW8ra-0004FO-Pc
for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 02:19:06 -0400
Received: from mail-ed1-f43.google.com ([209.85.208.43]:49471)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1sW8rY-0004Et-2u
for 72230 <at> debbugs.gnu.org; Tue, 23 Jul 2024 02:19:05 -0400
Received: by mail-ed1-f43.google.com with SMTP id
4fb4d7f45d1cf-5a1337cfbb5so4973119a12.3
for <72230 <at> debbugs.gnu.org>; Mon, 22 Jul 2024 23:18:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1721715474; x=1722320274; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=rAThHSPyqvwDzGewmd+cIbyX4kSUPVVcMx8RMHyIvos=;
b=Iqe+dr1EJLF1WzUVqbf26ryfjd8ozRlrnZiGli4OrP5nLSBlNRqOqacdFE74Cl7oKl
0DTZsbiHH6BpYjP+cEJqDyzKC+/LPH8XkWQe0QgaLF3Wi+3wKnoHY2TKrsnPVtV/+cpR
9JRMSLhOBvoRyWTuORU/V5GIbsK1DYGzv3rN0qXakxmrmy1EAGDllUV/PARiD8peqsbT
EN6hK3peBB5aW2+30ncv4aFiu6QDXot6sBe5uQdKQDTxX9d3RWNIDo5fOYJxYCA3lp1/
QnnvUX8tcJZnIxi3TcKgUl0pinoxR9pHwRFY0uIwTkNwTRMjyyMW+WcUA9omliuuJSyf
Hu7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1721715474; x=1722320274;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=rAThHSPyqvwDzGewmd+cIbyX4kSUPVVcMx8RMHyIvos=;
b=popIpr97ICvAohI6YjLGWEVw6uDEj6zEyy9AwoaAQUeXvYbCaaECMf070h9/OnbXSW
ZZSXBnGFBOj/TxdvR/PP4V7Ijg+pQE6BHdrQRzatC1joXyWygokuZ7iFaWqaaMeJmwjI
IVrJqIgiWL/ckQ1Z/IGBbgipAYVxqu3POpJWH4ZCprg0tSqSQ2bYnZH43XkCilY/KrXV
uh/cabT22K7Okp21gv9dxt4TlYB1H4e0gGc3R3BjvgHVf63GNbdQfWe6D4pbygZ8imiF
0LcQugZ4dP/muVcY6IGeKWOErMh4DPlBuy2+XYktgDgy2qST3xOSjRYy+qFZxcuvF1Ww
LvHQ==
X-Forwarded-Encrypted: i=1;
AJvYcCUon/GH074ZV+TkkW8JqkegC+X+kdvy5QIiIVs2z4URt1iIZJLPqLdxT0uZTvR1BayyDH325dGwvJYRNjN9j6WbZqi467o=
X-Gm-Message-State: AOJu0YzbziOCnaSm0VWN+4EieDeG37Bh6xtU8Lr0/cf/TXHWorFZEjDJ
Nt8E3mmYUquVs2e8qSNMMBZwJsMJm7NqtFflQGOjCI9ARK84wsoRz252Sg==
X-Google-Smtp-Source: AGHT+IGFK6Djo66ppONzuDg/XlJp8ZU8qhlECg7bM2MJElfde3umm+yu+R4HxZpHConz36lBZj6baQ==
X-Received: by 2002:a17:906:f58c:b0:a6f:4b5b:4ba7 with SMTP id
a640c23a62f3a-a7a885bffefmr145917966b.67.1721715473584;
Mon, 22 Jul 2024 23:17:53 -0700 (PDT)
Received: from pro2.fritz.box (pd9e3603f.dip0.t-ipconnect.de. [217.227.96.63])
by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-a7a9144a7f4sm49528266b.58.2024.07.22.23.17.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 22 Jul 2024 23:17:53 -0700 (PDT)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text
In-Reply-To: <m2v80x53el.fsf@HIDDEN> ("Gerd =?utf-8?Q?M=C3=B6llman?=
=?utf-8?Q?n=22's?= message of "Mon, 22 Jul 2024 08:47:30 +0200")
References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN>
<86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN>
<CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN>
<86a5iabq90.fsf@HIDDEN>
<CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN>
<87sew2xju6.fsf@HIDDEN> <m2v80x53el.fsf@HIDDEN>
Date: Tue, 23 Jul 2024 08:17:52 +0200
Message-ID: <m2msm8my27.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72230
Cc: Eli Zaretskii <eliz@HIDDEN>, hermann sorgel <hermannsorgel@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>, 72230 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
> I propose the following as a fix. This computes the right rectangle to
> draw before that rectangle is set via NSClipRect.
I've pushed this to emacs-30. Closing.
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.Received: (at 72230) by debbugs.gnu.org; 22 Jul 2024 07:06:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 22 03:06:16 2024 Received: from localhost ([127.0.0.1]:56725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sVn7g-0005wG-DE for submit <at> debbugs.gnu.org; Mon, 22 Jul 2024 03:06:16 -0400 Received: from mail-oa1-f48.google.com ([209.85.160.48]:52576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <hermannsorgel@HIDDEN>) id 1sVeEP-0004BZ-1n for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 17:36:37 -0400 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-261112c303bso1479570fac.1 for <72230 <at> debbugs.gnu.org>; Sun, 21 Jul 2024 14:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721597728; x=1722202528; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Z+aDwRVhtqIjZzmKXL2gQ0j7ta4o5bhOvbNVVCEe4+0=; b=kBI0MuIa1w1VI22xDF0peT5ONftAPcSZ7gvpnotOpE828e1tyHQpWcmahitE17B8ny JQ3Eo/jehiO67gFtd+FrdyzmmLEnWeYRn6Hod4Er6/C7on2oDQSj2KqfZMKjwLlyKqli avl/zd53jJ5xUjCStPJZ1IAaGEiTMTM9dSoMB83WwBxoJFZYHNLyD4H1FLdvmzzcs7FA EBivAUh+aoGq8UlKjrqu9E12C/3gXXU8yPoZoDEJG3y+1pygtliVt0XQwFLllkSghIdG ZB7dKbqHJ/JsNgxIt/4jYaVwDLa6RxlIEfOvG/f+42tRkc2W5Nz/FK+EokO/9EOHgAJX dEcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721597728; x=1722202528; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z+aDwRVhtqIjZzmKXL2gQ0j7ta4o5bhOvbNVVCEe4+0=; b=DEFCPANsCp6hkkOQzriQGjZbgL7oXn6U4v374GohUV6pbs20XqEJPS9LgfHDQUSYRq Yp1wcAP1vVtCitjW6zh0ZOKz0ET4vpD4IY8hCxjXNj5iGpROpOnBa6Mzas7i5FmzcWow EWvLqb7wT2kuyPg6HJjO8Yks0z7DZaIBoTaHZXtCi1nO6ssVgwX4oUZPYeUkOSLoqIpU wsPkm/oMlQ02yFSrCTsRlWMtFTP3WOP+jT0jZfvAYKDt0X8cv4tQv1btzPmpZJlbJcQL IZJ1lVs5r9kLnGgjNz/YWaH73JTaAGpeqdQspMP+vCgtSEWptVetSYgXbDI4U1SCuSdV ICUg== X-Forwarded-Encrypted: i=1; AJvYcCX4FnnlSfp55yz4Ox5xySd1RKcUR6+tyoIjlTTEJaO4p2QuFD9TV3ARecpHmSKl2qLJx+nnkM5UWmuP4ub9P3YT46+6gZ8= X-Gm-Message-State: AOJu0YwsnVJeotTbvwfUQZLpTuWuHb5xT/89bvUtk6vh5vpxztiP8Y7I uaJVCyFJJUQ29Giu9b+LQz5meXBwg+CtUAoZPIMZ5prRRRRTVNCDRYC+yLAK46kCrRqdABEczb0 2ucXiQlTPxwxY5YW6Dvc4c5LLpOs= X-Google-Smtp-Source: AGHT+IFnumUm90UkuieVBZiG4IKIfvwlQFH5/pN0fSJrRzape7MvdNZFZDUwUGWN0O0C1NL/HlHEHP3U4JtfvpcVgaI= X-Received: by 2002:a05:6870:5588:b0:25e:d90:fe70 with SMTP id 586e51a60fabf-261216527d1mr5273531fac.43.1721597728491; Sun, 21 Jul 2024 14:35:28 -0700 (PDT) MIME-Version: 1.0 References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> <86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN> <CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN> <86a5iabq90.fsf@HIDDEN> <CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN> <m2wmlewpmb.fsf@HIDDEN> <CADwFkm=zQZmWYotKCTwHNt1gkc=wHF9oHgiknZMR5mFGiOxseQ@HIDDEN> In-Reply-To: <CADwFkm=zQZmWYotKCTwHNt1gkc=wHF9oHgiknZMR5mFGiOxseQ@HIDDEN> From: hermann sorgel <hermannsorgel@HIDDEN> Date: Mon, 22 Jul 2024 00:35:17 +0300 Message-ID: <CAPinL6Oq9RRcJ9Y0L7Zp-6+9QBEhCc_8PCGdMDFjnMTewg9FyQ@HIDDEN> Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text To: Stefan Kangas <stefankangas@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000000d8fc5061dc8b590" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72230 X-Mailman-Approved-At: Mon, 22 Jul 2024 03:06:15 -0400 Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Po Lu <luangruo@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 72230 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000000d8fc5061dc8b590 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, thank you so much. This works for me too. On Sun, Jul 21, 2024 at 10:26=E2=80=AFPM Stefan Kangas <stefankangas@gmail.= com> wrote: > Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > > > 1 file changed, 4 insertions(+) > > src/nsterm.m | 4 ++++ > > > > modified src/nsterm.m > > @@ -3137,6 +3137,10 @@ Note that CURSOR_WIDTH is meaningful only for > (h)bar cursors. > > if ((cursor_glyph->resolved_level & 1) !=3D 0) > > s.origin.x +=3D cursor_glyph->pixel_width - s.size.width; > > > > + /* Get rid of the clipping set previously. */ > > + [ctx restoreGraphicsState]; > > + [ctx saveGraphicsState]; > > + NSRectClip (s); > > NSRectFill (s); > > [ctx restoreGraphicsState]; > > break; > > > > This fixes the bug for me. > --0000000000000d8fc5061dc8b590 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">Yes, thank you so much. This works for me= too.<br><br><br></div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D= "gmail_attr">On Sun, Jul 21, 2024 at 10:26=E2=80=AFPM Stefan Kangas <<a = href=3D"mailto:stefankangas@HIDDEN">stefankangas@HIDDEN</a>> wrote= :<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.= 8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Gerd M=C3=B6ll= mann <<a href=3D"mailto:gerd.moellmann@HIDDEN" target=3D"_blank">gerd= .moellmann@HIDDEN</a>> writes:<br> <br> > 1 file changed, 4 insertions(+)<br> > src/nsterm.m | 4 ++++<br> ><br> > modified=C2=A0 =C2=A0src/nsterm.m<br> > @@ -3137,6 +3137,10 @@ Note that CURSOR_WIDTH is meaningful only for (= h)bar cursors.<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ((cursor_glyph->resolved_level & = 1) !=3D 0)<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 s.origin.x +=3D cursor_glyph->pix= el_width - s.size.width;<br> ><br> > +=C2=A0 =C2=A0 =C2=A0 /* Get rid of the clipping set previously. */<br= > > +=C2=A0 =C2=A0 =C2=A0 [ctx restoreGraphicsState];<br> > +=C2=A0 =C2=A0 =C2=A0 [ctx saveGraphicsState];<br> > +=C2=A0 =C2=A0 =C2=A0 NSRectClip (s);<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 NSRectFill (s);<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 [ctx restoreGraphicsState];<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 break;<br> ><br> <br> This fixes the bug for me.<br> </blockquote></div></div> --0000000000000d8fc5061dc8b590--
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.
Received: (at 72230) by debbugs.gnu.org; 22 Jul 2024 06:48:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 22 02:48:44 2024
Received: from localhost ([127.0.0.1]:56722 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sVmqh-0005T4-G6
for submit <at> debbugs.gnu.org; Mon, 22 Jul 2024 02:48:43 -0400
Received: from mail-ej1-f49.google.com ([209.85.218.49]:61898)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1sVmqf-0005Sq-2W
for 72230 <at> debbugs.gnu.org; Mon, 22 Jul 2024 02:48:41 -0400
Received: by mail-ej1-f49.google.com with SMTP id
a640c23a62f3a-a6fd513f18bso339102366b.3
for <72230 <at> debbugs.gnu.org>; Sun, 21 Jul 2024 23:48:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1721630852; x=1722235652; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=wIcb4XEuECg94+pfInjkQtf0ydR23wPRtw0aabzO7Yo=;
b=KN2uu7rEElcGg50jlH3VQvjKCQnC7/rfiuoRDjL7WgGsD+HEEN5m+CkUzT8UPdcdxt
NZ60dXdNUT7uBquv16uVR7geXLu1nldWvj0Aby/MDjeg88ejhwJIHKUwXz46dO/MOG+B
cjluIdhkraNU74baJeTU0NSuDtykLL+JYz2w26jO6BpE9jMXt43+56k5d8+RilWrPYOW
9OsCg+VxVREQTlTUKj2/xadh8Tt3TueOFZdfAl9PCQU7EtcZJAK3/v6Or/NLPAe6Hpgc
dmaS3s9NAESIgs44YQDlPR36lb8svK6LChHJXMrXpQkDT1dkLNs3AJFe6W4jhaVXAq2m
24nQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1721630852; x=1722235652;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=wIcb4XEuECg94+pfInjkQtf0ydR23wPRtw0aabzO7Yo=;
b=TC9OLUorjS7Dfq46pAy0nNs+m+I12sCrvBCgmwl9j2YXYv27CosDKjcV+mSKCf4DQZ
Bi32LGLi6lDPI4P1K3Gysp+arhybD2QEpjA69rFGnVPPwnxy/Y2yU/bb2tYU/ifWj9zy
T+c8XZDzD3SZF4/vFdnN2IP5l5qN7mcsDYwan8gulFj1Jf3AyjOrEgKYxKpCKBtDZzIf
MU5vDmIGw1DnPUNvyOd/1MRhr94D3naj8/cI/XA/Q+VkWxYlYApv4v2SUMfJ1m4P+S23
Ce5yo/CnV7iic+Qw05rpF114bSt0Mh6Ce7dmR035deRYtExOb+NHCsjg/KKhrFFQxduT
SfPg==
X-Forwarded-Encrypted: i=1;
AJvYcCXrxr3SfyapNn2nYAHvdo/4KIw39Br6lFunzm0i48TGpKaF1eq1YYIpukF/R80BPerSvvsxwrRNSFLZDFybBsDfer20h+w=
X-Gm-Message-State: AOJu0Yy3X4G/q+zm0eYLTY27ax9+hyLccjAyC55uAhOTvvDhOMnbEZaU
n9aMAjOq2JwNxwiaxknTFO3Xxq8RbXAXKUPlXe+eVKp2xc3446FuemN3Ow==
X-Google-Smtp-Source: AGHT+IHyHDpeeHKeWFXoJD0yiTaWV+/ZstypPKQSz0kKcrsfRgpgHQdbQYdiJcMFXaB4SVjchbM5NA==
X-Received: by 2002:a17:906:39c8:b0:a77:dd5c:d7f2 with SMTP id
a640c23a62f3a-a7a0111613cmr996073966b.5.1721630851972;
Sun, 21 Jul 2024 23:47:31 -0700 (PDT)
Received: from pro2.fritz.box (pd9e3607a.dip0.t-ipconnect.de. [217.227.96.122])
by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-a7a3c785e07sm379924466b.38.2024.07.21.23.47.30
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 21 Jul 2024 23:47:31 -0700 (PDT)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text
In-Reply-To: <87sew2xju6.fsf@HIDDEN> (Po Lu's message of "Mon, 22 Jul 2024
10:05:05 +0800")
References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN>
<86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN>
<CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN>
<86a5iabq90.fsf@HIDDEN>
<CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN>
<87sew2xju6.fsf@HIDDEN>
Date: Mon, 22 Jul 2024 08:47:30 +0200
Message-ID: <m2v80x53el.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72230
Cc: Eli Zaretskii <eliz@HIDDEN>, hermann sorgel <hermannsorgel@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>, 72230 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Po Lu <luangruo@HIDDEN> writes:
> Stefan Kangas <stefankangas@HIDDEN> writes:
>
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>
>>> So maybe the problem is elsewhere. One thing is almost certain: it's
>>> a problem specific to the macOS build of Emacs. People who can debug
>>> on that platform are encouraged to suggest insights and changes.
>>
>> This seems to have something to with the clipping path, and is fixed
>> here by the below patch. I don't think it's suitable for installing
>> though.
>>
>> Po Lu, since you added the below NSRectClip call, do you have any
>> thoughts here?
>
> Yes, this will cause the overhangs of a cursor glyph to overwrite its
> surroundings. There is certain to be some other factor that has not
> been accounted for, while mindlessly removing clipping operations is not
> the solution.
>
>> diff --git a/src/nsterm.m b/src/nsterm.m
>> index 794630de1c1..54b15bc851d 100644
>> --- a/src/nsterm.m
>> +++ b/src/nsterm.m
>> @@ -3102,7 +3102,7 @@ Note that CURSOR_WIDTH is meaningful only for
>> (h)bar cursors.
>> #ifdef NS_IMPL_GNUSTEP
>> GSRectClipList (ctx, &r, 1);
>> #else
>> - NSRectClip (r);
>> + // NSRectClip (r);
>> #endif
>>
>> [FRAME_CURSOR_COLOR (f) set];
>> @@ -3135,7 +3135,7 @@ Note that CURSOR_WIDTH is meaningful only for
>> (h)bar cursors.
>> on the right of its glyph, rather than on the left. */
>> cursor_glyph = get_phys_cursor_glyph (w);
>> if ((cursor_glyph->resolved_level & 1) != 0)
>> - s.origin.x += cursor_glyph->pixel_width - s.size.width;
>> + s.origin.x += cursor_glyph->pixel_width - cursor_width;
>
> I don't recollect what `s' is supposed to represent.
I propose the following as a fix. This computes the right rectangle to
draw before that rectangle is set via NSClipRect.
1 file changed, 8 insertions(+), 12 deletions(-)
src/nsterm.m | 20 ++++++++------------
modified src/nsterm.m
@@ -3026,7 +3026,7 @@ External call (RIF): draw cursor.
Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
-------------------------------------------------------------------------- */
{
- NSRect r, s;
+ NSRect r;
int fx, fy, h, cursor_height;
struct frame *f = WINDOW_XFRAME (w);
struct glyph *phys_cursor_glyph;
@@ -3076,6 +3076,12 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
/* The bar cursor should never be wider than the glyph. */
if (cursor_width < w->phys_cursor_width)
w->phys_cursor_width = cursor_width;
+
+ /* If the character under cursor is R2L, draw the bar cursor
+ on the right of its glyph, rather than on the left. */
+ cursor_glyph = get_phys_cursor_glyph (w);
+ if ((cursor_glyph->resolved_level & 1) != 0)
+ fx += cursor_glyph->pixel_width - w->phys_cursor_width;
}
/* If we have an HBAR, "cursor_width" MAY specify height. */
else if (cursor_type == HBAR_CURSOR)
@@ -3126,18 +3132,8 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
[ctx restoreGraphicsState];
break;
case HBAR_CURSOR:
- NSRectFill (r);
- [ctx restoreGraphicsState];
- break;
case BAR_CURSOR:
- s = r;
- /* If the character under cursor is R2L, draw the bar cursor
- on the right of its glyph, rather than on the left. */
- cursor_glyph = get_phys_cursor_glyph (w);
- if ((cursor_glyph->resolved_level & 1) != 0)
- s.origin.x += cursor_glyph->pixel_width - s.size.width;
-
- NSRectFill (s);
+ NSRectFill (r);
[ctx restoreGraphicsState];
break;
}
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.Received: (at 72230) by debbugs.gnu.org; 22 Jul 2024 02:05:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 22:05:30 2024 Received: from localhost ([127.0.0.1]:56426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sViQc-00030e-EZ for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 22:05:30 -0400 Received: from sonic316-21.consmr.mail.ne1.yahoo.com ([66.163.187.147]:36257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1sViQZ-00030R-Pk for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 22:05:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1721613919; bh=q7T6QSye1Yw28pFfR51GcS0Rx9zU1wD6tGFkvbCKdw0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=XMH5h6qc2IAx4OCiemm1InayDcGh+RRRaZ/KoIpv75YSmDnSNJFshh/nde6rATtD4HgfxOYDWLWZUEI8n4L1B47jFPF6nAsL0jvQCS0UHM3nh8NhLaT5l3e7C+09V5n27NpI7H3KlYg2VbV9Yb5aASHpgpgy+AOrIlKujPJfjbjfMmkpUFh1/aWnZ8954LFo3IKbe0+yKLWD9TNYNJPbbfQIb3vA11BNsVm7oX7eIrTPFhp9L33a8mQOYFxknKnj1NnebSSJJPTJ6hmWaKhZXm/7F/+Mwaoud4Ljl3Mvt+0Lzov9LLWWzbUPVTwTdGGjL+z2ObxnLTLs/kzEEhJHCw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1721613919; bh=4z1PA3i/HRwXQbuIfFTTx85pgzLP5yvhBdYtJtRPt8Z=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=tdaTpw3ydmblN2mx5WoJRkJ+lXAN582sgN36TXQDaUjH7eYb+uYDz2qdR8rHQWwQXW8PJM3F8xrHZZ6uHcgGTmmBXcYW96o9T5a3T3ubphNc9VPZmsMpESuSM1UTRaqkbX3p6xSuDMo4b8qwZDBq9nbCX78Z9yaVqmuDeOfgjuhJjtdrif7Kb2G27ylrMlAk0GAHouIrDVWGhI1hM5Ad7MtH4RqZQlwZt4508Eoyj30xFaQJq2UTlnLgvXkYI99/qpGFsafoTEz+W3M2hG46qdh0/MG7P1kYlBz1hPNqpy0WCy6ubawHb1QGqjxKW9iI1DGK5swxPK+nc1lyAMubzA== X-YMail-OSG: R6kCxTMVM1nhCWxUBmhOZcDeY_Rb79suVNoJHxIP410EkLmYEAZcf_DTj682RLQ fjhJXiwQCaqLNmwTOIvgq9yLYhrAtCTlxjqcg74xZxzrQWHnhvRLF3qzfa9RWCpY8y0P3hPEfXx2 L5hoU2NPsK9fJrkOdz.F_kW5E0OTiswgEoxCPvVflDspea3Cl8RNS3Y98N9M0CgG1raeFRrbl55. XSQjOkiNwiz3LfoLRxEJcWaUMPjZdTlnuoiWZHVeUtGyYVprYhJ1HdJzc4MkCf2pRc6Llm2Opi5m woZLh6qygtAVLd90mawaUpUxUWbUoo.NXTftyLuvGnpEmIdLAS7VCfpZSdQivkU3wMs9vRWG3k98 9rag3g3DYb.axkF6S0WlPAxYGiB_g1djPpNsYs1fR0R2kphuljhlZ_gYLu_0JUvjYhH02e2cIbSR a9Wn8zLqAEcg8WoT8PGojB_D_Stluxoc7NUAqGtpoDLj2lW4Adspmtei1tXP2LlNTIGEf5.y2L7F a5wjLQovKjDo741SUme3dwHWkosbUssrV4WAFLM27vRkCI8gUTwKzGZi06.UAhvPIHaMPC3RivWp 7CmRW7i0S9vWdwZrvJyb_kHGkSUZPzo6MqrheM4fw6P8DjYvqdX67uvHz4nw3Bw3RT6m8YGFDBYR ySYPDvirytBijxfjJ2wIJxW1vqGYy8TF95BFWofrKzFbxZJA.H0A7_36zDi59jGDXvdWDbVyIKAL u0kwYIBgfV_tNWqzJcsJENsi9itvvi3r4LMzw2ozDxbpe7uF215bPKxj97.PP9rEqFWzyNLxgPf8 qHnvXkbMsBV.zTFsLJMYMCZWAph8puLJSl0eazj3UknhldK4E6mmJpt.CcR0RsS_2ajcHAido3pm hlZZyjIuD5_EWmSlRRyRsnM17D7QR7sY_bvKnphf8jaCtPMTmC2TsRpTeYiO9pgKICR3QhXYj2FZ HIsvdnsnh6OZ0GaYcjNMwzrBK_7RSEg.8_dYBKdi_PW5qFfy_PrW_E7Vu3mLLjPggPrk6b3F.BJF 2Fs6eCxIN5rVarptqhZMKUDLNSKtSwY7_D5v2rQeHEVWcxT4GRyjPIIIF2.M5rBheT0iSyqv8_qq cm4Okdp3t.Mdzqymi5lykPlEFT8Jaw_S68dUJ.oBBJOGu94QIwGl.VpiSZ73TwKMbmOdvlbs487E 9pSk0OFoJYt5K9omgfxHwf6gVPYLVm0PEC.mdzGKoc.cJBvkykelKlL.J6ZeerYhPAAMyPTbyiri okEvR.Ci4sat301h1HuSBIqoz0cZfjQUvFJQCd.xDjI7PB_q9ggFspwd.KzIAuz.4i8oNQuC1o5N n3ptnK4mDgVBfpDED215CVlKV23R_L8e4YGBvOZ_DxeWPuVfslCXNcYjbvBeo1AZYEv.gDTcZTVn xELUC1vHJDiSt6x2JbxSMXLIkkOTgigUoEkawG8hfbQE3aATOx0zimsEcO3msep18yWR_vPHsORe dr0nBs8m818XALRy_xaW8ySnFMH2LacQudAtTIg0dvbaUmhTn2CeFSn2NpqvN_XxcSwZre.CzA16 o0UkeTO2M1rGSHGp5jFGb0eTjSL5wYTMwQaskCMhzy4dOetfhUwrdIRX8vXoXSo9Fyds6W6XjhXy j.8XYLLeQPfhdj13vrKi8KgmAbcxBBlZx.aPyoQMA4OT5KTS441hmUonSxXioDMWnGC5DytXnMrS CYBZQFkoqKo7pw1Di23rqMk7BhMYtQgrRJbn6o5j7xHwapOGcxWE5CIjZMAKkfQnGwi3jd.TNJbK MUsUjLmKcdEx3urUgzOCtca5ZqaEm82gP3A0h0pDX6RY5C7GfzKhBi0KR616acQQwUnH7vi0eTBy wsMOioq4dICnkJv3HVpRimS72aOSmG9fPDP7oF6yKHrxuqA4AAVxwXDEA7KcR15xOgwk.Z7J.MW6 Wr5McPI.2FbcOrUzckV_qub70MQbZi40Dx3t2d6wsFWAp90tJszQlD.Ryz3aL8aoSGuuuVOHIrye Al3TXXQcoU16YfFkwUpRsKsYGfG6w3qgm1LKABGAYriOobnkHHJvhe2SzZDuPrctaq_xage37pb2 PFmZ1_FhGrzgj_YlLt..s6yU.YWHwzv3.Ox1hq500ybzatJZxv8ZwNUp2Pa9O4LUveapGta329P3 tdXysbMk0S7D4eaM45w.UKRaETkCUsxX2VlpxQO8tI73NJEI9gcqyH.D_FxPEBZA4AwBcEv9k4X2 Ic5EfH8BLxenplpMmtCe0PSC3im2Ic1NcAZr8KkURgAV.kwEk X-Sonic-MF: <luangruo@HIDDEN> X-Sonic-ID: da1cc6f3-ec90-4a38-b34d-76ebdee76de1 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Mon, 22 Jul 2024 02:05:19 +0000 Received: by hermes--production-sg3-85fdb5cfc8-ls28f (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5d1cbfae47ba5dd4f33f05b82aa211db; Mon, 22 Jul 2024 02:05:15 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text In-Reply-To: <CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN> (Stefan Kangas's message of "Sun, 21 Jul 2024 11:05:57 -0700") References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> <86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN> <CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN> <86a5iabq90.fsf@HIDDEN> <CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 22 Jul 2024 10:05:05 +0800 Message-ID: <87sew2xju6.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.22501 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1594 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72230 Cc: Eli Zaretskii <eliz@HIDDEN>, hermann sorgel <hermannsorgel@HIDDEN>, 72230 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Kangas <stefankangas@HIDDEN> writes: > Eli Zaretskii <eliz@HIDDEN> writes: > >> So maybe the problem is elsewhere. One thing is almost certain: it's >> a problem specific to the macOS build of Emacs. People who can debug >> on that platform are encouraged to suggest insights and changes. > > This seems to have something to with the clipping path, and is fixed > here by the below patch. I don't think it's suitable for installing > though. > > Po Lu, since you added the below NSRectClip call, do you have any > thoughts here? Yes, this will cause the overhangs of a cursor glyph to overwrite its surroundings. There is certain to be some other factor that has not been accounted for, while mindlessly removing clipping operations is not the solution. > diff --git a/src/nsterm.m b/src/nsterm.m > index 794630de1c1..54b15bc851d 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -3102,7 +3102,7 @@ Note that CURSOR_WIDTH is meaningful only for > (h)bar cursors. > #ifdef NS_IMPL_GNUSTEP > GSRectClipList (ctx, &r, 1); > #else > - NSRectClip (r); > + // NSRectClip (r); > #endif > > [FRAME_CURSOR_COLOR (f) set]; > @@ -3135,7 +3135,7 @@ Note that CURSOR_WIDTH is meaningful only for > (h)bar cursors. > on the right of its glyph, rather than on the left. */ > cursor_glyph = get_phys_cursor_glyph (w); > if ((cursor_glyph->resolved_level & 1) != 0) > - s.origin.x += cursor_glyph->pixel_width - s.size.width; > + s.origin.x += cursor_glyph->pixel_width - cursor_width; I don't recollect what `s' is supposed to represent.
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 19:27:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 15:27:59 2024 Received: from localhost ([127.0.0.1]:56078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sVcDu-0000p1-Vx for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 15:27:59 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:61516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1sVcDt-0000on-42 for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 15:27:57 -0400 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-58b0beaf703so2432004a12.2 for <72230 <at> debbugs.gnu.org>; Sun, 21 Jul 2024 12:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721590009; x=1722194809; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=nf+qBS/83sDu+TClPV1kbvwpD+g6exbK/qUCz0UQB54=; b=DVl/0LvoDHFzFVdyYhrsRQOSQqewEEpJGqNIlvyZhFgm/HopDZrgxEzz9IJnPU1Ftk 5+dWffXlUUOQLZH6HrmIjxhz0Dd2HGxfZepJ11JOdhjo6dxjPpf1pwu+td6Z4eqKxVYX jB7hw42/GJf1Jilw25GpLYLK47VKO4bG5I2lnoRMOIpwawhPUTmKcCHVKivcB2AWIeAa BoJwyiq7whbePJLVHS0YwwmbhmnCgDRYn1Ty4PMIolEhdMIBDMeQJKQZ8Vsqxz7xuDUN bHPpbWttH+QH/QzIwdsgepfvJKjHwkbrhKvG4Z9veIzyTQZh+sdnbFurGijBhsecx3d7 WOxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721590009; x=1722194809; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nf+qBS/83sDu+TClPV1kbvwpD+g6exbK/qUCz0UQB54=; b=KwZc+8hcjL/r4mvQqQb94+MaPT+EaPXu6C7/RlTNrgJwI7vJz0nkLMNJTX/IH6gSzM bAu9WUvx1YwQDW05OLkhLktWLakgktCRJOXRAXDQTJHQT7+0+BcUdOfjT0YmRTl4pe7P ONyWJRHbIdgTixNAr0yj0JQ+v6GzEBYmTnOoo9YSJSEGjZv6KpX76lEUHznK68s+LM+2 oAUMvxHGqsCep6OH25/h3IGNdprVVQxsJ7vZ/sG5Plm7yAnKSdl5nn6aaBgdLM2cIwxR nO6pmwHPcGpr9nil1ve5qbAUNdjAgmXl8jrqfg1HYul+TM18aTYcknvn7BUOpdu8PmfK bfhA== X-Forwarded-Encrypted: i=1; AJvYcCWUFdmjk+pLct6HwH7cSo8BPqqqUZERw6/A6l072yQkpjLaN0OxcDESAEx9GBKgp92fy+ouhmcMQ/F55RD6FTookjrfj8A= X-Gm-Message-State: AOJu0YzGVpAb9r1gbDmmHF2wDS0Fww/Kty634ogWZbiWtSayxYLAVN7p ocorBLxrwhtL9i5lMjErR/zGkqttk1OYacDOEUGwmip5QVwR8+urwoUBazZiTOg6IcA/Zt9hnA0 9KEaiFiOive62N1zsiSmc77fP35s= X-Google-Smtp-Source: AGHT+IGFrbqDfQZbn3qa+ryn69ilVvN4yOqzV153VFwodtTRHZIjGEm71MYArelnakwqf2uIzdpNk9vyGqivi7G0q2g= X-Received: by 2002:a50:f69e:0:b0:5a1:cb3c:bd3e with SMTP id 4fb4d7f45d1cf-5a3ef37a4f4mr3774884a12.20.1721590008953; Sun, 21 Jul 2024 12:26:48 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 21 Jul 2024 12:26:48 -0700 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <m2wmlewpmb.fsf@HIDDEN> References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> <86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN> <CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN> <86a5iabq90.fsf@HIDDEN> <CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN> <m2wmlewpmb.fsf@HIDDEN> MIME-Version: 1.0 Date: Sun, 21 Jul 2024 12:26:48 -0700 Message-ID: <CADwFkm=zQZmWYotKCTwHNt1gkc=wHF9oHgiknZMR5mFGiOxseQ@HIDDEN> Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72230 Cc: Po Lu <luangruo@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, hermann sorgel <hermannsorgel@HIDDEN>, 72230 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > 1 file changed, 4 insertions(+) > src/nsterm.m | 4 ++++ > > modified src/nsterm.m > @@ -3137,6 +3137,10 @@ Note that CURSOR_WIDTH is meaningful only for (h)b= ar cursors. > if ((cursor_glyph->resolved_level & 1) !=3D 0) > s.origin.x +=3D cursor_glyph->pixel_width - s.size.width; > > + /* Get rid of the clipping set previously. */ > + [ctx restoreGraphicsState]; > + [ctx saveGraphicsState]; > + NSRectClip (s); > NSRectFill (s); > [ctx restoreGraphicsState]; > break; > This fixes the bug for me.
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.
Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 18:46:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 14:46:44 2024
Received: from localhost ([127.0.0.1]:56062 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sVbZz-0008Hg-NK
for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 14:46:44 -0400
Received: from mail-ed1-f47.google.com ([209.85.208.47]:60884)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1sVbZx-0008HT-Iq
for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 14:46:42 -0400
Received: by mail-ed1-f47.google.com with SMTP id
4fb4d7f45d1cf-5a20de39cfbso2629465a12.1
for <72230 <at> debbugs.gnu.org>; Sun, 21 Jul 2024 11:46:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1721587533; x=1722192333; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=J30S0VWt9/XBo2k9zFu+m7AODhkSfLOoBIFl/1GtADs=;
b=Xbp07xaLdMIZcrz8hm6SRyCX8CtR2wUZlBLhHhoIlaoLlh6D4OOYYgkG1u9X8ADjBg
L9qpQfJLSA2UwMJ4ZwYLrqmlefK0VRF5hdemgUHwhcU2KWa7dMk1JZvel6WaG7IFmn+O
Wm8i4z5TzzRWdqcyK+p7MvSeRU1F+or/o9SJoevm0yKno0Joi6++DCgO3i+BP0bZafFB
vu+wZ+TYKA+hia5evkM+yJMR7WY0TATOflvAlJDF9CnZWgRQVJ/ZlhU0+Drxp6U+YdMD
e0p3kPhpjJaMp1YVf0xV7BV0OW9i/uVuVJ8GcW6RJmjVRckbFItlJT50BH5MYx5Sjrt9
+4qw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1721587533; x=1722192333;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=J30S0VWt9/XBo2k9zFu+m7AODhkSfLOoBIFl/1GtADs=;
b=j3kkTnsqAHC1eETQmW/3OsI9AXCccWNEjrCxffeiI4LXmeVdFxS3UlDZCzEFgp1pms
Rsjqp9vQX0oFnUAqryozfOFptaXMY3ghccbFZFCBU0GQ6uPFWF+olcHgE15w6eDOUAuo
GnbYbmpLMGgaPWL6030YZbbNSMg4U2tvdgUu83ayR291WwEt061OFmgtiUuNRC2WGZdr
VslF/AiLfCH67Of++vCRUYhj7OX2vAlymTvyVhrihmvlMELBaqmuu62VNH3E31Vt/EH6
lWuqiuvddTAoNNodrByIboU5xPcOtsU+c4/NeTwcJA72VrTuGPIA6re6CJr0Gr34PzAf
uegA==
X-Forwarded-Encrypted: i=1;
AJvYcCXfNN//CY/a5cCBxfl1R8/yIjX49d56+3EJZbPkgago3ERR/4jy/aVL6KWt+vVHo7MGsUzd/ePxO1qKIv5usXs1IsDxyEE=
X-Gm-Message-State: AOJu0Yyrzf9xg8DlcLP9yW0Cwo8rYWe9nTXn9HwLK0yA+K2iMqRwpjxT
HgT9IhvkKcnS/eM986jjpW6aLFxJqNxN5spvfAYd7s2lQ0B7Fv4lnbl1ig==
X-Google-Smtp-Source: AGHT+IFnQUzxpp0gKBxZBXiLXYq+enFtAbcoBED8NGNHoMHkX8qtDnEOGmzvlT/wQnmZ23EcxseXlQ==
X-Received: by 2002:a05:6402:3584:b0:59c:31fd:266b with SMTP id
4fb4d7f45d1cf-5a3f08931a3mr4732705a12.28.1721587533434;
Sun, 21 Jul 2024 11:45:33 -0700 (PDT)
Received: from pro2.fritz.box (pd9e36c76.dip0.t-ipconnect.de.
[217.227.108.118]) by smtp.gmail.com with ESMTPSA id
4fb4d7f45d1cf-5a30c2f88a5sm4841762a12.77.2024.07.21.11.45.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 21 Jul 2024 11:45:33 -0700 (PDT)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text
In-Reply-To: <CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN>
(Stefan Kangas's message of "Sun, 21 Jul 2024 11:05:57 -0700")
References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN>
<86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN>
<CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN>
<86a5iabq90.fsf@HIDDEN>
<CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN>
Date: Sun, 21 Jul 2024 20:45:32 +0200
Message-ID: <m2wmlewpmb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72230
Cc: Po Lu <luangruo@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
hermann sorgel <hermannsorgel@HIDDEN>, 72230 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Stefan Kangas <stefankangas@HIDDEN> writes:
> Eli Zaretskii <eliz@HIDDEN> writes:
>
>> So maybe the problem is elsewhere. One thing is almost certain: it's
>> a problem specific to the macOS build of Emacs. People who can debug
>> on that platform are encouraged to suggest insights and changes.
>
> This seems to have something to with the clipping path, and is fixed
> here by the below patch. I don't think it's suitable for installing
> though.
>
> Po Lu, since you added the below NSRectClip call, do you have any
> thoughts here?
>
> diff --git a/src/nsterm.m b/src/nsterm.m
> index 794630de1c1..54b15bc851d 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -3102,7 +3102,7 @@ Note that CURSOR_WIDTH is meaningful only for
> (h)bar cursors.
> #ifdef NS_IMPL_GNUSTEP
> GSRectClipList (ctx, &r, 1);
> #else
> - NSRectClip (r);
> + // NSRectClip (r);
> #endif
>
> [FRAME_CURSOR_COLOR (f) set];
> @@ -3135,7 +3135,7 @@ Note that CURSOR_WIDTH is meaningful only for
> (h)bar cursors.
> on the right of its glyph, rather than on the left. */
> cursor_glyph = get_phys_cursor_glyph (w);
> if ((cursor_glyph->resolved_level & 1) != 0)
> - s.origin.x += cursor_glyph->pixel_width - s.size.width;
> + s.origin.x += cursor_glyph->pixel_width - cursor_width;
>
> NSRectFill (s);
> [ctx restoreGraphicsState];
Erm, once is enough :-)
1 file changed, 4 insertions(+)
src/nsterm.m | 4 ++++
modified src/nsterm.m
@@ -3137,6 +3137,10 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
if ((cursor_glyph->resolved_level & 1) != 0)
s.origin.x += cursor_glyph->pixel_width - s.size.width;
+ /* Get rid of the clipping set previously. */
+ [ctx restoreGraphicsState];
+ [ctx saveGraphicsState];
+ NSRectClip (s);
NSRectFill (s);
[ctx restoreGraphicsState];
break;
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.
Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 18:44:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 14:44:09 2024
Received: from localhost ([127.0.0.1]:56058 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sVbXV-0008D6-0r
for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 14:44:09 -0400
Received: from mail-ed1-f49.google.com ([209.85.208.49]:53630)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1sVbXT-0008Co-HT
for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 14:44:08 -0400
Received: by mail-ed1-f49.google.com with SMTP id
4fb4d7f45d1cf-5a15c2dc569so1265972a12.3
for <72230 <at> debbugs.gnu.org>; Sun, 21 Jul 2024 11:44:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1721587379; x=1722192179; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=SZsumlNIHKT3dWPfrVBtXfzhzPV8EL9aTYQ82v3/gAM=;
b=AlELhEaeP5epYsFAV1F20wJmOlmHICV+yVmaeek/CMvFDUfm5KL028Wvqx+AJe6Cnu
93mcTGZgcJTG1oJL+eGZbUe1lQs5sDjJwU37cNVyYOpis8PtBNAzGn4RYCtxs0FXIzrS
osvmFMFBMabkjwj92WJxVg9mLNhMoDIMQxKdJR5eE8mUHjmKRqOlfeAX7O6/8N/7tRwg
QBT7icFEYisD6HvY7QI4qX7agrx93js0cPAsFqQMUookZ/L7Yf9xKNcyaUqe3TZNns6d
IvLcQGUAeDwctU4i2eKdfjeYXx9XzP24I7DwjvJqImFGq8hr/EN686+uZoZqdAaKqTXw
d/1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1721587379; x=1722192179;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=SZsumlNIHKT3dWPfrVBtXfzhzPV8EL9aTYQ82v3/gAM=;
b=twNwVRawLWjYCSI3Td1tBXVAgB9xxlfOY6qkcYJ8a3Jm5GeUyThhSCcebkbJvCR1n8
BE8ugt6xONQ/pKNmMASrkh9b+sXq3zIvDBG2krxY0lqOUUSOCzUDRXRnHBGfYm0MZ8ub
MF6DEkf/AwCLixzyYEd7qcUpzSrmIw22R+hqT8T6YPJUKsccSviBPcgX4lElWAj0hbZO
BNh6La0dehWiUV2J4moCH7A+tUrOZTclVGNub7SY7FniTlLpyYrP5KE3aHnQB+aOmP8i
v8PJKn7caPJjB0GR+OcDRUBzhZja5MWiedHTlS6Aen8ZLi5mKvufCFtLHAc+M2suf//y
GeRw==
X-Forwarded-Encrypted: i=1;
AJvYcCVBch9gjU7RKWjO98QgbBhw4BFBTP1EJ9uBcaMRUXptDhnwu8IjairkjdN53BJ+0P2KaoR5Cpcs3bDHWn/0M4WZvdzsIJc=
X-Gm-Message-State: AOJu0Yzdx6a68OkK/6k/qjjQKa/oPyusiy9H0QqPgM1y9xyltoR/1E/i
Ig12S8NvHVgu3g0FmznSIU9IeJ1Wolod60SBmNni84NOu5uTzwmD+eCd+A==
X-Google-Smtp-Source: AGHT+IGvHfFzCEBFO/XfpswNv4BNCDEXyh59kinGl9dwmnUIqlq9/LdAWURfBaHkuN6N257Vd2QH3A==
X-Received: by 2002:a05:6402:2681:b0:58e:2f7c:a9c with SMTP id
4fb4d7f45d1cf-5a47b1de140mr3602213a12.26.1721587379156;
Sun, 21 Jul 2024 11:42:59 -0700 (PDT)
Received: from pro2.fritz.box (pd9e36c76.dip0.t-ipconnect.de.
[217.227.108.118]) by smtp.gmail.com with ESMTPSA id
4fb4d7f45d1cf-5a30c7d326csm4810059a12.86.2024.07.21.11.42.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 21 Jul 2024 11:42:58 -0700 (PDT)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text
In-Reply-To: <CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN>
(Stefan Kangas's message of "Sun, 21 Jul 2024 11:05:57 -0700")
References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN>
<86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN>
<CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN>
<86a5iabq90.fsf@HIDDEN>
<CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN>
Date: Sun, 21 Jul 2024 20:42:57 +0200
Message-ID: <m2zfqawpqm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72230
Cc: Po Lu <luangruo@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
hermann sorgel <hermannsorgel@HIDDEN>, 72230 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Stefan Kangas <stefankangas@HIDDEN> writes:
> Eli Zaretskii <eliz@HIDDEN> writes:
>
>> So maybe the problem is elsewhere. One thing is almost certain: it's
>> a problem specific to the macOS build of Emacs. People who can debug
>> on that platform are encouraged to suggest insights and changes.
>
> This seems to have something to with the clipping path, and is fixed
> here by the below patch. I don't think it's suitable for installing
> though.
>
> Po Lu, since you added the below NSRectClip call, do you have any
> thoughts here?
>
> diff --git a/src/nsterm.m b/src/nsterm.m
> index 794630de1c1..54b15bc851d 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -3102,7 +3102,7 @@ Note that CURSOR_WIDTH is meaningful only for
> (h)bar cursors.
> #ifdef NS_IMPL_GNUSTEP
> GSRectClipList (ctx, &r, 1);
> #else
> - NSRectClip (r);
> + // NSRectClip (r);
> #endif
>
> [FRAME_CURSOR_COLOR (f) set];
> @@ -3135,7 +3135,7 @@ Note that CURSOR_WIDTH is meaningful only for
> (h)bar cursors.
> on the right of its glyph, rather than on the left. */
> cursor_glyph = get_phys_cursor_glyph (w);
> if ((cursor_glyph->resolved_level & 1) != 0)
> - s.origin.x += cursor_glyph->pixel_width - s.size.width;
> + s.origin.x += cursor_glyph->pixel_width - cursor_width;
>
> NSRectFill (s);
> [ctx restoreGraphicsState];
A clipping path set with NSRectClip is permanent, and the only way to
get rid it is to restore the graphics state. This seems to work:
modified src/nsterm.m
@@ -3130,6 +3130,8 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
[ctx restoreGraphicsState];
break;
case BAR_CURSOR:
+ [ctx restoreGraphicsState];
+ [ctx saveGraphicsState];
s = r;
/* If the character under cursor is R2L, draw the bar cursor
on the right of its glyph, rather than on the left. */
@@ -3137,6 +3139,10 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
if ((cursor_glyph->resolved_level & 1) != 0)
s.origin.x += cursor_glyph->pixel_width - s.size.width;
+ /* Get rid of the clipping set previously. */
+ [ctx restoreGraphicsState];
+ [ctx saveGraphicsState];
+ NSRectClip (s);
NSRectFill (s);
[ctx restoreGraphicsState];
break;
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.
Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 18:07:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 14:07:08 2024
Received: from localhost ([127.0.0.1]:56020 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sVaxg-0007AL-Ah
for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 14:07:08 -0400
Received: from mail-ed1-f46.google.com ([209.85.208.46]:57681)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1sVaxd-00079m-UF
for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 14:07:06 -0400
Received: by mail-ed1-f46.google.com with SMTP id
4fb4d7f45d1cf-5a156556fb4so2483555a12.3
for <72230 <at> debbugs.gnu.org>; Sun, 21 Jul 2024 11:07:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1721585158; x=1722189958; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=xf2IhBNSjfuCCFNOGQXIgOUX3v5LqBHuxCH6nnwMj/8=;
b=Cpn3Fn0qkjdPYUETCTK7NsMO0G0AF89K6NyYYW5k5zGKr9qEMMCZLs9LWZphATH0Rw
btU04+kqMQ94vn+j00TRYqI58V4wd+/MPSUi7G5Y8oR3b1K0UTTOZxze2HO3VTidt+ka
zDMePetRP4gCieH1XTq5uVbj5Mr0hYa073glGTbSeFZWK0IZRzYg6GvQCbl4AAdk+xD5
OEvRRkNkXG3204ZqhNcJVyeGwGTvoLpgS/8C5nVOk3XzfiJy15J2Fo1ToMowqHeoEkrX
x/pZ9E8iefEXNeQ8Iyc4gv2evs7O7+thWg1TYizlntlc0ll4KDjXoLMjOrIeFnrPJP3e
yvpA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1721585158; x=1722189958;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=xf2IhBNSjfuCCFNOGQXIgOUX3v5LqBHuxCH6nnwMj/8=;
b=G+i5RjxHtqg6rTxGQ4jNTiCG3Pm7qSqC5s6ME56aveJ/8WxsarGGVa653GgdZXLVq4
wK9kcGilKIy1HIUbPnMvowcvQ1x01Gcfa1EH7HoZ7t6vonykfXjJm/ENe9qk7DWBP5fi
U0UfHhYmpHv06bz45FuLX2FR+BcTYcE7v2zuczoB4psKZtZ5Np4AiBMXLRVmIQlaZBcG
41FlPIFIdr0f4BMVocXkrDavvdLZJUz3othk1umPckT0doM6sOH0L0bn1mJXGK3fK1uF
kL60DoOlfXNW6CWNGHME8qbR+3aZOXOmBaGVsMLKp0XK2lFKEIV/sE0by5UXMiwQfInz
UzKQ==
X-Gm-Message-State: AOJu0YxGdE1d8Bjna80xhzWxbfb3ViAL0sxjnaKIoFXJa5tmXGdBL50T
q7fmgJIDspSlms0zoaO9MQiVWpQJ52RPgbszedCoMLEmyhbGCD5IoMy9c1z/ii6GIqi4qvbIeeU
a9hQru5//AbN6Z4lnKUufvEF+om0=
X-Google-Smtp-Source: AGHT+IFT9b8S60tpvc+T+MVTafyiEwsRYtxsw3aLun1U7vXF3Bq8OSUQgQEqNK81EovRXpbAAJvcNu9bL3YBTKFslXU=
X-Received: by 2002:a05:6402:270c:b0:5a7:464a:ab9 with SMTP id
4fb4d7f45d1cf-5a7464a0b08mr1226347a12.21.1721585157917; Sun, 21 Jul 2024
11:05:57 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Sun, 21 Jul 2024 11:05:57 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <86a5iabq90.fsf@HIDDEN>
References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN>
<86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN>
<CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN>
<86a5iabq90.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sun, 21 Jul 2024 11:05:57 -0700
Message-ID: <CADwFkmnZ_AgRFES+aeQ7GvQ8HGwStJqRrhzKKKYzYT88PSWa7w@HIDDEN>
Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text
To: Eli Zaretskii <eliz@HIDDEN>, hermann sorgel <hermannsorgel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72230
Cc: Po Lu <luangruo@HIDDEN>, 72230 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
> So maybe the problem is elsewhere. One thing is almost certain: it's
> a problem specific to the macOS build of Emacs. People who can debug
> on that platform are encouraged to suggest insights and changes.
This seems to have something to with the clipping path, and is fixed
here by the below patch. I don't think it's suitable for installing
though.
Po Lu, since you added the below NSRectClip call, do you have any
thoughts here?
diff --git a/src/nsterm.m b/src/nsterm.m
index 794630de1c1..54b15bc851d 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -3102,7 +3102,7 @@ Note that CURSOR_WIDTH is meaningful only for
(h)bar cursors.
#ifdef NS_IMPL_GNUSTEP
GSRectClipList (ctx, &r, 1);
#else
- NSRectClip (r);
+ // NSRectClip (r);
#endif
[FRAME_CURSOR_COLOR (f) set];
@@ -3135,7 +3135,7 @@ Note that CURSOR_WIDTH is meaningful only for
(h)bar cursors.
on the right of its glyph, rather than on the left. */
cursor_glyph = get_phys_cursor_glyph (w);
if ((cursor_glyph->resolved_level & 1) != 0)
- s.origin.x += cursor_glyph->pixel_width - s.size.width;
+ s.origin.x += cursor_glyph->pixel_width - cursor_width;
NSRectFill (s);
[ctx restoreGraphicsState];
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 17:40:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 13:40:34 2024 Received: from localhost ([127.0.0.1]:55995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sVaXx-0006UO-Un for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 13:40:34 -0400 Received: from mail-oa1-f49.google.com ([209.85.160.49]:51370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <hermannsorgel@HIDDEN>) id 1sVaQr-0006JG-Bo for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 13:33:14 -0400 Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-25dfb580d1fso1451729fac.2 for <72230 <at> debbugs.gnu.org>; Sun, 21 Jul 2024 10:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721583126; x=1722187926; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0o8UmXNUmemWFaHBcTt7ZI4sMapeuO8uPCm5TJU7pVQ=; b=DAvAGIvU5b/HcEaD0+j4MNINsKZeknsE1Co5HSpwE7JjtLXVVwX0MafPru2Z4cSKDB LRfGbqUSN5w9QmUZgM/PIOnX62/0/st8WYGq6CDGfbHt2nwQWSsmtH67LfrkV9UZg4np 9lWPTapB1N2mkbnazwgrTGgUi3+xCoaHgLWyeJBm7VwLSX6gw1Uel5Bvbasw8sKks2HX /RcIBC/GETnb8jXJM/w33uAWN8xyd4ZeDYSgPOf8P0YK9uZFXouParxOMMqmJcLEPqZ3 r/y8DzH3vUCqTVEllECHcQ0bhflEibBsp9sv6R02fIURuJbtIQHjD9YbuQUUtwct3je1 AGow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721583126; x=1722187926; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0o8UmXNUmemWFaHBcTt7ZI4sMapeuO8uPCm5TJU7pVQ=; b=mhFkVAEceULbufuQPFbL3ndrIgr4tBu/szUC8ihZvrQ04w4excdTLPbgerYmAB1BjJ ZLdkrTSYO93FAwAuWq6hUUwN7xkMEphXwHEZMMUwcxODhPw1MW0XnfgcyyKTAsPDSewU ntiBtsDoJiVjQ+fVBytYauaMM02uY3a2FwrlFqjnJQGXICb84dL69q5iJEIK5qQc2NfU hcY6MFGGeIy8QCqsZ8LwlDbzXl2fAm4KUcIUSlNRdaNo0BuK0fY27u5LGqGGJ97W+KhN y8clg1xnwMwswiGZX8LDWoFaRQGjQI9d+r2JIpyRPVV+hkjmamca0/jimARlzX6xzHGv o3BA== X-Gm-Message-State: AOJu0YxiKkUVw3y5wtpy28P8et1agkZ1/+ZagB4YqJlzCbsyqjElfz8s nNkM/LhkJCkYWHBx/rED+KNwnBZv2ryIPns+UUjUIUswdNNhSpWhyuYKc3x/KVqnlQPIsYyaupt A1P3bmbO2JKkNkh8WT59rhvla5j/wg14mmVQ= X-Google-Smtp-Source: AGHT+IFIjLJcA8BKBFEzsZVcF+7rpEE8fstm1Km2HZ9yyuXHE3yXOhj6r+esWqqPoIWGrqMqn9PuSBfhdt0bIKQNQRs= X-Received: by 2002:a05:6871:722:b0:25e:65f:a530 with SMTP id 586e51a60fabf-263ab5d2b15mr4607462fac.41.1721583125673; Sun, 21 Jul 2024 10:32:05 -0700 (PDT) MIME-Version: 1.0 References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> <86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN> In-Reply-To: <86ikwybuoq.fsf@HIDDEN> From: hermann sorgel <hermannsorgel@HIDDEN> Date: Sun, 21 Jul 2024 20:31:54 +0300 Message-ID: <CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN> Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000a8404e061dc54ecc" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72230 X-Mailman-Approved-At: Sun, 21 Jul 2024 13:40:32 -0400 Cc: 72230 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000a8404e061dc54ecc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here is the same code <https://bitbucket.org/mituharu/emacs-mac/src/master/src/nsterm.m#lines-311= 9> with s.size.width in the working fork. It does not look that anything has changed in 29.4. On Sun, Jul 21, 2024 at 7:01=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > > Cc: 72230 <at> debbugs.gnu.org > > Date: Sun, 21 Jul 2024 18:46:58 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Thanks. I cannot reproduce this on my system, but I'm not on macOS. > > Maybe this is specific to macOS? Can a macOS user please try > > reproducing this? > > And I think I see the problem. This fragment of nsterm.m: > > case BAR_CURSOR: > s =3D r; > /* If the character under cursor is R2L, draw the bar cursor > on the right of its glyph, rather than on the left. */ > cursor_glyph =3D get_phys_cursor_glyph (w); > if ((cursor_glyph->resolved_level & 1) !=3D 0) > s.origin.x +=3D cursor_glyph->pixel_width - s.size.width; > > is incorrect: it should use the value of the cursor_width argument, > not s.size.width. Can someone who is capable of building Emacs on > macOS please try copying more closely the code from xterm.c or > w32term.c that draws the bar cursor, and see if that solves the > problem? > --000000000000a8404e061dc54ecc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><a href=3D"https://bitbucket.org/mituharu/emacs-mac/src/ma= ster/src/nsterm.m#lines-3119" target=3D"_blank">Here is the same code=C2=A0= </a>=C2=A0with=C2=A0<span style=3D"font-size:13px;background-color:rgb(255,= 255,254);font-family:ui-monospace,SFMono-Medium,"SF Mono","S= egoe UI Mono","Roboto Mono","Ubuntu Mono",Menlo,mo= nospace;color:rgb(32,32,32)">s</span><span style=3D"font-size:13px;backgrou= nd-color:rgb(255,255,254);color:rgb(0,0,0);font-family:ui-monospace,SFMono-= Medium,"SF Mono","Segoe UI Mono","Roboto Mono"= ;,"Ubuntu Mono",Menlo,monospace">.</span><span style=3D"font-size= :13px;background-color:rgb(255,255,254);font-family:ui-monospace,SFMono-Med= ium,"SF Mono","Segoe UI Mono","Roboto Mono",&= quot;Ubuntu Mono",Menlo,monospace;color:rgb(32,32,32)">size</span><spa= n style=3D"font-size:13px;background-color:rgb(255,255,254);color:rgb(0,0,0= );font-family:ui-monospace,SFMono-Medium,"SF Mono","Segoe UI= Mono","Roboto Mono","Ubuntu Mono",Menlo,monospace= ">.</span><span style=3D"font-size:13px;background-color:rgb(255,255,254);f= ont-family:ui-monospace,SFMono-Medium,"SF Mono","Segoe UI Mo= no","Roboto Mono","Ubuntu Mono",Menlo,monospace;co= lor:rgb(32,32,32)">width </span>in the working fork. It does not look that = anything has changed in 29.4.<br></div><br><div class=3D"gmail_quote"><div = dir=3D"ltr" class=3D"gmail_attr">On Sun, Jul 21, 2024 at 7:01=E2=80=AFPM El= i Zaretskii <<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN</a>> wrote:= <br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8= ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> Cc: <a hre= f=3D"mailto:72230 <at> debbugs.gnu.org" target=3D"_blank">72230 <at> debbugs.gnu.org<= /a><br> > Date: Sun, 21 Jul 2024 18:46:58 +0300<br> > From: Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN" target=3D"_bla= nk">eliz@HIDDEN</a>><br> > <br> > Thanks.=C2=A0 I cannot reproduce this on my system, but I'm not on= macOS.<br> > Maybe this is specific to macOS?=C2=A0 Can a macOS user please try<br> > reproducing this?<br> <br> And I think I see the problem.=C2=A0 This fragment of nsterm.m:<br> <br> =C2=A0 =C2=A0 case BAR_CURSOR:<br> =C2=A0 =C2=A0 =C2=A0 s =3D r;<br> =C2=A0 =C2=A0 =C2=A0 /* If the character under cursor is R2L, draw the bar = cursor<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0on the right of its glyph, rather than on= the left.=C2=A0 */<br> =C2=A0 =C2=A0 =C2=A0 cursor_glyph =3D get_phys_cursor_glyph (w);<br> =C2=A0 =C2=A0 =C2=A0 if ((cursor_glyph->resolved_level & 1) !=3D 0)<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 s.origin.x +=3D cursor_glyph->pixel_width - = s.size.width;<br> <br> is incorrect: it should use the value of the cursor_width argument,<br> not s.size.width.=C2=A0 Can someone who is capable of building Emacs on<br> macOS please try copying more closely the code from xterm.c or<br> w32term.c that draws the bar cursor, and see if that solves the<br> problem?<br> </blockquote></div> --000000000000a8404e061dc54ecc--
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 17:40:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 13:40:33 2024 Received: from localhost ([127.0.0.1]:55993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sVaXx-0006UL-7i for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 13:40:33 -0400 Received: from mail-oa1-f52.google.com ([209.85.160.52]:56338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <hermannsorgel@HIDDEN>) id 1sVaAY-0005sl-Hb for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 13:16:23 -0400 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-260f81f7fb5so1735258fac.0 for <72230 <at> debbugs.gnu.org>; Sun, 21 Jul 2024 10:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721582115; x=1722186915; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9zCpUnHYOZyFsffaTEMuF+t3hKigt2bX+pFn9fikydY=; b=R9R5WocFf7vLka2Rr9mYOI0buhlamsHZfdz7qflH38ZaAhkSj6OAE28CSSkbFNpsBD u8fUevz8HD0gmxHUr5DVU+UEYaR9kyNLr5U7iy0EHXS5/sHaxaqE6GCmc8BBgZ86xeXY cMLoSn15BEmdCNUtpmq9MU14RaCkiuTSCnaQaJNhg31QMRpCuhhdJ2joIj4PZsQhPchH 0tl7rE+YiVLD1YqGi7LOF8/hItopADaL2CL9pTx/MjWhwx6vjbU5a+uXprtrc7eFVTDH 1hwHgWt+a09fa2Z8zwO1VUnfY3pfWx3GVnaaUXWu5hJ1ch/A6gT8xxUCebrNOVpHF89h w4zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721582115; x=1722186915; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9zCpUnHYOZyFsffaTEMuF+t3hKigt2bX+pFn9fikydY=; b=F+eDix0WYypD/6TMvz2CpWVkBNwJcWkhJqou+g13M/kzrnw24wJriYnr1kOPR6ZwIi Iakw/fBwYoja2bDnmWWv/EtpHFTeMWkWloRd0NfIsSwGYwz0xKdZfVEXdY6sAEALP2R3 JxznkMiJQaYyGRUFpQ/gSslPXfErT65Zh97BqnicinEb3X5R3zZuDj+ZsqhlZi2+XtP0 NhTnLwy0Fin56lS77c0ACivkdN3Q5r4iQB6VxH2zHPZsVThW/VtunQ8hOC1ZGbSff9Ub ogFD6t7FN6b4CQE9tNXxDX6xA4Oqxe3pJ8vgxqES55Iy2y22zPnnZrdFsY45diXARR5V ukEg== X-Gm-Message-State: AOJu0YzEJYsFAeVYsy6bYlh8Xm9yM+Gw7fEwE+0oPQEQ7+PX99tD7K35 GpRRUbQurFo8kNq6eKk6s3K/jYjiXD0pN/Zu5jwL974d/6zaVviWvoZht6sVGsESF4kR1oCfgaG ULyToYA8JElZ5QGVhli69WJuVIGg= X-Google-Smtp-Source: AGHT+IFBMInYAduOWypWv6DMmNNe2aDtAby8iivlOn6sTzcBvmiCXIth9NvHDTf8vhwa4xldb+H9oOsF7BfpgIGGf9A= X-Received: by 2002:a05:6871:e78e:b0:260:df77:2484 with SMTP id 586e51a60fabf-261213a4902mr5090695fac.13.1721582114825; Sun, 21 Jul 2024 10:15:14 -0700 (PDT) MIME-Version: 1.0 References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> <86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN> In-Reply-To: <86ikwybuoq.fsf@HIDDEN> From: hermann sorgel <hermannsorgel@HIDDEN> Date: Sun, 21 Jul 2024 20:15:04 +0300 Message-ID: <CAPinL6Nw3kxEH5ktUXUsjETPd=xxrosx_8L5sqbjBWYn_bz4qA@HIDDEN> Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000067eda1061dc5128e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72230 X-Mailman-Approved-At: Sun, 21 Jul 2024 13:40:32 -0400 Cc: 72230 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --00000000000067eda1061dc5128e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you, Eli! Sadly, I'm not actually into coding, but I'm able to run make. So, the only thing I've changed was: s.origin.x +=3D cursor_glyph->pixel_width - *cursor_width*; Such a build kind of works, but does not fix the described behavior. Also, with the help of redditors, I've found that Mitsuharu's fork of 29.1 does not have this issue. Hope this will help us find the root of the problem. On Sun, Jul 21, 2024 at 7:01=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > > Cc: 72230 <at> debbugs.gnu.org > > Date: Sun, 21 Jul 2024 18:46:58 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Thanks. I cannot reproduce this on my system, but I'm not on macOS. > > Maybe this is specific to macOS? Can a macOS user please try > > reproducing this? > > And I think I see the problem. This fragment of nsterm.m: > > case BAR_CURSOR: > s =3D r; > /* If the character under cursor is R2L, draw the bar cursor > on the right of its glyph, rather than on the left. */ > cursor_glyph =3D get_phys_cursor_glyph (w); > if ((cursor_glyph->resolved_level & 1) !=3D 0) > s.origin.x +=3D cursor_glyph->pixel_width - s.size.width; > > is incorrect: it should use the value of the cursor_width argument, > not s.size.width. Can someone who is capable of building Emacs on > macOS please try copying more closely the code from xterm.c or > w32term.c that draws the bar cursor, and see if that solves the > problem? > --00000000000067eda1061dc5128e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Thank you, Eli!<br><br>Sadly, I'm not actually into co= ding, but I'm able to run make. So, the only thing I've changed was= :<br><br>s.origin.x +=3D cursor_glyph->pixel_width - <b>cursor_width</b>= ;<br><br>Such a build kind of works, but does not fix the described behavio= r.<br><br>Also, with the help of redditors, I've found that Mitsuharu&#= 39;s fork of 29.1 does not have this issue. Hope this will help us find the= root of the problem.<br></div><br><div class=3D"gmail_quote"><div dir=3D"l= tr" class=3D"gmail_attr">On Sun, Jul 21, 2024 at 7:01=E2=80=AFPM Eli Zarets= kii <<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN</a>> wrote:<br></di= v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde= r-left:1px solid rgb(204,204,204);padding-left:1ex">> Cc: <a href=3D"mai= lto:72230 <at> debbugs.gnu.org" target=3D"_blank">72230 <at> debbugs.gnu.org</a><br> > Date: Sun, 21 Jul 2024 18:46:58 +0300<br> > From: Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN" target=3D"_bla= nk">eliz@HIDDEN</a>><br> > <br> > Thanks.=C2=A0 I cannot reproduce this on my system, but I'm not on= macOS.<br> > Maybe this is specific to macOS?=C2=A0 Can a macOS user please try<br> > reproducing this?<br> <br> And I think I see the problem.=C2=A0 This fragment of nsterm.m:<br> <br> =C2=A0 =C2=A0 case BAR_CURSOR:<br> =C2=A0 =C2=A0 =C2=A0 s =3D r;<br> =C2=A0 =C2=A0 =C2=A0 /* If the character under cursor is R2L, draw the bar = cursor<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0on the right of its glyph, rather than on= the left.=C2=A0 */<br> =C2=A0 =C2=A0 =C2=A0 cursor_glyph =3D get_phys_cursor_glyph (w);<br> =C2=A0 =C2=A0 =C2=A0 if ((cursor_glyph->resolved_level & 1) !=3D 0)<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 s.origin.x +=3D cursor_glyph->pixel_width - = s.size.width;<br> <br> is incorrect: it should use the value of the cursor_width argument,<br> not s.size.width.=C2=A0 Can someone who is capable of building Emacs on<br> macOS please try copying more closely the code from xterm.c or<br> w32term.c that draws the bar cursor, and see if that solves the<br> problem?<br> </blockquote></div> --00000000000067eda1061dc5128e--
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 17:37:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 13:37:46 2024 Received: from localhost ([127.0.0.1]:55990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sVaVF-0006QE-M9 for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 13:37:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sVaVE-0006Q2-Aw for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 13:37:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sVaV7-0000Fz-2y; Sun, 21 Jul 2024 13:37:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n/TTFi8NLemiV3Svj1trpk+QBfYbNkPKERn/Rjytqrs=; b=QbIxDRVj+LWS 5z5qEM7vPqIPWdjtnzGyZ/qgQW7XUpdQYyQDvZwE3ZPCu2bECWbVKla7GU6erNasN+mVUFkdvU300 RogHmfwEkNR14u7yLe8nXxHefZ6lUjO3tebD2k+N+s0jP7nzjhCgCV2LQVpxrEm9LYOLKhUWGUHS9 FMjDLKe/9PDscWMWrZeCArlmF1eNt60XmLiQjExduyKEhqaQB/PiURMrw3ykfNYCPNPNMvWCt5FxP CimeGT+3SWeWQq/mgoR4wvFpF9qL7+vs2qXfZm3qPCzhNPV6ypaga+UPv4m3yE1gYo+4YLv6c+WKs c8vXMFvr06QpQV5+z7fwpQ==; Date: Sun, 21 Jul 2024 20:37:31 +0300 Message-Id: <86a5iabq90.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: hermann sorgel <hermannsorgel@HIDDEN> In-Reply-To: <CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN> (message from hermann sorgel on Sun, 21 Jul 2024 20:31:54 +0300) Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> <86o76qbvd9.fsf@HIDDEN> <86ikwybuoq.fsf@HIDDEN> <CAPinL6Mbk=U1FS_cayKsHhmdcUOBq3ksxeG3iqZzbckDhHV1Jg@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72230 Cc: 72230 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: hermann sorgel <hermannsorgel@HIDDEN> > Date: Sun, 21 Jul 2024 20:31:54 +0300 > Cc: 72230 <at> debbugs.gnu.org > > Here is the same code with s.size.width in the working fork. It does not look that anything has changed in > 29.4. So maybe the problem is elsewhere. One thing is almost certain: it's a problem specific to the macOS build of Emacs. People who can debug on that platform are encouraged to suggest insights and changes.
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.
Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 16:01:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 12:01:53 2024
Received: from localhost ([127.0.0.1]:55846 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sVZ0T-00018n-7K
for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 12:01:53 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50742)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1sVZ0R-00018a-1h
for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 12:01:51 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1sVZ0J-0006eJ-OC; Sun, 21 Jul 2024 12:01:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=rpCb/JBpypvv4U3eTzE7F5MTX97S+oC6XSV8/OPZ8Dg=; b=aYHY9ixgGZML
l0eNQTsZfwxqoM8SevuP83rvBW5CKkzj5pVZLvZ9uoND7T+ZneX7aPyzRricAOQHbmyATvqIHtSga
TfY+lq3LXN2zWUm7HxOlUrVVT8m2EoIpycvd9QW7bmq+BJt+f8QARLp1hVbvby6CUONnXuMv2hHuE
RfKgdqqNwbGtJa2kpucbCb3gBn9Gs3qDexbBlmEOP6Ca+JSpu96kmI/xWS16gEh01xe/8fM43hVBK
hPsJ4o63mEzji6q8qV3AUgX+o301oZTkVDlkespTUZ6oP3hkhVJDnBan/fdpY7v71BqnJKaUsBxKP
aIuFpBJqbQrlN5H+ErXkOQ==;
Date: Sun, 21 Jul 2024 19:01:41 +0300
Message-Id: <86ikwybuoq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: hermannsorgel@HIDDEN
In-Reply-To: <86o76qbvd9.fsf@HIDDEN> (message from Eli Zaretskii on Sun, 21
Jul 2024 18:46:58 +0300)
Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text
References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN>
<86o76qbvd9.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72230
Cc: 72230 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: 72230 <at> debbugs.gnu.org
> Date: Sun, 21 Jul 2024 18:46:58 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
>
> Thanks. I cannot reproduce this on my system, but I'm not on macOS.
> Maybe this is specific to macOS? Can a macOS user please try
> reproducing this?
And I think I see the problem. This fragment of nsterm.m:
case BAR_CURSOR:
s = r;
/* If the character under cursor is R2L, draw the bar cursor
on the right of its glyph, rather than on the left. */
cursor_glyph = get_phys_cursor_glyph (w);
if ((cursor_glyph->resolved_level & 1) != 0)
s.origin.x += cursor_glyph->pixel_width - s.size.width;
is incorrect: it should use the value of the cursor_width argument,
not s.size.width. Can someone who is capable of building Emacs on
macOS please try copying more closely the code from xterm.c or
w32term.c that draws the bar cursor, and see if that solves the
problem?
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 15:49:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 11:49:20 2024 Received: from localhost ([127.0.0.1]:55836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sVYoK-0000pJ-Gm for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 11:49:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sVYoI-0000p7-97 for 72230 <at> debbugs.gnu.org; Sun, 21 Jul 2024 11:49:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sVYm5-0003dV-Jo; Sun, 21 Jul 2024 11:47:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2a0h0GELJhrq9QHMy1JFqC6G96ufA1up0ukZo4D5+K4=; b=P2fZ1JqhAOSa SoRUShVQAvtW4dMuX0cIgbxLuVxXB0NHQXVXUwDO/FpwR5aPBHJiGcYqsKg8+xFh0vJ9VR+V8DiZz hwWdjXae1p2F1180PXT85k/loc8Fxj9d7U7upASZAG7d3BJGajhf4KkzT2C9VQmrO6/2dx/k0jVp+ 3OZLKhRSibZHIHUXWdAk8D6YX3cGG3iyBWh8vIDEQr5PSfLYdhOWfe66JLPVa/sNpQxI5ycIL/hwb 72+0CgXZ3Ddhr11uuj3OHvALhuMfJBLWWFhU2nxEXHYMKg1frovxfJutCgLy++F8ac3BPY/DuPxE/ tPkGxL5ZIU4LlfRhnWxwOw==; Date: Sun, 21 Jul 2024 18:46:58 +0300 Message-Id: <86o76qbvd9.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: hermann sorgel <hermannsorgel@HIDDEN> In-Reply-To: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> (message from hermann sorgel on Sun, 21 Jul 2024 17:20:50 +0300) Subject: Re: bug#72230: 29.4; Cursor Disappears with Hebrew Text References: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72230 Cc: 72230 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: hermann sorgel <hermannsorgel@HIDDEN> > Date: Sun, 21 Jul 2024 17:20:50 +0300 > > I'm encountering an issue with cursor behavior in Emacs, and I'm hoping someone can help me resolve it. > > When the cursor hovers over Hebrew text, it becomes invisible. Here are a few facts I've observed: > - This only occurs with the cursor type set to 'bar'. > - The "box" and other cursor types work without issues. > - The "bar" cursor becomes visible if I make its size huge, like '(bar . 10). > - There's a similar, but slightly different issue with Arabic text. > > The issue was reproduced with Emacs 29.3 for Mac and emacs-plus 29.4, on macOS Sonoma 14.5 (23F79). > Changing font and bidi settings haven't affected the issue. Neither has --no-init-file. Thanks. I cannot reproduce this on my system, but I'm not on macOS. Maybe this is specific to macOS? Can a macOS user please try reproducing this?
bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 21 Jul 2024 15:29:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 11:29:13 2024 Received: from localhost ([127.0.0.1]:55816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sVYUp-0000Hr-Le for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 11:29:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:49126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <hermannsorgel@HIDDEN>) id 1sVXQy-0006pK-EB for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 10:21:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <hermannsorgel@HIDDEN>) id 1sVXQw-0003X6-Bl for bug-gnu-emacs@HIDDEN; Sun, 21 Jul 2024 10:21:06 -0400 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <hermannsorgel@HIDDEN>) id 1sVXQu-0003n8-4W for bug-gnu-emacs@HIDDEN; Sun, 21 Jul 2024 10:21:06 -0400 Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-7037c464792so1955696a34.2 for <bug-gnu-emacs@HIDDEN>; Sun, 21 Jul 2024 07:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721571661; x=1722176461; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=tbHVkYgPgF+alTfx3tNc2nXSi156DQgRm7ik9nuaTfY=; b=WoDVT7ZGM4VYwJ3Yif+xNUptnvJxoKWebN1U85T0XgQfKsT56DJnnob0wTOqZifZEe sXFlzUZWzAuiiAtvEFQtqENwGP/vqm6FJpNFakrta09pH6BhbB7RC6jyppPjNoGM/bOb NLosBywGYa9Fktb4aOmSM7BbXRZ/qQsP2duNzwYwOgxPM0ZTDFabIdaQBU23+C3bdj8l AmaC2BNNMgZK8cLJAr66XXUOU2p5mextm6eJhFV3h6VOSgL1E91+lo1iTnfei23FZAlp XtCoWyuCWrzKzZxgqilnenVLmETckjRsD4STFqATYRmDhTCq2Sq20eQ/L9Qtb3td2CpA Egyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721571661; x=1722176461; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tbHVkYgPgF+alTfx3tNc2nXSi156DQgRm7ik9nuaTfY=; b=jscgxUFS/zjAV/oU10S/U1eIMLBSsp9tkSBbDp2KYt9ZVEr0DOk1S0WFYQU9iePctv UZ7UeHPme8HQWNkZlupctYrgWjg4FZC9bcMS0Wv7yt7SDQ9KdKCtRXdV4T07Hh++AZfS n1FIUVXytiD5wzNvuoP0YcWxd6w4bIqPWfa7Etc4ZQTGLHVXks6EF8oiLoLHt3GaaGH1 OkEH8v025Lnlp7jAd8qlC1XJcrK8spHBTrAPP+bEcBONyye7Tei3J43Xli3DaAYXsqWd POq6Xh3Y+0KKFhMX0/xotou+0h/nwL0c0HbsGvXqgWBhJqCwI4zp/TwQz49XLUAeeT50 npMw== X-Gm-Message-State: AOJu0YxeWLwo8JQMbTVfCUWjbcCi3MAo59MRIB/S3lyd77nptf6UNGTi wwY9fuA1bHlCcVqR2RAXMgA8I4DRtLoeWvBc/MWwnRSRGxR/lJSMXTLMrH5DGJmZtP0zkdIDmEb FPX4Ic3KFpGZLRu0xhhUsfbn3dF6L/Qzm X-Google-Smtp-Source: AGHT+IGo1o8EvJ9GqeiWfSIRVZBZ78D385S6Yh5k67Hw+EuX0LoqNUzLqcbNfYVmWeKAPAzJnUNUKW2ex1Td6f0aG9U= X-Received: by 2002:a05:6870:32c9:b0:261:39d:afa4 with SMTP id 586e51a60fabf-261213a58b9mr4574506fac.18.1721571661281; Sun, 21 Jul 2024 07:21:01 -0700 (PDT) MIME-Version: 1.0 From: hermann sorgel <hermannsorgel@HIDDEN> Date: Sun, 21 Jul 2024 17:20:50 +0300 Message-ID: <CAPinL6PLDOg0SzAcL4R-6o55o0nn8WTdUvjB7oyqs3YrPWH28A@HIDDEN> Subject: 29.4; Cursor Disappears with Hebrew Text To: bug-gnu-emacs@HIDDEN Content-Type: multipart/alternative; boundary="000000000000537fd8061dc2a367" Received-SPF: pass client-ip=2607:f8b0:4864:20::329; envelope-from=hermannsorgel@HIDDEN; helo=mail-ot1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 21 Jul 2024 11:29:10 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --000000000000537fd8061dc2a367 Content-Type: text/plain; charset="UTF-8" I'm encountering an issue with cursor behavior in Emacs, and I'm hoping someone can help me resolve it. When the cursor hovers over Hebrew text, it becomes invisible. Here are a few facts I've observed: - This only occurs with the cursor type set to 'bar'. - The "box" and other cursor types work without issues. - The "bar" cursor becomes visible if I make its size huge, like '(bar . 10). - There's a similar, but slightly different issue with Arabic text. The issue was reproduced with Emacs 29.3 for Mac and emacs-plus 29.4, on macOS Sonoma 14.5 (23F79). Changing font and bidi settings haven't affected the issue. Neither has --no-init-file. Short video with demonstration <https://e.pcloud.link/publink/show?code=XZIDjgZ3QLO9BNemLm4rGJp1Venlhq0PeI7> Text file from video <https://gist.github.com/hermannsorgel/a2a7de12dab858bb17da35b822721702> Please let me know if I'm missing something. In GNU Emacs 29.4 (build 1, aarch64-apple-darwin23.5.0, NS appkit-2487.60 Version 14.5 (Build 23F79)) of 2024-07-21 built on Sorgel-MBP Windowing system distributor 'Apple', version 10.3.2487 System Description: macOS 14.5 Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/opt/homebrew/share/emacs/site-lisp --infodir=/opt/homebrew/Cellar/emacs-plus@29/29.4/share/info/emacs --prefix=/opt/homebrew/Cellar/emacs-plus@29/29.4 --with-xml2 --with-gnutls --without-compress-install --without-dbus --without-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained 'CFLAGS=-Os -w -pipe -mmacosx-version-min=14 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -O2 -DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' 'CPPFLAGS=-I/opt/homebrew/opt/icu4c/include -I/opt/homebrew/opt/sqlite/include -I/opt/homebrew/opt/readline/include -isystem/opt/homebrew/include -F/opt/homebrew/Frameworks -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk' 'LDFLAGS=-L/opt/homebrew/opt/icu4c/lib -L/opt/homebrew/opt/sqlite/lib -L/opt/homebrew/opt/readline/lib -L/opt/homebrew/lib -F/opt/homebrew/Frameworks -Wl,-headerpad_max_install_names -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk'' Configured features: ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER XIM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils thingatpt vc-git diff-mode easy-mmode vc-dispatcher cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 43275 6299) (symbols 48 5649 0) (strings 32 15396 2057) (string-bytes 1 443058) (vectors 16 11570) (vector-slots 8 175067 6803) (floats 8 23 53) (intervals 56 298 0) (buffers 984 12)) --000000000000537fd8061dc2a367 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I'm encountering an issue with cursor behavior in Emac= s, and I'm hoping someone can help me resolve it.<br><br>When the curso= r hovers over Hebrew text, it becomes invisible. Here are a few facts I'= ;ve observed:<br>- This only occurs with the cursor type set to 'bar= 9;.<br>- The "box" and other cursor types work without issues.<br= >- The "bar" cursor becomes visible if I make its size huge, like= '(bar . 10).<br>- There's a similar, but slightly different issue = with Arabic text.<br><br>The issue was reproduced with Emacs 29.3 for Mac a= nd emacs-plus 29.4, on macOS Sonoma 14.5 (23F79). Changing font and bidi se= ttings haven't affected the issue. Neither has --no-init-file.<br><div>= <div><div><br></div><div><a href=3D"https://e.pcloud.link/publink/show?code= =3DXZIDjgZ3QLO9BNemLm4rGJp1Venlhq0PeI7" target=3D"_blank">Short video with = demonstration</a><br><br><a href=3D"https://gist.github.com/hermannsorgel/a= 2a7de12dab858bb17da35b822721702" target=3D"_blank">Text file from video</a>= </div><div><br></div><div>Please let me know if I'm missing something.<= br><div><br></div><div>In GNU Emacs 29.4 (build 1, aarch64-apple-darwin23.5= .0, NS<br>=C2=A0appkit-2487.60 Version 14.5 (Build 23F79)) of 2024-07-21 bu= ilt on<br>=C2=A0Sorgel-MBP<br>Windowing system distributor 'Apple',= version 10.3.2487<br>System Description: =C2=A0macOS 14.5<br><br>Configure= d using:<br>=C2=A0'configure --disable-dependency-tracking --disable-si= lent-rules<br>=C2=A0--enable-locallisppath=3D/opt/homebrew/share/emacs/site= -lisp<br>=C2=A0--infodir=3D/opt/homebrew/Cellar/emacs-plus@29/29.4/share/in= fo/emacs<br>=C2=A0--prefix=3D/opt/homebrew/Cellar/emacs-plus@29/29.4 --with= -xml2<br>=C2=A0--with-gnutls --without-compress-install --without-dbus<br>= =C2=A0--without-imagemagick --with-modules --with-rsvg --with-ns<br>=C2=A0-= -disable-ns-self-contained 'CFLAGS=3D-Os -w -pipe<br>=C2=A0-mmacosx-ver= sion-min=3D14<br>=C2=A0-isysroot/Library/Developer/CommandLineTools/SDKs/Ma= cOSX14.sdk -O2<br>=C2=A0-DFD_SETSIZE=3D10000 -DDARWIN_UNLIMITED_SELECT'= <br>=C2=A0'CPPFLAGS=3D-I/opt/homebrew/opt/icu4c/include<br>=C2=A0-I/opt= /homebrew/opt/sqlite/include -I/opt/homebrew/opt/readline/include<br>=C2=A0= -isystem/opt/homebrew/include -F/opt/homebrew/Frameworks<br>=C2=A0-isysroot= /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk'<br>=C2=A0'LD= FLAGS=3D-L/opt/homebrew/opt/icu4c/lib -L/opt/homebrew/opt/sqlite/lib<br>=C2= =A0-L/opt/homebrew/opt/readline/lib -L/opt/homebrew/lib<br>=C2=A0-F/opt/hom= ebrew/Frameworks -Wl,-headerpad_max_install_names<br>=C2=A0-isysroot/Librar= y/Developer/CommandLineTools/SDKs/MacOSX14.sdk''<br><br>Configured = features:<br>ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY= KQUEUE NS<br>PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TRE= E_SITTER<br>XIM ZLIB<br><br>Important settings:<br>=C2=A0 value of $LANG: e= n_US.UTF-8<br>=C2=A0 locale-coding-system: utf-8-unix<br><br>Major mode: Fu= ndamental<br><br>Minor modes in effect:<br>=C2=A0 tooltip-mode: t<br>=C2=A0= global-eldoc-mode: t<br>=C2=A0 show-paren-mode: t<br>=C2=A0 electric-inden= t-mode: t<br>=C2=A0 mouse-wheel-mode: t<br>=C2=A0 tool-bar-mode: t<br>=C2= =A0 menu-bar-mode: t<br>=C2=A0 file-name-shadow-mode: t<br>=C2=A0 global-fo= nt-lock-mode: t<br>=C2=A0 font-lock-mode: t<br>=C2=A0 blink-cursor-mode: t<= br>=C2=A0 line-number-mode: t<br>=C2=A0 indent-tabs-mode: t<br>=C2=A0 trans= ient-mark-mode: t<br>=C2=A0 auto-composition-mode: t<br>=C2=A0 auto-encrypt= ion-mode: t<br>=C2=A0 auto-compression-mode: t<br><br>Load-path shadows:<br= >None found.<br><br>Features:<br>(shadow sort mail-extr emacsbug message ma= ilcap yank-media puny dired<br>dired-loaddefs rfc822 mml mml-sec password-c= ache epa derived epg rfc6068<br>epg-config gnus-util text-property-search t= ime-date subr-x mm-decode<br>mm-bodies mm-encode mail-parse rfc2231 mailabb= rev gmm-utils mailheader<br>sendmail rfc2047 rfc2045 ietf-drums mm-util mai= l-prsvr mail-utils<br>thingatpt vc-git diff-mode easy-mmode vc-dispatcher c= l-loaddefs cl-lib<br>rmc iso-transl tooltip cconv eldoc paren electric uniq= uify ediff-hook<br>vc-hooks lisp-float-type elisp-mode mwheel term/ns-win n= s-win<br>ucs-normalize mule-util term/common-win tool-bar dnd fontset image= <br>regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode= <br>prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu<b= r>timer select scroll-bar mouse jit-lock font-lock syntax font-core<br>term= /tty-colors frame minibuffer nadvice seq simple cl-generic<br>indonesian ph= ilippine cham georgian utf-8-lang misc-lang vietnamese<br>tibetan thai tai-= viet lao korean japanese eucjp-ms cp51932 hebrew greek<br>romanian slovak c= zech european ethiopic indian cyrillic chinese<br>composite emoji-zwj chars= cript charprop case-table epa-hook<br>jka-cmpr-hook help abbrev obarray ocl= osure cl-preloaded button loaddefs<br>theme-loaddefs faces cus-face macroex= p files window text-properties<br>overlay sha1 md5 base64 format env code-p= ages mule custom widget keymap<br>hashtable-print-readable backquote thread= s kqueue cocoa ns lcms2<br>multi-tty make-network-process emacs)<br><br>Mem= ory information:<br>((conses 16 43275 6299)<br>=C2=A0(symbols 48 5649 0)<br= >=C2=A0(strings 32 15396 2057)<br>=C2=A0(string-bytes 1 443058)<br>=C2=A0(v= ectors 16 11570)<br>=C2=A0(vector-slots 8 175067 6803)<br>=C2=A0(floats 8 2= 3 53)<br>=C2=A0(intervals 56 298 0)<br>=C2=A0(buffers 984 12))<br></div></d= iv></div></div></div> --000000000000537fd8061dc2a367--
hermann sorgel <hermannsorgel@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#72230; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.