GNU logs - #72239, boring messages


Message sent to guix@HIDDEN, 873216071@HIDDEN, bug-guix@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#72239: libfaketime (still) broken on i686-linux
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludovic.courtes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix@HIDDEN, 873216071@HIDDEN, bug-guix@HIDDEN
Resent-Date: Sun, 21 Jul 2024 22:22:01 +0000
Resent-Message-ID: <handler.72239.B.172160050620801 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 72239
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: 72239 <at> debbugs.gnu.org
Cc: Christopher Baines <guix@HIDDEN>, Z572 <873216071@HIDDEN>
X-Debbugs-Original-To: bug-guix@HIDDEN
X-Debbugs-Original-Xcc: Christopher Baines <guix@HIDDEN>, Z572 <873216071@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.172160050620801
          (code B ref -1); Sun, 21 Jul 2024 22:22:01 +0000
Received: (at submit) by debbugs.gnu.org; 21 Jul 2024 22:21:46 +0000
Received: from localhost ([127.0.0.1]:56251 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sVew6-0005PP-6t
	for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 18:21:46 -0400
Received: from lists.gnu.org ([209.51.188.17]:43700)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludovic.courtes@HIDDEN>) id 1sVew3-0005PF-OO
 for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 18:21:44 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludovic.courtes@HIDDEN>)
 id 1sVew1-0007b2-1G
 for bug-guix@HIDDEN; Sun, 21 Jul 2024 18:21:41 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludovic.courtes@HIDDEN>)
 id 1sVevx-0002GZ-Vb
 for bug-guix@HIDDEN; Sun, 21 Jul 2024 18:21:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc;
 h=from:to:subject:date:message-id:mime-version;
 bh=l6rt9lpmudSonW4Pz22LBE8ULcaTuz4FblyF4ySHLvA=;
 b=sAibOQMN7+mfG/y6LQFaCRcftZbUvn1yu5ahjq1O6P3IXFowe4ZRPEqK
 Z5/aQ14YONkAVfnvLX9GQgvheODfSiRcIHBtmzn05ZaNwmRFqWj3ZC5S9
 Zfu8bkfW22umsuhG9NW5zECJ+xngF0vu4ckiaMWeswqTwMzsCbxlGYVNq M=;
Authentication-Results: mail3-relais-sop.national.inria.fr;
 dkim=none (message not signed) header.i=none;
 spf=SoftFail smtp.mailfrom=ludovic.courtes@HIDDEN;
 dmarc=fail (p=none dis=none) d=inria.fr
X-IronPort-AV: E=Sophos;i="6.09,225,1716242400"; d="scan'208";a="92642994"
Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201])
 by mail3-relais-sop.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 00:21:32 +0200
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludovic.courtes@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Quintidi 5 Thermidor an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du =?UTF-8?Q?B=C3=A9lier?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Mon, 22 Jul 2024 00:21:31 +0200
Message-ID: <87ikwyl72s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=192.134.164.104;
 envelope-from=ludovic.courtes@HIDDEN;
 helo=mail3-relais-sop.national.inria.fr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

This bug report is to keep track of the discussions around libfaketime
for i686-linux.  Right now, libfaketime segfaults when used to run the
test suite of =E2=80=98nss=E2=80=99 on i686-linux.  This can be reproduced =
in a simple
way as of =E2=80=98core-updates=E2=80=99 commit
05e6bd3efe1b03190839d2b91b09fa768c4ef83c:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix shell -s i686-linux libfaketime bash -- \
     faketime 2023-01-01 bash -c true
Caught Segmentation fault
--8<---------------cut here---------------end--------------->8---

Commit 127f1842fb037cc5acfc5406e373ccd723127732 (=E2=80=9Cgnu: libfaketime:
Support compilation with glibc 2.39 on i686-linux.=E2=80=9D) was written un=
der
the assumption that packages in Guix would be built with
=E2=80=98_TIME_BITS=3D64=E2=80=99.

Alas, as Z572 found out, packages that use Gnulib are typically built
that way, but other packages, such as =E2=80=98nss=E2=80=99 and =E2=80=98ba=
sh=E2=80=99, are often built
with a 32-bit =E2=80=98time_t=E2=80=99.  Our modified libfaketime fails bad=
ly in these
cases.

The libfaketime limitations are discussed in
<https://github.com/wolfcw/libfaketime/issues/418>.

OTOH, datefudge explicitly provides replacements for both the 32-bit and
64-bit variants of the relevant libc symbols on 32-bit platforms.  It
seems to work fine with 32-bit time_t programs (like =E2=80=98bash=E2=80=99=
) and 64-bit
time_t programs (like =E2=80=98date=E2=80=99 from Coreutils):

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix shell -s i686-linux datefudge bash coreutils -- datef=
udge 2023-01-01 bash -c true
$ ./pre-inst-env guix shell -s i686-linux datefudge bash coreutils -- datef=
udge 2023-01-01 date
Sun Jan  1 00:00:00 CET 2023
--8<---------------cut here---------------end--------------->8---

So the easiest short-term solution seems to be using datefudge to run
the =E2=80=98nss=E2=80=99 tests on 32-bit platforms, as Chris already sugge=
sted before
(patch below; it=E2=80=99s being built right now, I=E2=80=99ll see tomorrow=
 if it
worked=E2=80=A6).

Longer-term, as discussed with Z572, we should set up a branch where
we=E2=80=99d ensure =E2=80=9Ceverything=E2=80=9D uses 64-bit =E2=80=98time_=
t=E2=80=99 on 32-bit platforms
(that=E2=80=99s beyond the scope of this issue though).

Ludo=E2=80=99.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline

diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm
index 49276817ae..da3847fcb1 100644
--- a/gnu/packages/nss.scm
+++ b/gnu/packages/nss.scm
@@ -40,7 +40,8 @@ (define-module (gnu packages nss)
   #:use-module (gnu packages crates-io)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages perl)
-  #:use-module (gnu packages sqlite))
+  #:use-module (gnu packages sqlite)
+  #:use-module (gnu packages time))
 
 (define-public nspr
   (package
@@ -215,7 +216,8 @@ (define-public nss
                     ;; leading to test failures:
                     ;; <https://bugzilla.mozilla.org/show_bug.cgi?id=609734>.  To
                     ;; work around that, set the time to roughly the release date.
-                    (invoke "faketime" "2024-01-23" "./nss/tests/all.sh"))
+                    (invoke #$(if (target-64bit?) "faketime" "datefudge")
+                            "2024-01-23" "./nss/tests/all.sh"))
                   (format #t "test suite not run~%"))))
           (replace 'install
             (lambda* (#:key outputs #:allow-other-keys)
@@ -240,7 +242,9 @@ (define-public nss
                 (copy-recursively (string-append obj "/lib") lib)))))))
     (inputs (list sqlite zlib))
     (propagated-inputs (list nspr))               ;required by nss.pc.
-    (native-inputs (list perl libfaketime which)) ;for tests
+    (native-inputs (list perl
+                         (if (target-64bit?) libfaketime datefudge)
+                         which)) ;for tests
 
     ;; The NSS test suite takes around 48 hours on Loongson 3A (MIPS) when
     ;; another build is happening concurrently on the same machine.

--=-=-=--




Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludovic.courtes@HIDDEN>
Subject: bug#72239: Acknowledgement (libfaketime (still) broken on i686-linux)
Message-ID: <handler.72239.B.172160050620801.ack <at> debbugs.gnu.org>
References: <87ikwyl72s.fsf@HIDDEN>
X-Gnu-PR-Message: ack 72239
X-Gnu-PR-Package: guix
Reply-To: 72239 <at> debbugs.gnu.org
Date: Sun, 21 Jul 2024 22:22:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Christopher Baines <guix@HIDDEN>, Z572 <873216071@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 72239 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72239: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72239
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to bug-guix@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#72239: libfaketime (still) broken on i686-linux
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 22 Jul 2024 07:09:02 +0000
Resent-Message-ID: <handler.72239.B72239.172163212623067 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72239
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: 72239 <at> debbugs.gnu.org
Cc: Christopher Baines <guix@HIDDEN>, Z572 <873216071@HIDDEN>
Received: via spool by 72239-submit <at> debbugs.gnu.org id=B72239.172163212623067
          (code B ref 72239); Mon, 22 Jul 2024 07:09:02 +0000
Received: (at 72239) by debbugs.gnu.org; 22 Jul 2024 07:08:46 +0000
Received: from localhost ([127.0.0.1]:56729 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sVnA6-0005zz-0x
	for submit <at> debbugs.gnu.org; Mon, 22 Jul 2024 03:08:46 -0400
Received: from hera.aquilenet.fr ([185.233.100.1]:54030)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1sVnA3-0005zi-CI
 for 72239 <at> debbugs.gnu.org; Mon, 22 Jul 2024 03:08:44 -0400
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 51C6E261;
 Mon, 22 Jul 2024 09:08:04 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id SrxlkriOrrd3; Mon, 22 Jul 2024 09:08:03 +0200 (CEST)
Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 953D3190;
 Mon, 22 Jul 2024 09:08:03 +0200 (CEST)
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <87ikwyl72s.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 22 Jul 2024 00:21:31 +0200")
References: <87ikwyl72s.fsf@HIDDEN>
Date: Mon, 22 Jul 2024 09:08:01 +0200
Message-ID: <87cyn5lx9q.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Ludovic Court=C3=A8s <ludovic.courtes@HIDDEN> skribis:

> So the easiest short-term solution seems to be using datefudge to run
> the =E2=80=98nss=E2=80=99 tests on 32-bit platforms, as Chris already sug=
gested before
> (patch below; it=E2=80=99s being built right now, I=E2=80=99ll see tomorr=
ow if it
> worked=E2=80=A6).

It failed:

--8<---------------cut here---------------start------------->8---
$ gunzip < /var/log/guix/drvs/yk/8dxp7v6v29nbhkyiv5x8sk04gszycm-nss-3.99.dr=
v.gz | tail -20
NSS_DISABLE_HW_SHA2=3D
NSS_DISABLE_PCLMUL=3D
NSS_DISABLE_AVX=3D
NSS_DISABLE_ARM_NEON=3D
NSS_DISABLE_SSSE3=3D

Tests summary:
--------------
Passed:             79015
Failed:             2
Failed with core:   0
ASan failures:      0
Unknown status:     2
TinderboxPrint:Unknown: 2

error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "datefudge" arguments: ("2024-01-23" ".=
/nss/tests/all.sh") exit-status: 1 term-signal: #f stop-signal: #f>
phase `check' failed after 12784.8 seconds
command "datefudge" "2024-01-23" "./nss/tests/all.sh" failed with status 1
build process 18 exited with status 256

$ zgrep -B5 ' - FAILED$' /var/log/guix/drvs/yk/8dxp7v6v29nbhkyiv5x8sk04gszy=
cm-nss-3.99.drv.gz
[  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPss4096Sha256
[  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPss4096Sha512
[  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPssMisc

39 FAILED TESTS
gtests.sh: #54: pk11_gtest run successfully  - FAILED
--
[  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPss4096Sha256
[  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPss4096Sha512
[  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPssMisc

39 FAILED TESTS
gtests.sh: #54: pk11_gtest run successfully  - FAILED
--8<---------------cut here---------------end--------------->8---

Not sure if it=E2=80=99s because datefudge doesn=E2=80=99t interpose on eve=
ry symbol
that we need or if there=E2=80=99s another problem.

Thoughts?

Ludo=E2=80=99.




Message sent to bug-guix@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#72239: libfaketime (still) broken on i686-linux
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 22 Jul 2024 12:56:02 +0000
Resent-Message-ID: <handler.72239.B72239.17216529294232 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72239
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Z572 <873216071@HIDDEN>, 72239 <at> debbugs.gnu.org
Received: via spool by 72239-submit <at> debbugs.gnu.org id=B72239.17216529294232
          (code B ref 72239); Mon, 22 Jul 2024 12:56:02 +0000
Received: (at 72239) by debbugs.gnu.org; 22 Jul 2024 12:55:29 +0000
Received: from localhost ([127.0.0.1]:57191 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sVsZd-00016C-2Z
	for submit <at> debbugs.gnu.org; Mon, 22 Jul 2024 08:55:29 -0400
Received: from mira.cbaines.net ([212.71.252.8]:43968)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1sVsZZ-000162-Te
 for 72239 <at> debbugs.gnu.org; Mon, 22 Jul 2024 08:55:27 -0400
Received: from localhost (unknown [212.132.255.81])
 by mira.cbaines.net (Postfix) with ESMTPSA id E34A827BBE2;
 Mon, 22 Jul 2024 13:55:21 +0100 (BST)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 07854d90;
 Mon, 22 Jul 2024 12:55:21 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
In-Reply-To: <87cyn5lx9q.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 22 Jul 2024 09:08:01 +0200")
References: <87ikwyl72s.fsf@HIDDEN> <87cyn5lx9q.fsf@HIDDEN>
User-Agent: mu4e 1.12.4; emacs 29.3
Date: Mon, 22 Jul 2024 13:55:19 +0100
Message-ID: <87le1t60y0.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Ludovic Court=C3=A8s <ludovic.courtes@HIDDEN> skribis:
>
>> So the easiest short-term solution seems to be using datefudge to run
>> the =E2=80=98nss=E2=80=99 tests on 32-bit platforms, as Chris already su=
ggested before
>> (patch below; it=E2=80=99s being built right now, I=E2=80=99ll see tomor=
row if it
>> worked=E2=80=A6).
>
> It failed:
>
> --8<---------------cut here---------------start------------->8---
> $ gunzip < /var/log/guix/drvs/yk/8dxp7v6v29nbhkyiv5x8sk04gszycm-nss-3.99.=
drv.gz | tail -20
> NSS_DISABLE_HW_SHA2=3D
> NSS_DISABLE_PCLMUL=3D
> NSS_DISABLE_AVX=3D
> NSS_DISABLE_ARM_NEON=3D
> NSS_DISABLE_SSSE3=3D
>
> Tests summary:
> --------------
> Passed:             79015
> Failed:             2
> Failed with core:   0
> ASan failures:      0
> Unknown status:     2
> TinderboxPrint:Unknown: 2
>
> error: in phase 'check': uncaught exception:
> %exception #<&invoke-error program: "datefudge" arguments: ("2024-01-23" =
"./nss/tests/all.sh") exit-status: 1 term-signal: #f stop-signal: #f>
> phase `check' failed after 12784.8 seconds
> command "datefudge" "2024-01-23" "./nss/tests/all.sh" failed with status 1
> build process 18 exited with status 256
>
> $ zgrep -B5 ' - FAILED$' /var/log/guix/drvs/yk/8dxp7v6v29nbhkyiv5x8sk04gs=
zycm-nss-3.99.drv.gz
> [  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPss4096Sha256
> [  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPss4096Sha512
> [  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPssMisc
>
> 39 FAILED TESTS
> gtests.sh: #54: pk11_gtest run successfully  - FAILED
> -
> [  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPss4096Sha256
> [  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPss4096Sha512
> [  FAILED  ] Pkcs11RsaPssTestWycheproof.RsaPssMisc
>
> 39 FAILED TESTS
> gtests.sh: #54: pk11_gtest run successfully  - FAILED
> --8<---------------cut here---------------end--------------->8---
>
> Not sure if it=E2=80=99s because datefudge doesn=E2=80=99t interpose on e=
very symbol
> that we need or if there=E2=80=99s another problem.
>
> Thoughts?

So you can run just this failing gtests by adding (setenv "NSS_TESTS"
"gtests") to the check phase.

Then if you build with datefudge and without datefudge, there's some
difference in the output when the testsuite starts.

When running without datefudge, the tests work and the cd in gtests.sh
seems to fail:

Running tests for gtests
TIMESTAMP gtests BEGIN: Mon Jul 22 10:09:27 UTC 2024
./gtests.sh: line 25: cd: ./nss/tests: No such file or directory
/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/gtests

But when running with datefudge, the cd seems to work, but the tests
fail:

Running tests for gtests
TIMESTAMP gtests BEGIN: Tue Jan 23 00:00:01 UTC 2024
/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests


This seems to relate to the test failures, as they seem to fail reading
a JSON file because they're using the wrong filename:

[----------] 1 test from Pkcs11AESKeyWrapKwpTest
[ RUN      ] Pkcs11AESKeyWrapKwpTest.TestVectors
json_reader.cc:13: Failure
Value of: f_
  Actual: false
Expected: true
error opening vectors from: /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tes=
ts/../../gtests/pk11_gtest/../common/testvectors/kwp-vectors.json
json_reader.cc:130: Failure
Failed
Unexpected '\0'
json_reader.cc:49: Failure
Expected equality of these values:
  take()
    Which is: '\0'
  ':'
    Which is: ':' (58, 0x3A)
pk11_aeskeywrapkwp_unittest.cc:120: Failure
Expected equality of these values:
  "numberOfTests"
  r.ReadLabel()
    Which is: ""
[  FAILED  ] Pkcs11AESKeyWrapKwpTest.TestVectors (0 ms)


There's two many .. here, it should be
/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/../gtests/pk11_gtest/../c=
ommon/testvectors/kwp-vectors.json


Removing the cd line from the gtests.sh script seems to get the package
to build for i686-linux with datefudge, so I've sent a patch (#72244) to
this effect. It's odd that the cd command works but the tests fail
though.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmaeVrdfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XcWdhAAiNyxv2w+4orZIupxCsxBj1J+bmZfDaWR
92ZcOQ03y1ECAdlM7HK/StnTx2moRhCIctiRB52TDd7yVJxM0V1TuOyKSr9gNgka
U7/xmleAjgPSAbzr+Fw27GTPXgR02aBS0ZJy+ZNkkwN5mXrZccK9AE4PuBQO1827
MysovG6L5DMypuS+8tafYyDgeZ7TZsx9whVUWUHEb+wMAvwp52BHnt39IPI0L2cg
3UnxsiUiZTBPuSS+ddvwTO8utxsBicwDDZYzdCWyfycYllbi/X7Ve0NslWyJ2p2Z
sSBm9IQNjHEg7iFXBsAVz7u0gNVFLBX/TNatRxVVMSnzbprC/dlTiS/6OzKQ93I2
OC07yBnoDwWo6PuOTnq8h5d1kFZQfc4v86dJ1zAH/UMps3eKBF5WUkwS5+opAGFN
FcdXIQashi0foo/agKmmqDM5nQrswMTors7JzD+ugJhUZecU6zXTb/idZhUWcTJ1
wOlSlOrAvfhZWBx4DtZFIzOeFfyk+2XiHh7aNlTw5SSHTBa7GXvjt3b6iAmnK67e
TWwSBnldVDvrG0eoCZV2SV+8XQArVGinrxRJQOWnty69WYz7J6jDdZx+8V/IS6OH
TVQGvKZmsQauFH93JNuQPfRiOP8NmMD5TIuZxHVWv8jCJQa65Jene8NRHb1uwxIV
TTfpF26piPM=
=0rIH
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to bug-guix@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#72239: libfaketime (still) broken on i686-linux
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 23 Jul 2024 10:43:01 +0000
Resent-Message-ID: <handler.72239.B72239.172173133131888 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72239
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Christopher Baines <mail@HIDDEN>
Cc: Z572 <873216071@HIDDEN>, 72239 <at> debbugs.gnu.org
Received: via spool by 72239-submit <at> debbugs.gnu.org id=B72239.172173133131888
          (code B ref 72239); Tue, 23 Jul 2024 10:43:01 +0000
Received: (at 72239) by debbugs.gnu.org; 23 Jul 2024 10:42:11 +0000
Received: from localhost ([127.0.0.1]:59285 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWCyA-0008IG-UA
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 06:42:11 -0400
Received: from eggs.gnu.org ([209.51.188.92]:47158)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1sWCy9-0008I3-AE
 for 72239 <at> debbugs.gnu.org; Tue, 23 Jul 2024 06:42:10 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1sWCxx-00071F-UZ; Tue, 23 Jul 2024 06:41:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=dcpakSBaCs6UNA5d6/Z1cVJZlaQ1WHq/gIakKIQpQOw=; b=qNKxnfVL6e151mUVc8B8
 rSD8XvQOfiUB5F5TdWOTfQSFaB8MMWb14V4lrin2Evyw9nRpu/MQgB5Gxs9/ruQmwHX0MnchJ9ef/
 n6Gdx1FZ7zQssHYsWYGTy/FzRl/bkDhUZ1UWQusHB9/zwfoD8EbGOAkNf1bRe3jCUq9s6BxXCbl1H
 EUSJYUfQlOVtNeq6jtY76K0v4xXx866PP/mdMblv0qwcWB4rtCyAJwLzzfydM84M+ht0fAnAJWXeO
 vg2KR8RF/vaacbLx9EpWsGCrec3iGLUhbN7g6kKT5Ft8/Y1XdDe864CgpwdSBqgXZFIz9eSAkR54N
 atXtqzqTRJxKfg==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <87le1t60y0.fsf@HIDDEN> (Christopher Baines's message of
 "Mon, 22 Jul 2024 13:55:19 +0100")
References: <87ikwyl72s.fsf@HIDDEN> <87cyn5lx9q.fsf@HIDDEN>
 <87le1t60y0.fsf@HIDDEN>
Date: Tue, 23 Jul 2024 12:41:54 +0200
Message-ID: <874j8gie4t.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi!

Christopher Baines <mail@HIDDEN> skribis:

> When running without datefudge, the tests work and the cd in gtests.sh
> seems to fail:
>
> Running tests for gtests
> TIMESTAMP gtests BEGIN: Mon Jul 22 10:09:27 UTC 2024
> ./gtests.sh: line 25: cd: ./nss/tests: No such file or directory
> /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/gtests
>
> But when running with datefudge, the cd seems to work, but the tests
> fail:
>
> Running tests for gtests
> TIMESTAMP gtests BEGIN: Tue Jan 23 00:00:01 UTC 2024
> /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests

I added =E2=80=98set -x=E2=80=99 in =E2=80=98gtests.sh=E2=80=99.  With =E2=
=80=98datefudge=E2=80=99, it goes like this:

--8<---------------cut here---------------start------------->8---
log-Running tests for gtests
log-TIMESTAMP gtests BEGIN: Tue Jan 23 00:00:00 CET 2024
log-++ echo FOOOOO
log-FOOOOO
log-+++ dirname /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/all.sh
log-++ cd /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests
log-++ pwd
log-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests
log:++ SOURCE_DIR=3D/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/../..
log-++ set +x
log-gtests: base_gtest certhigh_gtest certdb_gtest der_gtest pk11_gtest uti=
l_gtest freebl_gtest softoken_gtest sysinit_gtest smime_gtest mozpkix_gtest
log-gtests.sh: base_gtest =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
log-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/dist/Linux6.9_x86_gcc_glibc_PTH=
_DBG.OBJ/bin/certutil -N -d /tmp/guix-build-nss-3.99.drv-0/nss-3.99/tests_r=
esults/security/guix-hpc5.7/gtests/base_gtest --empty-password
log-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/dist/Linux6.9_x86_gcc_glibc_PTH=
_DBG.OBJ/bin/certutil -S -z ../tests_noise -d /tmp/guix-build-nss-3.99.drv-=
0/nss-3.99/tests_results/security/guix-hpc5.7/gtests/base_gtest -n dummy -s=
 CN=3Ddummy -t ,, -x -m 1 -w -2 -v 120 -k ec -q nistp256 -Z SHA256 -1 -2
log-
log-
log-Generating key.  This may take a few moments...
--8<---------------cut here---------------end--------------->8---

*Without* =E2=80=98datefudge=E2=80=99:

--8<---------------cut here---------------start------------->8---
log.good-TIMESTAMP gtests BEGIN: Tue Jul 23 12:37:50 CEST 2024
log.good-++ echo FOOOOO
log.good-FOOOOO
log.good-+++ dirname ./nss/tests/all.sh
log.good-++ cd ./nss/tests
log.good-./gtests.sh: line 27: cd: ./nss/tests: No such file or directory
log.good-++ pwd
log.good-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/gtests
log.good:++ SOURCE_DIR=3D/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/=
gtests/../..
log.good-++ set +x
log.good-gtests: base_gtest certhigh_gtest certdb_gtest der_gtest pk11_gtes=
t util_gtest freebl_gtest softoken_gtest sysinit_gtest smime_gtest mozpkix_=
gtest
log.good-gtests.sh: base_gtest =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
log.good-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/dist/Linux6.9_x86_gcc_glib=
c_PTH_DBG.OBJ/bin/certutil -N -d /tmp/guix-build-nss-3.99.drv-0/nss-3.99/te=
sts_results/security/guix-hpc5.6/gtests/base_gtest --empty-password
log.good-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/dist/Linux6.9_x86_gcc_glib=
c_PTH_DBG.OBJ/bin/certutil -S -z ../tests_noise -d /tmp/guix-build-nss-3.99=
.drv-0/nss-3.99/tests_results/security/guix-hpc5.6/gtests/base_gtest -n dum=
my -s CN=3Ddummy -t ,, -x -m 1 -w -2 -v 120 -k ec -q nistp256 -Z SHA256 -1 =
-2
log.good-
log.good-
log.good-Generating key.  This may take a few moments...
--8<---------------cut here---------------end--------------->8---

In the latter case, the scripts gets a relative file name, which makes
it fail to cd, which then makes it succeed by chance.

This script looks extremely fragile.

My suggestion would be to:

  (substitute* "nss/tests/gtests/gtests.sh"
    (("SOURCE_DIR=3D.*")
     (string-append "SOURCE_DIR=3D" (getcwd) "/nss\n")))

WDYT?

(There=E2=80=99s a tension between getting a reasonably good understanding =
of
what=E2=80=99s happening and moving forward!)

Ludo=E2=80=99.




Message sent to bug-guix@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#72239: libfaketime (still) broken on i686-linux
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 23 Jul 2024 11:42:02 +0000
Resent-Message-ID: <handler.72239.B72239.172173487816073 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72239
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Z572 <873216071@HIDDEN>, 72239 <at> debbugs.gnu.org
Received: via spool by 72239-submit <at> debbugs.gnu.org id=B72239.172173487816073
          (code B ref 72239); Tue, 23 Jul 2024 11:42:02 +0000
Received: (at 72239) by debbugs.gnu.org; 23 Jul 2024 11:41:18 +0000
Received: from localhost ([127.0.0.1]:59373 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWDtN-0004BB-La
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 07:41:18 -0400
Received: from mira.cbaines.net ([212.71.252.8]:43970)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1sWDtJ-0004Ay-1I
 for 72239 <at> debbugs.gnu.org; Tue, 23 Jul 2024 07:41:16 -0400
Received: from localhost (unknown [212.132.255.81])
 by mira.cbaines.net (Postfix) with ESMTPSA id 9D25F27BBE2;
 Tue, 23 Jul 2024 12:40:35 +0100 (BST)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 727c0a80;
 Tue, 23 Jul 2024 11:40:34 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
In-Reply-To: <874j8gie4t.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 23 Jul 2024 12:41:54 +0200")
References: <87ikwyl72s.fsf@HIDDEN> <87cyn5lx9q.fsf@HIDDEN>
 <87le1t60y0.fsf@HIDDEN> <874j8gie4t.fsf@HIDDEN>
User-Agent: mu4e 1.12.4; emacs 29.3
Date: Tue, 23 Jul 2024 12:40:32 +0100
Message-ID: <87h6cg5ob3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Hi!
>
> Christopher Baines <mail@HIDDEN> skribis:
>
>> When running without datefudge, the tests work and the cd in gtests.sh
>> seems to fail:
>>
>> Running tests for gtests
>> TIMESTAMP gtests BEGIN: Mon Jul 22 10:09:27 UTC 2024
>> ./gtests.sh: line 25: cd: ./nss/tests: No such file or directory
>> /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/gtests
>>
>> But when running with datefudge, the cd seems to work, but the tests
>> fail:
>>
>> Running tests for gtests
>> TIMESTAMP gtests BEGIN: Tue Jan 23 00:00:01 UTC 2024
>> /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests
>
> I added =E2=80=98set -x=E2=80=99 in =E2=80=98gtests.sh=E2=80=99.  With =
=E2=80=98datefudge=E2=80=99, it goes like this:
>
> --8<---------------cut here---------------start------------->8---
> log-Running tests for gtests
> log-TIMESTAMP gtests BEGIN: Tue Jan 23 00:00:00 CET 2024
> log-++ echo FOOOOO
> log-FOOOOO
> log-+++ dirname /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/all.sh
> log-++ cd /tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests
> log-++ pwd
> log-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests
> log:++ SOURCE_DIR=3D/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/../=
..
> log-++ set +x
> log-gtests: base_gtest certhigh_gtest certdb_gtest der_gtest pk11_gtest u=
til_gtest freebl_gtest softoken_gtest sysinit_gtest smime_gtest mozpkix_gte=
st
> log-gtests.sh: base_gtest =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> log-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/dist/Linux6.9_x86_gcc_glibc_P=
TH_DBG.OBJ/bin/certutil -N -d /tmp/guix-build-nss-3.99.drv-0/nss-3.99/tests=
_results/security/guix-hpc5.7/gtests/base_gtest --empty-password
> log-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/dist/Linux6.9_x86_gcc_glibc_P=
TH_DBG.OBJ/bin/certutil -S -z ../tests_noise -d /tmp/guix-build-nss-3.99.dr=
v-0/nss-3.99/tests_results/security/guix-hpc5.7/gtests/base_gtest -n dummy =
-s CN=3Ddummy -t ,, -x -m 1 -w -2 -v 120 -k ec -q nistp256 -Z SHA256 -1 -2
> log-
> log-
> log-Generating key.  This may take a few moments...
> --8<---------------cut here---------------end--------------->8---
>
> *Without* =E2=80=98datefudge=E2=80=99:
>
> --8<---------------cut here---------------start------------->8---
> log.good-TIMESTAMP gtests BEGIN: Tue Jul 23 12:37:50 CEST 2024
> log.good-++ echo FOOOOO
> log.good-FOOOOO
> log.good-+++ dirname ./nss/tests/all.sh
> log.good-++ cd ./nss/tests
> log.good-./gtests.sh: line 27: cd: ./nss/tests: No such file or directory
> log.good-++ pwd
> log.good-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/tests/gtests
> log.good:++ SOURCE_DIR=3D/tmp/guix-build-nss-3.99.drv-0/nss-3.99/nss/test=
s/gtests/../..
> log.good-++ set +x
> log.good-gtests: base_gtest certhigh_gtest certdb_gtest der_gtest pk11_gt=
est util_gtest freebl_gtest softoken_gtest sysinit_gtest smime_gtest mozpki=
x_gtest
> log.good-gtests.sh: base_gtest =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> log.good-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/dist/Linux6.9_x86_gcc_gl=
ibc_PTH_DBG.OBJ/bin/certutil -N -d /tmp/guix-build-nss-3.99.drv-0/nss-3.99/=
tests_results/security/guix-hpc5.6/gtests/base_gtest --empty-password
> log.good-/tmp/guix-build-nss-3.99.drv-0/nss-3.99/dist/Linux6.9_x86_gcc_gl=
ibc_PTH_DBG.OBJ/bin/certutil -S -z ../tests_noise -d /tmp/guix-build-nss-3.=
99.drv-0/nss-3.99/tests_results/security/guix-hpc5.6/gtests/base_gtest -n d=
ummy -s CN=3Ddummy -t ,, -x -m 1 -w -2 -v 120 -k ec -q nistp256 -Z SHA256 -=
1 -2
> log.good-
> log.good-
> log.good-Generating key.  This may take a few moments...
> --8<---------------cut here---------------end--------------->8---
>
> In the latter case, the scripts gets a relative file name, which makes
> it fail to cd, which then makes it succeed by chance.
>
> This script looks extremely fragile.
>
> My suggestion would be to:
>
>   (substitute* "nss/tests/gtests/gtests.sh"
>     (("SOURCE_DIR=3D.*")
>      (string-append "SOURCE_DIR=3D" (getcwd) "/nss\n")))
>
> WDYT?

That looks good to me.

In a related note, I was going to push the original patch yesterday, but
I got stuck rebasing core-updates. There's some substantial rust changes
on the branch which clash with master.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmaflrBfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfAZQ//dRiugEitxQ2/GsoYYzDi3QFIgL5CwKO2
U+P5v3fkEFr/Hh/VaMJCUfNd81x2YnEJ6jRlXspHpO2QZZ9PsIh+VNTsUZmIFtfE
gio/y485MQeH7kQUkt/4DBP71KDa4yrDAdFcn1GSopmb88Kyej+E7ds6ZfbXSWJ+
P+daJ5vnYnwSrcGSGweyv5yO7KTDZLRfyUvxIZSj62eouKa8Y+vEOqc8lXe91XJN
/RXXXC0hWY9u0/G2/bn2AVPImlqgJwgXuqb3BrxZnP1J4mbKgtbEH2KDcqsJUaj9
IpiUGk1EzjOrNkfmzJSDhy6a6Yz2GM8j1eNcdqH2cZxONon9hesAQDAWEmOVquck
E0AXfVMBTgX0E0rUyFa9+v9tE2p6zf82LcM7RFUUFKy3WY2nKdtN9ts4HRTVhD30
/6zH5K9+me6F1A1okdXGRv1M+pmhRVnV1z1nOkRO/gdR6bseQlexiKjSEyFYW8Ob
1uVePa+XhhDt+LnCu6JhrvfRVMA0Vmn4DAnNgCxnciFQhiC97zsflpMgfz5Q3gG0
qOM5/Rt5mmRI+dVVcI6d7uIJh75jFkwpHq+1aNLZM06pQ6Tu3ohQV3tnvOoW1F0A
uDdW1zpie6WxveHmtGRh+mNm1PRr1U2fES32PjlYHQw1oFtSwJfjysr9R0sIucpS
iPAaZfGGHrA=
=77jz
-----END PGP SIGNATURE-----
--=-=-=--




Message received at control <at> debbugs.gnu.org:


Received: (at control) by debbugs.gnu.org; 23 Jul 2024 15:16:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 23 11:16:06 2024
Received: from localhost ([127.0.0.1]:60533 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWHFF-0007JG-RJ
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 11:16:05 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:56563)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1sWHFD-0007IR-VF
 for control <at> debbugs.gnu.org; Tue, 23 Jul 2024 11:16:04 -0400
Authentication-Results: mail3-relais-sop.national.inria.fr;
 dkim=none (message not signed) header.i=none;
 spf=SoftFail smtp.mailfrom=ludo@HIDDEN;
 dmarc=fail (p=none dis=none) d=gnu.org
X-IronPort-AV: E=Sophos;i="6.09,230,1716242400"; d="scan'208";a="92794877"
Received: from unknown (HELO ribbon) ([193.50.110.239])
 by mail3-relais-sop.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 17:15:52 +0200
Date: Tue, 23 Jul 2024 17:15:51 +0200
Message-Id: <87v80wf8bc.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #72239
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

severity 72239 important
quit






Last modified: Tue, 23 Jul 2024 15:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.