GNU bug report logs - #72240
The commit 17e26cf57e1 broke font-locking in maxima-mode

Message received at 72240 <at> debbugs.gnu.org:

Received: (at 72240) by debbugs.gnu.org; 22 Jul 2024 07:30:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 22 03:30:18 2024
Received: from localhost ([127.0.0.1]:56761 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sVnUw-0001ok-1q
	for submit <at> debbugs.gnu.org; Mon, 22 Jul 2024 03:30:18 -0400
Received: from mail-ed1-f45.google.com ([209.85.208.45]:59450)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1sVnUt-0001PL-Mx
 for 72240 <at> debbugs.gnu.org; Mon, 22 Jul 2024 03:30:16 -0400
Received: by mail-ed1-f45.google.com with SMTP id
 4fb4d7f45d1cf-5a156557026so3091842a12.2
 for <72240 <at> debbugs.gnu.org>; Mon, 22 Jul 2024 00:30:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1721633347; x=1722238147; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=rpkiLiExM70SmhNF+rBB9N9hAEwOfWxdpQiua4VxRIo=;
 b=mRJN+wG2/RC5VakTCbCLw0iJcyuduf39htT2mwxeA9t8rln+Yz9MbJ1O+PYRHnU/mE
 qkvzHkNzHYmWU8mHpAenzT+fLGWCOh057QA2OHhQ5g6R+TIxyXuX7qvQE+oiM0lNeNNi
 u3a5PPHey3m15O8SlVffsha6zKcjghSkssLeiBzd/kDPfj75KimS5j6tfzBkcV7ZceNU
 wmDbXqSz3yBPdl3aRC1lpBMQ9uk2Bb9GD73NIIzgAGqMRUk/roYbD+Dt/ySxx3hposh5
 U1Q/ZDZ3VFZs5W7GTBTLy4PDVfadiltAaMA08BAOkOCms6EU2alzBl+Ib6MnAoNGhwXs
 NL6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1721633347; x=1722238147;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=rpkiLiExM70SmhNF+rBB9N9hAEwOfWxdpQiua4VxRIo=;
 b=tlogqediQAsDJwASVL2wgIoMkpAkAQjVQJq9qduwyplpLo8e6doS5Ys83xRnck3d3v
 0auk8eeA0rtWesaHCZEtiFvAkzglT+Y1gil6I8+3dKSbBqUMA1lsAXHUQfGCet/ZjUvq
 EG4Sq9EEMJxXm0W+6jJbCfmPjGQNmGrlMTjIPlkNvs1rcF1sQe+oBg8v3iduZCMaCdcR
 Ffpg6wFEh0A2qhHxYDVu8P1zKGI0MiSUcy1zeHhH3Q1ZGqEYOqvJM4DOQiGSajBUvkos
 +912vIBWz8pcSrozmYtzASF2vsGluCjYf+1ZBh/qLu5A0D8zB/uyY8FtbGqTU2aVGwEN
 JeoA==
X-Forwarded-Encrypted: i=1;
 AJvYcCWAlELmGMg6fclkqTZxlDTtVJuOWk1yipjwwqkJsR42Rl8t6vK3ZFoJioU7fIuwatpYk4oxFC2cbj178TMzgxK7371Y9i0=
X-Gm-Message-State: AOJu0YwpFIAiEFJHAtqXYopxZwdUqdNGx7ZRQmXENBuK5+bceCe8KwaK
 xsvwuuzHVuvFLFkS+9t0hbnuD2HpfvSI5pJ53sZyOwy4QZWmQgAo5xAWWdrUbHrssTtIrrI2gRH
 klsSSNy3LcyMYwb2W6XU6lJaG+Ks=
X-Google-Smtp-Source: AGHT+IE9FC17hsj5XR6zZhj9agFgL3XxO3J2QLn4x9EL7ADMx63jXDPj6Sd++oKi0/zpDqU7KKyiQEXtAnr/EnfNq0E=
X-Received: by 2002:a05:6402:40d3:b0:5a2:4b34:b76f with SMTP id
 4fb4d7f45d1cf-5a4784834b0mr4027397a12.2.1721633347001; Mon, 22 Jul 2024
 00:29:07 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 22 Jul 2024 00:29:05 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CADs++6h-TU5WSM1hvYrdSDb+35LNLav47CmJfz-NDEmSCd1z1g@HIDDEN>
References: <CADs++6h-TU5WSM1hvYrdSDb+35LNLav47CmJfz-NDEmSCd1z1g@HIDDEN>
MIME-Version: 1.0
Date: Mon, 22 Jul 2024 00:29:05 -0700
Message-ID: <CADwFkmmBbNLC=GM6zwmVBLc3X-5f1CRqKZ-fk0DqcZOuib-JcQ@HIDDEN>
Subject: Re: bug#72240: The commit 17e26cf57e1 broke font-locking in
 maxima-mode
To: Eduardo Ochs <eduardoochs@HIDDEN>, 72240 <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72240
Cc: Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 72240 + notabug
thanks

Eduardo Ochs <eduardoochs@HIDDEN> writes:

> there are two Maxima modes around - one in Melpa and one in Maxima
> itself. They have different bugs, and lots of people, including me,
> prefer the Maxima mode that comes with Maxima. This bug report is
> about a change in Emacs that broke the font-locking in the Maxima mode
> that comes with Maxima - I didn't test the other Maxima mode.
>
> Something happened between these two commits:
>
> 3f7e26e2bed 2024-04-13 10:10:19 (define-globalized-minor-mode): Fix bug#58888
> 17e26cf57e1 2024-04-13 10:31:28 (define-globalized-minor-mode):
> Require the use of `run-mode-hooks`
>
> Until 3f7e26e2bed font-locking in .mac files worked, but from
> 17e26cf57e1 onwards it doesn't work anymore. In the current Emacs from
> git - where "current" means 2024jul21 - it doesn't work.

This should be reported to the maxima.el developers, I think.

They should change `maxima-mode' to use `run-mode-hooks' instead of
`run-hooks'. This is documented in etc/NEWS:

> ** 'define-globalized-minor-mode' requires that modes use 'run-mode-hooks'.
> Minor modes defined with 'define-globalized-minor-mode', such as
> 'global-font-lock-mode', will not be enabled any more in those buffers
> whose major modes fail to use 'run-mode-hooks'.  Major modes defined
> with 'define-derived-mode' are not affected.  'run-mode-hooks' has been the
> recommended way to run major mode hooks since Emacs 22.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 22 Jul 2024 03:06:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 21 23:06:19 2024
Received: from localhost ([127.0.0.1]:56601 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sVjNT-0007mN-5n
	for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 23:06:19 -0400
Received: from lists.gnu.org ([209.51.188.17]:40392)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eduardoochs@HIDDEN>) id 1sVjNR-0007mE-7V
 for submit <at> debbugs.gnu.org; Sun, 21 Jul 2024 23:06:17 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eduardoochs@HIDDEN>)
 id 1sVjNN-0008FT-M1
 for bug-gnu-emacs@HIDDEN; Sun, 21 Jul 2024 23:06:13 -0400
Received: from mail-yw1-x112d.google.com ([2607:f8b0:4864:20::112d])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <eduardoochs@HIDDEN>)
 id 1sVjNJ-0006Md-76
 for bug-gnu-emacs@HIDDEN; Sun, 21 Jul 2024 23:06:13 -0400
Received: by mail-yw1-x112d.google.com with SMTP id
 00721157ae682-65cd720cee2so39365317b3.1
 for <bug-gnu-emacs@HIDDEN>; Sun, 21 Jul 2024 20:06:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1721617562; x=1722222362; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=7AekDn6JKm84j6sl6TbFTioyhc3f29gOanG0/ScB7cQ=;
 b=SuMO7wQGqz7G/9abY0JFDq8R0yv7qrby7yJlAHRvCy+B4zhaE55j7uY7iyUQ/sN/Zs
 IEG4uH0e+yY7tiEEOvmfxgETTA6gs5f+72UQM/VLMLtbGqx+Fer6k3mFuqBZOp5mQxDF
 HNjVzZjSNTXv9s9DcrUcBCQXLyeA9Nu1bhTPktDSiOy9EcvrAiTXzbRyjqc3st/54Fuh
 Fcr02jihFzIS9bV+VDJHKfFAjvUlm/5y3pXLtT6XNRS2+jfwaqarOB2T4NfKnqYWemO6
 49BRS5akyLjfpvSFM3S8RmmKqFAZkHw4EINC8iWkenIG7lJ9nYHLPFrnZD2e6CbD8Uss
 r3VA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1721617562; x=1722222362;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=7AekDn6JKm84j6sl6TbFTioyhc3f29gOanG0/ScB7cQ=;
 b=f/dg5AtfTHdYvzIeojqpJYxcZs0p3lDvYeNgJBtSTw5WOL0nlfk1GoXX2AJVdqz1fu
 QkmwuRKyKitMotq1HAB5nHFulKpVw/qU5T3pbf+y5jquc8HBJ0qxF+xe4OmQC62TMauy
 M5GoaMfHEQONj5b8iWOxrp29slr/E+y2QHOo0oSaEBRSZZrlW7kNp6cq/vvFoNfhe7qn
 RNYKtr+qvYpTfwt9cE5+WRoE4TI6Im7mCiZZLHYsITnSqEUAH3ZojdOKKYy8HTzV1mUh
 M1kTDb9O8ctfbYTrQ3iB53UGseCBO/YBYeH3PtG20MQx2vL0gWELTtrD7S5arviYUxhA
 FsoA==
X-Gm-Message-State: AOJu0YwwBxIwbqm1Ee3W7KzoW1rfBYU5RyYyQqTf+Na8UUHuUVa7L5Sx
 XNj0ym2zCgCpVfbUfJVSLOJCvshYh7MSgFNPMqGm8oWXRwFxTmNnaYt5OOc5CdkFRjoSgQ0Obnd
 4agVKDXoxoDg3/xYeEdg5Q8tNJFIcUUoJ
X-Google-Smtp-Source: AGHT+IHfmfJOAQAD19gdvWkNv6t0pmK41jh/D9zqtDHHrmnlxudpAiJ78njtqvkgYy+h0MncHHHgaBYYMo1FybT6c0Q=
X-Received: by 2002:a05:690c:dc1:b0:64b:8086:5805 with SMTP id
 00721157ae682-66a66c1aa39mr82206707b3.15.1721617562213; Sun, 21 Jul 2024
 20:06:02 -0700 (PDT)
MIME-Version: 1.0
From: Eduardo Ochs <eduardoochs@HIDDEN>
Date: Mon, 22 Jul 2024 00:05:50 -0300
Message-ID: <CADs++6h-TU5WSM1hvYrdSDb+35LNLav47CmJfz-NDEmSCd1z1g@HIDDEN>
Subject: The commit 17e26cf57e1 broke font-locking in maxima-mode
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2607:f8b0:4864:20::112d;
 envelope-from=eduardoochs@HIDDEN; helo=mail-yw1-x112d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hi all,

there are two Maxima modes around - one in Melpa and one in Maxima
itself. They have different bugs, and lots of people, including me,
prefer the Maxima mode that comes with Maxima. This bug report is
about a change in Emacs that broke the font-locking in the Maxima mode
that comes with Maxima - I didn't test the other Maxima mode.

Something happened between these two commits:

3f7e26e2bed 2024-04-13 10:10:19 (define-globalized-minor-mode): Fix bug#58888
17e26cf57e1 2024-04-13 10:31:28 (define-globalized-minor-mode):
Require the use of `run-mode-hooks`

Until 3f7e26e2bed font-locking in .mac files worked, but from
17e26cf57e1 onwards it doesn't work anymore. In the current Emacs from
git - where "current" means 2024jul21 - it doesn't work.

Note that 3f7e26e2bed is 17e26cf57e1~1.
I'm on Debian 11 ("oldstable").

Here's how to test it.

--snip--snip--
rm -Rv /tmp/test-maxima-mode/
mkdir  /tmp/test-maxima-mode/
cd     /tmp/test-maxima-mode/

wget -O maxima.el \
  "https://sourceforge.net/p/maxima/code/ci/master/tree/interfaces/emacs/emaxima/maxima.el?format=raw"
wget -O maxima-font-lock.el \
  "https://sourceforge.net/p/maxima/code/ci/master/tree/interfaces/emacs/emaxima/maxima-font-lock.el?format=raw"

cat > test.mac <<'%%%'
max(2, 4);
min(2, 4);
q(t)   := max(0, t-2);
r(t)   := min(q(t), 2);
S(x,y) := max(r(x), r(y));
plot2d (r(t), [t, 0, 6]);
plot3d (S(x,y), [x, 0, 6], [y, 0, 6]);
%%%

cat > test.el <<'%%%'
(progn
  (load "/tmp/test-maxima-mode/maxima-font-lock.el")
  (load "/tmp/test-maxima-mode/maxima.el")
  (add-to-list 'auto-mode-alist '("\\.mac$"  . maxima-mode))
  (find-file "/tmp/test-maxima-mode/test.mac")
  )
%%%

emacs -Q test.el
--snip--snip--

  Cheers,
    Eduardo Ochs
    http://anggtwu.net/#eev