GNU bug report logs - #72281
[PATCH] Guix Packager: add copy feature for fetch command

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72281 in the body.
You can then email your comments to 72281 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakob Kirsch <jakob.kirsch <at> web.de>
To: guix-patches <at> gnu.org
Cc: Jakob Kirsch <jakob.kirsch <at> web.de>
Subject: [PATCH] Guix Packager: add copy feature for fetch command
Date: Thu, 25 Jul 2024 00:26:23 +0200

---
 src/components/inputs/SourceInput.tsx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/components/inputs/SourceInput.tsx b/src/components/inputs/SourceInput.tsx
index aa1b714..2f67425 100644
--- a/src/components/inputs/SourceInput.tsx
+++ b/src/components/inputs/SourceInput.tsx
@@ -136,9 +136,12 @@ function HashHelp({ method, url, version }: {
   method: Method, url: UrlType, version: string
 }) {
   return (
-    <div>
+    <div
+      onClick={() => {
+        navigator.clipboard.writeText(getFetchHelp(method, url, version))
+      }}>
       <Typography variant="body2">
-        You may compute the sha256 by running the following command(s):
+        You may compute the sha256 by running the following command(s) (click to copy):
       </Typography>
       <SyntaxHighlighter
         text={getFetchHelp(method, url, version)}
--
2.45.2

Message #10 received at 72281-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
To: Jakob Kirsch <jakob.kirsch <at> web.de>
Cc: 72281-done <at> debbugs.gnu.org,
 Philippe Virouleau <philippe.virouleau <at> inria.fr>
Subject: Re: [bug#72281] [PATCH] Guix Packager: add copy feature for fetch
 command
Date: Mon, 19 Aug 2024 14:53:43 +0200

Hello,

(Cc: Philippe, the author of Guix Packager.)

Jakob Kirsch <jakob.kirsch <at> web.de> skribis:

> ---
>  src/components/inputs/SourceInput.tsx | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/components/inputs/SourceInput.tsx b/src/components/inputs/SourceInput.tsx
> index aa1b714..2f67425 100644
> --- a/src/components/inputs/SourceInput.tsx
> +++ b/src/components/inputs/SourceInput.tsx
> @@ -136,9 +136,12 @@ function HashHelp({ method, url, version }: {
>    method: Method, url: UrlType, version: string
>  }) {
>    return (
> -    <div>
> +    <div
> +      onClick={() => {
> +        navigator.clipboard.writeText(getFetchHelp(method, url, version))
> +      }}>
>        <Typography variant="body2">
> -        You may compute the sha256 by running the following command(s):
> +        You may compute the sha256 by running the following command(s) (click to copy):

I took the liberty to apply this patch and it’s now deployed:

  https://guix-hpc.gitlabpages.inria.fr/guix-packager/

Philippe, lemme know if anything needs to be tweaked.  :-)

Thanks for your contribution!

Ludo’.

Message #13 received at 72281-done <at> debbugs.gnu.org (full text, mbox):

From: Philippe Virouleau <philippe.virouleau <at> inria.fr>
To: Ludovic Courtès <ludovic.courtes <at> inria.fr>,
 Jakob Kirsch <jakob.kirsch <at> web.de>
Cc: 72281-done <at> debbugs.gnu.org
Subject: Re: [bug#72281] [PATCH] Guix Packager: add copy feature for fetch
 command
Date: Mon, 26 Aug 2024 08:52:48 +0200

Hi Ludo and Jakob,

Thanks a lot, that looks great to me :)

Regards,
Philippe

On 8/19/24 14:53, Ludovic Courtès wrote:
> Hello,
> 
> (Cc: Philippe, the author of Guix Packager.)
> 
> Jakob Kirsch <jakob.kirsch <at> web.de> skribis:
> 
>> ---
>>   src/components/inputs/SourceInput.tsx | 7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/components/inputs/SourceInput.tsx b/src/components/inputs/SourceInput.tsx
>> index aa1b714..2f67425 100644
>> --- a/src/components/inputs/SourceInput.tsx
>> +++ b/src/components/inputs/SourceInput.tsx
>> @@ -136,9 +136,12 @@ function HashHelp({ method, url, version }: {
>>     method: Method, url: UrlType, version: string
>>   }) {
>>     return (
>> -    <div>
>> +    <div
>> +      onClick={() => {
>> +        navigator.clipboard.writeText(getFetchHelp(method, url, version))
>> +      }}>
>>         <Typography variant="body2">
>> -        You may compute the sha256 by running the following command(s):
>> +        You may compute the sha256 by running the following command(s) (click to copy):
> 
> I took the liberty to apply this patch and it’s now deployed:
> 
>    https://guix-hpc.gitlabpages.inria.fr/guix-packager/
> 
> Philippe, lemme know if anything needs to be tweaked.  :-)
> 
> Thanks for your contribution!
> 
> Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.