Received: (at 72312-done) by debbugs.gnu.org; 27 Jul 2024 05:58:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 27 01:58:45 2024 Received: from localhost ([127.0.0.1]:40372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sXaS5-0005cT-0i for submit <at> debbugs.gnu.org; Sat, 27 Jul 2024 01:58:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sXaS3-0005cH-Qn for 72312-done <at> debbugs.gnu.org; Sat, 27 Jul 2024 01:58:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sXaRo-0006cf-MS; Sat, 27 Jul 2024 01:58:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EGiM+KCg7Grhs4Tnky94kVcmmJ/gXyPR5l7SiMHG6YM=; b=BkpUZZe83hIa uOqPf4K3Y6d5HBOaVYoG9OTxN3lHXKDTXl9v0pXWSBCJ7+LM9dR4nSHEbpoDAPOuEJ87akRCTwscv Zt5d7CEuPMdCdd31zM6WukhiiUIgsoKu5KCU307ETtKDOPebg4sX0D6O0rabetG3S7m2XthgldtEX 2w1xiBS92GOPNTTU7FZ3AxpuXTBdF1DRZYgsx4wrq8i81My2GAm2D7zCQhvnp3rC3bl6guBpf8SeN kpiJcHNrW8s6DkASLCuhv4R1v3CNvEbGzbyDWkL4rEnzjmgudZN6t796kYwZeCYTEEidPjRE7OTOz ebe4ALS3dr8sZ7nCtHllHg==; Date: Sat, 27 Jul 2024 08:58:26 +0300 Message-Id: <86h6cb2x6l.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Thuna <thuna.cing@HIDDEN> In-Reply-To: <87y15n3nml.fsf@HIDDEN> (message from Thuna on Fri, 26 Jul 2024 22:27:14 +0200) Subject: Re: bug#72312: server--process-filter-1 returns from the wrong block References: <87y15n3nml.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72312-done Cc: 72312-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Thuna <thuna.cing@HIDDEN> > Date: Fri, 26 Jul 2024 22:27:14 +0200 > > In `server--process-filter-1' in lisp/server.el I assume the > `return-from' on line 28 was meant to be from `server--process-filter-1' > and not `server--process-filter'. This was already fixed yesterday by Andrea, see commit fdc133e97f65.
Thuna <thuna.cing@HIDDEN>:Eli Zaretskii <eliz@HIDDEN>:
Received: (at 72312) by debbugs.gnu.org; 26 Jul 2024 21:33:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 26 17:33:43 2024
Received: from localhost ([127.0.0.1]:40163 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sXSZK-0006xe-MD
for submit <at> debbugs.gnu.org; Fri, 26 Jul 2024 17:33:43 -0400
Received: from out-170.mta1.migadu.com ([95.215.58.170]:26788)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jb@HIDDEN>) id 1sXSZI-0006xP-HW
for 72312 <at> debbugs.gnu.org; Fri, 26 Jul 2024 17:33:41 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net;
s=key1; t=1722029574;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=KgkveA4j3mHACCmtLqPErW36w67WGmxzuZ47bXHyBAY=;
b=ZQGhgsoulmF+nCBXpq9BkV/C96tmktMUC481oJGHIqHGqnU6T6jMTBUyj/fnLNdffe5EZk
O1uv32oPJp8UU399w+u2Lrq1Jxnb9SNoH0dqcFYMc1rSN8nhRy1hChrSxhGzDt+pMJeKoT
iaAhqPohIoxGnpaVgwAAQIq/NbBwXK8dg6LSa4/Qp+L0HHBuZgnksPA5bwgLlaiy+6DXud
c/d9VZ3YxYdi1v6QrqX3TUm5uYwrfkPnAp1XBJ+DZWHv/+mQpwwPJL2rD7cqlo7588pb0S
sl+nacWNYU+yvlTVBMSlerZGPOccfDB4KbgTf0fYMich+yl1N4N4gn5IKNjDpg==
From: Jeremy Bryant <jb@HIDDEN>
To: Thuna <thuna.cing@HIDDEN>
Subject: Re: bug#72312: server--process-filter-1 returns from the wrong block
In-Reply-To: <87y15n3nml.fsf@HIDDEN> (Thuna's message of "Fri, 26 Jul 2024
22:27:14 +0200")
References: <87y15n3nml.fsf@HIDDEN>
Date: Fri, 26 Jul 2024 22:32:53 +0100
Message-ID: <87o76jalfe.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 72312
Cc: 72312 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Thuna <thuna.cing@HIDDEN> writes:
> In `server--process-filter-1' in lisp/server.el I assume the
> `return-from' on line 28 was meant to be from `server--process-filter-1'
> and not `server--process-filter'.
Assuming you mean this last line,
;; We return immediately.
(cl-return-from server--process-filter)))
adding Stefan M, who made a commit in
May and may know more.
commit 0d7d835902dfaeaae03850fb37e369833bb5664d
Author: Stefan Monnier <monnier@HIDDEN>
Date: Thu May 30 18:28:02 2024 -0400
server.el: Avoid nested runs of process filters (bug#71223)
(cl-defun server--process-filter-1 (proc string)
(server-log (concat "Received " string) proc)
;; First things first: let's check the authentication
(unless (process-get proc :authenticated)
(if (and (string-match "-auth \\([!-~]+\\)\n?" string)
(equal (match-string 1 string) (process-get proc :auth-key)))
(progn
(setq string (substring string (match-end 0)))
(process-put proc :authenticated t)
(server-log "Authentication successful" proc))
(server-log "Authentication failed" proc)
;; Display the error as a message and give the user time to see
;; it, in case the error written by emacsclient to stderr is not
;; visible for some reason.
(server--message-sit-for 2 "Authentication failed")
(server-send-string
proc (concat "-error " (server-quote-arg "Authentication failed")))
(unless (eq system-type 'windows-nt)
(let ((terminal (process-get proc 'terminal)))
;; Only delete the terminal if it is non-nil.
(when (and terminal (eq (terminal-live-p terminal) t))
(delete-terminal terminal))))
;; Before calling `delete-process', give emacsclient time to
;; receive the error string and shut down on its own.
;; FIXME: Why do we wait 1s here but 5s in the other one?
(run-with-timer 1 nil #'delete-process proc)
;; We return immediately.
(cl-return-from server--process-filter)))
bug-gnu-emacs@HIDDEN:bug#72312; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 26 Jul 2024 20:27:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 26 16:27:35 2024 Received: from localhost ([127.0.0.1]:40112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sXRXL-0005E3-HE for submit <at> debbugs.gnu.org; Fri, 26 Jul 2024 16:27:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:42004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <thuna.cing@HIDDEN>) id 1sXRXG-0005Dt-V0 for submit <at> debbugs.gnu.org; Fri, 26 Jul 2024 16:27:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <thuna.cing@HIDDEN>) id 1sXRX7-0000qT-Ak for bug-gnu-emacs@HIDDEN; Fri, 26 Jul 2024 16:27:21 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <thuna.cing@HIDDEN>) id 1sXRX5-0006Pd-Qn for bug-gnu-emacs@HIDDEN; Fri, 26 Jul 2024 16:27:21 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2f035ae1083so20610581fa.3 for <bug-gnu-emacs@HIDDEN>; Fri, 26 Jul 2024 13:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722025637; x=1722630437; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=3fgwCWX5wqssIgvmCYisv1C3xSW+hq1rz33UcLWRaYo=; b=LDMK6WkUdnIOK5nfO2VvRzCE9K0/YBRQ+yeF4fQE/1rvwkp4l5qLM66Io6P3Aoiduz 8csF2Rg3uBodPzHDCf1bAlTdiUk3OMZGVSLwmlThYEW7hCiRxvb4ZdBhGN1R2xuTdADh 2RuR4lEYruKcqp+WkALOOx3XDavltpfHOwExo/oxpVTQqEvj7gtIaerOvn6DKy5p3NWo e1gWkw8nVOE3C6T3a++ahcuZdwc56rK8ojRpQyOO2VFECvnDi7nbisyDD5frSloSQI5v fnE+7+0qbaThNo0b2bHKPfmbO6Df9c2yz3I3voZpIhTKbhsGRtxISF+Mt3PxU9GhJ4gN RSTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722025637; x=1722630437; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3fgwCWX5wqssIgvmCYisv1C3xSW+hq1rz33UcLWRaYo=; b=F1MUlsUZzHWD2OO9yLksN/ZAr9xQXffHS3OEDDKA1nLwmxeY1Eo5W6U3QYRpjJaxkU JwC1iCsUnJEbHmKi+g6QTowxPEp0bvCJZ46e1ccn4W4fD6NHNkKmKaXge3G9YM5kAw+H ywNwX17KAzeoHlo54yxJvvfNkvBY5fXeJ+AGndG+lXqu1I0TYOcJj6yZw+yfVYkmxc9R dWWw8cjUfusVyZ1VyFSvd5iTZD7Y7x5s03EdhPXe/hkHoazBHerNukzC3xWD++2UQp5F x0ppPINzql4jJdHtgFvBWmjXXojWHfQSxCn6lHBlfOcS1G5fqwqseO0T3UbMRKdNo43E r1LA== X-Gm-Message-State: AOJu0YylTh1DuIcTq1YqC/E9xuN6gVRootcXfhpDuKa043HgHEb6rjX3 23+pJG4mL8jCBVUBQ690KL0GQb+3pLiH0TiPd6tE2T+rV3EvhLKAmg8ndQ== X-Google-Smtp-Source: AGHT+IF+dfLQfjR+SubjBdP9rvKkRpuDpoyvHP0SCenUNdoKevsgE4QbGbryRvKNUzQsfWeaB+SmbA== X-Received: by 2002:a2e:9210:0:b0:2ef:265e:bb93 with SMTP id 38308e7fff4ca-2f12edfb4e5mr4768831fa.3.1722025636933; Fri, 26 Jul 2024 13:27:16 -0700 (PDT) Received: from thuna-lis3 ([85.106.105.81]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427f9372e99sm130887835e9.16.2024.07.26.13.27.16 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 13:27:16 -0700 (PDT) From: Thuna <thuna.cing@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: server--process-filter-1 returns from the wrong block Date: Fri, 26 Jul 2024 22:27:14 +0200 Message-ID: <87y15n3nml.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::232; envelope-from=thuna.cing@HIDDEN; helo=mail-lj1-x232.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) In `server--process-filter-1' in lisp/server.el I assume the `return-from' on line 28 was meant to be from `server--process-filter-1' and not `server--process-filter'.
Thuna <thuna.cing@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#72312; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.