GNU bug report logs - #72329
Avoid recursion in gnus-message-citation-mode

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Thuna <thuna.cing@HIDDEN>; dated Sun, 28 Jul 2024 01:32:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 72329 <at> debbugs.gnu.org:


Received: (at 72329) by debbugs.gnu.org; 28 Sep 2024 08:48:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 04:48:41 2024
Received: from localhost ([127.0.0.1]:51755 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1suT85-00056J-0b
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 04:48:41 -0400
Received: from eggs.gnu.org ([209.51.188.92]:59258)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1suT84-000566-6X
 for 72329 <at> debbugs.gnu.org; Sat, 28 Sep 2024 04:48:40 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1suT7U-0000oX-6m; Sat, 28 Sep 2024 04:48:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=pafHVjlnLQBsSfTS04p+GUII0JAW7MJxM157gi1MeWI=; b=nWI2Jf0AKGvB
 qWxN7n5eXqZqG1YLgFI6IiYRvIAmKMXvfKmciigaXISkgB5Ij2CrBxA8xdyKqIMHu+MzXU1Ub2NWS
 dHiw7XpjPleCihOxK/DIoWgYF86s4CtQaPl9IqKfJ/yLBUyIX53XFo8xsCKamPNq9H7EH0QqfVMiq
 rT7sVKu7NYHyhCyWcTC7mcfN3dWvqvO2ptA2FLm68XbcaaPalGn74m7UoQZ8v7w/IYHCF4b5xYoJu
 3iI6ESpHxqwc7eO/9dF2p754IEiVh/TEf9VJ5NXYWmNDR9bU7utvcSoqDa5jsqyLCU6wupLUACKHe
 S9C1qwUt7VMWT7HeNHcecw==;
Date: Sat, 28 Sep 2024 11:48:00 +0300
Message-Id: <86r0946u67.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: eric@HIDDEN
In-Reply-To: <86h6aiitak.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 14
 Sep 2024 10:33:07 +0300)
Subject: Re: bug#72329: Avoid recursion in gnus-message-citation-mode
References: <877cd62thb.fsf@HIDDEN> <86y15fv0xx.fsf@HIDDEN>
 <86y14v4nfo.fsf@HIDDEN> <86v7zhcegl.fsf@HIDDEN> <86h6aiitak.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72329
Cc: thuna.cing@HIDDEN, 72329 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping! Ping! Ping! Ping!

> Cc: 72329 <at> debbugs.gnu.org, thuna.cing@HIDDEN
> Date: Sat, 14 Sep 2024 10:33:07 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> Ping! Ping! Ping! Eric, are you there?
> 
> > Cc: thuna.cing@HIDDEN, 72329 <at> debbugs.gnu.org
> > Date: Sat, 31 Aug 2024 10:56:58 +0300
> > From: Eli Zaretskii <eliz@HIDDEN>
> > 
> > Ping! Ping!  Eric, any comments?
> > 
> > > Cc: 72329 <at> debbugs.gnu.org, thuna.cing@HIDDEN
> > > Date: Sat, 17 Aug 2024 10:29:31 +0300
> > > From: Eli Zaretskii <eliz@HIDDEN>
> > > 
> > > Ping! Eric, any comments?
> > > 
> > > > Cc: 72329 <at> debbugs.gnu.org
> > > > Date: Fri, 02 Aug 2024 10:27:54 +0300
> > > > From: Eli Zaretskii <eliz@HIDDEN>
> > > > 
> > > > > From: Thuna <thuna.cing@HIDDEN>
> > > > > Date: Sun, 28 Jul 2024 03:30:40 +0200
> > > > > 
> > > > > In `gnus-message-citation-mode' the
> > > > > 
> > > > >   (if (not font-lock-mode)
> > > > >       (gnus-message-citation-mode (font-lock-mode 1))
> > > > >     ...)
> > > > > 
> > > > > can lead to excessive nesting if font-lock-mode fails to be set (quick
> > > > > enough or altogether).  Changing this with
> > > > > 
> > > > >   (while (not font-lock-mode) (font-lock-mode 1))
> > > > >   ...
> > > > > 
> > > > > should be better, assuming it is necessary for `font-lock-mode' to be
> > > > > called repeatedly, otherwise
> > > > > 
> > > > >   (font-lock-mode 1)
> > > > >   (while (not font-lock-mode))
> > > > >   ...
> > > > > 
> > > > > might also work, or simply
> > > > > 
> > > > >   (font-lock-mode 1)
> > > > >   ...
> > > > > 
> > > > > if it is not necessary to wait.
> > > > > 
> > > > > One possible problem with these arrangements is that it may be desirable
> > > > > to error in case there is an issue which prevents font-lock-mode from
> > > > > being set perpetually, in which case something like
> > > > > 
> > > > >   (font-lock-mode 1)
> > > > >   (with-timeout (<however-long-before-giving-up>
> > > > >                  (error "Failed to enable `font-lock-mode'."))
> > > > >     (while (not font-lock-mode)))
> > > > >   ...
> > > > > 
> > > > > might be preferable.
> > > > 
> > > > Thanks.
> > > > 
> > > > Eric, any comments or suggestions?
> > > > 
> > > > 
> > > > 
> > > > 
> > > 
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#72329; Package emacs. Full text available.

Message received at 72329 <at> debbugs.gnu.org:


Received: (at 72329) by debbugs.gnu.org; 14 Sep 2024 07:33:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 14 03:33:29 2024
Received: from localhost ([127.0.0.1]:44648 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1spNHc-0002dh-KI
	for submit <at> debbugs.gnu.org; Sat, 14 Sep 2024 03:33:29 -0400
Received: from eggs.gnu.org ([209.51.188.92]:42456)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1spNHa-0002dR-7N
 for 72329 <at> debbugs.gnu.org; Sat, 14 Sep 2024 03:33:26 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1spNHK-0000Ky-CW; Sat, 14 Sep 2024 03:33:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=l+0kwYd8piDEdV9sc+7BbUg8sRvHPubUCOiKfb7AkNY=; b=M2FmqFSi5Qjc
 qZuFuF6C9SRa6nlfEfQIwjySuO5Gl8zMwkycNvqJqAkdfJInjpYpcZ+uXTxpW9WEootNrJG8YvNKZ
 2IZXfoIhYL9ZQz1dfpClocS7nUs+LOPhUOy5xr+8tN8evKouEa9owalGIb/djNTsq8kKi51EgyWk/
 2UrTfW07CYRvxuYYR4+8DwA7FS9bpsts+Jdp3MRn9nKeT7xLeYFZ/Oc97AiLhHyuMoSxXV7oSikBp
 QhUMyvZl83fWEK+6F/HJS871bmlMYYqfQC8Dw4GYJmVAKM9okDcVX5jSjoXfHqsil+nDWrCwu16UE
 jrYa3ZrNhJ1SOuHfdNjgxg==;
Date: Sat, 14 Sep 2024 10:33:07 +0300
Message-Id: <86h6aiitak.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: eric@HIDDEN
In-Reply-To: <86v7zhcegl.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 31
 Aug 2024 10:56:58 +0300)
Subject: Re: bug#72329: Avoid recursion in gnus-message-citation-mode
References: <877cd62thb.fsf@HIDDEN> <86y15fv0xx.fsf@HIDDEN>
 <86y14v4nfo.fsf@HIDDEN> <86v7zhcegl.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72329
Cc: 72329 <at> debbugs.gnu.org, thuna.cing@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping! Ping! Ping! Eric, are you there?

> Cc: thuna.cing@HIDDEN, 72329 <at> debbugs.gnu.org
> Date: Sat, 31 Aug 2024 10:56:58 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> Ping! Ping!  Eric, any comments?
> 
> > Cc: 72329 <at> debbugs.gnu.org, thuna.cing@HIDDEN
> > Date: Sat, 17 Aug 2024 10:29:31 +0300
> > From: Eli Zaretskii <eliz@HIDDEN>
> > 
> > Ping! Eric, any comments?
> > 
> > > Cc: 72329 <at> debbugs.gnu.org
> > > Date: Fri, 02 Aug 2024 10:27:54 +0300
> > > From: Eli Zaretskii <eliz@HIDDEN>
> > > 
> > > > From: Thuna <thuna.cing@HIDDEN>
> > > > Date: Sun, 28 Jul 2024 03:30:40 +0200
> > > > 
> > > > In `gnus-message-citation-mode' the
> > > > 
> > > >   (if (not font-lock-mode)
> > > >       (gnus-message-citation-mode (font-lock-mode 1))
> > > >     ...)
> > > > 
> > > > can lead to excessive nesting if font-lock-mode fails to be set (quick
> > > > enough or altogether).  Changing this with
> > > > 
> > > >   (while (not font-lock-mode) (font-lock-mode 1))
> > > >   ...
> > > > 
> > > > should be better, assuming it is necessary for `font-lock-mode' to be
> > > > called repeatedly, otherwise
> > > > 
> > > >   (font-lock-mode 1)
> > > >   (while (not font-lock-mode))
> > > >   ...
> > > > 
> > > > might also work, or simply
> > > > 
> > > >   (font-lock-mode 1)
> > > >   ...
> > > > 
> > > > if it is not necessary to wait.
> > > > 
> > > > One possible problem with these arrangements is that it may be desirable
> > > > to error in case there is an issue which prevents font-lock-mode from
> > > > being set perpetually, in which case something like
> > > > 
> > > >   (font-lock-mode 1)
> > > >   (with-timeout (<however-long-before-giving-up>
> > > >                  (error "Failed to enable `font-lock-mode'."))
> > > >     (while (not font-lock-mode)))
> > > >   ...
> > > > 
> > > > might be preferable.
> > > 
> > > Thanks.
> > > 
> > > Eric, any comments or suggestions?
> > > 
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#72329; Package emacs. Full text available.

Message received at 72329 <at> debbugs.gnu.org:


Received: (at 72329) by debbugs.gnu.org; 31 Aug 2024 07:58:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 31 03:58:15 2024
Received: from localhost ([127.0.0.1]:53833 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1skIzu-00065j-MI
	for submit <at> debbugs.gnu.org; Sat, 31 Aug 2024 03:58:14 -0400
Received: from eggs.gnu.org ([209.51.188.92]:53552)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1skIzt-00065R-1Y
 for 72329 <at> debbugs.gnu.org; Sat, 31 Aug 2024 03:58:13 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1skIyr-0004UL-5e; Sat, 31 Aug 2024 03:57:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=oFezNXNpNFLKVSlmgh+V9A0FcOuaKvhdZIkH+3tmueE=; b=HMT3bGnFY5Nb
 CTOnhqFvFVlhpeATXgI32N4iWNb4YY1so3r++8KEPuKy9nPvKW56oHc3XVsAqbsL39ViqI5NWqfH1
 mOVPPpyC2rx9kiSnI+O5s+iTJQs41pw77rexNpSx9oUTEYA5LW6Q2bgbkAnuCTIojrRjtkgZDw/8Q
 WUz1cH3mp94cDqcAq2pZAH/yn4KJ247P3Ei8hBml2jSqKUyLlCSk2iKizFycfvAk1GG0zvJYjnhFe
 gaH5HXi24SYzhA194PiLqwyr/Y7QBCiWOvSstDHOCmlf62NFeRCnuS6JfjuqpYyArIgcTu7Qn8MtM
 d+laF9Q3PM+6YOwJScLO8w==;
Date: Sat, 31 Aug 2024 10:56:58 +0300
Message-Id: <86v7zhcegl.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: eric@HIDDEN
In-Reply-To: <86y14v4nfo.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 17
 Aug 2024 10:29:31 +0300)
Subject: Re: bug#72329: Avoid recursion in gnus-message-citation-mode
References: <877cd62thb.fsf@HIDDEN> <86y15fv0xx.fsf@HIDDEN>
 <86y14v4nfo.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72329
Cc: thuna.cing@HIDDEN, 72329 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping! Ping!  Eric, any comments?

> Cc: 72329 <at> debbugs.gnu.org, thuna.cing@HIDDEN
> Date: Sat, 17 Aug 2024 10:29:31 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> Ping! Eric, any comments?
> 
> > Cc: 72329 <at> debbugs.gnu.org
> > Date: Fri, 02 Aug 2024 10:27:54 +0300
> > From: Eli Zaretskii <eliz@HIDDEN>
> > 
> > > From: Thuna <thuna.cing@HIDDEN>
> > > Date: Sun, 28 Jul 2024 03:30:40 +0200
> > > 
> > > In `gnus-message-citation-mode' the
> > > 
> > >   (if (not font-lock-mode)
> > >       (gnus-message-citation-mode (font-lock-mode 1))
> > >     ...)
> > > 
> > > can lead to excessive nesting if font-lock-mode fails to be set (quick
> > > enough or altogether).  Changing this with
> > > 
> > >   (while (not font-lock-mode) (font-lock-mode 1))
> > >   ...
> > > 
> > > should be better, assuming it is necessary for `font-lock-mode' to be
> > > called repeatedly, otherwise
> > > 
> > >   (font-lock-mode 1)
> > >   (while (not font-lock-mode))
> > >   ...
> > > 
> > > might also work, or simply
> > > 
> > >   (font-lock-mode 1)
> > >   ...
> > > 
> > > if it is not necessary to wait.
> > > 
> > > One possible problem with these arrangements is that it may be desirable
> > > to error in case there is an issue which prevents font-lock-mode from
> > > being set perpetually, in which case something like
> > > 
> > >   (font-lock-mode 1)
> > >   (with-timeout (<however-long-before-giving-up>
> > >                  (error "Failed to enable `font-lock-mode'."))
> > >     (while (not font-lock-mode)))
> > >   ...
> > > 
> > > might be preferable.
> > 
> > Thanks.
> > 
> > Eric, any comments or suggestions?
> > 
> > 
> > 
> > 
> 
> 
> 
> 




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#72329; Package emacs. Full text available.

Message received at 72329 <at> debbugs.gnu.org:


Received: (at 72329) by debbugs.gnu.org; 17 Aug 2024 07:30:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 17 03:30:20 2024
Received: from localhost ([127.0.0.1]:53316 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sfDtD-0007kE-Sa
	for submit <at> debbugs.gnu.org; Sat, 17 Aug 2024 03:30:20 -0400
Received: from eggs.gnu.org ([209.51.188.92]:40350)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sfDtC-0007k0-AP
 for 72329 <at> debbugs.gnu.org; Sat, 17 Aug 2024 03:30:18 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sfDsU-0004t9-0k; Sat, 17 Aug 2024 03:29:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=3sk64Ubojr6Fixmn1Z98MTfWzkKoYczp7X+S0qODAUI=; b=JBC94u0InM69
 B432OAG5lmIrIhMpdvoDnqIcKPhCVnFqfCVUylQerFj7Va4lybRqZjy7mhiEOtNyqKxq/xlFv8ma+
 zqvEGr3WhyJFGHAdw6s0vaa89jFk8o26I4jZx/pyMMT/N2+6/9ZsFpO7pjlEbzpWPAhDXIr87xJWm
 bypQoNIak1V0wA3pm9tuXcOqDy5JWh70bUxXji3DFy4YiiQi5wxH4fU27vuCtkYlO3pma2wTH5OOt
 L6M2y64T0TZoFrZwK+23A1JdeaKuDciIspt5YZS6SDhsiQ0FCmGpalOFScJzQNfC/WlIwD+eQ5QoZ
 MUn2rSEjPY2rniQEC9ZhlA==;
Date: Sat, 17 Aug 2024 10:29:31 +0300
Message-Id: <86y14v4nfo.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: eric@HIDDEN
In-Reply-To: <86y15fv0xx.fsf@HIDDEN> (message from Eli Zaretskii on Fri, 02
 Aug 2024 10:27:54 +0300)
Subject: Re: bug#72329: Avoid recursion in gnus-message-citation-mode
References: <877cd62thb.fsf@HIDDEN> <86y15fv0xx.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72329
Cc: 72329 <at> debbugs.gnu.org, thuna.cing@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping! Eric, any comments?

> Cc: 72329 <at> debbugs.gnu.org
> Date: Fri, 02 Aug 2024 10:27:54 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > From: Thuna <thuna.cing@HIDDEN>
> > Date: Sun, 28 Jul 2024 03:30:40 +0200
> > 
> > In `gnus-message-citation-mode' the
> > 
> >   (if (not font-lock-mode)
> >       (gnus-message-citation-mode (font-lock-mode 1))
> >     ...)
> > 
> > can lead to excessive nesting if font-lock-mode fails to be set (quick
> > enough or altogether).  Changing this with
> > 
> >   (while (not font-lock-mode) (font-lock-mode 1))
> >   ...
> > 
> > should be better, assuming it is necessary for `font-lock-mode' to be
> > called repeatedly, otherwise
> > 
> >   (font-lock-mode 1)
> >   (while (not font-lock-mode))
> >   ...
> > 
> > might also work, or simply
> > 
> >   (font-lock-mode 1)
> >   ...
> > 
> > if it is not necessary to wait.
> > 
> > One possible problem with these arrangements is that it may be desirable
> > to error in case there is an issue which prevents font-lock-mode from
> > being set perpetually, in which case something like
> > 
> >   (font-lock-mode 1)
> >   (with-timeout (<however-long-before-giving-up>
> >                  (error "Failed to enable `font-lock-mode'."))
> >     (while (not font-lock-mode)))
> >   ...
> > 
> > might be preferable.
> 
> Thanks.
> 
> Eric, any comments or suggestions?
> 
> 
> 
> 




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#72329; Package emacs. Full text available.

Message received at 72329 <at> debbugs.gnu.org:


Received: (at 72329) by debbugs.gnu.org; 2 Aug 2024 07:28:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 02 03:28:23 2024
Received: from localhost ([127.0.0.1]:52239 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sZmi7-0007SH-8D
	for submit <at> debbugs.gnu.org; Fri, 02 Aug 2024 03:28:23 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45630)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sZmi4-0007S3-J9
 for 72329 <at> debbugs.gnu.org; Fri, 02 Aug 2024 03:28:21 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sZmhg-00049v-LZ; Fri, 02 Aug 2024 03:27:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=8RJLcfiu5xGBlf6D50j2l/h6AjoANHLEc2KKZmh9V3E=; b=B5jvSM1Nquz3
 XAow0hB9mfi0HF+rpC9PQPd3aYDsgnT3c6oPKXjcNDdgne6/MxmMUfscI8mLA8c5p8s3ryGpwnoWK
 YA4DDmqTS72h/86l8IAeg+E8F1vIXTEE+YXi4aXBe8YSjz2SyXV/x5INfdWTV7XP0v35kBBa4bKEj
 7N86jZiTIoUTM24BWmiiw/lbIifO8NQYoDzbH5aDvW4VPPg5D1qgZIqqd+CaHj5YvpjJQ0V7TNuEU
 thh5FO8X3ZgVOWKt1iGWTFUtvzo0b+1l7vAVkHKzrVmvy0qr7QbQuvBO5ZRu+8j6wihP1Z7MAI0kk
 HybX8H+5UuaeCmsiwTrdzA==;
Date: Fri, 02 Aug 2024 10:27:54 +0300
Message-Id: <86y15fv0xx.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Thuna <thuna.cing@HIDDEN>, eric@HIDDEN
In-Reply-To: <877cd62thb.fsf@HIDDEN> (message from Thuna on Sun, 28 Jul
 2024 03:30:40 +0200)
Subject: Re: bug#72329: Avoid recursion in gnus-message-citation-mode
References: <877cd62thb.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72329
Cc: 72329 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Thuna <thuna.cing@HIDDEN>
> Date: Sun, 28 Jul 2024 03:30:40 +0200
> 
> In `gnus-message-citation-mode' the
> 
>   (if (not font-lock-mode)
>       (gnus-message-citation-mode (font-lock-mode 1))
>     ...)
> 
> can lead to excessive nesting if font-lock-mode fails to be set (quick
> enough or altogether).  Changing this with
> 
>   (while (not font-lock-mode) (font-lock-mode 1))
>   ...
> 
> should be better, assuming it is necessary for `font-lock-mode' to be
> called repeatedly, otherwise
> 
>   (font-lock-mode 1)
>   (while (not font-lock-mode))
>   ...
> 
> might also work, or simply
> 
>   (font-lock-mode 1)
>   ...
> 
> if it is not necessary to wait.
> 
> One possible problem with these arrangements is that it may be desirable
> to error in case there is an issue which prevents font-lock-mode from
> being set perpetually, in which case something like
> 
>   (font-lock-mode 1)
>   (with-timeout (<however-long-before-giving-up>
>                  (error "Failed to enable `font-lock-mode'."))
>     (while (not font-lock-mode)))
>   ...
> 
> might be preferable.

Thanks.

Eric, any comments or suggestions?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#72329; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Jul 2024 01:31:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 27 21:31:52 2024
Received: from localhost ([127.0.0.1]:42538 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sXslM-00079x-5d
	for submit <at> debbugs.gnu.org; Sat, 27 Jul 2024 21:31:52 -0400
Received: from lists.gnu.org ([209.51.188.17]:60600)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <thuna.cing@HIDDEN>) id 1sXslK-00079m-Dn
 for submit <at> debbugs.gnu.org; Sat, 27 Jul 2024 21:31:50 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <thuna.cing@HIDDEN>)
 id 1sXsl9-0007tY-3y
 for bug-gnu-emacs@HIDDEN; Sat, 27 Jul 2024 21:31:39 -0400
Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <thuna.cing@HIDDEN>)
 id 1sXsl6-0002ps-Ao
 for bug-gnu-emacs@HIDDEN; Sat, 27 Jul 2024 21:31:38 -0400
Received: by mail-lj1-x236.google.com with SMTP id
 38308e7fff4ca-2ef2d7d8854so30370301fa.0
 for <bug-gnu-emacs@HIDDEN>; Sat, 27 Jul 2024 18:31:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1722130294; x=1722735094; darn=gnu.org;
 h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=4TEat0lhwkoi6QOGe2ENrC8gw7ZQhrlQzx06nHpFuUw=;
 b=Pwrbhm9ieXfpmVRAcYQrPwcVconfH8KY5JRg8cejo/5ccEsMPwwY+h9BlWP4hMzlWA
 2yMuBfMhZ374Ft1IHdypiJQH++jaTTF9w9AM8KZ6rjPeqX8TEX872XtC/HcjxT01nJ/T
 wD8qqjOOxYpbwDP+w8LPdNNWMRO4o8Ir6GKuTDRXispWonoa9hncYQbarcW+tZgBYpAm
 L0vQMcILOsjNstVDfapd5vmIZdjj6Zkiw3X2AZri5mjRS90OjhFRZNcjP1P1+m6fgtj+
 kURw7k2Y9AfaheY4rLN4viXhUjV4XQwHcqz68TIIHUgigGLnFVY+Hwo087gtKQ4cA7+R
 Gb8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1722130294; x=1722735094;
 h=mime-version:message-id:date:subject:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=4TEat0lhwkoi6QOGe2ENrC8gw7ZQhrlQzx06nHpFuUw=;
 b=d+ST6kO/hSmhjL06WVRKCj9WLIM5y7tpY3UcyU2AQMd8d8kEN45bnMV1scVM0nUa04
 XeZRLu8qXNHb9LV01Yq/jdC4R3Qn/L1ULegcAk/XZnSr8XpK1tDgrqj8Ezv+4S+ZyFkU
 N5VSkmf5xiuIYRlir1IAOgukA01we0kVLTS09aU8lHj+ITe4UKOK+qbnhEPZ8f2PzqJe
 YAez1bJGtTcAyuVneNnfO5/c2gqsq/taUHqhnAlH1JoU1yizPQuQI8hTPjRRHRBw1QUJ
 ZJ0+M6K5ZUvuWAjF6MEW1qAqnHmQw4nYf47sIqrVHScTvv+B5d5bFU/5A+jK1EAAeRlW
 imMQ==
X-Gm-Message-State: AOJu0Yy43CfLrIP7ADS+qXUQLUvW0Gtg96dy4g8/ZRy3qnWGzA6tIjru
 2wteFGyKO1oU92Yne9eNNwbybVkXvhQTUYRb5EuVTWCIkWCJtLHFlv/SnQ==
X-Google-Smtp-Source: AGHT+IED6G9ADfxAYEQzU+vjQNPRIpx1UJ6bXT7bCgD6NpW8KUtM5BzOSX16byupY2P23+R6PdNMXg==
X-Received: by 2002:a2e:818b:0:b0:2ef:2d13:b1a with SMTP id
 38308e7fff4ca-2f12ee1bdcfmr25708471fa.33.1722130293846; 
 Sat, 27 Jul 2024 18:31:33 -0700 (PDT)
Received: from thuna-lis3 ([85.106.105.81]) by smtp.gmail.com with ESMTPSA id
 4fb4d7f45d1cf-5ac64eb3591sm3647190a12.67.2024.07.27.18.31.19
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 27 Jul 2024 18:31:33 -0700 (PDT)
From: Thuna <thuna.cing@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: Avoid recursion in gnus-message-citation-mode
Date: Sun, 28 Jul 2024 03:30:40 +0200
Message-ID: <877cd62thb.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::236;
 envelope-from=thuna.cing@HIDDEN; helo=mail-lj1-x236.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

In `gnus-message-citation-mode' the

  (if (not font-lock-mode)
      (gnus-message-citation-mode (font-lock-mode 1))
    ...)

can lead to excessive nesting if font-lock-mode fails to be set (quick
enough or altogether).  Changing this with

  (while (not font-lock-mode) (font-lock-mode 1))
  ...

should be better, assuming it is necessary for `font-lock-mode' to be
called repeatedly, otherwise

  (font-lock-mode 1)
  (while (not font-lock-mode))
  ...

might also work, or simply

  (font-lock-mode 1)
  ...

if it is not necessary to wait.

One possible problem with these arrangements is that it may be desirable
to error in case there is an issue which prevents font-lock-mode from
being set perpetually, in which case something like

  (font-lock-mode 1)
  (with-timeout (<however-long-before-giving-up>
                 (error "Failed to enable `font-lock-mode'."))
    (while (not font-lock-mode)))
  ...

might be preferable.




Acknowledgement sent to Thuna <thuna.cing@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#72329; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.