Received: (at 72343) by debbugs.gnu.org; 12 Aug 2024 16:55:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 12 12:55:39 2024 Received: from localhost ([127.0.0.1]:43705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sdYKZ-0003kf-2N for submit <at> debbugs.gnu.org; Mon, 12 Aug 2024 12:55:39 -0400 Received: from mail-oo1-f51.google.com ([209.85.161.51]:46140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sdYKX-0003kL-6q for 72343 <at> debbugs.gnu.org; Mon, 12 Aug 2024 12:55:37 -0400 Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-5d5b850d969so2873298eaf.0 for <72343 <at> debbugs.gnu.org>; Mon, 12 Aug 2024 09:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723481639; x=1724086439; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PuzCiXEoOzvwLyLzmIBbw8/aGhbfIVRPD/o63mP1KCk=; b=EAnAFLYfnh+p+uB8E+mzfXZNMXUkEs7e3ofcXFRCL0ilwQkOlRwWaunCwvsKrUIp/1 xkN350E523G2NTAJuE12/Fdk/zNWvEyEswSaaNMdHmxqTJx71mLmLEeW8zoN954njP1v JZVGo/wxGy14TgC7JpMwatFBdgbort395aYW3BIUY4yuN3snyXFF7h5bg8oRhOBbEgud 8k1vn8drVJgm38EEaBeET9NJmvvH+O8w5TK4tzlIWzXjc1s5LI9L7nl1rdD68qjZJOU2 1TovyGtJfV2tTj5IPhSIaBfMJTKfX6vyQeMO0gHiyDwyjTYEBob0VxO3udM5xCLu6eIF oBeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723481639; x=1724086439; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PuzCiXEoOzvwLyLzmIBbw8/aGhbfIVRPD/o63mP1KCk=; b=El9yUuBLNMM/hmWg1ltPjMEsgFvvGunLsde0nS+bLFdJlYYasNTg9GhjE9mc8b42eu xXR4ypkX6dDy4Hd6UmwyaqkTlxA342lyjm8yg3VG09ggSMQIy2WkH1XU9FnK32Oov0jU Mh/IohpRp1GyVe022RQYhAzx9kNvlY6zPE0kguSmUi4J4BA108ISG0JDtmgK/S3FU0Ye IULY4Wt0MVXy55hGqjFyQGR2FIUENWAU1qlsOvhifFz4yrfif7eYB3gNHNDcp5fGeMsg Lamb3ZPRpESZzBoTRLwITuilaCPCweDO/hAK8rU4g4WSmb5XIIwBnls3KMhXH3sUaffu 93aA== X-Forwarded-Encrypted: i=1; AJvYcCXMf90sAxzJJ0lc+kRYQRvYZhANa1s77FgV/7cGUhIzaWv/BDVY0PA91eYUdN4xbE3prvbxo3MEgbsrSJwbndptg6lb1Ig= X-Gm-Message-State: AOJu0Ywu6tHhRrCSMMZnnLoYz26HrGTBUO8ho4OvTD2RW8tX4/NQXpMf ol0CL0DY9UWCWT5b2jJ4mra8hbIsRUt/g9wODQ0dX99t6/6M4DvY9P2JFF/ZBEaXXks1bxb2Xrf WxCs5R3ABLttQMqtrAPxzrWIbU50= X-Google-Smtp-Source: AGHT+IEEia+aFKLcEL5mxvcb/2PPU+ZhWTsORyC/dXXJ+63EiWFMdfTC1fYcD5NODt5XUvWQnX2PiQEov763R/SZEPM= X-Received: by 2002:a05:6820:1690:b0:5d8:6769:9d85 with SMTP id 006d021491bc7-5da6899b2f5mr1117833eaf.6.1723481639210; Mon, 12 Aug 2024 09:53:59 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> <87bk24rgek.fsf@HIDDEN> <CALDnm538yLaa_YP8JN6JCcFe2Y-dvfaZYwjSrmpWsugVsDgk7Q@HIDDEN> <8734n98zp2.fsf@HIDDEN> In-Reply-To: <8734n98zp2.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Mon, 12 Aug 2024 17:53:48 +0100 Message-ID: <CALDnm50obTjqZiqeXn+snn6o+XxZBYJ6ZyQg_0qCwVR8Hu+iAA@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Philip Kaludercic <philipk@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, Augusto Stoffel <arstoffel@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Mon, Aug 12, 2024 at 5:37=E2=80=AFPM Philip Kaludercic <philipk@HIDDEN= et> wrote: > FWIW I have a number of other things on my todo list, and this isn't on > the top for now. So unless I can help and advise someone, this is going > to take a while. I'm not going to rush you or anyone. But since you proposed this this in the past, I thought you'd want to be aware of Augusto's observation. Jo=C3=A3o
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 12 Aug 2024 16:38:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 12 12:38:13 2024 Received: from localhost ([127.0.0.1]:43695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sdY3g-0003A8-P7 for submit <at> debbugs.gnu.org; Mon, 12 Aug 2024 12:38:13 -0400 Received: from mout01.posteo.de ([185.67.36.65]:38771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1sdY3e-00039q-5C for 72343 <at> debbugs.gnu.org; Mon, 12 Aug 2024 12:38:11 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5F905240029 for <72343 <at> debbugs.gnu.org>; Mon, 12 Aug 2024 18:37:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1723480651; bh=9uO84j+dHU09Z9lpioFR/CiTncwRpeBUIU73+G9MVc8=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=Vz8VzAJLLhZ9ba/9u7GBNAEmAYvUMfFuoNfu+jp0WfSGe5/s+2W7QK/l0sZwsZUdj HETf4OLQuj8tNtEXqtfDEwih+RfLM1YStGXpAVgv+nzYJIqytzofeKvtYxHXCO0KaY rWXfAe6DaVYjJQ2adX2IC+vy9yZ31ZvFVkHCpPA294vtTQX6RILb1cqfKQPSOc5pFA 261bZX1lu07gDEsh/G9tYMoCHyHyCXa/CVGCUcAaqqteFw8pp++nxJxUrNLWRxGPGy /s+L2uLbPQhu/T1lIYXMXS1NS2TjB18sz7ZSlDG70wQdCHcCDY6VCwfGQiQlhX7wNL cb5VMy9PoGpgA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WjKtf4Pywz9rxB; Mon, 12 Aug 2024 18:37:30 +0200 (CEST) From: Philip Kaludercic <philipk@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes In-Reply-To: <CALDnm538yLaa_YP8JN6JCcFe2Y-dvfaZYwjSrmpWsugVsDgk7Q@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 7 Aug 2024 14:23:02 +0100") References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> <87bk24rgek.fsf@HIDDEN> <CALDnm538yLaa_YP8JN6JCcFe2Y-dvfaZYwjSrmpWsugVsDgk7Q@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@HIDDEN; url="https://keys.openpgp.org/vks/v1/by-email/philipk@HIDDEN"; preference=signencrypt Date: Mon, 12 Aug 2024 16:37:29 +0000 Message-ID: <8734n98zp2.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, Augusto Stoffel <arstoffel@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > On Wed, Aug 7, 2024 at 7:33=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN= om> wrote: > >> By the way, if Eglot relies on that for the multi-language-per-session >> feature, then such feature would be incompatible with an >> `eglot-server-program' variable (note the singular) that major modes can >> set independently as a buffer-local variable. > > Yes, I think I mentioned this before. Depends on how you design the featu= re. > And you can't just defenestrate eglot-server-programs, you have to keep > backward compatibility to it. > >> Wouldn't it make more sense to reuse a running server if a new one would >> be started at the same directory and with the same command line >> arguments? > > The feature hasn't been designed so I don't understand the comparative > "more". But yes, it could make a lot of sense. But instead of "director= y", > "project". And instead of "command line arguments", "contact". > > CCing Philip who proposed working on this. FWIW I have a number of other things on my todo list, and this isn't on the top for now. So unless I can help and advise someone, this is going to take a while. > Jo=C3=A3o --=20 Philip Kaludercic on peregrine
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 7 Aug 2024 13:24:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 09:24:46 2024 Received: from localhost ([127.0.0.1]:33952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbgek-0005kK-3x for submit <at> debbugs.gnu.org; Wed, 07 Aug 2024 09:24:46 -0400 Received: from mail-oa1-f41.google.com ([209.85.160.41]:48513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sbgei-0005k6-BM for 72343 <at> debbugs.gnu.org; Wed, 07 Aug 2024 09:24:44 -0400 Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-260e1b5576aso1077215fac.1 for <72343 <at> debbugs.gnu.org>; Wed, 07 Aug 2024 06:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723036993; x=1723641793; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tH/R7399gP1jbI+mmYWXwni3+f6xaxIqfj/+FkR9mjU=; b=jfKrFOhE6RU2CTjWDRYIqEZj5bpVKcPSMSD4Ihjy/05JSvRj20SAP0BERnBMJW4dxx 1E1I+qxqCU9s9bYi9XzM0tkErDjW1elGRPu6mP9VcfXFywJGbQETz33FmeYLLGLGwCJK nl0mFRW+cYFm/Yohtra6idSQY4UXfLi1U0Dmp1TywqKId0lutRPQbDa01T6kODxa8G0c XLB9ox/7QKkNttD7lsdhcFUgHi4RC4YUdXqOfuqB7MsgE5GmDWbfywvymwRX/OAxqO8n kWupKO6yULTCLCxbDczER5kclaE+QdzDzirIFTgajMfPfK0TtxfUe2a5BdBj1XSbpk2W U3Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723036993; x=1723641793; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tH/R7399gP1jbI+mmYWXwni3+f6xaxIqfj/+FkR9mjU=; b=gJ0ng1dw4+r4eWKFU+9LOeBRjYVdsg6wfGM5LJHK3xKh3lVLw1AU040y2Cd7txk4L+ gMWI63UmAosTm+ZYoYlXG4vALdwYIjZSxz965AjeYJFBWjyORcfcn9j4uYGptZ+GqQGo H5nJ1zDRgZXmUSpiKbd2FrXzbtGbFHkXfMIXHBeXRN/Eb7996mxDa4PIK2tMbCuPDDXa tNXBQfLMmJsMhcjgvXuuWffmcSf96tUhDT9mkZkOnWuLB7Q6AJI3mOqSq6en8+QXmngA ozJ2dJmpzsTzH7/TfSyAWr1LDV8LFN68jbxm2Jzz1zhg2/cxIw1F45LZpKXOpCBDtRtp xlDg== X-Gm-Message-State: AOJu0YxaeMUzD0AOc81xaba5LbHho/laHgSErfRTjmtqEfT8/t7y2pqL wgoqNmWCo2IF8DcmwAobAouTBKRm5f7hwyO3DPZdsspR9wew5tn3jOBy4QStWgbKSwHyKEaNPwN 3M1CE4RFd63cKFt/vMbuBf0+UhRw= X-Google-Smtp-Source: AGHT+IFBeq+Tyz7BFudLtuJyNkXddbcp1Tuek4D9/N0zT0dB4nAZcdTdX2aZ5XafosDuClMhzdVRL0aKd+wowJN16N4= X-Received: by 2002:a05:6870:e389:b0:261:3f0:3c46 with SMTP id 586e51a60fabf-26891f3edfbmr21196096fac.46.1723036993585; Wed, 07 Aug 2024 06:23:13 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> <87bk24rgek.fsf@HIDDEN> In-Reply-To: <87bk24rgek.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Wed, 7 Aug 2024 14:23:02 +0100 Message-ID: <CALDnm538yLaa_YP8JN6JCcFe2Y-dvfaZYwjSrmpWsugVsDgk7Q@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN>, "Philip K." <philipk@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Wed, Aug 7, 2024 at 7:33=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN= > wrote: > By the way, if Eglot relies on that for the multi-language-per-session > feature, then such feature would be incompatible with an > `eglot-server-program' variable (note the singular) that major modes can > set independently as a buffer-local variable. Yes, I think I mentioned this before. Depends on how you design the feature= . And you can't just defenestrate eglot-server-programs, you have to keep backward compatibility to it. > Wouldn't it make more sense to reuse a running server if a new one would > be started at the same directory and with the same command line > arguments? The feature hasn't been designed so I don't understand the comparative "more". But yes, it could make a lot of sense. But instead of "directory"= , "project". And instead of "command line arguments", "contact". CCing Philip who proposed working on this. Jo=C3=A3o
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 7 Aug 2024 13:19:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 09:19:33 2024 Received: from localhost ([127.0.0.1]:33948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbgZh-0005aM-Ci for submit <at> debbugs.gnu.org; Wed, 07 Aug 2024 09:19:33 -0400 Received: from mail-oa1-f48.google.com ([209.85.160.48]:58504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sbgZf-0005a7-KX for 72343 <at> debbugs.gnu.org; Wed, 07 Aug 2024 09:19:32 -0400 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-26875acdf72so1003562fac.0 for <72343 <at> debbugs.gnu.org>; Wed, 07 Aug 2024 06:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723036680; x=1723641480; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gs67lmvU4tXEZ8bi51MLvN0JyWNIMvMGZW5yC9YNk2s=; b=WNvhqpw4+4ehnb/3/d4K8dld1buaHtJ4th9DbM86emSSOltDhsplDSIqXSYrrx/mPJ x+zPvaHryuOGMMape+WNEKnkMVCxtjDlQwrt5p4kv/wkiGWJBeY1Sj41DkNscQaIm+yT QItMo8Jii5iAs7dpNl7Hb2zeEJxnk+NEPeq0yCA9Rk4f4kumZ+06292croT6gbS1Omhi lHyTS4BwZzFEFjmxJT7PtndiXusVtwy2mOU0qaD2Hjz6xMhhtl547R2UVVWwhJGj1QxB Lrx1Q/vGL8l51N1pM8/8hiV4QtVgS6SYg7So8gSgojEiOxhnBpXLfz0XgghQbLsRDgV4 ZCHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723036680; x=1723641480; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gs67lmvU4tXEZ8bi51MLvN0JyWNIMvMGZW5yC9YNk2s=; b=lMlXRMqOVfEtMrAtkp+2dnaSgA9fvwcN6SHYa5VMPVktVoGFkgORhKFFbk1cLFaWTV FS8h2j3hqpmMHpqvxcS7lC//7RYT831GmGNaRgaujSq6xnhYstU+rp2NqnHjGUBkUgeb sUoPoYpnddE8Mc76RWyEjo1PcYW90gPYlEeQ6hloiwK5+jsqpVjR6NY/yP+cZFu2s7+h QUsN4X7cy9+lHUH4az/VDT7i/sAv6+6A02aLc8mYeYNaxPJCLQsRewG550htgJbWsm/n 9EkTzs30cPIx8VIKd2hK78ohzM5n7fCErfoMtr0Wrn1/f4ugrRjWXGvr2FSY1pNnsuXu YErA== X-Gm-Message-State: AOJu0Yw1366Vrm73cUf7KZLMtW4SsxJqPWiTm2I8IcKh9w9/5E832ZAm XT6paxZUe6HHHoE693aPety1tkJcWSrR+jb0RIKh9qGUHGp9V7BY5OadNGxHirHg15hnaEx1G/m hicljEBaKzkzS1chBXcxP709m1vE= X-Google-Smtp-Source: AGHT+IEI2ACZL33eLOYga9geUci69lX2b8QxIYjmKfdNWb1oy0d5os8siaUWgY9WkxxEUF+PbslSVW5olmxVaXeG4dQ= X-Received: by 2002:a05:6871:67c5:b0:268:97cb:f36c with SMTP id 586e51a60fabf-26897cbfcd5mr12641329fac.2.1723036680544; Wed, 07 Aug 2024 06:18:00 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> <87frrhxzbz.fsf@HIDDEN> <CALDnm51+-1-ug4Xu1douFOjNVnBgUEE7unWORvsyEvV=UBC9Nw@HIDDEN> <875xscrf1z.fsf@HIDDEN> <CALDnm530v0p=b+29p9p==6kHQ+D1OpRBMZPqsB5BFz3o=vr4NQ@HIDDEN> <87y158pu7t.fsf@HIDDEN> In-Reply-To: <87y158pu7t.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Wed, 7 Aug 2024 14:17:49 +0100 Message-ID: <CALDnm501CaGUbPdqmjHTdYiZ84TM8q-2Ru6FELyKAPZXEA=mUg@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Wed, Aug 7, 2024 at 10:18=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN= m> wrote: > "scheme". So I still see no advantage in sending less specific language > ids.) It's at the very least useful to know to _not_ send that file to the c/c++ server. > So this is my final suggestion then: > > > It solves problem X and my estimated breakage probability is > "infinitesimally small" since it works for LaTeX, BibTeX and ConTeXt and > all other dialects are very very fringe. Alright, and yes it even works without the simplification fix (that I'll also push, anyway). Jo=C3=A3o
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 7 Aug 2024 09:19:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 05:19:35 2024 Received: from localhost ([127.0.0.1]:33683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbcpT-0006SK-BG for submit <at> debbugs.gnu.org; Wed, 07 Aug 2024 05:19:35 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:60535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sbcpQ-0006Rz-4E for 72343 <at> debbugs.gnu.org; Wed, 07 Aug 2024 05:19:33 -0400 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-367990aaef3so855702f8f.0 for <72343 <at> debbugs.gnu.org>; Wed, 07 Aug 2024 02:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723022281; x=1723627081; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WbGJewUl5f7hhZPmt0cMKjG3qhlFzY6wdJgmeR2oxDo=; b=IusQy0lg/iovzXdTka2+7dmxE8e1bED1IeYj6AYxOhGrnn32dV1In3ZzKR91fLS2c3 ajxFydss+J0vILrfdZhlru02310ObpZS5OjorS5kMzdsEHSoETGe2aUjJRWkqjV8xvpM f0PTDoCWyTrozsICFGHoymo9ng3eIvj6/h/4BTk1twdrhiWaksIEDIeyVDVH2hewwAD2 KdLGrEIGrJWX3USGBdgPJhzK7f43atbtztGAE0ZJJmRzBSwZUcxi0kTez+aHeMfS5tih QHNFu0k0QHXyEEb4Pgn9TQ0FPRgjwsdSTPkOBIYOgHCZpbbU3FXI8SZ+41oGlpZEvmBm oofA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723022281; x=1723627081; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WbGJewUl5f7hhZPmt0cMKjG3qhlFzY6wdJgmeR2oxDo=; b=M8D2pdKwJgRosU4+enIlW41IsUtqXCiKSZJ/UNwDuokNBa7uXuJpNBKCpJ3iWsyjUi z9yDSTIGuAW5NeDuC4YJWrUvnmlQSyImKS1/eDX29KBr+mKIXw23T10mmWh1H0QNcq+Z QXAEqafWxCMc86ipvdp385X2ccLuzBNpgFP9CFndEEwK8q5Ze8cJ4qubL/N0jkB+/CHJ g+DB373uW5upEvJdfso8vijFTmtaoGzvAA8efZVMBABzOWSK3EIfMwSyjWZTXIOK4flc jpOGTTL4tEuZZHjZYhuyPEzAUcuyNWvnBYxjZuCFbIKROiUsQ6bt6GuQS9YHchCD5nL1 MIKg== X-Gm-Message-State: AOJu0YzK78h1AzVbmUyqs6ySQJ9XeRMxqLDrIhm4MSQlp7wtCMtAMLe+ dARpHpVnnDc9p3uZdC6+CymFHHRZy8iob5nVKTAMCJbhEoH4tcq0 X-Google-Smtp-Source: AGHT+IHhBz/9d1m6RkM0vzl6TyBQEY9XnfgrWs1yNS8pLKs4iqAUBOEjn7m4fq6U6edJQ9/F/dd2GQ== X-Received: by 2002:a05:6000:1246:b0:369:e72c:875f with SMTP id ffacd0b85a97d-36bbc164337mr12460536f8f.48.1723022280853; Wed, 07 Aug 2024 02:18:00 -0700 (PDT) Received: from ars3 ([89.246.250.22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbd0747cfsm15328101f8f.109.2024.08.07.02.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 02:17:59 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes In-Reply-To: <CALDnm530v0p=b+29p9p==6kHQ+D1OpRBMZPqsB5BFz3o=vr4NQ@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 7 Aug 2024 09:47:59 +0100") References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> <87frrhxzbz.fsf@HIDDEN> <CALDnm51+-1-ug4Xu1douFOjNVnBgUEE7unWORvsyEvV=UBC9Nw@HIDDEN> <875xscrf1z.fsf@HIDDEN> <CALDnm530v0p=b+29p9p==6kHQ+D1OpRBMZPqsB5BFz3o=vr4NQ@HIDDEN> Date: Wed, 07 Aug 2024 11:17:58 +0200 Message-ID: <87y158pu7t.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, 7 Aug 2024 at 09:47, Jo=C3=A3o T=C3=A1vora wrote: > On Wed, Aug 7, 2024 at 8:02=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN= om> wrote: > >> Sure, but how is that useful information for a language server? > > Fairly useful. If someone tells me this upfront about some stream of > data they're about to send I know I can use a very simple parser. > Or I can reject it altogether if I don't like "lisp" for some reason. > If working on a language server multiplexer, for example > that information is possibly enough to know where to redirect the > didOpen. (That's a tangent, but in practice your multiplexer will be required to know what to do with more specific language ids such as "common-lisp" or "scheme". So I still see no advantage in sending less specific language ids.) >> > 3. Ignoring my advice and sending "plain-tex" from Eglot anyway >> > (i.e. installing your patch without :language-id) >> >> You're clearly against this so it is not going to happen, but I hope I >> managed to explain to you why I would have done it. > > Ultimately, I have to leave room for a pragmatic decision from > domain experts, even if it violates the spec. I'm just trying to > understand the angles and judge the probability of breakage > later on. > >> > For the _other_ orthogonal problem, I suggest: >> > (racket-mode . ("racket" "-l" "racket-langserver")) >> > - ((tex-mode context-mode texinfo-mode bibtex-mode) >> > + ((latex-mode (plain-tex-mode :language-id "tex") tex-mode >> > context-mode texinfo-mode bibtex-mode) >> >> Since you want to send "tex" language id for plain tex, the following >> suffices: >> >> ((latex-mode tex-mode context-mode texinfo-mode bibtex-mode) > > Again, I don't "want" to (see above for the reasons). This patch > is concerned with the orthogonal requirement of keeping tex-mode > (and not removing it as you proposed) > > So: > > * please make up your mind, i.e. make a (possibly overriding) decision > whether sending off-spec "plain-tex" for tex-mode is really what is > needed. > > * whatever your decision, keep 'tex-mode' in the list. > > * help me test the patch below by checking that problem X is now > solved and now new problem Z has popped up. So this is my final suggestion then: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-eglot-server-programs-for-TeX-modes.patch From 22b876a153e8bbede02804e374c5c234213181f2 Mon Sep 17 00:00:00 2001 From: Augusto Stoffel <arstoffel@HIDDEN> Date: Tue, 6 Aug 2024 16:58:06 +0200 Subject: [PATCH] Fix eglot-server-programs for TeX modes * lisp/progmodes/eglot.el (eglot-server-programs): Explicitly list modes derived from tex-mode, so that the correct language id is guessed. --- lisp/progmodes/eglot.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 31948a12d69..67bd26f6f02 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -292,7 +292,7 @@ eglot-server-programs (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs"))) (racket-mode . ("racket" "-l" "racket-langserver")) - ((tex-mode context-mode texinfo-mode bibtex-mode) + ((latex-mode plain-tex-mode context-mode texinfo-mode bibtex-mode tex-mode) . ,(eglot-alternatives '("digestif" "texlab"))) (erlang-mode . ("erlang_ls" "--transport" "stdio")) ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) -- 2.45.2 --=-=-= Content-Type: text/plain It solves problem X and my estimated breakage probability is "infinitesimally small" since it works for LaTeX, BibTeX and ConTeXt and all other dialects are very very fringe. --=-=-=--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 7 Aug 2024 08:49:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 04:49:44 2024 Received: from localhost ([127.0.0.1]:33634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbcMZ-0005XG-N3 for submit <at> debbugs.gnu.org; Wed, 07 Aug 2024 04:49:44 -0400 Received: from mail-oa1-f54.google.com ([209.85.160.54]:52371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sbcMX-0005Wy-HZ for 72343 <at> debbugs.gnu.org; Wed, 07 Aug 2024 04:49:42 -0400 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-2689f74963bso887603fac.0 for <72343 <at> debbugs.gnu.org>; Wed, 07 Aug 2024 01:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723020491; x=1723625291; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r+NfFUA9UQCf9TdfY+/fsZ6+cOnv1fwEAaRJGv1Xuwc=; b=TcFcoTFIdcCvvtjYHJRMrsJo+0XYc0WorHfKYjmZpO+gzAwoprK/aQQF7N3979Bx8w OKJx0oTYVAN3JYnRuThcUxUxdPdYvWKzU1mqfMpJTHWOsWod/Z1pByJJRLshbOwOr7yL lE6NiwoGP2X0E55Trhy5XSqaX9ZjSLiaDUEJGfeBFruX7304y0nJaQrMeqrm98p0ggFi 4qfIdaAHB+2rNo9VLWdgzCIsdO45Omg+gGywSz16Ydk4jY2i7SESPqvn2qY9qm5Nb1V7 eorUaV9g1SLbnvYsuYr0uBMvKFO1DYQO/qt70dh5NQCOJCUzjEQc9zz3Dn35nynM0R6O oKhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723020491; x=1723625291; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r+NfFUA9UQCf9TdfY+/fsZ6+cOnv1fwEAaRJGv1Xuwc=; b=iEc6bCx9EDoIbXAmiKGzQES+ujIUQKb0pCN5r+mZvYXwmW/YfKj7BERvGYNXdIxz+T Ro5vIMoRjZhWlg2zscvtxH1RaBs82h7CAJjqZ/0Jn8nUls4Q+Tar7Fp6ULgCe0b3VmTT FuI7iMGVu7LFKI6aaK4N0rwQfdnmBIMf5+ZFakXLk9tGbDxRv3QZmsVfklqlbGQwM3Zf a1vrrV1zwJ7aCq4pSePUeQIW3LZt69yMP0OCO8I8UytKTwbVTdfOnHr78gORMK2enbjd Ob2PogO11wfsRvUmqtIz2qmWhJvIHr7gjfjjT01Vi/+vSgSYDcgnV7zDIONhl5M8LJPy tBYw== X-Gm-Message-State: AOJu0Yxlmd9F3jYZETRHXkDb9Xp8rgzyf5VPNeBRuFfGL5T7wD0rtkTD 3Q3BA7RXzX4GDRloHQmMWlMTd3+H0S8cga2cYQW/cbobdUh27KwVExQFMq5BfB23+oBI7uK62Xk flCPbdqkvmjcMzM70f+9gHNhN0IU= X-Google-Smtp-Source: AGHT+IH0ZYX/flw/NNpvQdPJy0z8FnhWwPUVazqtIA/RUCZWJSi6k0kbAjdhgw4/Rw0NicdpocXzQL3/ijdKYNbb/1A= X-Received: by 2002:a05:6870:c18b:b0:24c:59f7:e840 with SMTP id 586e51a60fabf-26891ae01e0mr21857257fac.17.1723020490735; Wed, 07 Aug 2024 01:48:10 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> <87frrhxzbz.fsf@HIDDEN> <CALDnm51+-1-ug4Xu1douFOjNVnBgUEE7unWORvsyEvV=UBC9Nw@HIDDEN> <875xscrf1z.fsf@HIDDEN> In-Reply-To: <875xscrf1z.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Wed, 7 Aug 2024 09:47:59 +0100 Message-ID: <CALDnm530v0p=b+29p9p==6kHQ+D1OpRBMZPqsB5BFz3o=vr4NQ@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Wed, Aug 7, 2024 at 8:02=E2=80=AFAM Augusto Stoffel <arstoffel@HIDDEN= > wrote: > Sure, but how is that useful information for a language server? Fairly useful. If someone tells me this upfront about some stream of data they're about to send I know I can use a very simple parser. Or I can reject it altogether if I don't like "lisp" for some reason. If working on a language server multiplexer, for example that information is possibly enough to know where to redirect the didOpen. > Relegating to users the task of debugging language ids doesn't sound > very user-friendly... It was you, not me, who talked about "ultimately the user". So ultimately the user has control over things, always has had. > (For the record, the only thing that's currently broken in the > Eglot-Digestif interaction is the plain TeX case.) Interesting, this is the X problem I was looking for. > > 3. Ignoring my advice and sending "plain-tex" from Eglot anyway > > (i.e. installing your patch without :language-id) > > You're clearly against this so it is not going to happen, but I hope I > managed to explain to you why I would have done it. Ultimately, I have to leave room for a pragmatic decision from domain experts, even if it violates the spec. I'm just trying to understand the angles and judge the probability of breakage later on. > > For the _other_ orthogonal problem, I suggest: > > (racket-mode . ("racket" "-l" "racket-langserver")) > > - ((tex-mode context-mode texinfo-mode bibtex-mode) > > + ((latex-mode (plain-tex-mode :language-id "tex") tex-mode > > context-mode texinfo-mode bibtex-mode) > > Since you want to send "tex" language id for plain tex, the following > suffices: > > ((latex-mode tex-mode context-mode texinfo-mode bibtex-mode) Again, I don't "want" to (see above for the reasons). This patch is concerned with the orthogonal requirement of keeping tex-mode (and not removing it as you proposed) So: * please make up your mind, i.e. make a (possibly overriding) decision whether sending off-spec "plain-tex" for tex-mode is really what is needed. * whatever your decision, keep 'tex-mode' in the list. * help me test the patch below by checking that problem X is now solved and now new problem Z has popped up. > > (defun eglot--guess-contact (&optional interactive) > > I have no opinion on that one, except to say that it looks really > complicated, although that's probably out of necessity. OK, then don't bother giving an opinion, but how can it look complicated?? It removes cyclomatic complexity (and lines of code) from the program. Jo=C3=A3o
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 7 Aug 2024 07:04:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 03:04:09 2024 Received: from localhost ([127.0.0.1]:33554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbaiO-0002BH-DX for submit <at> debbugs.gnu.org; Wed, 07 Aug 2024 03:04:09 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:48336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sbaiL-0002Ae-H7 for 72343 <at> debbugs.gnu.org; Wed, 07 Aug 2024 03:04:06 -0400 Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a7a8caef11fso183760666b.0 for <72343 <at> debbugs.gnu.org>; Wed, 07 Aug 2024 00:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723014155; x=1723618955; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r+hUMWwVSmQSA/5Qkm4i87rKZjiFPZChtVxa11OuicQ=; b=nicd+Syx8yquDeGaMq6yPstNaIcaJM6WQ1bA+bYdAXF5L9k4w3joadAbGGFeZ8VsHD Zk49PE6w8NDGqj0gEIiNKCCP1vZI2D3YBph9n97xqFjbi0XoXYdHjtNMRd6RxY7sD07Q rrBOImlEKLVuQI6aAqzhcqMvSgbRz91lbjjz0UxAAIjUYN3ewkT+vjuMiwecEnYuPaGc R3LIeXczTIGzyI/eE83VHQdeF1tBAeP1oit3+L461MYs63oNsKNoNY9A17CUgg6gXtMC jLS8+poFIRnQPQ4SXEyDh10OPBWgCVBK5pLEwaWnd9Sxf4fV9PnA5FZT61n21EyCMnc6 fPiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723014155; x=1723618955; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r+hUMWwVSmQSA/5Qkm4i87rKZjiFPZChtVxa11OuicQ=; b=EqWor5v+4MY96cBg9E+1S7YriXCtATsTSNE8uoFycituwlRDvM8ViZh/lbUYZe7S+Y OBB6IVLFHXxhVzQCX9TV6RDrrXWyKsH+N4rDwKyN8IRQTqalaUE/WeeCgxGidKeAGn77 rj/iz+3V2GT/l4fED18FZ615BELqTllNpQHukF3us9pS44+GadDqJ/dY6GJc4lCNvYxb /JfZ7vhMwcInpMuxq2woSsDSdgVJ6Tdhe3RHOkL7VYLU2bNxOORpM61MG68NBzY44lJs 4e/4L56/gZY/HPxvIASEzEjQ+1LUTBd9dBFijwXihjefyaUaZFRML/6mZWCmAPA6B+Bn IH/w== X-Gm-Message-State: AOJu0Yy9J+rBrrwJdb0Vagmo8Mb8l35u2kBfbB7VVWPzTQytaNUv0gmE 97vsJcuF1ricpyOiN9DYkZyB/KFBqPJYQrYt9/BeUibaMTuSRggZ X-Google-Smtp-Source: AGHT+IEW43IVyr9setVAc/eYJNBtrMO1AhGCuufubhWmewuxlsSxpV9ltmqoSnf+WhMmMMIaS3ehPA== X-Received: by 2002:a17:907:98e:b0:a7a:847d:63b7 with SMTP id a640c23a62f3a-a7dc51041f3mr1292020266b.59.1723014154398; Wed, 07 Aug 2024 00:02:34 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::e354]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9ec6b07sm604763266b.202.2024.08.07.00.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 00:02:33 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes In-Reply-To: <CALDnm51+-1-ug4Xu1douFOjNVnBgUEE7unWORvsyEvV=UBC9Nw@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 6 Aug 2024 23:52:08 +0100") References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> <87frrhxzbz.fsf@HIDDEN> <CALDnm51+-1-ug4Xu1douFOjNVnBgUEE7unWORvsyEvV=UBC9Nw@HIDDEN> Date: Wed, 07 Aug 2024 09:02:32 +0200 Message-ID: <875xscrf1z.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, 6 Aug 2024 at 23:52, Jo=C3=A3o T=C3=A1vora wrote: > On Tue, Aug 6, 2024 at 7:48PM Augusto Stoffel <arstoffel@HIDDEN> wrote: > >> I know about the list, but unfortunately "tex" as a language id makes no >> sense. It's like saying a program is written in "lisp" without saying >> which Lisp dialect. > > In that example, the "lisp" identifier is probably enough to derive that > the file in question is a tree of Lisp forms, much like lisp-data-mode > treats Lisp. Sure, but how is that useful information for a language server? >> Again, every TeX program belongs to a specific dialect: plain TeX, LaTeX >> and ConTeXt being the main ones. Accordingly, tex-mode is not a real >> major mode; it's just an "abstract base mode" from which the actual TeX >> modes derive (see the docstring for details). > > OK. That doesn't seem to necessitate that the tex-mode is a parent of > latex-mode or plain-tex-mode. [Also, I see no need to write "again" for > a point that you've just made once]. > >> except for the >> caveat that ultimately the user might know better and it's useful to >> rely on the user's choice of major mode / language id. > > How so a "caveat" if eglot-server-programs is a user-customizable > variable where the user can explicitly set whatever languageId she > wants?? Relegating to users the task of debugging language ids doesn't sound very user-friendly... >> I didn't ask but I don't see what could go wrong, given that texlab is >> for latex and bibtex only. > > It would be safer to ask. As far as I am concerned, currently we send > "tex" to texlab and it likes it, or at least doesn't dislike it. Yes, and Digestif is also fine with it. Clearly when seeing the "tex" language id, both servers fall back to "latex", which is by far the most common TeX dialect. (For the record, the only thing that's currently broken in the Eglot-Digestif interaction is the plain TeX case.) > For all we know, or at least, I know. "tex" is in the LSP spec, > "plain-tex" is not. Then I suggest -- for this specific problem: > > 1. Asking for the spec to correct itself Productivity-wise I don't have a very good experience talking to them (even less so than on the Emacs mailing lists...), so I will pass on that one. > 2. Interpreting "tex" as really "plain-tex" in your server. You should > probably be doing that anyway for old Eglot versions or any client > who follows the spec. This would definitely be wrong, since editors (including the current version of Eglot but also others e.g. vim), send out the "tex" language id when they mean "latex". What I _could_ do is to interpret "tex" to mean "some kind of tex" and trigger a heuristic to guess the specific dialect. (This is a TODO-comment since the first versions of Digestif, so the "could" in the previous sentence has a purely hypothetical connotation.) > 3. Ignoring my advice and sending "plain-tex" from Eglot anyway > (i.e. installing your patch without :language-id) You're clearly against this so it is not going to happen, but I hope I managed to explain to you why I would have done it. > For the _other_ orthogonal problem, I suggest: > > 1. Doing the simplification in eglot--lookup-mode, and then make the > left-hand-side list be like > > (latex-mode (plain-tex-mode :language-id "tex") ; see previous problem > also-derived-from-tex-mode > tex-mode > not-derived-from-tex-mode) > > Note that tex-mode is kept there, so this is compatible with any > tex-mode derivations we don't know of. Some testing required, of > course. I can perform some of it for C/C++ modes. > > This patch is after my sig. It also fixes a broken docstring. > > 2. Doing the ranking in eglot--languageID > 3. fixing tex-mode's relation with its children modes > > Jo=C3=A3o > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 5845aff39b7..beff9b17a25 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -292,7 +292,7 @@ eglot-server-programs > (scala-mode . ,(eglot-alternatives > '("metals" "metals-emacs"))) > (racket-mode . ("racket" "-l" "racket-langserver")) > - ((tex-mode context-mode texinfo-mode bibtex-mode) > + ((latex-mode (plain-tex-mode :language-id "tex") tex-mode > context-mode texinfo-mode bibtex-mode) Since you want to send "tex" language id for plain tex, the following suffices: ((latex-mode tex-mode context-mode texinfo-mode bibtex-mode) > . ,(eglot-alternatives '("digestif" "texlab"))) > (erlang-mode . ("erlang_ls" "--transport" "stdio")) > ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) > @@ -1238,28 +1238,23 @@ eglot--lookup-mode > "Lookup `eglot-server-programs' for MODE. > Return (LANGUAGES . CONTACT-PROXY). > > -MANAGED-MODES is a list with MODE as its first element. > -Subsequent elements are other major modes also potentially > -managed by the server that is to manage MODE. > - > -LANGUAGE-IDS is a list of the same length as MANAGED-MODES. Each > -elem is derived from the corresponding mode name, if not > -specified in `eglot-server-programs' (which see). > +LANGUAGES is a list ((MANAGED-MODE . LANGUAGE-ID) ...). MANAGED-MODE is > +a major mode also potentially managed by the server that is to manage > +MODE. LANGUAGE-ID is string identifying the language to the LSP server. > +It's derived from the corresponding mode name, or explicitly specified > +in `eglot-server-programs' (which see). > > CONTACT-PROXY is the value of the corresponding > `eglot-server-programs' entry." > - (cl-flet ((languages (main-mode-sym specs) > - (let* ((res > - (mapcar (jsonrpc-lambda (sym &key language-id > &allow-other-keys) > - (cons sym > - (or language-id > - (or (get sym 'eglot-language-i= d) > - (replace-regexp-in-string > - "\\(?:-ts\\)?-mode$" "" > - (symbol-name sym)))))) > - specs)) > - (head (cl-find main-mode-sym res :key #'car))) > - (cons head (delq head res))))) > + (cl-flet ((languages (specs) > + (mapcar (jsonrpc-lambda (sym &key language-id &allow-other= -keys) > + (cons sym > + (or language-id > + (or (get sym 'eglot-language-id) > + (replace-regexp-in-string > + "\\(?:-ts\\)?-mode$" "" > + (symbol-name sym)))))) > + specs))) > (cl-loop > for (modes . contact) in eglot-server-programs > for specs =3D (mapcar #'eglot--ensure-list > @@ -1268,7 +1263,7 @@ eglot--lookup-mode > thereis (cl-some (lambda (spec) > (cl-destructuring-bind (sym &key > &allow-other-keys) spec > (and (provided-mode-derived-p mode sym) > - (cons (languages sym specs) contact)))) > + (cons (languages specs) contact)))) > specs)))) > > (defun eglot--guess-contact (&optional interactive) I have no opinion on that one, except to say that it looks really complicated, although that's probably out of necessity.
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 7 Aug 2024 06:35:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 02:35:00 2024 Received: from localhost ([127.0.0.1]:33520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbaGB-0001Eq-J2 for submit <at> debbugs.gnu.org; Wed, 07 Aug 2024 02:34:59 -0400 Received: from mail-ej1-f45.google.com ([209.85.218.45]:58717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sbaG9-0001ES-OI for 72343 <at> debbugs.gnu.org; Wed, 07 Aug 2024 02:34:58 -0400 Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a7aac70e30dso156144466b.1 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 23:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723012406; x=1723617206; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MODP91BoR/zeJ48lDe9s7bdV+IotaJpOJJKKsBVHErM=; b=Cs913jlhKJyMyTJJz2+dTCSew+QqhpGCnEX3f/BLJCHckbSDCPzq2MzFJafaxtBHn1 tBVPBTAOoBTnS3gjjKMWldkoSFMgU1Kk91RyIvmD4JdCOGXSNjdj7Sj7Le9Z0utZVs79 izxcYUL052mgDqw2OAcNwqtHqyvV56TQ9WnLdHkXuQOQWVIcpqm+4/0fne7vcbtfwuYd nNi5iWr1myid4QTa6hmkO6RvoeTVR8KtbtKgbPlpKwk/LUjERvyWz+uFUAnDIfLA6+Se RglczKOQR28ZpXzTBsdRoaUSTXSZflQcj4zdG1aCj/RlUV0w5zo3Mp2kgPYjADA/vhIr UVIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723012406; x=1723617206; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MODP91BoR/zeJ48lDe9s7bdV+IotaJpOJJKKsBVHErM=; b=WcZbqdhFuG4EwRg08Mu2KMMW8TKYyNkfKpi8xH6hfDefplJCNNbmXrFEm/RGEg9sEe Ipes0ZUiipi/9ipy9LEdk+D3WOGFTkynAuC80akzjxvLuS6pnEbS9g1ZueO13fSbfFQ7 afGkRKQOv/+QCRE1Q7fjo2ib+Hqz0juL7whReNInXUiPz2mizTjY+5HL91V+1XIdS1f6 h44k2dX4sjG0Qcfhc60WVWiFrRgIGOoZQpwMmAGwrBTAhJ8knGVHx/DmV+CFHp+AqBzz vsOic/50vNyPgDk8Bq8nai2li7qrVkTufX5dptCkeX3W1hk5dM/fryhJUJrlxku7rFgv IUVg== X-Gm-Message-State: AOJu0YxRH84vEzffLHZycbVJJH3xppAcb9szUlgGtN+7XQW4yKpHYsO+ DQEzeU6rK9e4ZAbfEvrAOfG6tPfJbAZNrnIYpD9e8brZ4+tFuHrCquof0A== X-Google-Smtp-Source: AGHT+IHTHLNHoy82R+ZYYM4tMrcYjqi2FVosKQTCuphdq9LKsv46FgkFIAgTN5Xa5nx7USl7RogNbw== X-Received: by 2002:a17:907:9708:b0:a72:aeff:dfed with SMTP id a640c23a62f3a-a7dc5179d4amr1317067966b.53.1723012406196; Tue, 06 Aug 2024 23:33:26 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::e354]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9d89aacsm602658566b.159.2024.08.06.23.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 23:33:25 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes In-Reply-To: <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 6 Aug 2024 19:08:45 +0100") References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> Date: Wed, 07 Aug 2024 08:33:23 +0200 Message-ID: <87bk24rgek.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, 6 Aug 2024 at 19:08, Jo=C3=A3o T=C3=A1vora wrote: > Also earlier you proposed multiple entries in eglot-server-programs, > which would impede this multi-language-per-session feature. So I > figured you wouldn't be familiar with it. By the way, if Eglot relies on that for the multi-language-per-session feature, then such feature would be incompatible with an `eglot-server-program' variable (note the singular) that major modes can set independently as a buffer-local variable. Wouldn't it make more sense to reuse a running server if a new one would be started at the same directory and with the same command line arguments?
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 6 Aug 2024 22:53:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 18:53:53 2024 Received: from localhost ([127.0.0.1]:33164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbT3w-0004u5-NU for submit <at> debbugs.gnu.org; Tue, 06 Aug 2024 18:53:53 -0400 Received: from mail-oa1-f51.google.com ([209.85.160.51]:55581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sbT3t-0004tp-W0 for 72343 <at> debbugs.gnu.org; Tue, 06 Aug 2024 18:53:51 -0400 Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-264545214efso729657fac.3 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 15:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722984740; x=1723589540; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FxYxDeVmfNMeZGwEpXxID4QCWMxaOKnmPtgY7rGvIkw=; b=m2WxZTJRqToNrLxSW9ey35xkNOS+eALuUxHqOFYHnM82esws4sevQl3tJ2Qk3srqyV Hbnz8ES39uIkAhSc4pF1rtDiTSsP9F4U858XjrU3j1btDfYmu6kgG3utKj9VAzezf4yI s8eQoWskfSoSHxSQ7Otqvn0WVbmzkDYwoOvCLC+R0DkFOsz2UigOzbPmrg+qHNOaC+QP iSHZp89Yt9/pIOoX3cRWbUeiLLb54LCtlopH0i342kFJXauQwO7/vRQFF9x6HrmdcXdf bsJkWebQbCBgylRyEMN7KgYQtC1QqCgvitFz/Ee369uLw1fzD7noeVWq/dU+GTXSP8/7 mKWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722984740; x=1723589540; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FxYxDeVmfNMeZGwEpXxID4QCWMxaOKnmPtgY7rGvIkw=; b=tiV4EpyqFFIUhyYkbUzo5gxqVmETXQv9aZnXreKB4rAeCMPaof5SozeImSKjaoyuWi r5KtnNJGpFU18vx0wGcdDtB5wCerUoYOnnVqljWj12AuaN3zYb7sBnYijtm56qwzFtNj rlfPHXm510kN4CYJSCXebEBG0UtLIFujJI4hec6aWgfZgYdXFwawi8DgOYk9I5NA7WQu 9KI8z9BEOhRq+C5ntOT0FsUChC8AYNBl4SFUVq04GY1VOWXUIj2cLbOeflNd3+V7mIr+ eRbHw6UW0V+ZSpDY3El0yydB5pBXPtaAi/DrAhzYXS9qpe52ETj/vuBYVwoQzM4/QGmB 9wAQ== X-Gm-Message-State: AOJu0Yw4GK2ptGcwhD8+4AfbWGqf43VlZ78BDJxCn5QgxaYKQyoEALn7 ogW/1Y1v1ZGwEb5dgApuuUioVl/RQBjoGY+ecib7SGCE3F+ibi6ps1Igng0sjK2mU9EWWshMV7/ nAXvQbmwtl4dPB1lNvpOJQ+8mCdY= X-Google-Smtp-Source: AGHT+IHC9qv9IjvagpdguyiOzQKiexlwcrQlFIzt70roc1b0MKw2rg6saYz4rGVIT2c819uxUntDgxpEqYvvmvxzqSU= X-Received: by 2002:a05:6870:961a:b0:25d:ff4c:bc64 with SMTP id 586e51a60fabf-26891a7f60fmr18208856fac.6.1722984739846; Tue, 06 Aug 2024 15:52:19 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> <87frrhxzbz.fsf@HIDDEN> In-Reply-To: <87frrhxzbz.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Tue, 6 Aug 2024 23:52:08 +0100 Message-ID: <CALDnm51+-1-ug4Xu1douFOjNVnBgUEE7unWORvsyEvV=UBC9Nw@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, Aug 6, 2024 at 7:48PM Augusto Stoffel <arstoffel@HIDDEN> wrote: > I know about the list, but unfortunately "tex" as a language id makes no > sense. It's like saying a program is written in "lisp" without saying > which Lisp dialect. In that example, the "lisp" identifier is probably enough to derive that the file in question is a tree of Lisp forms, much like lisp-data-mode treats Lisp. > Again, every TeX program belongs to a specific dialect: plain TeX, LaTeX > and ConTeXt being the main ones. Accordingly, tex-mode is not a real > major mode; it's just an "abstract base mode" from which the actual TeX > modes derive (see the docstring for details). OK. That doesn't seem to necessitate that the tex-mode is a parent of latex-mode or plain-tex-mode. [Also, I see no need to write "again" for a point that you've just made once]. > except for the > caveat that ultimately the user might know better and it's useful to > rely on the user's choice of major mode / language id. How so a "caveat" if eglot-server-programs is a user-customizable variable where the user can explicitly set whatever languageId she wants?? > I didn't ask but I don't see what could go wrong, given that texlab is > for latex and bibtex only. It would be safer to ask. As far as I am concerned, currently we send "tex" to texlab and it likes it, or at least doesn't dislike it. For all we know, or at least, I know. "tex" is in the LSP spec, "plain-tex" is not. Then I suggest -- for this specific problem: 1. Asking for the spec to correct itself 2. Interpreting "tex" as really "plain-tex" in your server. You should probably be doing that anyway for old Eglot versions or any client who follows the spec. 3. Ignoring my advice and sending "plain-tex" from Eglot anyway (i.e. installing your patch without :language-id) For the _other_ orthogonal problem, I suggest: 1. Doing the simplification in eglot--lookup-mode, and then make the left-hand-side list be like (latex-mode (plain-tex-mode :language-id "tex") ; see previous problem also-derived-from-tex-mode tex-mode not-derived-from-tex-mode) Note that tex-mode is kept there, so this is compatible with any tex-mode derivations we don't know of. Some testing required, of course. I can perform some of it for C/C++ modes. This patch is after my sig. It also fixes a broken docstring. 2. Doing the ranking in eglot--languageID 3. fixing tex-mode's relation with its children modes Jo=C3=A3o diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 5845aff39b7..beff9b17a25 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -292,7 +292,7 @@ eglot-server-programs (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs"))) (racket-mode . ("racket" "-l" "racket-langserver")) - ((tex-mode context-mode texinfo-mode bibtex-mode) + ((latex-mode (plain-tex-mode :language-id "tex") tex-mode context-mode texinfo-mode bibtex-mode) . ,(eglot-alternatives '("digestif" "texlab"))) (erlang-mode . ("erlang_ls" "--transport" "stdio")) ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) @@ -1238,28 +1238,23 @@ eglot--lookup-mode "Lookup `eglot-server-programs' for MODE. Return (LANGUAGES . CONTACT-PROXY). -MANAGED-MODES is a list with MODE as its first element. -Subsequent elements are other major modes also potentially -managed by the server that is to manage MODE. - -LANGUAGE-IDS is a list of the same length as MANAGED-MODES. Each -elem is derived from the corresponding mode name, if not -specified in `eglot-server-programs' (which see). +LANGUAGES is a list ((MANAGED-MODE . LANGUAGE-ID) ...). MANAGED-MODE is +a major mode also potentially managed by the server that is to manage +MODE. LANGUAGE-ID is string identifying the language to the LSP server. +It's derived from the corresponding mode name, or explicitly specified +in `eglot-server-programs' (which see). CONTACT-PROXY is the value of the corresponding `eglot-server-programs' entry." - (cl-flet ((languages (main-mode-sym specs) - (let* ((res - (mapcar (jsonrpc-lambda (sym &key language-id &allow-other-keys) - (cons sym - (or language-id - (or (get sym 'eglot-language-id) - (replace-regexp-in-string - "\\(?:-ts\\)?-mode$" "" - (symbol-name sym)))))) - specs)) - (head (cl-find main-mode-sym res :key #'car))) - (cons head (delq head res))))) + (cl-flet ((languages (specs) + (mapcar (jsonrpc-lambda (sym &key language-id &allow-other-k= eys) + (cons sym + (or language-id + (or (get sym 'eglot-language-id) + (replace-regexp-in-string + "\\(?:-ts\\)?-mode$" "" + (symbol-name sym)))))) + specs))) (cl-loop for (modes . contact) in eglot-server-programs for specs =3D (mapcar #'eglot--ensure-list @@ -1268,7 +1263,7 @@ eglot--lookup-mode thereis (cl-some (lambda (spec) (cl-destructuring-bind (sym &key &allow-other-keys) spec (and (provided-mode-derived-p mode sym) - (cons (languages sym specs) contact)))) + (cons (languages specs) contact)))) specs)))) (defun eglot--guess-contact (&optional interactive)
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 6 Aug 2024 18:49:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 14:49:38 2024 Received: from localhost ([127.0.0.1]:33053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbPFZ-0006Zt-Pv for submit <at> debbugs.gnu.org; Tue, 06 Aug 2024 14:49:38 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:61537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sbPFV-0006Zd-Ie for 72343 <at> debbugs.gnu.org; Tue, 06 Aug 2024 14:49:36 -0400 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5b391c8abd7so1120402a12.2 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 11:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722970083; x=1723574883; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9TjRZzbBop9SsNvUSX2VCeRWzrduAE82vmcccc08OM0=; b=H4JCYflDaWhxdocJBJNTtIXTAHRKCDg8Ac7toEHUPdyX2OaUDd9VKhIYEOw00CfX2W Byd2kLe1IxSPViukvjtef/9qJUPVKZWuHbTywP8yKiTBiPYoSjMI1WvdCSeJsYaiBcJp aFCZ7E7X4UydtsjasOTOHIyPB7QJ7G+9znW71w4lS0gqt3VAKaKg3BQImSB2f7hK3Vnj mDUIWQ433i1W8E3r2deXB+EC8LaIA3l1BMbaYjjfr9gdp+3qN/1V5pvloJvFHaTigJLt Zw2f2dKXlVq6dGHIkrxJvFL2F56fwI/I7MCcA54TzZe2VGt9geThZsHUsKHx93nBpW9/ zs0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722970083; x=1723574883; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9TjRZzbBop9SsNvUSX2VCeRWzrduAE82vmcccc08OM0=; b=agc2xcEHA7AUssabzoc/Z2HaCVo4GGYvm8E6FcNBeX11+ebU9A8SepSV7aIf3lfTzD +2JAnV5Pnqp+0fi5Id25RaHOlL/Xgbpw0lo/Qr8cEpz7uV/b1vHZ/nCqKNY5CfafZ72X DG8OUxceDES/lcmW0a8eAVGkrFe5wgbh5kg53kvK5rLXsWDEO5ILmfkh6hajGJhM8DU2 wW4wXlDhj9sVKiOcKyKt4StxpSpoD5rAar6cNGyNCjhkODsFnhv145u433cmMMTY/2L7 ozWmCdpON4I+yyAZbI/o1G+p/0xYjJ6aQttE+3Gai1wdj83RP/97gFORo7bLm7+Hzmr9 Qllw== X-Gm-Message-State: AOJu0YzdtsCpfQB7UHM9hQFRfS2whS9Q5Spuh9/Udrbqdc2Fq21562/p PbuV98MIcqQh30RsBY6ISKHKOZsOUGUmBSUOO3vPVWz2khUzj2pX X-Google-Smtp-Source: AGHT+IG+01I6wFX2eajClRMRPcMP5KmbLIMll3udgRSesJqQCx6ir5w0br+scji7jjM9YT9eNbVV1g== X-Received: by 2002:a05:6402:22d0:b0:5b9:3846:8bae with SMTP id 4fb4d7f45d1cf-5b93846941bmr8331575a12.15.1722970083064; Tue, 06 Aug 2024 11:48:03 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::e354]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b83960f2fdsm6219205a12.7.2024.08.06.11.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 11:48:02 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes In-Reply-To: <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 6 Aug 2024 19:08:45 +0100") References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> Date: Tue, 06 Aug 2024 20:48:00 +0200 Message-ID: <87frrhxzbz.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, 6 Aug 2024 at 19:08, Jo=C3=A3o T=C3=A1vora wrote: > On Tue, Aug 6, 2024 at 5:38 PM Augusto Stoffel <arstoffel@HIDDEN> wrot= e: > >> > So there's no "single pick" in general. >> You don't need to explain that to me ;-). > > It is you who alluded to a single pick, so I thought I had to. Also > earlier you proposed multiple entries in eglot-server-programs, which > would impede this multi-language-per-session feature.> So I figured you > wouldn't be familiar with it. Fair enough. >> What I want to achieve (or, if I may, what Eglot should do) in case it >> wasn't clear yet, is: file x.tex is sent language id "latex" and file >> y.tex is sent language id "plain-tex". > > Indeed it wasn't clear, so I'm very glad I asked. I don't see > "plain-tex" in the list over at > > https://microsoft.github.io/language-server-protocol/specifications/lsp= /3.17/specification/ > > I just see "tex" and "latex" and "bibtex". I know about the list, but unfortunately "tex" as a language id makes no sense. It's like saying a program is written in "lisp" without saying which Lisp dialect. > But it won't for many other cases. The fact that Emacs models > latex-mode as a descendent of tex-mode is something Eglot can't do > anything about. It means that Emacs thinks that that every LaTex > program is a TeX program at least at some syntactic level (is this true? > no idea). Again, every TeX program belongs to a specific dialect: plain TeX, LaTeX and ConTeXt being the main ones. Accordingly, tex-mode is not a real major mode; it's just an "abstract base mode" from which the actual TeX modes derive (see the docstring for details). > I do think that's the lesser of two evils though. So anyway this is my > suggestion: > > @@ -292,7 +292,7 @@ eglot-server-programs > (scala-mode . ,(eglot-alternatives > '("metals" "metals-emacs"))) > (racket-mode . ("racket" "-l" "racket-langserver")) > - ((tex-mode context-mode texinfo-mode bibtex-mode) > + ((latex-mode (plain-tex-mode :language-id "tex") context-mode > texinfo-mode bibtex-mode) > . ,(eglot-alternatives '("digestif" "texlab"))) > (erlang-mode . ("erlang_ls" "--transport" "stdio")) > ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) So again, for the reason above, I wouldn't do what you suggest here. > In theory, this could also be fixed by keeping tex-mode in there, and > then adjusting Eglot's heuristic, by ranking the potential ancestors and > selecting the closest one, in 'eglot--languageId'. Could be tricky or > could be easy, feel free to give it a shot. (The status quo is already way too complicated, and this doesn't sound like an improvement in that regard...) > Yet another idea is to not reorder modes at all in 'eglot--lookup-mode' > and use an explicit order to express this ranking. I admit I don't > remember what the reordering idea (main-mode-sym is the local var name) > is for. it couldprecede the multiple-language-ids feature. Or it could > be essential for some other thing: testing would be needed. > >> This doesn't matter, as it's an Eglot issue. Any TeX server will do. > > This is not established, at least not yet. You are requesting for a > "plain-tex" LSP languageId property to be sent and that is outside the > spec as far as I can tell from reading the spec. Maybe your digestif > server supports and likes it, though. But it might break "texlab" for > all I know. Note also that the LSP spec says nothing about ConTeXt or Texinfo. Moreover, texlab only supports latex and bibtex. > Even the fact that "tex" is all that's being sent at the > moment may or may not be a bug -- only LaTex/Tex specialists can say > that. And certainly a capable enough language server, which is tasked > with analysing a file syntactically, can do much the same as our own > tex-mode.el and figure out the correct language from the contents. > Might do it better than Emacs. That's true, and in fact it's true all languages. So a server could as well ignore the language id and deduce it on its own -- except for the caveat that ultimately the user might know better and it's useful to rely on the user's choice of major mode / language id. > That said, if you really want to send "plain-tex", then there are two > options. You can change your user value of eglot-server-programs, > obviously. Or you can confirm with "texlab" that they don't mind, in > which case -- but only in that case -- your latest patch is acceptable. I didn't ask but I don't see what could go wrong, given that texlab is for latex and bibtex only.
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 6 Aug 2024 18:10:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 14:10:30 2024 Received: from localhost ([127.0.0.1]:33015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbOdh-0005aQ-Lt for submit <at> debbugs.gnu.org; Tue, 06 Aug 2024 14:10:30 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:58720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sbOde-0005a9-F4 for 72343 <at> debbugs.gnu.org; Tue, 06 Aug 2024 14:10:28 -0400 Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3db19caec60so530806b6e.1 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 11:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722967736; x=1723572536; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=n0IeHWRqWSZihnn7NsZ9IzjJcsRI5LTfbwBgGAL+xvk=; b=RIKV+BBE1JOppxGAg8mKsoyG8InkZF2S0UHrs33fI7qC+V8fD+t2z3GrqS6vspyMT/ e2ZSFar40pAA2ABV4CBXszudMvCUWh+F9E1vmaLGOpShYviE8KUe30AKXSA1PyCldZTr NhK2YoEP+SWtwIf6Uwnc0igvP9ge521tr72yPYDfeZN/bwVRKQLsdbyGGh1Qr1MKt7rN 5weIAxO0OOjcs8YBCtvFojU2IaxwOB24JTDyp7sKTz3ZPQ4Jb7k8Pjvn/0ZQr/lnfhFT 1ohGBIJTLCiGsI3zqC99Xba6BIjV+cbAVnc0a/LD7XGQh7cu6Rb1tawOYV3WvdBsmHAh Kpjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722967736; x=1723572536; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n0IeHWRqWSZihnn7NsZ9IzjJcsRI5LTfbwBgGAL+xvk=; b=bc236bcLB+9k0FcYN6SqM8eRxuPqSI9Ipxr9sYbFCQg7EIJUqB3bqsNZ8ikb5pLRtB T/+HEoMKM/nZuEiM9dTws7bS+afH24ls9U78/iNyUtUI62PoKk3IDNtjeMS01cce9UhB CdyFJlVDHZ++hQWa9in2xfTb9InIMrhNeRK1ntgjvkjs6oSCtNEkVHFcnoXd5i3P56An ks3wA/CAlKRsgXvoYZvCWWv+Wh7MxbBlDByoyrLRX0XmkrQeqYhvTHlVBKidvwuNt7TW /Y1LErZankhuf7w18NXC1SccUYoYTVZedgZAdciRPsEXaHURznAtaQcht/T3gVhQK9uC bqiA== X-Gm-Message-State: AOJu0Yx9mFrwHEPLpTGbGYVwqcDytju8bKgHtbUeuIUKg7fKxc8pfnVn KwCTkDSVAppNOy0/WEh47QbYN/0O4vF7y/BlM9rlDantqBwHl3dSk3Y+Syq4GAdBxJRNZ92S62N hSO9fXjSMhGUkDku+29TkwivvlhU= X-Google-Smtp-Source: AGHT+IGkPt8/4g4nuBd+GPrhpxwaiUIraEHSV8WaCifcuAyyeUMcPGOqzRLakjcBCJIEcgb2+i86aWRiZueSNbDg4Eg= X-Received: by 2002:a05:6871:62c1:b0:25a:eca3:6b59 with SMTP id 586e51a60fabf-26891e685e8mr19641695fac.40.1722967736473; Tue, 06 Aug 2024 11:08:56 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> <87ed71fvy8.fsf@HIDDEN> In-Reply-To: <87ed71fvy8.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Tue, 6 Aug 2024 19:08:45 +0100 Message-ID: <CALDnm53BHitCAu+p_=d4Ue9H7acVEWJ1ddPkTi3YyZqgnkQK=Q@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, Aug 6, 2024 at 5:38 PM Augusto Stoffel <arstoffel@HIDDEN> wrote: > > So there's no "single pick" in general. > You don't need to explain that to me ;-). It is you who alluded to a single pick, so I thought I had to. Also earlier you proposed multiple entries in eglot-server-programs, which would impede this multi-language-per-session feature. So I figured you wouldn't be familiar with it. > What I want to achieve (or, if I may, what Eglot should do) in case it > wasn't clear yet, is: file x.tex is sent language id "latex" and file > y.tex is sent language id "plain-tex". Indeed it wasn't clear, so I'm very glad I asked. I don't see "plain-tex" in the list over at https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/ I just see "tex" and "latex" and "bibtex". Now, if you want "latex" to be sent for x.tex (in latex-mode) and "tex" to be sent for x.tex (in plain-tex-mode), there is this possibility. diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 5845aff39b7..2695aa93ffe 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -292,7 +292,7 @@ eglot-server-programs (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs"))) (racket-mode . ("racket" "-l" "racket-langserver")) - ((tex-mode context-mode texinfo-mode bibtex-mode) + ((latex-mode tex-mode context-mode texinfo-mode bibtex-mode) . ,(eglot-alternatives '("digestif" "texlab"))) (erlang-mode . ("erlang_ls" "--transport" "stdio")) ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) No need to mention plain-tex-mode at all. The "guess" logic will work (though I still recommend :language-id cookie). You might notice this will only work for a particular sequence of invocations (specifically starting the server with the latex-mode file open, then opening other files in plain-tex-mode). But it won't for many other cases. The fact that Emacs models latex-mode as a descendent of tex-mode is something Eglot can't do anything about. It means that Emacs thinks that that every LaTex program is a TeX program at least at some syntactic level (is this true? no idea). So as soon as you have the two files open, M-x eglot-reconnect will send "tex" for _both_. Which, according to Emacs's view of the world, isn't wrong. This has happened before with the js/json mode and has been fixed in the mode relations. I think bug#67463. The same idea thatfixed it there could be applied here. Anyway, if plain-tex-mode is an attempt to fix this, by making a core mode that is not directly related to latex-mode, then I think it should appear in the list, but then :language-id set to to "tex". But I see plain-tex-mode also inherits from tex-mode, so the fundamental problem remains. Unless you remove tex-mode from the list (which is what you did). But then outside descendents of tex-mode would be cut off, which is what I warned about. I do think that's the lesser of two evils though. So anyway this is my suggestion: @@ -292,7 +292,7 @@ eglot-server-programs (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs"))) (racket-mode . ("racket" "-l" "racket-langserver")) - ((tex-mode context-mode texinfo-mode bibtex-mode) + ((latex-mode (plain-tex-mode :language-id "tex") context-mode texinfo-mode bibtex-mode) . ,(eglot-alternatives '("digestif" "texlab"))) (erlang-mode . ("erlang_ls" "--transport" "stdio")) ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) In theory, this could also be fixed by keeping tex-mode in there, and then adjusting Eglot's heuristic, by ranking the potential ancestors and selecting the closest one, in 'eglot--languageId'. Could be tricky or could be easy, feel free to give it a shot. Yet another idea is to not reorder modes at all in 'eglot--lookup-mode' and use an explicit order to express this ranking. I admit I don't remember what the reordering idea (main-mode-sym is the local var name) is for. it couldprecede the multiple-language-ids feature. Or it could be essential for some other thing: testing would be needed. > This doesn't matter, as it's an Eglot issue. Any TeX server will do. This is not established, at least not yet. You are requesting for a "plain-tex" LSP languageId property to be sent and that is outside the spec as far as I can tell from reading the spec. Maybe your digestif server supports and likes it, though. But it might break "texlab" for all I know. Even the fact that "tex" is all that's being sent at the moment may or may not be a bug -- only LaTex/Tex specialists can say that. And certainly a capable enough language server, which is tasked with analysing a file syntactically, can do much the same as our own tex-mode.el and figure out the correct language from the contents. Might do it better than Emacs. That said, if you really want to send "plain-tex", then there are two options. You can change your user value of eglot-server-programs, obviously. Or you can confirm with "texlab" that they don't mind, in which case -- but only in that case -- your latest patch is acceptable.
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 6 Aug 2024 16:39:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 12:39:59 2024 Received: from localhost ([127.0.0.1]:32964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbNE7-0003Hf-3I for submit <at> debbugs.gnu.org; Tue, 06 Aug 2024 12:39:59 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:51660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sbNE3-0003HO-SO for 72343 <at> debbugs.gnu.org; Tue, 06 Aug 2024 12:39:56 -0400 Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52f025bc147so1207340e87.3 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 09:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722962305; x=1723567105; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rx4OKUTCjV7JZheqArWvRuXoV1yoRN+D8HgufXE59ww=; b=kRftiIYbwwOjoaU59K76G/w7wX/Y4oLjfpAbNhjy+NO+M5PhklMBMsqM9sno96sqYh BOy7+Tq3MyZTNkB1LGqZWEAyzn8QQbzAZdwi8yoQCSRPHuaw5ZWt1mFOMDNErFT8wqlD Vxptn4MML2UJTS6mI0N2ZroTdrJKQ7qqoybmvLjZgrLWDGoPsw9b79zHQzEgILPDUyia SHrgKXaXmNU8rU8+y5W9H+aKNqQxryR0g6yKm1N41ravQrkJh2oxibY/99FY7rK8ERSe li5+ZvA3I5+E9TZw9mXAQN4Mvb639TKUJLAA23ixTws/gJvszGZrXUxCpLyW+zdQxybX PHxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722962305; x=1723567105; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rx4OKUTCjV7JZheqArWvRuXoV1yoRN+D8HgufXE59ww=; b=du241aWwTw0dkhF1dLNo+SFKSq4UQ2YwC5FF3lwgIXIp0VaXnPtMWN1MQA0rSVRXkV fSg+XnsIOQcFMuSePLPHUxirvYt1skyFP59stBikvS4lunCS6Ktv3N5QaD3BLmipd9jB edihUD3kzVhovzbzRl2aEsISdwYppDrS0XjViTAHhyzpzu2Dn/AQnd7sy1iYrkA4seru KAXNER0mAdq5oQWpq0Y26S4UwfwW2IubHLTqbOYRdbR0APGK+X8Osf0zADw8aPmQDNvz 8l0dsx9jEPhS5+Im+v/reeQa6e/RlZ7eFGQ6K2ltkUUGE+I6vt+tjBNk+rZxhXEr8xW0 pGZg== X-Gm-Message-State: AOJu0YxEzo/sh8T4jZ40MX2KAeZ3tLOvG3OPnYS3hZV1YMS/a/c6dQP1 5LOMPqzRxDdLibXcusIM6kruxlUl++gkA7xCqaU/s5tsluXGVupE X-Google-Smtp-Source: AGHT+IGXp7lTZT6fFHMu5zndfWwAi3ZWPvhMPXe2EfvTk+bX0hnoQDo1OxKtLkQ4L6+iDVXqDf5qtQ== X-Received: by 2002:a05:6512:2247:b0:52c:e4cf:4f31 with SMTP id 2adb3069b0e04-530bb39b6bemr11230368e87.49.1722962304963; Tue, 06 Aug 2024 09:38:24 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::e354]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b83960f313sm6111460a12.17.2024.08.06.09.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 09:38:24 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes In-Reply-To: <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 6 Aug 2024 17:27:28 +0100") References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> Date: Tue, 06 Aug 2024 18:38:23 +0200 Message-ID: <87ed71fvy8.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, 6 Aug 2024 at 17:27, Jo=C3=A3o T=C3=A1vora wrote: > Eglot pairs language ids with modes (plural). This is what the internal > function eglot--lookup does. In the same session, multiple language-id > maybe be picked depending on the LSP document being "opened". > So there's no "single pick" in general. You don't need to explain that to me ;-). > Previously, you suggested :language-id would work, but you didn't > want to "dabble" with it. Now you seem to be saying it can't work > at all. You're right. > This may be an "XY Problem". Can you state what exactly is the end > result you're trying to achieve (short of "writing thesis" or "fulfill > life goals") as someone who has never seen Eglot source code before or > has looked at LSP event logs to check what is being sent. I don't think there's an XY problem here, but anyway: > Tell me which server is installed This doesn't matter, as it's an Eglot issue. Any TeX server will do. > and what file(s) in which major modes you are visiting just before > typing `M-x eglot`. File x.tex in latex-mode and file y.tex in plain-tex-mode. > Then tell me what happens to said server invocation (if any). Currently, file x.tex is sent language id "tex" and file y.tex is sent language id "tex". > Focusing on the goal rather than the means may help me understand what > you want to achieve. What I want to achieve (or, if I may, what Eglot should do) in case it wasn't clear yet, is: file x.tex is sent language id "latex" and file y.tex is sent language id "plain-tex".
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 6 Aug 2024 16:29:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 12:29:11 2024 Received: from localhost ([127.0.0.1]:32951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbN3f-0002zI-1G for submit <at> debbugs.gnu.org; Tue, 06 Aug 2024 12:29:11 -0400 Received: from mail-oa1-f43.google.com ([209.85.160.43]:47429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sbN3d-0002yz-RF for 72343 <at> debbugs.gnu.org; Tue, 06 Aug 2024 12:29:10 -0400 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-2689e7a941fso585203fac.3 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 09:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722961660; x=1723566460; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5YMi/e0y4UW1wDU5cPjaYuKTUPVIZ4Q8iCkElUJrK0w=; b=hZNghLnyUJp00+yPu0WzzIyqo/an6V+Miu6+y7fmFc9IvkWAcvCf5T8zxOCXrtfg17 FOIlEzwiizi/ZITQI/GNMFSy/t6XndYN2up7cHzVib70dcoLyM7LHLVY4UwcV8q8pXF1 ikW4RxJLOk40fROsYv8ThvxpeOvUMKYxxIgbLk01o1kNpCGSTs+R3j4OAfRttgHYWgrX jDwJX48FXrKS8bPW7kHi0ozd8lN7Xq8SCLmq9oOKuLlZdAMloedrzv6e2HSQZ2W0EoC8 EYVltmjWdSlAaEeTIVemQeRr6M1Sp4g1/2wBbfdEMeFuQ0Hpua4C8Cf+A1GwqZ6cotLr 2mIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722961660; x=1723566460; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5YMi/e0y4UW1wDU5cPjaYuKTUPVIZ4Q8iCkElUJrK0w=; b=GQEHfRHZ37Nk4zHx14+krVLad8NPgLGHoPm5nyVaxkYzr479VAsE/ciTjdqBSBWUjk EbeWsjmkp9zGI3uO9usX9egoMNjj38gIEh3XIXeQfNVrQuIGbagnp3P+hfdEY9JAfhpw h5AbcN9P9LFD29FGQRkcT4kTS1iT1RW55W3JhuUqVvXCxBAvNdXEs7I09CKAN6oO9Z/7 OyxnY8rFv13i1hB5hiAkim7+VHjMAHgp8QbcOrU3BhpYxRNO5Mzk3GmfRLBGsZLT4Szz sh4WUIF/BB6uNMVE6/s5z2McHKtOI/W/aK0XuFV2HnqNbzf72o4V5JnPWgpFFBzESf8n dQJw== X-Gm-Message-State: AOJu0YwUW8uetqSrCFyr51bNb6A9D3EpqpYE6Ghwnh+95aJIg/N5Y5mN 0RAvORhLvqxXqjCb95EYKn9VOsBXlrGfpMf799VALO4guSIOrCCdpjYGpd7iiydOSL81IaaNRqc J/IT5UORCwbUOJ1W9Vmk8uSFKQro= X-Google-Smtp-Source: AGHT+IEneo1/BDO2eTTBKsqF120RRV0BFFBRVlX3hu+BdeNUgz+pSbtS8kbiMPTmeRs71m5gDJ4avdUon9U8NaugG1I= X-Received: by 2002:a05:6870:970c:b0:261:236c:2bb8 with SMTP id 586e51a60fabf-26891d1f9ddmr20740417fac.12.1722961660002; Tue, 06 Aug 2024 09:27:40 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> In-Reply-To: <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Tue, 6 Aug 2024 17:27:28 +0100 Message-ID: <CALDnm50cmpKfr+n-f+QmUzkO6B91xA7+LRdVF4g1D6F7PRH7Yw@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, Aug 6, 2024 at 4:45=E2=80=AFPM Augusto Stoffel <arstoffel@HIDDEN= > wrote: > > On Tue, Aug 6, 2024, 17:34 Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> w= rote: >> >> * lisp/progmodes/eglot.el (eglot-server-programs): Explicitly list modes >> derived from tex-mode, so that the correct language id is guessed. >> >> Won't it break when another mode is derived from it? > Not really, since such a hypothetical mode has no support from the server= s. No but it might represent a language that does! servers don't care modes, they know about languages. Furthermore, the same server, even the same server connection might serve multiple documents in multiple different languages. > That doesn't work, because apparently Eglot picks the language id Eglot pairs language ids with modes (plural). This is what the internal function eglot--lookup does. In the same session, multiple language-id maybe be picked depending on the LSP document being "opened". So there's no "single pick" in general. > of the first mode in the listing that applies, which previously was the g= eneric tex-mode. That doesn't allow distinguishing latex and plain TeX. Aga= in, the issue is not guessing the language id string from the mode name, bu= t rather choosing the right mode symbol to guess from. Previously, you suggested :language-id would work, but you didn't want to "dabble" with it. Now you seem to be saying it can't work at all. This may be an "XY Problem". Can you state what exactly is the end result you're trying to achieve (short of "writing thesis" or "fulfill life goals") as someone who has never seen Eglot source code before or has looked at LSP event logs to check what is being sent. Tell me which server is installed and what file(s) in which major modes you are visiting just before typing `M-x eglot`. Then tell me what happens to said server invocation (if any). Focusing on the goal rather than the means may help me understand what you want to achieve. Thanks
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 6 Aug 2024 15:46:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 11:46:52 2024 Received: from localhost ([127.0.0.1]:32921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbMOh-0001lt-NR for submit <at> debbugs.gnu.org; Tue, 06 Aug 2024 11:46:52 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:60716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sbMOe-0001lX-Ss for 72343 <at> debbugs.gnu.org; Tue, 06 Aug 2024 11:46:50 -0400 Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1fb3b7d0d56so4853955ad.1 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 08:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722959119; x=1723563919; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dRr3HGmT0bm8YPLOr9GICYiHxBuwhry029ylGFExanc=; b=UeS0OWXbFmN+guB2C8wHDMlhOffJJlEPBbVdviMC92AyvxgnzSakV1D7cUPKJFVyR9 aiqhhaj7t0xmEvEi2QJX2G3z5622COX4oZle9QrSny1/h0vEnFvI8HT4iGFjEf9DXtLx qnXmTZTq9QHaabuA98xOBn8MGQJsPvsphqwYJhlb3tVZz2F0bB1ZW92kxw9DoFg+mQaq WBQAlDzzbfJNAHLKf1zm96tHbk1w/ZxnOutP0wRViQpxicePlzA0d+qtQTI2tRNVh7vH os6g/sghNQkNnfMpZ17sy3C/Fx2/hf6bcQ9MKeQjZP8REtf6JmM8flqLYNOuhC1D/iXu Jr8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722959119; x=1723563919; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dRr3HGmT0bm8YPLOr9GICYiHxBuwhry029ylGFExanc=; b=fB3QmR60p01tqvDYzk0FfKMLSJXTRbOIdxCkGK2R2hRBK5PwT1ikrzVQKM0a9fouaR bSZ2FyEagWspKeRFn67DDBD+l+dRhNro50JEGcDLZqcsxbvTwwJ5egiqZbFZ2JAb3Hos +VQmSwbAgx8qHetKufJoZz56NnQ5he3SldLv8IXKs0zqwE9TyYAjfVVfDiXW7oc44G2n /MHIjfMNhLa9zB07+LynjHWIqHh4x1jO+voHq52Eno5tFcUeDnF5ko1ptjbCf89BQvce 2PyATxi05J+IMb+gQksdeUMvWHBvpTg/gDDS6LffWGccJdPWncW54r0z7lUTnZLGTh/a JIYw== X-Gm-Message-State: AOJu0YyocUVMEv/YUn7x9JhZehzLnFexERsgHkNP6JfSEUmeoNKMpXP4 UwaYt2yQKWpJZn2byNyvesaD2bcsjDuu47WMwGXYjIsfuSKAEufGQ7HmEbTy9C2aP5mNfcribEs spmMWnHKMdAOKWvXQGlNg31SUdxk= X-Google-Smtp-Source: AGHT+IHXalcxlZU17GLtk11X635TGJOcmfPOKjr1QbCEaABKllOpmuCNvjMEyiaZE/tIQMRm2eAtb/kQExA2b2SljXM= X-Received: by 2002:a17:902:e5c9:b0:1fb:64da:b142 with SMTP id d9443c01a7336-1ff574f685bmr154170145ad.59.1722959118099; Tue, 06 Aug 2024 08:45:18 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> In-Reply-To: <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> From: Augusto Stoffel <arstoffel@HIDDEN> Date: Tue, 6 Aug 2024 17:45:04 +0200 Message-ID: <CAHixrvabHG1-tydO_jCENbJzBdpujYZ9hgWOX09Hjc5_0bGuSQ@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000032713f061f05aeef" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --00000000000032713f061f05aeef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 6, 2024, 17:34 Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> wro= te: > * lisp/progmodes/eglot.el (eglot-server-programs): Explicitly list modes > derived from tex-mode, so that the correct language id is guessed. > > Won't it break when another mode is derived from it? > Not really, since such a hypothetical mode has no support from the servers. May I ask why > don't you just use the :language-id cookie which is designed > exactly for this -- to avoid a guess? > That doesn't work, because apparently Eglot picks the language id of the first mode in the listing that applies, which previously was the generic tex-mode. That doesn't allow distinguishing latex and plain TeX. Again, the issue is not guessing the language id string from the mode name, but rather choosing the right mode symbol to guess from. (Above I say apparently because this is not documented behavior, although it's easy to check or verify reading the code.) --00000000000032713f061f05aeef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D= "gmail_attr">On Tue, Aug 6, 2024, 17:34 Jo=C3=A3o T=C3=A1vora <<a href= =3D"mailto:joaotavora@HIDDEN">joaotavora@HIDDEN</a>> wrote:<br></d= iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord= er-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div = dir=3D"ltr">* lisp/progmodes/eglot.el (eglot-server-programs): Explicitly l= ist modes<br>derived from tex-mode, so that the correct language id is gues= sed.<br><div><br></div><div>Won't it break when another mode is derived= from it?=C2=A0 </div></div></div></blockquote></div></div><div dir=3D"auto= "><br></div><div dir=3D"auto">Not really, since such a hypothetical mode ha= s no support from the servers.</div><div dir=3D"auto"><br></div><div dir=3D= "auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style= =3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding= -left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div>May I ask why=C2=A0</div>= <div>don't you just use the :language-id cookie which is designed=C2=A0= </div><div>exactly for this -- to avoid a guess?</div></div></div></blockqu= ote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">That doesn= 9;t work, because apparently Eglot picks the language id of the first mode = in the listing that applies, which previously was the generic tex-mode. Tha= t doesn't allow distinguishing latex and plain TeX. Again, the issue is= not guessing the language id string from the mode name, but rather choosin= g the right mode symbol to guess from.</div><div dir=3D"auto"><br></div><di= v dir=3D"auto">(Above I say apparently because this is not documented behav= ior, although it's easy to check or verify reading the code.)</div></di= v> --00000000000032713f061f05aeef--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 6 Aug 2024 15:35:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 11:35:44 2024 Received: from localhost ([127.0.0.1]:32915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbMDw-0001Pv-Fs for submit <at> debbugs.gnu.org; Tue, 06 Aug 2024 11:35:44 -0400 Received: from mail-oa1-f41.google.com ([209.85.160.41]:57796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sbMDt-0001Pd-TE for 72343 <at> debbugs.gnu.org; Tue, 06 Aug 2024 11:35:42 -0400 Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-2689f749702so382708fac.3 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 08:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722958452; x=1723563252; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wT0RRwYhnkXOkksZFgdMj6XnKuYmc+D3MbbkJIkefaI=; b=fPlIBXYU/sRtaEE/IY8c3omePzapPvA69Oe0bBYenVIB9wJSnV9qwtJdkMVwdvaAwq shP3Wx9XVzAGbBjWH1D4i+WauX+Y3hhzOb9Ejl4DQMY9o2joB+J7nlg04KQlPnOPjvgg ocjNjY8iMSuKoIkElobzFEjZErzcuTc2zsx+qMt9UCXVhI18WPc36E/ksAX6OR3fkfWu wjAyT/P4GYkr6Elgg0N98/RjTa5YMAyMtw27MaiX+IKQxPTBPYgJqlMTCzbCE3/9YIqU ZoMhgjUZdVUhPK0/dr8Avs8m+3jLoXpiIwb/iKt3UemMgd8ZnshFRrer6zSIf8cXGy/l aUGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722958452; x=1723563252; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wT0RRwYhnkXOkksZFgdMj6XnKuYmc+D3MbbkJIkefaI=; b=DLp9QHkw8333iYhnPOfy90bJH1lz9Yc3uijq/ZN5aJbJVV3NeNqGRtNsbw+ML0ZUzf 7s6qVyaip1315lpY26EsWxBMrRr89fewL0/zlx2r9oHDQge8wIXGiMxGOrvVwSQcZzJB UlB/3bIOw753evifpyWblNIig4fzm3TC0SnR8+jDSdQ/iZV+UK2VA1rT3z66dRiADXRP Gc5KJlPrzFKdXRnO7/qzAWVPr/cohfOh56WFioZNC9/SuzhgRysIKtyxC9Nyg6bpbhz6 OBs53dzergy5oGQ1C5tglFrRrSJnBzit3ojdr76phqCbeb6g5VEvb9KSx0uMr4GWZygH a5FQ== X-Gm-Message-State: AOJu0YwkFn4b1LwbdTOP3RW2fa0/gn3c12qHhjsmiYQUQ1Qdsr63EnUr JZPsA/q7TnGPsdAhAYwRD+FNjGrut7G3TG8WmdN/apJB+L+Dovurd383qnwS5dSaE7hq6O8KxSf gwS034IHdoa1GmWXZCFL6tvXaY3c= X-Google-Smtp-Source: AGHT+IGVc07NSZnMXsZJ7vc1PvpqqqYRp6EpfqrLVwtfYIcmzuEDl1/smPqFQHR5+6kws6ACcYizBY+xkDOnMaMEsC0= X-Received: by 2002:a05:6870:6586:b0:25d:7cc4:caa8 with SMTP id 586e51a60fabf-26891a81021mr19233843fac.10.1722958451783; Tue, 06 Aug 2024 08:34:11 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> <87o765k7ze.fsf@HIDDEN> In-Reply-To: <87o765k7ze.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Tue, 6 Aug 2024 16:34:00 +0100 Message-ID: <CALDnm52gXTh38vfCJ4JcPXexc-RuAvzOPFajzb_9E6=ypzWZCg@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000007b3ffc061f0586a6" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000007b3ffc061f0586a6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable * lisp/progmodes/eglot.el (eglot-server-programs): Explicitly list modes derived from tex-mode, so that the correct language id is guessed. Won't it break when another mode is derived from it? May I ask why don't you just use the :language-id cookie which is designed exactly for this -- to avoid a guess? Jo=C3=A3o --0000000000007b3ffc061f0586a6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">* lisp/progmodes/eglot.el (eglot-server-p= rograms): Explicitly list modes<br>derived from tex-mode, so that the corre= ct language id is guessed.<br><div><br></div><div>Won't it break when a= nother mode is derived from it?=C2=A0 May I ask why=C2=A0</div><div>don'= ;t you just use the :language-id cookie which is designed=C2=A0</div><div>e= xactly for this -- to avoid a guess?</div><div><br></div><div>Jo=C3=A3o</di= v></div></div> --0000000000007b3ffc061f0586a6--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 6 Aug 2024 15:06:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 11:06:38 2024 Received: from localhost ([127.0.0.1]:32871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sbLll-0000HZ-43 for submit <at> debbugs.gnu.org; Tue, 06 Aug 2024 11:06:38 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:48572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sbLle-0000H4-Fw for 72343 <at> debbugs.gnu.org; Tue, 06 Aug 2024 11:06:35 -0400 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5a10835487fso1311464a12.1 for <72343 <at> debbugs.gnu.org>; Tue, 06 Aug 2024 08:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722956700; x=1723561500; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+W6nvW8NP+8M8lwux9yVWOKfekaEdE8YzFCXp1Qkcw8=; b=LTfZBwuM7Wq7UXPhQ/Am6/Y+C6DI8wbC1WCU3JgdRTCYK8KpvfzgMyz1oqcYZIT1CM 4miK43tsVpdQh1UUt1NIIWsdwRhrhZHsVH1MZj4U110vuEEWXUUNVXMtwn9BTalK/g71 uDSjXYdXKZRs0zEvx14sOS5CjFxbWwvsqsRQQ1u59B+Na8PBFZiD7TC7sbGPMPAXzr1o 0AmHdwUnLIXKtshvCZxod7FRaYLU5yXQattIttzP54Mz5Hkjdfq2d1VtcP+qlCbD3PFe rkMan8jhV7KrGlkBBz8tn1giXw3V/wGrKUR4eUBVGNwbOQRYElFS/+QgzKkGI5mHqyBg pnlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722956700; x=1723561500; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+W6nvW8NP+8M8lwux9yVWOKfekaEdE8YzFCXp1Qkcw8=; b=FuxAK/WkXRUKGGjROKiG/rpZ46aMFpsnFAACozXPBYWYG7oBSctb5x9KwqGKK8VyX4 CrW35isShfkAjWRnM0D+gbHubgbpZtxVEYX1gATT+CN6Hjh9AGzZCDzS9rCl7I+Ux5i5 12kqp5IKiRLRbyEOfc5P3GYVEYvIijiYFx3MKRwn9C0pXlRhqSecPv/zIw7AmMQF1Acm 2IpCfBNVDBCZLRH37RL5X3z5ZQefsuSVfjvtnJFAVVXR6ix7yE+tj0NMTsVrQbq6Mlh4 +outcDOlN+QHxCX9u+78GAzHvkNuzjhO6n8ZgxUJBWqLnWSnF1idrPqlRDQT0M/kHGnk tVcA== X-Gm-Message-State: AOJu0YyzCKKByqjOt9d/8d9K88cNGqW7OTA7lmLD02JEkd0PBDpN57Ea R5dHtTqrK9r3/J9dHY64hmOfmZpRrYyNM25pISWXL6FhV9Q0W/wY X-Google-Smtp-Source: AGHT+IHIzHOWIslCBGk4x+oGB2YJ0QUfUiXE9tB2JOb5y2dYT1PUlaRNYeaPPMofgBBHUgugXUWRLw== X-Received: by 2002:a05:6402:c08:b0:5b9:3846:8bab with SMTP id 4fb4d7f45d1cf-5b938469427mr8590445a12.14.1722956700115; Tue, 06 Aug 2024 08:05:00 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::e354]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b839610c77sm6081233a12.9.2024.08.06.08.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 08:04:55 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes In-Reply-To: <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Fri, 2 Aug 2024 16:29:45 +0100") References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> Date: Tue, 06 Aug 2024 17:04:53 +0200 Message-ID: <87o765k7ze.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jo=C3=A3o, The attached patch should satisfy the requisites you outlined above. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-eglot-server-programs-for-TeX-modes.patch From 659a7caede34c3d885f58227aa02c3e062ff980b Mon Sep 17 00:00:00 2001 From: Augusto Stoffel <arstoffel@HIDDEN> Date: Tue, 6 Aug 2024 16:58:06 +0200 Subject: [PATCH] Fix eglot-server-programs for TeX modes * lisp/progmodes/eglot.el (eglot-server-programs): Explicitly list modes derived from tex-mode, so that the correct language id is guessed. --- lisp/progmodes/eglot.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 31948a12d69..758bb9e9d3e 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -292,7 +292,7 @@ eglot-server-programs (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs"))) (racket-mode . ("racket" "-l" "racket-langserver")) - ((tex-mode context-mode texinfo-mode bibtex-mode) + ((plain-tex-mode doctex-mode latex-mode context-mode texinfo-mode bibtex-mode) . ,(eglot-alternatives '("digestif" "texlab"))) (erlang-mode . ("erlang_ls" "--transport" "stdio")) ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) -- 2.45.2 --=-=-=--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 2 Aug 2024 15:31:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 02 11:31:28 2024 Received: from localhost ([127.0.0.1]:53654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sZuFb-0003z5-Ml for submit <at> debbugs.gnu.org; Fri, 02 Aug 2024 11:31:28 -0400 Received: from mail-oo1-f47.google.com ([209.85.161.47]:58693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sZuFV-0003yo-19 for 72343 <at> debbugs.gnu.org; Fri, 02 Aug 2024 11:31:25 -0400 Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-5d60ab4f25bso2299774eaf.1 for <72343 <at> debbugs.gnu.org>; Fri, 02 Aug 2024 08:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722612597; x=1723217397; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cM64AVTv51B13lXamOsheOADakHLY7yeZaAnmso7iF4=; b=J3C/cRhLmeXA4g6UuMgnwNlxe13iZn9/fXTS72rC5JrW/315cW9z8VFENd1tds4Ttv oSyS+tahYtYC0Q/bICaTamK8bMH0nfpbWR/AVcVjN3G08LPnpTRQliPUFrAVw9BONWrA mCcaZqvEGEAnjtUFIUJCGSkaFlb9ulQsAlM5lj38aVLuYrKlQU0yAF+GuK7RYv6MtBIp X4HGqxxD333eUqPs4d6W1gULVWh6+IzxeuNUJYn9013wEWMXb8SKTiphZkYcAzMZYAPy ADaGfV97faTUSrWRTtvLALV4/7goBi0zSBAL4lux/lSSmsXKyWAvWXon6D79JcKIc1eO +K6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722612597; x=1723217397; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cM64AVTv51B13lXamOsheOADakHLY7yeZaAnmso7iF4=; b=invAU0/ekRT5XIP3qJxIzk8I7Fw8xoKYU4+ltf1VhqSRM0iBkK5E1mjv6rMtJsKbDv mql2t2LX15zjfqnOjH51sR5TRnDAc8UbI8Fv0P3w++JI4soQkygT9apMHpLzw6V32cCK gVV4zIZe9gdXtkxhoHeK4+JnzEO5vvA6WoIqtRH4+CSW3Rh9SJ/3cqmdTC/cRLZp9WwL d2x+EC0mJ/nFU5BvLJVOUv5Da4q0+iDNCaAhzoKf/EMzrUIfu7vkHRqBY2/iPY+8vGwA OuTSQ3UCcZPTteYCWwwwIE2CORiUn7RT2027DLq1H00m8xLir4dz72bykNhabtoPYN9r Xh8w== X-Gm-Message-State: AOJu0Ywb4Bzh2C83Vo+z1GNRKU8/hRCx3jf/nefhICfUtZgkcoS4DmI/ PhU7qHZ+rz+10/Y6Q3rcWhQO/oaYB9NodShH9qh1UhKif6cAmc5w8H2CgBBQa+iMSxBm3HhDj8A aG0Gyvz0kZPOZ08FtSUHVxCV763Y= X-Google-Smtp-Source: AGHT+IGtH+0OTT68mNcOPPfq2QndjoUUwxnRG9pD46TF5clAQ5JYarDXpJ1YVnNRNq4+ROsWWdNc2WLXXmIJn2IwAYg= X-Received: by 2002:a05:6870:224f:b0:260:fbc0:96ec with SMTP id 586e51a60fabf-26891e68691mr4691917fac.38.1722612596892; Fri, 02 Aug 2024 08:29:56 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> In-Reply-To: <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Fri, 2 Aug 2024 16:29:45 +0100 Message-ID: <CALDnm53hbbhMMHYmfg5FTC52UkNMc6jrW2QkRvLaqz-A3Tmh0w@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000ec6ce7061eb4ff5c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000ec6ce7061eb4ff5c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 2, 2024 at 4:13=E2=80=AFPM Augusto Stoffel <arstoffel@HIDDEN= > wrote: > > I think guessing "lang" from lang-mode is perfectly fine. > It's not. And increasingly less so. But you're right it should be perfectly possible to ask a mode: "what programming language, if any, are you for?". But it's not. It's a big discussion, I won't go over it. > For the reason noted above, there is no "concise solution" to choose, all > derived modes from tex-mode need to be mentioned explicitly in one way or > another (either to make the guess correct, or to provide manually a > language id). > The solution I gave is more concise in the number of elements of eglot-server-programs. And explicit in what it is doing. > Fine, I can change the patch so that texlab will still run on modes that > it doesn't support (plain TeX and ConTeXt, etc). Just please confirm that > this is the behavior you prefer. > Yes, I prefer patches that do only their stated purpose and no other side effects. Jo=C3=A3o --000000000000ec6ce7061eb4ff5c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Fri, Aug 2, 2024 at 4:13=E2=80=AFPM Au= gusto Stoffel <<a href=3D"mailto:arstoffel@HIDDEN">arstoffel@HIDDEN= m</a>> wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"g= mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204= ,204,204);padding-left:1ex"><div dir=3D"auto"><div><div class=3D"gmail_quot= e"><div dir=3D"ltr" class=3D"gmail_attr"><br></div></div></div><div dir=3D"= auto">I think guessing "lang" from lang-mode is perfectly fine. <= /div></div></blockquote><div><br></div><div>It's not.=C2=A0 And increas= ingly less so.=C2=A0 But you're right it should be perfectly possible t= o ask a mode: "what programming language, if any, are you for?".= =C2=A0 But it's not.=C2=A0 It's a big discussion, I won't go ov= er it.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"mar= gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1= ex"><div dir=3D"auto"><div dir=3D"auto">For the reason noted above, there i= s no "concise solution" to choose, all derived modes from tex-mod= e need to be mentioned explicitly in one way or another (either to make the= guess correct, or to provide manually a language id).</div></div></blockqu= ote><div><br></div><div>The solution I gave is more concise in the number o= f elements of eglot-server-programs.=C2=A0 And explicit in what it is doing= .</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0= px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><= div dir=3D"auto"><div dir=3D"auto">Fine, I can change the patch so that tex= lab will still run on modes that it doesn't support (plain TeX and ConT= eXt, etc). Just please confirm that this is the behavior you prefer.</div><= /div></blockquote><div><br></div><div>Yes, I prefer patches that do only th= eir stated purpose and no other side effects.</div><div><br></div><div>Jo= =C3=A3o</div><div>=C2=A0</div></div></div> --000000000000ec6ce7061eb4ff5c--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 2 Aug 2024 15:14:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 02 11:14:52 2024 Received: from localhost ([127.0.0.1]:53643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sZtzX-0003RU-HX for submit <at> debbugs.gnu.org; Fri, 02 Aug 2024 11:14:52 -0400 Received: from mail-pf1-f169.google.com ([209.85.210.169]:43490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sZtzV-0003RJ-4e for 72343 <at> debbugs.gnu.org; Fri, 02 Aug 2024 11:14:50 -0400 Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-70d316f0060so2286867b3a.1 for <72343 <at> debbugs.gnu.org>; Fri, 02 Aug 2024 08:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722611605; x=1723216405; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s4OsW/kryTr1qWIHcRdzKMpT0Zjll6UE0hjftrqO0Oo=; b=MFuudPrJCC9naAqIvr6XVmQcgYxIh9lqtDYxF+yth03w3F9z3CYvnzUiJ8H4D0O5Mr 8dxAFsNs/x8/JI7VyRd6IUY5z9kK6QyxXEECLuuvOig/sE6SXDWi5/8MVFFh9acu7mNM y0Pt+msu5JlrtPm4yGXyJzV/TLi7gK9YZPI4FXED6veFi1840xI+hx80XGc2+lbBqgiH 0J1DA4IHxWbjOiaByY84IOVcrv5hSMgIADMB40Ntn+2oYjwhwDf3aisINUqg9vFgre8P 9mhDINvN4Ex8hqezH6ue+wHzC7PrQCK1JoDiHMo1nLjvU54OkhJVOqACzOAakvnRkSOb VTag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722611605; x=1723216405; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s4OsW/kryTr1qWIHcRdzKMpT0Zjll6UE0hjftrqO0Oo=; b=Z1Tha5GbDrZu1WVmfTuD6TV81OsOIVXZUZ1rbl8XUj4OMb5xXvFtbLL6nw9NLL37YE i+2cevEVJNcLJ+tREmDZR+wGzwzErR8vYIFOV9Zo9e14Wtm5S7Xl8pxV/MzKxWahP8d4 xAKhoDPeCWceYtVPyxWZK0RaVwx8cQ7JNMA8CsTBvfyQKFOwc83oo16R+6O72B+AqBWE am5P12xGeKwLeem4v63HwQcrNh+4dFScbfi46tITf7XqmpNUPcHygYrDHj95NnSQaQgD X3jxt0UzwOkebJJkouL1RXQWdTL2VmHlue+R8Agn7kHeBViFu9QX9rCxS6DWVaAm04Bc 6ZNQ== X-Gm-Message-State: AOJu0Yz4+2R2vJ+zfwyBtRo3fQ0qyk41WpP7PcOjXvtzYgspEgDfsP4f ucKLpHysa5NPYvHzRzH48hb4IzDrmBw38YJ+pWelRwQ54p8bjw8Tdi+Fq5PwbjWeCzxeH7bXa0B gu6Q8L8dHh3EaDr2H5ZrMeFOO2Dw= X-Google-Smtp-Source: AGHT+IFdaSwQSPQD6gVOiBC1lmPtHsJVXQ8aTsVJO2gPu6MgLCihl53PyMnS69C6wFrIVnaM/LlnHEd65tWJX9cpRJM= X-Received: by 2002:a17:902:fa84:b0:1fd:96c7:24f5 with SMTP id d9443c01a7336-1ff523ef6f9mr61867095ad.5.1722611604560; Fri, 02 Aug 2024 08:13:24 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@HIDDEN> <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> In-Reply-To: <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@HIDDEN> From: Augusto Stoffel <arstoffel@HIDDEN> Date: Fri, 2 Aug 2024 17:13:11 +0200 Message-ID: <CAHixrvY_G_fxLCksPOqcT52WXpeCtGm9ObG1BnrJ1jPx4rGEfg@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000c6a906061eb4c4c6" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000c6a906061eb4c4c6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 2, 2024, 16:01 Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> wro= te: > [Did you mean to write only to me?] > Sorry, I'm copying the bug list now. > > On Fri, Aug 2, 2024 at 2:09=E2=80=AFPM Augusto Stoffel <arstoffel@HIDDEN= om> > wrote: > > >> Have you tried the :language-id _keyword_ as explained in the > documentation I linked to? It should avoid the multiple entries. > > I had to look at the source code for some examples to see what you mean= . > Sure, that would avoid multiple entries. > > I'd think this sentence: > > > can be either a symbol of an Emacs major mode or > > a list of the form (mode :language-id id), with mode being a major-mode > symbol > > and id a string that identifies the language to the server > > Would be enough. It's very typical of Emacs variables to have these kind= s > of things. > But feel free to propose some better documentation. Maybe an example. > > > Still, it's unclear to me why one would prefer a solution that requires > dabbling into language ids where it could be avoided. > > The problem you're trying to solve is related to language-id, as far as I > understand. > The "wrong" one is being sent right now, and you want the correct one to > be sent. > So it's not a question of dabbling, it's about sending the correct value. > And there's a > setting for affecting precisely that value, with no middle man, and it wa= s > designed > for solving exactly your problem. Guessing the language-id from the > major-mode > name is much worse than that, IMHO. > I think guessing "lang" from lang-mode is perfectly fine. The problem here is that when eglot-server-program lists a server for tex-mode and the server is selected for use in a derived mode such as latex-mode, the guessed language is tex and not latex. > Also it's a more concise solution. > For the reason noted above, there is no "concise solution" to choose, all derived modes from tex-mode need to be mentioned explicitly in one way or another (either to make the guess correct, or to provide manually a language id). Also it's more in-line with the rest of the variable, > Also keeps texlab working (or not working) like it did before. Also > doesn't spam "digestif" > multiple times in e-s-programs. > Fine, I can change the patch so that texlab will still run on modes that it doesn't support (plain TeX and ConTeXt, etc). Just please confirm that this is the behavior you prefer. > So if you say it works and can actually test it, please use that instead. > > Jo=C3=A3o > --000000000000c6a906061eb4c4c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D= "gmail_attr">On Fri, Aug 2, 2024, 16:01 Jo=C3=A3o T=C3=A1vora <<a href= =3D"mailto:joaotavora@HIDDEN">joaotavora@HIDDEN</a>> wrote:<br></d= iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord= er-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>= [Did you mean to write only to me?]</div></div></blockquote></div></div><di= v dir=3D"auto"><br></div><div dir=3D"auto">Sorry, I'm copying the bug l= ist now.</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote clas= s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r= gb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div><br></div>On Fri, A= ug 2, 2024 at 2:09=E2=80=AFPM Augusto Stoffel <<a href=3D"mailto:arstoff= el@HIDDEN" target=3D"_blank" rel=3D"noreferrer">arstoffel@HIDDEN</a>&= gt; wrote:<br><br>>> Have you tried the :language-id _keyword_ as exp= lained in the documentation I linked to? It should avoid the multiple entri= es.<br>> I had to look at the source code for some examples to see what = you mean. Sure, that would avoid multiple entries.<br><br>I'd think thi= s sentence:=C2=A0<div><br></div><div>> can be either a symbol of an Emac= s major mode or=C2=A0<div>> a list of the form (mode :language-id id), w= ith mode being a major-mode symbol=C2=A0</div><div>> and id a string tha= t identifies the language to the server</div><div><br></div><div>Would be e= nough.=C2=A0 It's very typical of Emacs variables to have these kinds o= f things.=C2=A0</div><div>But feel free to propose some better documentatio= n.=C2=A0 Maybe an example.<br>=C2=A0<br>> Still, it's unclear to me = why one would prefer a solution that requires dabbling into language ids wh= ere it could be avoided.<br><br>The problem you're trying to solve is r= elated to language-id, as far as I understand.=C2=A0=C2=A0</div><div>The &q= uot;wrong" one is being sent right now, and you want the correct one t= o be sent.</div><div>So it's not a question of dabbling, it's about= sending the correct value.=C2=A0 And there's a=C2=A0</div><div>setting= for affecting precisely that value, with no middle man, and it was designe= d</div><div>for solving exactly your problem. Guessing the language-id=C2= =A0 from the major-mode=C2=A0</div><div>name is much worse than that, IMHO.= </div></div></div></blockquote></div></div><div dir=3D"auto"><br></div><div= dir=3D"auto">I think guessing "lang" from lang-mode is perfectly= fine. The problem here is that when eglot-server-program lists a server fo= r tex-mode and the server is selected for use in a derived mode such as lat= ex-mode, the guessed language is tex and not latex.</div><div dir=3D"auto">= <br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D= "gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2= 04,204,204);padding-left:1ex"><div dir=3D"ltr"><div><br></div><div>Also it&= #39;s a more concise solution.=C2=A0 </div></div></blockquote></div></div><= div dir=3D"auto"><br></div><div dir=3D"auto">For the reason noted above, th= ere is no "concise solution" to choose, all derived modes from te= x-mode need to be mentioned explicitly in one way or another (either to mak= e the guess correct, or to provide manually a language id).</div><div dir= =3D"auto"><br></div><div dir=3D"auto"><br></div><div dir=3D"auto"><div clas= s=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px= 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div di= r=3D"ltr"><div>Also it's more in-line with the rest of the variable,=C2= =A0=C2=A0</div><div>Also keeps texlab working (or not working) like it did = before.=C2=A0 Also doesn't spam "digestif"<br></div><div>mult= iple times in e-s-programs.=C2=A0=C2=A0</div></div></blockquote></div></div= ><div dir=3D"auto"><br></div><div dir=3D"auto">Fine, I can change the patch= so that texlab will still run on modes that it doesn't support (plain = TeX and ConTeXt, etc). Just please confirm that this is the behavior you pr= efer.</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmai= l_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e= x;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"= ><div><br></div><div>So if you say it works and can actually test it, pleas= e use that instead.</div><div><br></div><div>Jo=C3=A3o</div></div> </blockquote></div></div></div> --000000000000c6a906061eb4c4c6--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 30 Jul 2024 20:31:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 30 16:31:09 2024 Received: from localhost ([127.0.0.1]:48595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sYtUz-0007il-5I for submit <at> debbugs.gnu.org; Tue, 30 Jul 2024 16:31:09 -0400 Received: from mail-oa1-f43.google.com ([209.85.160.43]:59490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sYtUv-0007i8-P5 for 72343 <at> debbugs.gnu.org; Tue, 30 Jul 2024 16:31:07 -0400 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-260209df55dso3025667fac.2 for <72343 <at> debbugs.gnu.org>; Tue, 30 Jul 2024 13:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722371385; x=1722976185; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KCZ9+Kgbmefw4B/2JUXpFnHtRthXV7HWLAEfGAMaboY=; b=MaV8N9c7ezfLHJFMO2MMqH5mGzntxzfpIeY5GdwpGAQSqLbOMmpBlIg1SrTtQF3suZ nJcxmonj4Ou2DOLeY24Gq7fb+xNPrYQIiznhTGcgVjG1M96YxYQRyHaZ79bqtxZq3U0W i8oaq2abIEJnkw7PpHv/Wn3ygE4hqKlkNwTUVca5llWL7Z4uldr0Xsc8VIgLwOuIuFoA NV+BbsB2szOnUVZkzsnMzWXgL+8lTmO1YeBgSKzJFwgZM0CZDJYysAbU0rSokv5dXUAz 5EDGIyMR7gCBkXUmEn5VZ5IzoT3FIIHI0nJhlZ2vCM8zbzybOlLQQFYaWcZSbJ7m7KLX 50Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722371385; x=1722976185; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KCZ9+Kgbmefw4B/2JUXpFnHtRthXV7HWLAEfGAMaboY=; b=CHwLLsAopJKp3T5dIBJKCtJwU71aSHxQxhgtmCoy7R0X9B+EYWeoXhg60d9RoOVB1H F5IZ4jqjptuR4F6TNNimrFgn6SQsEfJVBmFLPAQ1R3c5AiSTn7fMPjQjHEBBxzKucIdg tRIEW71Smwmp0TJ8lOgoBvklbK/5xHp8hAnkfNL0r++DL3TIaFyJJ7FgBd3xbF+biyKL 5fZZMNUeH3xp1e8VohwVSLXdqWSzIj9Jspova9oJEyQmTrAyxYUM9xmCLlh++WRvnhjl /7QewbBnWygxQZ4/EWhAElCb2EcWeqISJ2O5lR2ZNj5/drudRWQBmTyhpiYexEQNuu7I 8BQA== X-Forwarded-Encrypted: i=1; AJvYcCUTwDTChm9/j8IWx235HVrp3fPY8aHf1dztHgbXZ1GrWkyFp6+rXpkNzy2NFqNNL7TILle1SR4XM9mBOk4v8541ro9WzME= X-Gm-Message-State: AOJu0Yy2CEqVcMOM2f6btdm+roUhCyEJGpeK4T0FplfGQZzhNvirb8Hm vfZDUis/3PsTY2T9kV0+J6KzVPMqUJTCF0uMeWPf2ICSEvnY5dkK0XZm6h0QOrKt7GVGj/7VJpM fjJHrg3qE4SudEIlU1w4ipPdAnX8= X-Google-Smtp-Source: AGHT+IE9iFcSpTaIKgzvXXW1tQ6fL7FLZ2341ROQlGTZTknH4PWMduIo7+RaD18+uXENIXXBj6Xvp5qwJdUiEo+XhT0= X-Received: by 2002:a05:6870:32d4:b0:261:16da:ded9 with SMTP id 586e51a60fabf-267d4d16676mr15451659fac.6.1722371385351; Tue, 30 Jul 2024 13:29:45 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> In-Reply-To: <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Tue, 30 Jul 2024 21:29:33 +0100 Message-ID: <CALDnm52-YAnMibQVAYe5BxihBFYfxAkgyvs=HJs5RTcoaT1bsA@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Augusto Stoffel <arstoffel@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000986440061e7cd664" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000986440061e7cd664 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 30, 2024, 19:20 Augusto Stoffel <arstoffel@HIDDEN> wrote: > Thanks, but what about the other part of Jo=C3=A3o's questions, regarding >> :language-id? >> > > That's precisely the point of the patch: make different derived modes of > tex-mode pass different language IDs to the server. Based on the > documentation Jo=C3=A3o referred to, separate entries in eglot-server-pro= grams > are needed in this case. > Have you tried the :language-id _keyword_ as explained in the documentation I linked to? It should avoid the multiple entries. Jo=C3=A3o > > --000000000000986440061e7cd664 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Tue, Jul 30, 2024, 19:20 Augusto Stoffel <<a hre= f=3D"mailto:arstoffel@HIDDEN">arstoffel@HIDDEN</a>> wrote:<br></di= v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde= r-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"auto"><div>= <div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margi= n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex= ">Thanks, but what about the other part of Jo=C3=A3o's questions, regar= ding<br> :language-id?<br></blockquote></div></div><div dir=3D"auto"><br></div><div = dir=3D"auto">That's precisely the point of the patch: make different de= rived modes of tex-mode pass different language IDs to the server. Based on= the documentation Jo=C3=A3o referred to, separate entries in eglot-server-= programs are needed in this case.</div><div dir=3D"auto"></div></div></bloc= kquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Have you t= ried the :language-id _keyword_ as explained in the documentation I linked = to? It should avoid the multiple entries.</div><div dir=3D"auto"><br></div>= <div dir=3D"auto">Jo=C3=A3o</div><div dir=3D"auto"><div class=3D"gmail_quot= e"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord= er-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"auto"><div= dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><block= quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1= px solid rgb(204,204,204);padding-left:1ex"> </blockquote></div></div></div> </blockquote></div></div></div> --000000000000986440061e7cd664--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 30 Jul 2024 18:22:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 30 14:22:13 2024 Received: from localhost ([127.0.0.1]:48381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sYrUD-00049k-7X for submit <at> debbugs.gnu.org; Tue, 30 Jul 2024 14:22:13 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:56389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sYrUA-00049X-Eu for 72343 <at> debbugs.gnu.org; Tue, 30 Jul 2024 14:22:11 -0400 Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1fc6a017abdso29866905ad.0 for <72343 <at> debbugs.gnu.org>; Tue, 30 Jul 2024 11:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722363650; x=1722968450; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xGAqO5FJ3HLszJ8LVyiP7g62IS3ZubzUxsVgE4vp1ys=; b=cRw24qWYz3MSRFQ+ktkAEF3bgU7gwkSOaDfFDjuLvq0y8YmlD9NodZPzwTcsJi+kXT azTy2KHFvwzTa6KUONsIMiuHsbDFoYebcyN5isLzpv338hOU3cD29K/AArAzvhLl5u86 k+9du0uEB7XeVOauMoxsS9AE+PCH+zrAkuIqzx3nha0ryx4cecZgd66wqDkNsr4Ib6JC H0M/Op5aMlDgRYrdcZGUzFEKBsBvco3vNPknsTRYSNFQrQ44xh+JVselmL3KDtCmO6lQ eYmCd+qeSTTFiipoy/oawHDUtxP6QxBHZZtpoqP9F92TnRcT7jYDN6gtBB2MAEGNgp2X DIgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722363650; x=1722968450; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xGAqO5FJ3HLszJ8LVyiP7g62IS3ZubzUxsVgE4vp1ys=; b=A773yi/rd4nJnTH/+9nAVocp4bq2KhDivHxFQEA/0OfuRkOLLA/VPukY8MhyHeEFod 7t8T4n23EaYAlXPXSy9ASgR+Qevub6iGlIkm3YkiFLRA6bl/ujLILTSkG/yD2ghL8K9O at66jdG8qPBGwhujKMBBnJh2UzH+FFdihkJtpktGV4p1QvTzwABf1Vupc/zjYM7RMQ3J Mu58kih18ZL0LwwGMqbLwv2xsCB05mOKiOQRg5mOH0GFH85/jrpFcCBPX/QTlgLzM/2r eJgBXhrIxRAo/DMAJACe9HTVOwZ+Qn973Zrr7f+j/IbWQ+cPFvQMUubbgcRO8KzMXszy yM0Q== X-Forwarded-Encrypted: i=1; AJvYcCXVsja9fQ40Z9L5doixZoLUbyiX9Obo0mI2NoDO1kVLvGGfSzX1u2aR2kI4GI55EOjee66Ni5iD+HY7PB5m6Bj44WHP+84= X-Gm-Message-State: AOJu0Yxak295hVOOmQm/kSmvcU1PrjfJs0fTGYsWBqHy0ikEIQREqD6a WPy5Z2MHQn/KrBici8/9oaIPJmwq+3ufoevEMgZVubSzyKsZGhZFk/7erOVNHuIYFSbplOFYLw7 +j7V4zCUkfyTFC3v8+6VNELkEkEE= X-Google-Smtp-Source: AGHT+IHTasbZleQDcppvs7aU8mannw1TV0VfKgxWtDtPirMRdOHntVFgbkmkJTHjQFiSs+29EQzFzXQLYgLQAaRohQ4= X-Received: by 2002:a17:903:2305:b0:1fc:670f:426d with SMTP id d9443c01a7336-1ff048110b6mr95654215ad.19.1722363649937; Tue, 30 Jul 2024 11:20:49 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> <86frrszbep.fsf@HIDDEN> In-Reply-To: <86frrszbep.fsf@HIDDEN> From: Augusto Stoffel <arstoffel@HIDDEN> Date: Tue, 30 Jul 2024 20:20:37 +0200 Message-ID: <CAHixrvZmqHW1pf61qLQOJMzou81wx_UTxoq_m3Uw5nxzn5dCPQ@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000875d05061e7b09cc" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000875d05061e7b09cc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > Thanks, but what about the other part of Jo=C3=A3o's questions, regarding > :language-id? > That's precisely the point of the patch: make different derived modes of tex-mode pass different language IDs to the server. Based on the documentation Jo=C3=A3o referred to, separate entries in eglot-server-progr= ams are needed in this case. --000000000000875d05061e7b09cc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><div class=3D"gmail_quote"><blockquote class=3D"gmai= l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20= 4,204);padding-left:1ex">Thanks, but what about the other part of Jo=C3=A3o= 's questions, regarding<br> :language-id?<br></blockquote></div></div><div dir=3D"auto"><br></div><div = dir=3D"auto">That's precisely the point of the patch: make different de= rived modes of tex-mode pass different language IDs to the server. Based on= the documentation Jo=C3=A3o referred to, separate entries in eglot-server-= programs are needed in this case.</div><div dir=3D"auto"><br></div><div dir= =3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" styl= e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin= g-left:1ex"> </blockquote></div></div></div> --000000000000875d05061e7b09cc--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 29 Jul 2024 11:27:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 29 07:27:17 2024 Received: from localhost ([127.0.0.1]:45032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sYOX7-0000sE-Jo for submit <at> debbugs.gnu.org; Mon, 29 Jul 2024 07:27:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sYOX5-0000ry-KE for 72343 <at> debbugs.gnu.org; Mon, 29 Jul 2024 07:27:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sYOWm-0005W9-MF; Mon, 29 Jul 2024 07:26:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=JNTfKihx03BZJd94JK7wj4g2I6zApWqzteq9QkNI/fM=; b=JBlQVj0nir99FzgV3Rnk eYEZ6qbeWDcsz1ZwWa+YGCQPqJmMcxB5jFW2Y8b6I5scgaNHmbQB1R9ixD12JwH//C2agumGmdQrc O52W6Ce9gEbma2W51HRH7Yz6IUQlH/M4uRus8TzYHggCwX5M0OHYcQaPTDnDI/CPxcLAUw5bGm618 g0hPaPw4CEh5R210PR90zq+BGckzXKuDOVWvM6Oo3Ae9jmOqUCOD2NsIyw+NGaa/cpBsFoBJQ05O2 21JOUj1SARLHYAPHG1saH5eeDEIJxZyAKs/QXMTEWTzCghea5OKPuMkOU+P+5CeE1rK16yg0Sn/vx dTiAwaWQVCgbbg==; Date: Mon, 29 Jul 2024 14:26:54 +0300 Message-Id: <86frrszbep.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Augusto Stoffel <arstoffel@HIDDEN> In-Reply-To: <87ttg8k9l6.fsf@HIDDEN> (message from Augusto Stoffel on Mon, 29 Jul 2024 08:15:17 +0200) Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> <87ttg8k9l6.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72343 Cc: joaotavora@HIDDEN, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Augusto Stoffel <arstoffel@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org > Date: Mon, 29 Jul 2024 08:15:17 +0200 > > On Sun, 28 Jul 2024 at 22:31, João Távora wrote: > > > Also, is it an additional goal to prefer Augusto's 'digestif' sever here? > > I haven't changed the order of preference in the patch. > > > Unless I'm misreading it, this change seems to have the side > > effect that context-mode, texinfo-mode will no longer be served > > by 'texlab' (by default) if the user has that installed. Probably > > plain-tex-mode could also be served by 'texlab'. > > To the best of my knowledge (based on the documentation only; I haven't > tried it), texlab supports only latex and bibtex. I'm not aware of > other servers that support plain TeX or Texinfo. Thanks, but what about the other part of João's questions, regarding :language-id?
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 29 Jul 2024 06:16:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 29 02:16:39 2024 Received: from localhost ([127.0.0.1]:44767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sYJgU-0001Hw-PU for submit <at> debbugs.gnu.org; Mon, 29 Jul 2024 02:16:39 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:43084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sYJgQ-0001Hl-Kq for 72343 <at> debbugs.gnu.org; Mon, 29 Jul 2024 02:16:37 -0400 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a7aada2358fso576781566b.0 for <72343 <at> debbugs.gnu.org>; Sun, 28 Jul 2024 23:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722233721; x=1722838521; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q3T0FduodSaIPSFaVKJeuB6D2FYi4nmBorrbhPU7zJQ=; b=GM7sG3uzF6L2d/8kdt04GBAU5Mj9zx7LH9K/wIUxygjAON+/tiBvmEpqI390tYz+l8 UYQgsqcM/l25dPUUXVzRgPCitL+5iwICqRKXlXfj973NkIXmaS1zIicgehEpl/a8svYd /r/OhgzOZtuufsn1pKv67sLBV/NtTURbEGJb1ry1ATVwT63Ten14vCi1kMKmN/Jkk12b SNyAPijnX+SUqx21xRC1EUiBh9IdQmQo8HUNFMRg+G2kqT6N+r9oT8mQvYXe0nLS20Nt 3YAreufbadqYVHBpUK7yD5bJ6Rh/C9WkIc9mOwDxLB1OaNYfsd1H1WzvT8Omi7wa1K8J YPbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722233721; x=1722838521; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q3T0FduodSaIPSFaVKJeuB6D2FYi4nmBorrbhPU7zJQ=; b=NRyVNbFlavDuenJfZ/XFdQw2gRzattxuAM/H9hyIB5UG0kXpqcObjBifE2Y17FRTA+ qa5+b3M6ye4Xmkysk5BMj+ANvSXrNOgszJD6kxHTwQ2BhueHBn7Ha70kHrtFXzDfET3w 55dWXY2n386A/5ofkiyVKLjQxfSnXInAiHMn0ugjvjCOfIl76jnuO4gVDskkNdGEE3Ql pvZ+6LaAT618Jl3p8yq17P08+4F+j5kZiUidoXdMvrYUTAX0ry8cHKBKdp1oVCLO3JQI 214t9sG23NQr9M7ImzqIQuRgACmT2X4EBajz/Zq8zbrwidnRGI8q7xICbE7CIX+MTNRQ uYfw== X-Forwarded-Encrypted: i=1; AJvYcCW4JzoVTJHZksrP6C3ok8T1+y9t4WL4TOtIt8bf4JANESL6bdnngKDVd5DzRhZX62kJ18sPzb7B78Xd2jKHQwSMi82i2GQ= X-Gm-Message-State: AOJu0YykjM3INTK4YDwqjXe0/sE6bStwHmqM1WZn8y1JN2jHytHHfIu3 G14UVhz5GRokObURrP5ABfX6BMM0sWaGbhMd39AnNlvWJl2LVkMV04BxaQ== X-Google-Smtp-Source: AGHT+IHcEOIzpkPnzzZpf1uC4XgZ2hzoq3aVYzIuF4YddEoNqqWZsm46pujRDoReyUF4NRpFKt3Q8w== X-Received: by 2002:a17:906:cad8:b0:a72:7b17:5d68 with SMTP id a640c23a62f3a-a7d3f81dc42mr642528966b.3.1722233720365; Sun, 28 Jul 2024 23:15:20 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::e354]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acadb68c2sm462679066b.190.2024.07.28.23.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jul 2024 23:15:19 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes In-Reply-To: <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Sun, 28 Jul 2024 22:31:46 +0100") References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> Date: Mon, 29 Jul 2024 08:15:17 +0200 Message-ID: <87ttg8k9l6.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Eli Zaretskii <eliz@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Sun, 28 Jul 2024 at 22:31, Jo=C3=A3o T=C3=A1vora wrote: > Also, is it an additional goal to prefer Augusto's 'digestif' sever here?= =20=20 I haven't changed the order of preference in the patch. > Unless I'm misreading it, this change seems to have the side=20 > effect that context-mode, texinfo-mode will no longer be served=20 > by 'texlab' (by default) if the user has that installed. Probably=20 > plain-tex-mode could also be served by 'texlab'. To the best of my knowledge (based on the documentation only; I haven't tried it), texlab supports only latex and bibtex. I'm not aware of other servers that support plain TeX or Texinfo.
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 28 Jul 2024 21:33:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 28 17:33:20 2024 Received: from localhost ([127.0.0.1]:44408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sYBW4-0004er-EF for submit <at> debbugs.gnu.org; Sun, 28 Jul 2024 17:33:20 -0400 Received: from mail-oa1-f48.google.com ([209.85.160.48]:49384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sYBW1-0004ec-GN for 72343 <at> debbugs.gnu.org; Sun, 28 Jul 2024 17:33:19 -0400 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-26119999171so2075249fac.2 for <72343 <at> debbugs.gnu.org>; Sun, 28 Jul 2024 14:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722202320; x=1722807120; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/yvFJ+cgW3uwEflzCVgwlUQ46vj5PrTg53RukfD7KOw=; b=fMcIlDW9CAz90/EWdqj2Uf1EXiO9iI7m7oD5JIw+YpwHKbHLF8BFtIlqmzZmZzBynZ CgwjNidr8slfkVthDGHFAyRz2Tdsqshnmp+THk/BLZniSNUPZLQ/Z4Bbc2hWIKDAnGjK JLN2g+7RL92iOX0p/9IokR81NutO1e1+p6r1k6K2Fy0fKbPJbSmFk4OIvr7OqWEXCcK5 JNrB5YFDfYERgswAY6r5CEnjZuSS7mVSQInia0qNaFt/iVMU5QNkYFASjJkc/KFxabyx t/OYTRf1MsvmpWPcjiN8jNf91IRaTipxaDkujggPXAcFfWU2kgdHfm+Frwp4PGJEHYNI oJ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722202320; x=1722807120; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/yvFJ+cgW3uwEflzCVgwlUQ46vj5PrTg53RukfD7KOw=; b=fRIhxmXLWETQXF8/HTwJxefKjHesc4YGWfdaqMFQnSuewrzghIABuAivIPEIIsGKK6 IEbEYR84EbdtST4ZZ6oPY5KGWOXG5egXv8W6LwKImS3SozUOd33BXxP+oZnJTtVVPA6i fEwpqyVz9fHrcRG65lWICqUOfCj5yLZQpka/qQrgXusysZXO9wnIhbRo8vhsI7GeyC4N GSNbzQj7lYM3d6q+GR7AJoZQhQRyzW2VCuS6txuLDhQ8A36qewZBA+ldRsHQI84zMQoI at0NPSjvdnHFwy3iSnJGoTfInW+AdEWZwt9ljNrOiq8yqrMosVQngceTA5Eo4t9fQK4B xbcg== X-Forwarded-Encrypted: i=1; AJvYcCWHmozV9RwaWS/47uA1Bn840KK51EWxCCDt+quFQ+2EKwoVH4hPT1TB+eS/cjj0BPuqJy8/cGY2Dtkm3jjJTbtzI3BO344= X-Gm-Message-State: AOJu0YxAkJ84lX0SYo8YLy1Zt0dIQLuD+gzWvKn3HVziWCwPz2jZLvZe Qq71qXS7hevYrOwBnUMZbNP1PE1gLb6+yqpvziH9mfF12ocWnFyGDuH+BVAiOe6DTAem/7Y6pdo gRC9YXrV3qqk+7Zn4zbCarruhaDA= X-Google-Smtp-Source: AGHT+IGlcZbaav01RfCDD4S72a1BKaDxh8LbOMqjEJVHtXq8zhy+u2L/FFTuv47Tkb27uRWvtQvbyaH08Ys1Kp8VWhk= X-Received: by 2002:a05:6870:2247:b0:260:e2ea:e680 with SMTP id 586e51a60fabf-267d4d1666bmr7107608fac.10.1722202319780; Sun, 28 Jul 2024 14:31:59 -0700 (PDT) MIME-Version: 1.0 References: <87sevtz8xg.fsf@HIDDEN> <86msm1z8c4.fsf@HIDDEN> In-Reply-To: <86msm1z8c4.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Sun, 28 Jul 2024 22:31:46 +0100 Message-ID: <CALDnm52usALzEZxBoqfrqvww4HC7JohAwz91Jf1CftM4MUrYBg@HIDDEN> Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000808aa6061e55793b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72343 Cc: Augusto Stoffel <arstoffel@HIDDEN>, 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000808aa6061e55793b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jul 28, 2024 at 7:21=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > > I noticed Eglot currently sends the languageId "tex" in all TeX-derived > > modes, which is not correct; it should be "latex", "bibtex", etc. If that's the goal, I think the :language-id cookie can help. Has that been tried? I think it's documented well enough here: https://joaotavora.github.io/eglot/#index-eglot_002dserver_002dprograms Also, is it an additional goal to prefer Augusto's 'digestif' sever here? Unless I'm misreading it, this change seems to have the side effect that context-mode, texinfo-mode will no longer be served by 'texlab' (by default) if the user has that installed. Probably plain-tex-mode could also be served by 'texlab'. Jo=C3=A3o --000000000000808aa6061e55793b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Sun, Jul 28, 2024 at 7:21=E2=80=AFPM E= li Zaretskii <<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN</a>> wrote= :</div><div class=3D"gmail_quote"><div><br></div><div>> > I noticed E= glot currently sends the languageId "tex" in all TeX-derived</div= >> > modes, which is not correct; it should be "latex", &qu= ot;bibtex", etc.</div><div class=3D"gmail_quote"><br></div><div class= =3D"gmail_quote">If that's the goal, I think the :language-id cookie ca= n help.=C2=A0</div><div class=3D"gmail_quote">Has that been tried?=C2=A0 I = think it's documented well enough here:</div><div class=3D"gmail_quote"= ><br></div><div class=3D"gmail_quote"><a href=3D"https://joaotavora.github.= io/eglot/#index-eglot_002dserver_002dprograms">https://joaotavora.github.io= /eglot/#index-eglot_002dserver_002dprograms</a><br></div><div class=3D"gmai= l_quote"><br></div><div class=3D"gmail_quote">Also, is it an additional goa= l to prefer=C2=A0Augusto's 'digestif' sever here?=C2=A0=C2=A0<b= r></div><div class=3D"gmail_quote"><div>Unless I'm misreading it, this = change seems to have the side=C2=A0</div><div>effect=C2=A0 that context-mod= e, texinfo-mode will=C2=A0no longer be served=C2=A0</div><div>by 'texla= b' (by default) if the user has that installed.=C2=A0 Probably=C2=A0</d= iv><div>plain-tex-mode could also be served by 'texlab'.</div><div>= <br></div><div>Jo=C3=A3o</div><div><br></div></div></div> --000000000000808aa6061e55793b--
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at 72343) by debbugs.gnu.org; 28 Jul 2024 18:21:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 28 14:21:26 2024 Received: from localhost ([127.0.0.1]:44343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sY8WM-0008PX-3O for submit <at> debbugs.gnu.org; Sun, 28 Jul 2024 14:21:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sY8WH-0008PH-CT for 72343 <at> debbugs.gnu.org; Sun, 28 Jul 2024 14:21:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sY8Vy-0003Dn-UB; Sun, 28 Jul 2024 14:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=g/wv11kOrjUWbS94gWFtpQ5gTGII7H0RsBWLgXo4EuY=; b=NyVglRc/Nf/+CZShXlqp y+djhmbltGKFKgTyyUUWaLVQS0IKi3mtGti8MwRvya2lYZq+vUXJZ/c2pPXPtfVdlPpGrALIshF49 H12Vku8/5XpB/KNwFpZFlcWvGAogZPqEz70kas3qy7dWXFLN9xQpNXy0T486Gcvy1TP96otAc5ScY y1L9zR3qCs6ChmXcHCQtM8bdunBI1MMI84ycAVtV5DFwXWcnpdhqbpyBOyhZXRkbkGmfU0abJf6HN Xhw+YRXJ9RiMiQtSF/YRBuRRzwcH6vqDAL5UVN3wUVdkujTtM1YSrZUYLlp/WL+pCTvV+rS2jcLSx lrJT0jRc7SrMCg==; Date: Sun, 28 Jul 2024 21:20:59 +0300 Message-Id: <86msm1z8c4.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Augusto Stoffel <arstoffel@HIDDEN>, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> In-Reply-To: <87sevtz8xg.fsf@HIDDEN> (message from Augusto Stoffel on Sun, 28 Jul 2024 20:08:11 +0200) Subject: Re: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes References: <87sevtz8xg.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72343 Cc: 72343 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Augusto Stoffel <arstoffel@HIDDEN> > Date: Sun, 28 Jul 2024 20:08:11 +0200 > > I noticed Eglot currently sends the languageId "tex" in all TeX-derived > modes, which is not correct; it should be "latex", "bibtex", etc. > > See the attached patch for a fix. João, any objections to installing this on the emacs-30 release branch? > >From 754127ad8bfa6ade7fe9a836df2a8bea75d711ea Mon Sep 17 00:00:00 2001 > From: Augusto Stoffel <arstoffel@HIDDEN> > Date: Sun, 28 Jul 2024 20:03:35 +0200 > Subject: [PATCH] Fix eglot-server-programs for TeX modes > > * lisp/progmodes/eglot.el (eglot-server-programs): Add a dedicated entry > to each TeX format, since the languageId passed to the server is derived > from it. > --- > lisp/progmodes/eglot.el | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 5845aff39b7..ea60b5d9a72 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -292,8 +292,11 @@ eglot-server-programs > (scala-mode . ,(eglot-alternatives > '("metals" "metals-emacs"))) > (racket-mode . ("racket" "-l" "racket-langserver")) > - ((tex-mode context-mode texinfo-mode bibtex-mode) > - . ,(eglot-alternatives '("digestif" "texlab"))) > + (plain-tex-mode "digestif") > + (latex-mode . ,(eglot-alternatives '("digestif" "texlab"))) > + (context-mode "digestif") > + (texinfo-mode "digestif") > + (bibtex-mode . ,(eglot-alternatives '("digestif" "texlab"))) > (erlang-mode . ("erlang_ls" "--transport" "stdio")) > ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) > (nix-mode . ,(eglot-alternatives '("nil" "rnix-lsp" "nixd"))) > -- > 2.45.2 >
bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 28 Jul 2024 18:08:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 28 14:08:34 2024 Received: from localhost ([127.0.0.1]:44337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sY8Jt-00086G-KZ for submit <at> debbugs.gnu.org; Sun, 28 Jul 2024 14:08:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:51588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arstoffel@HIDDEN>) id 1sY8Jr-000868-MQ for submit <at> debbugs.gnu.org; Sun, 28 Jul 2024 14:08:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <arstoffel@HIDDEN>) id 1sY8Je-0006ZP-AX for bug-gnu-emacs@HIDDEN; Sun, 28 Jul 2024 14:08:19 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <arstoffel@HIDDEN>) id 1sY8Jc-000186-Nf for bug-gnu-emacs@HIDDEN; Sun, 28 Jul 2024 14:08:18 -0400 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-58ef19aa69dso3300516a12.3 for <bug-gnu-emacs@HIDDEN>; Sun, 28 Jul 2024 11:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722190094; x=1722794894; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=mGX35noVc9ebmNVKIN6zgR+mZTRVSkPyGxiZ/akgPNo=; b=W95K6w3MXD6ngyjo7And2B2fkOS2ePMT3Ig05EzIhXio3Mn4bY21qF0UfJT4OsdkJk NtbZj4yDalxjw1oEwe9j1FzUBEFN2bKeJVuOZfvWLY5qhphLSw5tF4ju2SbQMHrtl5hZ td7oi1IYrGMKXlgoWKufFlutQ4Zslt0ElBIwSPlz1/7nuR6EmOQb9VoKa0Wj+0GyuJib 48NQTjjng4fPKPhBBDESZ/ITK4JfYGQAOiTAer6ShGaDWsN2TX/6afrqwweaAupG+nNh 68Z/5JM9ntzrTECCOB6VlR+THQxmNFACBQwe9aneq3cW8Q6lSr30R+hbapi7q4PWqNX8 Z8Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722190094; x=1722794894; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mGX35noVc9ebmNVKIN6zgR+mZTRVSkPyGxiZ/akgPNo=; b=gawFg01UDZMKd1WCu84+EuPOOLf5RC1cr5QU2d5xzScOybnh08ox3zMFDGI1jTuAt2 SKl6gHj1No0ZwYo66czpXWR0AVQbvGmkWS0tQxzQ1pYE3grg6h32PBusSPgeRkSJd9zp KD7Snwf9UcD6PqvDGmSagqf1RuU8amZ8d31eK1vad0Jsk9UB8Aa4BDHHaQPslMlIHrap AfLJICa1/qZkO/ILYxBy4ylGGL2Wh2bYtvOjmfsWesGZ7lp+woUAsYxJIPYMNdnrXHRg dY+niDziDe+EnzOXWJP8PwFF90eM3LpJ0pIp0L7Jx3YFMRyl95N4xjWvhzQHhh3/VB6R a2sA== X-Gm-Message-State: AOJu0YzRLmfgYzeLtcy23+4plg+URizy3BcUY7jgzIob1nnTcEt76RyK omVAzuVGUykgk2DgoLdZPOOxxw7UwfJRcxvq5Xya2h1WvCeXMUPImdGK3g== X-Google-Smtp-Source: AGHT+IHb9sl+ilfqEb46112f96NHK0isoLJkKgy99mGMXUBDyN6jutLz14VNgImXewbXROf2kZeG6w== X-Received: by 2002:a50:d542:0:b0:5a1:225b:4233 with SMTP id 4fb4d7f45d1cf-5b021f0d886mr3519241a12.23.1722190093486; Sun, 28 Jul 2024 11:08:13 -0700 (PDT) Received: from ars3 ([2a02:8109:8a87:ff00::e354]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac6578356csm4692587a12.87.2024.07.28.11.08.12 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jul 2024 11:08:12 -0700 (PDT) From: Augusto Stoffel <arstoffel@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH] Fix eglot-server-programs for TeX modes Date: Sun, 28 Jul 2024 20:08:11 +0200 Message-ID: <87sevtz8xg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=arstoffel@HIDDEN; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch I noticed Eglot currently sends the languageId "tex" in all TeX-derived modes, which is not correct; it should be "latex", "bibtex", etc. See the attached patch for a fix. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-eglot-server-programs-for-TeX-modes.patch From 754127ad8bfa6ade7fe9a836df2a8bea75d711ea Mon Sep 17 00:00:00 2001 From: Augusto Stoffel <arstoffel@HIDDEN> Date: Sun, 28 Jul 2024 20:03:35 +0200 Subject: [PATCH] Fix eglot-server-programs for TeX modes * lisp/progmodes/eglot.el (eglot-server-programs): Add a dedicated entry to each TeX format, since the languageId passed to the server is derived from it. --- lisp/progmodes/eglot.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 5845aff39b7..ea60b5d9a72 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -292,8 +292,11 @@ eglot-server-programs (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs"))) (racket-mode . ("racket" "-l" "racket-langserver")) - ((tex-mode context-mode texinfo-mode bibtex-mode) - . ,(eglot-alternatives '("digestif" "texlab"))) + (plain-tex-mode "digestif") + (latex-mode . ,(eglot-alternatives '("digestif" "texlab"))) + (context-mode "digestif") + (texinfo-mode "digestif") + (bibtex-mode . ,(eglot-alternatives '("digestif" "texlab"))) (erlang-mode . ("erlang_ls" "--transport" "stdio")) ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio")) (nix-mode . ,(eglot-alternatives '("nil" "rnix-lsp" "nixd"))) -- 2.45.2 --=-=-=--
Augusto Stoffel <arstoffel@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#72343
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.