GNU logs - #72395, boring messages

Message sent to guix@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#72395] [PATCH] syscalls: Support musl libc in openpty and login-tty
Resent-From: soeren@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN
Resent-Date: Wed, 31 Jul 2024 09:44:02 +0000
Resent-Message-ID: <handler.72395.B.172241901910774 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72395 <at> debbugs.gnu.org
Cc: guix@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN
From: soeren@HIDDEN
Date: Wed, 31 Jul 2024 11:41:58 +0200
Message-ID: <ecdbe1915ce12e411816a7da2b59d48a6619630d.1722418917.git.soeren@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=45.76.88.171;
 envelope-from=soeren@HIDDEN; helo=magnesium.8pit.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

From: Sören Tempel <soeren@HIDDEN>

Contrary to glibc, musl does not define the openpty and login-tty
function in libutil.so. In fact, libutil.so does not exist on musl-based
Linux distributions.  Therefore, on musl-based systems we don't have
to pass any #:library keyword argument to syscall->procedure.
---
 guix/build/syscalls.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm
index 39bcffd516..b92b6955a4 100644
--- a/guix/build/syscalls.scm
+++ b/guix/build/syscalls.scm
@@ -2382,8 +2382,10 @@ (define terminal-string-width
         string-length)))                      ;using a statically-linked Guile
 
 (define openpty
-  (let ((proc (syscall->procedure int "openpty" '(* * * * *)
-                                  #:library "libutil")))
+  (let ((proc (if musl-libc?
+                (syscall->procedure int "openpty" '(* * * * *)
+                                    #:library "libutil")
+                (syscall->procedure int "openpty" '(* * * * *)))))
     (lambda ()
       "Return two file descriptors: one for the pseudo-terminal control side,
 and one for the controlled side."
@@ -2404,8 +2406,10 @@ (define openpty
           (values (* head) (* inferior)))))))
 
 (define login-tty
-  (let* ((proc (syscall->procedure int "login_tty" (list int)
-                                   #:library "libutil")))
+  (let* ((proc (if musl-libc?
+                 (syscall->procedure int "login_tty" (list int)
+                                     #:library "libutil")
+                 (syscall->procedure int "login_tty" (list int)))))
     (lambda (fd)
       "Make FD the controlling terminal of the current process (with the
 TIOCSCTTY ioctl), redirect standard input, standard output and standard error

base-commit: 01d4363168ed10ea223047f7a7b83201f161ec0b

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: soeren@HIDDEN
Subject: bug#72395: Acknowledgement ([PATCH] syscalls: Support musl libc
 in openpty and login-tty)
Message-ID: <handler.72395.B.172241901910774.ack <at> debbugs.gnu.org>
References: <ecdbe1915ce12e411816a7da2b59d48a6619630d.1722418917.git.soeren@HIDDEN>
X-Gnu-PR-Message: ack 72395
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 72395 <at> debbugs.gnu.org
Date: Wed, 31 Jul 2024 09:44:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  guix@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, zimon.=
toutoune@HIDDEN, me@HIDDEN
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 72395 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72395: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72395
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#72395] [PATCH] syscalls: Support musl libc in openpty and login-tty
Resent-From: Z572 <zhengjunjie@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 01 Aug 2024 16:05:01 +0000
Resent-Message-ID: <handler.72395.B72395.17225282722325 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: soeren@HIDDEN
Cc: dev@HIDDEN, me@HIDDEN, zimon.toutoune@HIDDEN, othacehe@HIDDEN, ludo@HIDDEN, 72395 <at> debbugs.gnu.org, guix@HIDDEN
From: Z572 <zhengjunjie@HIDDEN>
In-Reply-To: <ecdbe1915ce12e411816a7da2b59d48a6619630d.1722418917.git.soeren@HIDDEN>
 (soeren@HIDDEN's message of "Wed, 31 Jul 2024 11:41:58 +0200")
References: <ecdbe1915ce12e411816a7da2b59d48a6619630d.1722418917.git.soeren@HIDDEN>
Date: Fri, 02 Aug 2024 00:03:29 +0800
Message-ID: <87h6c4w7qm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

soeren@HIDDEN writes:

> From: S=C3=B6ren Tempel <soeren@HIDDEN>
>
> Contrary to glibc, musl does not define the openpty and login-tty
> function in libutil.so. In fact, libutil.so does not exist on musl-based
> Linux distributions.  Therefore, on musl-based systems we don't have
> to pass any #:library keyword argument to syscall->procedure.
> ---
>  guix/build/syscalls.scm | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm
> index 39bcffd516..b92b6955a4 100644
> --- a/guix/build/syscalls.scm
> +++ b/guix/build/syscalls.scm
> @@ -2382,8 +2382,10 @@ (define terminal-string-width
>          string-length)))                      ;using a statically-linked=
 Guile
>=20=20
>  (define openpty
> -  (let ((proc (syscall->procedure int "openpty" '(* * * * *)
> -                                  #:library "libutil")))
> +  (let ((proc (if musl-libc?
> +                (syscall->procedure int "openpty" '(* * * * *)
> +                                    #:library "libutil")
> +                (syscall->procedure int "openpty" '(* * * * *)))))
>      (lambda ()
>        "Return two file descriptors: one for the pseudo-terminal control =
side,
>  and one for the controlled side."
> @@ -2404,8 +2406,10 @@ (define openpty
>            (values (* head) (* inferior)))))))
>=20=20
>  (define login-tty
> -  (let* ((proc (syscall->procedure int "login_tty" (list int)
> -                                   #:library "libutil")))
> +  (let* ((proc (if musl-libc?
> +                 (syscall->procedure int "login_tty" (list int)
> +                                     #:library "libutil")
> +                 (syscall->procedure int "login_tty" (list int)))))
>      (lambda (fd)
>        "Make FD the controlling terminal of the current process (with the
>  TIOCSCTTY ioctl), redirect standard input, standard output and standard =
error
>
> base-commit: 01d4363168ed10ea223047f7a7b83201f161ec0b

see syscall->procedure definition:

```
(define* (syscall->procedure return-type name argument-types
                             #:key library)
  "Return a procedure that wraps the C function NAME using the dynamic FFI,
and that returns two values: NAME's return value, and errno.  When LIBRARY =
is
specified, look up NAME in that library rather than in the global symbol na=
me
space.

If an error occurs while creating the binding, defer the error report until
the returned procedure is called."
  (catch #t
    (lambda ()
      ;; Note: When #:library is set, try it first and fall back to libc
      ;; proper.  This is because libraries like libutil.so have been subsu=
med
      ;; by libc.so with glibc >=3D 2.34.
      (let ((ptr (dynamic-func name
                               (if library
                                   (or (false-if-exception
                                        (dynamic-link library))
                                       (dynamic-link))
                                   (dynamic-link)))))
        ;; The #:return-errno? facility was introduced in Guile 2.0.12.
        (pointer->procedure return-type ptr argument-types
                            #:return-errno? #t)))
    (lambda args
      (lambda _
        (throw 'system-error name  "~A" (list (strerror ENOSYS))
               (list ENOSYS))))))
```

In my understanding, when we can't find libutil, will try to find it in
libc. Do you have any problems using it?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmarsdEACgkQO1qpk+Gi
3/CvHRAAoJgg6EQZg5bWbEgoMwm9Kk5pQX9AAlvNtDlrtr81SpzrLtdH6M8RNGdG
PluLjMHApbMVrBXowHS7aUdEc4yP+cX1J4Zo+90YxxrJigmCE+YWFS3fbTJxSBJ9
ZSfa6aPHSH8YcgcrUnHJEDhyOr/FRuArOq2NYZtVOz2jV2z/VEdWdM6HQ/2tiGPh
pRceK0IDS25Q6VqgzLHZtnLaNpVrzwciU1m4CHfAZs+aUsVT/IvxTJUlrbW23Jzz
SU0J1dr+Nltxw6r6Ogx3nu592bP8PHCpDPOJSnoGhWqOU3vAhDJ7MlBb9K4xsT4w
MHNxiQDWXOsl72LbhjHdu/2p/7f8w/lG9Q4KrL9o1STP2/smR2cn+cYgACUKua4e
M5Qgq/9vJNUPEFmckP6Y60NNIm2FODn93F+Ovs5DhZHWuz3sy3htM1yMPm5JU5sy
MBrBml18qkvoIfqOPQRb5tZKuU2Oo8Rgvt65QbobX9IX+zgEMcMsT4/TKsJ+q+W5
54rp94JaD8SdWTqCVIq4IXfvIuh29IaVv1qXXTxpAabXUD5xRaiDjLlZvBY0TM6E
TfxH5+Xd5pB6vDcnV7COfpe7UWZIVeBgwKWW/2jGP/Mgk7z74pwksIh5afBfqW9m
MfzPsQGHVCk8I4SdkwmrquU06uzEKf9Xh12zxgfXr3C5ZueZ//k=
=ySI7
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

Subject: [bug#72395] [PATCH] syscalls: Support musl libc in openpty and login-tty
Resent-From: =?UTF-8?Q?S=C3=B6ren?= Tempel <soeren@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 03 Aug 2024 10:40:02 +0000
Resent-Message-ID: <handler.72395.B72395.17226815782305 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Z572 <zhengjunjie@HIDDEN>
Cc: dev@HIDDEN, me@HIDDEN, zimon.toutoune@HIDDEN, othacehe@HIDDEN, ludo@HIDDEN, 72395 <at> debbugs.gnu.org, guix@HIDDEN
Date: Fri, 03 Aug 2024 12:38:36 +0200
From: =?UTF-8?Q?S=C3=B6ren?= Tempel <soeren@HIDDEN>
References: <ecdbe1915ce12e411816a7da2b59d48a6619630d.1722418917.git.soeren@HIDDEN>
 <87h6c4w7qm.fsf@HIDDEN>
In-Reply-To: <87h6c4w7qm.fsf@HIDDEN>
Message-Id: <2LJ9T2UGSZRU4.2KSFZPMA47XMM@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi!

Z572 <zhengjunjie@HIDDEN> wrote:
> In my understanding, when we can't find libutil, will try to find it in
> libc. Do you have any problems using it?

Yea, for example consider the invocation `guix import pypi cart`.
Without this patch, this emits the following error message for me
on Alpine Linux Edge (a musl-based Linux distribution):

	guix import: error: no source release for pypi package cart 1.2.2

	hint: Backtrace:
	In ice-9/boot-9.scm:
	  1685:16 19 (raise-exception _ #:continuable? _)
	In guix/ui.scm:
	   867:16 18 (_ _)
	   340:43 17 (display-hint "This indicates that the\npackage is a=C3=A2=
=E2=82=AC=C2=A6" . #)
	In ice-9/boot-9.scm:
	  1747:15 16 (with-exception-handler #<procedure 7f8c8f9b2660 at ic=C3=A2=
=E2=82=AC=C2=A6> =C3=A2=E2=82=AC=C2=A6)
	  3474:28 15 (_)
	  3327:17 14 (resolve-interface (guix build syscalls) #:select _ # _ =C3=A2=
=E2=82=AC=C2=A6)
	In ice-9/threads.scm:
	    390:8 13 (_ _)
	In ice-9/boot-9.scm:
	  3253:13 12 (_)
	In ice-9/threads.scm:
	    390:8 11 (_ _)
	In ice-9/boot-9.scm:
	  3544:20 10 (_)
	   2836:4  9 (save-module-excursion #<procedure 7f8c8f9b2600 at ice-=C3=A2=
=E2=82=AC=C2=A6>)
	  3564:26  8 (_)
	In unknown file:
		   7 (primitive-load-path "guix/build/syscalls" #<procedure =C3=A2=E2=82=AC=
=C2=A6>)
	In guix/build/syscalls.scm:
	  2385:14  6 (_)
	In ice-9/boot-9.scm:
	  1747:15  5 (with-exception-handler #<procedure 7f8c8fa3b270 at ic=C3=A2=
=E2=82=AC=C2=A6> =C3=A2=E2=82=AC=C2=A6)
	In guix/build/syscalls.scm:
	   456:39  4 (_)
	In ice-9/boot-9.scm:
	  1747:15  3 (with-exception-handler #<procedure 7f8c8fa3b240 at ic=C3=A2=
=E2=82=AC=C2=A6> =C3=A2=E2=82=AC=C2=A6)
	In unknown file:
		   2 (dynamic-link "libutil")
	In system/foreign-library.scm:
	   190:25  1 (load-foreign-library _ #:extensions _ # _ #:search-path =C3=A2=
=E2=82=AC=C2=A6)
	In unknown file:
		   0 (dlopen "libutil.so" 1)

	ERROR: In procedure dlopen:
	In procedure dlopen: file "libutil.so", message "libutil.so: cannot open s=
hared object file: No such file or directory"

With this patch applied, I instead get:

	guix import: error: no source release for pypi package cart 1.2.2

	hint: This indicates that the package is available on PyPI, but only as a =
"wheel" containing
	binaries, not source.  To build it from source, refer to the upstream repo=
sitory at
	`https://github.com/CybercentreCanada/cart'.

I assume the fallback code in syscall->procedure does not work correctly
then and the "correct fix" would be to fix this fallback code?

Greetings,
S=C3=B6ren

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.