Björn Bidar <bjorn.bidar@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Received: (at 72526) by debbugs.gnu.org; 8 Jan 2025 02:58:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 07 21:58:05 2025 Received: from localhost ([127.0.0.1]:45418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tVMGi-0007be-KU for submit <at> debbugs.gnu.org; Tue, 07 Jan 2025 21:58:04 -0500 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:59453) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tVMGg-0007bD-0H for 72526 <at> debbugs.gnu.org; Tue, 07 Jan 2025 21:58:03 -0500 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-aaec111762bso2666995766b.2 for <72526 <at> debbugs.gnu.org>; Tue, 07 Jan 2025 18:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736305080; x=1736909880; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=DBywJ1GI0eNkVo2KWzIkBdkahuupDhEvZRH0+iV0Mmc=; b=ifoP5K0NZCSVkDLdy+E1tUJcCrgJ7cIgZgYyumXXD9em0xZrznPbwoqQLwkhjtmqPt E/WKmlimA8kZR1mnFhfw6/pWITMcc0/zPTob9m/hIdTAJ87g+QcVZHEEph34FfYyY8c9 JTDyVMTrI+t+x7Ix8yq+iaWOZW9m4EaAj3+IU2kyGo7Wq3afhtG33WblubBHs9MTYn7c BON/JOU3VDCtDIgo0SIj0SwnH0a8yVKSj+3lneyGh8a2Tgge3MOXOMlXUs0mPYpzFYXo 991Aqytiyev+eGesmadHZ3dnIyspsjpHd08tEP8brXTSzds01yvc0kRXhwyqW4OsaGvW /GiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736305080; x=1736909880; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DBywJ1GI0eNkVo2KWzIkBdkahuupDhEvZRH0+iV0Mmc=; b=iaLy9J95a246vSj8zo5LJlaTvTw9EqqKSL+BIIQQTxYcoAD+oeRlnzRd4PSBQ9VyVt vLb1xppsb1+RSDypqCV9s5uQd7o9oegkJ48rOzVjublmrabnjpsjTpLfO4dWfJDisJZX 27K4DDbQ9blpI8DhNHeSgIg1VyxyF0INUT+dTGPJDPqQm5I26Egl0vIptTTBHxXRDuMH pA9n5J01JcQky1e2B6XSEDrP4hZ0m7dq0ipFYWWDkynhopBU+uRp6DQXFK5v45J4fNCC usntuzCuXyznNSpww/hz/ZDcVJo7iJ5AtyoedVZ5/eKPeRoYl8csqx1WFGFf3Rzf0UqH vjuQ== X-Forwarded-Encrypted: i=1; AJvYcCUrFJN7ZbgM55IDOzFfmoMozAMifaKCJzZq1JYmVEFk19kAMMQriSIPU9g1bV1Wfpvq/dbcXg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzOe3y7J82bBl7YCDmZRmNR0Ecb5YTsyikQvgfVbZc/eGoNxOHj KiItFSo0HnkDi5cLhTYnhh7CVQz4coV86PlANBlwBP48Uk9wezq4HmcHkTRrxQrnfahstoo9EQ4 OEBaOQcHUdyiuNr92TyftSguvhEk= X-Gm-Gg: ASbGncsVv2zuK3abrLHl24A9JT7TNSemAdhowik4XYqotK4Z1D/hbYl71LQ/pHsf8Qi otBEFYJE1WOYi2Klb8KwNFUzq1k5cWowCnAxAG3XF X-Google-Smtp-Source: AGHT+IFtPR/TmYc6fJNm/d3SPdTepFnY56l5Uf22PxRmuazh76wOrMNSss+Gg57YbhUBYVZODmNipQx9kYy8TnA0jQ4= X-Received: by 2002:a17:907:7286:b0:aa6:89b9:e9c0 with SMTP id a640c23a62f3a-ab2ab6a7624mr77995266b.8.1736305080265; Tue, 07 Jan 2025 18:58:00 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 7 Jan 2025 20:57:59 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <51798334680bb9a85ab586eba92afb88a1446c8c.camel@HIDDEN> References: <51798334680bb9a85ab586eba92afb88a1446c8c.camel@HIDDEN> MIME-Version: 1.0 Date: Tue, 7 Jan 2025 20:57:59 -0600 X-Gm-Features: AbW1kvbq4ApgQ3u_5bYwDwFPrj2Ynnx7_VE37i35cwi1LxCWWlcMmjujAtwwJYE Message-ID: <CADwFkmkg4Yx5yBdTJbwkHtCFeYAV2qX+djBXjS8FpWotDb2ZSQ@HIDDEN> Subject: Re: bug#72526: Needs NEWS item and doc change To: Tim Ruffing <dev@HIDDEN>, 72526 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72526 Cc: =?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Tim Ruffing <dev@HIDDEN> writes: > I think the first patch (commit a7a22e7) is a good change, but it > should get a NEWS item because it breaks existing configurations. > > If you had this in your netrc file: > machine www.example.com:443 port https login foo password bar > Then it needs to be changed to: > machine www.example.com port https login foo password bar > > See https://github.com/dengste/org-caldav/issues/320 for reports of > people running into this. This is true not only for netrc files but > also for other authinfo backends. (For example, I've run into this > issue with the GNOME keyring / Secret Service API.) > > Moreover, the docs need to be updated. doc/misc/auth.texi has an > example that uses `yourmachine.com:80`. This should be changed to > `yourmachine.com`. (Or better, `example.com` or some domain reserved > for documentation, see=C2=A0https://www.iana.org/help/example-domains ). Bj=C3=B6rn, could you please take a look at this?
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.
Received: (at 72526) by debbugs.gnu.org; 7 Jan 2025 23:24:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 07 18:24:24 2025
Received: from localhost ([127.0.0.1]:45168 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tVIvw-0005hv-8Y
for submit <at> debbugs.gnu.org; Tue, 07 Jan 2025 18:24:24 -0500
Received: from mout-p-201.mailbox.org ([80.241.56.171]:40060)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <dev@HIDDEN>)
id 1tVIvs-0005hh-Ql
for 72526 <at> debbugs.gnu.org; Tue, 07 Jan 2025 18:24:22 -0500
Received: from smtp202.mailbox.org (smtp202.mailbox.org
[IPv6:2001:67c:2050:b231:465::202])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4YSRvc3vLMz9sTm
for <72526 <at> debbugs.gnu.org>; Wed, 8 Jan 2025 00:24:12 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=real-or-random.org;
s=MBO0001; t=1736292252;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=r5laPXBkgwB1z7ckGaZpveNv56Z4x5gVfXWYB2WMBqM=;
b=uO78HEfQI+yk0ITM4QAv/mMwFOVJMCwuxrjGt+R4JUNukYKZIBl70u6tmFXJiuBzF8VrWY
0FsYOMBG4AIpJ+4W1u6EDzgRKoyYWKC5n+5dR16+A7ULYxXs017stlflIV7/dFA1nDYzve
NEnYkMd+mhwyA/rvEs0wGyBnn6sqm57urteK4FS919qYXz+M2ZGrvCik96SdPWpn+Bb/+J
xt3OUxqNp8z5ekluaPp+Vo0LVG4nTHOBWLw3kSVpiPc9TnCtDAu1LVVSeFxOHhfMMvLjrs
JLNPanKFep+jT6nNpIO/88sChGQt/qlZ95zuAaYeA34hnHWkM336A5xmLPvcyA==
Message-ID: <51798334680bb9a85ab586eba92afb88a1446c8c.camel@HIDDEN>
Subject: Needs NEWS item and doc change
From: Tim Ruffing <dev@HIDDEN>
To: 72526 <at> debbugs.gnu.org
Date: Wed, 08 Jan 2025 00:24:09 +0100
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Rspamd-Queue-Id: 4YSRvc3vLMz9sTm
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 72526
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
I think the first patch (commit a7a22e7) is a good change, but it
should get a NEWS item because it breaks existing configurations.
If you had this in your netrc file:
machine www.example.com:443 port https login foo password bar
Then it needs to be changed to:
machine www.example.com port https login foo password bar
See https://github.com/dengste/org-caldav/issues/320 for reports of
people running into this. This is true not only for netrc files but
also for other authinfo backends. (For example, I've run into this
issue with the GNOME keyring / Secret Service API.) =20
Moreover, the docs need to be updated. doc/misc/auth.texi has an
example that uses `yourmachine.com:80`. This should be changed to
`yourmachine.com`. (Or better, `example.com` or some domain reserved
for documentation, see=C2=A0https://www.iana.org/help/example-domains ). =
=20
Best,
Tim
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Tim Ruffing <dev@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Received: (at 72526) by debbugs.gnu.org; 26 Aug 2024 11:17:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 26 07:17:21 2024 Received: from localhost ([127.0.0.1]:43812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1siXir-0001PF-MH for submit <at> debbugs.gnu.org; Mon, 26 Aug 2024 07:17:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1siXiq-0001P1-CW for 72526 <at> debbugs.gnu.org; Mon, 26 Aug 2024 07:17:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1siXfn-0002qF-Uf; Mon, 26 Aug 2024 07:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cq1AMI7PsjAiYgJDRqNMkPmTvTst8VYgyKTdHYZTDH4=; b=V7dqm4Rvs4sAzf+mPCWT 2hutEOSdioA6wfTMa8hwIYsrdLuVX13L9KGNxwowplt16RCwNC02dsBHakNQOE4CivQ5A7ReFtv/M 6d6arfbfue9aw2SIFJhkBbE1ujj75ocx+RcHyMhhc7cWrWU+/XXM2cywv2/C+fN4ntqYRoAj2524v JAyLTWYrpSEl7wpN4FJxagkni1aP0KscFwERo1ydDNLvs1B3WvvXcPHfGcxT06GKYBwG789A2PlA/ qtAwMm2BAEvUuTNwiIDdID04oengV5DlUFp8wMezW9yzPtL4nAHuXXsi6vi2ziqMv4UDn0YSizhvg bQhPXGYozlCedw==; Date: Mon, 26 Aug 2024 14:14:08 +0300 Message-Id: <86plpvk03j.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?iso-8859-1?Q?Bj=F6rn?= Bidar <bjorn.bidar@HIDDEN> In-Reply-To: <87h6b7byzb.fsf@> (message from =?iso-8859-1?Q?Bj=F6rn?= Bidar on Mon, 26 Aug 2024 09:05:28 +0300) Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN> <867cce1ke4.fsf@HIDDEN> <86ikvyynwg.fsf@HIDDEN> <86bk1invo7.fsf@HIDDEN> <86r0aem6cj.fsf@HIDDEN> <87h6b7byzb.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72526 Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Bidar <bjorn.bidar@HIDDEN> > Cc: 72526 <at> debbugs.gnu.org > Date: Mon, 26 Aug 2024 09:05:28 +0300 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> > Thanks, so I installed the patch on the master branch, and I'm now > >> > closing this bug. > >> > >> Would it make sense to apply it to Emacs 30.1 too? > > > > It's too late for behavior changes on the release branch, sorry. > > > IMHO it's more a bugfix than a plain behavior change, but ok for me. It fixes a bug by changing behavior.
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at 72526) by debbugs.gnu.org; 26 Aug 2024 06:06:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 26 02:06:30 2024 Received: from localhost ([127.0.0.1]:43565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1siSs1-0000rg-Tf for submit <at> debbugs.gnu.org; Mon, 26 Aug 2024 02:06:30 -0400 Received: from thaodan.de ([185.216.177.71]:60286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1siSrz-0000rM-9r for 72526 <at> debbugs.gnu.org; Mon, 26 Aug 2024 02:06:28 -0400 Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154]) by thaodan.de (Postfix) with ESMTPSA id 115A5D00063; Mon, 26 Aug 2024 09:05:30 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1724652330; bh=PfuKbu9NCcpG3XLXfdQmXsuwz8aGt194TdaymqE/cx0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=E7yMfu4KgqyLmyIckTeWNUGTk5TjNsZlCkQTfVP5h/BSiJemuUN4SaEsFIrABKTYR yE8qJNugGW4JuDO9B2I777LCZ2xONL9m1FMG5CHzI2HUk0uEigUwwapKN8YtkJOwLF e/jAU4P94fB3iRp9r+21/Y8i9uguxzj2QsJNG8tSPfDCSXb18Pd5TpKQyXCElAx4lI RI2o9RAMycS9Wn7tvSIkl5+qoSgOB2xoK2AHFid+RJKzVmlW70ZwfW5Ph9kIcway8P VPnNwUQ/N0+/VbDKBMnHpHwsR2ImggfouqrEB4LeM6XaObahee+wvW2QD8GwX+XY5p iMzxCoFGjdtDM0WIR7DHtf2KdnkgXDaoLrDQHzA5W6m7sqFwj666/9U+so2A94gsTg NhRyzlQUfs+oVdrjQ0yLijRSdTozMUz2XL4BzvXUEqeF/uKDM9/wsxya5D6uwt8TQ7 Xx54imlX3kC+Wyzuc311xSaY6DOfhDI5vrm9LdSuEPiZJeGn/eVdmVLYq5oWYKG+kh IzS/SUI6VO1M/ZC00N1FJzYiF1WDudBVbpZyXMzzrn6Rwkcs7044/pmzhNVfd06ofA lTb3/ehmxYUATRqY/830uORYtgghdi8eD818IlugcCghMoQFAfyq9qS236iwXy/4EX asnMCk+AjMNsFsh+gzaiiV3M= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port In-Reply-To: <86r0aem6cj.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 24 Aug 2024 15:51:40 +0300") References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN> <867cce1ke4.fsf@HIDDEN> <86ikvyynwg.fsf@HIDDEN> <86bk1invo7.fsf@HIDDEN> <86r0aem6cj.fsf@HIDDEN> Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Mon, 26 Aug 2024 09:05:28 +0300 Message-ID: <87h6b7byzb.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> > Thanks, so I installed the patch on the master branch, and I'm now >> > closing this bug. >> >> Would it make sense to apply it to Emacs 30.1 too? > > It's too late for behavior changes on the re [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 72526 Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) Eli Zaretskii <eliz@HIDDEN> writes: >> > Thanks, so I installed the patch on the master branch, and I'm now >> > closing this bug. >> >> Would it make sense to apply it to Emacs 30.1 too? > > It's too late for behavior changes on the release branch, sorry. > IMHO it's more a bugfix than a plain behavior change, but ok for me. >> What about the other patch? Should :user only be passed to >> auth-source-search if there was a user in the url for the patch to be >> ok? > > Sorry, forgot to push that. Done now. Thanks
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at 72526) by debbugs.gnu.org; 24 Aug 2024 12:52:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 24 08:52:41 2024 Received: from localhost ([127.0.0.1]:40680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1shqG1-0005r3-4a for submit <at> debbugs.gnu.org; Sat, 24 Aug 2024 08:52:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1shqFy-0005qm-1T for 72526 <at> debbugs.gnu.org; Sat, 24 Aug 2024 08:52:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1shqF5-0004WC-Gv; Sat, 24 Aug 2024 08:51:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=z5MoubkGEvEXIGjf5KUKvOFbH14W4jRnoOe+HCvO96U=; b=rJOVllou7ScwulbSZl5B SgM2kSbTbcDR8c59jwOjynOEvueIC4uTU7PK9iwUeKrA0n4+47GOILjG8SB7Zn2uO/FmzWp2gR44R Sz3l3QKR2faHWJdAA4+RQchhtpIWRcuQlibOJKjuAu2wkepYfI8bmpPhtrpxxEwLBs5DzSZ3AbUYK PhUurDYB+w8leyYPp8lWm4fhHhRLy4CBOFMaUrLE4YfUmWYvzXRylGq83bmh2US0tpQz8Ux0+1uDm YPKaRa72IBmNAqF+UabxyHxZoDPeDRBKR7ijFErkG9ij81G0VRe7axBe7auML5TQfcZdiFZNZmkDd s2ItI/pldHAz9g==; Date: Sat, 24 Aug 2024 15:51:40 +0300 Message-Id: <86r0aem6cj.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> In-Reply-To: <87y14mb07y.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Sat, 24 Aug 2024 14:59:29 +0300) Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN> <867cce1ke4.fsf@HIDDEN> <86ikvyynwg.fsf@HIDDEN> <86bk1invo7.fsf@HIDDEN> <87y14mb07y.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72526 Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Bidar <bjorn.bidar@HIDDEN> > Cc: 72526-done <at> debbugs.gnu.org > Date: Sat, 24 Aug 2024 14:59:29 +0300 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> From: Björn Bidar <bjorn.bidar@HIDDEN> > >> Cc: 72526 <at> debbugs.gnu.org > >> Date: Mon, 19 Aug 2024 09:54:09 +0300 > >> > >> Eli Zaretskii <eliz@HIDDEN> writes: > >> > >> >> From: Björn Bidar <bjorn.bidar@HIDDEN> > >> >> Cc: 72526 <at> debbugs.gnu.org > >> >> Date: Sun, 18 Aug 2024 15:30:22 +0300 > >> >> > >> >> Eli Zaretskii <eliz@HIDDEN> writes: > >> >> > >> >> 1. url-basic-auth-store uses the 'server' as in the '<server>:<port>' in > >> >> url-basic-auth-storage. I did not want to change the existing format > >> >> as I don't know the implications. > >> > > >> > Can you calculate a separate variable once, and then use 'server' and > >> > that new variable, each one where appropriate? It simply doesn't look > >> > clean to recalculate the same value several times. > >> > > >> >> 2. I tested calling auth-source-search with :user nil and without :user > >> >> in both cases the result was the same, from this I imply that calling > >> >> auth-source-search with :user nil is ok. > >> > > >> > Wouldn't it be cleaner to omit :user if the value is nil? > >> > >> It would, how would one do such thing in lisp except of course > >> having two separate calls one with :user and one without :user. > >> For C it would be normal to just pass NULL if the argument is optional > >> (beginner in lisp). > >> > >> >> Yes if auth-source-search doesn't find a user for the url > >> >> url-basic-auth will prompt the user for a user. > >> >> Why is it a good idea to derive the user by url-basic-auth? > >> >> Because HTTP basic authentication uses the as specific in RFC 3986 > >> >> section 3.2.1. Using it in this function to infer the user from the > >> >> url just follows the standard as already in other programs/Emacs > >> >> packages. > >> >> If the user has specified the username they want to identify with > >> >> at the server asking for it would be redundant and not confirming to > >> >> the standard. > >> > > >> > What does the current code do in that case? Does it completely fail, > >> > or does it prompt for the username? If the latter, it would be a > >> > change in behavior, won't it? > >> > >> Currently it does ask for the user even if the caller sends the user in the > >> url. It would be change of behavior, however it is expected that the user is > >> used in HTTP basic authentication if the the url is 'http://user@host'. > >> I don't think any caller would call the function in such a way without > >> expecting that user is the username used in the call. > > > > Thanks, so I installed the patch on the master branch, and I'm now > > closing this bug. > > Would it make sense to apply it to Emacs 30.1 too? It's too late for behavior changes on the release branch, sorry. > What about the other patch? Should :user only be passed to > auth-source-search if there was a user in the url for the patch to be > ok? Sorry, forgot to push that. Done now.
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.
Received: (at 72526-done) by debbugs.gnu.org; 24 Aug 2024 12:00:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 24 08:00:28 2024
Received: from localhost ([127.0.0.1]:40655 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1shpRU-0004TV-78
for submit <at> debbugs.gnu.org; Sat, 24 Aug 2024 08:00:28 -0400
Received: from thaodan.de ([185.216.177.71]:60862)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjorn.bidar@HIDDEN>) id 1shpRR-0004TG-Hu
for 72526-done <at> debbugs.gnu.org; Sat, 24 Aug 2024 08:00:27 -0400
Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154])
by thaodan.de (Postfix) with ESMTPSA id A5642D00033;
Sat, 24 Aug 2024 14:59:30 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1724500771; bh=XwXxl6V40aEY/ryKItJ2ayrADQD2Thv57/P0nCsfJPg=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=JWqtqc4aYbzVvOtmC6qBx5IADCXnEqgWjeNQBnfOfEQmz5R6xvzxRu8ib/rXvE8d6
IfHX9lsCSQviXE/QajRUzsm50L9YODdqplglDC/PrQezUJDdwlrLgRi77PNqk8vAc+
FNElnxSD8ycW2QUJtwI0vdALVguj/5YtKGtRKpIpqMQEbI935+3uMcE7DgA2F77be0
Z+JdSd/RZcVzjsyz1YuZm/EmC7Uw0blGU/mKxaG0KRTZknq7h5UDIJwrbKN2B9ZBLY
YFhpgpKASKIJHjU32mlS0ZYFiVIzDSUjuBk7B+H1L1eq7awxinpLcgB1HZdHywPYk7
ezK4qau8+L/Qb7e1snwO50WqsPGhbxilN2hlbD2YHYb8ztq8Vj6CI6XEjd9nWNjjfh
mWgIJ8jaPEwz6qxnSqgKGyw3kDOxDbVMy8YSPtiTrxjf3Bv41E08rbhfPglPxN5+3P
YYlPgNzy/C54ze6gvBmNM0j8LO4xq53sSUsZEfdAg8mHZSYPcF8N/O5XaiMEPbB6+3
t8RrYrip1KUeWmts3OabkA0mXa3Jp8y2ufWPnL5cOyIPByZP1lKzDM25+XUlGSsq/f
+JFWzUF5Hm3sJI+DZAmNQNlaghl3G/yTFA6uSRFAP4lFWMf+YGz0faiTFdLFGhSdnH
8GP8ma6HgtmbGUnjidgoC/LU=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search
when passing username and/or port
In-Reply-To: <86bk1invo7.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 24 Aug
2024 11:59:20 +0300")
References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN>
<867cce1ke4.fsf@HIDDEN> <86ikvyynwg.fsf@HIDDEN> <86bk1invo7.fsf@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Sat, 24 Aug 2024 14:59:29 +0300
Message-ID: <87y14mb07y.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From: Björn Bidar
<bjorn.bidar@HIDDEN> >> Cc: 72526 <at> debbugs.gnu.org >> Date: Mon, 19 Aug
2024 09:54:09 +0300 >> >> Eli Zaretskii <eliz@HIDDEN> writes: >> >> >> From:
Björn Bidar <bjorn.bidar [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 72526-done
Cc: 72526-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN>
>> Cc: 72526 <at> debbugs.gnu.org
>> Date: Mon, 19 Aug 2024 09:54:09 +0300
>>=20
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>=20
>> >> From: Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN>
>> >> Cc: 72526 <at> debbugs.gnu.org
>> >> Date: Sun, 18 Aug 2024 15:30:22 +0300
>> >>=20
>> >> Eli Zaretskii <eliz@HIDDEN> writes:
>> >>=20
>> >> 1. url-basic-auth-store uses the 'server' as in the '<server>:<port>'=
in
>> >> url-basic-auth-storage. I did not want to change the existing form=
at
>> >> as I don't know the implications.
>> >
>> > Can you calculate a separate variable once, and then use 'server' and
>> > that new variable, each one where appropriate? It simply doesn't look
>> > clean to recalculate the same value several times.
>> >
>> >> 2. I tested calling auth-source-search with :user nil and without :us=
er
>> >> in both cases the result was the same, from this I imply that call=
ing
>> >> auth-source-search with :user nil is ok.
>> >
>> > Wouldn't it be cleaner to omit :user if the value is nil?
>>=20
>> It would, how would one do such thing in lisp except of course
>> having two separate calls one with :user and one without :user.
>> For C it would be normal to just pass NULL if the argument is optional
>> (beginner in lisp).
>>=20
>> >> Yes if auth-source-search doesn't find a user for the url
>> >> url-basic-auth will prompt the user for a user.
>> >> Why is it a good idea to derive the user by url-basic-auth?
>> >> Because HTTP basic authentication uses the as specific in RFC 3986
>> >> section 3.2.1. Using it in this function to infer the user from the
>> >> url just follows the standard as already in other programs/Emacs
>> >> packages.
>> >> If the user has specified the username they want to identify with
>> >> at the server asking for it would be redundant and not confirming =
to
>> >> the standard.
>> >
>> > What does the current code do in that case? Does it completely fail,
>> > or does it prompt for the username? If the latter, it would be a
>> > change in behavior, won't it?
>>=20
>> Currently it does ask for the user even if the caller sends the user in =
the
>> url. It would be change of behavior, however it is expected that the use=
r is
>> used in HTTP basic authentication if the the url is 'http://user@host'.
>> I don't think any caller would call the function in such a way without
>> expecting that user is the username used in the call.
>
> Thanks, so I installed the patch on the master branch, and I'm now
> closing this bug.
Would it make sense to apply it to Emacs 30.1 too?
What about the other patch? Should :user only be passed to
auth-source-search if there was a user in the url for the patch to be
ok?
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at 72526-done) by debbugs.gnu.org; 24 Aug 2024 09:00:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 24 05:00:23 2024 Received: from localhost ([127.0.0.1]:40452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1shmdC-0007pP-Hj for submit <at> debbugs.gnu.org; Sat, 24 Aug 2024 05:00:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1shmd9-0007p7-MD for 72526-done <at> debbugs.gnu.org; Sat, 24 Aug 2024 05:00:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1shmcG-0002GY-SE; Sat, 24 Aug 2024 04:59:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=v80PmlUXl9NBmn0+sDaOz6AqSSadN2t2gBpcktz6C3Y=; b=khkzvFRsQDElKuJ3kexz K6n5vhIHmtgBjLloHUz1KUK4nRnAQ1MhEbuHKHG4WYJGA2S2AZN9kMT9Jk18Vt4WjuFRr+PoAhj9W FMlaEXlia+XxjhBs820YKo2gyKa2CJHpEqfvyDtwGln9zODeUThLjGcstl01GogBIA7y9I8eaFClS wQ4G1jOznrZWvnf5u1BViiNXBxA2WYhfsSh5tLMdk+92cgMWXRWTTt9mv0Q5nJ/5K9JW5bPmv0uFN 3+d/luOfTXlyOTz07VTTL591ADHxW7q12JsDjWo9TnolBh3W5JArA5o+IDM6n3qQysmvIHa4JxRyP /kQDbEd01itKsw==; Date: Sat, 24 Aug 2024 11:59:20 +0300 Message-Id: <86bk1invo7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> In-Reply-To: <87zfp9q9ym.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Mon, 19 Aug 2024 09:54:09 +0300) Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN> <867cce1ke4.fsf@HIDDEN> <86ikvyynwg.fsf@HIDDEN> <87zfp9q9ym.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72526-done Cc: 72526-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Bidar <bjorn.bidar@HIDDEN> > Cc: 72526 <at> debbugs.gnu.org > Date: Mon, 19 Aug 2024 09:54:09 +0300 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> From: Björn Bidar <bjorn.bidar@HIDDEN> > >> Cc: 72526 <at> debbugs.gnu.org > >> Date: Sun, 18 Aug 2024 15:30:22 +0300 > >> > >> Eli Zaretskii <eliz@HIDDEN> writes: > >> > >> 1. url-basic-auth-store uses the 'server' as in the '<server>:<port>' in > >> url-basic-auth-storage. I did not want to change the existing format > >> as I don't know the implications. > > > > Can you calculate a separate variable once, and then use 'server' and > > that new variable, each one where appropriate? It simply doesn't look > > clean to recalculate the same value several times. > > > >> 2. I tested calling auth-source-search with :user nil and without :user > >> in both cases the result was the same, from this I imply that calling > >> auth-source-search with :user nil is ok. > > > > Wouldn't it be cleaner to omit :user if the value is nil? > > It would, how would one do such thing in lisp except of course > having two separate calls one with :user and one without :user. > For C it would be normal to just pass NULL if the argument is optional > (beginner in lisp). > > >> Yes if auth-source-search doesn't find a user for the url > >> url-basic-auth will prompt the user for a user. > >> Why is it a good idea to derive the user by url-basic-auth? > >> Because HTTP basic authentication uses the as specific in RFC 3986 > >> section 3.2.1. Using it in this function to infer the user from the > >> url just follows the standard as already in other programs/Emacs > >> packages. > >> If the user has specified the username they want to identify with > >> at the server asking for it would be redundant and not confirming to > >> the standard. > > > > What does the current code do in that case? Does it completely fail, > > or does it prompt for the username? If the latter, it would be a > > change in behavior, won't it? > > Currently it does ask for the user even if the caller sends the user in the > url. It would be change of behavior, however it is expected that the user is > used in HTTP basic authentication if the the url is 'http://user@host'. > I don't think any caller would call the function in such a way without > expecting that user is the username used in the call. Thanks, so I installed the patch on the master branch, and I'm now closing this bug.
Björn Bidar <bjorn.bidar@HIDDEN>:Eli Zaretskii <eliz@HIDDEN>:
Received: (at 72526) by debbugs.gnu.org; 19 Aug 2024 06:55:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 19 02:55:00 2024
Received: from localhost ([127.0.0.1]:57528 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sfwI8-0001p6-2l
for submit <at> debbugs.gnu.org; Mon, 19 Aug 2024 02:55:00 -0400
Received: from thaodan.de ([185.216.177.71]:40938)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjorn.bidar@HIDDEN>) id 1sfwI5-0001on-Qs
for 72526 <at> debbugs.gnu.org; Mon, 19 Aug 2024 02:54:59 -0400
Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154])
by thaodan.de (Postfix) with ESMTPSA id 4FA5ED00057;
Mon, 19 Aug 2024 09:54:10 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1724050450; bh=nqN7Z/KqDPj932agPe5WjYCfVFE9jW7WsoQZbs38wZA=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=yXxlLb4hx6XbnMVlrRZdTtF7OK5mJzoa12Z0VKjin6zhpCZZv4dshAkmqNdfwTu9R
rcxr/TfU6ra0+b3XSoAjcK7Qr94rBXO+UXOm+jXvFge2FAKdYsWXKKZVOV2bkDpLkI
G4pxeAyE6Pccvq/aMlWkT09k/p96h/fstyCzkyF9N/9CRutW7eB5J8odoqRojeeyzl
En0Rx5MQT/3XKltos/meotOGF8Y1zA6Mzi6TCefbuc58XtjSCXXE5S64/YPpnqqhBU
wNH5qPOiYJIWCXA3hTWXlg981unH/uXTKeEAoRMvRQxNzhsZE1H1MkychTXEIuOXlr
4UCqTPCcdxxnwQZ3v27QqWniowt1Ab5usYv7oQjG+wi2ODs6PlAxE+nqvu9VnQdPOX
ochfMbdZxqqvxoGtKg/ADL7GW89KWEgaOdnUisufLH+fJTDWqbI7c5jRf8AACMZ7nZ
KrzH75zsJ2z2LkIBy52abib9HggSTI2x8Y7c9+AXgR150oKkWOhsUjL5QuqFNUWioW
wJKahQGHkMoJu0NgFS+oBgE/X0j0NwZPJp5JhIfk+CIhtIeI5r11lxYFRs0VjGlKAP
EFcj8hvltNEKzsY3h2I0rYenIs/m1ozCUx1WKOxBY48eYyy+PIl0kIsJWTACKQ9/+d
Yb6BdWqqcveZ265wnCckhrL8=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search
when passing username and/or port
In-Reply-To: <86ikvyynwg.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 18 Aug
2024 16:13:35 +0300")
References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN>
<867cce1ke4.fsf@HIDDEN> <86ikvyynwg.fsf@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Mon, 19 Aug 2024 09:54:09 +0300
Message-ID: <87zfp9q9ym.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From: Björn Bidar
<bjorn.bidar@HIDDEN> >> Cc: 72526 <at> debbugs.gnu.org >> Date: Sun, 18 Aug
2024 15:30:22 +0300 >> >> Eli Zaretskii <eliz@HIDDEN> writes: >> >> 1. url-basic-auth-store
uses the ' [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 72526
Cc: 72526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN>
>> Cc: 72526 <at> debbugs.gnu.org
>> Date: Sun, 18 Aug 2024 15:30:22 +0300
>>=20
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>=20
>> 1. url-basic-auth-store uses the 'server' as in the '<server>:<port>' in
>> url-basic-auth-storage. I did not want to change the existing format
>> as I don't know the implications.
>
> Can you calculate a separate variable once, and then use 'server' and
> that new variable, each one where appropriate? It simply doesn't look
> clean to recalculate the same value several times.
>
>> 2. I tested calling auth-source-search with :user nil and without :user
>> in both cases the result was the same, from this I imply that calling
>> auth-source-search with :user nil is ok.
>
> Wouldn't it be cleaner to omit :user if the value is nil?
It would, how would one do such thing in lisp except of course
having two separate calls one with :user and one without :user.
For C it would be normal to just pass NULL if the argument is optional
(beginner in lisp).
>> Yes if auth-source-search doesn't find a user for the url
>> url-basic-auth will prompt the user for a user.
>> Why is it a good idea to derive the user by url-basic-auth?
>> Because HTTP basic authentication uses the as specific in RFC 3986
>> section 3.2.1. Using it in this function to infer the user from the
>> url just follows the standard as already in other programs/Emacs
>> packages.
>> If the user has specified the username they want to identify with
>> at the server asking for it would be redundant and not confirming to
>> the standard.
>
> What does the current code do in that case? Does it completely fail,
> or does it prompt for the username? If the latter, it would be a
> change in behavior, won't it?
Currently it does ask for the user even if the caller sends the user in the
url. It would be change of behavior, however it is expected that the user is
used in HTTP basic authentication if the the url is 'http://user@host'.
I don't think any caller would call the function in such a way without
expecting that user is the username used in the call.
>> PS: Reading your message was quite hard as a non-native speaker of
>> English, had to search so many of the acronyms.
>
> Sorry about that. (I'm not a native English speaker, either.)
Np, I was wondering if you are (your last name did sound interesting).
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at 72526) by debbugs.gnu.org; 18 Aug 2024 13:14:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 18 09:14:28 2024 Received: from localhost ([127.0.0.1]:55587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sffjn-0005po-KP for submit <at> debbugs.gnu.org; Sun, 18 Aug 2024 09:14:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sffjk-0005pa-Ca for 72526 <at> debbugs.gnu.org; Sun, 18 Aug 2024 09:14:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sffj0-0005SH-3l; Sun, 18 Aug 2024 09:13:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lxwhb+THo8dtkXupAUJOsrP9r92HFC3zNRgJFDSVh/A=; b=KffZuf+DGX7p5GyOk/Tg 3/haiKroFLXPxX4Lmi13RJ0m0DsGchlYPOHfGBxv31chRsgCZgLJHq3mCUMCQP5SdHIiXHUtymYjK Y8JDsGlYzGtwAs5giHbjqxgtHkvFbPFaziMLZI6TCZNjWn+Bs5jv8AiwZR3Wons42SXV7Ep/wVJaJ YIOOWdPU4mdM2PUyrqZoe0CwFuFkpkC4azncKax1wf83yYn59V7rMmTaS18zbKg+EmnldTSnXGcg6 FTn+av02tNrfogMZGS00UmxCLsnWXa0dP9fRph+1u9dFkUGVMgXDAtWHTfYUa6Wvhh7hGQduYlRU4 8Y8s5Mdk7z01Yg==; Date: Sun, 18 Aug 2024 16:13:35 +0300 Message-Id: <86ikvyynwg.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> In-Reply-To: <87v7zyrp29.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Sun, 18 Aug 2024 15:30:22 +0300) Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN> <867cce1ke4.fsf@HIDDEN> <87v7zyrp29.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72526 Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Bidar <bjorn.bidar@HIDDEN> > Cc: 72526 <at> debbugs.gnu.org > Date: Sun, 18 Aug 2024 15:30:22 +0300 > > Eli Zaretskii <eliz@HIDDEN> writes: > > 1. url-basic-auth-store uses the 'server' as in the '<server>:<port>' in > url-basic-auth-storage. I did not want to change the existing format > as I don't know the implications. Can you calculate a separate variable once, and then use 'server' and that new variable, each one where appropriate? It simply doesn't look clean to recalculate the same value several times. > 2. I tested calling auth-source-search with :user nil and without :user > in both cases the result was the same, from this I imply that calling > auth-source-search with :user nil is ok. Wouldn't it be cleaner to omit :user if the value is nil? > Yes if auth-source-search doesn't find a user for the url > url-basic-auth will prompt the user for a user. > Why is it a good idea to derive the user by url-basic-auth? > Because HTTP basic authentication uses the as specific in RFC 3986 > section 3.2.1. Using it in this function to infer the user from the > url just follows the standard as already in other programs/Emacs > packages. > If the user has specified the username they want to identify with > at the server asking for it would be redundant and not confirming to > the standard. What does the current code do in that case? Does it completely fail, or does it prompt for the username? If the latter, it would be a change in behavior, won't it? > PS: Reading your message was quite hard as a non-native speaker of > English, had to search so many of the acronyms. Sorry about that. (I'm not a native English speaker, either.)
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.
Received: (at 72526) by debbugs.gnu.org; 18 Aug 2024 12:31:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 18 08:31:44 2024
Received: from localhost ([127.0.0.1]:55572 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sff4S-0004oM-Ap
for submit <at> debbugs.gnu.org; Sun, 18 Aug 2024 08:31:44 -0400
Received: from thaodan.de ([185.216.177.71]:34080)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjorn.bidar@HIDDEN>) id 1sff4Q-0004o7-27
for 72526 <at> debbugs.gnu.org; Sun, 18 Aug 2024 08:31:43 -0400
Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154])
by thaodan.de (Postfix) with ESMTPSA id E83FDD0004C;
Sun, 18 Aug 2024 15:30:23 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1723984224; bh=mqlbcjfDX/Al8pQNnn73LZk890cYkeB/ntxMONVxssY=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=AJZB1XXv1/qb7w+nzEQocQiSbJJweqJ3rSidUW77+iXBxWJ9Ci2wvKWRbNOmBZU8W
ZkbdpjhHtOsrbyOyzg/ZX3vSv+s5Al+FCrUfc+GN3ej3BhqK1QQZZr8KryRD9sI37t
a3eqSH0EEJbEcAq47X5CA/0iC3YB3NtKGe+MK7e0iwTXi9qgfK1z2JJfV6fbuTr3l7
D7LEcfILbXfdrxhVd4hzSHOztFxWbvZ7ztqT8uuVj9TgMiypn3B/ail6lDjPB69YUC
WwF1zocdXCQRJPmULd6u+yMtqD/GG5nT5DM/aWZgnCUln9gBl84d2NZ03HdMfBcy1Z
wD/MKk8jOyHqicxP9j7ZBE3AMq8RNmShRnYMOYdvwbB8gRBMhqBR0ZXe+KSo+9x3iF
0JvNqMS7nHwrNOpbCyB6/DRyYJZg9oWeIMm2p+LsPkd6Odfj6eZChxYkcXlqXvW0Sg
e7761shGiwF2v+PF4ne6URezIAePDO5sa52Gflhw1gkqD2GsCJzPMoJ6YfeBOpMIBn
mqAsQiRFmhnNALRsIrZhK6mIPMj0eodL1fDFjHqNYP6Llh8rtIBLN3E1boYktFwy0R
8+oJCk61Iag4DP8vCnWgGI6Rv2IRNxP3y4zzwy+YFINuXRJTwIe5jcKrYoARsNNl3q
+l0G5lVrNggJEV+v0CEo1vQA=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search
when passing username and/or port
In-Reply-To: <867cce1ke4.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 18 Aug
2024 08:15:47 +0300")
References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN>
<867cce1ke4.fsf@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Sun, 18 Aug 2024 15:30:22 +0300
Message-ID: <87v7zyrp29.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From: Björn Bidar
<bjorn.bidar@HIDDEN> >> Cc: 72526 <at> debbugs.gnu.org >> Date: Sat, 17 Aug
2024 23:50:51 +0300 >> >> Eli Zaretskii <eliz@HIDDEN> writes: >> >> >> >
Sorry, I don't see any expert [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 72526
Cc: 72526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN>
>> Cc: 72526 <at> debbugs.gnu.org
>> Date: Sat, 17 Aug 2024 23:50:51 +0300
>>=20
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>=20
>> >> > Sorry, I don't see any experts around to ask to do that.
>> >>=20
>> >> Maybe the maintainer of the url package?
>> >
>> > Whom did you have in mind? url.el says "emacs-devel", which is
>> > basically no one and everyone.
>>=20
>> I don't know, the person that usually deals with the package?
>
> I couldn't find him or her in the recent logs. I concluded we didn't
> have such a person/
>
>> >> > Maybe if you'd posted a more detailed description of the problem and
>> >> > its context, someone could follow your arguments and do a meaningful
>> >> > review. E.g., it sounds from your description like the case of URLs
>> >> > where it currently fails was not meant to be supported by this
>> >> > library? If so, perhaps an alternative is to submit to this library
>> >> > only URLs that it supports, like after stripping the port part?
>> >>=20
>> >> The problem is that the user in url-basic-auth when handling urls lik=
e <uri-type>://<user>@<host> isn't
>> >> forwarded to auth-source. Further it also appends to port to the
>> >> hostname of host which means that the host is invalid since the hostn=
ame
>> >> includes the port number.
>> >>=20
>> >> >From what I read when looking at url-auth.el at line 84 it does supp=
ort
>> >> this kind of case of url as it already handles the same type of url w=
hen
>> >> it deals with <uri-type>://<user>:<password>@<host>.
>> >
>> > So how come this code was not fixed since the day it was added to
>> > Emacs, so long ago?
>>=20
>> I don't know I assume it was never an issue at that time?
>> In any case amending the port to the :host key seems like a bug to me.
>> Similarly when the user specifies the user in the url it should be
>> passed to auth-source so it can find the credentials.
>
> So please take me through your changes with more detailed
> explanations, without assuming I know my way around this code. A few
> things bother me just by looking at the diffs: (1) why do we need to
> calculate 'server' more than once using the same code in the same
> function, and (2) will auth-source-search as called in
> url-do-auth-source-search DTRT when called with ':user nil', which
> will happen if the last argument is omitted. I also wonder what is
> the semantics of the call to auth-source-search in the current code
> where the user is omitted. AFAIU, in that case Emacs will prompt the
> user for username? If so, why is it a good idea to pass to
> auth-source-search USER derived by url-basic-auth, instead of
> prompting?
1. url-basic-auth-store uses the 'server' as in the '<server>:<port>' in
url-basic-auth-storage. I did not want to change the existing format
as I don't know the implications.
2. I tested calling auth-source-search with :user nil and without :user
in both cases the result was the same, from this I imply that calling
auth-source-search with :user nil is ok.
Yes if auth-source-search doesn't find a user for the url
url-basic-auth will prompt the user for a user.
Why is it a good idea to derive the user by url-basic-auth?
Because HTTP basic authentication uses the as specific in RFC 3986
section 3.2.1. Using it in this function to infer the user from the
url just follows the standard as already in other programs/Emacs
packages.
If the user has specified the username they want to identify with
at the server asking for it would be redundant and not confirming to
the standard.
> IOW, I'd like to open what the current code and your changes do for a
> more detailed discussion, so we could be sure the change is TRT before
> we decide what changes to install.
>
> Thanks.
PS: Reading your message was quite hard as a non-native speaker of
English, had to search so many of the acronyms.
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at 72526) by debbugs.gnu.org; 18 Aug 2024 05:16:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 18 01:16:39 2024 Received: from localhost ([127.0.0.1]:55259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sfYHO-0001AB-8f for submit <at> debbugs.gnu.org; Sun, 18 Aug 2024 01:16:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sfYHL-00019w-GS for 72526 <at> debbugs.gnu.org; Sun, 18 Aug 2024 01:16:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sfYGb-0001LD-MN; Sun, 18 Aug 2024 01:15:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KCaRzfwnkSzQn3QJh0Cg1+iPu0X5tGH23vm/quvdhsY=; b=EIVnd6yA0SkRELsdIiiv hGwPFESwCeg7q7no6Mxcm+kg62pIcco/K+xPgRS14ZDeteiyUR7FUOhws0VQbolpLF3IQYu9Mm+xG 9i4ECA2AdCXeGVMq0sYNGCtr5wEgoen1kWyUukncyNubO0tN7NBPbGTiRqgnR8TaT+vj07COxpl1O 3za0z3873r93Bog4PN4xSow+EgVEXijJF83wzqexSPcnpgmEDFlZl9zxsON4YJvSpQr8XfNZozyVS /7xsILikCoA4DJrSO2lwC661Y7ggOPeo3ygRmWdM53JE+jYE7arH44PNVJ5BQbdTw85KJGaoFJ8r9 8OntJD0ZeSIUaQ==; Date: Sun, 18 Aug 2024 08:15:47 +0300 Message-Id: <867cce1ke4.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> In-Reply-To: <87zfpaswk4.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Sat, 17 Aug 2024 23:50:51 +0300) Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN> <87zfpaswk4.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72526 Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Bidar <bjorn.bidar@HIDDEN> > Cc: 72526 <at> debbugs.gnu.org > Date: Sat, 17 Aug 2024 23:50:51 +0300 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> > Sorry, I don't see any experts around to ask to do that. > >> > >> Maybe the maintainer of the url package? > > > > Whom did you have in mind? url.el says "emacs-devel", which is > > basically no one and everyone. > > I don't know, the person that usually deals with the package? I couldn't find him or her in the recent logs. I concluded we didn't have such a person/ > >> > Maybe if you'd posted a more detailed description of the problem and > >> > its context, someone could follow your arguments and do a meaningful > >> > review. E.g., it sounds from your description like the case of URLs > >> > where it currently fails was not meant to be supported by this > >> > library? If so, perhaps an alternative is to submit to this library > >> > only URLs that it supports, like after stripping the port part? > >> > >> The problem is that the user in url-basic-auth when handling urls like <uri-type>://<user>@<host> isn't > >> forwarded to auth-source. Further it also appends to port to the > >> hostname of host which means that the host is invalid since the hostname > >> includes the port number. > >> > >> >From what I read when looking at url-auth.el at line 84 it does support > >> this kind of case of url as it already handles the same type of url when > >> it deals with <uri-type>://<user>:<password>@<host>. > > > > So how come this code was not fixed since the day it was added to > > Emacs, so long ago? > > I don't know I assume it was never an issue at that time? > In any case amending the port to the :host key seems like a bug to me. > Similarly when the user specifies the user in the url it should be > passed to auth-source so it can find the credentials. So please take me through your changes with more detailed explanations, without assuming I know my way around this code. A few things bother me just by looking at the diffs: (1) why do we need to calculate 'server' more than once using the same code in the same function, and (2) will auth-source-search as called in url-do-auth-source-search DTRT when called with ':user nil', which will happen if the last argument is omitted. I also wonder what is the semantics of the call to auth-source-search in the current code where the user is omitted. AFAIU, in that case Emacs will prompt the user for username? If so, why is it a good idea to pass to auth-source-search USER derived by url-basic-auth, instead of prompting? IOW, I'd like to open what the current code and your changes do for a more detailed discussion, so we could be sure the change is TRT before we decide what changes to install. Thanks.
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.
Received: (at 72526) by debbugs.gnu.org; 17 Aug 2024 20:52:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 17 16:52:11 2024
Received: from localhost ([127.0.0.1]:55034 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sfQPC-0004RB-SR
for submit <at> debbugs.gnu.org; Sat, 17 Aug 2024 16:52:11 -0400
Received: from thaodan.de ([185.216.177.71]:53128)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjorn.bidar@HIDDEN>) id 1sfQPA-0004Qy-UO
for 72526 <at> debbugs.gnu.org; Sat, 17 Aug 2024 16:52:09 -0400
Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154])
by thaodan.de (Postfix) with ESMTPSA id 03E03D00047;
Sat, 17 Aug 2024 23:50:52 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1723927853; bh=5Kc1QmrCc76jT0j5QjJhw+soi7V2Af0gK9R0cpV9adE=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=ztpIC7aCo3M/M/+NpvkqVY8gKFNXbtYr4MWuk6RMFCUnwSuN0iY7YceX4U5WuZip6
lCrrCxIIS5+rzCyA2GDLltFl2zeFzOELEz179IRGYb6PMfI/YKEqyoXDIYAThYlfJM
yt+DN5ngX75NDp8rYerqSHxIboT2YfwF1yIqRgRTHneXgATab42OvxGhsNuZVPvKfL
0QzT4V3K8naiLGceEuX1cshw52dklg0zI2NhVqiaOJhcIjQbUcKYEAKDfOb9V1XIMd
0azPbySyRBhBia8S4exc0aGbv0pYA0ZZ7ZB6Xt97Tbh6h5qSfpWGIC6PC8vIpzoV2t
dI20e5eavXN8Nx9FfjWGZTLrW64mubkj1/8Y89H3s/f8VpLaSvd5er6q7Ec0o5WTUV
07ZleVf4huBjYIADFy8kZW+BLl1rMsGzPDuqfCbd4g1++dQSXBlFbFhOYQGqYJdNRO
F9/E235Cb788e8W1wlvrghBtH/aiW3TrgXpI/BWtlMDu3qwbHI5bVOEu9/LlmgrX4u
ZDSavty9tnSl7My41lhJ+6WHDba3aKJGUZhIH+Ua771qv8dx0du2Mf+hHj4UTDGOB9
kVCedzyHtSfZvvlHv9YUW7s9OD7XaWsQRQEIKC2TSbxoXx2uNU8tGfLCHR/dY1RaA/
/zOEd4qb4hBn43cMM6cVaAk4=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search
when passing username and/or port
In-Reply-To: <86ed6n2zld.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 17 Aug
2024 13:49:50 +0300")
References: <86bk1r661g.fsf@HIDDEN> <86ed6n2zld.fsf@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Sat, 17 Aug 2024 23:50:51 +0300
Message-ID: <87zfpaswk4.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From: Björn Bidar
<bjorn.bidar@HIDDEN> >> Cc: 72526 <at> debbugs.gnu.org >> Date: Sat, 17 Aug
2024 11:41:33 +0300 >> >> Eli Zaretskii <eliz@HIDDEN> writes: >> >> >> Date:
Fri, 16 Aug 2024 23:02:51 [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 72526
Cc: 72526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN>
>> Cc: 72526 <at> debbugs.gnu.org
>> Date: Sat, 17 Aug 2024 11:41:33 +0300
>>=20
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>=20
>> >> Date: Fri, 16 Aug 2024 23:02:51 +0300
>> >> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs,
>> >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>> >>=20
>> >> Could someone please review my patch?
>> >
>> > Sorry, I don't see any experts around to ask to do that.
>>=20
>> Maybe the maintainer of the url package?
>
> Whom did you have in mind? url.el says "emacs-devel", which is
> basically no one and everyone.
I don't know, the person that usually deals with the package?
>> > Maybe if you'd posted a more detailed description of the problem and
>> > its context, someone could follow your arguments and do a meaningful
>> > review. E.g., it sounds from your description like the case of URLs
>> > where it currently fails was not meant to be supported by this
>> > library? If so, perhaps an alternative is to submit to this library
>> > only URLs that it supports, like after stripping the port part?
>>=20
>> The problem is that the user in url-basic-auth when handling urls like <=
uri-type>://<user>@<host> isn't
>> forwarded to auth-source. Further it also appends to port to the
>> hostname of host which means that the host is invalid since the hostname
>> includes the port number.
>>=20
>> >From what I read when looking at url-auth.el at line 84 it does support
>> this kind of case of url as it already handles the same type of url when
>> it deals with <uri-type>://<user>:<password>@<host>.
>
> So how come this code was not fixed since the day it was added to
> Emacs, so long ago?
I don't know I assume it was never an issue at that time?
In any case amending the port to the :host key seems like a bug to me.
Similarly when the user specifies the user in the url it should be
passed to auth-source so it can find the credentials.
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at 72526) by debbugs.gnu.org; 17 Aug 2024 10:50:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 17 06:50:41 2024 Received: from localhost ([127.0.0.1]:53600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sfH17-0004nM-7A for submit <at> debbugs.gnu.org; Sat, 17 Aug 2024 06:50:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sfH15-0004n8-FE for 72526 <at> debbugs.gnu.org; Sat, 17 Aug 2024 06:50:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sfH0M-0005xc-Uw; Sat, 17 Aug 2024 06:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=6jOjtKR5ffFa6UnqWUwDG4Qy8EUwqjVoDPb1KQyRTJo=; b=Bu8fRxXs5rhjB4kjr5jJ Itdd44iQusBmZoSTkRAzYOpx/wxBQgAZ17PFTSSiA7evVUmukI/7cCkGyUUzIhbEhURrYWU6l8Eb9 OMIWAmf2EcfcRV6Wsoin6eTDW4RWOQ0VoTrZ+KnBJqUm+zZSCNQ35IrVbgIACekbFJSXu6dLVrGiE IEmmzHUljKQNhMY38VJc+9uEtQ6JkPjXIPA8MOcBtB5q7VoBOEf5epj+N8mSXyn5FzBvZWlZJK4rC t4X/5hMiKW6szsIGf3ofWeLtLszQdoQBU906PJ+5bHhYZA6gc9vWzoJJ8RHMRzqwAQVlFJeTXilHb k4hem7ewO9bigw==; Date: Sat, 17 Aug 2024 13:49:50 +0300 Message-Id: <86ed6n2zld.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> In-Reply-To: <877ccftubm.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Sat, 17 Aug 2024 11:41:33 +0300) Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port References: <86bk1r661g.fsf@HIDDEN> <877ccftubm.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72526 Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Bidar <bjorn.bidar@HIDDEN> > Cc: 72526 <at> debbugs.gnu.org > Date: Sat, 17 Aug 2024 11:41:33 +0300 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> Date: Fri, 16 Aug 2024 23:02:51 +0300 > >> From: Björn Bidar via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > >> > >> Could someone please review my patch? > > > > Sorry, I don't see any experts around to ask to do that. > > Maybe the maintainer of the url package? Whom did you have in mind? url.el says "emacs-devel", which is basically no one and everyone. > > Maybe if you'd posted a more detailed description of the problem and > > its context, someone could follow your arguments and do a meaningful > > review. E.g., it sounds from your description like the case of URLs > > where it currently fails was not meant to be supported by this > > library? If so, perhaps an alternative is to submit to this library > > only URLs that it supports, like after stripping the port part? > > The problem is that the user in url-basic-auth when handling urls like <uri-type>://<user>@<host> isn't > forwarded to auth-source. Further it also appends to port to the > hostname of host which means that the host is invalid since the hostname > includes the port number. > > >From what I read when looking at url-auth.el at line 84 it does support > this kind of case of url as it already handles the same type of url when > it deals with <uri-type>://<user>:<password>@<host>. So how come this code was not fixed since the day it was added to Emacs, so long ago?
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.
Received: (at 72526) by debbugs.gnu.org; 17 Aug 2024 08:42:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 17 04:42:54 2024
Received: from localhost ([127.0.0.1]:53449 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sfF1S-0001FH-5p
for submit <at> debbugs.gnu.org; Sat, 17 Aug 2024 04:42:54 -0400
Received: from thaodan.de ([185.216.177.71]:39344)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjorn.bidar@HIDDEN>) id 1sfF1P-0001F0-CB
for 72526 <at> debbugs.gnu.org; Sat, 17 Aug 2024 04:42:52 -0400
Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154])
by thaodan.de (Postfix) with ESMTPSA id 1011AD00039;
Sat, 17 Aug 2024 11:41:35 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1723884095; bh=/kandhwzaMP9tJ8Ib11/E6HRBhVJVQ9g+7Gkeax0cS4=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=O8JHveGWWRG9m6W/2wEmnPYm0ljVziWg6/hAS5jLuNbLlidBAnGlpDao7Ht8ViSeR
5SHhkpG05qXL77N36jw672GCaB0/vNnRmqrY41+ciofsE3gGIBt+hOWMWXpxsihLsC
rhjOSY9GQdamJang93mgTmEjmL2iQc0VTjaGMAV4Vkngz9ESAxtBF4U07UhCpmtOBx
bT8/9UArS2MltZrriL63FbejB023ZGGFjILeBI6pf69Kw+DDK/JbGfVa2tzjOqEUak
rC1wJNOUBLnPGvkA+L2FgOK2ss3G1o2bk/ipC3hVslOCXkE8wS1ACQl96MxQd+1//7
pMLDl0eq+u96TlT8wUXwwTYysOArOXecO8YTwynEhaAo+K9gwsAuU714gWDD+BeJmc
P7UtwVOfR2/rzYvBSZY2ABfwse12Tots47Umx84rt6ICwfh5SarcI2aUNc3RMtjlCh
ee29ifn46TIighAsBDaDOGfVGDTwNY6+RdEJY80dyfOhqEZdLkLabAEpJYCJIWWrAh
7gu1cQ37hTkWrZWYbazFlocqm/sfdwn0C6Hpvzy9LaQxYF04lkMCJsawsNWnnkqKlG
qHpdFc2IVbMNYo6IDAcXxaVneLuLQKyxI6kcsewgGSoU4d6L3hglK/I2cY9AMGd3eA
xjEaHy+kao9Dcq9w/6ExCqz0=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search
when passing username and/or port
In-Reply-To: <86bk1r661g.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 17 Aug
2024 09:02:19 +0300")
References: <86bk1r661g.fsf@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Sat, 17 Aug 2024 11:41:33 +0300
Message-ID: <877ccftubm.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Fri, 16 Aug
2024 23:02:51 +0300 >> From: Björn Bidar via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> Could
someone please review my pat [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 72526
Cc: 72526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> Date: Fri, 16 Aug 2024 23:02:51 +0300
>> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>=20
>> Could someone please review my patch?
>
> Sorry, I don't see any experts around to ask to do that.
Maybe the maintainer of the url package?
> Maybe if you'd posted a more detailed description of the problem and
> its context, someone could follow your arguments and do a meaningful
> review. E.g., it sounds from your description like the case of URLs
> where it currently fails was not meant to be supported by this
> library? If so, perhaps an alternative is to submit to this library
> only URLs that it supports, like after stripping the port part?
The problem is that the user in url-basic-auth when handling urls like <uri=
-type>://<user>@<host> isn't
forwarded to auth-source. Further it also appends to port to the
hostname of host which means that the host is invalid since the hostname
includes the port number.
From what I read when looking at url-auth.el at line 84 it does support
this kind of case of url as it already handles the same type of url when
it deals with <uri-type>://<user>:<password>@<host>.
> On another level: please make sure you leave 2 spaces between
> sentences in comments, strings, and commit log messages. And I don't
> think the 3rd patch belongs to this issue, so let's not include it in
> this discussion.
Sure.
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at 72526) by debbugs.gnu.org; 17 Aug 2024 06:03:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 17 02:03:08 2024 Received: from localhost ([127.0.0.1]:53256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sfCWp-00057C-Mc for submit <at> debbugs.gnu.org; Sat, 17 Aug 2024 02:03:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sfCWo-00056h-3P for 72526 <at> debbugs.gnu.org; Sat, 17 Aug 2024 02:03:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sfCW6-0001RH-0c; Sat, 17 Aug 2024 02:02:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xeO98z5cqec6O89Qp5E/GFunhqAUMrpPlDBiuWzTkuA=; b=p4oJCDET0+XFStrlivfi pKzBFzsqk3bMSXS+2wZyaoKWKrKcU0nU8H4gdVjBvvmdZNPk2nLpZqtmUo2Y1xMukHy7DIJUIEszC W2l5hYGtCKGhTgf/3p/Lbperp/9gucpX/t3mS04UTV7+NJeQZc/r8cy8BGC9O2zUhenhdOXJwEK51 Bf2tKKlkI+sr1av41kOvAsKHnZrMpvrJjlf9UnP/4Is/KBFWiqb2VUW+KSGkPbAVWj8aLq4VS0/2y jmUHNLUKbqTAELePeR5ldCdPgRy7glKJwohrQEKN37Vk+J/4ahJe4R+LnocF+lnm0SjvNManGeWYE AkfcwEph9uyUyw==; Date: Sat, 17 Aug 2024 09:02:19 +0300 Message-Id: <86bk1r661g.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?iso-8859-1?Q?Bj=F6rn?= Bidar <bjorn.bidar@HIDDEN> In-Reply-To: <87bk1stevo.fsf@> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port References: <87bk1stevo.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72526 Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Fri, 16 Aug 2024 23:02:51 +0300 > From: Björn Bidar via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > Could someone please review my patch? Sorry, I don't see any experts around to ask to do that. Maybe if you'd posted a more detailed description of the problem and its context, someone could follow your arguments and do a meaningful review. E.g., it sounds from your description like the case of URLs where it currently fails was not meant to be supported by this library? If so, perhaps an alternative is to submit to this library only URLs that it supports, like after stripping the port part? On another level: please make sure you leave 2 spaces between sentences in comments, strings, and commit log messages. And I don't think the 3rd patch belongs to this issue, so let's not include it in this discussion. Thanks.
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at 72526) by debbugs.gnu.org; 16 Aug 2024 20:03:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 16 16:03:44 2024 Received: from localhost ([127.0.0.1]:52964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sf3Al-0005iu-UK for submit <at> debbugs.gnu.org; Fri, 16 Aug 2024 16:03:44 -0400 Received: from thaodan.de ([185.216.177.71]:59550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1sf3Ah-0005iN-EG for 72526 <at> debbugs.gnu.org; Fri, 16 Aug 2024 16:03:39 -0400 Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154]) by thaodan.de (Postfix) with ESMTPSA id 133E9D00030; Fri, 16 Aug 2024 23:02:53 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1723838573; bh=jto1t4sFpqVeXoi7JwjtDj3am1uOb7gwcg3pa2uUT5Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=we/uIIuxN3I+C0pV08smKHzx/8QIf3UnfWvbNut52coD1ySVxhvfLDPR07S+LSPg0 I/yJ4IsdFICNUKwYqIhqYwin9ph6JNrhlMMZXt3UdmzFBOzmn6BYYNafv1lBjVZ5f4 2/jU1V2px1rFGfW32rVPrLT6dZODcPsZPVE+6jDsKd7fALn3hJM/qaMlp51DzFPR84 svofv2EI4Qu18n5yPgVYewzp4MB99ePgWRPGxCfqRpw9pzsi3eiOnTgN59Vl67ixFY 75hz3DdEYiHaZ+zAvnMvlD/A6qzBh5CD1LecmglwNCIlwpbHm1/ZMp06qqCJsrzwuw wSk1BvgZDXqapRqIBb0u4s7eFEWmxdLndNR4d3M3Hv/Q4CdtCC9wbGcZiaGQia5xc+ 7vuoOqUbFVNkf10dA/+URZRThJT0JFXgFDzE7GCo5NB58bSSiDi8FOqZ1X8nv7qbxW EH4CSLffryieAJ9+/0tkEKmMF83N3qNrQryn999kLPEVj9bzv7cYStTCj3kmL9jbnG qryzq3qKkIZgZdAvZmpWeCjd6UiebnOlGo7kKhhLzTmE4AP0uTZjNiUFaqY8ttvL8z B37Gfw2zNwEofNw96KRq5F5mpX2bcb9CuNNHssI/mSwIB1nUtiBldp+TY2lKv/w/1P ap+ZXnXy6ozzrs3EkWv7GyP4= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port In-Reply-To: <87r0azawml.fsf@> (=?utf-8?Q?=22Bj=C3=B6rn?= Bidar via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Thu, 08 Aug 2024 17:59:30 +0300") References: Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Fri, 16 Aug 2024 23:02:51 +0300 Message-ID: <87bk1stevo.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Could someone please review my patch? Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 72526 Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) Could someone please review my patch?
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 16 Aug 2024 20:03:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 16 16:03:39 2024 Received: from localhost ([127.0.0.1]:52962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sf3Ah-0005iZ-Ic for submit <at> debbugs.gnu.org; Fri, 16 Aug 2024 16:03:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:37536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1sf3Ag-0005iS-Bo for submit <at> debbugs.gnu.org; Fri, 16 Aug 2024 16:03:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>) id 1sf3A4-0007uv-4j for bug-gnu-emacs@HIDDEN; Fri, 16 Aug 2024 16:03:00 -0400 Received: from thaodan.de ([185.216.177.71]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>) id 1sf3A1-0005yC-KV for bug-gnu-emacs@HIDDEN; Fri, 16 Aug 2024 16:02:59 -0400 Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154]) by thaodan.de (Postfix) with ESMTPSA id 133E9D00030; Fri, 16 Aug 2024 23:02:53 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1723838573; bh=jto1t4sFpqVeXoi7JwjtDj3am1uOb7gwcg3pa2uUT5Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=we/uIIuxN3I+C0pV08smKHzx/8QIf3UnfWvbNut52coD1ySVxhvfLDPR07S+LSPg0 I/yJ4IsdFICNUKwYqIhqYwin9ph6JNrhlMMZXt3UdmzFBOzmn6BYYNafv1lBjVZ5f4 2/jU1V2px1rFGfW32rVPrLT6dZODcPsZPVE+6jDsKd7fALn3hJM/qaMlp51DzFPR84 svofv2EI4Qu18n5yPgVYewzp4MB99ePgWRPGxCfqRpw9pzsi3eiOnTgN59Vl67ixFY 75hz3DdEYiHaZ+zAvnMvlD/A6qzBh5CD1LecmglwNCIlwpbHm1/ZMp06qqCJsrzwuw wSk1BvgZDXqapRqIBb0u4s7eFEWmxdLndNR4d3M3Hv/Q4CdtCC9wbGcZiaGQia5xc+ 7vuoOqUbFVNkf10dA/+URZRThJT0JFXgFDzE7GCo5NB58bSSiDi8FOqZ1X8nv7qbxW EH4CSLffryieAJ9+/0tkEKmMF83N3qNrQryn999kLPEVj9bzv7cYStTCj3kmL9jbnG qryzq3qKkIZgZdAvZmpWeCjd6UiebnOlGo7kKhhLzTmE4AP0uTZjNiUFaqY8ttvL8z B37Gfw2zNwEofNw96KRq5F5mpX2bcb9CuNNHssI/mSwIB1nUtiBldp+TY2lKv/w/1P ap+ZXnXy6ozzrs3EkWv7GyP4= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port In-Reply-To: <87r0azawml.fsf@> (=?utf-8?Q?=22Bj=C3=B6rn?= Bidar via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Thu, 08 Aug 2024 17:59:30 +0300") References: Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Fri, 16 Aug 2024 23:02:51 +0300 Message-ID: <87bk1stevo.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.216.177.71; envelope-from=bjorn.bidar@HIDDEN; helo=thaodan.de X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: submit Cc: 72526 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.2 (-) Could someone please review my patch?
bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 8 Aug 2024 15:02:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 08 11:02:27 2024
Received: from localhost ([127.0.0.1]:37049 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sc4em-0005Vp-HR
for submit <at> debbugs.gnu.org; Thu, 08 Aug 2024 11:02:26 -0400
Received: from lists.gnu.org ([209.51.188.17]:35734)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjorn.bidar@HIDDEN>) id 1sc4ei-0005Vf-FS
for submit <at> debbugs.gnu.org; Thu, 08 Aug 2024 11:02:22 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>)
id 1sc4cA-0000JV-HR
for bug-gnu-emacs@HIDDEN; Thu, 08 Aug 2024 10:59:42 -0400
Received: from thaodan.de ([2a03:4000:4f:f15::1])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>)
id 1sc4c5-0001W2-GS
for bug-gnu-emacs@HIDDEN; Thu, 08 Aug 2024 10:59:42 -0400
Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154])
by thaodan.de (Postfix) with ESMTPSA id 797FED00046
for <bug-gnu-emacs@HIDDEN>; Thu, 8 Aug 2024 17:59:32 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1723129172; bh=gKLAQo2PNUwaWriy+BOVNh8wPocN1DpSWmDrTTQjZ6g=;
h=From:To:Subject:Date;
b=nmlGjNUGxfDKnAdCTh2eWxw5PhToAO28GWC/ho6AiHxN0fe07gFOn0QztG+1KycRX
QvDdoVXCyQa9gPBjivMzjsvtAbReA8mcGG+N6ud18FuDDFx0WoGK0bx6/ub/JWUYHr
mI1V6HU4aYgeTQFgbH2ajkIWeqvNUj3NJ6kqJFw4JL0ETxb1NA3R7SX9gAO1Qzt3mo
Pu2eigsXfjgLFU/Yfihp6x9n2Q2e08pnDuwVCFitKBtyHiFja+kY0fr6hHMPNMp6Eh
ma6oMKexuegpwBvmMs7iBiu8GV9NcDQ8aed/w72e816AOYA2aZHQVb/9eJKU9mibVb
Eznod+02knDZQAawuUrvMaBX5tqyLdOaodG/m5hXpF2RhL7d04UnRMhlAD2aAYAF7B
p+0ZMtr8rQuxpVNnwmB7cPUurQyAXKr4NsyteCx2I9hM8q+k4vkalMpUt2Gf4EoNP4
vSYFUb9Xenoht5sbiMqBf5lMxUp5jJd4DEcmTnbY+ManOF+L1eg9yonV6a8hyJJuJo
wBBQmvL8h6X4cu59ZzWbfTRHSisA429ktK9Yiggfg8BydRBpNI4imu501wZfXlijV8
i9KZvdCnOP95WKWgkjIyXWupFjHUIUQtePS/9nmkld7/7IFlcvlwQ1YnvdOaqEaEea
0Va9TgrZZRzbh2y5Drs5+dXc=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing
username and/or port
X-Debbugs-Cc:
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Thu, 08 Aug 2024 17:59:30 +0300
Message-ID: <87r0azawml.fsf@>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a03:4000:4f:f15::1;
envelope-from=bjorn.bidar@HIDDEN; helo=thaodan.de
X-Spam_score_int: -14
X-Spam_score: -1.5
X-Spam_bar: -
X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.2 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
--=-=-=
Content-Type: text/plain
While testing org-caldav I noticed that url-basic-auth doesn't handle
cases where either the port or user is supplied in the url when
searching for secrets.
It amends the port to the server when searching for :host in auth-source
and doesn't forward the user parameter that if it finds it.
E.g. in cases where the url is http://max@HIDDEN:443 it
call auth-source-search with :host fsf.org:443 instead of :host fsf.org
and doesn't forward :user max to it even thou it was parsed from the
URL.
The last patch is included to set the max line length for git commit
summary when using Magit's git-commit-mode as mentioned in CONTRIBUTE.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Fix-secret-search-with-basic-auth-with-a-port-in-url.patch
From cbf74f6cfac4df318885b15ad034dd761d33a0f8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Thu, 8 Aug 2024 17:31:20 +0300
Subject: [PATCH 1/3] Fix secret search with basic auth with a port in url
* lisp/url/url-auth.el (url-basic-auth): Fix retrieving of secrets when
the url contains a port. Ammending the port to server breaks
auth-source-search matching for :host which is redundant
as it already specified in :port.
---
lisp/url/url-auth.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/url/url-auth.el b/lisp/url/url-auth.el
index 8f4df780a54..c73047da6b3 100644
--- a/lisp/url/url-auth.el
+++ b/lisp/url/url-auth.el
@@ -72,8 +72,7 @@ url-basic-auth
(pass (url-password href))
(enable-recursive-minibuffers t) ; for url-handler-mode (bug#10298)
byserv retval data)
- (setq server (format "%s:%d" server port)
- file (cond
+ (setq file (cond
(realm realm)
((string= "" file) "/")
((string-match "/$" file) file)
@@ -94,6 +93,7 @@ url-basic-auth
(url-do-auth-source-search server type :secret)
(and (url-interactive-p)
(read-passwd "Password: " nil (or pass "")))))
+ (setq server (format "%s:%d" server port))
(set url-basic-auth-storage
(cons (list server
(cons file
@@ -129,6 +129,7 @@ url-basic-auth
(url-do-auth-source-search server type :secret)
(and (url-interactive-p)
(read-passwd "Password: ")))
+ server (format "%s:%d" server port)
retval (base64-encode-string (format "%s:%s" user pass) t)
byserv (assoc server (symbol-value url-basic-auth-storage)))
(setcdr byserv
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0002-Forward-user-to-auth-source-inside-url-basic-auth.patch
From c7b2321ab0f85c98cb88070b09abc04ee21af84e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Thu, 8 Aug 2024 17:36:01 +0300
Subject: [PATCH 2/3] Forward user to auth-source inside url-basic-auth
* lisp/url/url-auth.el (url-basic-auth): Forward the user if provided by
the url or found by auth-source when searching for secrets. Supplying
auth-source with the user when matching secrets allows for more accurate
retrieval and fixes instances where the user enters an url that already
contains the user such as "user@HIDDEN".
---
lisp/url/url-auth.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/url/url-auth.el b/lisp/url/url-auth.el
index c73047da6b3..d7d7701b364 100644
--- a/lisp/url/url-auth.el
+++ b/lisp/url/url-auth.el
@@ -90,7 +90,7 @@ url-basic-auth
(read-string (url-auth-user-prompt href realm)
(or user (user-real-login-name)))))
pass (or
- (url-do-auth-source-search server type :secret)
+ (url-do-auth-source-search server type :secret user)
(and (url-interactive-p)
(read-passwd "Password: " nil (or pass "")))))
(setq server (format "%s:%d" server port))
@@ -126,7 +126,7 @@ url-basic-auth
(read-string (url-auth-user-prompt href realm)
(user-real-login-name))))
pass (or
- (url-do-auth-source-search server type :secret)
+ (url-do-auth-source-search server type :secret user)
(and (url-interactive-p)
(read-passwd "Password: ")))
server (format "%s:%d" server port)
@@ -461,8 +461,8 @@ url-registered-auth-schemes
"A list of the registered authorization schemes and various and sundry
information associated with them.")
-(defun url-do-auth-source-search (server type parameter)
- (let* ((auth-info (auth-source-search :max 1 :host server :port type))
+(defun url-do-auth-source-search (server type parameter &optional user)
+ (let* ((auth-info (auth-source-search :max 1 :host server :port type :user user))
(auth-info (nth 0 auth-info))
(token (plist-get auth-info parameter))
(token (if (functionp token) (funcall token) token)))
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0003-Highlight-git-commit-summary-after-50-characters-in-.patch
From 89a172b1de2e19753d58d23f5e3c763c14179d59 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Thu, 8 Aug 2024 17:40:27 +0300
Subject: [PATCH 3/3] ; Highlight git commit summary after 50 characters in
Magit
Highlight summary line of git commit after 50 characters as mention in
CONTRIBUTE when commit with Magit's git-commit-mode.
---
.dir-locals.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/.dir-locals.el b/.dir-locals.el
index c74da88a811..e483b04f0c8 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -43,6 +43,7 @@
(fill-column . 74)
(mode . bug-reference)))
(diff-mode . ((mode . whitespace)))
+ (git-commit-major-mode . ((git-commit-summary-max-length . 50)))
(emacs-lisp-mode . ((indent-tabs-mode . nil)
(electric-quote-comment . nil)
(electric-quote-string . nil)
--
2.45.2
--=-=-=
Content-Type: text/plain
In GNU Emacs 31.0.50 (build 1, x86_64-suse-linux-gnu, GTK+ Version
3.24.43, cairo version 1.18.0)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101012
System Description: openSUSE Tumbleweed
Configured using:
'configure --disable-build-details --without-pop --with-mailutils
--without-hesiod --with-gameuser=:games --with-kerberos
--with-kerberos5 --with-file-notification=inotify --with-modules
--enable-autodepend --enable-link-time-optimization --prefix=/usr
--mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share
--localstatedir=/var --sharedstatedir=/var/lib
--libexecdir=/usr/libexec --with-file-notification=yes
--libdir=/usr/lib64 --with-native-compilation=aot
--enable-locallisppath=/usr/share/emacs/31.0.50/site-lisp:/usr/share/emacs/site-lisp
--with-x --with-xim --with-sound --with-xpm --with-jpeg --with-tiff
--with-gif --with-png --with-rsvg --with-dbus --with-xft --without-gpm
--with-tree-sitter --with-x-toolkit=gtk --without-pgtk
--with-toolkit-scroll-bars --x-includes=/usr/include
--x-libraries=/usr/lib64 --with-libotf --with-m17n-flt --with-cairo
--with-xwidgets --build=x86_64-suse-linux --with-dumping=pdumper
build_alias=x86_64-suse-linux 'CC=sccache cc' 'CFLAGS=-O2 -Wall
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection
-Werror=return-type -flto=auto -march=znver3 -mmmx -mpopcnt -msse
-msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -mavx2 -msse4a -mno-fma4
-mno-xop -mfma -mno-avx512f -mbmi -mbmi2 -maes -mpclmul -mno-avx512vl
-mno-avx512bw -mno-avx512dq -mno-avx512cd -mno-avx512er -mno-avx512pf
-mno-avx512vbmi -mno-avx512ifma -mno-avx5124vnniw -mno-avx5124fmaps
-mno-avx512vpopcntdq -mno-avx512vbmi2 -mno-gfni -mvpclmulqdq
-mno-avx512vnni -mno-avx512bitalg -mno-avx512bf16
-mno-avx512vp2intersect -mno-3dnow -madx -mabm -mno-cldemote
-mclflushopt -mclwb -mclzero -mcx16 -mno-enqcmd -mf16c -mfsgsbase
-mfxsr -mno-hle -msahf -mno-lwp -mlzcnt -mmovbe -mno-movdir64b
-mno-movdiri -mmwaitx -mno-pconfig -mpku -mno-prefetchwt1 -mprfchw
-mno-ptwrite -mrdpid -mrdrnd -mrdseed -mno-rtm -mno-serialize -mno-sgx
-msha -mshstk -mno-tbm -mno-tsxldtrk -mvaes -mno-waitpkg -mwbnoinvd
-mxsave -mxsavec -mxsaveopt -mxsaves -mno-amx-tile -mno-amx-int8
-mno-amx-bf16 -mno-uintr -mno-hreset -mno-kl -mno-widekl -mno-avxvnni
-mno-avx512fp16 -mno-avxifma -mno-avxvnniint8 -mno-avxneconvert
-mno-cmpccxadd -mno-amx-fp16 -mno-prefetchi -mno-raoint
-mno-amx-complex --param l1-cache-size=32 --param l1-cache-line-size=64
--param l2-cache-size=512 -mtune=znver3 -fno-optimize-sibling-calls -g
-D_GNU_SOURCE -DGDK_DISABLE_DEPRECATION_WARNINGS
-DGLIB_DISABLE_DEPRECATION_WARNINGS -pipe -Wno-pointer-sign
-Wno-unused-variable -Wno-unused-label -DPDMP_BASE='\''"emacs-gtk"'\'''
LDFLAGS=-Wl,-O2 'CXX=sccache c++'
PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP
NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM XWIDGETS
GTK3 ZLIB
Important settings:
value of $LC_MONETARY: fi_FI.UTF-8
value of $LC_NUMERIC: POSIX
value of $LANG: en_GB.UTF-8
value of $XMODIFIERS: @im=local
locale-coding-system: utf-8-unix
Major mode: Outline
Minor modes in effect:
circe-lagmon-mode: t
lsp-treemacs-sync-mode: t
magit-wip-initial-backup-mode: t
magit-wip-before-change-mode: t
magit-wip-after-apply-mode: t
magit-wip-after-save-mode: t
magit-wip-after-save-local-mode: t
magit-wip-mode: t
magit-auto-revert-mode: t
treemacs-filewatch-mode: t
treemacs-git-mode: t
treemacs-fringe-indicator-mode: t
global-atomic-chrome-edit-mode: t
minions-mode: t
back-button-mode: t
recentf-mode: t
global-auto-revert-mode: t
savehist-mode: t
bug-reference-mode: t
emms-playing-time-display-mode: t
emms-playing-time-mode: t
gnus-desktop-notify-mode: t
tracking-mode: t
org-super-agenda-mode: t
ws-butler-mode: t
selected-minor-mode: t
jinx-mode: t
global-git-commit-mode: t
projectile-mode: t
global-company-mode: t
company-mode: t
electric-pair-mode: t
editorconfig-mode: t
frames-only-mode: t
windmove-mode: t
marginalia-mode: t
which-key-mode: t
dirvish-override-dired-mode: t
dired-async-mode: t
helm-mode: t
helm-minibuffer-history-mode: t
global-so-long-mode: t
global-emojify-mode: t
emojify-mode: t
change-cursor-mode: t
doom-modeline-mode: t
server-mode: t
helm-autoresize-mode: t
desktop-save-mode: t
Info-persist-history-mode: t
save-place-mode: t
delete-selection-mode: t
override-global-mode: t
tooltip-mode: t
global-eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
undelete-frame-mode: t
minibuffer-regexp-mode: t
line-number-mode: t
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-koma-letter hides /home/bidar/.local/etc/emacs/lib/lisp/ox-koma-letter
/home/bidar/.local/etc/emacs/lib/org-contrib/lisp/ox-groff hides /home/bidar/.local/etc/emacs/lib/lisp/ox-groff
/home/bidar/.local/etc/emacs/lib/vim-modeline/vim-modeline hides /home/bidar/.local/etc/emacs/lib/lisp/vim-modeline
/home/bidar/.local/etc/emacs/lib/lisp/htmlize hides /home/bidar/.local/etc/emacs/lib/htmlize/htmlize
/home/bidar/.local/etc/emacs/lib/lisp/cursor-chg hides /home/bidar/.local/etc/emacs/lib/cursor-chg/cursor-chg
/home/bidar/.local/etc/emacs/lib/async/dired-async hides /usr/share/emacs/site-lisp/dired-async
/home/bidar/.local/etc/emacs/lib/async/async-bytecomp hides /usr/share/emacs/site-lisp/async-bytecomp
/home/bidar/.local/etc/emacs/lib/async/async-autoloads hides /usr/share/emacs/site-lisp/async-autoloads
/home/bidar/.local/etc/emacs/lib/compat/compat hides /usr/share/emacs/site-lisp/compat
/home/bidar/.local/etc/emacs/lib/compat/compat-28 hides /usr/share/emacs/site-lisp/compat-28
/home/bidar/.local/etc/emacs/lib/compat/compat-25 hides /usr/share/emacs/site-lisp/compat-25
/home/bidar/.local/etc/emacs/lib/cmake-mode/cmake-mode hides /usr/share/emacs/site-lisp/cmake-mode
/home/bidar/.local/etc/emacs/lib/async/smtpmail-async hides /usr/share/emacs/site-lisp/smtpmail-async
/home/bidar/.local/etc/emacs/lib/async/async hides /usr/share/emacs/site-lisp/async
/home/bidar/.local/etc/emacs/lib/compat/compat-29 hides /usr/share/emacs/site-lisp/compat-29
/home/bidar/.local/etc/emacs/lib/compat/compat-27 hides /usr/share/emacs/site-lisp/compat-27
/home/bidar/.local/etc/emacs/lib/compat/compat-26 hides /usr/share/emacs/site-lisp/compat-26
/home/bidar/.local/etc/emacs/lib/which-key/which-key hides /usr/share/emacs/31.0.50/lisp/which-key
/home/bidar/.local/etc/emacs/lib/transient/lisp/transient hides /usr/share/emacs/31.0.50/lisp/transient
/home/bidar/.local/etc/emacs/lib/editorconfig/editorconfig-core-handle hides /usr/share/emacs/31.0.50/lisp/editorconfig-core-handle
/home/bidar/.local/etc/emacs/lib/editorconfig/editorconfig hides /usr/share/emacs/31.0.50/lisp/editorconfig
/home/bidar/.local/etc/emacs/lib/use-package/bind-key hides /usr/share/emacs/31.0.50/lisp/bind-key
/home/bidar/.local/etc/emacs/lib/editorconfig/editorconfig-tools hides /usr/share/emacs/31.0.50/lisp/editorconfig-tools
/home/bidar/.local/etc/emacs/lib/editorconfig/editorconfig-fnmatch hides /usr/share/emacs/31.0.50/lisp/editorconfig-fnmatch
/home/bidar/.local/etc/emacs/lib/editorconfig/editorconfig-core hides /usr/share/emacs/31.0.50/lisp/editorconfig-core
/home/bidar/.local/etc/emacs/lib/editorconfig/editorconfig-conf-mode hides /usr/share/emacs/31.0.50/lisp/editorconfig-conf-mode
/home/bidar/.local/etc/emacs/lib/modus-themes/theme-loaddefs hides /usr/share/emacs/31.0.50/lisp/theme-loaddefs
/home/bidar/.local/etc/emacs/lib/use-package/use-package-core hides /usr/share/emacs/31.0.50/lisp/use-package/use-package-core
/home/bidar/.local/etc/emacs/lib/use-package/use-package hides /usr/share/emacs/31.0.50/lisp/use-package/use-package
/home/bidar/.local/etc/emacs/lib/use-package/use-package-lint hides /usr/share/emacs/31.0.50/lisp/use-package/use-package-lint
/home/bidar/.local/etc/emacs/lib/use-package/use-package-jump hides /usr/share/emacs/31.0.50/lisp/use-package/use-package-jump
/home/bidar/.local/etc/emacs/lib/use-package/use-package-ensure hides /usr/share/emacs/31.0.50/lisp/use-package/use-package-ensure
/home/bidar/.local/etc/emacs/lib/use-package/use-package-ensure-system-package hides /usr/share/emacs/31.0.50/lisp/use-package/use-package-ensure-system-package
/home/bidar/.local/etc/emacs/lib/use-package/use-package-diminish hides /usr/share/emacs/31.0.50/lisp/use-package/use-package-diminish
/home/bidar/.local/etc/emacs/lib/use-package/use-package-delight hides /usr/share/emacs/31.0.50/lisp/use-package/use-package-delight
/home/bidar/.local/etc/emacs/lib/use-package/use-package-bind-key hides /usr/share/emacs/31.0.50/lisp/use-package/use-package-bind-key
/home/bidar/.local/etc/emacs/lib/org/lisp/ox hides /usr/share/emacs/31.0.50/lisp/org/ox
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-publish hides /usr/share/emacs/31.0.50/lisp/org/ox-publish
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-latex hides /usr/share/emacs/31.0.50/lisp/org/ox-latex
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-icalendar hides /usr/share/emacs/31.0.50/lisp/org/ox-icalendar
/home/bidar/.local/etc/emacs/lib/org/lisp/org hides /usr/share/emacs/31.0.50/lisp/org/org
/home/bidar/.local/etc/emacs/lib/org/lisp/org-table hides /usr/share/emacs/31.0.50/lisp/org/org-table
/home/bidar/.local/etc/emacs/lib/org/lisp/org-src hides /usr/share/emacs/31.0.50/lisp/org/org-src
/home/bidar/.local/etc/emacs/lib/org/lisp/org-refile hides /usr/share/emacs/31.0.50/lisp/org/org-refile
/home/bidar/.local/etc/emacs/lib/org/lisp/org-persist hides /usr/share/emacs/31.0.50/lisp/org/org-persist
/home/bidar/.local/etc/emacs/lib/org/lisp/org-mouse hides /usr/share/emacs/31.0.50/lisp/org/org-mouse
/home/bidar/.local/etc/emacs/lib/org/lisp/org-mobile hides /usr/share/emacs/31.0.50/lisp/org/org-mobile
/home/bidar/.local/etc/emacs/lib/org/lisp/org-macs hides /usr/share/emacs/31.0.50/lisp/org/org-macs
/home/bidar/.local/etc/emacs/lib/org/lisp/org-loaddefs hides /usr/share/emacs/31.0.50/lisp/org/org-loaddefs
/home/bidar/.local/etc/emacs/lib/org/lisp/org-inlinetask hides /usr/share/emacs/31.0.50/lisp/org/org-inlinetask
/home/bidar/.local/etc/emacs/lib/org/lisp/org-habit hides /usr/share/emacs/31.0.50/lisp/org/org-habit
/home/bidar/.local/etc/emacs/lib/org/lisp/org-goto hides /usr/share/emacs/31.0.50/lisp/org/org-goto
/home/bidar/.local/etc/emacs/lib/org/lisp/org-fold hides /usr/share/emacs/31.0.50/lisp/org/org-fold
/home/bidar/.local/etc/emacs/lib/org/lisp/org-fold-core hides /usr/share/emacs/31.0.50/lisp/org/org-fold-core
/home/bidar/.local/etc/emacs/lib/org/lisp/org-feed hides /usr/share/emacs/31.0.50/lisp/org/org-feed
/home/bidar/.local/etc/emacs/lib/org/lisp/org-faces hides /usr/share/emacs/31.0.50/lisp/org/org-faces
/home/bidar/.local/etc/emacs/lib/org/lisp/org-element hides /usr/share/emacs/31.0.50/lisp/org/org-element
/home/bidar/.local/etc/emacs/lib/org/lisp/org-element-ast hides /usr/share/emacs/31.0.50/lisp/org/org-element-ast
/home/bidar/.local/etc/emacs/lib/org/lisp/org-clock hides /usr/share/emacs/31.0.50/lisp/org/org-clock
/home/bidar/.local/etc/emacs/lib/org/lisp/org-agenda hides /usr/share/emacs/31.0.50/lisp/org/org-agenda
/home/bidar/.local/etc/emacs/lib/org/lisp/ol hides /usr/share/emacs/31.0.50/lisp/org/ol
/home/bidar/.local/etc/emacs/lib/org/lisp/ob hides /usr/share/emacs/31.0.50/lisp/org/ob
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-tangle hides /usr/share/emacs/31.0.50/lisp/org/ob-tangle
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-sql hides /usr/share/emacs/31.0.50/lisp/org/ob-sql
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-scheme hides /usr/share/emacs/31.0.50/lisp/org/ob-scheme
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-python hides /usr/share/emacs/31.0.50/lisp/org/ob-python
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-processing hides /usr/share/emacs/31.0.50/lisp/org/ob-processing
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-plantuml hides /usr/share/emacs/31.0.50/lisp/org/ob-plantuml
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-lob hides /usr/share/emacs/31.0.50/lisp/org/ob-lob
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-exp hides /usr/share/emacs/31.0.50/lisp/org/ob-exp
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-core hides /usr/share/emacs/31.0.50/lisp/org/ob-core
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-beamer hides /usr/share/emacs/31.0.50/lisp/org/ox-beamer
/home/bidar/.local/etc/emacs/lib/org/lisp/org-version hides /usr/share/emacs/31.0.50/lisp/org/org-version
/home/bidar/.local/etc/emacs/lib/org/lisp/org-num hides /usr/share/emacs/31.0.50/lisp/org/org-num
/home/bidar/.local/etc/emacs/lib/org/lisp/org-list hides /usr/share/emacs/31.0.50/lisp/org/org-list
/home/bidar/.local/etc/emacs/lib/org/lisp/org-indent hides /usr/share/emacs/31.0.50/lisp/org/org-indent
/home/bidar/.local/etc/emacs/lib/org/lisp/org-colview hides /usr/share/emacs/31.0.50/lisp/org/org-colview
/home/bidar/.local/etc/emacs/lib/org/lisp/org-capture hides /usr/share/emacs/31.0.50/lisp/org/org-capture
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-lilypond hides /usr/share/emacs/31.0.50/lisp/org/ob-lilypond
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-shell hides /usr/share/emacs/31.0.50/lisp/org/ob-shell
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-R hides /usr/share/emacs/31.0.50/lisp/org/ob-R
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-texinfo hides /usr/share/emacs/31.0.50/lisp/org/ox-texinfo
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-org hides /usr/share/emacs/31.0.50/lisp/org/ox-org
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-odt hides /usr/share/emacs/31.0.50/lisp/org/ox-odt
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-md hides /usr/share/emacs/31.0.50/lisp/org/ox-md
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-man hides /usr/share/emacs/31.0.50/lisp/org/ox-man
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-koma-letter hides /usr/share/emacs/31.0.50/lisp/org/ox-koma-letter
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-html hides /usr/share/emacs/31.0.50/lisp/org/ox-html
/home/bidar/.local/etc/emacs/lib/org/lisp/ox-ascii hides /usr/share/emacs/31.0.50/lisp/org/ox-ascii
/home/bidar/.local/etc/emacs/lib/org/lisp/org-timer hides /usr/share/emacs/31.0.50/lisp/org/org-timer
/home/bidar/.local/etc/emacs/lib/org/lisp/org-tempo hides /usr/share/emacs/31.0.50/lisp/org/org-tempo
/home/bidar/.local/etc/emacs/lib/org/lisp/org-protocol hides /usr/share/emacs/31.0.50/lisp/org/org-protocol
/home/bidar/.local/etc/emacs/lib/org/lisp/org-plot hides /usr/share/emacs/31.0.50/lisp/org/org-plot
/home/bidar/.local/etc/emacs/lib/org/lisp/org-pcomplete hides /usr/share/emacs/31.0.50/lisp/org/org-pcomplete
/home/bidar/.local/etc/emacs/lib/org/lisp/org-macro hides /usr/share/emacs/31.0.50/lisp/org/org-macro
/home/bidar/.local/etc/emacs/lib/org/lisp/org-lint hides /usr/share/emacs/31.0.50/lisp/org/org-lint
/home/bidar/.local/etc/emacs/lib/org/lisp/org-keys hides /usr/share/emacs/31.0.50/lisp/org/org-keys
/home/bidar/.local/etc/emacs/lib/org/lisp/org-id hides /usr/share/emacs/31.0.50/lisp/org/org-id
/home/bidar/.local/etc/emacs/lib/org/lisp/org-footnote hides /usr/share/emacs/31.0.50/lisp/org/org-footnote
/home/bidar/.local/etc/emacs/lib/org/lisp/org-entities hides /usr/share/emacs/31.0.50/lisp/org/org-entities
/home/bidar/.local/etc/emacs/lib/org/lisp/org-duration hides /usr/share/emacs/31.0.50/lisp/org/org-duration
/home/bidar/.local/etc/emacs/lib/org/lisp/org-datetree hides /usr/share/emacs/31.0.50/lisp/org/org-datetree
/home/bidar/.local/etc/emacs/lib/org/lisp/org-cycle hides /usr/share/emacs/31.0.50/lisp/org/org-cycle
/home/bidar/.local/etc/emacs/lib/org/lisp/org-ctags hides /usr/share/emacs/31.0.50/lisp/org/org-ctags
/home/bidar/.local/etc/emacs/lib/org/lisp/org-crypt hides /usr/share/emacs/31.0.50/lisp/org/org-crypt
/home/bidar/.local/etc/emacs/lib/org/lisp/org-compat hides /usr/share/emacs/31.0.50/lisp/org/org-compat
/home/bidar/.local/etc/emacs/lib/org/lisp/org-attach hides /usr/share/emacs/31.0.50/lisp/org/org-attach
/home/bidar/.local/etc/emacs/lib/org/lisp/org-attach-git hides /usr/share/emacs/31.0.50/lisp/org/org-attach-git
/home/bidar/.local/etc/emacs/lib/org/lisp/org-archive hides /usr/share/emacs/31.0.50/lisp/org/org-archive
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-w3m hides /usr/share/emacs/31.0.50/lisp/org/ol-w3m
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-rmail hides /usr/share/emacs/31.0.50/lisp/org/ol-rmail
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-mhe hides /usr/share/emacs/31.0.50/lisp/org/ol-mhe
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-man hides /usr/share/emacs/31.0.50/lisp/org/ol-man
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-irc hides /usr/share/emacs/31.0.50/lisp/org/ol-irc
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-info hides /usr/share/emacs/31.0.50/lisp/org/ol-info
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-gnus hides /usr/share/emacs/31.0.50/lisp/org/ol-gnus
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-eww hides /usr/share/emacs/31.0.50/lisp/org/ol-eww
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-eshell hides /usr/share/emacs/31.0.50/lisp/org/ol-eshell
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-doi hides /usr/share/emacs/31.0.50/lisp/org/ol-doi
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-docview hides /usr/share/emacs/31.0.50/lisp/org/ol-docview
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-bibtex hides /usr/share/emacs/31.0.50/lisp/org/ol-bibtex
/home/bidar/.local/etc/emacs/lib/org/lisp/ol-bbdb hides /usr/share/emacs/31.0.50/lisp/org/ol-bbdb
/home/bidar/.local/etc/emacs/lib/org/lisp/oc hides /usr/share/emacs/31.0.50/lisp/org/oc
/home/bidar/.local/etc/emacs/lib/org/lisp/oc-natbib hides /usr/share/emacs/31.0.50/lisp/org/oc-natbib
/home/bidar/.local/etc/emacs/lib/org/lisp/oc-csl hides /usr/share/emacs/31.0.50/lisp/org/oc-csl
/home/bidar/.local/etc/emacs/lib/org/lisp/oc-bibtex hides /usr/share/emacs/31.0.50/lisp/org/oc-bibtex
/home/bidar/.local/etc/emacs/lib/org/lisp/oc-biblatex hides /usr/share/emacs/31.0.50/lisp/org/oc-biblatex
/home/bidar/.local/etc/emacs/lib/org/lisp/oc-basic hides /usr/share/emacs/31.0.50/lisp/org/oc-basic
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-table hides /usr/share/emacs/31.0.50/lisp/org/ob-table
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-sqlite hides /usr/share/emacs/31.0.50/lisp/org/ob-sqlite
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-sed hides /usr/share/emacs/31.0.50/lisp/org/ob-sed
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-screen hides /usr/share/emacs/31.0.50/lisp/org/ob-screen
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-sass hides /usr/share/emacs/31.0.50/lisp/org/ob-sass
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-ruby hides /usr/share/emacs/31.0.50/lisp/org/ob-ruby
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-ref hides /usr/share/emacs/31.0.50/lisp/org/ob-ref
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-perl hides /usr/share/emacs/31.0.50/lisp/org/ob-perl
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-org hides /usr/share/emacs/31.0.50/lisp/org/ob-org
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-octave hides /usr/share/emacs/31.0.50/lisp/org/ob-octave
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-ocaml hides /usr/share/emacs/31.0.50/lisp/org/ob-ocaml
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-maxima hides /usr/share/emacs/31.0.50/lisp/org/ob-maxima
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-matlab hides /usr/share/emacs/31.0.50/lisp/org/ob-matlab
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-makefile hides /usr/share/emacs/31.0.50/lisp/org/ob-makefile
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-lua hides /usr/share/emacs/31.0.50/lisp/org/ob-lua
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-lisp hides /usr/share/emacs/31.0.50/lisp/org/ob-lisp
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-latex hides /usr/share/emacs/31.0.50/lisp/org/ob-latex
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-julia hides /usr/share/emacs/31.0.50/lisp/org/ob-julia
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-js hides /usr/share/emacs/31.0.50/lisp/org/ob-js
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-java hides /usr/share/emacs/31.0.50/lisp/org/ob-java
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-haskell hides /usr/share/emacs/31.0.50/lisp/org/ob-haskell
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-groovy hides /usr/share/emacs/31.0.50/lisp/org/ob-groovy
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-gnuplot hides /usr/share/emacs/31.0.50/lisp/org/ob-gnuplot
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-fortran hides /usr/share/emacs/31.0.50/lisp/org/ob-fortran
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-forth hides /usr/share/emacs/31.0.50/lisp/org/ob-forth
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-eval hides /usr/share/emacs/31.0.50/lisp/org/ob-eval
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-eshell hides /usr/share/emacs/31.0.50/lisp/org/ob-eshell
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-emacs-lisp hides /usr/share/emacs/31.0.50/lisp/org/ob-emacs-lisp
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-dot hides /usr/share/emacs/31.0.50/lisp/org/ob-dot
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-ditaa hides /usr/share/emacs/31.0.50/lisp/org/ob-ditaa
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-css hides /usr/share/emacs/31.0.50/lisp/org/ob-css
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-comint hides /usr/share/emacs/31.0.50/lisp/org/ob-comint
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-clojure hides /usr/share/emacs/31.0.50/lisp/org/ob-clojure
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-calc hides /usr/share/emacs/31.0.50/lisp/org/ob-calc
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-awk hides /usr/share/emacs/31.0.50/lisp/org/ob-awk
/home/bidar/.local/etc/emacs/lib/org/lisp/ob-C hides /usr/share/emacs/31.0.50/lisp/org/ob-C
/home/bidar/.local/etc/emacs/lib/compat/compat hides /usr/share/emacs/31.0.50/lisp/emacs-lisp/compat
Features:
(shadow emacsbug magit-patch descr-text helm-ring bbdb-message
gnus-alias autocrypt-message gnus-search eieio-opt speedbar ezimage
dframe smart-region multiple-cursors mc-separate-operations
rectangular-region-mode mc-mark-pop mc-edit-lines
mc-hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors
multiple-cursors-core rect expand-region yaml-mode-expansions
subword-mode-expansions cperl-mode-expansions text-mode-expansions
cc-mode-expansions the-org-mode-expansions python-el-fgallina-expansions
nxml-mode-expansions html-mode-expansions er-basic-expansions
expand-region-core expand-region-custom whitespace helm-ls-git
magit-extras help-macro em-unix em-term em-script em-prompt em-pred
em-ls em-hist em-glob em-extpipe em-cmpl em-dirs em-basic em-banner
em-alias esh-mode esh-var eshell esh-cmd esh-ext esh-proc esh-opt esh-io
esh-arg esh-module esh-module-loaddefs esh-util circe-lagmon goto-chg
mastodon-media mastodon-profile mastodon-auth mastodon-client mastodon
mastodon-search mastodon-toot persist mastodon-http request shortdoc
cl-print tabify elfeed-link orgit-forge orgit w3m-form w3m-symbol w3m
w3m-hist bookmark-w3m w3m-ems w3m-favicon w3m-image w3m-fb tab-line
w3m-proc w3m-util ietf-drums-date gnus-gravatar gnus-cite
message-view-patch mm-archive mail-extr textsec uni-scripts idna-mapping
ucs-normalize uni-confusable textsec-check gnus-bcklg bbdb-gnus-aux qp
gnus-ml gnus-demon gnus-topic autocrypt-gnus nndraft nnmh utf-7 epa-file
nnfolder bbdb-gnus bbdb-mua nnnil dired-open helm-x-files helm-for-files
hydra two-column help-fns helm-descbinds helm-command dcl-mode tempo
char-fold misearch multi-isearch helm-external emacsql-sqlite-builtin
sqlite winner tramp-archive tramp-gvfs zeroconf vc-dir plstore
gitconfig-mode rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid nxml-mode
nxml-outln nxml-rap sgml-mode company-anaconda highlight-indent-guides
cap-words superword subword anaconda-mode pythonic rpm-spec-mode
company-lua lua-mode image-file image-converter cmake-font-lock
cmake-mode pdf-occur tablist tablist-filter semantic/wisent/comp
semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util
semantic semantic/tag semantic/lex semantic/fw mode-local cedet
pdf-isearch pdf-misc whole-line-or-region pdf-tools pdf-view pdf-cache
pdf-info pdf-util pdf-macs tramp-cache tramp-sh dired-collapse
time-stamp lsp-treemacs lsp-treemacs-generic lsp-treemacs-themes
treemacs-treelib treemacs-nerd-icons treemacs-magit forge-repos
forge-tablist forge-topics forge-commands forge-semi forge-bitbucket
buck forge-gogs gogs forge-gitea gtea forge-gitlab glab forge-github
ghub-graphql treepy gsexp ghub forge-notify forge-revnote forge-pullreq
forge-issue forge-topic yaml eieio-custom forge-post forge-repo forge
forge-core forge-db magit-popup magit-bookmark magit-submodule
magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull
magit-fetch magit-clone magit-remote magit-commit magit-sequence
magit-notes magit-worktree magit-tag magit-merge magit-branch
magit-reset magit-files magit-refs magit-status magit magit-repos
magit-apply magit-wip magit-log which-func magit-diff smerge-mode diff
magit-core magit-autorevert magit-margin magit-transient magit-process
magit-mode benchmark treemacs treemacs-header-line
treemacs-compatibility treemacs-mode treemacs-bookmarks treemacs-tags
treemacs-interface treemacs-persistence treemacs-filewatch-mode
treemacs-follow-mode treemacs-rendering treemacs-annotations
treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals
treemacs-fringe-indicator pulse treemacs-macros yasnippet lsp-mode
lsp-protocol spinner network-stream markdown-mode lv imenu dirvish-yank
dirvish-subtree dirvish-collapse dirvish-icons dirvish-vc
dirvish-widgets company-shell generic-x skeleton generic atomic-chrome
websocket minions back-button smartrep helm-projectile recentf
tree-widget autorevert savehist org-edit-indirect edit-indirect
cus-start org-bug bug-search bug-comment-mode bug-backend-bz-rpc
bug-list-mode bug-mode bug-format bug-rpc bug-debug bug-search-common
bug-common-functions bug-persistent-data bug-custom yeetube yeetube-mpv
socks elfeed-autotag elfeed-score elfeed-score-maint
elfeed-score-scoring elfeed-score-serde elfeed-score-rule-stats
elfeed-score-rules elfeed-score-log elfeed-tube elfeed-tube-utils aio
elfeed-protocol-owncloud elfeed-protocol elfeed-protocol-common
elfeed-show elfeed-search rainbow-delimiters ligature symbol-overlay
hideshow vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view
bug-reference elfeed-csv elfeed elfeed-curl elfeed-log elfeed-db
elfeed-lib xml-query emms-i18n emms-history emms-score emms-stream-info
emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon
emms-browser sort emms-volume emms-volume-sndioctl emms-volume-mixerctl
emms-volume-pulse emms-volume-amixer emms-playlist-sort emms-last-played
emms-player-mpd emms-playing-time emms-lyrics emms-url
emms-player-simple emms-streams emms-show-all emms-tag-editor
emms-tag-tracktag emms-info-mp3info emms-mark emms-mode-line emms-cache
emms-playlist-mode emms-info-native emms-info-native-spc
emms-info-native-mp3 emms-info-native-ogg emms-info-native-opus
emms-info-native-flac emms-info-native-vorbis emms-info-libtag emms-info
emms-later-do emms-source-playlist emms-source-file locate emms
emms-compat khardel gravatar dns smiley autocrypt gnus-icalendar
org-capture gnus-async smtpmail-async smtpmail gnus-agent gnus-srvr
gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache
gnus-desktop-notify bbdb-vcard bbdb-com bbdb-vcard-vcard21 bbdb
bbdb-site timezone mastodon-async mastodon-tl url-cache mpv tq
mastodon-iso lui-track company-emoji company-emoji-list helm-circe
circe-notifications circe-display-images circe-color-nicks circe
lui-irc-colors irc lcs lui-logging lui-format lui tracking shorten
flyspell circe-compat ical2org org-modern org-caldav icalendar url-dav
url-http url-auth url-gw nsm ox-koma-letter ox-extra org-pomodoro alert
notifications org-timer org-expiry ol-man org-clock org-protocol
ob-sqlite ob-sql ob-shell ob-python python ob-plantuml ob-org ob-octave
ob-lua ob-js ob-gnuplot ox-odt rng-loc rng-uri rng-parse rng-match
rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util
ox-latex ox-icalendar org-super-agenda ts org-habit org-duration cdlatex
reftex reftex-loaddefs reftex-vars texmathp org-appear ws-butler
selected jinx oc-basic ol-eww eww url-queue mm-url ol-rmail ol-mhe
ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime
smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom
gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail
mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win gnus
nnheader range ol-docview doc-view ol-bibtex bibtex ol-bbdb ol-w3m
ol-doi org-link-doi goto-addr view mule-util cal-china cal-bahai
cal-islam cal-hebrew holidays holiday-loaddefs cal-iso cal-julian lunar
solar cal-dst vc-git vim-modeline company-yasnippet appt org-agenda
ox-html table ox-ascii ox-publish ox org-element org-persist org-id
org-refile org-element-ast avl-tree ob-dot ob-ditaa ob-clojure ob-C
outshine outshine-org-cmds outorg smartparens-org smartparens-text
smartparens loadhist org-archive-subtree-hierarchy org-archive org ob
ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint
org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp
ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys
oc org-loaddefs org-version org-compat org-macs noutline outline
salt-mode rst mmm-jinja2 yaml-mode perl-completion woman man ffap
dabbrev cperl-mode facemenu helm-elisp helm-eval edebug debug backtrace
cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine
cc-vars cc-defs ggtags ewoc flycheck-color-mode-line flycheck jka-compr
let-alist meson-mode bitbake-modes bitbake autoinsert conf-bitbake-mode
conf-mode bitbake-ff find-file bitbake-mmm sh-script smie treesit
executable mmm-mode mmm-univ mmm-class mmm-region mmm-auto mmm-vars
mmm-utils mmm-compat bitbake-functions bitbake-compat xterm-color vc-osc
diff-mode track-changes vc vc-dispatcher magit-libgit libgit libegit2
git-commit magit-git magit-base magit-section cursor-sensor crm log-edit
pcvs-util add-log git-email message sendmail yank-media puny rfc822 mml
mml-sec epa epg rfc6068 epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums
mail-prsvr mailabbrev mail-utils gmm-utils mailheader diary-lib
diary-loaddefs cal-menu calendar cal-loaddefs midnight vlf-setup
multi-vterm vterm face-remap color term disp-table ehelp vterm-module
term/xterm xterm projectile ibuf-ext ibuffer ibuffer-loaddefs
company-oddmuse company-keywords company-etags etags fileloop generator
xref project company-gtags company-dabbrev-code company-dabbrev
company-files company-clang company-capf company-cmake company-semantic
company-template company-bbdb company elec-pair editorconfig
editorconfig-core editorconfig-core-handle editorconfig-fnmatch wgrep-ag
frames-only-mode windmove i3-integration i3 bindat marginalia which-key
dirvish transient helm-dired-history dired-ranger dired-avfs
dired-rainbow dired-filter dired-hacks-utils dired-x dired-async
dired-du find-dired wdired dired-aux helm-icons treemacs-icons
treemacs-scope treemacs-themes treemacs-core-utils treemacs-logging
treemacs-customization pfuture inline hl-line treemacs-faces
helm-bookmark helm-net xml helm-adaptive helm-info bookmark helm-mode
helm-misc helm-files image-dired image-dired-tags image-dired-external
image-dired-util image-mode dired dired-loaddefs exif filenotify tramp
trampver tramp-integration files-x tramp-message tramp-compat xdg
parse-time iso8601 time-date tramp-loaddefs helm-buffers all-the-icons
all-the-icons-faces data-material data-weathericons data-octicons
data-fileicons data-faicons data-alltheicons helm-occur helm-tags
helm-locate helm-grep wgrep-helm wgrep grep compile text-property-search
helm-regexp format-spec helm-utils helm-help helm-types so-long emojify
apropos tar-mode arc-mode archive-mode ht cursor-chg doom-modeline
doom-modeline-segments doom-modeline-env doom-modeline-core shrink-path
f s dash nerd-icons nerd-icons-faces nerd-icons-data
nerd-icons-data-mdicon nerd-icons-data-flicon nerd-icons-data-codicon
nerd-icons-data-devicon nerd-icons-data-sucicon nerd-icons-data-wicon
nerd-icons-data-faicon nerd-icons-data-powerline nerd-icons-data-octicon
nerd-icons-data-pomicon nerd-icons-data-ipsicon modus-vivendi-theme
modus-themes helm-pass password-store with-editor shell pcomplete comint
ansi-osc ansi-color ring server helm helm-global-bindings helm-easymenu
edmacro kmacro helm-core async-bytecomp helm-source helm-multi-match
helm-lib async auth-source-pass printing ps-print ps-print-loaddefs lpr
desktop frameset derived info+ thingatpt cl saveplace advice delsel
no-littering epkg-elpa epkg-utils epkg-list epkg-desc find-func epkg
closql emacsql-sqlite-common emacsql emacsql-compiler eieio-base llama
comp-run compat use-package use-package-ensure use-package-delight
use-package-diminish use-package-bind-key bind-key easy-mmode
use-package-core zop-to-char-autoloads yeetube-autoloads
yasnippet-autoloads yaml-mode-autoloads yaml-autoloads
xterm-color-autoloads ws-butler-autoloads with-editor-autoloads
whole-line-or-region-autoloads which-key-autoloads wgrep-autoloads
websocket-autoloads web-mode-autoloads w3m-autoloads vlf-autoloads
visual-regexp-autoloads vim-modeline-autoloads vc-osc-autoloads
uuidgen-autoloads use-package-autoloads ts-autoloads treepy-autoloads
treemacs-nerd-icons-autoloads treemacs-autoloads transient-autoloads
toml-mode-autoloads systemd-autoloads symbol-overlay-autoloads
swiper-helm-autoloads ssh-config-mode-autoloads spinner-autoloads
sound-async-autoloads smartrep-autoloads smartparens-autoloads
smart-region-autoloads skewer-mode-autoloads simple-httpd-autoloads
shrink-path-autoloads selected-autoloads salt-mode-autoloads s-autoloads
rpm-spec-mode-autoloads rich-minority-autoloads request-autoloads
rainbow-delimiters-autoloads qt-pro-mode-autoloads qml-mode-autoloads
pythonic-autoloads projectile-autoloads posframe-autoloads
pos-tip-autoloads popup-autoloads plantuml-mode-autoloads
pkgbuild-mode-autoloads piper-autoloads pfuture-autoloads
perspective-autoloads persp-mode-autoloads persist-autoloads
password-store-autoloads pass-autoloads outshine-autoloads
outorg-autoloads orgit-forge-autoloads orgit-autoloads
org-vcard-autoloads org-tree-slide-autoloads org-super-agenda-autoloads
org-pomodoro-autoloads org-modern-autoloads org-edit-indirect-autoloads
org-contrib-autoloads org-contacts-autoloads org-clock-helpers-autoloads
org-caldav-autoloads org-appear-autoloads org-autoloads
no-littering-autoloads nginx-mode-autoloads nerd-icons-ibuffer-autoloads
nerd-icons-autoloads navi-mode-autoloads multiple-cursors-autoloads
multi-vterm-autoloads mpv-autoloads move-text-autoloads
modus-themes-autoloads mode-icons-autoloads mmm-mode-autoloads
mmm-jinja2-autoloads minions-autoloads message-x-autoloads
message-view-patch-autoloads message-attachment-reminder-autoloads
meson-mode-autoloads mastodon-autoloads markdown-mode-autoloads
marginalia-autoloads magit-popup-autoloads magit-autoloads
lua-mode-autoloads lsp-ui-autoloads lsp-treemacs-autoloads
lsp-mode-autoloads lsp-docker-autoloads logview-autoloads
llama-autoloads lisp-autoloads link-hint-autoloads ligature-autoloads
levenshtein-autoloads khardel-autoloads js2-mode-autoloads
journalctl-autoloads jira-markup-mode-autoloads ivy-autoloads
irony-autoloads ir-black-theme-autoloads info+-autoloads iedit-autoloads
ical2org-autoloads ibuffer-projectile-autoloads
i3wm-config-mode-autoloads i3-autoloads hydra-autoloads
htmlize-autoloads ht-autoloads highlight-indent-guides-autoloads
helm-projectile-autoloads helm-pass-autoloads helm-org-rifle-autoloads
helm-make-autoloads helm-ls-git-autoloads helm-icons-autoloads
helm-ext-autoloads helm-emms-autoloads helm-dired-history-autoloads
helm-descbinds-autoloads helm-circe-autoloads helm-autoloads
guess-language-autoloads grep-context-autoloads goto-chg-autoloads
gnus-recent-autoloads gnus-notes-autoloads gnus-desktop-notify-autoloads
gnus-alias-autoloads gitconfig-autoloads git-modes-autoloads
git-email-autoloads ghub-autoloads ggtags-autoloads
frames-only-mode-autoloads forge-autoloads
flycheck-color-mode-line-autoloads flycheck-autoloads fedi-autoloads
f-autoloads extmap-autoloads expand-region-autoloads
evil-multiedit-autoloads evil-autoloads emojify-autoloads
emacsql-autoloads elixir-mode-autoloads elfeed-tube-autoloads
elfeed-summary-autoloads elfeed-score-autoloads
elfeed-protocol-autoloads elfeed-autotag-autoloads elfeed-autoloads
el-mock-autoloads eimp-autoloads editorconfig-autoloads
edit-indirect-autoloads dumb-jump-autoloads doom-modeline-autoloads
docbook-autoloads dirvish-autoloads dired-rsync-autoloads
dired-hacks-autoloads dired-du-autoloads devhelp-autoloads
deferred-autoloads default-text-scale-autoloads debbugs-autoloads
datetime-autoloads dash-autoloads dap-mode-autoloads
cursor-chg-autoloads crux-autoloads copy-as-format-autoloads
compat-autoloads company-shell-autoloads company-quickhelp-autoloads
company-nginx-autoloads company-lua-autoloads company-irony-autoloads
company-emoji-autoloads company-anaconda-autoloads company-autoloads
code-review-autoloads cmake-mode-autoloads cmake-font-lock-autoloads
closql-autoloads circe-notifications-autoloads circe-autoloads
cdlatex-autoloads ccls-autoloads buttercup-autoloads bui-autoloads
bug-mode-autoloads bitbake-modes-autoloads bbdb-vcard-autoloads
bbdb-loaddefs back-button-autoloads avy-autoloads autocrypt-autoloads
auto-compile-autoloads atomic-chrome-autoloads async-autoloads
anaphora-autoloads anaconda-mode-autoloads all-the-icons-autoloads
alert-autoloads aio-autoloads ag-autoloads ace-window-autoloads
ace-link-autoloads a-autoloads 2048-game-autoloads borg loaddefs-gen
lisp-mnt radix-tree info comp comp-cstr cl-extra help-mode comp-common
warnings rx preview-latex auctex tex-site ispell package browse-url url
url-proxy url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cus-edit pp pcase
cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl tooltip cconv
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq
simple cl-generic indonesian philippine cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs theme-loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads
xwidget-internal dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x
multi-tty move-toolbar make-network-process native-compile emacs)
Memory information:
((conses 16 5501062 1305343) (symbols 48 120655 0)
(strings 32 2017340 88180) (string-bytes 1 114937713)
(vectors 16 380950) (vector-slots 8 6889205 1943160)
(floats 8 6624 20095) (intervals 56 144347 21135) (buffers 992 340))
--=-=-=--
Björn Bidar <bjorn.bidar@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#72526; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.