GNU bug report logs - #72541
[PATCH] gnu: gerbv: Fix missing version.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72541 in the body.
You can then email your comments to 72541 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gerbv: Fix missing version.
Date: Fri, 09 Aug 2024 15:00:51 +0300

[Message part 1 (text/plain, inline)]

This program currently lacks version number everywhere - in pkgconfig,
in CLI and in GUI, because it is generated by a script that needs git
and updating shebang. This patch fixes the problem.

[0001-gnu-gerbv-Fix-missing-version.patch (text/x-patch, attachment)]

Message #8 received at 72541 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Evgeny Pisemsky <mail <at> pisemsky.site>
Cc: 72541 <at> debbugs.gnu.org
Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version.
Date: Fri, 06 Sep 2024 23:51:11 +0200

Hi,

Evgeny Pisemsky <mail <at> pisemsky.site> skribis:

> This program currently lacks version number everywhere - in pkgconfig,
> in CLI and in GUI, because it is generated by a script that needs git
> and updating shebang. This patch fixes the problem.

This is surprising because the checkout lacks the ‘.git’ directory, and
thus Git cannot possibly determine the commit ID or anything.

Could it be that adding ‘git’ to $PATH just hides the problem?

>>From c066b30a8f1afff37deb54d7ed571d99b059f619 Mon Sep 17 00:00:00 2001
> Message-ID: <c066b30a8f1afff37deb54d7ed571d99b059f619.1723204072.git.mail <at> pisemsky.site>
> From: Evgeny Pisemsky <mail <at> pisemsky.site>
> Date: Fri, 9 Aug 2024 14:40:05 +0300
> Subject: [PATCH] gnu: gerbv: Fix missing version.
>
> * gnu/packages/engineering.scm (gerbv): Fix missing version.
> [source]: Change indentation.
> [arguments]: Patch version generator shebang.
> [native-inputs]: Add git.
>
> Change-Id: I29a38fff03127d9ce2b5e04ca638dacfc3720125

[…]

>      (build-system gnu-build-system)
>      (arguments
> -     '(#:configure-flags '("CFLAGS=-fcommon")))

Not related to your patch, but this thing is most likely wrong and
should read "CFLAGS=-O2 -g -fcommon", or the binaries will be
unoptimized (-O0) and unconditionally stripped.

Thanks,
Ludo’.

Message #11 received at 72541 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 72541 <at> debbugs.gnu.org
Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version.
Date: Sat, 07 Sep 2024 19:30:23 +0300

[Message part 1 (text/plain, inline)]

Hello!

The problem is certainly in this script or its environment, since the
only place where version can come from is this line in configure.ac:

AC_INIT([gerbv], [m4_esyscmd(utils/git-version-gen.sh 2.10.0)])

This gave me the idea to do substitution there to avoid running it.

As for wrong flag, I suggest just removing it.

Alter these changes gerbv builds and works fine for me.

Updated patch attached.

[0001-gnu-gerbv-Fix-missing-version.patch (text/x-patch, attachment)]

Message #14 received at 72541 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 72541 <at> debbugs.gnu.org
Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version.
Date: Sun, 08 Sep 2024 19:00:37 +0300

*After these changes

Looks like I have found the problem in this script:

When git is absent, it stops at the following line:

GIT=`command -v git`

resulting an empty version. The reason is probably this instruction:

set -e

Anyway, IMO in guix it makes more sense to just exclude obviously
useless script from the build process, rather than patch it.

Message #17 received at 72541 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 72541 <at> debbugs.gnu.org
Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version.
Date: Mon, 16 Sep 2024 09:35:48 +0300

FYI this issue is one of two reasons why another package, pcb2gcode,
does not build since around october 2023:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68036

The other one is incompatibility with geos, which can be solved in
three different ways, but only after this one will be resolved.

Message #20 received at 72541 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 72541 <at> debbugs.gnu.org
Subject: Re: [bug#72541] Any feedback?
Date: Wed, 16 Oct 2024 22:22:37 +0300

It's like I'm sending patches and messages into a black hole.

Message #23 received at 72541 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: 72541 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version.
Date: Fri, 03 Jan 2025 22:04:30 +0300

[Message part 1 (text/plain, inline)]

I tried to contact upstream, but they don't accept pull requests:

- https://github.com/gerbv/gerbv/issues/244
- https://github.com/gerbv/gerbv/pull/226#issuecomment-2566103734

So it can only be done here. I updated initial patch with suggested
configure flags and commented why git is added to native inputs.

[0001-gnu-gerbv-Fix-missing-version.patch (text/x-patch, attachment)]

Message #28 received at 72541-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Evgeny Pisemsky <mail <at> pisemsky.site>
Cc: 72541-done <at> debbugs.gnu.org
Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version.
Date: Sat, 04 Jan 2025 19:43:24 +0100

[Message part 1 (text/plain, inline)]

Hi,

Evgeny Pisemsky <mail <at> pisemsky.site> skribis:

> From f85ab2e24f0da292f639c07f4d66430896b18d13 Mon Sep 17 00:00:00 2001
> Message-ID: <f85ab2e24f0da292f639c07f4d66430896b18d13.1735929709.git.mail <at> pisemsky.site>
> From: Evgeny Pisemsky <mail <at> pisemsky.site>
> Date: Fri, 3 Jan 2025 21:40:01 +0300
> Subject: [PATCH] gnu: gerbv: Fix missing version.
>
> * gnu/packages/engineering.scm (gerbv): Fix missing version.
> [source]: Change indentation.
> [arguments]: Set correct configure flags, patch version generator shebang.
>
> Change-Id: I29a38fff03127d9ce2b5e04ca638dacfc3720125

Finally applied with the change below.

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 5b43f8787e..f9c4ac9bbd 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -862,7 +862,7 @@ (define-public gerbv
                          gettext-minimal
                          ;; Version generator needs git to work properly:
                          ;; https://github.com/gerbv/gerbv/issues/244
-                         git
+                         git-minimal/pinned
                          `(,glib "bin")
                          libtool
                          pkg-config))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.