GNU bug report logs - #72572
[PATCH] gnu: Add elinks.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72572 in the body.
You can then email your comments to 72572 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Faiz <adam.faiz <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add elinks.
Date: Sun, 11 Aug 2024 17:29:22 +0800

From e5f84076855745ba103053933beafbd75a4c68d2 Mon Sep 17 00:00:00 2001
Message-ID: <e5f84076855745ba103053933beafbd75a4c68d2.1723368423.git.adam.faiz <at> disroot.org>
From: AwesomeAdam54321 <adam.faiz <at> disroot.org>
Date: Sun, 11 Aug 2024 17:26:37 +0800
Subject: [PATCH] gnu: Add elinks.

* gnu/packages/web-browsers.scm (elinks): New variable.
---
 gnu/packages/web-browsers.scm | 57 +++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 4a2b28916d..adb9444dac 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -97,6 +97,7 @@ (define-module (gnu packages web-browsers)
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages readline)
+  #:use-module (gnu packages regex)
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages suckless)
@@ -105,6 +106,7 @@ (define-module (gnu packages web-browsers)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
+  #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg))
 
 (define-public midori
@@ -218,6 +220,61 @@ (define-public links
     ;; linking of the program with openssl.
     (license license:gpl1+)))
 
+(define-public elinks
+  (package
+    (name "elinks")
+    (version "0.17.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/rkd77/elinks")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0ij738y1ig2cdfdim85al9iyqz6cwrfac0zg0mqrqj9af0q25r95"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:configure-flags
+      #~(list "--enable-finger"
+              "--enable-html-highlight"
+              "--enable-gopher"
+              "--enable-gemini"
+              "--enable-cgi"
+              "--enable-bittorrent"
+              "--enable-nntp"
+              "--enable-256-colors"
+              "--enable-true-color"
+              "--with-brotli"
+              "--with-lzma"
+              "--with-libev")))
+    (native-inputs
+     (list autoconf
+           automake
+           gnu-gettext
+           pkg-config))
+    (inputs
+     (list brotli
+           bzip2
+           expat
+           gnutls
+           gpm
+           libev
+           libgcrypt
+           libidn
+           lua
+           tre
+           xz
+           zlib))
+    (synopsis "Advanced text mode web browser")
+    (description "ELinks is a feature-rich program for browsing the web
+in text mode.  It can render both frames and tables, is highly customisable
+and can be extended via Lua scripts.  It is like an enhanced Lynx and Links.")
+    (home-page "http://elinks.cz/")
+    (license license:gpl2+)))
+
 (define-public luakit
   (package
     (name "luakit")

base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8
-- 
2.41.0

Message #8 received at 72572 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: control <at> debbugs.gnu.org,72572 <at> debbugs.gnu.org
Cc: Adam Faiz <adam.faiz <at> disroot.org>
Subject: QA review for 72572
Date: Thu, 15 Aug 2024 18:57:31 +0200

user guix
usertag 72572 + reviewed-looks-good
thanks

Guix QA review form submission:
Hi Adam, 
Thanks for this package, it builds deterministically and no lints. I just have a doubt over the license given both the description that it's GPVv2 and not later (so license:gpl2 would seem more appropriate instead of license:gpl2+). Additionnally, other licenses are evocated in this file : 
https://github.com/rkd77/elinks?tab=License-1-ov-file#readme
although I'm not sure we should include all these licenses.

Items marked as checked: Lint warnings, Package builds, Commit messages, New package tests, New package synopsis and descriptions

-- 
Best regards,
Nicolas Graves

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Adam Faiz via Guix-patches via <guix-patches <at> gnu.org>
Cc: 72572 <at> debbugs.gnu.org, Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#72572] [PATCH] gnu: Add elinks.
Date: Sat, 17 Aug 2024 11:28:58 +0800

[Message part 1 (text/plain, inline)]

Adam Faiz via Guix-patches via <guix-patches <at> gnu.org> writes:

> From e5f84076855745ba103053933beafbd75a4c68d2 Mon Sep 17 00:00:00 2001
> Message-ID: <e5f84076855745ba103053933beafbd75a4c68d2.1723368423.git.adam.faiz <at> disroot.org>
> From: AwesomeAdam54321 <adam.faiz <at> disroot.org>
> Date: Sun, 11 Aug 2024 17:26:37 +0800
> Subject: [PATCH] gnu: Add elinks.
>
> * gnu/packages/web-browsers.scm (elinks): New variable.
> ---
>  gnu/packages/web-browsers.scm | 57 +++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 4a2b28916d..adb9444dac 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -97,6 +97,7 @@ (define-module (gnu packages web-browsers)
>    #:use-module (gnu packages python-xyz)
>    #:use-module (gnu packages qt)
>    #:use-module (gnu packages readline)
> +  #:use-module (gnu packages regex)
>    #:use-module (gnu packages sdl)
>    #:use-module (gnu packages sqlite)
>    #:use-module (gnu packages suckless)
> @@ -105,6 +106,7 @@ (define-module (gnu packages web-browsers)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages web)
>    #:use-module (gnu packages webkit)
> +  #:use-module (gnu packages xml)
>    #:use-module (gnu packages xorg))
>  
>  (define-public midori
> @@ -218,6 +220,61 @@ (define-public links
>      ;; linking of the program with openssl.
>      (license license:gpl1+)))
>  
> +(define-public elinks
> +  (package
> +    (name "elinks")
> +    (version "0.17.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/rkd77/elinks")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0ij738y1ig2cdfdim85al9iyqz6cwrfac0zg0mqrqj9af0q25r95"))))
> +    (build-system gnu-build-system)

can you switch to meson-build-system? I think it's better this way.

> +    (arguments
> +     (list
> +      #:configure-flags
> +      #~(list "--enable-finger"
> +              "--enable-html-highlight"
> +              "--enable-gopher"
> +              "--enable-gemini"
> +              "--enable-cgi"
> +              "--enable-bittorrent"
> +              "--enable-nntp"
> +              "--enable-256-colors"
> +              "--enable-true-color"
> +              "--with-brotli"
> +              "--with-lzma"
> +              "--with-libev")))
> +    (native-inputs
> +     (list autoconf
> +           automake
> +           gnu-gettext
> +           pkg-config))
> +    (inputs
> +     (list brotli
> +           bzip2
> +           expat
> +           gnutls
> +           gpm
> +           libev
> +           libgcrypt
> +           libidn
> +           lua
> +           tre
> +           xz
> +           zlib))
> +    (synopsis "Advanced text mode web browser")
> +    (description "ELinks is a feature-rich program for browsing the web
> +in text mode.  It can render both frames and tables, is highly customisable
> +and can be extended via Lua scripts.  It is like an enhanced Lynx and Links.")
> +    (home-page "http://elinks.cz/")
> +    (license license:gpl2+)))
> +
>  (define-public luakit
>    (package
>      (name "luakit")
>
> base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 72572-submitter <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 72572-submitter <at> debbugs.gnu.org
Subject: RE: adding elinks to Guix
Date: Fri, 22 Nov 2024 14:52:26 +0000

Hi Adam,

You submitted a patch to add Elinks to Guix. Last I saw there was a request to move it to the meson-build-system. Is that something that you have the time/interest to do? It would be great to get this contribution into the repo!

Steve / Futurile

Message #20 received at 72572-quiet <at> debbugs.gnu.org (full text, mbox):

From: Adam Faiz <adam.faiz <at> disroot.org>
To: Steve George <steve <at> futurile.net>, 72572-quiet <at> debbugs.gnu.org
Subject: Re: bug#72572: adding elinks to Guix
Date: Fri, 22 Nov 2024 23:55:17 +0800

Hi Steve,

On 11/22/24 22:52, Steve George wrote:
> Hi Adam,
> 
> You submitted a patch to add Elinks to Guix. Last I saw there was a request to move it to the meson-build-system. Is that something that you have the time/interest to do? It would be great to get this contribution into the repo!
> 
> Steve / Futurile
> 
> 

Switching it to the meson-build-system is not something that I have interest in doing personally, but I won't stop anyone that wants to. I don't have the time to address the licensing details with the elinks package right now, unfortunately.

Message #21 received at 72572-quiet <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Steve George <steve <at> futurile.net>
Cc: 72572-quiet <at> debbugs.gnu.org
Subject: Re: bug#72572: adding elinks to Guix
Date: Thu, 20 Feb 2025 17:25:00 +0100

Hi,

On Fri, 22 Nov 2024 at 14:52, Steve George <steve <at> futurile.net> wrote:
> Hi Adam,
>
> You submitted a patch to add Elinks to Guix. Last I saw there was a
> request to move it to the meson-build-system. Is that something that
> you have the time/interest to do? It would be great to get this
> contribution into the repo!

This patch is marked as moreinfo and reviewed-looks-good.

Steve, if you think that’s worth to merge it, feel free to use your
super power. :-)  Else let close it.

Cheers,
simon

Message #22 received at 72572-quiet <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 72572-quiet <at> debbugs.gnu.org
Subject: Re: bug#72572: adding elinks to Guix
Date: Fri, 21 Feb 2025 10:36:30 +0000

On 20/02/2025 16:25, Simon Tournier wrote:
> Hi,
> 
> On Fri, 22 Nov 2024 at 14:52, Steve George <steve <at> futurile.net> wrote:
>> Hi Adam,
>>
>> You submitted a patch to add Elinks to Guix. Last I saw there was a
>> request to move it to the meson-build-system. Is that something that
>> you have the time/interest to do? It would be great to get this
>> contribution into the repo!
> 
> This patch is marked as moreinfo and reviewed-looks-good.
> 
> Steve, if you think that’s worth to merge it, feel free to use your
> super power. :-)  Else let close it.
(...)

I'm having problems with my key not being recognised, so it seemed like 
an opportunity to try out the PR process. I've created a PR here:

https://codeberg.org/civodul/guix/pulls/9

If/When it's merged I'll close this off.

Thanks,

Steve /  Futurile

Message #27 received at 72572-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 72572-done <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, Adam Faiz <adam.faiz <at> disroot.org>,
 Steve George <steve <at> futurile.net>, Simon Tournier <zimon.toutoune <at> gmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Subject: Re: [PATCH] gnu: Add elinks.
Date: Wed, 26 Feb 2025 21:17:04 +0100

Hello,

> On 20/02/2025 16:25, Simon Tournier wrote:
> > Hi,
> > 
> > On Fri, 22 Nov 2024 at 14:52, Steve George <steve <at> futurile.net> wrote:
> >> Hi Adam,
> >>
> >> You submitted a patch to add Elinks to Guix. Last I saw there was a
> >> request to move it to the meson-build-system. Is that something that
> >> you have the time/interest to do? It would be great to get this
> >> contribution into the repo!
> > 
> > This patch is marked as moreinfo and reviewed-looks-good.
> > 
> > Steve, if you think that’s worth to merge it, feel free to use your
> > super power. :-)  Else let close it.
> (...)
> 
> I'm having problems with my key not being recognised, so it seemed like 
> an opportunity to try out the PR process. I've created a PR here:
> 
> https://codeberg.org/civodul/guix/pulls/9
> 
> If/When it's merged I'll close this off.

I pushed Elinks patch without reading your response. Sorry for the
duplicate work.

Note that I couldn’t make meson recognize gpm either. I left a FIXME for
that.

Thanks!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.