GNU bug report logs - #72579
29.4; Viper does not handle changing cursor colour well

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 11 Aug 2024 15:14:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 11 11:14:08 2024
Received: from localhost ([127.0.0.1]:41865 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sdAGl-0007uh-QP
	for submit <at> debbugs.gnu.org; Sun, 11 Aug 2024 11:14:08 -0400
Received: from lists.gnu.org ([209.51.188.17]:43880)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zharmeny@HIDDEN>) id 1sd9DL-0005zZ-QS
 for submit <at> debbugs.gnu.org; Sun, 11 Aug 2024 10:06:32 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <zharmeny@HIDDEN>)
 id 1sd9Cq-0004Qe-Ld
 for bug-gnu-emacs@HIDDEN; Sun, 11 Aug 2024 10:06:00 -0400
Received: from mail-40137.protonmail.ch ([185.70.40.137])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <zharmeny@HIDDEN>)
 id 1sd9Co-0005Er-UB
 for bug-gnu-emacs@HIDDEN; Sun, 11 Aug 2024 10:06:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail3; t=1723385149; x=1723644349;
 bh=6+rXb4LpMvHU75Aej9IDlEB7bNVI6Lx+omIuw55UGOk=;
 h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:
 Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;
 b=wRSYihKJfjhZndiLW2EmueGnu+lSnb+hJcQxbldBQ6Uksmf90UO2h38iuPccGwugw
 2W4C/+GUzZsK1W5GnOGJsTQpKGof6cq4Mfnc4vm8YWjN4Vg03jFE8XU4Djqtijg9gA
 mcWWF0olVva/fPPcqiDalNfIoJIby+7T0i5aO/VPdPK+bf7JpeUc7LmO7Nv1XSMKwO
 1B8GXWViBbXEloxE0BOVh+ma+wyoxxGp9MOQwowb2iRsN2Oo7v5TOvOEsgKqkJq9S5
 BS5/OIofhHIkg8jy/TVE1mxR4HmiDOHs55mbFX6oOMDlXf8yLOCuxxrKE4ESioOVWM
 EUeo2r7z+G63w==
Date: Sun, 11 Aug 2024 14:05:44 +0000
To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN>
From: ZharMeny <zharmeny@HIDDEN>
Subject: 29.4; Viper does not handle changing cursor colour well
Message-ID: <dTShxM3aEpuzJxisTx7Uj0k3lpmWriTObFe-S5Pont8NTq3IsaFT9Sq28tQLSajQA838LMem6C_9GORL87oQKdwPxLHXYy178MXDM9RWwk0=@protonmail.com>
Feedback-ID: 90799146:user:proton
X-Pm-Message-ID: 25e8ea112eae61b332d9e80580e4dc3876dbbe72
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.40.137;
 envelope-from=zharmeny@HIDDEN; helo=mail-40137.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sun, 11 Aug 2024 11:14:06 -0400
Cc: "info@HIDDEN" <info@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

If you change the cursor colour with viper-mode enabled, it will use the 'r=
emembered' cursor colour from the previous theme, which makes cursor practi=
cally invisible if switching between dark and light themes.

Here's an `emacs -Q` reproduction:

  (load-theme 'modus-operandi)
  (viper-mode)
  (modus-themes-toggle)

The (internal) variable `viper-vi-state-cursor-color` seems to be the culpr=
it, as it remembers the cursor color of the theme that is no longer active =
after the toggle.

This problem is not specific to modus-themes, any theme should work.