X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Troy Brown <brownts@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 13 Aug 2024 01:18:02 +0000 Resent-Message-ID: <handler.72597.B.172351186112930 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 72597 <at> debbugs.gnu.org Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.172351186112930 (code B ref -1); Tue, 13 Aug 2024 01:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Aug 2024 01:17:41 +0000 Received: from localhost ([127.0.0.1]:43948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sdgAP-0003MU-CU for submit <at> debbugs.gnu.org; Mon, 12 Aug 2024 21:17:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:46886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy.s.brown@HIDDEN>) id 1sdgAJ-0003MG-NY for submit <at> debbugs.gnu.org; Mon, 12 Aug 2024 21:17:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <troy.s.brown@HIDDEN>) id 1sdg9k-0004xA-Th for bug-gnu-emacs@HIDDEN; Mon, 12 Aug 2024 21:17:02 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <troy.s.brown@HIDDEN>) id 1sdg9h-0004SX-VO for bug-gnu-emacs@HIDDEN; Mon, 12 Aug 2024 21:17:00 -0400 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5b9d48d1456so1303779a12.1 for <bug-gnu-emacs@HIDDEN>; Mon, 12 Aug 2024 18:16:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723511814; x=1724116614; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZxoNvcv+MJeaqaChXRPZ1Ic+Qsw9RX1itRfksBY1nxk=; b=KO9VX0NezqHA8yfhhXh3Go/XX9dqMRV6W33ZQ6gqv9VhnsC4NawYDdLcvl4cDpEjLU 5sB9maR/MkjrZhaEs20Ow9mnO72vHVtH8kCQ6yuXhGt1XNF9tcNSJ5e95/RGdZ2OOlqc nr2iYyGZKp0a/jH4c2Jrj8RgKWsnZvtbgXNZiTJtYqyNskEBiywU4XtOZKABY0pCxKa/ Uv+cpbmxA5KTSuojz1oqbD4mCImehZkkQlnmJ/krkrl00eCvj6A8RwhxXcfD9fb/IJlA BUStLDqMiKEPDZ8nIBLAp4sLhyitoAS8G1dJY4XcG390LXsgRNQjOIttNtcDHGo8qDFX Vmuw== X-Gm-Message-State: AOJu0YxsudToXa3UlATCKA1usSwgds8z0/b71OysnIjBQSH+7zuvhqg5 6NZIp6aF2fqQIi7owhX/o4Q/UJaToA/VF1ZAVzYEU9NJuiZxTp4boFdc11ru X-Google-Smtp-Source: AGHT+IGUmCTBYVQlhdwsQC03UNPWngL4lE4ERQXX3nRe3CwoiUfzPoIwSBQQZ9vXttbshBwgeUk+AQ== X-Received: by 2002:a05:6402:51ca:b0:5b4:ec9d:d66a with SMTP id 4fb4d7f45d1cf-5bd461c9a9dmr1141960a12.15.1723511813029; Mon, 12 Aug 2024 18:16:53 -0700 (PDT) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com. [209.85.218.44]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bd1a5e1109sm2697241a12.68.2024.08.12.18.16.52 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 18:16:52 -0700 (PDT) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7a94478a4eso958159266b.1 for <bug-gnu-emacs@HIDDEN>; Mon, 12 Aug 2024 18:16:52 -0700 (PDT) X-Received: by 2002:a17:907:6ea0:b0:a7a:b26d:fb5 with SMTP id a640c23a62f3a-a80f0b18678mr128564666b.19.1723511812253; Mon, 12 Aug 2024 18:16:52 -0700 (PDT) MIME-Version: 1.0 From: Troy Brown <brownts@HIDDEN> Date: Mon, 12 Aug 2024 21:16:40 -0400 X-Gmail-Original-Message-ID: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> Message-ID: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.208.54; envelope-from=troy.s.brown@HIDDEN; helo=mail-ed1-f54.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) With the LSP language server I'm using, it's possible the language server will return a textDocument/hover response MarkedString containing "\r" (i.e., carriage return) for the line terminator when the content contains multiple lines. An example of a typical response is as follows: [jsonrpc] e[19:19:44.606] <-- textDocument/hover[38] {"jsonrpc":"2.0","id":38,"result":{"contents":[{"language":"gpr","value":"type Library_Kinds is (\"relocatable\", \"static\", \"static-pic\");\rLibrary_Kind : Library_Kinds := \"static\";"},"gtkada_shared.gpr:37:04"]}} The font locking is performed correctly (as the highlighting looks fine), but when the content is placed in the *eldoc* buffer, content surrounding the carriage return is not placed on separate lines. Instead it remains on the same line and "^M" is displayed in the buffer. This is what I expect: type Library_Kinds is ("relocatable", "static", "static-pic"); Library_Kind : Library_Kinds := "static"; gtkada_shared.gpr:37:04 This is what I'm observing (single line with embedded ^M): type Library_Kinds is ("relocatable", "static", "static-pic");^MLibrary_Kind : Library_Kinds := "static"; gtkada_shared.gpr:37:04
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Troy Brown <brownts@HIDDEN> Subject: bug#72597: Acknowledgement (30.0.60; Eglot: MarkedString with embedded Carriage Return) Message-ID: <handler.72597.B.172351186112930.ack <at> debbugs.gnu.org> References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> X-Gnu-PR-Message: ack 72597 X-Gnu-PR-Package: emacs Reply-To: 72597 <at> debbugs.gnu.org Date: Tue, 13 Aug 2024 01:18:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 72597 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 72597: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72597 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 13 Aug 2024 11:19:02 +0000 Resent-Message-ID: <handler.72597.B72597.172354793612503 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Troy Brown <brownts@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172354793612503 (code B ref 72597); Tue, 13 Aug 2024 11:19:02 +0000 Received: (at 72597) by debbugs.gnu.org; 13 Aug 2024 11:18:56 +0000 Received: from localhost ([127.0.0.1]:44528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sdpYG-0003Fa-3O for submit <at> debbugs.gnu.org; Tue, 13 Aug 2024 07:18:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sdpYD-0003FF-Bn for 72597 <at> debbugs.gnu.org; Tue, 13 Aug 2024 07:18:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sdpXZ-0008Mo-4g; Tue, 13 Aug 2024 07:18:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MMVFOjgtEblYuFKnAS/PTN10B5NEZNKVoqAXrDB0K5s=; b=id4n+Monp+UxLxzCf/Ru 2AwQp80EmkwLJ3nNl81MJAvyv0tGmBFEK42OSVW8PkVVHdUO+TMZbAp9N6uZQMAfdKedoHToplCHi +WmcR6P3971gD18ppneL5yEalMNmh3r2pmiEKPKvPn56yH4w7QB2lmlAzWaT6f27rYlo1ojfkZDkL zqFvc9QctqgOfIR8YwjphKbwWbkFOfoLJQTBp61tPYQIU/IXbGZ9TAnfOgYatd6NSfY2FWz6Ymd9P znKytbIyTDa9WvNs+HS6LLlw//dSDEFfehj0sMoTmu3wyIBC45bgglAQs5H5QGOfMU7tqMwqWF/3l tQCXLMY/HpWJmg==; Date: Tue, 13 Aug 2024 14:18:10 +0300 Message-Id: <86h6bohdsd.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> (message from Troy Brown on Mon, 12 Aug 2024 21:16:40 -0400) References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: João Távora <joaotavora@HIDDEN> > From: Troy Brown <brownts@HIDDEN> > Date: Mon, 12 Aug 2024 21:16:40 -0400 > > With the LSP language server I'm using, it's possible the language > server will return a textDocument/hover response MarkedString > containing "\r" (i.e., carriage return) for the line terminator when > the content contains multiple lines. An example of a typical response > is as follows: > > [jsonrpc] e[19:19:44.606] <-- textDocument/hover[38] > {"jsonrpc":"2.0","id":38,"result":{"contents":[{"language":"gpr","value":"type > Library_Kinds is (\"relocatable\", \"static\", > \"static-pic\");\rLibrary_Kind : Library_Kinds := > \"static\";"},"gtkada_shared.gpr:37:04"]}} Does this behavior comply to the LSP standards?
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Felician Nemeth <felician.nemeth@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 13 Aug 2024 18:34:01 +0000 Resent-Message-ID: <handler.72597.B72597.17235740296758 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, Troy Brown <brownts@HIDDEN>, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.17235740296758 (code B ref 72597); Tue, 13 Aug 2024 18:34:01 +0000 Received: (at 72597) by debbugs.gnu.org; 13 Aug 2024 18:33:49 +0000 Received: from localhost ([127.0.0.1]:45493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sdwL6-0001kv-Ix for submit <at> debbugs.gnu.org; Tue, 13 Aug 2024 14:33:48 -0400 Received: from mail-ej1-f54.google.com ([209.85.218.54]:57421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felician.nemeth@HIDDEN>) id 1sdwL4-0001ke-8N for 72597 <at> debbugs.gnu.org; Tue, 13 Aug 2024 14:33:47 -0400 Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a7a8a4f21aeso625934366b.2 for <72597 <at> debbugs.gnu.org>; Tue, 13 Aug 2024 11:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723573927; x=1724178727; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qR+YDW9S0ORb9JWEj/CvSdYqa6NXui7Tt49JQLIZoXk=; b=SuqgZVWdl2P+Dy+UUaxPf4WKPL7mIDdTKNkZqxVUwgn22UsrGWavyOnvnalBOX4led I/HYLpfk7NhdpP5yqtKKTVgHh4y3fUVAOBHViY/4GMVouOmNeaDL65z5DzDdm4L79M6c gKKPCxt1hfD61JzrigZzPmwPUMgtTM6H8CJX9bsmFKAgzqKq59CQ+KmmjBgi9MkWRk0t sdsYK03TfXUjs0miaFHydqNbq0VSk8FfePUi8168UrnGh7T0JSkGobKuqUfgNBKyXbiG 2lA0AwOmUF3x0A44PbBwHccFxBPy5tnJHGDGH1cRJpSKAW4RIfgM66/cFmSNgXLynuOT WLZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723573927; x=1724178727; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qR+YDW9S0ORb9JWEj/CvSdYqa6NXui7Tt49JQLIZoXk=; b=FgaBl99DJkD2mq9wPIk9WY1MItzKrXyMqyjNjpDf6ujwYkFUwBQq+B8pV6Lc48ECug rG50xMXayEjSWxuJu0Bk4f2/whUzGuEjEGxJD2b2AlXjb4yqqaBEJ6CWWXNqtyJv1kNX 8t04YPJ/4VjsHxmfNpjRyJIOaQGZoj7CG/06vU4pu+5wlbbT4wqE7R+nakOMtUfx1nt3 PDRkMx+i2m21K6zepX04UVE+aZRta5S9RCV/I8x3/5KrIDgmV7mp3r8VqORodT5ry4L4 N0A05E9yATbpD5u2w54IUi1cBMfPgaFYeq2PybeVi8AlMk6ODRzZB7OgHgpwGb63CByS XMqA== X-Forwarded-Encrypted: i=1; AJvYcCX5EvUTlBnCOOhvXma45jScBW/XE+zEVqKWDn33xI9OIhXLrqcjPVdUnLvf7wAg9LDHBRfHJg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz0uIzlHAylCi3u/0/pVa6zSyhr5W45SxRGoZ5xxV15KdZjN3A9 Rza8peJVxMwjihuXcpEcyDKCYR6TmsGSHBNaA3UEZs++TAREI9cy X-Google-Smtp-Source: AGHT+IFKoRPHnZZ3tn/Ndzvlpz+1b/vFNujdHqQvJbAT4WE9am9q8n6zRiUwM/dNn4dHRGU8UFsS9w== X-Received: by 2002:a17:907:e257:b0:a77:e0ed:8c4 with SMTP id a640c23a62f3a-a8366c10d6emr16840466b.7.1723573926327; Tue, 13 Aug 2024 11:32:06 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f3fedd2asm88820766b.96.2024.08.13.11.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 11:32:06 -0700 (PDT) From: Felician Nemeth <felician.nemeth@HIDDEN> References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> Date: Tue, 13 Aug 2024 20:32:04 +0200 In-Reply-To: <86h6bohdsd.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 13 Aug 2024 14:18:10 +0300") Message-ID: <87v804mfyz.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> Cc: Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> >> From: Troy Brown <brownts@HIDDEN> >> Date: Mon, 12 Aug 2024 21:16:40 -0400 >>=20 >> With the LSP language server I'm using, it's possible the language >> server will return a textDocument/hover response MarkedString >> containing "\r" (i.e., carriage return) for the line terminator when >> the content contains multiple lines. An example of a typical response >> is as follows: >>=20 >> [jsonrpc] e[19:19:44.606] <-- textDocument/hover[38] >> {"jsonrpc":"2.0","id":38,"result":{"contents":[{"language":"gpr","value"= :"type >> Library_Kinds is (\"relocatable\", \"static\", >> \"static-pic\");\rLibrary_Kind : Library_Kinds :=3D >> \"static\";"},"gtkada_shared.gpr:37:04"]}} > > Does this behavior comply to the LSP standards? The way I understand it, Eglot calls gfm-view-mode to format this text. So even if the observed behavior is not in line with the LSP specification, it is the fault of gfm-view-mode and not directly Eglot's. gfm-view-mode is part of the markdown-mode package, which is NonGNU ELPA.
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 13 Aug 2024 18:48:02 +0000 Resent-Message-ID: <handler.72597.B72597.17235748338417 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Felician Nemeth <felician.nemeth@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Troy Brown <brownts@HIDDEN> Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.17235748338417 (code B ref 72597); Tue, 13 Aug 2024 18:48:02 +0000 Received: (at 72597) by debbugs.gnu.org; 13 Aug 2024 18:47:13 +0000 Received: from localhost ([127.0.0.1]:45498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sdwY5-0002Bh-0R for submit <at> debbugs.gnu.org; Tue, 13 Aug 2024 14:47:13 -0400 Received: from mail-oo1-f47.google.com ([209.85.161.47]:54539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sdwY3-0002BQ-Mw for 72597 <at> debbugs.gnu.org; Tue, 13 Aug 2024 14:47:12 -0400 Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-5d59e491fefso2844580eaf.1 for <72597 <at> debbugs.gnu.org>; Tue, 13 Aug 2024 11:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723574732; x=1724179532; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vqU21Gyv4bLmzB33xjnaal2byx+p6MSFR3PmYkf78h8=; b=StWcwYybl/YHlHZM1FDgLDoLDZxV8zk0DJkYSDG/nIvKNNSxMICJFlwrpf0BhHe5jM L3VXkCW2N1asYPATwbBbYsF5vBztFsjkhQd57nLd1jeb2Eo2K2GLDKrdlKmieDmnHUbi oFDbgN7LxVS8P+WDhn8LQVXYW0ual/c8loElZOJF4TZtLCO1Y+bpDXrLmOF22UECSMtY 5qCKG4nUs8h7g+TyYSyPMpSXHr2wyLyTdVBym4/s5Pu89yA8e4pkd6zs3IKJDqo8MLW3 EjrSLLcKKNK34LU8PW2ARV+2pSbBcAMxpe+PM9XxUl5SD0HW++SYgWDUiXTujTfOoL5d tMFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723574732; x=1724179532; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vqU21Gyv4bLmzB33xjnaal2byx+p6MSFR3PmYkf78h8=; b=oEoNcFtIUOVmvL/bS1dd8T0qThQTrccrpW+8H4/P+Gqlk/Oj8V6KMrrmJW512IrKxG vtGFq3gNiFCKcNSK0LCfx7l24eoXGuygRw2QxTwbTyvqeG4aGb12gVwW7MGmXl2Sh/jy lij4PWw+cC2VsDQHGBDbIjtJRy/B9sojlLnCzY+Q6Yh0Svgau3BQtH+Wd5BoygN3iuvO JEUpoSm2wsHZrht+XmPqzhNB+YnMNni1OtB+eaBnewJBM2QLG8hw2Sz3MnBK+/J4mscr 3Ly+LCkuNY9MTot0Znazl6ONh3rY0VHyi+biadgZKPP7gKDDmauNwkwiqx2Zxwf9kUJv bR0A== X-Forwarded-Encrypted: i=1; AJvYcCWgtortdMt1Ay6REzbYI1kRa13rP100guLEA0termMHC4v+cxz4DIr4Ntds+W26X7yFz0rVfwvfi7W/+raOUJ+uVAm+47g= X-Gm-Message-State: AOJu0Yx/AIV+C6iy00hnErrWFq82unRYIDO66XLEWNtwG3C+UhDQcBeF IjOVrx4UpiMx9JBnwg+blfCAeYgaUHcwjGPe5gyplIyWi74fZQavvtxpuPkZQduaDYxTJsp8UZM SSM8ys9h5eVt/hYA+lQ5WMvk1sQg= X-Google-Smtp-Source: AGHT+IG0vASzJY9elRZycFfUerLJi9HDrSfT2UpMSclvrpbwDuzLvnrTfby9I6fCSv4odn6AdTcUYlu//jH2NK/vzoc= X-Received: by 2002:a05:6820:80c:b0:5d8:4845:1a4e with SMTP id 006d021491bc7-5da7c48984amr830843eaf.0.1723574732155; Tue, 13 Aug 2024 11:45:32 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> In-Reply-To: <87v804mfyz.fsf@HIDDEN> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Date: Tue, 13 Aug 2024 19:45:20 +0100 Message-ID: <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, Aug 13, 2024 at 7:32=E2=80=AFPM Felician Nemeth <felician.nemeth@HIDDEN> wrote: > The way I understand it, Eglot calls gfm-view-mode to format this text. > So even if the observed behavior is not in line with the LSP > specification, it is the fault of gfm-view-mode and not directly > Eglot's. > > gfm-view-mode is part of the markdown-mode package, which is NonGNU > ELPA. Very correct. Worth noting, though, that markdown-mode is an _optional_ dependency of Eglot. It doesn't need it (but it will use it if it finds it)= . Jo=C3=A3o
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Troy Brown <brownts@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 13 Aug 2024 21:37:02 +0000 Resent-Message-ID: <handler.72597.B72597.17235850166227 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, 72597 <at> debbugs.gnu.org, Felician Nemeth <felician.nemeth@HIDDEN> Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.17235850166227 (code B ref 72597); Tue, 13 Aug 2024 21:37:02 +0000 Received: (at 72597) by debbugs.gnu.org; 13 Aug 2024 21:36:56 +0000 Received: from localhost ([127.0.0.1]:45596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sdzCJ-0001cM-TG for submit <at> debbugs.gnu.org; Tue, 13 Aug 2024 17:36:56 -0400 Received: from mail-lj1-f179.google.com ([209.85.208.179]:60926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy.s.brown@HIDDEN>) id 1sdzCE-0001bn-OJ for 72597 <at> debbugs.gnu.org; Tue, 13 Aug 2024 17:36:51 -0400 Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2f136e23229so63925211fa.1 for <72597 <at> debbugs.gnu.org>; Tue, 13 Aug 2024 14:36:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723584970; x=1724189770; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7b6C247eVgj12aIPeZPu6ZcDOyI4mW7PGmZKbPhlJTk=; b=qHEGk0xuuRG2qehERNMvwiWN0EIojfs2T7RmJAyUBeLMdxJUotzYHo/dlj1x4jMuCW pLr/sBqkCelFrl5Tuv4gJVV33mZdk797K25CsLzZDm5604MRgC8OvItu7WcO/kJ95RyQ eqDK97PkiVWL5ChYKo1Tr7IgMG+6bgjnImId0Vf2lWlyaxTJZ8J60H2PMyRc8x328eME 1XqPP9KbWvrCM3FEIIUXbz0e8bvQUMo8D1MDRcauDdRPWFjAug1PWw14yB/nk2cBA81E e0XRxt54AZFxQvtwZfnglnQXW28SZ2qJKydjzwIAkuZwZClEk2iGajqrUo6B15NzsS7I T05Q== X-Forwarded-Encrypted: i=1; AJvYcCXCV3QwVJUxRE0xi43nXlybVI5eSBv3gx4IPxTWrJUCA5XiXSg7IiOfRsYOcOawj1hW6WyWsHmLKIpGlEd2jsEoqHeA86M= X-Gm-Message-State: AOJu0Yyra9bIiD8a4Bgq4JHZgtUTwIuFxALJ8ksqu6lS2PRfgaLE5DxB xUYfAWbevR1TCvdx1Gq/nOX51zjjDHC7DfBYcPQ8B2l+Pnp832ZyMWRXyS3xWTY= X-Google-Smtp-Source: AGHT+IFalbU+YS93uPoZPO+01nXJaclUcxEOl0QVXTQNKd9YnVzdvH4eEYlX6R3gWUOy+26EoyNyQQ== X-Received: by 2002:a2e:1319:0:b0:2ef:2c4b:b799 with SMTP id 38308e7fff4ca-2f3aa1d3e86mr3688361fa.28.1723584969545; Tue, 13 Aug 2024 14:36:09 -0700 (PDT) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bd1a5e1109sm3442616a12.68.2024.08.13.14.36.09 for <72597 <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 14:36:09 -0700 (PDT) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5bb477e3a6dso5794655a12.0 for <72597 <at> debbugs.gnu.org>; Tue, 13 Aug 2024 14:36:09 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWBDADNIi5O23CMbKePnp4429Ev17GWI/Abh60BYotr5bAugMUUstJHAaQYnlBo4mqYimraXH05Ax39KGGoESU7Y2vkdfI= X-Received: by 2002:a05:6402:4412:b0:5ab:324c:d77d with SMTP id 4fb4d7f45d1cf-5bea1c6a9a0mr571394a12.1.1723584968994; Tue, 13 Aug 2024 14:36:08 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> In-Reply-To: <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> From: Troy Brown <brownts@HIDDEN> Date: Tue, 13 Aug 2024 17:35:57 -0400 X-Gmail-Original-Message-ID: <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> Message-ID: <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, Aug 13, 2024 at 2:45=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora@g= mail.com> wrote: > > On Tue, Aug 13, 2024 at 7:32=E2=80=AFPM Felician Nemeth > <felician.nemeth@HIDDEN> wrote: > > > The way I understand it, Eglot calls gfm-view-mode to format this text. > > So even if the observed behavior is not in line with the LSP > > specification, it is the fault of gfm-view-mode and not directly > > Eglot's. > > > > gfm-view-mode is part of the markdown-mode package, which is NonGNU > > ELPA. > > Very correct. Worth noting, though, that markdown-mode is an _optional_ > dependency of Eglot. It doesn't need it (but it will use it if it finds i= t). > I don't think it's gfm-view-mode's fault. I can get the same problematic behavior with MarkupContent of "plaintext" (which uses text-mode), as follows: (eglot--format-markup '(:value "foo\rbar" :kind "plaintext"))
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 14 Aug 2024 04:38:01 +0000 Resent-Message-ID: <handler.72597.B72597.172361026826599 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Troy Brown <brownts@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, felician.nemeth@HIDDEN, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172361026826599 (code B ref 72597); Wed, 14 Aug 2024 04:38:01 +0000 Received: (at 72597) by debbugs.gnu.org; 14 Aug 2024 04:37:48 +0000 Received: from localhost ([127.0.0.1]:45817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1se5lc-0006uw-0t for submit <at> debbugs.gnu.org; Wed, 14 Aug 2024 00:37:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1se5lZ-0006ue-NJ for 72597 <at> debbugs.gnu.org; Wed, 14 Aug 2024 00:37:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1se5kv-0002OO-0S; Wed, 14 Aug 2024 00:37:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=i3KjggmzlPX+NlTsDT6x+mc51VJq2Bfa7Z9Ji2Uad+E=; b=a1qxwtWKSo+8RxIYG19Z a61xQI276P6sp9agiDrJNiNVtqJ71Scmso/kOn8qIUacIX+JZ/snRxkuiQxAZsrRxKqRDGYLx+qnY b5srilJM9zyIHTwpy5yIZArIsSxmZkmRUJfGI07BGk8CzmT3Y2YjMVaI2RTqHiwPVbBJslkvMCD6x OImKSZkYK/VCt3PzJmb8Iz940IVVhHm1sWM5KyF1Z1poN8Q1v0XZB9552/Y4kAEUJrTGatrsReP0g 8CMmey+B7Rf1n/53Kwfa9sEKauF3CvpIb1ip84rmn7rOder9S0ohOMwfL+rRwdcDloPJ4+cVITkDK 1TAYAvO3Gpik5Q==; Date: Wed, 14 Aug 2024 07:37:01 +0300 Message-Id: <86v803g1oy.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> (message from Troy Brown on Tue, 13 Aug 2024 17:35:57 -0400) References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Troy Brown <brownts@HIDDEN> > Date: Tue, 13 Aug 2024 17:35:57 -0400 > Cc: Felician Nemeth <felician.nemeth@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 72597 <at> debbugs.gnu.org > > On Tue, Aug 13, 2024 at 2:45 PM João Távora <joaotavora@HIDDEN> wrote: > > > > On Tue, Aug 13, 2024 at 7:32 PM Felician Nemeth > > <felician.nemeth@HIDDEN> wrote: > > > > > The way I understand it, Eglot calls gfm-view-mode to format this text. > > > So even if the observed behavior is not in line with the LSP > > > specification, it is the fault of gfm-view-mode and not directly > > > Eglot's. > > > > > > gfm-view-mode is part of the markdown-mode package, which is NonGNU > > > ELPA. > > > > Very correct. Worth noting, though, that markdown-mode is an _optional_ > > dependency of Eglot. It doesn't need it (but it will use it if it finds it). > > > > I don't think it's gfm-view-mode's fault. I can get the same > problematic behavior with MarkupContent of "plaintext" (which uses > text-mode), as follows: > > (eglot--format-markup '(:value "foo\rbar" :kind "plaintext")) Can you please answer my question whether this is standard-complying behavior according to LSP protocol? IOW, what is the source of the assumption that CR characters will be interpreted as newlines in these cases?
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Felician Nemeth <felician.nemeth@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 14 Aug 2024 05:57:02 +0000 Resent-Message-ID: <handler.72597.B72597.17236149692562 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, Troy Brown <brownts@HIDDEN>, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.17236149692562 (code B ref 72597); Wed, 14 Aug 2024 05:57:02 +0000 Received: (at 72597) by debbugs.gnu.org; 14 Aug 2024 05:56:09 +0000 Received: from localhost ([127.0.0.1]:45860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1se6zR-0000fG-14 for submit <at> debbugs.gnu.org; Wed, 14 Aug 2024 01:56:09 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:59840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felician.nemeth@HIDDEN>) id 1se6zO-0000el-HF for 72597 <at> debbugs.gnu.org; Wed, 14 Aug 2024 01:56:07 -0400 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3687f8fcab5so3290591f8f.3 for <72597 <at> debbugs.gnu.org>; Tue, 13 Aug 2024 22:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723614866; x=1724219666; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=8o6bZ7O5D+XaldzbNxovpNXJbBIKEySuOFbllb7+dUE=; b=JYCAI1NSmFo3oOmPRyAz4bPw5xVkoNw3XOdgt0uY5KUVCD7940sNQ7gWrcUmlrbq5K M9cVoBesevtp6vJovlktu80daTMPtIVpILAGme8yz0Uf/1q/vkDCo+LNo9Rj6omlG0dU mTD2MQ5csq+Ho+neLMHWuGWYHFsM23tb59guXuTE9LTyaqe0sdyntNMH69ndOdBGYuJ9 toUVFplwzKBMbs1MqQDynHpUOJMatMn2YqoxUOed1r1PgN4qLp007K1s5TDlHjkSaUss W0kCRIa0+16LOKLboEjgCNBebToRC50cSHhVi4yhyOIGvVr+04ggX6pQ2GL+dkH0ULUR 5EfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723614866; x=1724219666; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8o6bZ7O5D+XaldzbNxovpNXJbBIKEySuOFbllb7+dUE=; b=ah8/uq1/11KZcZAGhAuOfCFrP6aWiNXplZ33tG5MPpuyjGOKZyzmqmAN+mposUHN2v Amn0QFYHLUMp0VDailn/Fw0ycuBGiFgvBkSPgoo/7k0vPJhQPR8rInUWJpfm8biuZib7 nicXOE+Gm6fl6f8akVEv+1+IYB3UFE6aiPsk8NEYjlM1Cs0Jroe0Bmjc3buZz6xFnWKb AfpwDj+sD+hBYvotN9l+G1gRzCs0UmggcfbufpgJ6+EwufOCmPtGU5DzvyseDRIeH91Y 3fifiWG/i4zEnuWUwrtKymjeUJ8qkaXXweA34uQjWsqsCP6O92YmTaonbSOQgqbRq3fL wveg== X-Forwarded-Encrypted: i=1; AJvYcCW1hgc1FA4bHS/ew5MnacQnf1Z2MvhjWn/0CeFMh2flnnzzafikc102zvqP+NDrJHAmbc/b4epeayXL7Ykpij1Rd++DlwM= X-Gm-Message-State: AOJu0YyRt0U8IygT1nGeDwTZb633m+lDTkV4Ko0k1DqfI0LEB5FhjGZV TSi6YwvoA32aFckfK8R4wqEWXs5ht6gl9kxSJPg6cmnPa3NFHeHD7GnQvg== X-Google-Smtp-Source: AGHT+IG5u/VDlzEfKEk/Ctv03D/GwWW9XcREGGSSO9gP4tGEORKDdkFx3V0D/ZC11DrNCQST2rj12w== X-Received: by 2002:a5d:4449:0:b0:368:664a:d4f9 with SMTP id ffacd0b85a97d-37177796650mr1200336f8f.28.1723614865805; Tue, 13 Aug 2024 22:54:25 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4c36bce0sm12068583f8f.3.2024.08.13.22.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 22:54:25 -0700 (PDT) From: Felician Nemeth <felician.nemeth@HIDDEN> References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> Date: Wed, 14 Aug 2024 07:54:24 +0200 In-Reply-To: <86v803g1oy.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 14 Aug 2024 07:37:01 +0300") Message-ID: <87le0zmyy7.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1250 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > Can you please answer my question whether this is standard-complying > behavior according to LSP protocol? IOW, what is the source of the > assumption that CR characters will be interpreted as newlines in these > cases? It seems this is standard-complying, because the specification has this: "To ensure that both client and server split the string into the same line representation the protocol specifies the following end-of-line sequences: =91\n=92, =91\r\n=92 and =91\r=92."
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 14 Aug 2024 06:39:02 +0000 Resent-Message-ID: <handler.72597.B72597.17236174826519 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Felician Nemeth <felician.nemeth@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, brownts@HIDDEN, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.17236174826519 (code B ref 72597); Wed, 14 Aug 2024 06:39:02 +0000 Received: (at 72597) by debbugs.gnu.org; 14 Aug 2024 06:38:02 +0000 Received: from localhost ([127.0.0.1]:45889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1se7dx-0001gr-IR for submit <at> debbugs.gnu.org; Wed, 14 Aug 2024 02:38:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1se7dv-0001gZ-Gx for 72597 <at> debbugs.gnu.org; Wed, 14 Aug 2024 02:38:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1se7dG-0003aj-SI; Wed, 14 Aug 2024 02:37:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=4PlcxfLt23lfIrtVlCD2KgaXPiFBZhrOAJDy+3bPPMk=; b=J3vUg6oVZOKzkBeNqefJ qrt9j0FTYkWxO9liqrQAbWwLYSsxler/M67TZch1+8arcJqmm+/UL+7AFZ7DsembmbTehOFbgPShy b005DIQFsCy0ZLjOK/qNLsEgV/c/I81Fy0Cf4QoU95Y4i18W1CBI6GXO7ThufQ6VEkk5H4Es9l3D1 07V2zNdK904oN+elcR8GX4OacEh4i+ut3iZojM3to9XNJ/jBjWxwE7pBTWi61ZglERlCwSi8fkE/+ SBJ6Wu3NghkjYEojOR56DKv0XkB6jO0w753LcL80f72lqdyp+GiT0jelvl4rlk4xC+wPHzG1FHDR8 vvx9R8ZcZD/wJg==; Date: Wed, 14 Aug 2024 09:37:15 +0300 Message-Id: <86ikw3fw4k.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <87le0zmyy7.fsf@HIDDEN> (message from Felician Nemeth on Wed, 14 Aug 2024 07:54:24 +0200) References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=windows-1250 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Felician Nemeth <felician.nemeth@HIDDEN> > Cc: Troy Brown <brownts@HIDDEN>, joaotavora@HIDDEN, > 72597 <at> debbugs.gnu.org > Date: Wed, 14 Aug 2024 07:54:24 +0200 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Can you please answer my question whether this is standard-complying > > behavior according to LSP protocol? IOW, what is the source of the > > assumption that CR characters will be interpreted as newlines in these > > cases? > > It seems this is standard-complying, because the specification has this: > "To ensure that both client and server split the string into the same > line representation the protocol specifies the following end-of-line > sequences: ‘\n’, ‘\r\n’ and ‘\r’." This just caters to the 3 known EOL formats: the Unix, the DOS/Windows, and the Mac one. If this is the basis for the described behavior, then Emacs should bind coding-system-for-read when reading this stuff, or maybe manually decode the strings after detecting EOL format. But that would only work if the EOL format is used consistently in the entire response of the server; if they just use the above as a means to sneak in multiple-line responses, and otherwise use some other EOL format, then we need to handle a lone \r specially in Eglot's code, something I'm not sure we like to do.
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Troy Brown <brownts@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 14 Aug 2024 11:43:02 +0000 Resent-Message-ID: <handler.72597.B72597.17236357534826 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, Felician Nemeth <felician.nemeth@HIDDEN>, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.17236357534826 (code B ref 72597); Wed, 14 Aug 2024 11:43:02 +0000 Received: (at 72597) by debbugs.gnu.org; 14 Aug 2024 11:42:33 +0000 Received: from localhost ([127.0.0.1]:46350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1seCOf-0001Fm-EC for submit <at> debbugs.gnu.org; Wed, 14 Aug 2024 07:42:33 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:45350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy.s.brown@HIDDEN>) id 1seCOc-0001FX-PY for 72597 <at> debbugs.gnu.org; Wed, 14 Aug 2024 07:42:31 -0400 Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5a10bb7bcd0so8088776a12.3 for <72597 <at> debbugs.gnu.org>; Wed, 14 Aug 2024 04:41:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723635709; x=1724240509; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KDBCyHW2pkZ1pZEJjOdPmfKMAwF6nWFVovc983aafN4=; b=KuEiKpCiTBNeiLt0LIN5XSpiByldfat4g7zzduWtYcBEMpzJaAKB3Nm8PXp+z4Z+QG +whwxmLGg0V0a9+PMw1s32vo8snmBOb0lEOZ9Zjq4LhegQlHeoG7JiFHmdx9jW58HUSl cXKSlmsPOHJQymQL0ntuGDnnhQALpoQFW8RqelBbpvvKt/V9swJVcHoCnGIOrWac2fmT W/GCascozAzNlxDa95bcgaNYl3c2lfbytmxYIrkupolw/yLtO4Ixs0z4FU0GHk2lWCyD NyV4NVXEdmnnr7K3I8b4sqUkbB8qaC0nu2qU2pZc4SK59BZmM9Jd/ByHdYASrk/ICBM7 MEwA== X-Forwarded-Encrypted: i=1; AJvYcCX87Xs1heVTH64W4Hi4NgBnDcLQnzikfMTtSzVMJkT/10+t7Y98a4MrfIswglKzFewKDltUbcTXYrOM3u0+k8Fi8NHY6fY= X-Gm-Message-State: AOJu0YydMWllpvAvcV4UpvMdFaut97TngCRsCBg9Q8eDN8/pEZ+ATVHf dv7i7lZNWWMUzL1tfRANFpSCqq1ehfqaC91FKJLjNrFIhkZnRbgX3sqm9+7vNh8= X-Google-Smtp-Source: AGHT+IHLDkBEVzChuUHel4Q00RyrnFWflzr/WSqo0RqjbgWa+veoKY/BakkxS0I9zfNIHLsZi6C2BQ== X-Received: by 2002:a17:907:e20f:b0:a77:b3c4:cd28 with SMTP id a640c23a62f3a-a8366c387a8mr169569366b.9.1723635708264; Wed, 14 Aug 2024 04:41:48 -0700 (PDT) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f411b4d5sm159755066b.119.2024.08.14.04.41.47 for <72597 <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 04:41:47 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5a10bb7bcd0so8088744a12.3 for <72597 <at> debbugs.gnu.org>; Wed, 14 Aug 2024 04:41:47 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCV1A0Oq2g/IPSeqCj+PlZSQLr10YFX+gPozOzfzz5DGKPGIERbMK/5xrhjEtLhyc+KCxYXTG5NjsoCLYlWQ5U+GTAgBI5g= X-Received: by 2002:a05:6402:2354:b0:5bb:b8e1:4653 with SMTP id 4fb4d7f45d1cf-5bea1cac726mr1500924a12.24.1723635707438; Wed, 14 Aug 2024 04:41:47 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> In-Reply-To: <86ikw3fw4k.fsf@HIDDEN> From: Troy Brown <brownts@HIDDEN> Date: Wed, 14 Aug 2024 07:41:36 -0400 X-Gmail-Original-Message-ID: <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> Message-ID: <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Wed, Aug 14, 2024 at 2:37=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote: > > > From: Felician Nemeth <felician.nemeth@HIDDEN> > > Cc: Troy Brown <brownts@HIDDEN>, joaotavora@HIDDEN, > > 72597 <at> debbugs.gnu.org > > Date: Wed, 14 Aug 2024 07:54:24 +0200 > > > > Eli Zaretskii <eliz@HIDDEN> writes: > > > > > Can you please answer my question whether this is standard-complying > > > behavior according to LSP protocol? IOW, what is the source of the > > > assumption that CR characters will be interpreted as newlines in thes= e > > > cases? > > > > It seems this is standard-complying, because the specification has this= : > > "To ensure that both client and server split the string into the same > > line representation the protocol specifies the following end-of-line > > sequences: =E2=80=98\n=E2=80=99, =E2=80=98\r\n=E2=80=99 and =E2=80=98\r= =E2=80=99." > > This just caters to the 3 known EOL formats: the Unix, the > DOS/Windows, and the Mac one. If this is the basis for the described > behavior, then Emacs should bind coding-system-for-read when reading > this stuff, or maybe manually decode the strings after detecting EOL > format. But that would only work if the EOL format is used > consistently in the entire response of the server; if they just use > the above as a means to sneak in multiple-line responses, and > otherwise use some other EOL format, then we need to handle a lone \r > specially in Eglot's code, something I'm not sure we like to do. Other than what Felician already quoted from the LSP specification, there doesn't seem to be much else stated about EOL. In this particular case, I've seen it on both Linux and Windows, therefore the use of the CR doesn't seem to be consistent with the platform or the document format. It's unclear to me why this particular EOL format was chosen for the hover information, but I can't find anything in the specification that says it is incorrect.
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 31 Aug 2024 07:57:01 +0000 Resent-Message-ID: <handler.72597.B72597.172509101723255 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Troy Brown <brownts@HIDDEN>, joaotavora@HIDDEN Cc: 72597 <at> debbugs.gnu.org, felician.nemeth@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172509101723255 (code B ref 72597); Sat, 31 Aug 2024 07:57:01 +0000 Received: (at 72597) by debbugs.gnu.org; 31 Aug 2024 07:56:57 +0000 Received: from localhost ([127.0.0.1]:53828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1skIyf-000630-5f for submit <at> debbugs.gnu.org; Sat, 31 Aug 2024 03:56:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1skIyd-00062l-C6 for 72597 <at> debbugs.gnu.org; Sat, 31 Aug 2024 03:56:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1skIxa-0003tb-Vf; Sat, 31 Aug 2024 03:55:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YhuujxZ+MPcruK8N50IqygL9FNpIg8lq6M/WxYD3KF0=; b=hi8Xk6kQpKokp2xfaA+v 1VLsF+J9ULOVlj2iF6LGdGeoAqE7po9AVUVIX+N/dVC167IQFrvECE9iVOxyXblUXOVrVbPRwt/dN 6mlaPF/uKDdaPuNGenF3jh7equ7YdC3ix4PSugrh1cb5vhHB1GNQ0YKXyLl/qtkbq2ieZN18v/7Ch t/7jxv1hGoTenayq/y6pey1YmCtu1dGz3koef2UAKD+khmakKUqOUWODkiagvkQHeiI/mFkzG+qXQ +XsshKrbLpCSeZuqniV3d9An1unBx5ZMDQ+MRtykz8fdQjvkdMmczq6f596jxlamcMWALiy8IPw8B q81+ZM8pGNNyeA==; Date: Sat, 31 Aug 2024 10:55:44 +0300 Message-Id: <86wmjxcein.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> (message from Troy Brown on Wed, 14 Aug 2024 07:41:36 -0400) References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! How can we make progress with this issue? > From: Troy Brown <brownts@HIDDEN> > Date: Wed, 14 Aug 2024 07:41:36 -0400 > Cc: Felician Nemeth <felician.nemeth@HIDDEN>, joaotavora@HIDDEN, 72597 <at> debbugs.gnu.org > > On Wed, Aug 14, 2024 at 2:37 AM Eli Zaretskii <eliz@HIDDEN> wrote: > > > > > From: Felician Nemeth <felician.nemeth@HIDDEN> > > > Cc: Troy Brown <brownts@HIDDEN>, joaotavora@HIDDEN, > > > 72597 <at> debbugs.gnu.org > > > Date: Wed, 14 Aug 2024 07:54:24 +0200 > > > > > > Eli Zaretskii <eliz@HIDDEN> writes: > > > > > > > Can you please answer my question whether this is standard-complying > > > > behavior according to LSP protocol? IOW, what is the source of the > > > > assumption that CR characters will be interpreted as newlines in these > > > > cases? > > > > > > It seems this is standard-complying, because the specification has this: > > > "To ensure that both client and server split the string into the same > > > line representation the protocol specifies the following end-of-line > > > sequences: ‘\n’, ‘\r\n’ and ‘\r’." > > > > This just caters to the 3 known EOL formats: the Unix, the > > DOS/Windows, and the Mac one. If this is the basis for the described > > behavior, then Emacs should bind coding-system-for-read when reading > > this stuff, or maybe manually decode the strings after detecting EOL > > format. But that would only work if the EOL format is used > > consistently in the entire response of the server; if they just use > > the above as a means to sneak in multiple-line responses, and > > otherwise use some other EOL format, then we need to handle a lone \r > > specially in Eglot's code, something I'm not sure we like to do. > > Other than what Felician already quoted from the LSP specification, > there doesn't seem to be much else stated about EOL. In this > particular case, I've seen it on both Linux and Windows, therefore the > use of the CR doesn't seem to be consistent with the platform or the > document format. It's unclear to me why this particular EOL format > was chosen for the hover information, but I can't find anything in the > specification that says it is incorrect. >
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Troy Brown <brownts@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sun, 01 Sep 2024 20:51:02 +0000 Resent-Message-ID: <handler.72597.B72597.172522382622173 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, felician.nemeth@HIDDEN, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172522382622173 (code B ref 72597); Sun, 01 Sep 2024 20:51:02 +0000 Received: (at 72597) by debbugs.gnu.org; 1 Sep 2024 20:50:26 +0000 Received: from localhost ([127.0.0.1]:40183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1skrWj-0005lY-UT for submit <at> debbugs.gnu.org; Sun, 01 Sep 2024 16:50:26 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:49382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy.s.brown@HIDDEN>) id 1skrWh-0005lH-RD for 72597 <at> debbugs.gnu.org; Sun, 01 Sep 2024 16:50:24 -0400 Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a86cc0d10aaso384630066b.2 for <72597 <at> debbugs.gnu.org>; Sun, 01 Sep 2024 13:49:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725223757; x=1725828557; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zPGUJpO2QLri7Js6fDtGGw9bedcEfm/Zlc06iYGBXy4=; b=iqKtp9s4JNuK3CrGiQdLhIziqfF9O9DUMYga27K7IHPHJZ3RN4sUGneFNDVl9Eeg8/ ksypd8CZ/gj+GL7832hnyIIcK0W9RP7ruBINvRKX/AzOKUhIboUx62lwCDeUY2mlcQeH c7GgNqIUgkexIRRO0kXER734F0zKV6WIwIhdaH0lAH0GQJLXsRGul86rdXrqiz1UjNUy z4M0/vtGfLn3qESI+t95HCwJpDo7k4js7daSAMtpHLjO/sbpa6VT2K+qAttVf4p0Qa1I 8mCClc9ncRRonWizun8H8Ist0RQsBPMgS1AsndvG2Qvn6ONe6W0a3qDNsJLqq8WuO/iP PrqQ== X-Forwarded-Encrypted: i=1; AJvYcCW7T6Ju6npG0hXdyuBGUjaXySGrorOXFmqfQMlN24B7/VbM8ohp5XPSkfSjVoOKqvskugRAJw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxI8/cFcWXjq8zXNTOEOMqgUn7hlsWtOCbXCiWBFyQxA0xMSO+y ziJrCnqovN2PAUBgKk8DLQ3zLoVtlV60hNHs8bOhngWV/et7xHPYeSP7t7Koktw= X-Google-Smtp-Source: AGHT+IH36DoT3Y4piXul8ms7vTp3C21/2PDSRUru9BXz0AUiOnv96w1J69Yqi6QbpHMHoH24GuDdHw== X-Received: by 2002:a17:907:2d14:b0:a86:a948:705a with SMTP id a640c23a62f3a-a897fad0febmr878587566b.57.1725223757004; Sun, 01 Sep 2024 13:49:17 -0700 (PDT) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8988feb592sm480470766b.13.2024.09.01.13.49.16 for <72597 <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Sep 2024 13:49:16 -0700 (PDT) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5c251ba0d1cso490147a12.3 for <72597 <at> debbugs.gnu.org>; Sun, 01 Sep 2024 13:49:16 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWasZ/jAfQRt54UrVBkkj+evtM/YOsTn36bTUAkgQiyWGT4Tyg0na6obD8Cb5aPOTKTgS49/g==@debbugs.gnu.org X-Received: by 2002:a05:6402:274c:b0:5be:ecaa:bd91 with SMTP id 4fb4d7f45d1cf-5c25f23baa3mr370234a12.15.1725223755864; Sun, 01 Sep 2024 13:49:15 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> In-Reply-To: <86wmjxcein.fsf@HIDDEN> From: Troy Brown <brownts@HIDDEN> Date: Sun, 1 Sep 2024 16:49:04 -0400 X-Gmail-Original-Message-ID: <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> Message-ID: <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Sat, Aug 31, 2024 at 3:55=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote: > > Ping! How can we make progress with this issue? > Just FYI, for the time being I've been using this "return filter" advice on eglot--format-markup which splits all lines irregardless of the EOL marker and rejoins them with a newline. It's a bit heavy-handed, but it gets the job done. (defun init.el/fix-eol/eglot--format-markup (value) (let ((strings (list value))) (dolist (eol '("\r\n" "\n" "\r")) (setq strings (flatten-list (mapcar (lambda (value) (split-string value eol)) strings)))) (string-join strings "\n"))) (advice-add 'eglot--format-markup :filter-return #'init.el/fix-eol/eglot--format-markup)
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 02 Sep 2024 11:26:02 +0000 Resent-Message-ID: <handler.72597.B72597.172527635326016 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Troy Brown <brownts@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, felician.nemeth@HIDDEN, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172527635326016 (code B ref 72597); Mon, 02 Sep 2024 11:26:02 +0000 Received: (at 72597) by debbugs.gnu.org; 2 Sep 2024 11:25:53 +0000 Received: from localhost ([127.0.0.1]:45805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sl5Bx-0006lY-Fa for submit <at> debbugs.gnu.org; Mon, 02 Sep 2024 07:25:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sl5Bv-0006l4-9k for 72597 <at> debbugs.gnu.org; Mon, 02 Sep 2024 07:25:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sl5Aq-0006ox-QG; Mon, 02 Sep 2024 07:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=J9GxGUh2tRKez2ka2oi5BO+dDpHFYZdzufN0Jf04bHY=; b=YNa9RboHqcFhdX0ayrHe 8jaGKh0oP8a9Xx1o+APz1Nk/xWhNlEw2BO8oipxsPDoPju6a95XiQJpOz/F159P3M62117a4TQoZ+ GZIeEVPA+HuLAgqAabBrm0F0/p2yHRjrpkKIiCJC3fzV7F9XuhXZfHERljiAgod/epRTs6rFAC7Xi 5IX+udaCTo57CfJHUJqgrEQaWI2SNkvo2qA9t56vnc3MwGUpPtMzuP7ttYrAVoS9LQI9BUS+lNG/b fC2UPCU6fuw3CYgDia0PW7/bwjHoHOVn38r47lAZhzQSUu24PrxXo+JQKumhsepFUx3bLrtiGjbWx 6zkGq0kWcbIvKw==; Date: Mon, 02 Sep 2024 14:24:29 +0300 Message-Id: <864j6y9u36.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> (message from Troy Brown on Sun, 1 Sep 2024 16:49:04 -0400) References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Troy Brown <brownts@HIDDEN> > Date: Sun, 1 Sep 2024 16:49:04 -0400 > Cc: joaotavora@HIDDEN, felician.nemeth@HIDDEN, 72597 <at> debbugs.gnu.org > > On Sat, Aug 31, 2024 at 3:55 AM Eli Zaretskii <eliz@HIDDEN> wrote: > > > > Ping! How can we make progress with this issue? > > > > Just FYI, for the time being I've been using this "return filter" > advice on eglot--format-markup which splits all lines irregardless of > the EOL marker and rejoins them with a newline. It's a bit > heavy-handed, but it gets the job done. > > (defun init.el/fix-eol/eglot--format-markup (value) > (let ((strings (list value))) > (dolist (eol '("\r\n" "\n" "\r")) > (setq strings > (flatten-list (mapcar (lambda (value) > (split-string value eol)) > strings)))) > (string-join strings "\n"))) > > (advice-add 'eglot--format-markup :filter-return > #'init.el/fix-eol/eglot--format-markup) Thanks, but isn't the above the same as setting the car of process-coding-system for the Eglot subprocesses to 'dos'?
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 02 Sep 2024 12:34:02 +0000 Resent-Message-ID: <handler.72597.B72597.17252804376206 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN>, Daniel Pettersson <daniel@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, Troy Brown <brownts@HIDDEN>, felician.nemeth@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.17252804376206 (code B ref 72597); Mon, 02 Sep 2024 12:34:02 +0000 Received: (at 72597) by debbugs.gnu.org; 2 Sep 2024 12:33:57 +0000 Received: from localhost ([127.0.0.1]:47112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sl6Fp-0001c2-BM for submit <at> debbugs.gnu.org; Mon, 02 Sep 2024 08:33:57 -0400 Received: from mail-oo1-f53.google.com ([209.85.161.53]:48534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sl6Fn-0001bm-Iw for 72597 <at> debbugs.gnu.org; Mon, 02 Sep 2024 08:33:56 -0400 Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5dcd8403656so3024832eaf.1 for <72597 <at> debbugs.gnu.org>; Mon, 02 Sep 2024 05:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725280309; x=1725885109; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0hKW4YvmGYZorUCjkBeZT2vsBQLPKHmkgN8/OmsOwLk=; b=CQISnmPBFLZ2VoU8qJ50qrKG/aR5kXOcBnFNqMHgr0KTfaXF+yxQpuGrz8VPpIo3GX l8niIVkSz4qBlqpXWR+QFTO8x+kUcjvA/PQx5jXhNBkNh2Ov8agsWYA49opFCJnmSMB3 RmmUb6zI5GL17aUJnMb71J4dJlwsnoPRvb0Ki514eILjTIMwpg1J5+CNr9ZmomfDIHRf VwTscDKLJagIygHI2doppQXCbS/mB/YuX/6RhSQK/sl1D7y3A1kNOXCVdighl8DupP7t HElA0X2a4moKKzlXtD8ZorFEFvX3pw1ouwgrz6vh2h2D4rpq/B/Cwkgi8zTHnz5sFh55 Dodg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725280309; x=1725885109; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0hKW4YvmGYZorUCjkBeZT2vsBQLPKHmkgN8/OmsOwLk=; b=xRi3nCd00T60cPga5fVHK47ntXkGbZd8aM5rBTu85u2ED2wG74d/SdnvBqc6c6Tp8u 78zUAv3vUPHLcj2zV85FzzHiyVDub9fJpjtjlNQ/hUbl1zUHGY47vhCxchLuEPqy3CeD wUasz8XgBGcTUaPT4lQ6XuDYrSSB/U3UTfQLNbEPoNZ6eMj558qCXK6pkqefQ9pmSYRq XL9ejBgtRXqjwJV66Toe+2pi1gf+t9+51dcGoVW1GqUKaGfj0Y8cSo632/xEwj7PQH1J hkULupyWd3aiLSZ+t9E0FLoNV16XLnrAQ9CZvsS2iZWqJTr4A3zVOzHO2dh08qFwHkDl YITg== X-Forwarded-Encrypted: i=1; AJvYcCU6N9IouBtlAumlwWz+HKxDd6wzUTcQW2fVKoGb7As128GYZxZFF3lyUnAtzv8zqQiP8xsymg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyUSBD1xGqaajlFGbHbHIT0KG2TdGR7zj7YBUKVxNOry42LZOkx Tx4pPUwCZK0tNjhrbAWLDgwD46dS1VTMINZHNYb5D8tc6M46xkusbDKn4iJr3VYk3cygi8xW51L rgh5dRNO7zbWD2qqtzgaMbTj1D28= X-Google-Smtp-Source: AGHT+IEl+T7G+3c5Zlegz39Stbik6xrIkslFUSaf2I2GKG6mLrsNqrnaKZ1JypfU2ux6X/gZ8Rp6PT7DWfyRA1vcQpU= X-Received: by 2002:a05:6870:d24e:b0:261:142:7b95 with SMTP id 586e51a60fabf-2779013818cmr15414127fac.25.1725280308994; Mon, 02 Sep 2024 05:31:48 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> <864j6y9u36.fsf@HIDDEN> In-Reply-To: <864j6y9u36.fsf@HIDDEN> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Date: Mon, 2 Sep 2024 13:31:37 +0100 Message-ID: <CALDnm52NVc+7pOO1TkS_mjxr2JENmnhQB7dg2OO9m8t9=f6fqQ@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Mon, Sep 2, 2024 at 12:24=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > > (advice-add 'eglot--format-markup :filter-return > > #'init.el/fix-eol/eglot--format-markup) > > Thanks, but isn't the above the same as setting the car of > process-coding-system for the Eglot subprocesses to 'dos'? If that works consistently across all OSs and servers, it's a much better idea. I don't know how this works in terms of jsonrpc.el though. I hope it doesn't mess up the byte count of JSON objects transmitted back and forth, and only affects how we interpret strings inside those JSON objects. AFAIR the buffer where we do the JSON deserialization is in utf-8, but it uses position-bytes for everything. Anyway, if the solution is to be performed at this lower level (which I think it should), then Daniel Petterson jsonrpc.el maintainer should be added. Jo=C3=A3o
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Daniel Pettersson <daniel@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 05 Sep 2024 21:34:01 +0000 Resent-Message-ID: <handler.72597.B72597.172557200315552 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Troy Brown <brownts@HIDDEN>, felician.nemeth@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172557200315552 (code B ref 72597); Thu, 05 Sep 2024 21:34:01 +0000 Received: (at 72597) by debbugs.gnu.org; 5 Sep 2024 21:33:23 +0000 Received: from localhost ([127.0.0.1]:38416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1smK6U-00042m-KU for submit <at> debbugs.gnu.org; Thu, 05 Sep 2024 17:33:22 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:51343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <daniel.dpettersson.net@HIDDEN>) id 1smK6T-00042a-ND for 72597 <at> debbugs.gnu.org; Thu, 05 Sep 2024 17:33:22 -0400 Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2f3eabcd293so14679751fa.2 for <72597 <at> debbugs.gnu.org>; Thu, 05 Sep 2024 14:32:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725571930; x=1726176730; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i8JOrvQdRDjPCjGjsZfa4ke7NhOXhvGhyzFEvoVaM2I=; b=sDBqcZp3HSRLHxBnGPsjXgbTQxHgHmjfSFUGnxIn3BXqDHHfN5FMGCVYLFftPFw1vV NhQp6YpTC2sCdFufk+M3aBaomcSf3vlh0MiynWAN7GUGv0I5Jc7YFBSZqgLZZOMQ4NRe hlwByHbPmcPexY+oYtfpeCeLumQS5YWB9/GXL+mlSj5KuxEiFIS9LsZ7e3u6vBMOynFJ XNNJpz7XVktXEYCqcAlz3G492Z8wguTvNE8Evn1RMsQ1F8J56HANpuDb606bqRQdq339 6fwllnEHoNjI5LHDeWElJGHE2CUDqiJ7A6i+ho2mnI6trpsumYA1mzPFxmG8/AZ/a6Ya jFvQ== X-Forwarded-Encrypted: i=1; AJvYcCV48WHbGQrUCziLzo9Xok//n1iYTctISckdkcpmCwFmDngl9UcwUTrVZhuwtvsNSQeQn9tI7g==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzm2vdBvGLEs9NdZfkME/Ccb2/qHwpCEgJoUyaoRrypnuAV7j5X hXnhNoGNWtfFSGr0IuG6pOjuqnhiYAJIgEC7jQcEuzkitQIjxps5TBASJA== X-Google-Smtp-Source: AGHT+IHC57ZdHFTpmxv6mAL/Ee9dezgCj4Gdr7PDUzzFGNJTjHhOj1ROpi4N0ANezQA7PPWcy2XN0Q== X-Received: by 2002:a05:651c:b0f:b0:2ef:2f9e:dd1b with SMTP id 38308e7fff4ca-2f751edfe0amr2497811fa.14.1725571929882; Thu, 05 Sep 2024 14:32:09 -0700 (PDT) Received: from Daniels-Air (c-97c9e455.027-357-6d6c6d4.bbcust.telenor.se. [85.228.201.151]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f614ed1622sm29245251fa.27.2024.09.05.14.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 14:32:09 -0700 (PDT) From: Daniel Pettersson <daniel@HIDDEN> In-Reply-To: <CALDnm52NVc+7pOO1TkS_mjxr2JENmnhQB7dg2OO9m8t9=f6fqQ@HIDDEN> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 2 Sep 2024 13:31:37 +0100") References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> <864j6y9u36.fsf@HIDDEN> <CALDnm52NVc+7pOO1TkS_mjxr2JENmnhQB7dg2OO9m8t9=f6fqQ@HIDDEN> Date: Thu, 05 Sep 2024 23:32:08 +0200 Message-ID: <m2ikv9zt0n.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > On Mon, Sep 2, 2024 at 12:24=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrot= e: >> Thanks, but isn't the above the same as setting the car of >> process-coding-system for the Eglot subprocesses to 'dos'? I would think that a better place for encoding the displayed string at the place where we are displaying the string rather then before parsing the json. > Anyway, if the solution is to be performed at this lower > level (which I think it should), then Daniel Petterson > jsonrpc.el maintainer should be added. I might be missing something, but jsonrpc should not in my mind convert/format/encode any json data. Any assumptions on line endings can only be made on header and content separators, not on the json payload itself. /Daniel Pettersson
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 05 Sep 2024 22:01:02 +0000 Resent-Message-ID: <handler.72597.B72597.172557362622939 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Pettersson <daniel@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Troy Brown <brownts@HIDDEN>, felician.nemeth@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172557362622939 (code B ref 72597); Thu, 05 Sep 2024 22:01:02 +0000 Received: (at 72597) by debbugs.gnu.org; 5 Sep 2024 22:00:26 +0000 Received: from localhost ([127.0.0.1]:38476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1smKWf-0005xv-Ux for submit <at> debbugs.gnu.org; Thu, 05 Sep 2024 18:00:26 -0400 Received: from mail-oi1-f169.google.com ([209.85.167.169]:44171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1smKWd-0005xZ-PH for 72597 <at> debbugs.gnu.org; Thu, 05 Sep 2024 18:00:24 -0400 Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3df03d1f1ddso1019585b6e.0 for <72597 <at> debbugs.gnu.org>; Thu, 05 Sep 2024 14:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725573492; x=1726178292; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3+vD2QZzDUiEpiYH2Sa9NtxGungpq4KaUi6BKyf0ipE=; b=F8UQrKw9QqgzuZkooGQ3hidoZtyB2VjXo4uLTbRjlAXBG0dIY0gJnULdiTjMm9UaMv bdzeFEBLA45Z2LfeO2rNpWUqQJn/JoDM2GSxhLORkywQrVKaAB2c6Mhio4vC1XYEqV5Q BjWC2mTR03S3mqgD+tvLSXH08rTlv3K81VUfkYE9RsRY5hRd+oeZmc60wmeL928NoZsp /VtTDI1Vq0xWV43vWtuTomLCEJiRrKm3hbtc3vC1daC2EQ4Ji1G3HKAvVmAXXN4MsIAz zwkY+71tg0qiztlJul/vdmU8P6+tXfFdtQ7jae56mV7o/zt5Ths/IpTPJTuZo6HO1AO+ O0gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725573492; x=1726178292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3+vD2QZzDUiEpiYH2Sa9NtxGungpq4KaUi6BKyf0ipE=; b=qLulpmQHFbbqWzamzt4T/bmy43U6fYet9CWwYWfCK9mLpCEntcwVA1wuPvZkt7P7B7 6QOXYGowjbjdLDjDQZu+iKlviwE0y9Z+1v1fRnoD35qo+qX06CBLC7M7H4wqwCcLMMeH Jj711HsCSn69mt3zsbr/VkCYyINhl3TeLm11cj4xCEhjhqANw2VKFBQFOIWF0G74WDQ5 ce6PvxsPGEhcXz6kZz00Jc3xKyObgMoiQMt/x8NZYOM+3Y9s6caRXhVXhjOerFXuEr2G xi4kKtJLhWNeBneA3lF59aGF3iJr7qev7Z1N69M5PSb39cF7xIhMEppwrAFzPuxbRXzN gxqA== X-Forwarded-Encrypted: i=1; AJvYcCVUpa1cONnK9Dmy8wZ3n07cQS3mk3Rkz9drKNpLBIUTGIECdna3qxtFJtd2p/laZSGBun2ylA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxxy/whabJZUd9r/RZMmgZYvW8bQa1/VdsSeQkW61S4CpnuNiGL 1uQ0kJOU1VanKZorcNU9fkwRWdkt3tJv9ElICNM95OovW0zS2FcYyP+EgZpX3LkFm4kVdI7Vdyo yF2EMlndtkD3juy00h5d8y5Y9ejQ= X-Google-Smtp-Source: AGHT+IGQbHw8rZaJF77WsVvnrlIC2gJ+G/pY5IktuvD5Z5nnoLYyYXCFiosPUYmdvnz1WPDpBv1jK941xP/RRE/bjug= X-Received: by 2002:a05:6870:3923:b0:277:a34c:1b83 with SMTP id 586e51a60fabf-277a34c2304mr25998601fac.47.1725573492447; Thu, 05 Sep 2024 14:58:12 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> <864j6y9u36.fsf@HIDDEN> <CALDnm52NVc+7pOO1TkS_mjxr2JENmnhQB7dg2OO9m8t9=f6fqQ@HIDDEN> <m2ikv9zt0n.fsf@HIDDEN> In-Reply-To: <m2ikv9zt0n.fsf@HIDDEN> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Date: Thu, 5 Sep 2024 22:58:01 +0100 Message-ID: <CALDnm51M1es+ApV+FYEcxvgRZ_j7q67cGXFsqBNYnZqReqPQpw@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Thu, Sep 5, 2024 at 10:32=E2=80=AFPM Daniel Pettersson <daniel@HIDDEN> wrote: > I might be missing something, but jsonrpc should not in my mind > convert/format/encode any json data. Any assumptions on line endings > can only be made on header and content separators, not on the json > payload itself. That's also a reasonable position, I guess. The line ending convention is somewhat of a grey zone. jsonrpc.el produces Elisp strings from JSON strings. It could apply Emasc's line-ending conventions. Or maybe not, maybe you're right and Eglot the jsonrpc.el client should do it. Or really this quirky server should just use \n like everyone else. Jo=C3=A3o
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Fri, 06 Sep 2024 05:46:02 +0000 Resent-Message-ID: <handler.72597.B72597.17256015261830 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Pettersson <daniel@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, brownts@HIDDEN, felician.nemeth@HIDDEN, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.17256015261830 (code B ref 72597); Fri, 06 Sep 2024 05:46:02 +0000 Received: (at 72597) by debbugs.gnu.org; 6 Sep 2024 05:45:26 +0000 Received: from localhost ([127.0.0.1]:38985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1smRmg-0000TR-2C for submit <at> debbugs.gnu.org; Fri, 06 Sep 2024 01:45:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1smRmZ-0000T4-9U for 72597 <at> debbugs.gnu.org; Fri, 06 Sep 2024 01:45:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1smRlP-0003G7-A4; Fri, 06 Sep 2024 01:44:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fzcjPRyd9vun06azR7YnO0I8a5+YvYlvNZx4USXnQxk=; b=Iexau0i38hmm 3BF87oZmJPiDMcRxl3CaXR8+1yA2EuLni9p1uKxVp829bzjD/H61uiCEXvhEIzvj0ciO/rP66SEzs gV4+IGUcE6jkrq4cmtwlaHHhBs/XKiWn0cnJC7lS2ZLtL5uwA0trWLplYWOYv/kZYZhlLBrVmRyOO tPwHMfnat0253BbbyjZdVzpTO67scXJzuZ6dns9aWfQ4bjWt/SwNIZ6BSGj6hVK5VTQSKuREHD53G oLlXzV6A/YnTvy9mGgXdCiT9zmpy6xcfmbNUwegCmitHBTZt6eNoCiNQD1m7dh3uJ258ye0i043vk 6PfbqKnzaUSQKD9/0GdZYg==; Date: Fri, 06 Sep 2024 08:44:04 +0300 Message-Id: <861q1x2v6j.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <m2ikv9zt0n.fsf@HIDDEN> (message from Daniel Pettersson on Thu, 05 Sep 2024 23:32:08 +0200) References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> <864j6y9u36.fsf@HIDDEN> <CALDnm52NVc+7pOO1TkS_mjxr2JENmnhQB7dg2OO9m8t9=f6fqQ@HIDDEN> <m2ikv9zt0n.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Daniel Pettersson <daniel@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, Troy Brown <brownts@HIDDEN>, > felician.nemeth@HIDDEN, 72597 <at> debbugs.gnu.org > Date: Thu, 05 Sep 2024 23:32:08 +0200 > > > Anyway, if the solution is to be performed at this lower > > level (which I think it should), then Daniel Petterson > > jsonrpc.el maintainer should be added. > > I might be missing something, but jsonrpc should not in my mind > convert/format/encode any json data. Any assumptions on line endings > can only be made on header and content separators, not on the json > payload itself. That depends on the reason why the CR character appeared there in the first place. Are they required for the strings in questions, or are they simply an artifact of how the server marshaled JSON data on the wire? In the latter case, the CR characters are the result of Windows-style text writing, which adds a CR to each newline, and therefore removing that CR should indeed happen where Emacs decodes the EOLs of the incoming stuff.
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Daniel Pettersson <daniel@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Fri, 06 Sep 2024 16:01:02 +0000 Resent-Message-ID: <handler.72597.B72597.172563843931383 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, brownts@HIDDEN, felician.nemeth@HIDDEN, joaotavora@HIDDEN Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172563843931383 (code B ref 72597); Fri, 06 Sep 2024 16:01:02 +0000 Received: (at 72597) by debbugs.gnu.org; 6 Sep 2024 16:00:39 +0000 Received: from localhost ([127.0.0.1]:53985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1smbO2-0008A7-JN for submit <at> debbugs.gnu.org; Fri, 06 Sep 2024 12:00:38 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:54458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <daniel.dpettersson.net@HIDDEN>) id 1smbO1-00089q-4B for 72597 <at> debbugs.gnu.org; Fri, 06 Sep 2024 12:00:37 -0400 Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5365392cfafso2033410e87.0 for <72597 <at> debbugs.gnu.org>; Fri, 06 Sep 2024 09:00:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725638431; x=1726243231; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7bYGFlqSAttRNNWP/cIEek15obL31edT2WWKlVl9e1I=; b=nRNKGVZle12gROsOgaozVpPco1DzFDAQIJ+esjUB/5Of4Rh/QB8FZjTW9WHK53YYsv kvlYBDl32WI059qLsW9kWuIkhqQd1g7VaM+1apsVo17ZkbTPosgLv58+YOoKtsFHADD8 padWAoAvpO81wPoHD8GXAQn3rcb9VFsKDsRWLA+9pZtwNBINFukL1GmZT2RPsHE8PzJz 2TkNXAB982e0X5zfFUjU9bZd1J+4FFEa2YoKA/ZDP4AjmGnrqx/+UVwnCcttyvg7KHzn p38J/CoZFcb7GPXGux82/LDS0fpgkPSOAINN12an/202nG9wK7A3Fvwmhc6QJ1gca/gp 7K3w== X-Forwarded-Encrypted: i=1; AJvYcCVfeNOyj94GH2W/cY6/XPgZmPZ7JF8HT7OcRkt9qxwEMpLKpRjHUXrQH6defhi7SaAfWlHJTQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy4gLhAY926Pi2mHM5qnGEtTP0/KcllfYJEk9VqlVP0yeNaXzZG qZrFylqz6xqft87TM/o/g3gouROBUu9E7mppJRDZ19NktvL1skFO0uREYw== X-Google-Smtp-Source: AGHT+IEHqekZdvTnSkC7LJ+CHmIRc9WMmtEd1eF4UovjVkTeNi7Q2Nl3FefVsF5iJGW5xfUNn+5MNQ== X-Received: by 2002:a05:6512:1283:b0:52c:e0fb:92c0 with SMTP id 2adb3069b0e04-536587c8177mr2176309e87.34.1725638430818; Fri, 06 Sep 2024 09:00:30 -0700 (PDT) Received: from Daniels-Air (c-97c9e455.027-357-6d6c6d4.bbcust.telenor.se. [85.228.201.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5365889273dsm231767e87.109.2024.09.06.09.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 09:00:30 -0700 (PDT) From: Daniel Pettersson <daniel@HIDDEN> In-Reply-To: <861q1x2v6j.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 06 Sep 2024 08:44:04 +0300") References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> <864j6y9u36.fsf@HIDDEN> <CALDnm52NVc+7pOO1TkS_mjxr2JENmnhQB7dg2OO9m8t9=f6fqQ@HIDDEN> <m2ikv9zt0n.fsf@HIDDEN> <861q1x2v6j.fsf@HIDDEN> Date: Fri, 06 Sep 2024 18:00:29 +0200 Message-ID: <m2bk10zs9u.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) Eli Zaretskii <eliz@HIDDEN> writes: > That depends on the reason why the CR character appeared there in the > first place. Are they required for the strings in questions, or are > they simply an artifact of how the server marshaled JSON data on the > wire? I am not convinced, in my mind if the marshaling operation converts \n to \r\n (or any other character combination) within a string literal, then the server's JSON conversion is broken. > In the latter case, the CR characters are the result of > Windows-style text writing, which adds a CR to each newline, and > therefore removing that CR should indeed happen where Emacs decodes > the EOLs of the incoming stuff. I fail to see how that is not due to an broken json marshaling and not intentionally chosen line endings by the server. Of course I might be overlooking something. /Daniel Pettersson
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Fri, 06 Sep 2024 19:33:02 +0000 Resent-Message-ID: <handler.72597.B72597.172565114811240 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 72597 <at> debbugs.gnu.org, brownts@HIDDEN, felician.nemeth@HIDDEN, Daniel Pettersson <daniel@HIDDEN> Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172565114811240 (code B ref 72597); Fri, 06 Sep 2024 19:33:02 +0000 Received: (at 72597) by debbugs.gnu.org; 6 Sep 2024 19:32:28 +0000 Received: from localhost ([127.0.0.1]:54225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1smeh1-0002vD-Gt for submit <at> debbugs.gnu.org; Fri, 06 Sep 2024 15:32:27 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:61674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1smegz-0002up-8X for 72597 <at> debbugs.gnu.org; Fri, 06 Sep 2024 15:32:26 -0400 Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3df0519a3ceso1596818b6e.2 for <72597 <at> debbugs.gnu.org>; Fri, 06 Sep 2024 12:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725651080; x=1726255880; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H0SYIj9NKY9zyJfAGlbYEfwU7ZFO21kJMGZ9em3Mibk=; b=DAtKLVPG8rlFr6MzwM0CLa99cei7AQEQ0RYbPA3TnNlv96BW8COjEO8zvyKNwh2dhy 0IR57fRMsg4U0SO8vQ4Ud8Ynfplo/UQrBq2dEQHMjd03SGrA32j7EjOpIDnAlxVN4T1h YygJw42h2P7gXhN9MGLW9JEgfNxC4D6fvsmG8/tIvhJlMq5aJ4Qv0Usw1YgW1Q6JKCll uWid6O1w5ISuHqn5J7duBHEvdGPFa/d/tvY3DAcFKkRsb/EwPysvdLxlTkEo59xWpdMq CDfbEYBuNb4q1+h2cVhPCAUw8ttNeZWZnI1VRfeKqFY6++sUqcCBu9X8kPPRV+u/TkF/ qkuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725651080; x=1726255880; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H0SYIj9NKY9zyJfAGlbYEfwU7ZFO21kJMGZ9em3Mibk=; b=tSLNg/nDds/o1miHfQL4Go2ltJ8CPqX9WIcROeQm1Gp+cvUkT7xOizYEPSkOpcg6ka 7JaE9qtMKWgJadB+Z6idUCkfMu0CHLSliJrsXJrRNPOyrzIhV/vxLJVC3C4cq36fRB0r cnVgdtchyVMit91Zirk2sZ6Ljvl/FdfWPFtIjGFfYqaxZvsY3ctVySlFJ8CJy8giUq8h CHpaxhp8MHhIyyzE2NIQgWd1gk1uL4GvIoAx1bX6crzD+ObFEdSmXOL3/lmHzqqEEvbo Tr11aACt0PjwbT3ioChB8/lpTbKxWJbGYLAOT6Bp0dJNdK1RbgX0A2Mwu/MZ62qDK5Xm VmDA== X-Forwarded-Encrypted: i=1; AJvYcCU/ZXqn/x6gsu4KWKAU93xkFpqq1fmNTXIH1GARalIh2e7NHAa6gr64Oq63M/ss6/OFAwGPGA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwNI3QgEdeY9pyOkjeUDBQuvU9Tc0BY4XDinXI/LO4lOZzDmT2M UrGXd4s8/987t3OuuExvaiJLd6b4B7o2boA5+/CpgSwFf2zYufgrtCEcpeJUXMYV4RT+gvxnykW kmRESd9KgNSvfJXwIqVrd34yQyCs= X-Google-Smtp-Source: AGHT+IHeYse3/SpmllG74HDkZBkhfeXyv9NOfS9aP/zpj2aGdSUth7DZIS5NrqT/dVf9VMfbSZuoqsNqUVSii/4VxCw= X-Received: by 2002:a05:6870:8290:b0:277:eb79:b4fb with SMTP id 586e51a60fabf-27b9d672853mr218876fac.1.1725651079688; Fri, 06 Sep 2024 12:31:19 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> <864j6y9u36.fsf@HIDDEN> <CALDnm52NVc+7pOO1TkS_mjxr2JENmnhQB7dg2OO9m8t9=f6fqQ@HIDDEN> <m2ikv9zt0n.fsf@HIDDEN> <861q1x2v6j.fsf@HIDDEN> In-Reply-To: <861q1x2v6j.fsf@HIDDEN> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Date: Fri, 6 Sep 2024 20:31:08 +0100 Message-ID: <CALDnm53UwUGiLd3ad+9sFFP5O40bWDhBdD_1=krZd2o5Xrz=Dw@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Fri, Sep 6, 2024 at 6:44=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote: > > > From: Daniel Pettersson <daniel@HIDDEN> > > Cc: Eli Zaretskii <eliz@HIDDEN>, Troy Brown <brownts@HIDDEN>, > > felician.nemeth@HIDDEN, 72597 <at> debbugs.gnu.org > > Date: Thu, 05 Sep 2024 23:32:08 +0200 > > > > > Anyway, if the solution is to be performed at this lower > > > level (which I think it should), then Daniel Petterson > > > jsonrpc.el maintainer should be added. > > > > I might be missing something, but jsonrpc should not in my mind > > convert/format/encode any json data. Any assumptions on line endings > > can only be made on header and content separators, not on the json > > payload itself. > > That depends on the reason why the CR character appeared there in the > first place. Are they required for the strings in questions, or are > they simply an artifact of how the server marshaled JSON data on the > wire? Indeed this is the question. And it is not necessarily easy to asnwer. For example most LSP servers may be used to edit CRLF terminated files, and when doing so they will possibly exchange file snippets with intentional CR chars in them (however odd that may be for most people, it can happen). But that is theoretically completely independent of the decision to terminate documentation snippets with CRLF or just LF or just CR. Both these kinds of snippets are transmitted as JSON strings over the wire. jsonrpc.el makes them Elisp strings and (afair) doesn't do any newline conversion. Even if Eglot is most well positioned to answer this question in the LSP case, i don't think it can: there's no interface for doing so. If it could, then it could theoretically ask jsonrpc.el to do that conversion. But it can't. So perhaps something like Troys patch for the "doc view" layer is best if inefficient/hacky. Even fixing it in gfm-view-mode isn't a bad idea. But also, I don't think this is a very urgent matter: the server that does this is clearly in the minority. I would just ask this server's devs if they wouldn't mind not sending these odd doc snippets. Jo=C3=A3o
X-Loop: help-debbugs@HIDDEN Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Resent-From: Troy Brown <brownts@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 09 Sep 2024 00:32:02 +0000 Resent-Message-ID: <handler.72597.B72597.172584190324661 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 72597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN> Cc: Eli Zaretskii <eliz@HIDDEN>, 72597 <at> debbugs.gnu.org, felician.nemeth@HIDDEN, Daniel Pettersson <daniel@HIDDEN> Received: via spool by 72597-submit <at> debbugs.gnu.org id=B72597.172584190324661 (code B ref 72597); Mon, 09 Sep 2024 00:32:02 +0000 Received: (at 72597) by debbugs.gnu.org; 9 Sep 2024 00:31:43 +0000 Received: from localhost ([127.0.0.1]:60314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1snSJj-0006Pg-Jk for submit <at> debbugs.gnu.org; Sun, 08 Sep 2024 20:31:43 -0400 Received: from mail-ej1-f42.google.com ([209.85.218.42]:58762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy.s.brown@HIDDEN>) id 1snSJi-0006PR-0z for 72597 <at> debbugs.gnu.org; Sun, 08 Sep 2024 20:31:42 -0400 Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a8ce5db8668so341500466b.1 for <72597 <at> debbugs.gnu.org>; Sun, 08 Sep 2024 17:31:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725841893; x=1726446693; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wkWY05mHFyMp7J93H5AAcXsP1LlFoqAswiLDOSdmzVg=; b=aoS2laL0mN68UKS88oLRb6FhRoH930Dh25jb3Lwnqzwjo9m5KgyLKiHAPbtkQDweAZ jASHXyQi2ySqXjxCDRF4W5woHuW0oMD0Pl1aY7aqQKCNoNYnBFo7Oxa/SdbpnoLO4D43 WRHicWCvbEHn8XJEUJm6/4jzF9h4iv/DTJFSi6mBDJ1W26ZZtDdPu6HQWINsjUO3wPm4 LSCNofZf3BDtRFaW4en5CHtGAHkjsP5OA9JZd3ijtEX9rr+14Uh6ySqBdZ1df/zt2uAZ mNAms3Vs/Zcw43LvLYpKwpBDsfaNYSs0P9CLMosQUodMG136GH+GvAGVrkXY9JI2mOST rhAw== X-Forwarded-Encrypted: i=1; AJvYcCWQ6dSdQpSgeWuxXZYLAKuuiqc+aSwyDsX7S5+xkDMu0oSVTRzwIbE8UcED9iA+smskytOggw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxeD2z88+MtgT47+nrexZQoQ+wd7bFy0xY5Nd8Vn3uFIRLZa9Yq vr54NUWwWIuSAHZYAsvyHUzDrEofUOCBfN8Cojfl7qgoxiigurl6I96pLO8n3Ws= X-Google-Smtp-Source: AGHT+IG+WTlf11pJxEqxYa2ZXlzIzFrBxqwWYzxIITP17mrITIVBKzwsYNiyZ1RGTzfsfB7yqZp/bg== X-Received: by 2002:a17:906:7312:b0:a8d:e82:9f82 with SMTP id a640c23a62f3a-a8d1bfcb42cmr868197066b.16.1725841892220; Sun, 08 Sep 2024 17:31:32 -0700 (PDT) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25c62570sm261415766b.134.2024.09.08.17.31.31 for <72597 <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Sep 2024 17:31:31 -0700 (PDT) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5c3d209db94so3992388a12.3 for <72597 <at> debbugs.gnu.org>; Sun, 08 Sep 2024 17:31:31 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWGN1DIMkcD3wKuINFGK45JRc5ZN0R3ULW3OR0pg+NnS8AVDezHXmZ3vp9EWtiGT44X/bcw6A==@debbugs.gnu.org X-Received: by 2002:a05:6402:350c:b0:5c2:56d2:20b3 with SMTP id 4fb4d7f45d1cf-5c3e9636605mr4986774a12.21.1725841891556; Sun, 08 Sep 2024 17:31:31 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ411f_mfr5oa+KrggZ_xc8Gp0cx8zHBfrEeNnm1PdpT-DA@HIDDEN> <86h6bohdsd.fsf@HIDDEN> <87v804mfyz.fsf@HIDDEN> <CALDnm53VhpM-NwaKDQt5oaMmFeLCEHuQt9RN3EHt4Apc3+mffA@HIDDEN> <CABvCZ427GX11wZueJqtgd3Q-zNoAe_CSJ7b7HN5TQzHqYA=M1A@HIDDEN> <86v803g1oy.fsf@HIDDEN> <87le0zmyy7.fsf@HIDDEN> <86ikw3fw4k.fsf@HIDDEN> <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@HIDDEN> <86wmjxcein.fsf@HIDDEN> <CABvCZ43yGB4+uCWSvgUZdB5PWzpSD7ZmVJJo3xS9Aw+vq++Fjw@HIDDEN> <864j6y9u36.fsf@HIDDEN> <CALDnm52NVc+7pOO1TkS_mjxr2JENmnhQB7dg2OO9m8t9=f6fqQ@HIDDEN> <m2ikv9zt0n.fsf@HIDDEN> <861q1x2v6j.fsf@HIDDEN> <CALDnm53UwUGiLd3ad+9sFFP5O40bWDhBdD_1=krZd2o5Xrz=Dw@HIDDEN> In-Reply-To: <CALDnm53UwUGiLd3ad+9sFFP5O40bWDhBdD_1=krZd2o5Xrz=Dw@HIDDEN> From: Troy Brown <brownts@HIDDEN> Date: Sun, 8 Sep 2024 20:31:20 -0400 X-Gmail-Original-Message-ID: <CABvCZ400c6pZJTAK5fb4EXEJ+Z==mW_2cFErJ=bVO1_Cfk3tCw@HIDDEN> Message-ID: <CABvCZ400c6pZJTAK5fb4EXEJ+Z==mW_2cFErJ=bVO1_Cfk3tCw@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) On Fri, Sep 6, 2024 at 3:31=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora@gm= ail.com> wrote: > > I would just ask this server's > devs if they wouldn't mind not sending these odd doc snippets. > I've logged an inquiry with the LS developers. Hopefully we'll at least gain some insight with a rationale. https://github.com/AdaCore/ada_language_server/issues/1204
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.