GNU logs - #72616, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails
Resent-From: Gerard Vermeulen <gerard.vermeulen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 14 Aug 2024 08:06:02 +0000
Resent-Message-ID: <handler.72616.B.172362272015086 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72616 <at> debbugs.gnu.org
MIME-Version: 1.0
Date: Wed, 14 Aug 2024 08:04:31 +0000
From: Gerard Vermeulen <gerard.vermeulen@HIDDEN>
Message-ID: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=185.67.36.66;
 envelope-from=gerard.vermeulen@HIDDEN; helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hello,

I get the message:
"apropos-library: Wrong type argument: symbolp, ((cl-deftype-satisfies 
eglot-lsp-server))"
when I try "M-x apropos-library eglot"

GNU Emacs 30.0.60 (build 12, x86_64-apple-darwin20.6.0, NS 
appkit-2202.70 Version 11.7.1 (Build 20G918)) of 2024-08-13

Regards -- Gerard

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Gerard Vermeulen <gerard.vermeulen@HIDDEN>
Subject: bug#72616: Acknowledgement (30.0.60; M-x apropos-library eglot fails)
Message-ID: <handler.72616.B.172362272015086.ack <at> debbugs.gnu.org>
References: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN>
X-Gnu-PR-Message: ack 72616
X-Gnu-PR-Package: emacs
Reply-To: 72616 <at> debbugs.gnu.org
Date: Wed, 14 Aug 2024 08:06:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 72616 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72616: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72616
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 14 Aug 2024 09:11:02 +0000
Resent-Message-ID: <handler.72616.B72616.172362664221669 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gerard Vermeulen <gerard.vermeulen@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 72616 <at> debbugs.gnu.org
Date: Wed, 14 Aug 2024 12:09:56 +0300
Message-Id: <86y14z8o7v.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN> (message from
 Gerard Vermeulen on Wed, 14 Aug 2024 08:04:31 +0000)
References: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Wed, 14 Aug 2024 08:04:31 +0000
> From: Gerard Vermeulen <gerard.vermeulen@HIDDEN>
> 
> I get the message:
> "apropos-library: Wrong type argument: symbolp, ((cl-deftype-satisfies 
> eglot-lsp-server))"
> when I try "M-x apropos-library eglot"

You forgot to tell that one needs first to load Eglot, otherwise the
above command cannot be invoked at all.

Stefan and Jo�o, is the below the right solution?

diff --git a/lisp/apropos.el b/lisp/apropos.el
index 6c6cd0b..3fb7581 100644
--- a/lisp/apropos.el
+++ b/lisp/apropos.el
@@ -731,6 +731,7 @@ apropos-library
 	('require (push (cdr x) requires))
 	('provide (push (cdr x) provides))
         ('t nil)                     ; Skip "was an autoload" entries.
+        ('define-symbol-props nil)
         ;; FIXME: Print information about each individual method: both
         ;; its docstring and specializers (bug#21422).
         ('cl-defmethod (push (cadr x) provides))

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 14 Aug 2024 11:59:02 +0000
Resent-Message-ID: <handler.72616.B72616.17236367406611 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 72616 <at> debbugs.gnu.org, Gerard Vermeulen <gerard.vermeulen@HIDDEN>, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <86y14z8o7v.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 14 Aug
 2024 12:09:56 +0300")
Message-ID: <jwv4j7npbr1.fsf-monnier+emacs@HIDDEN>
References: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN>
 <86y14z8o7v.fsf@HIDDEN>
Date: Wed, 14 Aug 2024 07:58:15 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

>> I get the message:
>> "apropos-library: Wrong type argument: symbolp, ((cl-deftype-satisfies=20
>> eglot-lsp-server))"
>> when I try "M-x apropos-library eglot"
>
> You forgot to tell that one needs first to load Eglot, otherwise the
> above command cannot be invoked at all.
>
> Stefan and Jo=E3o, is the below the right solution?
>
> diff --git a/lisp/apropos.el b/lisp/apropos.el
> index 6c6cd0b..3fb7581 100644
> --- a/lisp/apropos.el
> +++ b/lisp/apropos.el
> @@ -731,6 +731,7 @@ apropos-library
>  	('require (push (cdr x) requires))
>  	('provide (push (cdr x) provides))
>          ('t nil)                     ; Skip "was an autoload" entries.
> +        ('define-symbol-props nil)
>          ;; FIXME: Print information about each individual method: both
>          ;; its docstring and specializers (bug#21422).
>          ('cl-defmethod (push (cadr x) provides))

This doesn't look right: the meaning of `define-symbol-props` in
`load-history` should be defined in a more modular way, near
`define-symbol-prop` rather than by hardcoding something in
`apropos.el`.

IOW, we should add something to `apropos.el` where users of
`load-history` can register what to do with their entries, just like
`find-function-regexp-alist` and the generic function
`loadhist-unload-element` are used to tell `find-function` what to do
with those same entries.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 14 Aug 2024 12:18:02 +0000
Resent-Message-ID: <handler.72616.B72616.17236378558841 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72616
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 72616 <at> debbugs.gnu.org, gerard.vermeulen@HIDDEN, joaotavora@HIDDEN
Received: via spool by 72616-submit <at> debbugs.gnu.org id=B72616.17236378558841
          (code B ref 72616); Wed, 14 Aug 2024 12:18:02 +0000
Received: (at 72616) by debbugs.gnu.org; 14 Aug 2024 12:17:35 +0000
Received: from localhost ([127.0.0.1]:46412 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1seCwY-0002IX-Kj
	for submit <at> debbugs.gnu.org; Wed, 14 Aug 2024 08:17:35 -0400
Received: from eggs.gnu.org ([209.51.188.92]:56940)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1seCwW-0002IJ-K6
 for 72616 <at> debbugs.gnu.org; Wed, 14 Aug 2024 08:17:33 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1seCtm-0007du-71; Wed, 14 Aug 2024 08:14:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=Rx0KJDkrIv7UME6Yo0pD9w2GKsgDk2LphlP+McGwJfc=; b=MCpjTQonKfr6ct5tZoAi
 g7GoiFNYWXbP9TKweRIRdwa5a3BBrAkoH+U1kec20TlojhHCC2p4L8ShmgVt0dLWVTHcH9CNhC+am
 US45/V18bB0YvIy7Rr60Uh83SfGG3VHJjGhSuHpsytdsoDI1qvcWZJssCG+BbGDwdLKmT9lXCmWCi
 COxDu5vW4iNaffHc9dDmNPEfIzZeI6hvgTqlBmA4sq12GNBwagD0V5USWvj0o7bqTUOX8PfPjN/1+
 HVG/BurD7aWGvu7bF5H8tPOygrvFWhdAOmDZUeXN023IWVpK4wKRtB4XwCUlZBlXmyeJ0qXXBUMhP
 tr4Ki9GCmHZS7g==;
Date: Wed, 14 Aug 2024 15:14:28 +0300
Message-Id: <86sev78fob.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwv4j7npbr1.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Wed, 14 Aug 2024 07:58:15 -0400)
References: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN>
 <86y14z8o7v.fsf@HIDDEN> <jwv4j7npbr1.fsf-monnier+emacs@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: Gerard Vermeulen <gerard.vermeulen@HIDDEN>,  Jo�o T�vora
>  <joaotavora@HIDDEN>,  72616 <at> debbugs.gnu.org
> Date: Wed, 14 Aug 2024 07:58:15 -0400
> 
> >> I get the message:
> >> "apropos-library: Wrong type argument: symbolp, ((cl-deftype-satisfies 
> >> eglot-lsp-server))"
> >> when I try "M-x apropos-library eglot"
> >
> > You forgot to tell that one needs first to load Eglot, otherwise the
> > above command cannot be invoked at all.
> >
> > Stefan and Jo�o, is the below the right solution?
> >
> > diff --git a/lisp/apropos.el b/lisp/apropos.el
> > index 6c6cd0b..3fb7581 100644
> > --- a/lisp/apropos.el
> > +++ b/lisp/apropos.el
> > @@ -731,6 +731,7 @@ apropos-library
> >  	('require (push (cdr x) requires))
> >  	('provide (push (cdr x) provides))
> >          ('t nil)                     ; Skip "was an autoload" entries.
> > +        ('define-symbol-props nil)
> >          ;; FIXME: Print information about each individual method: both
> >          ;; its docstring and specializers (bug#21422).
> >          ('cl-defmethod (push (cadr x) provides))
> 
> This doesn't look right: the meaning of `define-symbol-props` in
> `load-history` should be defined in a more modular way, near
> `define-symbol-prop` rather than by hardcoding something in
> `apropos.el`.

Is it better to leave us where we are now: that apropos-library
signals an error instead of displaying the information about the
library?

> IOW, we should add something to `apropos.el` where users of
> `load-history` can register what to do with their entries, just like
> `find-function-regexp-alist` and the generic function
> `loadhist-unload-element` are used to tell `find-function` what to do
> with those same entries.

Patches are welcome, but maybe we should start with someone explaining
what are those define-symbol-props elements in load-history.  They are
currently completely undocumented AFAICT, and so anyone but the
person(s) who added that to Emacs will have hard time coming up with
changes such as you describe.  (Apologies if this is already
documented and I just missed it.)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 14 Aug 2024 12:49:01 +0000
Resent-Message-ID: <handler.72616.B72616.172363970812324 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72616
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 72616 <at> debbugs.gnu.org, gerard.vermeulen@HIDDEN, joaotavora@HIDDEN
Received: via spool by 72616-submit <at> debbugs.gnu.org id=B72616.172363970812324
          (code B ref 72616); Wed, 14 Aug 2024 12:49:01 +0000
Received: (at 72616) by debbugs.gnu.org; 14 Aug 2024 12:48:28 +0000
Received: from localhost ([127.0.0.1]:46450 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1seDQR-0003Ci-Ho
	for submit <at> debbugs.gnu.org; Wed, 14 Aug 2024 08:48:27 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15119)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1seDQP-0003CU-Gu
 for 72616 <at> debbugs.gnu.org; Wed, 14 Aug 2024 08:48:26 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 40C9910005D;
 Wed, 14 Aug 2024 08:47:43 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1723639661;
 bh=GB1UmpfX+Ev8bfF2zid0bSDHyAaRVZliB65nIu0cBCI=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Shaclw5N8hus6Biv/T4OANPVJN2eMCt/R1akl+QKu8iiKnAubu0guuZ6WKXmCUnvG
 hDcgxAwnNsPDSNwN0SBhH41d7vEm6x3qO0QzMV/zuMyvEsOQdYs4v4GnUTJYm0dVlM
 7IuUT9WJ8ReaEvsMFpTm1ui7jmFK7labatLL+jaXy+cBKVHj27ILolavE1GFchiz1P
 MiU3EeF1Dg9ZIcW676F2QC0ycn2nHuvZhwHz6MBkntL1cQ8OCto1PP+jpaOdKZ5wqY
 5FxYrVbJNBPhdGsfQm4beqggiJWb2VpJfNt6pbu2dfegc2rszh6omb+Vtct+iv0Qna
 7A371yooaPrbg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B741A100042;
 Wed, 14 Aug 2024 08:47:41 -0400 (EDT)
Received: from pastel (unknown [216.154.9.87])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 84BF112024D;
 Wed, 14 Aug 2024 08:47:41 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <86sev78fob.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 14 Aug
 2024 15:14:28 +0300")
Message-ID: <jwv7ccjnuv8.fsf-monnier+emacs@HIDDEN>
References: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN>
 <86y14z8o7v.fsf@HIDDEN> <jwv4j7npbr1.fsf-monnier+emacs@HIDDEN>
 <86sev78fob.fsf@HIDDEN>
Date: Wed, 14 Aug 2024 08:47:40 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.022 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> This doesn't look right: the meaning of `define-symbol-props` in
>> `load-history` should be defined in a more modular way, near
>> `define-symbol-prop` rather than by hardcoding something in
>> `apropos.el`.
>
> Is it better to leave us where we are now: that apropos-library
> signals an error instead of displaying the information about the
> library?

In the mean time we could just sanitize the data we use heuristically,
as in the patch below.

> Patches are welcome, but maybe we should start with someone explaining
> what are those define-symbol-props elements in load-history.  They are
> currently completely undocumented AFAICT, and so anyone but the
> person(s) who added that to Emacs will have hard time coming up with
> changes such as you describe.  (Apologies if this is already
> documented and I just missed it.)

Indeed, we currently don't have a good way to document the new kinds of
elements that can occur in `load-history` and the new ones we do have
(e.g. `cl-defmethod`, `define-type`, ...) are currently undocumented.


        Stefan


diff --git a/lisp/apropos.el b/lisp/apropos.el
index 6c6cd0b593d..0655fecd0e8 100644
--- a/lisp/apropos.el
+++ b/lisp/apropos.el
@@ -734,7 +734,10 @@ apropos-library
         ;; FIXME: Print information about each individual method: both
         ;; its docstring and specializers (bug#21422).
         ('cl-defmethod (push (cadr x) provides))
-	(_ (push (or (cdr-safe x) x) symbols))))
+        ;; FIXME: Add extension point (bug#72616).
+	(_ (let ((sym (or (cdr-safe x) x)))
+	     (and sym (symbolp sym)
+	          (push sym symbols))))))
     (let ((apropos-pattern "") ;Dummy binding for apropos-symbols-internal.
           (text
            (concat

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 14 Aug 2024 13:43:02 +0000
Resent-Message-ID: <handler.72616.B72616.172364293118831 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72616
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 72616 <at> debbugs.gnu.org, gerard.vermeulen@HIDDEN, joaotavora@HIDDEN
Received: via spool by 72616-submit <at> debbugs.gnu.org id=B72616.172364293118831
          (code B ref 72616); Wed, 14 Aug 2024 13:43:02 +0000
Received: (at 72616) by debbugs.gnu.org; 14 Aug 2024 13:42:11 +0000
Received: from localhost ([127.0.0.1]:46529 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1seEGN-0004tb-JH
	for submit <at> debbugs.gnu.org; Wed, 14 Aug 2024 09:42:11 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60596)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1seEGL-0004t6-4i
 for 72616 <at> debbugs.gnu.org; Wed, 14 Aug 2024 09:42:06 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1seEFf-00051M-75; Wed, 14 Aug 2024 09:41:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=enDRWiimUm20jxAWwYoIW6aSzGcNidGuNXbntK7syE8=; b=KGRzeQLIGH0i
 L5Bf7bkV4MQz9PxcAEJjeXfU+zAnvoSpaYf7R1z0UY7mcn/SbtFo6epcrlA9m3sWuwVx7neM+jkRW
 c4t4gYJ64PzR3of77K2rT2cLINB3+mgRiN86is++gprAU99GnE1w7W0vPB7RLCgW6415JOmxFwr+G
 VUtmtzyN1MeFAzhQJGc44Czf2WIuHzVarTSWbdFE7f7FjXraLZtUuhS5eLmun4WqLxHZn98l0WAiE
 Ec6ExQW5YDyVgsSpTpPGUMaSrgHk+1WhQ9a1hJ7OuPyyQTKHhTeECW0//9fko46pfz4F3OiIziDFJ
 vM3DiuT2gA2iC2rjFoCkog==;
Date: Wed, 14 Aug 2024 16:41:19 +0300
Message-Id: <86o75v8bnk.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwv7ccjnuv8.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Wed, 14 Aug 2024 08:47:40 -0400)
References: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN>
 <86y14z8o7v.fsf@HIDDEN> <jwv4j7npbr1.fsf-monnier+emacs@HIDDEN>
 <86sev78fob.fsf@HIDDEN> <jwv7ccjnuv8.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: gerard.vermeulen@HIDDEN,  joaotavora@HIDDEN,  72616 <at> debbugs.gnu.org
> Date: Wed, 14 Aug 2024 08:47:40 -0400
> 
> >> This doesn't look right: the meaning of `define-symbol-props` in
> >> `load-history` should be defined in a more modular way, near
> >> `define-symbol-prop` rather than by hardcoding something in
> >> `apropos.el`.
> >
> > Is it better to leave us where we are now: that apropos-library
> > signals an error instead of displaying the information about the
> > library?
> 
> In the mean time we could just sanitize the data we use heuristically,
> as in the patch below.

Thanks, will install soon unless someone has a better suggestion.

> > Patches are welcome, but maybe we should start with someone explaining
> > what are those define-symbol-props elements in load-history.  They are
> > currently completely undocumented AFAICT, and so anyone but the
> > person(s) who added that to Emacs will have hard time coming up with
> > changes such as you describe.  (Apologies if this is already
> > documented and I just missed it.)
> 
> Indeed, we currently don't have a good way to document the new kinds of
> elements that can occur in `load-history` and the new ones we do have
> (e.g. `cl-defmethod`, `define-type`, ...) are currently undocumented.

cl-defmethod and define-type _are_ documented, AFAICT.  See the
documentation of load-history.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 17 Aug 2024 09:48:02 +0000
Resent-Message-ID: <handler.72616.B72616.172388805512008 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72616
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: monnier@HIDDEN
Cc: 72616 <at> debbugs.gnu.org, gerard.vermeulen@HIDDEN, joaotavora@HIDDEN
Received: via spool by 72616-submit <at> debbugs.gnu.org id=B72616.172388805512008
          (code B ref 72616); Sat, 17 Aug 2024 09:48:02 +0000
Received: (at 72616) by debbugs.gnu.org; 17 Aug 2024 09:47:35 +0000
Received: from localhost ([127.0.0.1]:53551 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sfG23-00037c-GJ
	for submit <at> debbugs.gnu.org; Sat, 17 Aug 2024 05:47:35 -0400
Received: from eggs.gnu.org ([209.51.188.92]:52898)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sfG20-00037O-PQ
 for 72616 <at> debbugs.gnu.org; Sat, 17 Aug 2024 05:47:33 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sfG1H-0006dv-Dy; Sat, 17 Aug 2024 05:46:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=sQMVlEkrIPgV4Uj5ds8eWdyKcoonE1Ydv9n4zwLyBzc=; b=l34HglroMnsi
 UAVA+YmKIvVLMaqDKqCKTridaf0qvCFHYlc43U5EqFr2zCtGWJgbzbyPUbAVe2xDB2rS/+Yc17yS1
 EpS+skYzjxRRKSXZch5geJUIhm39E60T+QPViiSeTxVo9Vu4M0Xy7UarBgWQNlMJBmYNhqJf0qDlC
 DMISoYMbY2ewWt0uBepk5YUalLWw/E7OOKY1Q3S0SAYjWDzfY8qf5uln3At5OsODkRVoXQ4dG6ZxZ
 ugukHEAE+l4wjFlN+Px9+LMVMAW3ntUZavJZJo2JXEl0XROWQXoYnx608kWqoOBqWmDGmBOxTH+fU
 OgjB5VZpBIsWoVMHpjwIAA==;
Date: Sat, 17 Aug 2024 12:46:45 +0300
Message-Id: <86r0an32ii.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86o75v8bnk.fsf@HIDDEN> (message from Eli Zaretskii on Wed, 14
 Aug 2024 16:41:19 +0300)
References: <b8d9d2ddb72aece4ace998d26e208086@HIDDEN>
 <86y14z8o7v.fsf@HIDDEN> <jwv4j7npbr1.fsf-monnier+emacs@HIDDEN>
 <86sev78fob.fsf@HIDDEN> <jwv7ccjnuv8.fsf-monnier+emacs@HIDDEN>
 <86o75v8bnk.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 72616 <at> debbugs.gnu.org, gerard.vermeulen@HIDDEN, joaotavora@HIDDEN
> Date: Wed, 14 Aug 2024 16:41:19 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > From: Stefan Monnier <monnier@HIDDEN>
> > Cc: gerard.vermeulen@HIDDEN,  joaotavora@HIDDEN,  72616 <at> debbugs.gnu.org
> > Date: Wed, 14 Aug 2024 08:47:40 -0400
> > 
> > >> This doesn't look right: the meaning of `define-symbol-props` in
> > >> `load-history` should be defined in a more modular way, near
> > >> `define-symbol-prop` rather than by hardcoding something in
> > >> `apropos.el`.
> > >
> > > Is it better to leave us where we are now: that apropos-library
> > > signals an error instead of displaying the information about the
> > > library?
> > 
> > In the mean time we could just sanitize the data we use heuristically,
> > as in the patch below.
> 
> Thanks, will install soon unless someone has a better suggestion.

Now done.

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.