GNU bug report logs - #72666
[PATCH] Add firefly-synth package

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Apoorv <apoorvs@HIDDEN>; Keywords: patch; dated Fri, 16 Aug 2024 10:45:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 72666 <at> debbugs.gnu.org:


Received: (at 72666) by debbugs.gnu.org; 31 Oct 2024 10:57:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 31 06:57:03 2024
Received: from localhost ([127.0.0.1]:41621 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t6SrP-0003or-Cw
	for submit <at> debbugs.gnu.org; Thu, 31 Oct 2024 06:57:03 -0400
Received: from mailtransmit04.runbox.com ([185.226.149.37]:33430)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <steve@HIDDEN>) id 1t6SrL-0003oJ-Jv
 for 72666 <at> debbugs.gnu.org; Thu, 31 Oct 2024 06:57:01 -0400
Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com)
 by mailtransmit04.runbox.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)
 (envelope-from <steve@HIDDEN>) id 1t6Sp8-00EFTd-P2
 for 72666 <at> debbugs.gnu.org; Thu, 31 Oct 2024 11:54:42 +0100
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=futurile.net; s=selector1; h=Content-Type:MIME-Version:Message-ID:Subject:
 To:From:Date; bh=2wYIQMY1XT5uoNJA8VXVMUnW6SwgrFiWersbB+sjmZ4=; b=NUDnuopVAXyU
 JZnI6w7qK438q2x+DgSHdTwUr0RBLyddSREB0zcsbtP/MRlQ/t1le91u8XJvQc3Bpk8wf1jG7uibf
 JDZhyYxygQkxhkyu5QCtTQOUnG9X/v0RS0fAbAeiN49qAxrQnf4GzCMTfGnxESVaidv5nVu0c9kZj
 MyvpmphVaJ942FkxodDXA2XWDnkyp+f6AvSfv1GFuryFji4Mrd6k2U/9Di0+VMp3O0tGUUzxVx8z5
 tjjGhpYZEMC8gMLcucvPHnCdIlPJoiIXUqmw089B5rzvli0Q4y8Ruu0Twl/X0j3cA2XIyRzw+g66p
 YPKquGLqP+b53XwTYu1DpA==;
Received: from [10.9.9.74] (helo=submission03.runbox)
 by mailtransmit02.runbox with esmtp (Exim 4.86_2)
 (envelope-from <steve@HIDDEN>) id 1t6Sp8-0008D1-B4
 for 72666 <at> debbugs.gnu.org; Thu, 31 Oct 2024 11:54:42 +0100
Received: by submission03.runbox with esmtpsa [Authenticated ID (641962)]
 (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93)
 id 1t6Sp0-00Dlut-Kd
 for 72666 <at> debbugs.gnu.org; Thu, 31 Oct 2024 11:54:34 +0100
Date: Thu, 31 Oct 2024 10:54:33 +0000
From: Steve George <steve@HIDDEN>
To: 72666 <at> debbugs.gnu.org
Subject: RE: Add firely-synth package to Guix
Message-ID: <ZyNh6Y2KXm_Zrj15@dragon2>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72666
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

You sent a patch to add firefly-synth, a couple of things:

1. Looks like there's a new release, can you update the patch?
  https://github.com/sjoerdvankreel/firefly-synth/releases/tag/v1.9.6

2. You added it to the end of music.scm please don't put it there as it makes
diffs more difficult. See if there's an alphabetical location in the file if at all possible.

3. Please send patches 'in-line' so that the automated QA system can pick them up.
I think the manual now has an updated section on how to use git send-email which might help.

https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1

Thanks,

Futurile




Information forwarded to guix-patches@HIDDEN:
bug#72666; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 16 Aug 2024 10:44:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 16 06:44:05 2024
Received: from localhost ([127.0.0.1]:51749 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1seuRB-00079E-7L
	for submit <at> debbugs.gnu.org; Fri, 16 Aug 2024 06:44:05 -0400
Received: from lists.gnu.org ([209.51.188.17]:58092)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <apoorvs@HIDDEN>) id 1seuR8-00078N-Ed
 for submit <at> debbugs.gnu.org; Fri, 16 Aug 2024 06:44:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <apoorvs@HIDDEN>) id 1seuQV-0004m9-8D
 for guix-patches@HIDDEN; Fri, 16 Aug 2024 06:43:24 -0400
Received: from w1.tutanota.de ([81.3.6.162])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <apoorvs@HIDDEN>) id 1seuQT-00074Z-B2
 for guix-patches@HIDDEN; Fri, 16 Aug 2024 06:43:23 -0400
Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10])
 by w1.tutanota.de (Postfix) with ESMTP id 85CC5FBFCCB
 for <guix-patches@HIDDEN>; Fri, 16 Aug 2024 10:43:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1723804999; 
 s=s1; d=tuta.io;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender;
 bh=hC/40mYlW9auedqCDrQfT0z9iYIcdq0CcDr59N0oGbk=;
 b=RQmfbTHv+h8w+iEJdQwukLVHmOhwIgpZyHOpbTyrEIRHbAs2QiMgXLFStI8Sj25s
 uH9eONa4I0atWZVN4ux8CTkdg+v7Tb5390JhoGp79sQuz6UYEG49RzfV8CSjKm8b6tI
 9Xe8pFsGJzl3xWpek4vvV9dHYB6s7lPQGjdWKR+L7WtqMRep8gZL62Bx2+IJjTIajyW
 RrsQdMyCgfwsjgVmQasxSKO/4Pdph7xkDDY+I4VvMJ9XZKMhkzxr7ZJKLAioCnBxbVz
 Pm4Jv+SteE7aC0dZ95iYhV5ZvPbx0b7JXeRRLPSGQCs84W8wrmmexfMc1Nt+NPpD2aX
 sXZ1ZgOhQw==
Date: Fri, 16 Aug 2024 12:43:19 +0200 (CEST)
From: Apoorv <apoorvs@HIDDEN>
To: Guix Patches <guix-patches@HIDDEN>
Message-ID: <O4PmCjA--B-9@HIDDEN>
Subject: [PATCH] Add firefly-synth package
MIME-Version: 1.0
Content-Type: multipart/mixed; 
 boundary="----=_Part_83028_1927746075.1723804999562"
Received-SPF: pass client-ip=81.3.6.162; envelope-from=apoorvs@HIDDEN;
 helo=w1.tutanota.de
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001,
 RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

------=_Part_83028_1927746075.1723804999562
Content-Type: multipart/alternative; 
	boundary="----=_Part_83029_1602904391.1723804999562"

------=_Part_83029_1602904391.1723804999562
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

This is a patch to add a new package, `firefly-synth` to `gnu/packages/music.scm`.

-- 
 Sent with Tuta; enjoy secure & ad-free emails: 
 https://tuta.com

------=_Part_83029_1602904391.1723804999562
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
<div dir="auto">This is a patch to add a new package, `firefly-synth` to `gnu/packages/music.scm`.<br></div><div dir="auto"><br></div><div dir="auto">-- <br></div><div dir="auto"> Sent with Tuta; enjoy secure &amp; ad-free emails: <br></div><div dir="auto"> https://tuta.com<br></div>  </body>
</html>

------=_Part_83029_1602904391.1723804999562--

------=_Part_83028_1927746075.1723804999562
Content-Type: text/x-patch; charset=us-ascii; 
	name=0013-Add-firefly-synth-package.patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; 
	filename=0013-Add-firefly-synth-package.patch

From 5d08a4fee0ac8906780c43f340d01e9d0b82c03b Mon Sep 17 00:00:00 2001
From: apoorv569 <apoorvs569@HIDDEN>
Date: Fri, 16 Aug 2024 15:37:25 +0530
Subject: [PATCH 13/13] Add firefly-synth package

---
 gnu/packages/music.scm | 70 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 5b89419b07..6a28d73429 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -8577,6 +8577,76 @@ (define-public bitrot-plugins
       "Audio effect plugins (LV2, VST2, LADSPA) for glitch effects")
      (license license:asl2.0))))
 
+(define-public firefly-synth
+  (let ((commit "b4ba5a90461d698000df73ebff736570667e42ac")
+        (revision "1"))
+    (package
+     (name "firefly-synth")
+     (version (git-version "1.8.5" revision commit))
+     (source
+      (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/sjoerdvankreel/firefly-synth")
+             (recursive? #t)
+             (commit commit)))
+       (sha256
+        (base32 "1j6cap45608jdybgj3zsqlfbzmqpqxl29jk7ikk3x7d29jaxw84r"))
+       (file-name (git-file-name name version))))
+     (build-system cmake-build-system)
+     (arguments
+      (list
+       #:tests? #f ;; No test target
+       #:build-type "Release"
+       #:phases
+       #~(modify-phases
+          %standard-phases
+          (add-after 'install 'plugin-base-ref-gen
+                     (lambda* (#:key outputs #:allow-other-keys)
+                       (let* ((out (assoc-ref outputs "out")))
+                         (with-directory-excursion
+                          "../source/dist/Release/linux"
+                          (system*
+                           "./plugin_base.ref_gen"
+                           "firefly_synth_1.vst3/Contents/x86_64-linux/firefly_synth_1.so"
+                           "../../../param_reference.html")))))
+          (add-after 'plugin-base-ref-gen 'copy-plugin-artefacts
+                     (lambda* (#:key inputs outputs #:allow-other-keys)
+                       (let* ((out (assoc-ref outputs "out"))
+                              (src (assoc-ref inputs "source"))
+                              (clap (string-append out "/lib/clap"))
+                              (vst3 (string-append out "/lib/vst3")))
+                         ;; Make clap and vst3 directories
+                         (mkdir-p clap)
+                         (mkdir-p vst3)
+                         (with-directory-excursion
+                          "../source/dist/Release/linux"
+                          ;; Install clap.
+                          (copy-recursively
+                           "firefly_synth_1.clap"
+                           (string-append clap "/firefly_synth_1.clap"))
+                          (copy-recursively
+                           "firefly_synth_fx_1.clap"
+                           (string-append clap "/firefly_synth_fx_1.clap"))
+                          ;; Install vst3.
+                          (copy-recursively
+                           "firefly_synth_1.vst3"
+                           (string-append vst3 "/firefly_synth_1.vst3"))
+                          (copy-recursively
+                           "firefly_synth_fx_1.vst3"
+                           (string-append vst3 "/firefly_synth_fx_1.vst3")))))))))
+     (inputs (list libxrandr
+                   libxinerama
+                   libxcursor
+                   freetype
+                   mesa
+                   alsa-lib))
+     (native-inputs (list pkg-config))
+     (home-page "https://github.com/sjoerdvankreel/firefly-synth")
+     (synopsis "Semi-modular synthesizer and FX plugin, VST3 and CLAP")
+     (description "A semi-modular software synthesizer and fx plugin")
+     (license license:gpl3))))
+
 ;;;
 ;;; Avoid adding new packages to the end of this file. To reduce the chances
 ;;; of a merge conflict, place them above by existing packages with similar
-- 
2.45.2


------=_Part_83028_1927746075.1723804999562--




Acknowledgement sent to Apoorv <apoorvs@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#72666; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.