GNU bug report logs - #72731
Wrong source comment in src/w32term.c

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 20 Aug 2024 11:44:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 07:44:09 2024
Received: from localhost ([127.0.0.1]:59956 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sgNHU-0007aO-Eh
	for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 07:44:09 -0400
Received: from lists.gnu.org ([209.51.188.17]:57368)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cpardo@HIDDEN>) id 1sgNHR-0007aG-TF
 for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 07:44:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <cpardo@HIDDEN>)
 id 1sgNGk-00024k-5l
 for bug-gnu-emacs@HIDDEN; Tue, 20 Aug 2024 07:43:22 -0400
Received: from mail.imayhem.com ([82.223.54.191]
 helo=zealous-pike.82-223-54-191.plesk.page)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <cpardo@HIDDEN>)
 id 1sgNGg-0007w4-Fh
 for bug-gnu-emacs@HIDDEN; Tue, 20 Aug 2024 07:43:21 -0400
Received: from [10.0.12.202] (66.red-2-136-43.staticip.rima-tde.net
 [2.136.43.66])
 by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id BFA0D800F2
 for <bug-gnu-emacs@HIDDEN>; Tue, 20 Aug 2024 11:43:15 +0000 (UTC)
Authentication-Results: zealous-pike.82-223-54-191.plesk.page;
 spf=pass (sender IP is 2.136.43.66) smtp.mailfrom=cpardo@HIDDEN
 smtp.helo=[10.0.12.202]
Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is
 authenticated)
Message-ID: <24971b2b-a0a6-47ce-9f20-74324b88ea47@HIDDEN>
Date: Tue, 20 Aug 2024 13:43:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: es-ES
To: bug-gnu-emacs@HIDDEN
From: Cecilio Pardo <cpardo@HIDDEN>
Subject: Wrong source comment in src/w32term.c
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=82.223.54.191; envelope-from=cpardo@HIDDEN;
 helo=zealous-pike.82-223-54-191.plesk.page
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

I think this comment in w32term.c is wrong:

     ...
     case WM_RBUTTONUP:
     case WM_XBUTTONDOWN:
     case WM_XBUTTONUP:
       {
             /* If we decide we want to generate an event to be seen
                by the rest of Emacs, we put it here.  */
         Lisp_Object tab_bar_arg = Qnil;
         bool tab_bar_p = 0;
     ...

It was added on

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=791f420fea18d7ef5ddfc386509de2c84d4f39c3 


+ /* If we decide we want to generate an event to be seen
+ by the rest of Emacs, we put it here. */
+ struct input_event emacs_event;
+ int tool_bar_p = 0;
int button;
int up;


The comment is attached to the emacs_event variable?

The variable was then removed on:

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=004b1d3853dbb7ef5c5b2e3b5d011718e602c33a 



/* If we decide we want to generate an event to be seen
by the rest of Emacs, we put it here. */
- struct input_event emacs_event;
int tool_bar_p = 0;
int button;
int up;


But the comment stayed there for years to come.