Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Received: (at 72735) by debbugs.gnu.org; 13 Feb 2025 16:38:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 11:38:28 2025 Received: from localhost ([127.0.0.1]:45175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ticEO-0003es-8z for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 11:38:28 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:50618) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1ticE9-0003eD-HZ for 72735 <at> debbugs.gnu.org; Thu, 13 Feb 2025 11:38:15 -0500 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-aaec61d0f65so261926066b.1 for <72735 <at> debbugs.gnu.org>; Thu, 13 Feb 2025 08:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739464687; x=1740069487; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=aeBn5s3dNAHeYvpichUTiBucP1tNDNJtehlPc+zm7dg=; b=VvfAGYGztyh8lzMMnZ8QDeAPiAKMi/bh09NAm0XRncGhZSp0X8QQEh6In3BTL+Dt+7 zakQjewzEZs8mDsjceYyXqMhoUlH2NhTFxtmHeC8Vb2w/GwxICo2VVvgTpue3UgIiwXL 1MMZrKD1wyrtx+BCgzk19GZ2Lj91ppVlk7eJj8owiqtcnz5ir+V3RKe6wFL+HJpS0DeE RssQNONYlWfuy3T/qVscDXoX3Ezl1HZ7GOteu0W3DTIF7jV3bAJJd7lFmc/6gWv48vXF Iw9FRaErJXUQXcMlwoQxd5WqFovSafRXbXyXnTRn9iaftvnY1OntIWr4T8GQgvDzuYX1 XFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739464687; x=1740069487; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aeBn5s3dNAHeYvpichUTiBucP1tNDNJtehlPc+zm7dg=; b=MGEW4WY0tq/sgwG2M7zbUaPKsEUhmmEKVKLrbaQDxx6+exs3AQdSVtF4FiQjlGyloL uF+ay3Ao7OgWmZA2duFVC/tWr89UwoW3IYWwaEYAQvAeMMAEZfnW6nVvj91CWN8Hc9nA hMUikpc6zLCW4K6Eux30hAwFFjOURLQld/bBX4z0O036QXGYOX2IWBl/haRzMyFziSTT XSOpA6jE4CzLgtvx1+NTRf0RLNKmnbGUepWxC7noZNG78F0bVqmSgWNZtLV+aieivGJs yOUQubpaS3Zql2VjCSS6XVrSpxCLBkRuJlHe5cIlEBqERVqjtFNlBgbcXj7BM3RoBx8y 1izw== X-Forwarded-Encrypted: i=1; AJvYcCXdeGvyLTGzdW3qVFmHV3I/ZttRlzZGGlQfCSYiZ0RyUiPW0Z1Wg1SZCfLr9yqqQPwBljlviw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwyFuetqUvKF8CRMPgiKI7LqE9MEGjgTa9jtRigsA40FN8p8/mD uexpl7MxuE2w9CtyUHkaVkGiHtx75GRmGjiloktW7fH8GEpqiNgV7/Iy91njDSYvidwT3p6b7r/ s8p6+T9lq6hz+XISvIPCtuj7Gklk= X-Gm-Gg: ASbGncuL78UI4BDtmVXMonvt5U2HHl5Qb6hjxxl8rITOSzpAhpc1ygxzFwBDwfoqKAa TaF2zUYgohD8ExxAXHRIirFanfUCxpa19xvjubRtiC3aIVMaA6kFGotEnuLrp1s2LZUI1tJ5DyP o= X-Google-Smtp-Source: AGHT+IG338KKcZCOQjL5N1K+iYrvvPep2qGCMTq+bPHO96vSxJQ58Vg2CiHUm2PTS3H4jYJVmmihTjI5R1Jlq3U5w5o= X-Received: by 2002:a17:907:970b:b0:ab7:63fa:e49c with SMTP id a640c23a62f3a-aba5017e536mr415665266b.36.1739464686735; Thu, 13 Feb 2025 08:38:06 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Feb 2025 08:38:05 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87ikpd7rux.fsf@HIDDEN> References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN> <87seojhe6p.fsf@HIDDEN> <87ikpd7rux.fsf@HIDDEN> MIME-Version: 1.0 Date: Thu, 13 Feb 2025 08:38:05 -0800 X-Gm-Features: AWEUYZlyCzIE8wWUJNIrfRs2-PALmO2MBVTHZgDTSuJc1Vs8fX6N0E_rQ9sKB7Q Message-ID: <CADwFkmkuNgaTMydH8mExagS00jtoCAmSac1c_tzb7O_c-eBgDw@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable To: Tassilo Horn <tsdh@HIDDEN>, =?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72735 Cc: Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) reopen 72735 tags 72735 - wontfix thanks Tassilo Horn <tsdh@HIDDEN> writes: > As said, I'm positive about the three variables > bug-reference-setup-from-*-alist becoming defcustoms. But for any other > defcustomization, especially those where additional "default" variables > need to be introduced, I don't think it's worth it. Bj=C3=B6rn, can you please respin the patch to make these three variables defcustoms? Please also include the changes to the manual and NEWS. Thanks in advance.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 13 Feb 2025 16:06:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 11:06:29 2025 Received: from localhost ([127.0.0.1]:45084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tibjQ-0002DX-KN for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 11:06:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33590) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <tsdh@HIDDEN>) id 1tibjN-0002DH-Qr for 72735 <at> debbugs.gnu.org; Thu, 13 Feb 2025 11:06:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <tsdh@HIDDEN>) id 1tibj7-0006Jy-HX; Thu, 13 Feb 2025 11:06:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=SoPdSEGfoygUqw6+g6zTvg7iFFZmesq/kGgiJlKcXeg=; b=XIoX3HPxomJd8NoJtRBD RR0mQWwE2ywPncsZoKujB5Al8/lKlf0z0IiWtrWmIEKGWfmkvpqetUK8sdSad7OeRE+/PkUnMHVN/ 8384PCzFTaCOs4zW/T8w8fhJW8envMDjagX3HT9fMVqljO+937rDcw7GEAogoUEL+gzX1wNDk8TnZ OQCWklmDJ4mF3O6kH9EzihbJmbUfxeK4aLZjItZRsu3Xw2abq0Kp8OlWvKRsI/2RYTerBtIiPJ3UN 3UoXtlbtGIQ8ibXVCRyijesSdO9nOXGao9XhbyYWEH1LjVDJ/oMNSAFJEPTNW6YZA+hfzQpCl6Bxy XINjM2kWeqBbjg==; X-ME-Sender: <xms:ORiuZ6WVvRZWlGL-W2SsLhuweRu_iSzUORoaOOBTwvrfezLwezVMSQ> <xme:ORiuZ2kRPVX21PQQH2M2XPqdlTvYSE6LTM7Mz54nAuvzJUkRudU3wML3vjLB3z3Ab 1ItO9d4U133TQ> X-ME-Received: <xmr:ORiuZ-YX0TqtffmxzwwXl67w1s9Uo7FJx3LQA1zqoQaDqh531bRSnpHmYXlSgi-4X8RzDdcrb4Pdf2pvrokf1otzs3W6YnA4> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegjedvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttder jeenucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqe enucggtffrrghtthgvrhhnpeeivdduudekffegfeduueffgffhvdefvdelhfduiefffeeh gfetkeetleffueffhfenucffohhmrghinhepuggvsghirghnrdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhm thhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqth hsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmhdpnhgspghrtghpthhtohep fedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjedvjeefheesuggvsggsuhhgsh drghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthho pegsjhhorhhnrdgsihgurghrsehthhgrohgurghnrdguvg X-ME-Proxy: <xmx:ORiuZxU9a6fF8ngl7aLlrDNjesNlSBxwV69Fyb-FtqP6k-EsjTCFvw> <xmx:ORiuZ0mkKWPJ0wFSk2t6AbQOCJBGUlbUaJvv-q1yO88Q7Ki61gRClQ> <xmx:ORiuZ2clh-TAHx0tI5hb3faYIrVjm8F7EAAgwKLE6RfQSHT2SFBWmg> <xmx:ORiuZ2EIt_iZEwcRvsXWCSqcRvXstZwLnEnKcUPbbBvHpFznvBjipA> <xmx:ORiuZymEkjfbej3ilnjHnNWR3O5WCKFYsNKWF0WJJfoMGdcLu_HtqEPH> Feedback-ID: ib2b94485:Fastmail From: Tassilo Horn <tsdh@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable In-Reply-To: <87ed03ezxt.fsf@> References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN> <87seojhe6p.fsf@HIDDEN> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Thu, 13 Feb 2025 17:05:10 +0100 Message-ID: <87ikpd7rux.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72735 Cc: Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN> writes: Hi Bj=C3=B6rn, >> No, bug-reference should work out-of-the-box for every project >> checked out of the forges in bug-reference-forge-alist. Well, unless >> you've set bug-reference-url-format globally which would turn off the >> auto-setup. > > I get that point however not all or none, depending on one's usecase, > might use forges to track bugs. Sure, that's where .dir-locals.el or the three variables come into play. >>> Or is the purpose of bug-reference mode GNU specific and not >>> intended to be used for anything but GNU? >> >> As said, it works out-of-the-box for Github, several Gitlab >> instances, codeberg, framagit, salsa.debian.org, and sr.ht. > > I know these where the where a customize variable works the easiest > similar to Forge's forge-alist. Sorry, cannot parse this sentence. > Would it make sense to include common instances of FOSS projects such > as for example Freedesktop, KDE and GNOME in to the > bug-reference-forge-alist by default? Yes, absolutely. > I will try to send some patches in a few days. As said, I'm positive about the three variables bug-reference-setup-from-*-alist becoming defcustoms. But for any other defcustomization, especially those where additional "default" variables need to be introduced, I don't think it's worth it. Bye, Tassilo
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.
Received: (at 72735) by debbugs.gnu.org; 12 Feb 2025 19:16:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 14:16:43 2025
Received: from localhost ([127.0.0.1]:38322 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tiIDy-0003DQ-O7
for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 14:16:43 -0500
Received: from thaodan.de ([2a03:4000:4f:f15::1]:46050)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>)
id 1tiIDw-0003Cy-Hq
for 72735 <at> debbugs.gnu.org; Wed, 12 Feb 2025 14:16:41 -0500
Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49])
by thaodan.de (Postfix) with ESMTPSA id C2411D00055;
Wed, 12 Feb 2025 21:16:31 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1739387791; bh=tyaykK3PB/gW+1BSrl276TUV9XblW7Bb/XM9wADBZKQ=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=PEa0fS+OeFhjD50v/gZ+z/uHHGNNZySGjVBGgemvBocpQjtcrBDg/aCBA6YsbImzf
guPqSgbJ+RonwyPx64ytGF92b3FwQK46gSKCtw9KXAvJ3kKxeIKu1JmAAEHWqeyY6z
zHDHjQkLYXmkbtKvGiBllaGq4EHwn6bjXC+PgvFTgFiTAy13JA3dn+7Q029m+VRWSn
jfXugzpbhmrnm0vYUb5wrGh21E3xSF4CaTVHNxUJUozjrGHNe1JFYol7ktUgEo1iIn
wmDGjz73sqR1IjMfit0E5os/fznxBwtHT4iAzOCBtv3jTxVBpdiWHQF74xZOxLJxbE
7G2HxhxXJtYQAYMouhrGBDb44+a0Xh+x58KPJGR4ieKehIJAKkwtvvDKTtG04M8Qrh
BTQoAyJvrsvD6xjYo0M2mneLA578QxwUgdWovsdp4RzNuljGIXRKkFzKZNuvrPCHDo
M1pNmuPLlEottXaKeyhNM6Fy70eG6aGixIly2m8Ejrl00x4qbI9A+U8339ko7hsHrI
hOFuMnRfDwbnugBCGM1g5u7XbIoYGPEqMVjRuruGh0wW2qcISlB7lmzl7OfrLNotJ2
BHhXRv1+6kV7G8fQcWE6NdcMj/VHrKeAgZ9mmw1QOM/RODlw4XkGVoejeJZCDhTpVg
KqaAnI1kKB1M0DYI453jfsKc=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Tassilo Horn <tsdh@HIDDEN>
Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables
customizeable
In-Reply-To: <87seojhe6p.fsf@HIDDEN> (Tassilo Horn's message of "Wed, 12 Feb
2025 07:25:50 +0100")
References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN>
<87seojhe6p.fsf@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Wed, 12 Feb 2025 21:16:30 +0200
Message-ID: <87ed03ezxt.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Tassilo Horn <tsdh@HIDDEN> writes: > Björn Bidar <bjorn.bidar@HIDDEN>
writes: > > Hi Björn, > >>> As Eli already mentioned, bug-reference-url-format
is usually set via >>> a file local variables section or programatically
so neit [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 72735
Cc: Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Tassilo Horn <tsdh@HIDDEN> writes:
> Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN> writes:
>
> Hi Bj=C3=B6rn,
>
>>> As Eli already mentioned, bug-reference-url-format is usually set via
>>> a file local variables section or programatically so neither a
>>> defcustom nor a default value makes sense.
>>>
>>> Wrt. bug-reference-setup-from-mail-alist,
>>> bug-reference-setup-from-irc-alist, and
>>> bug-reference-setup-from-vc-alist: yes, they could be defcustoms but
>>> their entries can all (and are likely to) contain functions which are
>>> hard to specify in the defcustom interface. I've thought it wouldn't
>>> be needed. After all, bug-reference is a programmer's tool.
>>
>> Isn't that a weak argument against changing those to a defcustom?
>
> Maybe. I have no problem with those three being defcustoms.
>
That's great. It would certainly help new user to discover and get
started customizing.
>> With the current default values if not modified it is much harder to
>> use them for anything else but the GNU debbugs instance.
>
> No, bug-reference should work out-of-the-box for every project checked
> out of the forges in bug-reference-forge-alist. Well, unless you've set
> bug-reference-url-format globally which would turn off the auto-setup.
I get that point however not all or none, depending on one's usecase, might=
use
forges to track bugs.=20
>> Correct me if I'm wrong but all those variables only regular
>> expressions and a format string which is something that already has
>> been done using defcustom e.g. as in Gnus.
>
> In all three, BUG-REGEXP and URL-FORMAT can be functions as documented
> by bug-reference-bug-regexp and bug-reference-url-format. Oh, and with
> bug-reference-setup-from-vc-alist there's only a URL-FORMAT-FN which
> must be a function.
OK that sounds good.
>> Isn't it the policy that for settings variables there should be
>> defcustom variables? E.g. as mentioned in (info "(elisp) Documentation
>> Tips"):
>>
>>> =E2=80=A2 When you define a variable that represents an option users=
might
>>> want to set, use =E2=80=98defcustom=E2=80=99. *Note Defining Var=
iables::.
>>
>> Or is the purpose of bug-reference mode GNU specific and not intended
>> to be used for anything but GNU?
>
> As said, it works out-of-the-box for Github, several Gitlab instances,
> codeberg, framagit, salsa.debian.org, and sr.ht.
I know these where the where a customize variable works the easiest
similar to Forge's forge-alist.
Would it make sense to include common instances of FOSS projects such as
for example Freedesktop, KDE and GNOME in to the
bug-reference-forge-alist by default?=20
> And adding you company's tracker is quite easy, too. That's what I use:
>
> --8<---------------cut here---------------start------------->8---
> (let ((shd-jira-regexp (concat "\\b\\(\\("
> (regexp-opt '("ARCA" "BRI" "ECOJ" "KASE" "=
MOBA"
> "PORC" "LOWE" "SABA"))
> "-[0-9]\\{1,6\\}\\)\\)\\b")))
> (add-to-list 'bug-reference-setup-from-vc-alist
> `("srv-upsource\\.shd\\.lan"
> ,shd-jira-regexp
> ,(lambda (_)
> :dont-hl-value-as-docstring
> "http://srvjira-and.shd.lan/browse/%s")))
>
> (add-to-list 'bug-reference-setup-from-mail-alist
> `("SHD" nil ,shd-jira-regexp
> "http://srvjira-and.shd.lan/browse/%s"))
> --8<---------------cut here---------------end--------------->8---
Oh that's that looks very useful. Thank you.
That would have been what I would try next.=20
>>> Wrt. bug-reference-forge-alist: if it became a defcustom and a user
>>> would set it, she wouldn't see updates (like support for some new
>>> forge) in its default value anymore because their old saved custom
>>> value overrides the new default value. It's much better to add new
>>> entries programatically using add-to-list or push/cl-pushnew. Of
>>> course, one could split the variable in some *-default-alist defvar
>>> and a defcustom *-alist where the latter is meant for user
>>> customization but I think it's not worth the added complexity here.
>>
>> Didn't have time to work on this. Besides that the general downside
>> with custom is that if the user modifies it they do not get the
>> updates to the default value a separate variable similar to
>> browse-url-handler and browse-url-defautl-handlers would be an option.
>
> That's what I've said, yes. And I recall some recent discussion where
> it was argued that the browse-url-(default-)handlers split (one for
> users, one for emacs/packages) was adding too much complexity.
Hm I didn't exactly follow those discussions but I know some of those
layered configuration systems had their difficulties.
In this instance I mean with layered that that the default configuration
is taken and then merged with each additional layer where each layer
after it can override the previous configuration.
I know that custom doesn't deal well with list variables.
If this is a common issue some shared solution might help but I digress.
Using some sort of -default variable would make it the easiest to
include more forge's into the alist without messing with defaults even
when not using custom.
I will try to send some patches in a few days.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 72735) by debbugs.gnu.org; 12 Feb 2025 14:30:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 09:30:49 2025
Received: from localhost ([127.0.0.1]:33494 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tiDlI-000379-OL
for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 09:30:49 -0500
Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:44441)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
id 1tiDlF-0002lO-AB
for 72735 <at> debbugs.gnu.org; Wed, 12 Feb 2025 09:30:45 -0500
Received: by mail-ed1-x52c.google.com with SMTP id
4fb4d7f45d1cf-5de63846e56so8200579a12.1
for <72735 <at> debbugs.gnu.org>; Wed, 12 Feb 2025 06:30:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739370639; x=1739975439; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=MyX4DrE4ANekJp7bfuib2MhOHj22/yxw5NHT2CtyFt4=;
b=WmawqcLuk185v2AlWSE12gUYfjlK7KRVW0sLj8jzGLH+qyiNinmsDtnlBMMmSMc0fp
7J//jneeoLw5EijkujPxUWIKOgVlcQcsbzm+c3MKKiCcnbQnuW0qiV+ix1HYX+eIWVB+
mYhHb+0rfE6P6KUmiEFbyXJ7+yP7UWv9Hm8bwKZjdETXscriGvuZ5qniCvBl3ZQt1P6p
aCWjJLumE8m3jKo4C+TA2zizcYvRN8NDr5nKxJn4zAx/iXdrJvfz+nvy9cg0u2ppDCcY
EHWCFfhjPdzRSH4ggmjzG9kAo3Z9Y2/0vhslbWFfTqimbohTyUO3c7qsr6nTNuvXJgdm
FQYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739370639; x=1739975439;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=MyX4DrE4ANekJp7bfuib2MhOHj22/yxw5NHT2CtyFt4=;
b=WfR0gkzRA5maPX7g8MLc1E8NODyIkvjfOibhJNFIObXT8QpYNzMk96v1njmXhVmmt4
O8lUXIruv/HZ/oEwIvZSHERtnNbTdgtxxKW2d+LZEUm7ghnbjuAQnZg7XkECcAlWpshv
JHidSMA9k/A4YlR7HnuBuU8KxzY04G4S1OI9U0M5nF2EzDHCFA5vIWW+0106IZqU0TRJ
lrYjtOUPY+8uIb8inWV6fJHRigQTxcc38JETy3nvmESlb7rZ1N76LjlhLrPV5TM9e36K
xbBW22rpyKG4T8d31qdrkYFcn9ajhqc2T3Nropmyh1qRnxmb6XUnS7frDiED6LdCRSmR
jLUw==
X-Forwarded-Encrypted: i=1;
AJvYcCVC/Xt1nLPMcJpcnHoh60Qmwfg3kt8LHWVnQEps/DXrJ/e+K1SElkPOW+rDo9axQUZdL4kRFA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzrPRrcl8oNWl0H8etNdwnMrrE0mtT3TFYPq18NAFTxjncWCqPy
cY0T/BLcw72XNOcMs/lG2SZt3oEzBBjb2DDmcTMLrsYrEoUgs5p2hwUsJDbfIiR+ikUgHwB50nc
b3sfBCQrY00EY7GZA4r+2klRJ1sI=
X-Gm-Gg: ASbGncvDl3+r4QYjf9W1nhbgTaCk0qhXLr5xj/CETBJfNsxXGqBo4Q+7oqiQvo/u6QR
xpOOsXROBYo+Dgc4SlTBRPHA9bHASzEjTQ1MXLzTLPs3gwK8zXKYv9KZbWYOeiT5rr/hj/fDIjl
U=
X-Google-Smtp-Source: AGHT+IGiC6zGl37W43SjVmed2sglkJA0W2VruyTFkHMIxazH+ZwaLQj4hO1Yc15BEGr0+x5JgABjvJ1u5zueyQ4LFoo=
X-Received: by 2002:a05:6402:238e:b0:5de:bb61:5d81 with SMTP id
4fb4d7f45d1cf-5debb615e8cmr810403a12.20.1739370639020; Wed, 12 Feb 2025
06:30:39 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Wed, 12 Feb 2025 06:30:38 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87v7tfzdsq.fsf@HIDDEN>
References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN>
<87seojhe6p.fsf@HIDDEN> <87v7tfzdsq.fsf@HIDDEN>
MIME-Version: 1.0
Date: Wed, 12 Feb 2025 06:30:38 -0800
X-Gm-Features: AWEUYZnRrj1cVGQJKnf1aWqLJICbC6VlMaBRhYUFxIhEzgqBKKGiYmWL16aiLIU
Message-ID: <CADwFkm=M6mtJWRYf0ky5UkzPyHQCBfiUCgD0_HMckfA8yXxj4Q@HIDDEN>
Subject: Re: bug#72735: 31.0.50;
[PATCH] Make more bug-reference variables customizeable
To: Tassilo Horn <tsdh@HIDDEN>,
=?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72735
Cc: Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Tassilo Horn <tsdh@HIDDEN> writes:
> As Stefan K. already said: setting up bug-reference using a
> .dir-locals.el is probably the better & easier approach for many cases.
Note also that this is also what is currently recommended in:
(info "(emacs) Bug Reference")
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.
Received: (at 72735) by debbugs.gnu.org; 12 Feb 2025 09:57:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 04:57:06 2025
Received: from localhost ([127.0.0.1]:60996 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ti9UQ-0003lq-GL
for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 04:57:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:34970)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <tsdh@HIDDEN>) id 1ti9UN-0003kw-VD
for 72735 <at> debbugs.gnu.org; Wed, 12 Feb 2025 04:57:04 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <tsdh@HIDDEN>)
id 1ti9UI-00006y-Do; Wed, 12 Feb 2025 04:56:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
From; bh=nvDU/lAQhDHIS586nkxfp4oSlcsisCF7lQ4Nv+q1dVs=; b=Fy2o0o2Gev2s8QiMhjbJ
tL4HJukFH68VvzH8XkJri+DUhuGjYj9s8paKcVwOx6/rJaEeLWCXazmxBKUZ598o9znhIDU+rKFiq
QWZxX3lWMP5md1NJiLENbTebFVdpBbyLjphE3L8C59DRvql0Of7K3GC8E9hCpV1XCjV0T9RMKsb5r
AGjmWo3Ci3ip6vti4DA5mPIIy1uhJ6jTJnMCy6v79vHhKqQnQRYx7H2yc9kCuMx2GkOeHucfSgX26
bknDsc5Fc5DKkbBJD+ssO+a11bbGQ/LP5sp2TARQW2B1iagiOlb86HEDcnVeDFRPyejJsFcDoBZXL
UtH71sS21dIe3w==;
X-ME-Sender: <xms:Z3CsZ1lHQJbvSfhO1R42kty7kPbshy6OVcghOlfntqyrttbxolGrgQ>
<xme:Z3CsZw1zevWXGmzxaEDd6hWmv0QTpahMMQsZbGjrxRvRw3wf9_iASOgpHesKqRf2R
h8KTfLt_h7KYA>
X-ME-Received: <xmr:Z3CsZ7oC3dUKrIj_eIKk410CxGJEFawtexwAkqpbR-AbAUEg1Jg2D_r2q8In8__aJFyDQXFHMwwGsC_Odeto3yHSweBHq3rD>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegfeehjecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp
uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg
hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt
necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne
cuggftrfgrthhtvghrnhepieffkeeuiedtlefhuedtgeekveefhfefhedtudevieefvdfg
ueeifeekjeeuffehnecuffhomhgrihhnpehshhgurdhlrghnnecuvehluhhsthgvrhfuih
iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghu
thhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpe
epghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmhdpnhgspghrtghpthhtohepfedpmhho
uggvpehsmhhtphhouhhtpdhrtghpthhtohepjedvjeefheesuggvsggsuhhgshdrghhnuh
drohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopegsjhho
rhhnrdgsihgurghrsehthhgrohgurghnrdguvg
X-ME-Proxy: <xmx:Z3CsZ1mx6LMkGSxB1jQuqWxD0gWIMn-U1g2AlOWFsVNIra8PEI1vrQ>
<xmx:Z3CsZz09uZGhXIjmuecJSBxVNeVldJOiNNL1lG3NRr2K-PsZfNkz_g>
<xmx:Z3CsZ0t9BlQ_Ia-jsr3449ja9pYH4pvO9bVhZLW22tnJMEjzj_KRcg>
<xmx:Z3CsZ3VMFpl5w_atfmVEmXPURy95PfO0icUnywayJYzIUJQPRTgR7w>
<xmx:Z3CsZ614vDE5hQFnypBl5KY4rsOti5I993DaKcSVPBgrvgFKpXsIfvyY>
Feedback-ID: ib2b94485:Fastmail
From: Tassilo Horn <tsdh@HIDDEN>
To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables
customizeable
In-Reply-To: <87seojhe6p.fsf@HIDDEN>
References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN>
<87seojhe6p.fsf@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 31.0.50
Date: Wed, 12 Feb 2025 10:56:53 +0100
Message-ID: <87v7tfzdsq.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72735
Cc: Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Tassilo Horn <tsdh@HIDDEN> writes:
> Oh, and with bug-reference-setup-from-vc-alist there's only a
> URL-FORMAT-FN which must be a function.
I've changed that now so that URL-FORMAT-FN became URL-FORMAT which can
be string or function. The string variant suffices in many situations
like my own below.
> And adding you company's tracker is quite easy, too. That's what I use:
>
> --8<---------------cut here---------------start------------->8---
> (let ((shd-jira-regexp (concat "\\b\\(\\("
> (regexp-opt '("ARCA" "BRI" "ECOJ" "KASE" "MOBA"
> "PORC" "LOWE" "SABA"))
> "-[0-9]\\{1,6\\}\\)\\)\\b")))
> (add-to-list 'bug-reference-setup-from-vc-alist
> `("srv-upsource\\.shd\\.lan"
> ,shd-jira-regexp
> ,(lambda (_)
> :dont-hl-value-as-docstring
> "http://srvjira-and.shd.lan/browse/%s")))
>
> (add-to-list 'bug-reference-setup-from-mail-alist
> `("SHD" nil ,shd-jira-regexp
> "http://srvjira-and.shd.lan/browse/%s"))
> --8<---------------cut here---------------end--------------->8---
With my latest change, the first add-to-list can now be written as
(add-to-list 'bug-reference-setup-from-mail-alist
`("SHD" nil ,shd-jira-regexp
"http://srvjira-and.shd.lan/browse/%s"))
So now all three variables bug-reference-setup-from-*-alist may contain
entries with only simple strings, none strictly requires a function
(unless you need to derive the bug URL from the VC URL). As such, they
could become defcustoms (of course, those must allow functions where
applicable, too) that could be customized at least for the simple cases
(like my dayjob config above). I wouldn't reject a patch in this regard
(although I'm not convinced that many users would prefer that).
As Stefan K. already said: setting up bug-reference using a
.dir-locals.el is probably the better & easier approach for many cases.
Bye,
Tassilo
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 12 Feb 2025 08:06:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 03:06:42 2025 Received: from localhost ([127.0.0.1]:60703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ti7la-00031b-Ej for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 03:06:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58018) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <tsdh@HIDDEN>) id 1ti7lX-00031J-Lq for 72735 <at> debbugs.gnu.org; Wed, 12 Feb 2025 03:06:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <tsdh@HIDDEN>) id 1ti7lR-0005vz-ND; Wed, 12 Feb 2025 03:06:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=uRvlRR2wAsgNaWdI1BZDWFS3607SIFCKoqvUzKsFaXY=; b=muQgtqC8F1jneW/nauzu 2ZI4uBsG9w2aJnOxr/3tORd5rH6mvlL507ekxaIiawB8Ult5oucs+yWvjANcJoJErNR2Wxh7wghoq ruo8YtF8ilH3fK/wBZJvFDwI01XoMZ0a/mQ2OSVWqH6L7mMQPGyY8Z4aln8rqAONLA57Ap7QOGmda Nv48euC0r87OsAFhWetSgp8kKjjttI/QF3g2lnx3y5y5vkIwmzKGL/TpjmX9AOMghbywjwPqSKrB4 yHejJddBYJQzwvD4mc0uaSnqVtCx9DiuilsSG9CvvAuGD2tWJTCxv921nbI7ML7H6VOJrn8y08YWj DegnlwAuXsmsOg==; X-ME-Sender: <xms:iFasZ2I5hsRP9KHE3JixPkmKTzvIVEgflelX-IK9VuTQlLgXkiOSxA> <xme:iFasZ-KWAm8VWx86kcpW7rEfO3wMFedTjj3Z3-ZbD_Wva5D_QTTnhmxcxQtjGcdMh b-yzU9d0b8GGw> X-ME-Received: <xmr:iFasZ2uiYaM6TQO9aOtATlETBeYusjjU3rSD2JC2dAb6ivusuby44usyX-74RVnDUc1H2Nn1rks1jengJDuzDVO0zLFU_zd1> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegfeefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne cuggftrfgrthhtvghrnhepleduvdegfeduvdejkeefteelgeetgfevhefhueffueffgeeh gfeufefgvdffgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepjedvjeefheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiii esghhnuhdrohhrghdprhgtphhtthhopegsjhhorhhnrdgsihgurghrsehthhgrohgurghn rdguvgdprhgtphhtthhopehsthgvfhgrnhhkrghnghgrshesghhmrghilhdrtghomh X-ME-Proxy: <xmx:iFasZ7a1BRLjmUbTdoz-bCzakMlq0p43Od_lDCXOIfyHhqy-zGp5UA> <xmx:iFasZ9amu2GJ6ivbNxyPHE4qJyWf70A7DhqHo0vXaRQE7BZ685a61g> <xmx:iFasZ3Dp-BaFLcDh4GAZevB4bCYEBRm_97aq6seLKBzEFUztSxMj9w> <xmx:iFasZzaWky9kbVwqs84sYlyPximpaD606k6thEZdgWooPM_Kirw3EA> <xmx:iFasZ9pFRDF1gzrt2HzDNYA-1DqO_Bk_mPauLBbnr7wXRODpLxqi1R0W> Feedback-ID: ib2b94485:Fastmail From: Tassilo Horn <tsdh@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable In-Reply-To: <CADwFkmnJmor-UV6FaT+2JHCjxT569arK69NnydBL8p8Aur+oqw@HIDDEN> References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN> <87seojhe6p.fsf@HIDDEN> <CADwFkmnJmor-UV6FaT+2JHCjxT569arK69NnydBL8p8Aur+oqw@HIDDEN> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Wed, 12 Feb 2025 09:06:28 +0100 Message-ID: <871pw31ta3.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72735 Cc: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Stefan Kangas <stefankangas@HIDDEN> writes: >> And adding you company's tracker is quite easy, too. That's what I >> use: > > FWIW, I just throw $DAYJOB related customizations into .dir-locals.el > in my ~/work directory. It seems more natural to me than having it in > my Init file, for example because some of the information in there is > not necessarily public and can't be shared outside of the company. Yup, that's obviously fine, too. I have it differently mostly because I have no strict ~/work vs. ~/fun separation between projects, so there's no single root directory for the work stuff. Bye, Tassilo
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 12 Feb 2025 07:06:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 02:06:14 2025 Received: from localhost ([127.0.0.1]:60607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ti6p3-0005a9-TM for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 02:06:14 -0500 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:43424) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1ti6p1-0005Zo-H2 for 72735 <at> debbugs.gnu.org; Wed, 12 Feb 2025 02:06:12 -0500 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-ab771575040so97785066b.1 for <72735 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 23:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739343965; x=1739948765; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=QIqqyHvoMDH/k80f91hbjeDkbI6xerQIsqo3Kf+b0u0=; b=J1mGeOw2wgzh9RK8g8gjFGbGOhld9gY2oQkmXdRIoJ7nvEYvz8oK9YynMRjgKpuPh0 gTNZ9DBeB6aQ1tq4O9IDHOsLT4QTMu2Hl3meVfAJKEaxZItA3jtT9/OZ9gKuSXhKAsqB +O0nU46s5LgckhY3xkUvJZEi34MMeatGV8fxfrI/cirkMGJrPVytrCUsHqqPoD2nToLT cuFhbMtvYnckQ7FuOefHMptLESrPLDd3Kfr5RQ79GUMDxYSKLji0qhE+lo1ca/ZfI2st GBMk4e5jmzhbKRORsLJ/yNq82cKHRgnG7HjmDg6mA3T0Mx4znIxU/3LfGmAwQM2uTzP9 CMiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739343965; x=1739948765; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QIqqyHvoMDH/k80f91hbjeDkbI6xerQIsqo3Kf+b0u0=; b=LTEGZ1vKfNJhiuH6fbEZdIi3Z0tIufgmfJCL7YZdUR0vi4988+BF0Qcjq5Rjd4HNtW Z3H19ySUn3KpvqX0oGf1/pT7mOIoC/eVyS2b+RfvdoGDe+9REpHNE+ZQRGlMcoa9xJzE mArlOH/880MNYjItc8X9cQoRR7s8Z8LWx58tZVfzEBah6AcsrlGIvHMJChep0/cWqaG1 atVHlFSXjaWsRMahh3pQ4wqjNnKQQ/FCU1BlKNpvklKWpV4aLto/s86dTyF+hliD5Ury 7dRyMWUOhLRpR5jZb+cTttAk0PMbtRKqkYom/BuFXpsHRZj2paZbOmV7GdFa3dDmLsCL HQ1w== X-Forwarded-Encrypted: i=1; AJvYcCXM4L8KbG7G+j/4uSfjDRFfXOUGCvHpbibtUNqWw7+N/33urGGZTCUOKvzedTO4FFH+yP/J/A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwQb4oXnw2mWjUtrHOe+risUAlBw3AvZEHDtq647Bx6+XiyliU9 t9E98jYvnIQu65/ZR1YEPdo/QsCdeo/Xi5W5U3ui/PtHesjPxj2bkLdElkQKwyisbObmDAk4Cct BbbjbDOGnxRoSXSqIvDJAwbxpi6U= X-Gm-Gg: ASbGncsP16boPtweSnh6KwwC/v23quGyER6SRZd7XadC29JghyKQwGKiJoHgP6Nhbyi cjXiRpd9ijKgcBnnLQSvi37BNKFj6dZJW/KXNq3EHIYVbT8pW4Acys8a9tTIKZ09zKYZ/8iWjgg == X-Google-Smtp-Source: AGHT+IHQuQCpr2ZHq9RyFOHfEOk/05b2dcBm1lBY/ODVC9ft1gGvrleRrHQHK/vVIvB8TNwxgnIOpCCvByN17CAmqAI= X-Received: by 2002:a17:907:388b:b0:ab7:9101:e480 with SMTP id a640c23a62f3a-ab7dafef650mr629793566b.11.1739343964882; Tue, 11 Feb 2025 23:06:04 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 23:06:04 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87seojhe6p.fsf@HIDDEN> References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN> <87seojhe6p.fsf@HIDDEN> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 23:06:04 -0800 X-Gm-Features: AWEUYZnfgoocR78J_w94SBkcgbbE-2xh940rsDKeWbKHoMUI2C5xSiwhOF_U8sg Message-ID: <CADwFkmnJmor-UV6FaT+2JHCjxT569arK69NnydBL8p8Aur+oqw@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable To: Tassilo Horn <tsdh@HIDDEN>, =?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72735 Cc: Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Tassilo Horn <tsdh@HIDDEN> writes: > And adding you company's tracker is quite easy, too. That's what I use: FWIW, I just throw $DAYJOB related customizations into .dir-locals.el in my ~/work directory. It seems more natural to me than having it in my Init file, for example because some of the information in there is not necessarily public and can't be shared outside of the company.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.
Received: (at 72735) by debbugs.gnu.org; 12 Feb 2025 06:26:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 01:26:08 2025
Received: from localhost ([127.0.0.1]:60513 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ti6CG-0003ae-56
for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 01:26:08 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:44212)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <tsdh@HIDDEN>) id 1ti6CA-0003a4-Fp
for 72735 <at> debbugs.gnu.org; Wed, 12 Feb 2025 01:26:06 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <tsdh@HIDDEN>)
id 1ti6C4-0005Pc-Hb; Wed, 12 Feb 2025 01:25:56 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
From; bh=RTBS1xhhD81e3pj6b1mEfEZBsaBoEn9dg2df6IOk67Y=; b=VQM5E7PHvz41VqQ+sQRd
qr4N9g9xg236f7maPU6cpShVDByFHK/rZC5yXV0zf9/sVr66m3Oy9momANn3ShQRlzrIvFfnbLV5r
KkvYDzNGykCrcwl5d+9ddRkmaKWOA/PDEDwfR5IvU3Kz7apQJvvf2pOEJE3ZznPIP1XlIAlmiQUTG
zTWCnn/tx1VEFqc6QqUEFozBc0RTkXHdkjBQa2UrzZJlVC3tyrChLzdSXH+p/pbxKrrtW2ftsv37X
+ZiEVA1LTUZmrstUF4V929Obu0mogC9ZaGytZOUKoEEMBOM3+r64aebIA5ehu5ULHSzZmOPCjE7Ei
TthminQK3gELSQ==;
X-ME-Sender: <xms:8j6sZ0160h6T3pjk8ILsLGfX5bzCsH8I8hRVsBq1wZIyvQ79ISqrEw>
<xme:8j6sZ_FccQbiuGLORuReWLAhRZ0csAnFOPluKxLAPa6kYR_YhbyZDvvgN4qq8K1RF
FZqJ1rUQpPlMA>
X-ME-Received: <xmr:8j6sZ85wUTs0EdB4zLYMTTs2jn6P_n0uuv0BE7rkaHXpwF6kujPYcVLsVVkQgSEpOrxvc_YuZO6C1jIkJjn7lObvw_Rm8Kt7>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegfeduhecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp
uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg
hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttder
jeenucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqe
enucggtffrrghtthgvrhhnpeelvddtkeefvdefvdefleehieevueekhedttedugfegiedv
keevleehuedvkefftdenucffohhmrghinhepuggvsghirghnrdhorhhgpdhshhgurdhlrg
hnnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhh
ohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqd
eifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmhdpnhgs
pghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjedvjeefhe
esuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhr
ghdprhgtphhtthhopegsjhhorhhnrdgsihgurghrsehthhgrohgurghnrdguvg
X-ME-Proxy: <xmx:8j6sZ92H0VOOwBA3HJbcXj3J7nX0iyWUDfRdnzegaQaXXbyqrrjKIg>
<xmx:8j6sZ3ErRxKciklyK-U6SZTDQZHDahfa0at_4eBrsXUb4y4AeA3cTA>
<xmx:8j6sZ2-hZ0TYyx9D-OezXCTYTr8Dk1YH1EnJivvysqH77ETHEbUFDw>
<xmx:8j6sZ8kHG8K6UOFM_bhixxN3eI8QZIvGW3mqyUM370Hkns4L4dHDVA>
<xmx:8j6sZ3GzfXJvDwEEgDhrKRjG-Gaaez_H6bvot7pGkjWTPwBKZFxZfUm4>
Feedback-ID: ib2b94485:Fastmail
From: Tassilo Horn <tsdh@HIDDEN>
To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables
customizeable
In-Reply-To: <875xlgi76s.fsf@>
References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 31.0.50
Date: Wed, 12 Feb 2025 07:25:50 +0100
Message-ID: <87seojhe6p.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72735
Cc: Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN> writes:
Hi Bj=C3=B6rn,
>> As Eli already mentioned, bug-reference-url-format is usually set via
>> a file local variables section or programatically so neither a
>> defcustom nor a default value makes sense.
>>
>> Wrt. bug-reference-setup-from-mail-alist,
>> bug-reference-setup-from-irc-alist, and
>> bug-reference-setup-from-vc-alist: yes, they could be defcustoms but
>> their entries can all (and are likely to) contain functions which are
>> hard to specify in the defcustom interface. I've thought it wouldn't
>> be needed. After all, bug-reference is a programmer's tool.
>
> Isn't that a weak argument against changing those to a defcustom?
Maybe. I have no problem with those three being defcustoms.
> With the current default values if not modified it is much harder to
> use them for anything else but the GNU debbugs instance.
No, bug-reference should work out-of-the-box for every project checked
out of the forges in bug-reference-forge-alist. Well, unless you've set
bug-reference-url-format globally which would turn off the auto-setup.
> Correct me if I'm wrong but all those variables only regular
> expressions and a format string which is something that already has
> been done using defcustom e.g. as in Gnus.
In all three, BUG-REGEXP and URL-FORMAT can be functions as documented
by bug-reference-bug-regexp and bug-reference-url-format. Oh, and with
bug-reference-setup-from-vc-alist there's only a URL-FORMAT-FN which
must be a function.
> Isn't it the policy that for settings variables there should be
> defcustom variables? E.g. as mentioned in (info "(elisp) Documentation
> Tips"):
>
>> =E2=80=A2 When you define a variable that represents an option users =
might
>> want to set, use =E2=80=98defcustom=E2=80=99. *Note Defining Vari=
ables::.
>
> Or is the purpose of bug-reference mode GNU specific and not intended
> to be used for anything but GNU?
As said, it works out-of-the-box for Github, several Gitlab instances,
codeberg, framagit, salsa.debian.org, and sr.ht.
And adding you company's tracker is quite easy, too. That's what I use:
--8<---------------cut here---------------start------------->8---
(let ((shd-jira-regexp (concat "\\b\\(\\("
(regexp-opt '("ARCA" "BRI" "ECOJ" "KASE" "MO=
BA"
"PORC" "LOWE" "SABA"))
"-[0-9]\\{1,6\\}\\)\\)\\b")))
(add-to-list 'bug-reference-setup-from-vc-alist
`("srv-upsource\\.shd\\.lan"
,shd-jira-regexp
,(lambda (_)
:dont-hl-value-as-docstring
"http://srvjira-and.shd.lan/browse/%s")))
(add-to-list 'bug-reference-setup-from-mail-alist
`("SHD" nil ,shd-jira-regexp
"http://srvjira-and.shd.lan/browse/%s"))
--8<---------------cut here---------------end--------------->8---
>> Wrt. bug-reference-forge-alist: if it became a defcustom and a user
>> would set it, she wouldn't see updates (like support for some new
>> forge) in its default value anymore because their old saved custom
>> value overrides the new default value. It's much better to add new
>> entries programatically using add-to-list or push/cl-pushnew. Of
>> course, one could split the variable in some *-default-alist defvar
>> and a defcustom *-alist where the latter is meant for user
>> customization but I think it's not worth the added complexity here.
>
> Didn't have time to work on this. Besides that the general downside
> with custom is that if the user modifies it they do not get the
> updates to the default value a separate variable similar to
> browse-url-handler and browse-url-defautl-handlers would be an option.
That's what I've said, yes. And I recall some recent discussion where
it was argued that the browse-url-(default-)handlers split (one for
users, one for emacs/packages) was adding too much complexity.
Bye,
Tassilo
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 11 Feb 2025 19:59:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 14:59:35 2025 Received: from localhost ([127.0.0.1]:58892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thwPv-00039p-2y for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:59:35 -0500 Received: from thaodan.de ([185.216.177.71]:55298) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1thwPr-00039W-Ow for 72735 <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:59:32 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 17DE6D00045; Tue, 11 Feb 2025 21:59:24 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1739303964; bh=skV/4eJ5QLNHl8/Z0FkLP216eLZODZOu0tT8dvlBNZc=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ckVRsJ3CJg5qtmM5oxi25TFdhcPgFByA3mE1JIVZnojA6fwpNpH27CjaiJ0SoZdng BVUGghAXed4yKioNDDLd73Fssg6vNA83hJ99j59Q6xbVE5pHIKx9b1tfgogKmybg9f fxbRagyaB/gL7Mysi5xct3gdjEVFL6ANB1W09mq5QQLiROuYiZQN+Noumctt4Sh6zJ 3YfMjqjmMDG3Q1nxzP/Fpe6v7WzWOJL0cgBrFgd/uS8eSbhtYiyqxgCzYcDEOFXMNF eO+7ugbAdQpTOfbHQ03tHwPj8FvQMbpngrh76WDsa5MKn1vMOhrRSjJ05+NTKihqdy 4om+FHqhGHVtBk3u698AQsg8u9Wn6mWIJFns1r1FbnASe9pZQ3kqas+iUCBHfFXQcd m893Uw+9ydwzAZ4wVbuo9W38gCf4vGcioXwR06Bn0LhP14KnYmdWF1vsY32m2huh5g u/YE7CCyjKfld7H1FWgxEBMCbBZoTLNPfZasQBe+qv+s+2EO7Tl4dLQ4zF0zwH4pXF CefB2QTKrKOU8JuOaDSZAYYllyhSN3uGPor8lwI/vghYIs+M2vJzROeFFxYXS2BbUw Za6MrbSSsay6oupMuq3RGh5DZfGqfd26VgyPslEYYR8nDIaTd+9++qzTcwjDc/dHDQ tNxRe0Jo+H5M0Z7wSrahj6Cs= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: Tassilo Horn <tsdh@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable In-Reply-To: <87seuyh2p0.fsf@HIDDEN> (Tassilo Horn's message of "Wed, 21 Aug 2024 07:20:27 +0200") References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN> Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Tue, 11 Feb 2025 21:59:23 +0200 Message-ID: <875xlgi76s.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tassilo Horn <tsdh@HIDDEN> writes: > Eli Zaretskii <eliz@HIDDEN> writes: > > Hi all, > >>> I noticed that there are other variable such as >>> bug-reference-setup-from-mail-alist that should be change similarly. >> >> Which ones, spec [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 72735 Cc: Eli Zaretskii <eliz@HIDDEN>, 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) Tassilo Horn <tsdh@HIDDEN> writes: > Eli Zaretskii <eliz@HIDDEN> writes: > > Hi all, > >>> I noticed that there are other variable such as >>> bug-reference-setup-from-mail-alist that should be change similarly. >> >> Which ones, specifically? >> >> And let's get Tassilo (CC'ed) on board of this discussion. > > As Eli already mentioned, bug-reference-url-format is usually set via a > file local variables section or programatically so neither a defcustom > nor a default value makes sense. > > Wrt. bug-reference-setup-from-mail-alist, > bug-reference-setup-from-irc-alist, and > bug-reference-setup-from-vc-alist: yes, they could be defcustoms but > their entries can all (and are likely to) contain functions which are > hard to specify in the defcustom interface. I've thought it wouldn't be > needed. After all, bug-reference is a programmer's tool. Isn't that a weak argument against changing those to a defcustom? One could argue that Emacs itself is a programmers tool and yet with a have defcustom to make it easier to customize Emacs and avoid errors. With the current default values if not modified it is much harder to use them for anything else but the GNU debbugs instance. Correct me if I'm wrong but all those variables only regular expressions and a format string which is something that already has been done using defcustom e.g. as in Gnus. Isn't it the policy that for settings variables there should be defcustom variables? E.g. as mentioned in (info "(elisp) Documentation Tips"): > =E2=80=A2 When you define a variable that represents an option users m= ight > want to set, use =E2=80=98defcustom=E2=80=99. *Note Defining Varia= bles::. Or is the purpose of bug-reference mode GNU specific and not intended to be used for anything but GNU? > Wrt. bug-reference-forge-alist: if it became a defcustom and a user > would set it, she wouldn't see updates (like support for some new forge) > in its default value anymore because their old saved custom value > overrides the new default value. It's much better to add new entries > programatically using add-to-list or push/cl-pushnew. Of course, one > could split the variable in some *-default-alist defvar and a defcustom > *-alist where the latter is meant for user customization but I think > it's not worth the added complexity here. Didn't have time to work on this. Besides that the general downside with custom is that if the user modifies it they do not get the updates to the default value a separate variable similar to browse-url-handler and browse-url-defautl-handlers would be an option.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.
Received: (at 72735-done) by debbugs.gnu.org; 11 Feb 2025 19:49:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 14:49:46 2025
Received: from localhost ([127.0.0.1]:58847 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thwGP-0002en-9d
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:49:45 -0500
Received: from thaodan.de ([2a03:4000:4f:f15::1]:46334)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>)
id 1thwGN-0002eH-85
for 72735-done <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:49:43 -0500
Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49])
by thaodan.de (Postfix) with ESMTPSA id D1E22D00045;
Tue, 11 Feb 2025 21:49:34 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1739303375; bh=QvKCbouXjr1Pe+/P4A8oXDZGAK1mcM6uePIHzeFCMpA=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=IsJu0d7jLgLFvRiyUf4pt2ajm93U/Tzjw64gLzK3hOz1ea+iKLhXG5MpZY0GSKacY
MW5rtGvAanjeOqJYsVSWQ1gOas0a1GvCrFeWDnfspGJnzKauEwlyYVmCinpqhL4xI1
ge5mbWKkdyXY+aPY/7x7Lx62v0UdHvsqDeWO5WJ9ymR8r+2cwIlDdEfWaMryDqNh+c
tjbn6zuzB1pmS6VTyoxKTvIohtMvbRoASP5jVVUjmbOt7bOc93vyI/F6x7jfhuRXBY
W5RlTdtz+gO0TAYvUvXM2zn4kmQSo/tU309UOuqbRNGh5lwOkVSXiIZhYjybz/NyJM
3MryRygF34lu9cr3NG8F4zt64lI4agQwfkogM2JrRTCJ/YN24lbfzgJ7n2axKikebY
qzwlJ8Yp/+NSPCGTSpsUNlIVAsq7P+ugEXOmtHluhlXeQ1kghjvednHP/tx4JBCLCP
y7hqTn4rR7a6VbDPlkEpyF9sCHyivyvPfWBB1iTdHLURwH/xCOnkiahI4DTcJNZq8k
aGiK6z5vahlIHy+E0ulExJq7hwgHaOHq7q/myZmegpboir8Gs3FDI5GeQqern4qGpe
r5N2C8Lp56vgubSHuvMzKfsSkS5t/gPoKDsnBS/HPA6oxb4ALMW7a6BVmi7vdxX82d
NapqgVmN5IkLZZyxncSr4zy8=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables
customizeable
In-Reply-To: <CADwFkm=KMQNn1y08KoidWmvJnnGicEiL4ZHt4LezzPAdsNwZ3g@HIDDEN>
(Stefan Kangas's message of "Mon, 10 Feb 2025 23:29:47 -0800")
References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN>
<867ccaugq6.fsf@HIDDEN>
<CADwFkm=KMQNn1y08KoidWmvJnnGicEiL4ZHt4LezzPAdsNwZ3g@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Tue, 11 Feb 2025 21:49:34 +0200
Message-ID: <87a5asi7n5.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Stefan Kangas <stefankangas@HIDDEN> writes: > Eli Zaretskii
<eliz@HIDDEN> writes: > >>> From: Tassilo Horn <tsdh@HIDDEN> >>> Cc: Björn
Bidar <bjorn.bidar@HIDDEN>, >>> 72735 <at> debbugs.gnu.org >>> Date: Wed,
21 Aug 2024 07:20:27 +0200 >>> >> [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 72735-done
Cc: Eli Zaretskii <eliz@HIDDEN>, 72735-done <at> debbugs.gnu.org,
Tassilo Horn <tsdh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Stefan Kangas <stefankangas@HIDDEN> writes:
> Eli Zaretskii <eliz@HIDDEN> writes:
>
>>> From: Tassilo Horn <tsdh@HIDDEN>
>>> Cc: Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN>,
>>> 72735 <at> debbugs.gnu.org
>>> Date: Wed, 21 Aug 2024 07:20:27 +0200
>>>
>>> As Eli already mentioned, bug-reference-url-format is usually set via a
>>> file local variables section or programatically so neither a defcustom
>>> nor a default value makes sense.
>>>
>>> Wrt. bug-reference-setup-from-mail-alist,
>>> bug-reference-setup-from-irc-alist, and
>>> bug-reference-setup-from-vc-alist: yes, they could be defcustoms but
>>> their entries can all (and are likely to) contain functions which are
>>> hard to specify in the defcustom interface. I've thought it wouldn't be
>>> needed. After all, bug-reference is a programmer's tool.
>>> Wrt. bug-reference-forge-alist: if it became a defcustom and a user
>>> would set it, she wouldn't see updates (like support for some new forge)
>>> in its default value anymore because their old saved custom value
>>> overrides the new default value. It's much better to add new entries
>>> programatically using add-to-list or push/cl-pushnew. Of course, one
>>> could split the variable in some *-default-alist defvar and a defcustom
>>> *-alist where the latter is meant for user customization but I think
>>> it's not worth the added complexity here.
>>>
>>> So I'd rather keep it as-is.
>>
>> Thanks.
>>
>> So, Bj=C3=B6rn, now you get to try to convince Tassilo that making some =
of
>> these variables defcustoms does make sense. IOW, what are the
>> problems in the current situation that prompted you to suggest these
>> changes?
>
> No further comments within 24 weeks, so I'm closing this bug.
Sorry I didn't have time to work on this earlier I will reply to the
rest of comments now.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735-done) by debbugs.gnu.org; 11 Feb 2025 07:29:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 02:29:56 2025 Received: from localhost ([127.0.0.1]:54031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thkiS-0002oj-2K for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 02:29:56 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:56705) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1thkiP-0002oR-Mr for 72735-done <at> debbugs.gnu.org; Tue, 11 Feb 2025 02:29:54 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5de5bf41652so5010619a12.1 for <72735-done <at> debbugs.gnu.org>; Mon, 10 Feb 2025 23:29:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739258988; x=1739863788; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=q+4Gu7dRULOres/+1YuZ9/nnwmyima1h/Rt6m6FeqMw=; b=iaQq96zwayWI4dJ7gF/mYM6Nabbn37FRnEctK1Kuvv3MYBkkhMKl++IupKKClA8RTF vziLvnPvTIcANHnuSC94eYY4mCHSqhRjWl50UiFfZgAm5FxFlQZia8RGyHlIzx4ugwTI IF6qIkq9hB+8oATaXISFyd7OTX4HVSUefxU/qebgCMx9w/aPL6tHhz7zjYv+wV/gCphO YafAFvgukr3GE4ezkVAiRfQGM9XtO/oS3VT2BsjAc9zcprSZTtVpAJPS2+zybjUSes5q N7Xvq04RQT+RWOvcz8z7pjhvJTLPk8cJWT8LRKjHtjEWA6OaNPwmX6NFVQ6x+/tABW4s vGEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739258988; x=1739863788; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=q+4Gu7dRULOres/+1YuZ9/nnwmyima1h/Rt6m6FeqMw=; b=etkYiDnb7mFphhhwYnelfLCuyCWqoo3LGwyNM3g2PZyvj7I7lx7DaHQxSpZGbkktHj zbgKsS31WPvtCBzYfzQBGL+Hl13CI6O8BoUKQF2Fn2fZv1IrUCBX3Is6KN3ZfcQEpHzi iW4hgsD38PRB0inFN10hzx25mmRSjP56zt+z7vFMUuFuRdPY7dQkFyymr3QSAORbY0DT QLzdYWk0ECNXgPY3Er6tCQqCir7TRulxPIHey3oGC1hpw60rvHkz6djamWameE5Oev6l PKbS+ANR8opHbhOSjRCfADX+J7W1Kx1zy7uYajBsnprv73P7zqwbs7GJOsqQW8fR+qWJ SLaQ== X-Forwarded-Encrypted: i=1; AJvYcCW3RxZ2DL2kGr7aEl8fDvbbmD+R6okt4A6A0bXK43PbZiV16lqycyZDHyM2EY4n5tJJ1TcCzQV8icDb <at> debbugs.gnu.org X-Gm-Message-State: AOJu0Yz4RwF1GAisS5/JOPL4Y4GQfYieFeORuZBhovovJR56cQ4sqij1 9hXvIOI4lWraqeT6nvKs8b85bMWQW1l7MthXznJnAKMQqXpgij1x9xkBzS8UCPNkJB7y40AUwLC yCDG4ycuYT10OncdNVhwhBJQhNM0= X-Gm-Gg: ASbGncttXgQNxspld4BhRLaBiIl9/PbBbbOPIG2fyEqDsvymnPG0jXsm5rUd/otQSv0 74Jy3d/qExOdo6ynzUPOhUIKhrbNHCRrmNv7ZiYucR7hepAe0LyELWCwni0jIhCBl0gA7aP1Xjg == X-Google-Smtp-Source: AGHT+IF14ech1It4x6ORkPXi7y7jcJtUNQnMX+GdUI58azI6JpofvvL0UDyLRFqIR6YDorEzuH/+LqJxreb/H6k4S8I= X-Received: by 2002:a05:6402:2106:b0:5dc:a44d:36bd with SMTP id 4fb4d7f45d1cf-5de4500274cmr14768058a12.8.1739258987622; Mon, 10 Feb 2025 23:29:47 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 10 Feb 2025 23:29:47 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <867ccaugq6.fsf@HIDDEN> References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN> <867ccaugq6.fsf@HIDDEN> MIME-Version: 1.0 Date: Mon, 10 Feb 2025 23:29:47 -0800 X-Gm-Features: AWEUYZmVq0giuQVkzbOK6LqTnjpVNi29R7FyUfnVKadFg1Qz3Qt1zD5k_8EwJCw Message-ID: <CADwFkm=KMQNn1y08KoidWmvJnnGicEiL4ZHt4LezzPAdsNwZ3g@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72735-done Cc: bjorn.bidar@HIDDEN, 72735-done <at> debbugs.gnu.org, Tassilo Horn <tsdh@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> From: Tassilo Horn <tsdh@HIDDEN> >> Cc: Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN>, >> 72735 <at> debbugs.gnu.org >> Date: Wed, 21 Aug 2024 07:20:27 +0200 >> >> As Eli already mentioned, bug-reference-url-format is usually set via a >> file local variables section or programatically so neither a defcustom >> nor a default value makes sense. >> >> Wrt. bug-reference-setup-from-mail-alist, >> bug-reference-setup-from-irc-alist, and >> bug-reference-setup-from-vc-alist: yes, they could be defcustoms but >> their entries can all (and are likely to) contain functions which are >> hard to specify in the defcustom interface. I've thought it wouldn't be >> needed. After all, bug-reference is a programmer's tool. >> >> Wrt. bug-reference-forge-alist: if it became a defcustom and a user >> would set it, she wouldn't see updates (like support for some new forge) >> in its default value anymore because their old saved custom value >> overrides the new default value. It's much better to add new entries >> programatically using add-to-list or push/cl-pushnew. Of course, one >> could split the variable in some *-default-alist defvar and a defcustom >> *-alist where the latter is meant for user customization but I think >> it's not worth the added complexity here. >> >> So I'd rather keep it as-is. > > Thanks. > > So, Bj=C3=B6rn, now you get to try to convince Tassilo that making some o= f > these variables defcustoms does make sense. IOW, what are the > problems in the current situation that prompted you to suggest these > changes? No further comments within 24 weeks, so I'm closing this bug.
Björn Bidar <bjorn.bidar@HIDDEN>:Stefan Kangas <stefankangas@HIDDEN>:Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 72735) by debbugs.gnu.org; 21 Aug 2024 13:52:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 21 09:52:16 2024 Received: from localhost ([127.0.0.1]:35233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sgll1-0003gu-Kz for submit <at> debbugs.gnu.org; Wed, 21 Aug 2024 09:52:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sglkz-0003gb-WF for 72735 <at> debbugs.gnu.org; Wed, 21 Aug 2024 09:52:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sglkB-00056X-VA; Wed, 21 Aug 2024 09:51:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=D76r9fonHcYyHMw4nQAAQaSecpX2fyDijmCTNWHnU9A=; b=N9AzE5at8wSK9oVxF3fG nYSGnW5uyta0LQGCrRo8FWNSQMOwkOHiaROCTrcp1TDBcdrYgh3/so4eVnwxzo0tLpOVns9xuNWMB kPmtCECwIkRqZn1IaFykbFDrK6XP6ZjnVhExwNd2x6X1MFf259RlTCAHhylxdPmt5/6TTMUr6YMdp byR+pG8x1hpzRboaLkApRGA8zYY+jkY+84m81GykZK+OnNqcQCES+geg64+ru6dBrvhov3WjwxzD9 9tqiqhGfGnoDGIEV4leqlNDDOkPg+RsDKhLrMrombzgWyMW/10KrHDmvvHbcterGCKE+59FCRsO/Q Y1mvBXCRbwVmFA==; Date: Wed, 21 Aug 2024 16:51:13 +0300 Message-Id: <867ccaugq6.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Tassilo Horn <tsdh@HIDDEN> In-Reply-To: <87seuyh2p0.fsf@HIDDEN> (message from Tassilo Horn on Wed, 21 Aug 2024 07:20:27 +0200) Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable References: <86plq3uib0.fsf@HIDDEN> <87seuyh2p0.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72735 Cc: bjorn.bidar@HIDDEN, 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Tassilo Horn <tsdh@HIDDEN> > Cc: Björn Bidar <bjorn.bidar@HIDDEN>, > 72735 <at> debbugs.gnu.org > Date: Wed, 21 Aug 2024 07:20:27 +0200 > > As Eli already mentioned, bug-reference-url-format is usually set via a > file local variables section or programatically so neither a defcustom > nor a default value makes sense. > > Wrt. bug-reference-setup-from-mail-alist, > bug-reference-setup-from-irc-alist, and > bug-reference-setup-from-vc-alist: yes, they could be defcustoms but > their entries can all (and are likely to) contain functions which are > hard to specify in the defcustom interface. I've thought it wouldn't be > needed. After all, bug-reference is a programmer's tool. > > Wrt. bug-reference-forge-alist: if it became a defcustom and a user > would set it, she wouldn't see updates (like support for some new forge) > in its default value anymore because their old saved custom value > overrides the new default value. It's much better to add new entries > programatically using add-to-list or push/cl-pushnew. Of course, one > could split the variable in some *-default-alist defvar and a defcustom > *-alist where the latter is meant for user customization but I think > it's not worth the added complexity here. > > So I'd rather keep it as-is. Thanks. So, Björn, now you get to try to convince Tassilo that making some of these variables defcustoms does make sense. IOW, what are the problems in the current situation that prompted you to suggest these changes?
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 21 Aug 2024 13:28:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 21 09:28:17 2024 Received: from localhost ([127.0.0.1]:35193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sglNo-0002sd-Md for submit <at> debbugs.gnu.org; Wed, 21 Aug 2024 09:28:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sglNj-0002sN-9S for 72735 <at> debbugs.gnu.org; Wed, 21 Aug 2024 09:28:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sglMs-000337-P6; Wed, 21 Aug 2024 09:27:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=QCRhMzS71UyGpwqXsA2SZkraF2XddoqCOqgC0Yg5G1w=; b=Tcyb5+2GV9NQRsSjQmpl 9eN0+nZcuy0I8/5MOOX6NHSf2Skxs3rCqjM5atxv3GSR8qtY3TWpJxmXCRxX0pqzewdvZZpi9aLoA ISV4dGW2H8RLoYnXNOgwkdInLQ+/27E/PfGETZgdRj/FCDS91yQHZmqgM9I927dWmXsiEhQHfDVSp HN5rnOiDRSLQjmCuFyWxNTttJcEZM/wIR6Z5mMRBsAl9b4MT+CWd4bvIVEyFWqtRE6iOET2yhgLMX V0x2pKfEeffGLQQVy3+qqymycfh2d/mLKTtpBTHcmp3dROH/+yT8ekyNDV8pPYpI8DfRozANuvBQS luzfOpqO4c+7Xw==; Date: Wed, 21 Aug 2024 16:27:01 +0300 Message-Id: <86frqyuhui.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> In-Reply-To: <875xrvhtll.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Tue, 20 Aug 2024 22:39:18 +0300) Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable References: <86wmkbujh5.fsf@HIDDEN> <875xrvhtll.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72735 Cc: 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Björn Bidar <bjorn.bidar@HIDDEN> > Cc: 72735 <at> debbugs.gnu.org > Date: Tue, 20 Aug 2024 22:39:18 +0300 > > >> +FORGE-TYPE is the type of the forge, e.g., gitlab, gitea, > >> +sourcehut, or github. > > > > This leaves it unsaid how these symbols are used, and what symbols are > > recognized. > > Does the original text not say that already? The choices over all the > existing symbols which are accepted, if it doesn't make sense to > e.g. add a custom symbol to extend the mode than removing the (symbol) > choice is good. It might be enough to say that those symbols are the only predefined ones. The text as it is leaves the impression that they are only examples. Also, something should be said regarding the differences between the symbols: why does the user need to specify these symbols and what could happen if they use a wrong symbol? > > Finally, I think this warrants a NEWS entry. > > Should the news entry explain similarly that the variables can be set > with defcustom and have improved documentation? Just the fact that they are now user options, that's all.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 21 Aug 2024 05:23:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 21 01:23:35 2024 Received: from localhost ([127.0.0.1]:34758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sgdok-0004mn-LC for submit <at> debbugs.gnu.org; Wed, 21 Aug 2024 01:23:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <tsdh@HIDDEN>) id 1sgdoi-0004mU-JE for 72735 <at> debbugs.gnu.org; Wed, 21 Aug 2024 01:23:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <tsdh@HIDDEN>) id 1sgdlo-0004CI-Q8; Wed, 21 Aug 2024 01:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lhoicBoufMRJWmXyH0Wb1L+UiVkCFByMExkLsuXbqcQ=; b=criGaUF7hTjJ4Yclb0RY q0IBz6TijgGfz/hkjOOsxs71pltJ7g1NMjyAWQW+9u1hTrYrkH7l45eRCp6/EE/gOiJlbFUFbNCDD Fv2xSmi2xmtlMTqgEARHfLVf5/NJJ8k7c0LChFeqJtFtXheL2gQQRsQBpxlVAecBCrxHHTiiQLFNP l10fU3RP6Y665f9D+J1ImzjPokK/K2A3RFU8uItRXbzSNS2bxPOhBJ+CqLuv/nAR093QeYo1i3eON UL7F0mTEk12Y8TB+uW6wZspLn95H/jET2O0s0zZHAxVOmZlWLb65y8yzpgkEu3+YObKIU+ZEPBhQO voYqRk2a0ERr8g==; X-ME-Sender: <xms:H3nFZnrOsYlJ5UTsy7xA_Q2M5EILNCL4Hiy1jDozlgGALsQ4bBO5OA> <xme:H3nFZhqipMyaXhI1o_8zIX8Y0DXiYMMtqIi2V9XMmtgjcaBG1l9M6delcNXIrwAK- 8RpDSMPaySImw> X-ME-Received: <xmr:H3nFZkO5FP-HvyyVpb__-82ILRFKxr-YYGkFwAUy3wNIWEXYpxaCqRkkqWMCFEo0609_3Xnv8y515bWrRGkXztu6amlEmqPv> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddujedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgesthdtredttdertden ucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenuc ggtffrrghtthgvrhhnpedthedvfffhkedtleejvdelgefgieefgeekudeffeeitdffteeg vdetvefgjeehudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieej feekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilh drfhhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthho peejvdejfeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepsghjohhrnh drsghiuggrrhesthhhrghouggrnhdruggvpdhrtghpthhtohepvghlihiisehgnhhurdho rhhg X-ME-Proxy: <xmx:H3nFZq5_7GKFOVOMTGBmDyug3GRbzGO3s07nv_q6t8Oc2gGX6KTsOg> <xmx:H3nFZm51FG7PXzzGB3T8SEbkvsmSJpon4k-T7qyA5heDRUIRgx3R7Q> <xmx:H3nFZihwhWZrArJvUgal7ODA1wisMvH5Z2HUrZcaD4_yWbpgAirU3A> <xmx:H3nFZo5CEhH7ad_wJsa2BWFsHss883xhb8Nqvm5xGqmc9rXdk_Fgfg> <xmx:H3nFZlK3KjRq8rCU250wYj4uAYM_WP1g_Zqs-GONg4JM7NIPKTc31c22> Feedback-ID: ib2b94485:Fastmail From: Tassilo Horn <tsdh@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable In-Reply-To: <86plq3uib0.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 20 Aug 2024 22:04:51 +0300") References: <86plq3uib0.fsf@HIDDEN> Date: Wed, 21 Aug 2024 07:20:27 +0200 Message-ID: <87seuyh2p0.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72735 Cc: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>, 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Eli Zaretskii <eliz@HIDDEN> writes: Hi all, >> I noticed that there are other variable such as >> bug-reference-setup-from-mail-alist that should be change similarly. > > Which ones, specifically? > > And let's get Tassilo (CC'ed) on board of this discussion. As Eli already mentioned, bug-reference-url-format is usually set via a file local variables section or programatically so neither a defcustom nor a default value makes sense. Wrt. bug-reference-setup-from-mail-alist, bug-reference-setup-from-irc-alist, and bug-reference-setup-from-vc-alist: yes, they could be defcustoms but their entries can all (and are likely to) contain functions which are hard to specify in the defcustom interface. I've thought it wouldn't be needed. After all, bug-reference is a programmer's tool. Wrt. bug-reference-forge-alist: if it became a defcustom and a user would set it, she wouldn't see updates (like support for some new forge) in its default value anymore because their old saved custom value overrides the new default value. It's much better to add new entries programatically using add-to-list or push/cl-pushnew. Of course, one could split the variable in some *-default-alist defvar and a defcustom *-alist where the latter is meant for user customization but I think it's not worth the added complexity here. So I'd rather keep it as-is. Bye, Tassilo
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 20 Aug 2024 19:50:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 15:50:46 2024 Received: from localhost ([127.0.0.1]:33701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sgUsQ-0004Rc-99 for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 15:50:46 -0400 Received: from thaodan.de ([185.216.177.71]:41418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1sgUsN-0004RH-4m for 72735 <at> debbugs.gnu.org; Tue, 20 Aug 2024 15:50:45 -0400 Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154]) by thaodan.de (Postfix) with ESMTPSA id BACF0D00076; Tue, 20 Aug 2024 22:49:53 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1724183393; bh=JIEIpM8f3cgt9qTGCzf3tc4rl07ZGRO/+oqjjd1cc0Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=HyC/z8YudYghkmp9FZskdEM9mqywwJnulzIQyOQEf9GdlR+jJpAr/RFPXQHqiLEJL vyqXaxrZMUk7xdYeW+XRo5fFccE+6KQHhaX2thwyrwjav/siozbe4U2FUj1l9Ryffz 3AjXAXRYBYdOHSF5D1xF4PUxX0pIdmuHl13duJW2dDtT51c6n4bknnxPvKoQUuZT/+ 1MsDAZ1BBbvxje7PKyLRqzC9XOODU6Zp4+lvsT0UlrDEqOVQ9AzDOS2Q/qI4Fp0ZJ8 7e/jGC4/tE+zjTQO1kLloQX0g4Gg7jJsCBjtZv6K0NO9xXwpLy9JDqeufUrC+g2mL8 UXPJBBcEi4kh5PVLlnp2mboiAIuef4TsxO7LN5Ov5or/9vlIVweYGm9P21563bQBcy z4XsR/VR/pyoei1y6RskQFw07gf7baJQHr71AwkIiMiN34G5F5bOKOQUBrmZf2tC6o Tm/LKSNr8DPZv5ZGoPk24QmUkqxMSStIrkWCCfe0ADXvCxjBobTF6nrU9CTmBcpzDr EZpvrVCP+X/xXCpP89vxa0DamUNkGVkJJJUFLWieEVNcZ3pHjPcnl5ii8+do8OLovL /0HggCkyH9/dL/0YPQ2h2cmz00mwcsfGaNCXkEfTxE0NhGPP+poDS3h2DV9/W0Rli+ frLHUJwF/InVa8lgrLUspt90= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable In-Reply-To: <86plq3uib0.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 20 Aug 2024 22:04:51 +0300") References: <86plq3uib0.fsf@HIDDEN> Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Tue, 20 Aug 2024 22:49:53 +0300 Message-ID: <87wmkbgeji.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Tue, 20 Aug 2024 20:40:38 +0300 >> From: Björn Bidar via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> >> I noticed that there are other [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 72735 Cc: 72735 <at> debbugs.gnu.org, Tassilo Horn <tsdh@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Tue, 20 Aug 2024 20:40:38 +0300 >> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >>=20 >>=20 >> I noticed that there are other variable such as >> bug-reference-setup-from-mail-alist that should be change similarly. > > Which ones, specifically? Besides the one mentioned above bug-reference-setup-from-irc-alist and bug-= reference-auto-setup-functions.=20 The latter to e.g. the user providing their own functions. > And let's get Tassilo (CC'ed) on board of this discussion. > >> Would it make sense to group the changes to convert them to defcustom in >> one patch or is one patch per variable better? > > I prefer a single patch, thanks. Ok great.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.
Received: (at 72735) by debbugs.gnu.org; 20 Aug 2024 19:40:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 15:40:12 2024
Received: from localhost ([127.0.0.1]:33689 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sgUiB-0004Ad-IG
for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 15:40:11 -0400
Received: from thaodan.de ([185.216.177.71]:56814)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjorn.bidar@HIDDEN>) id 1sgUi9-0004AA-At
for 72735 <at> debbugs.gnu.org; Tue, 20 Aug 2024 15:40:09 -0400
Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154])
by thaodan.de (Postfix) with ESMTPSA id 80A39D00076;
Tue, 20 Aug 2024 22:39:19 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1724182759; bh=M53lq8Qw/dfW+miRLSlDVk7yClFDWDz62s09paQKs6U=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=YK7xf+zib0mXkDTnu3FpnckHqVml0cMxMOTJbxUw1XiTtZuFE7fWDAnM9oywDi/Gl
P0eFOL1MJWNLZie65QSnpr+DwqTxS0laDaR9hEOZyZBL8yXqOi5sDLMKAUfcuwCoyD
QtWHg8Y9At1Qcln84GpuoiRjO5kB+9ua3/+NVgDXPC13WVbo8fh2r//OEh7hHDDGhV
TmRpswrCd7iz9Xe/eSMBt9zhvmwDUVqtiF3AagNc0pWwMhSIXjxMBh2IMFm6wR4N1h
iaxS7h4axcjq9xIZkqLsbq3GeId7uLOs9NYpUx9Y1fKCSX5MuY7Mm33XvYs1lyZYCl
SJIv4eUfaLTaBENlLGCSlfDN8eaEDadNtlWDiapWVoRv9dVgo01y/pKod0mnQJHkW1
C2azGLh1R88Fk4Asff6tXG7wm9mSmJg1ydm1uHN1Do5ZTOQFOpSrHJY8gEFFWt8tDu
XoW9RhtnAN2KqwfIqoTNk+FTOlNDuYUO1M32rvQltNSx34uZGJox9OhYuadJyEiO0D
hTNQJoT9AvVklw6GE6lH2b62wsJHHkw8qNedpAjeZ7jx3bs04oIs2Yq96TcDQ9dPrk
W9W28ioG0YJKzLLkUYqc41PFia/788qL/9W/ZR/wDyZHNjGkyxypZlLV9nWV2R2J2s
S+UGN1t6xeQGIA43041ALYC4=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables
customizeable
In-Reply-To: <86wmkbujh5.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 20 Aug
2024 21:39:34 +0300")
References: <86wmkbujh5.fsf@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Tue, 20 Aug 2024 22:39:18 +0300
Message-ID: <875xrvhtll.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Tue, 20 Aug
2024 18:34:38 +0300 >> From: Björn Bidar via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> I noticed
that some of the variabl [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 72735
Cc: 72735 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> Date: Tue, 20 Aug 2024 18:34:38 +0300
>> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>=20
>> I noticed that some of the variables that can be modified
>> by the user or as mentioned as such were not defined as custom variable.
>> These patches to so and correct the group of one of the existing
>> defcustom.
>>=20
>> The patches don't change any of the existing functionality
>> but only document these variables better and make them easier to modify.
>> Because of that I set version to Emacs 30.1. Please tell if that's ok.
>
> The emacs-30 release branch is closed to enhancements, it only
> receives bugfix changes and improvements in documentation. Converting
> a defvar to a defcustom is not just a documentation change, it
> radically changes how the variable is initialized and set. So this is
> not appropriate for the release branch.
OK I wasn't aware that there's such a difference for existing user that
don't use defcustom.
> Please see several comments below.
>
>> * lisp/progmodes/bug-reference.el (bug-reference-url-format): Define as
>> custom type. The manual and the documentation string talk like the
> ^^
>> variable like is a custom variable. It does make sense to define
> ^^
> Our convention is to leave two spaces between sentences in comments,
> strings, and commit log messages. There are several places in the
> patch where you left only one space.
Will fix, in prior changes to the file there were changes with only one spa=
ce.
>> -(defvar bug-reference-url-format nil
>> +(defcustom bug-reference-url-format nil
>> "Format used to turn a bug number into a URL.
>
> I wonder how this makes sense as a defcustom, since this variable must
> be file-local, AFAIU. In any case, the doc string should explain the
> semantics of the nil value.
The doc string says it must be local however I see no reason to not be
able to have a global function that returns a default if no setting is
found for the file. E.g. it's common to have something like
keyword#bugnumber where each keyword would refer to a different
bugtracker.=20
>> + :group 'bug-reference)
>
> This is redundant (here and elsewhere in the patches), since the
> package name will supply the group.
ok,.
>> +FORGE-TYPE is the type of the forge, e.g., gitlab, gitea,
>> +sourcehut, or github.
>
> This leaves it unsaid how these symbols are used, and what symbols are
> recognized.
Does the original text not say that already? The choices over all the
existing symbols which are accepted, if it doesn't make sense to
e.g. add a custom symbol to extend the mode than removing the (symbol)
choice is good.
> Finally, I think this warrants a NEWS entry.
Should the news entry explain similarly that the variables can be set
with defcustom and have improved documentation?
> Thanks.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 20 Aug 2024 19:05:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 15:05:47 2024 Received: from localhost ([127.0.0.1]:33663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sgUAt-0003FT-2e for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 15:05:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sgUAr-0003FD-D6 for 72735 <at> debbugs.gnu.org; Tue, 20 Aug 2024 15:05:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sgUA4-0006JW-D1; Tue, 20 Aug 2024 15:04:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DLFWoNWlHOLDHxasXIlV5QP0a0fUbevaR/GB3cKbfLw=; b=W+JG7gWxICVSgkDto0IW rA3PWnRSJv8JN5ZJG3c8r752oVFmqV2TZQnWUNQWw+3Oi5yCdd9z2QTKLkDWfumJAyLciZaGI34Hv aB6eRwkGizOtosQ7s9dVIkqAUiHKO3PlTSQa+dM3A+6Hq7Up8v+rEffhPf7gKqSVTNJIv0vZ6brp1 EDZMDBvH1zhZZepowN6n/6XB3wsZFKx1l/k+1yU/OGZS2sFQS0KUTHv8rp7YN4ZI3lULezOPTlat8 elNUVmfeAzylLg2NeUqrSYOARGlxuuaMPkBSuFK5Ncz9gfv2v8WfmnEUjpa19W7bIxKbWnQ6uAJrJ YbxPKXtM4tsedA==; Date: Tue, 20 Aug 2024 22:04:51 +0300 Message-Id: <86plq3uib0.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?iso-8859-1?Q?Bj=F6rn?= Bidar <bjorn.bidar@HIDDEN>, Tassilo Horn <tsdh@HIDDEN> In-Reply-To: <87a5h7hz3d.fsf@> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable References: <87a5h7hz3d.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72735 Cc: 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 20 Aug 2024 20:40:38 +0300 > From: Björn Bidar via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > I noticed that there are other variable such as > bug-reference-setup-from-mail-alist that should be change similarly. Which ones, specifically? And let's get Tassilo (CC'ed) on board of this discussion. > Would it make sense to group the changes to convert them to defcustom in > one patch or is one patch per variable better? I prefer a single patch, thanks.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.
Received: (at 72735) by debbugs.gnu.org; 20 Aug 2024 18:40:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 14:40:29 2024
Received: from localhost ([127.0.0.1]:33644 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sgTmP-0002aA-Ek
for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 14:40:29 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45660)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1sgTmM-0002Zu-VV
for 72735 <at> debbugs.gnu.org; Tue, 20 Aug 2024 14:40:28 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1sgTlZ-00035g-W3; Tue, 20 Aug 2024 14:39:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=9yUOgLmjjgCQYDtIaU+/jOMrM5D+/+uacUwdEvbWoMk=; b=dvihM2Upvo1Hn3UAOSSV
RnMxTf5SJ/f6FIgM7DOtiOHHvCsFoKhpK2lJy/iKMCm2JESzH29FnePelE7g6NRjGJIxh11uv9J1L
8kCNaL5v1Bl8KAaH5/Kj45yHW8HFEmwf3Ly4ahnVYIRMEi/2Rw0ymZXUE0gvgazDMeySFvCSY5wjw
B/C7M5W8gqReyYU1eJGBYv/bjdkFnIZiVJpTgJe2QSzbmjKzbILpSJ6rKZVtl5WLLeU1uKSuI985e
MCu4lbgLtBMufTi427nVhi1aA4jbY90OmcnBUu9tF56rOE95Vod42WPgTVfHLhtTkrQJIBMNPoG3L
T2ptSSpK3NhczA==;
Date: Tue, 20 Aug 2024 21:39:34 +0300
Message-Id: <86wmkbujh5.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
In-Reply-To: <874j7fnr75.fsf@> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#72735: 31.0.50;
[PATCH] Make more bug-reference variables customizeable
References: <874j7fnr75.fsf@>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 72735
Cc: 72735 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Tue, 20 Aug 2024 18:34:38 +0300
> From: Björn Bidar via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> I noticed that some of the variables that can be modified
> by the user or as mentioned as such were not defined as custom variable.
> These patches to so and correct the group of one of the existing
> defcustom.
>
> The patches don't change any of the existing functionality
> but only document these variables better and make them easier to modify.
> Because of that I set version to Emacs 30.1. Please tell if that's ok.
The emacs-30 release branch is closed to enhancements, it only
receives bugfix changes and improvements in documentation. Converting
a defvar to a defcustom is not just a documentation change, it
radically changes how the variable is initialized and set. So this is
not appropriate for the release branch.
Please see several comments below.
> * lisp/progmodes/bug-reference.el (bug-reference-url-format): Define as
> custom type. The manual and the documentation string talk like the
^^
> variable like is a custom variable. It does make sense to define
^^
Our convention is to leave two spaces between sentences in comments,
strings, and commit log messages. There are several places in the
patch where you left only one space.
> -(defvar bug-reference-url-format nil
> +(defcustom bug-reference-url-format nil
> "Format used to turn a bug number into a URL.
I wonder how this makes sense as a defcustom, since this variable must
be file-local, AFAIU. In any case, the doc string should explain the
semantics of the nil value.
> + :group 'bug-reference)
This is redundant (here and elsewhere in the patches), since the
package name will supply the group.
> +FORGE-TYPE is the type of the forge, e.g., gitlab, gitea,
> +sourcehut, or github.
This leaves it unsaid how these symbols are used, and what symbols are
recognized.
Finally, I think this warrants a NEWS entry.
Thanks.
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at 72735) by debbugs.gnu.org; 20 Aug 2024 17:42:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 13:42:02 2024 Received: from localhost ([127.0.0.1]:33624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sgSrq-00011h-9v for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 13:42:02 -0400 Received: from thaodan.de ([185.216.177.71]:40810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1sgSrn-000113-BR for 72735 <at> debbugs.gnu.org; Tue, 20 Aug 2024 13:42:00 -0400 Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154]) by thaodan.de (Postfix) with ESMTPSA id 5031CD00086; Tue, 20 Aug 2024 20:40:39 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1724175639; bh=41UA80OWQmy/KwZFUi5GgbvIWVjkb+VAxT4tbeSb04M=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=L1Hjmvx7ttFd2m41SRJYbNmuJlRXCb9yxlYb+Jl0T5WIalALLNntsUSt8+hQnKLhI iKAMvNjOQxFKds0S/wpcTleCUczjJ+tioH1T6ApGIUVHumf3hOWHD99l0JGnpS8boE /THthPzgm8n/pVxerprLyhKUMBDPEsATFU0fTnFRRabOXKT+o6a6sb7Imlo59dloE0 IwpJ+bvlwzWzxAfDMde53YztxJjPpTr1OD832pGmYHw0ncgBkNEPQYke4uLXufRYlF GHpOeai3pUk6/LqZ2IrgCCa1al71RX41ZS9cN2D1wKTRLi1pm0PvQlDVREUQmejNby pN+bnTcVXxzzPif8bZ04J5RTf5eMeyzzj8FxY8gJsCOxDfzppN3tp9lso8pcS8ob8N VkOQmWSxyGdEAHQq7G1jeEU+oQdBcDV71f8TZftMW0fDkAjpFJYCImnlxNnzp8rZ9Z oWB3W1s4aZSw3YkpEPTLQ0/Syow+17SFm8tvULO8wgF07CDYG/rKGgce90QB2iRhW+ uFGS5BfdsjQEEAuje4gjI3ZPpk4sFZNkKltEpwmID/as1zrfk4O35czkafe+UQfjqH vptWT8M/mCHvOstVNiIYuev48vwyMbr3GwRg85trQPLPxV5fw8ogLKBM6LNE1ERVfD ZPHzNnDwNICNw/kEvkGz8r7o= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable In-Reply-To: <874j7fnr75.fsf@> (=?utf-8?Q?=22Bj=C3=B6rn?= Bidar via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Tue, 20 Aug 2024 18:34:38 +0300") References: Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Tue, 20 Aug 2024 20:40:38 +0300 Message-ID: <87a5h7hz3d.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I noticed that there are other variable such as bug-reference-setup-from-mail-alist that should be change similarly. Would it make sense to group the changes to convert them to defcustom in one patch or is one patch per variable better? Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 72735 Cc: 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) I noticed that there are other variable such as bug-reference-setup-from-mail-alist that should be change similarly. Would it make sense to group the changes to convert them to defcustom in one patch or is one patch per variable better?
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 20 Aug 2024 17:41:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 13:41:39 2024 Received: from localhost ([127.0.0.1]:33619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sgSrS-00010e-UR for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 13:41:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:55932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1sgSrP-00010S-4G for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 13:41:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>) id 1sgSqe-0003td-56 for bug-gnu-emacs@HIDDEN; Tue, 20 Aug 2024 13:40:49 -0400 Received: from thaodan.de ([2a03:4000:4f:f15::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>) id 1sgSqa-0003l6-Jm for bug-gnu-emacs@HIDDEN; Tue, 20 Aug 2024 13:40:46 -0400 Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154]) by thaodan.de (Postfix) with ESMTPSA id 5031CD00086; Tue, 20 Aug 2024 20:40:39 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1724175639; bh=41UA80OWQmy/KwZFUi5GgbvIWVjkb+VAxT4tbeSb04M=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=L1Hjmvx7ttFd2m41SRJYbNmuJlRXCb9yxlYb+Jl0T5WIalALLNntsUSt8+hQnKLhI iKAMvNjOQxFKds0S/wpcTleCUczjJ+tioH1T6ApGIUVHumf3hOWHD99l0JGnpS8boE /THthPzgm8n/pVxerprLyhKUMBDPEsATFU0fTnFRRabOXKT+o6a6sb7Imlo59dloE0 IwpJ+bvlwzWzxAfDMde53YztxJjPpTr1OD832pGmYHw0ncgBkNEPQYke4uLXufRYlF GHpOeai3pUk6/LqZ2IrgCCa1al71RX41ZS9cN2D1wKTRLi1pm0PvQlDVREUQmejNby pN+bnTcVXxzzPif8bZ04J5RTf5eMeyzzj8FxY8gJsCOxDfzppN3tp9lso8pcS8ob8N VkOQmWSxyGdEAHQq7G1jeEU+oQdBcDV71f8TZftMW0fDkAjpFJYCImnlxNnzp8rZ9Z oWB3W1s4aZSw3YkpEPTLQ0/Syow+17SFm8tvULO8wgF07CDYG/rKGgce90QB2iRhW+ uFGS5BfdsjQEEAuje4gjI3ZPpk4sFZNkKltEpwmID/as1zrfk4O35czkafe+UQfjqH vptWT8M/mCHvOstVNiIYuev48vwyMbr3GwRg85trQPLPxV5fw8ogLKBM6LNE1ERVfD ZPHzNnDwNICNw/kEvkGz8r7o= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: =?utf-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable In-Reply-To: <874j7fnr75.fsf@> (=?utf-8?Q?=22Bj=C3=B6rn?= Bidar via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Tue, 20 Aug 2024 18:34:38 +0300") References: Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Tue, 20 Aug 2024 20:40:38 +0300 Message-ID: <87a5h7hz3d.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a03:4000:4f:f15::1; envelope-from=bjorn.bidar@HIDDEN; helo=thaodan.de X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: submit Cc: 72735 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.2 (-) I noticed that there are other variable such as bug-reference-setup-from-mail-alist that should be change similarly. Would it make sense to group the changes to convert them to defcustom in one patch or is one patch per variable better?
bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 20 Aug 2024 15:35:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 20 11:35:34 2024
Received: from localhost ([127.0.0.1]:33579 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sgQtR-00064S-ED
for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 11:35:34 -0400
Received: from lists.gnu.org ([209.51.188.17]:56752)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjorn.bidar@HIDDEN>) id 1sgQtN-00064I-S2
for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 11:35:32 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>)
id 1sgQsg-0008DN-A6
for bug-gnu-emacs@HIDDEN; Tue, 20 Aug 2024 11:34:46 -0400
Received: from thaodan.de ([185.216.177.71])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>)
id 1sgQsd-0003er-M5
for bug-gnu-emacs@HIDDEN; Tue, 20 Aug 2024 11:34:46 -0400
Received: from odin (dsl-trebng12-50dc75-154.dhcp.inet.fi [80.220.117.154])
by thaodan.de (Postfix) with ESMTPSA id E03ABD00077
for <bug-gnu-emacs@HIDDEN>; Tue, 20 Aug 2024 18:34:40 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1724168081; bh=l6PpT3bGrpZ+BdvDuue2NiqYfKD+3cIXX5VS8GTEi+8=;
h=From:To:Subject:Date;
b=Ne8It9C0eRrtDhYeh99Kv29abj+fxFsvZssOu3C5vOY3uhoV++iU9bfgGfU+Az8ab
JHXZO85CaJjD5hz8w1hnX5Mlb61GdAe+k7k0zh45HurM7Ogfih0P3ABPBJrJHoRfma
oNc1l/+J8eJ47sVnQdHbCfnwXwhkput3Tc6YK+1sfY8e3M8Tq5qbT5qqU2r+9Xvu7J
yYlFEk74PcFHaKS7VLagtR5CdwR2UnNCIjtDdmdSj8e5pyWtUDDcry7CppzkbtLhY7
Ohniqq1GtCp/uSG1kswqeWePBaMEhunZT3koES4M1f5qCO46YNKdYAVFjp83UQuV0A
IUaGJhGp3f7bEaAj/HJAGhzeN3QF+I303lgR43Ll1SCXc5hbxa+pIMrSLpoD3Yt2kk
JcsT8cnENMWJTOjpfzGifoH3zgHI+EwNf+W8KfYEvMmjIUpGyJcg9FEODrqdQifTSm
iBWqFsPTbMWGoeFAxGCEao7QgMpSRiODqdm+frsPwDLaNCzUIakzw0QGImrqtciSJV
0raNxHHPKqRlZ+qbQEZ8bCrHjSLoG/oXPp7CVW7Tf7QJEHDhxodP3a3xA0khVr8pL0
ALfxb29kS1qTJ5Bu3/d6ci4ygF2kO+BH1joVKmnQZCXGDbMD7ZL7t0jmEJ2rI6EB9p
fgUBd8TIFucXtHXjU8jvMc+c=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; [PATCH] Make more bug-reference variables customizeable
X-Debbugs-Cc:
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Tue, 20 Aug 2024 18:34:38 +0300
Message-ID: <874j7fnr75.fsf@>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=185.216.177.71;
envelope-from=bjorn.bidar@HIDDEN; helo=thaodan.de
X-Spam_score_int: -14
X-Spam_score: -1.5
X-Spam_bar: -
X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.2 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Hello,
I noticed that some of the variables that can be modified
by the user or as mentioned as such were not defined as custom variable.
These patches to so and correct the group of one of the existing
defcustom.
The patches don't change any of the existing functionality
but only document these variables better and make them easier to modify.
Because of that I set version to Emacs 30.1. Please tell if that's ok.
Good day,
Bj=C3=B6rn
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Define-bug-reference-url-format-as-custom-type.patch
From 0a0f4062c41de25225df6b216470141d3537308c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Tue, 20 Aug 2024 16:05:31 +0300
Subject: [PATCH 1/3] Define bug-reference-url-format as custom type
* lisp/progmodes/bug-reference.el (bug-reference-url-format): Define as
custom type. The manual and the documentation string talk like the
variable like is a custom variable. It does make sense to define
it as a custom type to check the type and group it under the other
bug-reference-mode settings
---
lisp/progmodes/bug-reference.el | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/bug-reference.el b/lisp/progmodes/bug-reference.el
index 3bcfc213fc6..815e51aef73 100644
--- a/lisp/progmodes/bug-reference.el
+++ b/lisp/progmodes/bug-reference.el
@@ -48,7 +48,7 @@ bug-reference-map
"C-c RET" #'bug-reference-push-button)
;; E.g., "https://gcc.gnu.org/PR%s"
-(defvar bug-reference-url-format nil
+(defcustom bug-reference-url-format nil
"Format used to turn a bug number into a URL.
The bug number is supplied as a string, so this should have a single %s.
This can also be a function designator; it is called without arguments
@@ -62,7 +62,11 @@ bug-reference-url-format
If you set it to a symbol in the file Local Variables section,
you need to add a `bug-reference-url-format' property to it:
\(put \\='my-bug-reference-url-format \\='bug-reference-url-format t)
-so that it is considered safe, see `enable-local-variables'.")
+so that it is considered safe, see `enable-local-variables'."
+ :type '(choice (function)
+ (string))
+ :version "30.1"
+ :group 'bug-reference)
;;;###autoload
(put 'bug-reference-url-format 'safe-local-variable
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0002-Define-bug-reference-forge-alist-as-custom-type.patch
From 5cad0f9d1cb982f03a60c494f0a363056feab688 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Tue, 20 Aug 2024 17:09:14 +0300
Subject: [PATCH 2/3] Define bug-reference-forge-alist as custom type
* lisp/progmodes/bug-reference.el (bug-reference-forge-alist):
Define as custom type. The manual and the documentation string
refere to it like it is a custom variable.
Further defcustom will also ensure that the variable is the right type
when the user modifies it.
---
lisp/progmodes/bug-reference.el | 49 +++++++++++++++++++++------------
1 file changed, 31 insertions(+), 18 deletions(-)
diff --git a/lisp/progmodes/bug-reference.el b/lisp/progmodes/bug-reference.el
index 815e51aef73..9f293754c78 100644
--- a/lisp/progmodes/bug-reference.el
+++ b/lisp/progmodes/bug-reference.el
@@ -104,6 +104,37 @@ bug-reference-bug-regexp
;;;###autoload
(put 'bug-reference-bug-regexp 'safe-local-variable 'stringp)
+
+(defcustom bug-reference-forge-alist
+ '(("github.com" github "https")
+ ("gitea.com" gitea "https")
+ ("codeberg.org" gitea "https")
+ ("gitlab.com" gitlab "https")
+ ("framagit.org" gitlab "https")
+ ("salsa.debian.org" gitlab "https")
+ ("sr.ht" sourcehut "https"))
+ "An alist of forge instances.
+Each entry has the form (HOST-DOMAIN FORGE-TYPE PROTOCOL).
+HOST-DOMAIN is the host- and domain name, e.g., gitlab.com,
+salsa.debian.org, or sr.ht.
+FORGE-TYPE is the type of the forge, e.g., gitlab, gitea,
+sourcehut, or github.
+PROTOCOL is the protocol for accessing the forge's issue tracker,
+usually \"https\" but for self-hosted forge instances not
+accessible via the internet it might also be \"http\"."
+ :type '(alist :key-type (string :tag "Host-Domain")
+ :value-type (group (choice :tag "Forge-Type"
+ (const :tag "Github" github)
+ (const :tag "Gitea" gitea)
+ (const :tag "Gitlab" gitlab)
+ (const :tag "Sourcehut" sourcehut)
+ (symbol))
+ (choice :tag "Protocol"
+ (const "https") (string))))
+ :group 'bug-reference
+ :version "30.1")
+
+
(defun bug-reference-set-overlay-properties ()
"Set properties of bug reference overlays."
(put 'bug-reference 'evaporate t)
@@ -240,24 +271,6 @@ bug-reference--setup-from-vc-alist
from a few default entries, and the value of
`bug-reference-forge-alist'.")
-(defvar bug-reference-forge-alist
- '(("github.com" github "https")
- ("gitea.com" gitea "https")
- ("codeberg.org" gitea "https")
- ("gitlab.com" gitlab "https")
- ("framagit.org" gitlab "https")
- ("salsa.debian.org" gitlab "https")
- ("sr.ht" sourcehut "https"))
- "An alist of forge instances.
-Each entry has the form (HOST-DOMAIN FORGE-TYPE PROTOCOL).
-HOST-DOMAIN is the host- and domain name, e.g., gitlab.com,
-salsa.debian.org, or sr.ht.
-FORGE-TYPE is the type of the forge, e.g., gitlab, gitea,
-sourcehut, or github.
-PROTOCOL is the protocol for accessing the forge's issue tracker,
-usually \"https\" but for self-hosted forge instances not
-accessible via the internet it might also be \"http\".")
-
(cl-defgeneric bug-reference--build-forge-setup-entry
(host-domain forge-type protocol)
"Build an entry for `bug-reference--setup-from-vc-alist'.
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0003-Set-custom-group-of-bug-reference-bug-regexp.patch
From 5498829ad845ad7763d25f417be52233cc707753 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Tue, 20 Aug 2024 17:41:20 +0300
Subject: [PATCH 3/3] ; Set custom group of bug-reference-bug-regexp
---
lisp/progmodes/bug-reference.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/progmodes/bug-reference.el b/lisp/progmodes/bug-reference.el
index 9f293754c78..00d8f5d506c 100644
--- a/lisp/progmodes/bug-reference.el
+++ b/lisp/progmodes/bug-reference.el
@@ -97,6 +97,7 @@ bug-reference-bug-regexp
outside the bounds of subexpressions 1 and then don't contribute
to the highlighted and clickable region."
:type 'regexp
+ :group 'bug-reference
; 24.3: defconst -> defcustom
; 28.1: contract about subexpression 1 defines the overlay region.
:version "28.1")
--
2.45.2
--=-=-=--
Björn Bidar <bjorn.bidar@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#72735; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.