GNU logs - #72770, boring messages

Message sent to bug-coreutils@HIDDEN:

Subject: bug#72770: stat: filesystem ID regression in 9.5 with musl libc
Resent-From: Natanael Copa <ncopa@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Fri, 23 Aug 2024 07:16:02 +0000
Resent-Message-ID: <handler.72770.B.172439734525437 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72770 <at> debbugs.gnu.org
Date: Fri, 23 Aug 2024 09:14:34 +0200
From: Natanael Copa <ncopa@HIDDEN>
Message-ID: <20240823091434.50f31161@ncopa-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=2a01:7e00:e000:2fc::20;
 envelope-from=ncopa@HIDDEN; helo=gbr-app-1.alpinelinux.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

With coreutils 9.5 stat -f -c %i returns wrong value with musl libc.

$ docker run --rm -it -v /tmp:/tmp alpine:3.20 sh -c "apk add --quiet coreutils && stat --version && stat -f -c %i /tmp && busybox stat -f -c %i /tmp"
stat (GNU coreutils) 9.5
Copyright (C) 2024 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Michael Meskes.
4dc59e8900000000
4dc59e89680d9b7c

Coreutils returns 4dc59e8900000000 instead of the expected 4dc59e89680d9b7c.

With 9.4 this works as expected:

$ docker run --rm -it -v /tmp:/tmp alpine:3.19 sh -c "apk add --quiet coreutils && stat --version && stat -f -c %i /tmp && busybox stat -f -c %i /tmp"
stat (GNU coreutils) 9.4
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Michael Meskes.
4dc59e89680d9b7c
4dc59e89680d9b7c

Downstream report: https://gitlab.alpinelinux.org/alpine/aports/-/issues/16386

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Natanael Copa <ncopa@HIDDEN>
Subject: bug#72770: Acknowledgement (stat: filesystem ID regression in 9.5
 with musl libc)
Message-ID: <handler.72770.B.172439734525437.ack <at> debbugs.gnu.org>
References: <20240823091434.50f31161@ncopa-desktop>
X-Gnu-PR-Message: ack 72770
X-Gnu-PR-Package: coreutils
Reply-To: 72770 <at> debbugs.gnu.org
Date: Fri, 23 Aug 2024 07:16:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-coreutils@HIDDEN

If you wish to submit further information on this problem, please
send it to 72770 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72770: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72770
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-coreutils@HIDDEN:

Subject: bug#72770: stat: filesystem ID regression in 9.5 with musl libc
Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Fri, 23 Aug 2024 10:44:01 +0000
Resent-Message-ID: <handler.72770.B72770.172440980614336 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Natanael Copa <ncopa@HIDDEN>, 72770 <at> debbugs.gnu.org
Message-ID: <08922ef2-e433-497f-a657-ca1799fadd21@HIDDEN>
Date: Fri, 23 Aug 2024 11:41:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
References: <20240823091434.50f31161@ncopa-desktop>
Content-Language: en-US
From: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
In-Reply-To: <20240823091434.50f31161@ncopa-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 23/08/2024 08:14, Natanael Copa wrote:
> With coreutils 9.5 stat -f -c %i returns wrong value with musl libc.
> 
> $ docker run --rm -it -v /tmp:/tmp alpine:3.20 sh -c "apk add --quiet coreutils && stat --version && stat -f -c %i /tmp && busybox stat -f -c %i /tmp"
> stat (GNU coreutils) 9.5
> Copyright (C) 2024 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> 
> Written by Michael Meskes.
> 4dc59e8900000000
> 4dc59e89680d9b7c
> 
> Coreutils returns 4dc59e8900000000 instead of the expected 4dc59e89680d9b7c.
> 
> With 9.4 this works as expected:
> 
> $ docker run --rm -it -v /tmp:/tmp alpine:3.19 sh -c "apk add --quiet coreutils && stat --version && stat -f -c %i /tmp && busybox stat -f -c %i /tmp"
> stat (GNU coreutils) 9.4
> Copyright (C) 2023 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> 
> Written by Michael Meskes.
> 4dc59e89680d9b7c
> 4dc59e89680d9b7c
> 
> Downstream report: https://gitlab.alpinelinux.org/alpine/aports/-/issues/16386

I can't see what might have changed on the coreutils side with a quick look.
It would help eliminate cases if you provided strace output from 9.4 and 9.5

thanks,
Pádraig

Message sent to bug-coreutils@HIDDEN:

Subject: bug#72770: stat: filesystem ID regression in 9.5 with musl libc
Resent-From: Natanael Copa <ncopa@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Fri, 23 Aug 2024 11:41:02 +0000
Resent-Message-ID: <handler.72770.B72770.172441326020172 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
Cc: 72770 <at> debbugs.gnu.org
Date: Fri, 23 Aug 2024 13:39:58 +0200
From: Natanael Copa <ncopa@HIDDEN>
Message-ID: <20240823133958.405bc9e7@ncopa-desktop>
In-Reply-To: <08922ef2-e433-497f-a657-ca1799fadd21@HIDDEN>
References: <20240823091434.50f31161@ncopa-desktop>
 <08922ef2-e433-497f-a657-ca1799fadd21@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Fri, 23 Aug 2024 11:41:28 +0100
P=E1draig Brady <P@HIDDEN> wrote:

> On 23/08/2024 08:14, Natanael Copa wrote:
> > With coreutils 9.5 stat -f -c %i returns wrong value with musl libc.
> >=20
> > $ docker run --rm -it -v /tmp:/tmp alpine:3.20 sh -c "apk add --quiet c=
oreutils && stat --version && stat -f -c %i /tmp && busybox stat -f -c %i /=
tmp"
> > stat (GNU coreutils) 9.5
> > Copyright (C) 2024 Free Software Foundation, Inc.
> > License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gp=
l.html>.
> > This is free software: you are free to change and redistribute it.
> > There is NO WARRANTY, to the extent permitted by law.
> >=20
> > Written by Michael Meskes.
> > 4dc59e8900000000
> > 4dc59e89680d9b7c
> >=20
> > Coreutils returns 4dc59e8900000000 instead of the expected 4dc59e89680d=
9b7c.
> >=20
> > With 9.4 this works as expected:
> >=20
> > $ docker run --rm -it -v /tmp:/tmp alpine:3.19 sh -c "apk add --quiet c=
oreutils && stat --version && stat -f -c %i /tmp && busybox stat -f -c %i /=
tmp"
> > stat (GNU coreutils) 9.4
> > Copyright (C) 2023 Free Software Foundation, Inc.
> > License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gp=
l.html>.
> > This is free software: you are free to change and redistribute it.
> > There is NO WARRANTY, to the extent permitted by law.
> >=20
> > Written by Michael Meskes.
> > 4dc59e89680d9b7c
> > 4dc59e89680d9b7c
> >=20
> > Downstream report: https://gitlab.alpinelinux.org/alpine/aports/-/issue=
s/16386 =20
>=20
> I can't see what might have changed on the coreutils side with a quick lo=
ok.
> It would help eliminate cases if you provided strace output from 9.4 and =
9.5

I think the difference is that with 9.4 it ends up using statfs(2), and
with 9.5 it ends up using statvfs(3).

musl only uses 32 bits of the returned 64 bits from statfs(2) to match the =
POSIX interface.

https://git.musl-libc.org/cgit/musl/tree/src/stat/statvfs.c?id=3Ddd1e63c363=
8d5f9afb857fccf6ce1415ca5f1b8b#n39

I believe they do so to have consistent fsid on 32 bit and 64 bit architect=
ures.

>=20
> thanks,
> P=E1draig

Message sent to bug-coreutils@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#72770: stat: filesystem ID regression in 9.5 with musl libc
Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Fri, 23 Aug 2024 17:36:01 +0000
Resent-Message-ID: <handler.72770.B72770.172443450528004 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72770
X-GNU-PR-Package: coreutils
X-GNU-PR-Keywords: 
To: Natanael Copa <ncopa@HIDDEN>
Cc: 72770 <at> debbugs.gnu.org
Received: via spool by 72770-submit <at> debbugs.gnu.org id=B72770.172443450528004
          (code B ref 72770); Fri, 23 Aug 2024 17:36:01 +0000
Received: (at 72770) by debbugs.gnu.org; 23 Aug 2024 17:35:05 +0000
Received: from localhost ([127.0.0.1]:40069 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1shYBk-0007Hc-SJ
	for submit <at> debbugs.gnu.org; Fri, 23 Aug 2024 13:35:05 -0400
Received: from mail-ej1-f43.google.com ([209.85.218.43]:43342)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pixelbeat@HIDDEN>) id 1shYBh-0007H0-2u
 for 72770 <at> debbugs.gnu.org; Fri, 23 Aug 2024 13:35:03 -0400
Received: by mail-ej1-f43.google.com with SMTP id
 a640c23a62f3a-a86910caf9cso359365566b.1
 for <72770 <at> debbugs.gnu.org>; Fri, 23 Aug 2024 10:34:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1724434388; x=1725039188; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:cc:from:content-language
 :references:to:subject:user-agent:mime-version:date:message-id
 :sender:from:to:cc:subject:date:message-id:reply-to;
 bh=KgW2WPqGCtph3EOnVdPy+us/Z+ks0Eqz0lJFaP0P07g=;
 b=TWWInAykpzfhSFA7XjrOgfzjYxes3pyRQ1kLt3K1GLFlnXT/p0eOINr8Rs2UOwcUdO
 BOR6JS5SbG1N/p9Xxlopd8iudOhk1PE9+jQhuNAq1LM1VeZXdCOGr03M9Dpp5OMPLHR5
 sDP7iwfYDjkDybOXlWKmBhhnGLrVK+0mBukaCOcwfDlydsnE80SOluFFIGCkrUt35mym
 J/SpMEbdyk9es+Lqgtl3KC3U0evVWrcz9B9zmauPwmU1vnlb2SwLtOoEbVlcRrObSh2o
 7HT4exSkblQuGHu832QqUjiJN0C1RYlfFERDoT14tkIUUYY82ATOBFkTRLYNGrwOR0iL
 4yag==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1724434388; x=1725039188;
 h=content-transfer-encoding:in-reply-to:cc:from:content-language
 :references:to:subject:user-agent:mime-version:date:message-id
 :sender:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=KgW2WPqGCtph3EOnVdPy+us/Z+ks0Eqz0lJFaP0P07g=;
 b=lrqO0QTSJRyPwFWWLeWu61OIpxIOFQf8fFQz905ZV+3Ey6HFckicw29H0c1Gv6FuM9
 8wN3j/09bqePmy6zqJWq+CPR2NfQO0RXJkRUafzKkSU+2/CCYtSuZNRRIyeFlgmwm/En
 gzAVHH2aT27z6e3Qo1MCFAJe27oOF8SbGxQZOffplc3yob8GgkMDmLHINP2wZYSHx9N6
 De8mHgakpoIrQ89x1Kp11e5SPFbZ4nuixfLWV1FYtyJ/9QoObmgkiS31QG38t2z7nSkb
 knSJv0U4Zg+nyMt9Of4b7RGplHUoZW3HG9ztDpmFlD900aSOdBLGEF2RwDNZWoXhOrFT
 0gjA==
X-Gm-Message-State: AOJu0Yzm+iTzuYSy2PYLD7iRaaM3CGPvFtCTzZlcxQ9B8tGAgHgQRWPX
 afZ7/D2ihCXaALSItETyK3X9lS4x8Br9beuM4wnzhPoaXw309MEqh7g2rA==
X-Google-Smtp-Source: AGHT+IFyiuW93J4LOl+SsYQZb4UEgAR3V7ctU8Tm8+KPkNyV/UC45VUHEw/KNOEmIvqJiDzoV/NJRg==
X-Received: by 2002:a17:907:1c25:b0:a77:c051:36a9 with SMTP id
 a640c23a62f3a-a86a2f5c197mr328589466b.9.1724434387289; 
 Fri, 23 Aug 2024 10:33:07 -0700 (PDT)
Received: from [192.168.1.54]
 (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146])
 by smtp.googlemail.com with ESMTPSA id
 a640c23a62f3a-a868f437c23sm288831766b.110.2024.08.23.10.33.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 23 Aug 2024 10:33:06 -0700 (PDT)
Message-ID: <6c48697a-4c4b-4623-8c5d-1df8d41ae118@HIDDEN>
Date: Fri, 23 Aug 2024 18:33:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
References: <20240823091434.50f31161@ncopa-desktop>
 <08922ef2-e433-497f-a657-ca1799fadd21@HIDDEN>
 <20240823133958.405bc9e7@ncopa-desktop>
Content-Language: en-US
From: =?UTF-8?Q?P=C3=A1draig?= Brady <P@HIDDEN>
In-Reply-To: <20240823133958.405bc9e7@ncopa-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 23/08/2024 12:39, Natanael Copa wrote:
> On Fri, 23 Aug 2024 11:41:28 +0100
> Pádraig Brady <P@HIDDEN> wrote:
> 
>> On 23/08/2024 08:14, Natanael Copa wrote:
>>> With coreutils 9.5 stat -f -c %i returns wrong value with musl libc.
>>>
>>> $ docker run --rm -it -v /tmp:/tmp alpine:3.20 sh -c "apk add --quiet coreutils && stat --version && stat -f -c %i /tmp && busybox stat -f -c %i /tmp"
>>> stat (GNU coreutils) 9.5
>>> Copyright (C) 2024 Free Software Foundation, Inc.
>>> License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
>>> This is free software: you are free to change and redistribute it.
>>> There is NO WARRANTY, to the extent permitted by law.
>>>
>>> Written by Michael Meskes.
>>> 4dc59e8900000000
>>> 4dc59e89680d9b7c
>>>
>>> Coreutils returns 4dc59e8900000000 instead of the expected 4dc59e89680d9b7c.
>>>
>>> With 9.4 this works as expected:
>>>
>>> $ docker run --rm -it -v /tmp:/tmp alpine:3.19 sh -c "apk add --quiet coreutils && stat --version && stat -f -c %i /tmp && busybox stat -f -c %i /tmp"
>>> stat (GNU coreutils) 9.4
>>> Copyright (C) 2023 Free Software Foundation, Inc.
>>> License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
>>> This is free software: you are free to change and redistribute it.
>>> There is NO WARRANTY, to the extent permitted by law.
>>>
>>> Written by Michael Meskes.
>>> 4dc59e89680d9b7c
>>> 4dc59e89680d9b7c
>>>
>>> Downstream report: https://gitlab.alpinelinux.org/alpine/aports/-/issues/16386
>>
>> I can't see what might have changed on the coreutils side with a quick look.
>> It would help eliminate cases if you provided strace output from 9.4 and 9.5
> 
> I think the difference is that with 9.4 it ends up using statfs(2), and
> with 9.5 it ends up using statvfs(3).
> 
> musl only uses 32 bits of the returned 64 bits from statfs(2) to match the POSIX interface.
> 
> https://git.musl-libc.org/cgit/musl/tree/src/stat/statvfs.c?id=dd1e63c3638d5f9afb857fccf6ce1415ca5f1b8b#n39
> 
> I believe they do so to have consistent fsid on 32 bit and 64 bit architectures.

Interesting. I see musl has been doing this truncation since 2011,
but I guess the coreutils build picked up statvfs() since musl
started returning f_type in it:
https://git.musl-libc.org/cgit/musl/commit/src/stat/statvfs.c?id=7291c6c6
I suppose we could adjust m4/stat-prog.m4 in coreutils to
avoid statvfs detection on musl

It would be worth suggesting to the musl folks to avoid this truncation.

thanks,
Pádraig

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.