Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 21:35:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 17:35:10 2024
Received: from localhost ([127.0.0.1]:53508 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sqJNG-0001pR-2G
for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 17:35:10 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30214)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1sqJNE-0001pA-HD
for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 17:35:08 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AD5154450F4;
Mon, 16 Sep 2024 17:34:47 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1726522486;
bh=b47tPLJ05sGMsGz2N/N4alUPNO0C1cJ+7TDmlcaplS8=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=bdGVtu4DQDyYKlvsdtIB+zm2hzoIxM5xYHRmnN3LD/gN+D7OrQXEsJMGwXeoK8YbO
JeLn4LLgtzKh7tE/+YvhdFgbFS9SeDsMdLaBNU5PSbkp1+cjFhyeYgi89FZk2SXzoj
dzbqkg2D2JQ1GbkVbReKVSrtXncBfqPcOJ6xBhHo6exXkZKwUkloJjwIy4DaLXutDE
gUa3+XB+9qg6BQf0Pm2d/qX6JHS+7LFKBy+snbbV/ivax3QYvML6g0bELB8GyoGeo0
LbVzGEXOe6ubUSjR6viWqwfhZwllB0fieWafgzWIvapxZ0RbjeFkP5c0pt7AQomsoK
CvqH4JsAKO0Pw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EE03D4450DA;
Mon, 16 Sep 2024 17:34:45 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DC4DC12051B;
Mon, 16 Sep 2024 17:34:45 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might
not be found in .dir-locals.el
In-Reply-To: <86ttefde1d.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 16 Sep
2024 14:38:22 +0300")
Message-ID: <jwvwmjbi97e.fsf-monnier+emacs@HIDDEN>
References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN>
<86ttefde1d.fsf@HIDDEN>
Date: Mon, 16 Sep 2024 17:34:45 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.167 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73280
Cc: Troy Brown <brownts@HIDDEN>, joaotavora@HIDDEN,
73280 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> ```elisp
>> ;; Set the major mode to be the first of the managed
>> ;; modes. This is the one the user started eglot in.
>> (setq major-mode (car (eglot--major-modes server)))
>> ```
This code is indeed hackish/heuristic by nature.
I guess the reason for it is that it needs to work regardless of the
buffers that use that server (which could all use different major
modes).
Alternatives:
- Get `eglot-workspace-configuration` "once and for all" when starting
the server, using the major mode currently active the buffer from
which the server's launch was triggered.
- Collect all the buffers currently using that server, take the set of
modes they currently use, fetch the corresponding
`eglot-workspace-configuration` values, and "merge them" (and if they
disagree, maybe emit a warning?).
But in the mean time, it seems `eglot-workspace-configuration` was
designed so that you can have a single setting shared for all modes, as
Jo=E3o mentions, so using nil (or `prog-mode`) instead of `ada-mode` or
`ada-ts-mode` seems like the better option.
Stefan
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 21:34:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 17:34:37 2024 Received: from localhost ([127.0.0.1]:53503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqJMi-0001ny-JJ for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 17:34:36 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:44270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy.s.brown@HIDDEN>) id 1sqJMg-0001nm-Oc for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 17:34:35 -0400 Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a7aa086b077so612993566b.0 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 14:34:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726522455; x=1727127255; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HgRzOnFdz/XzplpAmPy6XZaPVLwoSmauZKj1+Yd5BNs=; b=CRTo87XMlPgg1c272kJOB0M0xdavKIaf89qsGwUC1fk6O5jQ4alac95dkS0tpVEwZ1 nHYtgQbjwe/xrE0LXH83i5VLSS/mQhJ2jb9hStfpbuwRj6uGtcDSUHrqwiac//q0TmJx SNUB6CRkggi5dvPlKWIoTKs2dcqUOr4wuoZHsWuuYvnoSoHvh9VcF028nunhpm4nt5Mu VhHINREEx/lkjYxOtGECaalCWtGUd/7IRDCT4lHpUX9K8RseTCpYZC1sn1V6aeFMQxDU sLlhm37q/Al6lLR6glZqK15n9jy7SVU2UlFtIFROfqTZouDkwTmCoxIAHJ2YdjGNO4jo d2YQ== X-Forwarded-Encrypted: i=1; AJvYcCXmc+1Iy9os3aMeD1HaBJKtfmih8BBq+Cyghu+eEMMmChYd35VKj1/iDvqzmwv2pILw+zt9UA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzkRaXexMHCHLMiJery4vqpxQlWyvCCx2BCPinfqrquicMJ8qVi CzLWfFyiKHC8AcIj3rnzItF8j5GKO/Q3lRg4e5FoyHYJVsU1i6xJw1xPwlYnrVs= X-Google-Smtp-Source: AGHT+IEFydWbAawbLFgZhJQDWZIopGmgJDlrvOd3HuP0G6uWOgxTQwrSn/60DGtsbfd/j7RlmL+FHA== X-Received: by 2002:a17:907:f153:b0:a7d:e956:ad51 with SMTP id a640c23a62f3a-a9029438ed1mr1558188366b.21.1726522454237; Mon, 16 Sep 2024 14:34:14 -0700 (PDT) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com. [209.85.208.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90610f3878sm364833266b.47.2024.09.16.14.34.13 for <73280 <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2024 14:34:13 -0700 (PDT) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5c413cf5de5so6897475a12.0 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 14:34:13 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWplKiA7EvmUsyFTuM3tVR2YMBIiC325PpUiA0hMxHBroKUHMWBVVHU5WEWzPXZ0GUkhUuwvA==@debbugs.gnu.org X-Received: by 2002:a05:6402:5290:b0:5af:30d9:e2b6 with SMTP id 4fb4d7f45d1cf-5c413e4a402mr16388423a12.23.1726522453724; Mon, 16 Sep 2024 14:34:13 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> <86a5g7cvnx.fsf@HIDDEN> <CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@HIDDEN> <CALDnm52bMP71BVcazV2AZ+PKQAoL3A_asvWzP3B9hmmQu+QQSg@HIDDEN> In-Reply-To: <CALDnm52bMP71BVcazV2AZ+PKQAoL3A_asvWzP3B9hmmQu+QQSg@HIDDEN> From: Troy Brown <brownts@HIDDEN> Date: Mon, 16 Sep 2024 17:34:02 -0400 X-Gmail-Original-Message-ID: <CABvCZ41k8q5ofgP8j=hynxAk8ZJNboSf=15ENhhObnhXfkjqVQ@HIDDEN> Message-ID: <CABvCZ41k8q5ofgP8j=hynxAk8ZJNboSf=15ENhhObnhXfkjqVQ@HIDDEN> Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 73280 Cc: Eli Zaretskii <eliz@HIDDEN>, monnier@HIDDEN, 73280 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) On Mon, Sep 16, 2024 at 3:06=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora@g= mail.com> wrote: > > On Mon, Sep 16, 2024 at 7:54=E2=80=AFPM Troy Brown <brownts@HIDDEN= > wrote: > > > That would be fine if this was isolated to only "ts" vs "non-ts" > > modes. Another example is "typescript-mode". In order to configure > > the server, you have to use "js-mode" in .dir-locals.el. Why? > > Because it's the first one in the list. > > Well, typescript is a transpile-to-js language, doesn't strike me as > that odd. > > Also have you read section 5.1.1 of the Eglot's user manual? You > can just use `nil` as the mode and `w-s-configuration` will > be set buffer-locally in all modes for buffers within that dir. > This is probably easier. Check it out. Thanks for the pointer on using "nil", I had forgotten about that. Since it appears I'm failing to make a convincing argument, I think that using "nil" will be my approach going forward. I'll avoid using mode-based configuration in Eglot, as I find it deceptive and prone to future breakage. In its current state, I think it would be wise to discourage its use in the user manual, to avoid misunderstanding and potential future problems. I'm surprised nobody has raised this issue in the past, but don't be surprised if you receive additional bug reports in the future.
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 19:17:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 15:17:49 2024 Received: from localhost ([127.0.0.1]:53295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqHEK-0002gI-Nc for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 15:17:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sqHEH-0002g1-WC for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 15:17:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sqHDx-0005E0-VC; Mon, 16 Sep 2024 15:17:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vzJqNitKN8pmGCJecZpZjAI/LHpjm3QyaJkS/U4PU+I=; b=ZbmffgxO/jS+ 5ESe3qTMSxBdPe8o49agiPy2SRgFR/dkb5cOjygfE9OKZ9FIDxC2KY1G9JcAKluY7NrmUVu/YB6IE T4uw8D6pjHCldaSubkp0CGtjsq+HdYXsZjgdsjCoF+fk/Dvx2W3YjAh0kV9NkdSrDnP5O4Ai9vGuU 7oZV92mQ98HDM/tPdHD9ea6EFuezqb8UOuLtWsNBe0UenuDffACuu6JkF1KA2Wdi4wEpBMjdcQgdl jgveQh4p0ov0AQVILxs2mEKJ7swBmvn1Lye/4nfkAwJd37EZ9EtS9uAXbIZvxu8BvCnwYZhcpl/LG A0WdRovouBcJShAKX5aZwA==; Date: Mon, 16 Sep 2024 22:17:01 +0300 Message-Id: <861q1jcssy.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Troy Brown <brownts@HIDDEN> In-Reply-To: <CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@HIDDEN> (message from Troy Brown on Mon, 16 Sep 2024 14:53:53 -0400) Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> <86a5g7cvnx.fsf@HIDDEN> <CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73280 Cc: 73280 <at> debbugs.gnu.org, joaotavora@HIDDEN, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Troy Brown <brownts@HIDDEN> > Date: Mon, 16 Sep 2024 14:53:53 -0400 > Cc: joaotavora@HIDDEN, monnier@HIDDEN, 73280 <at> debbugs.gnu.org > > > With the emergence of the *-ts-mode modes, we need to adjust our > > intuition. We decided that having foo-mode settings cover foo-ts-mode > > as well as much as possible is an advantage, not a disadvantage. So > > our intuition needs to follow suit. > > > > That would be fine if this was isolated to only "ts" vs "non-ts" > modes. Another example is "typescript-mode". In order to configure > the server, you have to use "js-mode" in .dir-locals.el. Why? > Because it's the first one in the list. Isn't Typescript a variant of JavaScript? > I proposed in my last response a mechanism where you could specify a > configuration for any of the modes associated with a server and have > it applied, rather than ignoring a configuration if it wasn't > explicitly specified for the first one in the list. I'm not against it, I just responded to the part of your arguments which are more philosophical. > > > I don't think I'd agree with the first mode being representative, it > > > seems somewhat arbitrary. For instance, in order to change > > > eglot-workspace-configuration for "sh-mode", you have to set the > > > configuration in .dir-locals.el for "bash-ts-mode"...who would've > > > guessed this? > > > > I'd like to think that in a not-so-distant future, _everyone_ will > > guess that. Why not? it makes perfect sense to me. > > What is that? It's not consistent with the "foo-mode settings cover > foo-ts-mode", it's actually the other way around. Bash is a variant of a Bourne shell, isn't it?
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 19:07:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 15:07:53 2024 Received: from localhost ([127.0.0.1]:53289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqH4j-00029m-KN for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 15:07:53 -0400 Received: from mail-oo1-f51.google.com ([209.85.161.51]:48637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sqH4i-00029a-1v for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 15:07:52 -0400 Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-5dcd8403656so2534595eaf.1 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 12:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726513593; x=1727118393; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rvqVrMKyZawPrwswRcje1qN4f6NMW/Fi9RTZ1tKM8+U=; b=emIaitYVUtBU2Gq9mu+asAvadxlSakydLO5yJ1ZvO/xcvSIjmTEclx3uXbre0MnBcX JMpS6LHgvO6vdK5zFEAE1kq3kFNA3jzA2TODEB+C2ASmVRjogQJjyNd1IOs+emYP4xbN yQgFDzPDQiD6/MzfjH/MOsiOXtlhUCHwVmCKmcNztTL7LJoKXDO29M1EIhMQkUb3QKZg qnLEOjR+t5vKzQn+J1jxXEguy75W72neEdbzoLWoznDd4KRcpnh0fDndxak0kW5xZwPF cS0+9wXTa7/hg2w8yK3GDDR8WOE5fJzS1qTOrZdQ4RBphxHYXobq+y+pdUUshYGYyaHk ocmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726513593; x=1727118393; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rvqVrMKyZawPrwswRcje1qN4f6NMW/Fi9RTZ1tKM8+U=; b=tnU5Xqfy1ma8zh8GR2ddgeq2QLlBiWnwBnICoDxBxtnb/AbjBDqa/FpCFVBAzpZw9t W8oTLF2Owzhv1a8XkZsNRQBvQNGDE97lYFZ7j0ZmYk8bkkxPRRb0G1BhOp6Mo+bDSaq7 LpfBUyjVnTcqRpCkOq+XWPUWiOO/Hbcdn6gnXm4cAXRO0m3ZakDT9FhbpC63V6OXE2Or Tg238XZA98gk40I9GLb+NWpzoTtQvWLlseRzpUh20p8VTqf8ux9nJoMVAIL6xSD5oHST +BjKMf3tACWQUD6kSCAirhtAiO+gsMNavyDrpb64I+Xkdr6yIByfe0r4G8fRO/4O/paL ySCw== X-Forwarded-Encrypted: i=1; AJvYcCVpXM/wlTJT5C+RA4ZTx76y5VX/B0cegYS6udjVHGqWDboj9yCJd/slc5jmfYicPc7zWPnJEA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw0EyWSfZFWVB5kkR9m1PU0XJqkfb4W8vlo3kLi17RYWZO6H//g YTx7EovtdFLjBegKJKh9WbfhVRbggQqX8R1HN5Su/oL7qaZm97wTpBoWgwfaeBjK/SykgKTFRhR B2AbJ5dlcggqHwTfwU9lKw9j6DBs= X-Google-Smtp-Source: AGHT+IGS14xMWSWis3NDvCUhWpooVRMVmNsP+q6aI/q1sEYFY/Rr2IWUVNFIjgKMmcRpSsDxvceCQ8JRQAmpBK5ZOmc= X-Received: by 2002:a05:6820:178b:b0:5e1:ba69:1646 with SMTP id 006d021491bc7-5e201419ebfmr8050255eaf.4.1726513592684; Mon, 16 Sep 2024 12:06:32 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> <86a5g7cvnx.fsf@HIDDEN> <CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@HIDDEN> In-Reply-To: <CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Mon, 16 Sep 2024 20:07:57 +0100 Message-ID: <CALDnm52bMP71BVcazV2AZ+PKQAoL3A_asvWzP3B9hmmQu+QQSg@HIDDEN> Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el To: Troy Brown <brownts@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73280 Cc: Eli Zaretskii <eliz@HIDDEN>, monnier@HIDDEN, 73280 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Mon, Sep 16, 2024 at 7:54=E2=80=AFPM Troy Brown <brownts@HIDDEN> = wrote: > That would be fine if this was isolated to only "ts" vs "non-ts" > modes. Another example is "typescript-mode". In order to configure > the server, you have to use "js-mode" in .dir-locals.el. Why? > Because it's the first one in the list. Well, typescript is a transpile-to-js language, doesn't strike me as that odd. Also have you read section 5.1.1 of the Eglot's user manual? You can just use `nil` as the mode and `w-s-configuration` will be set buffer-locally in all modes for buffers within that dir. This is probably easier. Check it out.
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 18:54:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 14:54:28 2024 Received: from localhost ([127.0.0.1]:53277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqGrk-0001No-7J for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 14:54:28 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:59718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy.s.brown@HIDDEN>) id 1sqGrh-0001NW-Sb for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 14:54:26 -0400 Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c3d209db94so5952348a12.3 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 11:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726512846; x=1727117646; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wuihC1VF3tEmGOviXp131I+VhGHNbglTrCysjtRCKoA=; b=NE01hfx5Aux2yU9WRgzm8o4cTX+KoHb4OO4iJYbj/xonsvuFpz9HGgOlrFSFRuCtLQ sovSmG7qYsnmK4c24mzLPkddfktalTnNGnHIApHkElxZq5Jluf8qa9LChcZ5yVNfggzu oYWlQs5lLdot7sOKkU85SscpgEf8IBh9ZfGlJfV5+X/2e3R0oaRnEO1lNH+tuiYk5dNb ImLt96M8/266FzdUKvxuNmQtNbPgLGrX9fqU4HIvcsc803/jFM8QhovkIaWVk8Pt7Q8O tN2n8rOVtGVzyUeNroSYDB/9im0WdDXXBndjh9ptMNzCn5p5p5EyLW234233ocl9jlhQ bOYQ== X-Forwarded-Encrypted: i=1; AJvYcCW1aSY87xa5CilCDWZYlJuSr99GvCHH1xII5n0q4rzkflhuvhK3NOIHxQv7dUC7+qP53SaiMA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwyvWcmljqbXg5VkFhQgUgms/sgraLSAu7P3h9Sob/U6ripFb34 d26LsuxkGMZ1/kj/hvP5OvXMLkrP9eofHm2WtCvhA+mfxc4P2u8OWCyIw6mfL8U= X-Google-Smtp-Source: AGHT+IFwR2XOg/l3RzZc0Xd1KnIzLHTn2/HDKxwJH4Hs+NUHt9WH5spxgpx3qF5I5ZArKLTyROwsPA== X-Received: by 2002:a05:6402:26c9:b0:5c2:4ad9:6d9f with SMTP id 4fb4d7f45d1cf-5c413e0942dmr14874336a12.1.1726512844876; Mon, 16 Sep 2024 11:54:04 -0700 (PDT) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bc88fe2sm2883269a12.87.2024.09.16.11.54.04 for <73280 <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2024 11:54:04 -0700 (PDT) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5c25554ec1eso5899466a12.1 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 11:54:04 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX3GE5kebBVDi3my7lsz/clcOQfxe119LPdW8Aj3QWZukpDrALlxftYJfGIteZ/0CUs3Jn0MA==@debbugs.gnu.org X-Received: by 2002:a05:6402:3228:b0:5c2:67d9:3578 with SMTP id 4fb4d7f45d1cf-5c413e54206mr14629401a12.29.1726512844465; Mon, 16 Sep 2024 11:54:04 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> <86a5g7cvnx.fsf@HIDDEN> In-Reply-To: <86a5g7cvnx.fsf@HIDDEN> From: Troy Brown <brownts@HIDDEN> Date: Mon, 16 Sep 2024 14:53:53 -0400 X-Gmail-Original-Message-ID: <CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@HIDDEN> Message-ID: <CABvCZ416iSqrm53LUNth3bLn42EXvKZCrhAvX_DM4=wLSV75og@HIDDEN> Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 73280 Cc: 73280 <at> debbugs.gnu.org, joaotavora@HIDDEN, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) On Mon, Sep 16, 2024 at 2:15=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > > > > I would say the major downside is that it is not intuitive at all. > > With the emergence of the *-ts-mode modes, we need to adjust our > intuition. We decided that having foo-mode settings cover foo-ts-mode > as well as much as possible is an advantage, not a disadvantage. So > our intuition needs to follow suit. > That would be fine if this was isolated to only "ts" vs "non-ts" modes. Another example is "typescript-mode". In order to configure the server, you have to use "js-mode" in .dir-locals.el. Why? Because it's the first one in the list. > > It's not consistent with how directory-local variables behave. > > I disagree. Certain settings in .dir-locals are completely global, > which is even more radical than this case. Having to specify a > setting once for several related modes is a Good Thing, IMO. > I proposed in my last response a mechanism where you could specify a configuration for any of the modes associated with a server and have it applied, rather than ignoring a configuration if it wasn't explicitly specified for the first one in the list. The way it currently exists, you'll never be able to change the first mode in the list or you will likely break someone's .dir-locals.el which had to rely on this ordering in order to properly configure their server. > > I don't think I'd agree with the first mode being representative, it > > seems somewhat arbitrary. For instance, in order to change > > eglot-workspace-configuration for "sh-mode", you have to set the > > configuration in .dir-locals.el for "bash-ts-mode"...who would've > > guessed this? > > I'd like to think that in a not-so-distant future, _everyone_ will > guess that. Why not? it makes perfect sense to me. What is that? It's not consistent with the "foo-mode settings cover foo-ts-mode", it's actually the other way around. You have to set the "ts" version in order to have it apply to the "non-ts" version. YAML is another one where the "ts" version is listed first in the list. These are inconsistent. Some lists specify the "non-ts" version before the "ts" version, others swap those. And furthermore, some lists contain multiple "non-ts" modes, so it's arbitrary which one is listed first.
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 18:44:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 14:44:14 2024 Received: from localhost ([127.0.0.1]:53262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqGhq-0000qB-87 for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 14:44:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sqGho-0000px-42 for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 14:44:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sqGhU-0001tb-6V; Mon, 16 Sep 2024 14:43:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=4FfGXgcBC2CKPxl7qXeRZha9W+6Za+8OhsI7Bw7hPrY=; b=lkCsrkrr/dT1SZr5EjDl diggxE+7oRZRPv8hXYE5ct0ML+prl9Zee9KT+0IQqivvxA7VilCZybTAtumYZM6HKYkJqHHcW3GB8 A7L+hZkMUQocWrXVLU8De6mPKDOL5iXP+P9PSeNGwT59ric6uCnMX83c+cPc8bjNj7KwL2xrdNQQP Qg4RNufESQrGDY3lrm1TYSfww2HwLHZifS+SAbm8dwkmP3w8zEe1i5zmlwSgqXOc+Pg7PY0B/1wA9 AytwoUOWjzSAssFdGRUYisFAIvUL2hz/a0jlBxgFJiF6zUyBmTrzq7PSKq5Mvb9eSUgQguKHIAD8O xnRTs4ersgFo6g==; Date: Mon, 16 Sep 2024 21:43:50 +0300 Message-Id: <8634lzcuc9.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> In-Reply-To: <CALDnm50eujnBd7nrUJWHKbcmtZkmp52Z7kNHGUOnfvMSEb4hmQ@HIDDEN> (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Mon, 16 Sep 2024 19:39:03 +0100) Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> <86a5g7cvnx.fsf@HIDDEN> <CALDnm50eujnBd7nrUJWHKbcmtZkmp52Z7kNHGUOnfvMSEb4hmQ@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73280 Cc: brownts@HIDDEN, monnier@HIDDEN, 73280 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: João Távora <joaotavora@HIDDEN> > Date: Mon, 16 Sep 2024 19:39:03 +0100 > Cc: Troy Brown <brownts@HIDDEN>, monnier@HIDDEN, 73280 <at> debbugs.gnu.org > > On Mon, Sep 16, 2024 at 7:15 PM Eli Zaretskii <eliz@HIDDEN> wrote: > > > I'd like to think that in a not-so-distant future, _everyone_ will > > guess that. Why not? it makes perfect sense to me. > > I mean, we can fix this one if we really want to. Or make a separate > entry just for sh-mode. In fact the user can do that if she is very > bothered by this: this is defcustom after all. I must say I don't find > any compelling arguments to worry much about this bug, except > that maybe some note in the documentation could be > added. Fixing documentation is fine by me, thanks.
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 18:38:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 14:38:59 2024 Received: from localhost ([127.0.0.1]:53247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqGcl-0000YJ-GW for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 14:38:59 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:46511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sqGcj-0000Y6-Pg for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 14:38:58 -0400 Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3e03a5ed4d7so1921643b6e.1 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 11:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726511858; x=1727116658; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6CfiOorabT+NlSqsScjB4xJ11al4cFI0Hhq4Eds44ow=; b=IQ+gtKtD9pzjsUhQUFPu/6nz0GPTQXuL5Yb0EuoNvlIcFeffOFAbeVXL+MRiIuZCaI sJw2AOXAcNMUzpKQPA+D+42Uhz9N850bFM86Xq7/BXtj+lMukAcL4IW55YJ6CMRex2F0 1gWaBSVyA+ZhDjLuzRqBGT7AvTiQQ4JXnnmJOxklN9hQ/PHG/EiLoW9WYJjpYgY6Gt+O yqW23sfIDD6brLNiE777MMMugSGCN3Tyn2o5q0NYt8y2b6n58yiGSK8yI1kGskpF7Lsp PEWfwxkXO8hGv3SVGMYahb+sxJRJtzldyFl7Y3CXWQN+U8XGPfQTpvdqh0CQqbEcbNah nkXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726511858; x=1727116658; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6CfiOorabT+NlSqsScjB4xJ11al4cFI0Hhq4Eds44ow=; b=B0Wx+aPljkT/nRiWpa0KIy259SdlBs27pRPKqZetmjwIyEhZUkz7F4y4CWQVAACCEd 6Ydlj1oitknNJVqWp/zIJuw/+NQ0vhZ8h02FUGscURxHKviUUDYlKdLOE3GeJ1risQ2H f5OwYo//Xhlgm31hF2OxyDBnxSkCV4pumjS8nrkUdzj5L9rbwko4o7SPcHSeTKWjm8yj XqhoruwSgqudYNeGaF91v9AWE5QpbSgmyH9g4PceYcuH0XhXkTYCmHNLZN9i+Yc/e8jw H239IkMURhzwD9rTHz0rsiggSYI0uMpn8wxadZAj97f2XHmBWmjBIygFRtKb1tnLnctX 0q2w== X-Forwarded-Encrypted: i=1; AJvYcCXxjMxGGgL1z74yUb4BM8rXKQZv1LgbTlph8aa+dlxFwK1HxSSfs3qDpWo3uM2TfVPHs3PCgg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyLHhWtW1XArCXoo1mS99jlBNPDFDcN2tvxGbpXV8XiUPti6Ss1 MRSjSUXykSGoZHzJz+a0evPORugMcYDLGv+Mr2wqMGEQdJYbtoZAR90m2sf2SCGyNpD+5lciuux eE5rw3ulLLELnS5aUfJnOhjKDR/w= X-Google-Smtp-Source: AGHT+IH9NpGO6sAV800OZT0zxrtm73oNp5DM5haIWHzHZi/F3PVHVaHKId1U23sUvu03zEFfh/9RMq5E7Nr/UXNLHRg= X-Received: by 2002:a05:6808:3994:b0:3e0:4211:1b93 with SMTP id 5614622812f47-3e071b14fe3mr9851398b6e.39.1726511858444; Mon, 16 Sep 2024 11:37:38 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> <86a5g7cvnx.fsf@HIDDEN> In-Reply-To: <86a5g7cvnx.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Mon, 16 Sep 2024 19:39:03 +0100 Message-ID: <CALDnm50eujnBd7nrUJWHKbcmtZkmp52Z7kNHGUOnfvMSEb4hmQ@HIDDEN> Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73280 Cc: Troy Brown <brownts@HIDDEN>, monnier@HIDDEN, 73280 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Mon, Sep 16, 2024 at 7:15=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > I'd like to think that in a not-so-distant future, _everyone_ will > guess that. Why not? it makes perfect sense to me. I mean, we can fix this one if we really want to. Or make a separate entry just for sh-mode. In fact the user can do that if she is very bothered by this: this is defcustom after all. I must say I don't find any compelling arguments to worry much about this bug, except that maybe some note in the documentation could be added. Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 18:15:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 14:15:39 2024 Received: from localhost ([127.0.0.1]:53230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqGGB-0007nr-BD for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 14:15:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sqGG9-0007nc-Bp for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 14:15:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sqGFp-0007dp-DM; Mon, 16 Sep 2024 14:15:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YFSVj6C3wrVno7WFkWK89dDiBWcA705XGEpemwIr1Xo=; b=EthD5MYtcppx OckQ4cF+wXQK8J0keaxFHmVXz8C3laxodVrSY9vA1d+JhqjIM9OxtsVko+2m5CmZB3GQ6Hrb6AqAK VWnok+HhNujA1Z/UKUNNRN6P46AgnWoAHAahJ+aciaXX+FqyiZ4mbu6DH1ZASxyUp2Wll4dTMf6p3 hDaUtRWSpwUDIOwbIDfId507N4fQF28G+MsITtLxGkEa6cpCKnrSIhcmGIadTFXMqT70LlwlZoNGm UE8PZUvk3zaCWZybGlhuiCxbT6nGWaXcnsB9vVZIEC6JwG4XuQIgV76ymJPSAgccakW61CtqgjNH/ q1a62QLzBWWs84FFTu8w/w==; Date: Mon, 16 Sep 2024 21:15:14 +0300 Message-Id: <86a5g7cvnx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Troy Brown <brownts@HIDDEN> In-Reply-To: <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> (message from Troy Brown on Mon, 16 Sep 2024 13:07:15 -0400) Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73280 Cc: 73280 <at> debbugs.gnu.org, joaotavora@HIDDEN, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Troy Brown <brownts@HIDDEN> > Date: Mon, 16 Sep 2024 13:07:15 -0400 > Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 73280 <at> debbugs.gnu.org > > > Is there a downside to mentioning a major mode you don't > > actually use in your .dir-locals.el, Troy? > > > > I would say the major downside is that it is not intuitive at all. With the emergence of the *-ts-mode modes, we need to adjust our intuition. We decided that having foo-mode settings cover foo-ts-mode as well as much as possible is an advantage, not a disadvantage. So our intuition needs to follow suit. > It's not consistent with how directory-local variables behave. I disagree. Certain settings in .dir-locals are completely global, which is even more radical than this case. Having to specify a setting once for several related modes is a Good Thing, IMO. > I don't think I'd agree with the first mode being representative, it > seems somewhat arbitrary. For instance, in order to change > eglot-workspace-configuration for "sh-mode", you have to set the > configuration in .dir-locals.el for "bash-ts-mode"...who would've > guessed this? I'd like to think that in a not-so-distant future, _everyone_ will guess that. Why not? it makes perfect sense to me.
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 17:07:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 13:07:50 2024 Received: from localhost ([127.0.0.1]:53182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqFCY-0003p0-Be for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 13:07:50 -0400 Received: from mail-lj1-f182.google.com ([209.85.208.182]:47469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy.s.brown@HIDDEN>) id 1sqFCW-0003oj-Co for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 13:07:49 -0400 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2f75b13c2a8so52567781fa.3 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 10:07:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726506448; x=1727111248; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3an15VdY5qgI6oHqcfzK/k+INAxPQRzttr98l1yMwzc=; b=q4a1IRqN4tl2Dd0tNRqSDjftJFzKnjs7ksE2StYf4O+HCYmgY1Ao+xsnSL3mA64q09 GWccB4IXR5APQXMQ5VRrRoI1Alw/NkS6LKFAKZb1ehsKchfTO7DO5Zd6oobiKvkt1xIT 0RepklkN1MzC1ktDybcFaXLL61Me/IOEzqv+FxpMB8V1hMw4ZxzmgvQ0EjmnBFlAXr41 NnnZuFqdDywWDRzP9/0lkfmCms2KjUgnaNLsfZH+GYYlEjduX1sYhHbV+9jt5qSsYWk/ oTuKNuegpupEbhiFKPcc0gh/kX42KLPW+mMBJKwz5Ei2Zt5uZ3sbZ+RgGP8GIVFIFl8F b1wg== X-Forwarded-Encrypted: i=1; AJvYcCWHjPhGor6GBk6Iusq4yIiRY2NyZOGQ3fhseQ7vRscR+IPQYWSeTKHtIYiy5DPtoyUfDtm2ww==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywn9+FUavWCdAfFFN77CaOAMiwDdrkDS0e9T2q0DbK5G/JyJpCF I5ObhsNL1Mv6DJ82DTy12Ee1fmUl6R+k4dLeMXSgvqRe94HA3uVeNMB+kSV2A9Y= X-Google-Smtp-Source: AGHT+IESdBY+I76iP4IjkOWI8krl9HDj+WrpMcgFZT4ocLXYUUYcsE+d352skga77TqWoO6l8FTewg== X-Received: by 2002:a05:651c:1990:b0:2ef:2b06:e554 with SMTP id 38308e7fff4ca-2f787dbf3eemr89079721fa.15.1726506447310; Mon, 16 Sep 2024 10:07:27 -0700 (PDT) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb8c143sm2787902a12.68.2024.09.16.10.07.26 for <73280 <at> debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2024 10:07:26 -0700 (PDT) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5c4226a56a8so3953111a12.2 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 10:07:26 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUAdjKpDPPLZKCg9oCjq/OPI1Eaeb87mS2QJpeTCmUtxUi9JyTIrPT01jfieVb+CMg+VQ4Q1g==@debbugs.gnu.org X-Received: by 2002:a05:6402:388e:b0:5c0:c6ab:7c0f with SMTP id 4fb4d7f45d1cf-5c413e4c6b4mr14044712a12.23.1726506446398; Mon, 16 Sep 2024 10:07:26 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> In-Reply-To: <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> From: Troy Brown <brownts@HIDDEN> Date: Mon, 16 Sep 2024 13:07:15 -0400 X-Gmail-Original-Message-ID: <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> Message-ID: <CABvCZ415yyzEEjvW4fKT86Nv_HWysrA03EYJBSLkNkuEohXbuw@HIDDEN> Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 73280 Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 73280 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) On Mon, Sep 16, 2024 at 9:48=E2=80=AFAM Jo=C3=A3o T=C3=A1vora <joaotavora@g= mail.com> wrote: > > On Mon, Sep 16, 2024 at 12:38=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wro= te: > > > Jo=C3=A3o and Stefan, any comments? > > > > FWIW, I'd rather think this is a feature, since users don't need > > separate Eglot settings for ada-mode and ada-ts-mode. But maybe I'm > > missing something. > > You didn't miss that much. This is half-feature, half > headache-I-didn't-want-to-worry-about. So I put int the 'car' > on purpose. The first of the modes listed in a e-s-programs entry > is usually the most representative one of the language, more or less. > > Is there a downside to mentioning a major mode you don't > actually use in your .dir-locals.el, Troy? > I would say the major downside is that it is not intuitive at all. It's not consistent with how directory-local variables behave. When I saw that the variable was set locally in my buffer but that the configuration wasn't actually applied to the server, I had to dig into this and understand what was going on. I have to imagine anyone else using this would be just as stumped as I was when it wasn't working. I don't think I'd agree with the first mode being representative, it seems somewhat arbitrary. For instance, in order to change eglot-workspace-configuration for "sh-mode", you have to set the configuration in .dir-locals.el for "bash-ts-mode"...who would've guessed this? Just looking through the lists of modes corresponding to the same server, I don't think people would normally make this connection, and the fact that it doesn't work the same way that directory-local variables do, makes it even more unexpected and confusing. What about having eglot--workspace-configuration-plist cycle through the list of modes for the server until it finds a non-nil eglot-workspace-configuration, or has scanned them all? This would seem like a better approach since it will at least find a configuration if one exists, rather than ignoring an existing configuration. I don't know if that would be considered too CPU intensive or not. It's still not the same behavior as a directory local variable, but I think it would be an improvement over the current behavior.
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 13:49:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 09:49:54 2024 Received: from localhost ([127.0.0.1]:51358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sqC70-0000sd-Al for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 09:49:54 -0400 Received: from mail-oo1-f42.google.com ([209.85.161.42]:47524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1sqC6y-0000sO-UZ for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 09:49:53 -0400 Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5df9433ac0cso2223372eaf.3 for <73280 <at> debbugs.gnu.org>; Mon, 16 Sep 2024 06:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726494514; x=1727099314; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=10iV/auVLL8CDoDTH8MP5AXStuvr8ijQekSLmYuiJV8=; b=UOmH6cHMTbdPjjjHxGmx1mCqQWudGCmugcWDd4r6acsNo3nNBwjEReoiwb8UKb0dZD UedRRGpIPPgJyPhyiZaPX9bxDnbP72uiQLpNrcxJHCVXJ2hWjxfP5zbTTUk9BaMRAeDK alNi1/gwZm1fXMQmawJxN13Y+1TDHkW5A2SkZPs36PkI5n93WAeEOXvHs4l9n8OofsAx kcvhAITn4C4uUzCvE9yrF52I6Bi3Fz8u+HIfddKOj0zfAHEBEpvhhy1YwanRtc/YO5Q5 igodTONGdqmWSRR/c8/eWCBxktXCdgFfBLcB8vtSe+WBBfZe94yp4VYuI0qxdhzQMhCn 1w9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726494514; x=1727099314; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=10iV/auVLL8CDoDTH8MP5AXStuvr8ijQekSLmYuiJV8=; b=T7k3fQQLZQuhQpv5+L0F2gNnlk4U8DZ6sx+IpEx+5pw6y/smNWeOxK6DrMEKwZGU/8 i8GBlHfEKLqfa/IsMGgIByavMHX8HXho3OV7t1AbiIpmlhgJgKVLOzOmzI6877DYm1Hd jMJuOiccK1RXnByk9rn1qXEJck9+QjzizeN3OliXbbmxjlbL6bZPHyOt7QhnFAHYedqw n/QpUiRpu/1dxPDPYaCbNXHJ0G0chMD9sdOwVrnNcg/zj+ToDpf+i2Wa31Z7SjPohV2G 4ZRzaGtH7t+iz8wPK3ds7LbW/qgHzV4Dp/Gnos+yPiROosjpMr37MoqEzc951/+8OZt3 Ww7w== X-Forwarded-Encrypted: i=1; AJvYcCWbbLnex2BI40d1np+EgF4I2RIryG+WEmGGxvTs9r78EsqxHIc9MwFaM9lyvXkPUalHWgMx1g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwivyP9wFF/trbPeaZzkFcuZI38UdFo3v0eIpGjvkjW8Kbt63Uv mvnR/aZVKS64lh1dz24fcNm/H5fgERo++RCM+vHYiV8yMaXp/oOBTegFTPmW7Uykx5z8V2b1OnA I7e3ATUkpp1HCop1aa1C8jTYU1dY= X-Google-Smtp-Source: AGHT+IHtrvjWK2gywDRnslUNha/HllfxcUFIAnq9Tp440R+gbLQFxOlG93hvLhyb/cGueX1UngH7cksfanGDTvbxzC0= X-Received: by 2002:a05:6820:221c:b0:5e1:dd09:153b with SMTP id 006d021491bc7-5e201454b7cmr6887713eaf.7.1726494513570; Mon, 16 Sep 2024 06:48:33 -0700 (PDT) MIME-Version: 1.0 References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN> <86ttefde1d.fsf@HIDDEN> In-Reply-To: <86ttefde1d.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Mon, 16 Sep 2024 14:48:22 +0100 Message-ID: <CALDnm51-QMPxisdTk8FCaVrgQyQHfvWyg0p1-9Cky5ARco=GjQ@HIDDEN> Subject: Re: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 73280 Cc: Troy Brown <brownts@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 73280 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Mon, Sep 16, 2024 at 12:38=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote= : > Jo=C3=A3o and Stefan, any comments? > > FWIW, I'd rather think this is a feature, since users don't need > separate Eglot settings for ada-mode and ada-ts-mode. But maybe I'm > missing something. You didn't miss that much. This is half-feature, half headache-I-didn't-want-to-worry-about. So I put int the 'car' on purpose. The first of the modes listed in a e-s-programs entry is usually the most representative one of the language, more or less. Is there a downside to mentioning a major mode you don't actually use in your .dir-locals.el, Troy? Jo=C3=A3o PS: This is again because Emacs doesn't have a great way to refer to "language" or to associate languages to modes and vice-versa. I certainly don't want to reopen that can of worms.
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.
Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 11:39:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 16 07:39:04 2024
Received: from localhost ([127.0.0.1]:51183 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sqA4N-0001zZ-RK
for submit <at> debbugs.gnu.org; Mon, 16 Sep 2024 07:39:04 -0400
Received: from eggs.gnu.org ([209.51.188.92]:53692)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1sqA4K-0001z3-DO
for 73280 <at> debbugs.gnu.org; Mon, 16 Sep 2024 07:39:01 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1sqA41-0004li-AV; Mon, 16 Sep 2024 07:38:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=VLONm7aQPB+7uCOpOo5Cxnf0CChn5qRAkfGxW5BI06k=; b=VcO6pJnKP5zQe8I8tosv
cXFjMzFOyKcY4+UnBPNL9NMIpSZnSHd4ZB1FC2wTB22LDwYrRXG704xPydEOiwHQ9RWRef1Qv5+H4
QDTzEQSwJPaCf9kO5uGMFvLR3s+xDRAjKojWLSnoXp+NEQXuKwCPlWzJDjD/BqdpINPaF4kzdRm7Y
fJOnZskxh+WEBv7go+iLbc/3eO5c3NXANNp1KLkSnrDcfi18Lp7nUvi5/7TQnV00WE8DAJWQaUEgM
Xs8FS2OHv5ikd+S6i2z24uBNy2nKeEwS8xf8k+MRS5G3zzRJD94zNuDanj6MB5e2ICct5jbTrYFU6
Zs3L9inwUfjGqA==;
Date: Mon, 16 Sep 2024 14:38:22 +0300
Message-Id: <86ttefde1d.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Troy Brown <brownts@HIDDEN>,
Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN>
(message from Troy Brown on Sun, 15 Sep 2024 15:54:00 -0400)
Subject: Re: bug#73280: 30.0.90;
Eglot: eglot-workspace-configuration might not be found in
.dir-locals.el
References: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73280
Cc: joaotavora@HIDDEN, 73280 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: João Távora <joaotavora@HIDDEN>
> From: Troy Brown <brownts@HIDDEN>
> Date: Sun, 15 Sep 2024 15:54:00 -0400
>
> I discovered that the workspace configuration specified in a
> `.dir-locals.el` file was not being used if the mode is not listed
> first in `eglot-server-programs`. Consider a scenario where the
> current buffer's major mode is `ada-ts-mode` and Eglot is enabled in
> that buffer. Also, consider the following `.dir-locals.el` in a
> parent directory containing the file of the buffer.
>
> ```elisp
> ((ada-ts-mode . ((eglot-workspace-configuration . (:ada (:projectFile
> "src/gtkada.gpr"))))))
> ```
>
> If I then execute `M-x eglot-show-workspace-configuration RET` in that
> `ada-ts-mode` buffer, the "*EGLOT workspace configuration*" buffer
> opens and displays a value of "null".
>
> ```json
> null
> ```
>
> However, if I change the mode in `.dir-locals.el` from `ada-ts-mode`
> to `ada-mode` and repeat the "show configuration" command, I see the
> configuration as expected, even though the major mode is
> `ada-ts-mode`.
>
> ```json
> {
> "ada": {
> "projectFile": "src/gtkada.gpr"
> }
> }
> ```
>
> I believe this is due to the following statement in
> `eglot--workspace-configuration-plist`, which sets the major mode in
> the temporary buffer before calling
> `hack-dir-local-variables-non-file-buffer`:
>
> ```elisp
> ;; Set the major mode to be the first of the managed
> ;; modes. This is the one the user started eglot in.
> (setq major-mode (car (eglot--major-modes server)))
> ```
>
> The comment indicates that the major mode that Eglot was started in
> will be listed first, but that is not the case. If I execute `M-:
> (eglot--major-modes (eglot-current-server))` from the `ada-ts-mode`
> buffer, the value is `(ada-mode ada-ts-mode)`, which is the same order
> they are listed in `eglot-server-programs`, and is not ordered based
> on the major mode of the buffer where Eglot was started.
> Additionally, `eglot--connect` which populates `eglot--languages`
> doesn't change the order from how they are listed in
> `eglot-server-programs`.
João and Stefan, any comments?
FWIW, I'd rather think this is a feature, since users don't need
separate Eglot settings for ada-mode and ada-ts-mode. But maybe I'm
missing something.
bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 15 Sep 2024 19:54:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 15 15:54:35 2024
Received: from localhost ([127.0.0.1]:50553 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1spvKM-0000yI-Pg
for submit <at> debbugs.gnu.org; Sun, 15 Sep 2024 15:54:35 -0400
Received: from lists.gnu.org ([209.51.188.17]:45422)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <troy.s.brown@HIDDEN>) id 1spvKK-0000yA-Hp
for submit <at> debbugs.gnu.org; Sun, 15 Sep 2024 15:54:33 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <troy.s.brown@HIDDEN>)
id 1spvK5-0002xb-0K
for bug-gnu-emacs@HIDDEN; Sun, 15 Sep 2024 15:54:18 -0400
Received: from mail-ed1-f52.google.com ([209.85.208.52])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <troy.s.brown@HIDDEN>)
id 1spvK3-0004ls-5k
for bug-gnu-emacs@HIDDEN; Sun, 15 Sep 2024 15:54:16 -0400
Received: by mail-ed1-f52.google.com with SMTP id
4fb4d7f45d1cf-5c24c92f699so3977712a12.2
for <bug-gnu-emacs@HIDDEN>; Sun, 15 Sep 2024 12:54:14 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1726430053; x=1727034853;
h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=woLfxDnR/saDsDopAlMPwQwCjDy+3oCBnrhohvTidiE=;
b=aGN3fF6srsikUg5BkjqIPVKa+6Iv8CKxojNcFOXFhjYJ48xcGVJFuxnotXlqD3yIHz
HdANfxufKJkUQFpKZRZ+1Xyz0zPy160XZz+7akePhPHw9kROpobnhrw30VfLd2t1UfHV
CcEe8CSZROFgIDbMwfmM8G7/vlKiW7QNuyIcoofQyCE8iDQrRWa7p8Qe0g05k0B+Dun8
zheV8gYzivmqOPFZDeU6XcNoq10mI4GUqQeI7rE+4Zdy2ZfR0J+OpOKdB4ls8oLfDJb9
U23MwaB9kMwTEXIjx9MGmj7OmsK2C6pHsL3Pd9ZTPh+ykDNx6uVD6yhseztSbUFbIKWm
u3Aw==
X-Gm-Message-State: AOJu0Ywj092c04YZFw/8HFxMSCqc8Us+EVRFhNJC1tJgQemyJtYibpWD
lrNFe968OfDM+07/v/o311QJj1WOrhB5P1VRzFrkV0xWnaWhpretKqO8JbfLTk4=
X-Google-Smtp-Source: AGHT+IFgVRb7NQjmxflJyAQG1GS0G4i00aZc6w+NN89IKO8w1RWrXopMAVmABtRGEnVP9Dj6Vy8rFA==
X-Received: by 2002:a50:eac9:0:b0:5c0:aad3:c8fc with SMTP id
4fb4d7f45d1cf-5c413e57b3dmr8278067a12.30.1726430052026;
Sun, 15 Sep 2024 12:54:12 -0700 (PDT)
Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com.
[209.85.208.52]) by smtp.gmail.com with ESMTPSA id
4fb4d7f45d1cf-5c42bb49770sm1907505a12.12.2024.09.15.12.54.11
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sun, 15 Sep 2024 12:54:11 -0700 (PDT)
Received: by mail-ed1-f52.google.com with SMTP id
4fb4d7f45d1cf-5c24c92f699so3977689a12.2
for <bug-gnu-emacs@HIDDEN>; Sun, 15 Sep 2024 12:54:11 -0700 (PDT)
X-Received: by 2002:a05:6402:1d53:b0:5c2:7570:3a2a with SMTP id
4fb4d7f45d1cf-5c413e1ee8cmr11872350a12.17.1726430051345; Sun, 15 Sep 2024
12:54:11 -0700 (PDT)
MIME-Version: 1.0
From: Troy Brown <brownts@HIDDEN>
Date: Sun, 15 Sep 2024 15:54:00 -0400
X-Gmail-Original-Message-ID: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN>
Message-ID: <CABvCZ40Sva9Mdhf1mw+uuOerQ0L1ERW-7W6itrBK5k1sivNafQ@HIDDEN>
Subject: 30.0.90; Eglot: eglot-workspace-configuration might not be found in
.dir-locals.el
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=209.85.208.52;
envelope-from=troy.s.brown@HIDDEN; helo=mail-ed1-f52.google.com
X-Spam_score_int: -26
X-Spam_score: -2.7
X-Spam_bar: --
X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9,
FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001,
HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001,
RCVD_IN_MSPIKE_H2=-1.048, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
Cc: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
I discovered that the workspace configuration specified in a
`.dir-locals.el` file was not being used if the mode is not listed
first in `eglot-server-programs`. Consider a scenario where the
current buffer's major mode is `ada-ts-mode` and Eglot is enabled in
that buffer. Also, consider the following `.dir-locals.el` in a
parent directory containing the file of the buffer.
```elisp
((ada-ts-mode . ((eglot-workspace-configuration . (:ada (:projectFile
"src/gtkada.gpr"))))))
```
If I then execute `M-x eglot-show-workspace-configuration RET` in that
`ada-ts-mode` buffer, the "*EGLOT workspace configuration*" buffer
opens and displays a value of "null".
```json
null
```
However, if I change the mode in `.dir-locals.el` from `ada-ts-mode`
to `ada-mode` and repeat the "show configuration" command, I see the
configuration as expected, even though the major mode is
`ada-ts-mode`.
```json
{
"ada": {
"projectFile": "src/gtkada.gpr"
}
}
```
I believe this is due to the following statement in
`eglot--workspace-configuration-plist`, which sets the major mode in
the temporary buffer before calling
`hack-dir-local-variables-non-file-buffer`:
```elisp
;; Set the major mode to be the first of the managed
;; modes. This is the one the user started eglot in.
(setq major-mode (car (eglot--major-modes server)))
```
The comment indicates that the major mode that Eglot was started in
will be listed first, but that is not the case. If I execute `M-:
(eglot--major-modes (eglot-current-server))` from the `ada-ts-mode`
buffer, the value is `(ada-mode ada-ts-mode)`, which is the same order
they are listed in `eglot-server-programs`, and is not ordered based
on the major mode of the buffer where Eglot was started.
Additionally, `eglot--connect` which populates `eglot--languages`
doesn't change the order from how they are listed in
`eglot-server-programs`.
Troy Brown <brownts@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#73280; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.