Package: guix-patches;
Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Date: Mon, 16 Sep 2024 15:55:01 UTC
Severity: normal
Tags: patch
Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73301 in the body.
You can then email your comments to 73301 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
View this report as an mbox folder, status mbox, maintainer mbox
liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, vivien <at> planete-kraus.eu, guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Mon, 16 Sep 2024 15:55:01 GMT) Full text and rfc822 format available.Liliana Marie Prikler <liliana.prikler <at> gmail.com>:liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, vivien <at> planete-kraus.eu, guix-patches <at> gnu.org.
(Mon, 16 Sep 2024 15:55:01 GMT) Full text and rfc822 format available.Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: guix-patches <at> gnu.org Subject: [PATCH 0/4] Post-GLib bumps. Date: Sun, 15 Sep 2024 20:34:21 +0200
Hi Guix, With the recent bump to GLib 2.80, telepathy-glib and network-manager no longer build. Additionally, gtk and libadwaita have new major versions, that we might want to have in this iteration already. Cheers Liliana Marie Prikler (4): gnu: telepathy-glib: Fix build. gnu: network-manager: Update to 1.48.2. gnu: gtk: Update to 4.16.1. gnu: libadwaita: Update to 1.6.0. gnu/local.mk | 2 +- gnu/packages/glib.scm | 1 + gnu/packages/gnome.scm | 11 +++--- gnu/packages/gtk.scm | 34 +++++-------------- .../patches/network-manager-meson.patch | 21 ------------ .../patches/telepathy-glib-fix-test.patch | 31 +++++++++++++++++ 6 files changed, 46 insertions(+), 54 deletions(-) delete mode 100644 gnu/packages/patches/network-manager-meson.patch create mode 100644 gnu/packages/patches/telepathy-glib-fix-test.patch base-commit: 3c3baffeb2861144036d057e7c6fbc2202d0a3f4 -- 2.46.0
liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, vivien <at> planete-kraus.eu_, guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Mon, 16 Sep 2024 15:58:01 GMT) Full text and rfc822 format available.Message #8 received at 73301 <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: 73301 <at> debbugs.gnu.org Subject: [PATCH 1/4] gnu: telepathy-glib: Fix build. Date: Sat, 14 Sep 2024 11:54:46 +0200
* gnu/packages/patches/telepathy-glib-fix-test.patch: New file.
* gnu/packages/glib.scm (telepathy-glib)[patches]: Use it here.
* gnu/local.mk (dist_patch_DATA): Register it here.
---
gnu/local.mk | 1 +
gnu/packages/glib.scm | 1 +
.../patches/telepathy-glib-fix-test.patch | 31 +++++++++++++++++++
3 files changed, 33 insertions(+)
create mode 100644 gnu/packages/patches/telepathy-glib-fix-test.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index aba8bf078a..b5260ff7ec 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -2189,6 +2189,7 @@ dist_patch_DATA = \
%D%/packages/patches/texinfo-5-perl-compat.patch \
%D%/packages/patches/telegram-desktop-allow-disable-libtgvoip.patch \
%D%/packages/patches/telegram-purple-adjust-test.patch \
+ %D%/packages/patches/telepathy-glib-fix-test.patch \
%D%/packages/patches/teuchos-remove-duplicate-using.patch \
%D%/packages/patches/texi2html-document-encoding.patch \
%D%/packages/patches/texi2html-i18n.patch \
diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index 72bcbdcc61..d3731f1167 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -1162,6 +1162,7 @@ (define telepathy-glib
(string-append
"https://telepathy.freedesktop.org/releases/telepathy-glib/"
"telepathy-glib-" version ".tar.gz"))
+ (patches (search-patches "telepathy-glib-fix-test.patch"))
(sha256
(base32
"1w3kja8j3gz2apal79bi3hq44xk5g78aphrqbw983l6df7bp98xh"))))
diff --git a/gnu/packages/patches/telepathy-glib-fix-test.patch b/gnu/packages/patches/telepathy-glib-fix-test.patch
new file mode 100644
index 0000000000..515c31eec9
--- /dev/null
+++ b/gnu/packages/patches/telepathy-glib-fix-test.patch
@@ -0,0 +1,31 @@
+From aa858698d7ede76b3b4c825ca14b8061c24f14e1 Mon Sep 17 00:00:00 2001
+From: Mamoru TASAKA <mtasaka <at> fedoraproject.org>
+Date: Mon, 4 Sep 2023 17:56:15 +0900
+Subject: [PATCH] test: make test-cm accepted with newer GLib
+
+With GLib 2.77.3, the key value "foo\;bar" is no longer accepted
+with g_key_file_get_string and it returns null string result.
+
+Modify key value in test file to get it accepted by new GLib.
+---
+ tests/dbus/telepathy/managers/test_manager_file.manager | 6 ++----
+ 1 file changed, 2 insertions(+), 4 deletions(-)
+
+diff --git a/tests/dbus/telepathy/managers/test_manager_file.manager b/tests/dbus/telepathy/managers/test_manager_file.manager
+index 426ad4a7e..bdb3f90f1 100644
+--- a/tests/dbus/telepathy/managers/test_manager_file.manager
++++ b/tests/dbus/telepathy/managers/test_manager_file.manager
+@@ -79,11 +79,9 @@ default-triply-escaped-semicolon-in-list = list\\\;of;misc;
+ param-empty-list = as
+ default-empty-list =
+
+-# this is probably technically a Desktop Entry spec violation?
+-# we should be permissive, interpreting this as either "foo\;bar" or "foo;bar"
+-# seems reasonable
++# the value is "foo\\;bar"
+ param-escaped-semicolon = s
+-default-escaped-semicolon = foo\;bar
++default-escaped-semicolon = foo\\;bar
+
+ # all the other types
+ param-object = o
\ No newline at end of file
--
2.46.0
liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, vivien <at> planete-kraus.eu_, guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Mon, 16 Sep 2024 15:58:02 GMT) Full text and rfc822 format available.Message #11 received at 73301 <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: 73301 <at> debbugs.gnu.org Subject: [PATCH 2/4] gnu: network-manager: Update to 1.48.2. Date: Sat, 14 Sep 2024 14:17:33 +0200
* gnu/packages/gnome.scm (network-manager): Update to 1.48.2.
[source]: Drop “network-manager-meson.patch”.
* gnu/packages/patches/network-manager-meson.patch: Delete file.
* gnu/local.mk (dist_patch_DATA): Unregister it.
---
gnu/local.mk | 1 -
gnu/packages/gnome.scm | 7 +++----
.../patches/network-manager-meson.patch | 21 -------------------
3 files changed, 3 insertions(+), 26 deletions(-)
delete mode 100644 gnu/packages/patches/network-manager-meson.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index b5260ff7ec..eaba0e129e 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1797,7 +1797,6 @@ dist_patch_DATA = \
%D%/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch \
%D%/packages/patches/ngircd-handle-zombies.patch \
%D%/packages/patches/network-manager-plugin-path.patch \
- %D%/packages/patches/network-manager-meson.patch \
%D%/packages/patches/nginx-socket-cloexec.patch \
%D%/packages/patches/nickle-man-release-date.patch \
%D%/packages/patches/nnpack-system-libraries.patch \
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9cecc3c044..0857d46a97 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8462,17 +8462,16 @@ (define-public network-manager
(name "network-manager")
;; Note: NetworkManager still follows the odd/even major version number
;; for development/stable releases scheme; be sure to use a stable one.
- (version "1.44.0")
+ (version "1.48.2")
(source (origin
(method url-fetch)
(uri (string-append "mirror://gnome/sources/NetworkManager/"
(version-major+minor version) "/"
"NetworkManager-" version ".tar.xz"))
- (patches (search-patches "network-manager-plugin-path.patch"
- "network-manager-meson.patch"))
+ (patches (search-patches "network-manager-plugin-path.patch"))
(sha256
(base32
- "17zvg63jjbqdw8xyc6narirvvbbv7micbn0j7dmq0bqqgmihkjpd"))))
+ "18c6bbfiln03fwksw52ir6w6hxg10c36zl7m647dykcncb67341x"))))
(build-system meson-build-system)
(outputs '("out"
"doc")) ; 8 MiB of gtk-doc HTML
diff --git a/gnu/packages/patches/network-manager-meson.patch b/gnu/packages/patches/network-manager-meson.patch
deleted file mode 100644
index 1056d40ede..0000000000
--- a/gnu/packages/patches/network-manager-meson.patch
+++ /dev/null
@@ -1,21 +0,0 @@
-Since libnm-wwan.so is not just a loadable module but also a shared library
-that some plugin links against, build it as a shared library while avoiding
-'-Wl,--no-undefined':
-
- https://github.com/mesonbuild/meson/issues/9492#issuecomment-973117289
-
-diff --git a/src/core/devices/wwan/meson.build b/src/core/devices/wwan/meson.build
-index 37ef738..18ac54f 100644
---- a/src/core/devices/wwan/meson.build
-+++ b/src/core/devices/wwan/meson.build
-@@ -4,8 +4,9 @@ wwan_inc = include_directories('.')
-
- linker_script = join_paths(meson.current_source_dir(), 'libnm-wwan.ver')
-
--libnm_wwan = shared_module(
-+libnm_wwan = shared_library(
- 'nm-wwan',
-+ override_options: ['b_lundef=false'],
- sources: files(
- 'nm-service-providers.c',
- 'nm-modem-broadband.c',
--
2.46.0
liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, vivien <at> planete-kraus.eu_, guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Mon, 16 Sep 2024 15:58:03 GMT) Full text and rfc822 format available.Message #14 received at 73301 <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: 73301 <at> debbugs.gnu.org Subject: [PATCH 3/4] gnu: gtk: Update to 4.16.1. Date: Sun, 15 Sep 2024 00:33:55 +0200
* gnu/packages/gtk.scm (gtk): Update to 4.16.1.
[arguments]<#:configure-flags>: Replace “-Dgtk_doc=…” with
“-Ddocumentation=true”.
<#:test-options>: Add “--no-suite=needs-udmabuf”.
<#:phases>: Adjust patches for failing tests.
[inputs]: Replace wayland-protocols with wayland-protocols-next.
---
gnu/packages/gtk.scm | 34 ++++++++--------------------------
1 file changed, 8 insertions(+), 26 deletions(-)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 8945fb98ae..5733749a72 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -1141,7 +1141,7 @@ (define-public gtk+
(define-public gtk
(package
(name "gtk")
- (version "4.14.5")
+ (version "4.16.1")
(source
(origin
(method url-fetch)
@@ -1149,7 +1149,7 @@ (define-public gtk
(version-major+minor version) "/"
name "-" version ".tar.xz"))
(sha256
- (base32 "0kg286za53qhl6ngw4rrvbpm3q04g30qf2q77sck7c86y2wz4ism"))
+ (base32 "0p11k5afy3g9d6p402zrn9izkypwzlb51y9qanibzyc1sjmiwslj"))
(patches
(search-patches "gtk4-respect-GUIX_GTK4_PATH.patch"))
(modules '((guix build utils)))))
@@ -1166,11 +1166,7 @@ (define-public gtk
"-Dcloudproviders=enabled" ;for cloud-providers support
"-Dtracker=enabled" ;for filechooser search support
"-Dcolord=enabled" ;for color printing support
- #$@(if (%current-target-system)
- ;; If true, gtkdoc-scangobj will try to execute a
- ;; cross-compiled binary.
- '("-Dgtk_doc=false")
- '("-Dgtk_doc=true"))
+ "-Ddocumentation=true"
"-Dman-pages=true")
#:test-options #~(list "--setup=x11" ;defaults to wayland
;; Use the same test options as upstream uses for
@@ -1180,6 +1176,7 @@ (define-public gtk
"--no-suite=flaky"
"--no-suite=headless" ; requires mutter…
"--no-suite=gsk-compare-broadway"
+ "--no-suite=needs-udmabuf"
;; These seem to fail on aarch64, and Debian has
;; also disabled these, see:
;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050075
@@ -1219,29 +1216,14 @@ (define-public gtk
(("[ \t]*'empty-text.node',") "")
(("[ \t]*'testswitch.node',") "")
(("[ \t]*'widgetfactory.node',") "")
- ;; The unaligned-offscreen test fails for unknown reasons, also
- ;; on different distributions (see:
- ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/4889).
- ((" 'unaligned-offscreen',") "")
;; This test, 'gtk:tools / validate', started failing for
;; unknown reasons after updating mesa to 23.3.1 and xorgproto
;; to 2023.2.
((" 'validate',") "")
- ;; XXX: These test failures come newly from 4.14.
- ;; Not all of them are reported upstream yet, but the text nodes
- ;; are mentioned in
- ;; <https://gitlab.gnome.org/GNOME/gtk/-/issues/6647>.
- (("'glyph-subpixel-position',") "")
- (("'subpixel-positioning',") "")
- (("'subpixel-positioning-hidpi-nogl-nocairo',") "")
- (("'text.*\\.node',") "")
- (("'text-mixed-color-colrv1',") ""))
+ ;; XXX: Figure out why this fails and report upstream.
+ ((".*'memorytexture',.*") ""))
(substitute* "testsuite/reftests/meson.build"
- (("[ \t]*'label-wrap-justify.ui',") "")
- ;; The inscription-markup.ui fails due to /etc/machine-id
- ;; related warnings (see:
- ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/5169).
- (("[ \t]*'inscription-markup.ui',") ""))
+ (("[ \t]*'label-wrap-justify.ui',") ""))
;; These tests fail on an Apple M1 (aarch64) with the following errors:
;; - MESA: error: ZINK: failed to choose pdev
;; - libEGL warning: egl: failed to create dri2 screen
@@ -1391,7 +1373,7 @@ (define-public gtk
vulkan-headers
vulkan-loader ;for vulkan graphics API support
wayland ;for wayland display-backend
- wayland-protocols))
+ wayland-protocols-next))
(native-search-paths
(list
(search-path-specification
--
2.46.0
liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, vivien <at> planete-kraus.eu_, guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Mon, 16 Sep 2024 15:58:03 GMT) Full text and rfc822 format available.Message #17 received at 73301 <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: 73301 <at> debbugs.gnu.org Subject: [PATCH 4/4] gnu: libadwaita: Update to 1.6.0. Date: Sun, 15 Sep 2024 00:35:56 +0200
* gnu/packages/gnome.scm (libadwaita): Update to 1.6.0.
---
gnu/packages/gnome.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0857d46a97..e86e6ea475 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13840,7 +13840,7 @@ (define-public ocrfeeder
(define-public libadwaita
(package
(name "libadwaita")
- (version "1.5.2")
+ (version "1.6.0")
(source (origin
(method url-fetch)
(uri (string-append "mirror://gnome/sources/libadwaita/"
@@ -13848,7 +13848,7 @@ (define-public libadwaita
"libadwaita-" version ".tar.xz"))
(sha256
(base32
- "05icswk84kf4pbcybv8j9r9n98q1dgr1m7zn6k72p4dlbh0fxyn9"))))
+ "1lyqvalqc09r4dkgrhpkp01r7c1c0zyf354icc0r375r9j9q7mwy"))))
(build-system meson-build-system)
(arguments
`(#:phases
--
2.46.0
guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Sun, 22 Sep 2024 02:49:02 GMT) Full text and rfc822 format available.Message #20 received at 73301 <at> debbugs.gnu.org (full text, mbox):
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com> To: Liliana Marie Prikler <liliana.prikler <at> gmail.com> Cc: vivien <at> planete-kraus.eu, 73301 <at> debbugs.gnu.org Subject: Re: [bug#73301] [PATCH 3/4] gnu: gtk: Update to 4.16.1. Date: Sun, 22 Sep 2024 11:47:05 +0900
Hi Liliana,
Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> * gnu/packages/gtk.scm (gtk): Update to 4.16.1.
> [arguments]<#:configure-flags>: Replace “-Dgtk_doc=…” with
> “-Ddocumentation=true”.
> <#:test-options>: Add “--no-suite=needs-udmabuf”.
> <#:phases>: Adjust patches for failing tests.
> [inputs]: Replace wayland-protocols with wayland-protocols-next.
> ---
> gnu/packages/gtk.scm | 34 ++++++++--------------------------
> 1 file changed, 8 insertions(+), 26 deletions(-)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index 8945fb98ae..5733749a72 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -1141,7 +1141,7 @@ (define-public gtk+
> (define-public gtk
> (package
> (name "gtk")
> - (version "4.14.5")
> + (version "4.16.1")
> (source
> (origin
> (method url-fetch)
> @@ -1149,7 +1149,7 @@ (define-public gtk
> (version-major+minor version) "/"
> name "-" version ".tar.xz"))
> (sha256
> - (base32 "0kg286za53qhl6ngw4rrvbpm3q04g30qf2q77sck7c86y2wz4ism"))
> + (base32 "0p11k5afy3g9d6p402zrn9izkypwzlb51y9qanibzyc1sjmiwslj"))
> (patches
> (search-patches "gtk4-respect-GUIX_GTK4_PATH.patch"))
> (modules '((guix build utils)))))
> @@ -1166,11 +1166,7 @@ (define-public gtk
> "-Dcloudproviders=enabled" ;for cloud-providers support
> "-Dtracker=enabled" ;for filechooser search support
> "-Dcolord=enabled" ;for color printing support
> - #$@(if (%current-target-system)
> - ;; If true, gtkdoc-scangobj will try to execute a
> - ;; cross-compiled binary.
> - '("-Dgtk_doc=false")
> - '("-Dgtk_doc=true"))
> + "-Ddocumentation=true"
> "-Dman-pages=true")
> #:test-options #~(list "--setup=x11" ;defaults to wayland
> ;; Use the same test options as upstream uses for
> @@ -1180,6 +1176,7 @@ (define-public gtk
> "--no-suite=flaky"
> "--no-suite=headless" ; requires mutter…
> "--no-suite=gsk-compare-broadway"
> + "--no-suite=needs-udmabuf"
> ;; These seem to fail on aarch64, and Debian has
> ;; also disabled these, see:
> ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050075
> @@ -1219,29 +1216,14 @@ (define-public gtk
> (("[ \t]*'empty-text.node',") "")
> (("[ \t]*'testswitch.node',") "")
> (("[ \t]*'widgetfactory.node',") "")
> - ;; The unaligned-offscreen test fails for unknown reasons, also
> - ;; on different distributions (see:
> - ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/4889).
> - ((" 'unaligned-offscreen',") "")
> ;; This test, 'gtk:tools / validate', started failing for
> ;; unknown reasons after updating mesa to 23.3.1 and xorgproto
> ;; to 2023.2.
> ((" 'validate',") "")
> - ;; XXX: These test failures come newly from 4.14.
> - ;; Not all of them are reported upstream yet, but the text nodes
> - ;; are mentioned in
> - ;; <https://gitlab.gnome.org/GNOME/gtk/-/issues/6647>.
> - (("'glyph-subpixel-position',") "")
> - (("'subpixel-positioning',") "")
> - (("'subpixel-positioning-hidpi-nogl-nocairo',") "")
> - (("'text.*\\.node',") "")
> - (("'text-mixed-color-colrv1',") ""))
LGTM so far.
> + ;; XXX: Figure out why this fails and report upstream.
> + ((".*'memorytexture',.*") ""))
Is the above comment just for 'memorytexture' test? I've learnt to be
very explicit in my comments, as when new tests gets disabled, it's how
to track what is being commented about.
(also, I doubt someone will come back to the investigation later, so
this is technical debt on our side -- I'd favor a minimal investigation
with a report upstream if none exist so far).
> (substitute* "testsuite/reftests/meson.build"
> - (("[ \t]*'label-wrap-justify.ui',") "")
> - ;; The inscription-markup.ui fails due to /etc/machine-id
> - ;; related warnings (see:
> - ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/5169).
> - (("[ \t]*'inscription-markup.ui',") ""))
> + (("[ \t]*'label-wrap-justify.ui',") ""))
There's no more comment about why this new test fails. Is it known
upstream?
> ;; These tests fail on an Apple M1 (aarch64) with the following errors:
> ;; - MESA: error: ZINK: failed to choose pdev
> ;; - libEGL warning: egl: failed to create dri2 screen
> @@ -1391,7 +1373,7 @@ (define-public gtk
> vulkan-headers
> vulkan-loader ;for vulkan graphics API support
> wayland ;for wayland display-backend
> - wayland-protocols))
> + wayland-protocols-next))
Instead of using -next things, perhaps we should byte the bullet and
update them in this iteration too?
Using various variants of system means the system closure will be
higher, may cause problems down the line (if the same process attempts
to load two variants library in memory, that would cause issues).
--
Thanks,
Maxim
guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Sun, 22 Sep 2024 02:50:01 GMT) Full text and rfc822 format available.Message #23 received at 73301 <at> debbugs.gnu.org (full text, mbox):
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com> To: Liliana Marie Prikler <liliana.prikler <at> gmail.com> Cc: vivien <at> planete-kraus.eu, 73301 <at> debbugs.gnu.org Subject: Re: [bug#73301] [PATCH 0/4] Post-GLib bumps. Date: Sun, 22 Sep 2024 11:48:14 +0900
Hi Liliana, Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes: > Hi Guix, > > With the recent bump to GLib 2.80, telepathy-glib and network-manager > no longer build. Additionally, gtk and libadwaita have new major > versions, that we might want to have in this iteration already. > > Cheers > > Liliana Marie Prikler (4): > gnu: telepathy-glib: Fix build. > gnu: network-manager: Update to 1.48.2. > gnu: gtk: Update to 4.16.1. > gnu: libadwaita: Update to 1.6.0. Thanks for doing that! All LGTM except for comments posted to 3/4. Feel free to push with these addressed, if possible. Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail> -- Thanks, Maxim
guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Sun, 22 Sep 2024 05:57:02 GMT) Full text and rfc822 format available.Message #26 received at 73301 <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com> Cc: vivien <at> planete-kraus.eu, 73301 <at> debbugs.gnu.org Subject: Re: [bug#73301] [PATCH 0/4] Post-GLib bumps. Date: Sun, 22 Sep 2024 07:55:18 +0200
Am Sonntag, dem 22.09.2024 um 11:48 +0900 schrieb Maxim Cournoyer: > Hi Liliana, > > Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes: > > > Hi Guix, > > > > With the recent bump to GLib 2.80, telepathy-glib and network- > > manager > > no longer build. Additionally, gtk and libadwaita have new major > > versions, that we might want to have in this iteration already. > > > > Cheers > > > > Liliana Marie Prikler (4): > > gnu: telepathy-glib: Fix build. > > gnu: network-manager: Update to 1.48.2. > > gnu: gtk: Update to 4.16.1. > > gnu: libadwaita: Update to 1.6.0. > > Thanks for doing that! All LGTM except for comments posted to 3/4. > > Feel free to push with these addressed, if possible. I did already push them, but it's still gnome-team – meaning I can revise the 3/4 and pseudo-force-push later. Cheers
guix-patches <at> gnu.org:bug#73301; Package guix-patches.
(Sun, 22 Sep 2024 06:02:02 GMT) Full text and rfc822 format available.Message #29 received at 73301 <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com> Cc: vivien <at> planete-kraus.eu, 73301 <at> debbugs.gnu.org Subject: Re: [bug#73301] [PATCH 3/4] gnu: gtk: Update to 4.16.1. Date: Sun, 22 Sep 2024 07:59:34 +0200
Am Sonntag, dem 22.09.2024 um 11:47 +0900 schrieb Maxim Cournoyer:
> > + ;; XXX: Figure out why this fails and report
> > upstream.
> > + ((".*'memorytexture',.*") ""))
>
> Is the above comment just for 'memorytexture' test? I've learnt to
> be very explicit in my comments, as when new tests gets disabled,
> it's how to track what is being commented about.
Yes, that's "this" as in "this test".
> (also, I doubt someone will come back to the investigation later, so
> this is technical debt on our side -- I'd favor a minimal
> investigation with a report upstream if none exist so far).
Sure, but let's not forget that there are webkitgtk rebuilds etc.
stalling further upgrades while we investigate. I think it's fair to
postpone this a little as long as it hits master clean later.
> > (substitute* "testsuite/reftests/meson.build"
> > - (("[ \t]*'label-wrap-justify.ui',") "")
> > - ;; The inscription-markup.ui fails due to
> > /etc/machine-id
> > - ;; related warnings (see:
> > - ;;
> > https://gitlab.gnome.org/GNOME/gtk/-/issues/5169).
> > - (("[ \t]*'inscription-markup.ui',") ""))
> > + (("[ \t]*'label-wrap-justify.ui',") ""))
>
> There's no more comment about why this new test fails. Is it known
> upstream?
This is not a new test failing, it is an old, uncommented test.
> > ;; These tests fail on an Apple M1 (aarch64) with
> > the following errors:
> > ;; - MESA: error: ZINK: failed to choose pdev
> > ;; - libEGL warning: egl: failed to create dri2
> > screen
> > @@ -1391,7 +1373,7 @@ (define-public gtk
> > vulkan-headers
> > vulkan-loader ;for vulkan graphics API
> > support
> > wayland ;for wayland display-
> > backend
> > - wayland-protocols))
> > + wayland-protocols-next))
>
> Instead of using -next things, perhaps we should byte the bullet and
> update them in this iteration too?
>
> Using various variants of system means the system closure will be
> higher, may cause problems down the line (if the same process
> attempts to load two variants library in memory, that would cause
> issues).
I mean, we could, but I'm hesitant to be the one making this decision
not just for gtk, but mesa as well. I do wish more folk were to chime
in on the state of gnome-team…
Cheers
Liliana Marie Prikler <liliana.prikler <at> gmail.com>
to control <at> debbugs.gnu.org.
(Sun, 09 Mar 2025 06:56:02 GMT) Full text and rfc822 format available.Debbugs Internal Request <help-debbugs <at> gnu.org>
to internal_control <at> debbugs.gnu.org.
(Sun, 06 Apr 2025 11:24:05 GMT) Full text and rfc822 format available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.