GNU bug report logs - #73314
PyPI importer gives null at home-page for some packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73314 in the body.
You can then email your comments to 73314 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: bug-guix <at> gnu.org
Subject: PyPI importer gives null at home-page for some packages
Date: Tue, 17 Sep 2024 14:23:02 +0300

For example, this command:

guix import pypi snitun <at> 0.35.0

Message #8 received at 73314 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Evgeny Pisemsky <mail <at> pisemsky.site>, 73314 <at> debbugs.gnu.org
Subject: Re: bug#73314: PyPI importer gives null at home-page for some packages
Date: Fri, 20 Sep 2024 19:02:24 +0200

Hi,

On mar., 17 sept. 2024 at 14:23, Evgeny Pisemsky <mail <at> pisemsky.site> wrote:
> For example, this command:
>
> guix import pypi snitun <at> 0.35.0

That’s probably because the JSON file metadata stored in PyPI does not
have the information.

Well, do you prefer #false in order to be consistent with the rest, as
license for instance?

Cheers,
simon

Message #11 received at 73314 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 73314 <at> debbugs.gnu.org
Subject: Re: bug#73314: PyPI importer gives null at home-page for some packages
Date: Sun, 22 Sep 2024 10:00:40 +0300

Hi, actually I was thinking about empty string, because the package
record type definition in (guix packages) has explicit comment:

     (home-page package-home-page)                   ; string

But #f also works, and grep'ing shows that a lot of packages and even
tests use it, so let it be #f, with changing the comment above to:

string | #f

Message #14 received at 73314 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: 73314 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: [PATCH] Fix null at home-page in PyPI importer
Date: Fri, 22 Nov 2024 19:38:49 +0300

[Message part 1 (text/plain, inline)]

Here is the fix that works for me.

[0001-Fix-null-at-home-page-in-PyPI-importer.patch (text/x-patch, attachment)]

Message #19 received at 73314 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: 73314 <at> debbugs.gnu.org
Cc: Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: Re: bug#73314: PyPI importer gives null at home-page for some packages
Date: Sat, 22 Mar 2025 16:32:45 +0300

Ping.

The fix is so primitive.

Message #22 received at 73314 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: 73314 <at> debbugs.gnu.org
Subject: [PATCH v1] Fix null at home-page in PyPI importer
Date: Tue,  1 Apr 2025 01:52:51 +0300

Change-Id: I501582988cf58b00bd201c12ad47e9b095988fae
---
 guix/import/pypi.scm | 4 ++--
 guix/packages.scm    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index 9a40dea1c1..dd43ebdcf3 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -116,8 +116,8 @@ (define-json-mapping <project-info> make-project-info project-info?
   (license      project-info-license)             ;string
   (download-url project-info-download-url         ;string | #f
                 "download_url" non-empty-string-or-false)
-  (home-page    project-info-home-page            ;string
-                "home_page")
+  (home-page    project-info-home-page            ;string | #f
+                "home_page" non-empty-string-or-false)
   (url          project-info-url "project_url")   ;string
   (release-url  project-info-release-url "release_url") ;string
   (version      project-info-version))            ;string
diff --git a/guix/packages.scm b/guix/packages.scm
index 70ccd8a924..18ab23e0aa 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -651,7 +651,7 @@ (define-record-type* <package>
                (sanitize validate-texinfo))       ; one or two paragraphs
   (license package-license                        ; (list of) <license>
            (sanitize validate-license))
-  (home-page package-home-page)                   ; string
+  (home-page package-home-page)                   ; string | #f
   (supported-systems package-supported-systems    ; list of strings
                      (default %supported-systems))
 

base-commit: e2c2f98edd5d64921678c2570439dedfe662b1f8
-- 
2.49.0

Message #27 received at 73314-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 73314-done <at> debbugs.gnu.org
Subject: PyPI importer gives null at home-page for some packages
Date: Tue, 01 Apr 2025 08:57:11 +0100

[Message part 1 (text/plain, inline)]

Hi,

Pushed as ea6f4ee097bffacc33a98e462bdec58920d823b5 to master with
ammended commit message.

--
Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 73314-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Evgeny Pisemsky <mail <at> pisemsky.site>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Simon Tournier <zimon.toutoune <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Lars-Dominik Braun <lars <at> 6xq.net>,
 73314-done <at> debbugs.gnu.org, Christopher Baines <guix <at> cbaines.net>
Subject: Re: bug#73314: [PATCH v1] Fix null at home-page in PyPI importer
Date: Tue, 01 Apr 2025 14:30:44 +0200

Evgeny Pisemsky <mail <at> pisemsky.site> skribis:

> Change-Id: I501582988cf58b00bd201c12ad47e9b095988fae
> ---
>  guix/import/pypi.scm | 4 ++--
>  guix/packages.scm    | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

I added a commit log and applied it, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.