GNU bug report logs - #73411
31.0.50; sql-mode interacts poorly with package gnu-elpa

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 21 Sep 2024 14:32:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 21 10:32:37 2024
Received: from localhost ([127.0.0.1]:40115 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ss1A4-0003St-SD
	for submit <at> debbugs.gnu.org; Sat, 21 Sep 2024 10:32:37 -0400
Received: from lists.gnu.org ([209.51.188.17]:33532)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1ss1A2-0003Sl-TI
 for submit <at> debbugs.gnu.org; Sat, 21 Sep 2024 10:32:35 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1ss19i-0006Wt-8r
 for bug-gnu-emacs@HIDDEN; Sat, 21 Sep 2024 10:32:14 -0400
Received: from mout.gmx.net ([212.227.17.20])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1ss19e-0001lY-Rb
 for bug-gnu-emacs@HIDDEN; Sat, 21 Sep 2024 10:32:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net;
 s=s31663417; t=1726929125; x=1727533925; i=stephen.berman@HIDDEN;
 bh=axLHUBl13HJoet/j19fcLwceH/rqyk4WRVRdCrwvWcY=;
 h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version:
 Content-Type:cc:content-transfer-encoding:content-type:date:from:
 message-id:mime-version:reply-to:subject:to;
 b=BnvqVGcE0/hRNLR3uCplmtvzeAc/s+8HowfHsHdY6FExtRyX71Jb8f//Os9QluXs
 oBrZRQeWmXYcJn9tv06J9vxxAekgHbnAFPlTDCRXUvlC2YIi/Szy/yM3P95eFtp4H
 hc25ICuNFfR4vPisgNx1bPi4CZLKO766FZmOGoc/KmAfN4zozIfxR+qfbzDvPKzRV
 hVVfIi8fTsZ4JdpQfyR4qe+zM+LrwKT2nZRSBkN66RvDFzWG3TqaSVNANToyMNix2
 8t+D+A8gsSvSSE43jCskQFTlWIxyVfO1Mz7BrZSeucuuIb6lOVEmNs2hQZewjjEZp
 KV3XQzvOw9dw0jriYw==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from strobelfssd ([88.130.49.45]) by mail.gmx.net (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MKbg4-1sX2tN34t2-00Ku4b for
 <bug-gnu-emacs@HIDDEN>; Sat, 21 Sep 2024 16:32:05 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; sql-mode interacts poorly with package gnu-elpa
X-Debbugs-Cc: 
Date: Sat, 21 Sep 2024 16:32:05 +0200
Message-ID: <875xqpnkm2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:ol200qiAKK5DbHWgZ60kiYEiv/lQ8c4LhZXLc1UWfFGdUH5fN/W
 HKTmAhn1ghd/ujIeJhd64C9/g3eQt6ztMQforLrLEf7pCmUsgdL/TyoUpHcX32ZIrddksjm
 1sG1v5sArzzc6HWmqgvNCktpJP6zTiiogAKBmWp2uf3uJ6UJIhM6ScIoUgYVM97aq4tDJW+
 E9Wy1Umg4FpCjjr7ZX2LA==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:Kx9PIMURVJU=;0NfWfJrLcG7MO+XS00qY0fVB7L1
 hHj8ZufMrLrOg8S1Ox7zjvixytsVtAgvLjs0zcMOjqxlUWOQOLG9Jz+zdZlU9rZo7/X81hiZq
 4MSNUBhpEbR/au6bCWFkSZfd4J4oZOKIPI8G17S7JXw9mCR3DJy5lxNPf+5AgVpc/DdOIzg4G
 qp6lGr348IIjL6kTZYve/7FXCi9kuPwVruMP9n81KcU7TUXw6Q+kDkvNHqZIaV5bSTa1L6LF8
 kdd9iyfwucTEQtm8eA8/gajB1UpoJWW2YgC+A5c8bOUYjMCsoLCDm9D1tRZE730D+5LsB5Emk
 qzVTx2RBbANNmvrvFYIev+qDT8hCFNxHosnnXMj4iA4qBu6GN3YuYKzGNSWc03qKnLKpOWFhQ
 kuO7v+H5vbOXT3LvJdopM73m8EAYYaqZiZGwi+g5z/XMUnmJX4OurjpZ2tnPQgEVGJtejtCm9
 d3szcjlb8WmKSvreZYCp4FqZCNxmHJvguvIuVEMvu11j/p7hUYB1Cgk4EFRzyPiNqeMv1PK2H
 FSh34jaVtNEKpTLoc6W7F25n5DekOBJ+kOehbDE/kNCoR0xWvjItoWkmdKW1kaIIsoP0S4S/s
 Mrc45rflOM6J+4YnyQ7HNPsIv4SAZ99ufvCMvYyOXAJm7J2uHo59f/yvEeZxKlkzOffEkK6tB
 E4UKzdoq4MgxL0NgXW/gq9UEnET4Xv47SEsm604ZuMTDiMIZ+C7I0g9hh4/HzDJbma9WdM6wW
 SILvqy8dUUXKnGhBo8LW334GhQWyTO9h2epG6GRW3KUhwcooGMi7J1yzKvhpx7IiWGRVa1dxp
 aJk/aBK+YK5L/728BLw1hjug==
Received-SPF: pass client-ip=212.227.17.20;
 envelope-from=stephen.berman@HIDDEN; helo=mout.gmx.net
X-Spam_score_int: -37
X-Spam_score: -3.8
X-Spam_bar: ---
X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1.047, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

0. Install the GNU ELPA package gnu-elpa.
1. emacs -Q
2. M-x package-initialize
3. Visit an SQL file (one with the extension .sql, like the attached
   file test.sql, so it will be visited in sql-mode).
4. At the prompt "Install package sql-indent? (yes or no) " type "no".
5. Now the current buffer displays the SQL file and the mode line
   displays "(SQL[ANSI])", but the buffer is not fontified and the echo
   area displays "File mode specification error: (error Abort!)".

This also happens in emacs-29 and emacs-30.  Typing `M-x
font-lock-fontify-buffer' makes the buffer correctly fontified.

When I add `M-x toggle-debug-on-error' to step 2 above and repeat the
recipe, I get the attached backtrace. According to this, running
sql-mode-hook invokes sql-indent-enable, whose definition is:

(when (fboundp 'sqlind-minor-mode)
    (sqlind-minor-mode (if sql-use-indent-support +1 -1)))

Further, the activated gnu-elpa package loads the feature
sqlind-minor-mode, so the above when-clause condition is satisfied, but
since the package sql-indent was not installed, sqlind-minor-mode is not
defined, causing the file mode specification error.  It's not clear to
me from this why the SQL file is not fontified, since IIUC the mode hook
is run at the end of the mode definition, so the mode fontification code
should already have been executed; and indeed, when I instrument
sql-mode, carry out the above recipe and step through sql-mode, the SQL
file gets fontified and there is no error.  Nevertheless, without
instrumentation the above recipe reliably results in the error and
unfontified display.  The following patch prevents the error and
displays the SQL file correctly fontified:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline
Content-Description: sql-indent-enable patch
Content-Transfer-Encoding: quoted-printable

diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
index 5273ba2bee1..ffb29075cce 100644
=2D-- a/lisp/progmodes/sql.el
+++ b/lisp/progmodes/sql.el
@@ -734,8 +734,10 @@ sql-use-indent-support

 (defun sql-indent-enable ()
   "Enable `sqlind-minor-mode' if available and requested."
-  (when (fboundp 'sqlind-minor-mode)
-    (sqlind-minor-mode (if sql-use-indent-support +1 -1))))
+  (condition-case nil
+      (when (fboundp 'sqlind-minor-mode)
+        (sqlind-minor-mode (if sql-use-indent-support +1 -1)))
+    (error nil)))

 ;; Secure Password wallet


--=-=-=
Content-Type: text/plain


I haven't yet tested what happens on answering yes in step 4 of the
recipe, but assuming that then the sql-indent package is installed and
the file is visited with correct fontification, the patch shouldn't
change that.  However, if you answer no in step 4, then next time you
visit a SQL file you get prompted again, and the patch doesn't change
that either.  It may be desirable to limit the prompting, but I'm not
sure if the required changes should be in sql.el, the gnu-elpa package,
or both.


In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.2) of 2024-09-12 built on strobelfssd
Repository revision: 31e8500b061b6963708e66468fc89db1006226d7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: Linux From Scratch r12.2-5-systemd

Configured using:
 'configure -C 'CFLAGS=-Og -g3''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER
WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB


--=-=-=
Content-Type: application/octet-stream
Content-Disposition: attachment; filename=test.sql
Content-Transfer-Encoding: base64

Q1JFQVRFIFRBQkxFIHdlYXRoZXIgKAogICAgY2l0eSAgICAgICAgICAgIHZhcmNoYXIoODApLAog
ICAgdGVtcF9sbyAgICAgICAgIGludCwgICAgICAgICAgIC0tIGxvdyB0ZW1wZXJhdHVyZQogICAg
dGVtcF9oaSAgICAgICAgIGludCwgICAgICAgICAgIC0tIGhpZ2ggdGVtcGVyYXR1cmUKICAgIHBy
Y3AgICAgICAgICAgICByZWFsLCAgICAgICAgICAtLSBwcmVjaXBpdGF0aW9uCiAgICBkYXRlICAg
ICAgICAgICAgZGF0ZQopOwoKQ1JFQVRFIFRBQkxFIGNpdGllcyAoCiAgICBuYW1lICAgICAgICAg
ICAgdmFyY2hhcig4MCksCiAgICBsb2NhdGlvbiAgICAgICAgcG9pbnQKKTsKCklOU0VSVCBJTlRP
IHdlYXRoZXIgVkFMVUVTICgnU2FuIEZyYW5jaXNjbycsIDQ2LCA1MCwgMC4yNSwgJzE5OTQtMTEt
MjcnKTsKSU5TRVJUIElOVE8gY2l0aWVzIFZBTFVFUyAoJ1NhbiBGcmFuY2lzY28nLCAnKC0xOTQu
MCwgNTMuMCknKTsKSU5TRVJUIElOVE8gd2VhdGhlciAoY2l0eSwgdGVtcF9sbywgdGVtcF9oaSwg
cHJjcCwgZGF0ZSkKICAgIFZBTFVFUyAoJ1NhbiBGcmFuY2lzY28nLCA0MywgNTcsIDAuMCwgJzE5
OTQtMTEtMjknKTsKSU5TRVJUIElOVE8gd2VhdGhlciAoZGF0ZSwgY2l0eSwgdGVtcF9oaSwgdGVt
cF9sbykKICAgIFZBTFVFUyAoJzE5OTQtMTEtMjknLCAnSGF5d2FyZCcsIDU0LCAzNyk7CgpTRUxF
Q1QgY2l0eSwgKHRlbXBfaGkrdGVtcF9sbykvMiBBUyB0ZW1wX2F2ZywgZGF0ZSBGUk9NIHdlYXRo
ZXI7Cg==
--=-=-=
Content-Type: application/octet-stream
Content-Disposition: attachment; filename=backtrace
Content-Transfer-Encoding: base64

RGVidWdnZXIgZW50ZXJlZC0tTGlzcCBlcnJvcjogKGVycm9yICJBYm9ydCEiKQogIGVycm9yKCJB
Ym9ydCEiKQogIGdudS1lbHBhLS1wZXJmb3JtLWF1dG9sb2FkKCkKICBieXRlLWNvZGUoIlwzMDBc
MzAxIVwyMTBcMzAyIFwyMDciIFtyZXF1aXJlIGdudS1lbHBhLXV0aWxzIGdudS1lbHBhLS1wZXJm
b3JtLWF1dG9sb2FkXSAyKQogIHNxbGluZC1taW5vci1tb2RlKDEpCiAgc3FsLWluZGVudC1lbmFi
bGUoKQogIHJ1bi1ob29rcyhjaGFuZ2UtbWFqb3ItbW9kZS1hZnRlci1ib2R5LWhvb2sgcHJvZy1t
b2RlLWhvb2sgc3FsLW1vZGUtaG9vaykKICBhcHBseShydW4taG9va3MgY2hhbmdlLW1ham9yLW1v
ZGUtYWZ0ZXItYm9keS1ob29rIChwcm9nLW1vZGUtaG9vayBzcWwtbW9kZS1ob29rKSkKICBydW4t
bW9kZS1ob29rcyhzcWwtbW9kZS1ob29rKQogIHNxbC1tb2RlKCkKICBzZXQtYXV0by1tb2RlLTAo
c3FsLW1vZGUgbmlsKQogIHNldC1hdXRvLW1vZGUtLWFwcGx5LWFsaXN0KCgoIlxcLmh2YVxcJyIg
LiBMYVRlWC1tb2RlKSAoIlxcLmlweW5iXFwnIiAuIGNvZGUtY2VsbHMtY29udmVydC1pcHluYikg
KCJcXC5kanZ1XFwnIiAuIGRqdnUtaW5pdC1tb2RlKSAoIlxcLmlweW5iXFwnIiAuIGVpbjppcHlu
Yi1tb2RlKSAoIlxcLltTc11bQWFdW1NzXVxcJyIgLiBTQVMtbW9kZSkgKCJcXC5Tb3V0XFwnIiAu
IFMtdHJhbnNjcmlwdC1tb2RlKSAoIlxcLltTc110XFwnIiAuIFMtdHJhbnNjcmlwdC1tb2RlKSAo
IlxcLlJkXFwnIiAuIFJkLW1vZGUpICgiREVTQ1JJUFRJT05cXCciIC4gY29uZi1jb2xvbi1tb2Rl
KSAoIi9NYWtldmFyc1xcKFxcLndpblxcKT9cXCciIC4gbWFrZWZpbGUtbW9kZSkgKCJcXC5bUnJd
b3V0XFwnIiAuIGVzcy1yLXRyYW5zY3JpcHQtbW9kZSkgKCJDSVRBVElPTlxcJyIgLiBlc3Mtci1t
b2RlKSAoIk5BTUVTUEFDRVxcJyIgLiBlc3Mtci1tb2RlKSAoIlxcLltyUl1wcm9maWxlXFwnIiAu
IGVzcy1yLW1vZGUpICgiXFwuW3JSXVxcJyIgLiBlc3Mtci1tb2RlKSAoIi9SLy4qXFwucVxcJyIg
LiBlc3Mtci1tb2RlKSAoIlxcLltKal1bQWFdW0dnXVxcJyIgLiBlc3MtamFncy1tb2RlKSAoIlxc
LltCYl1bTW1dW0RkXVxcJyIgLiBlc3MtYnVncy1tb2RlKSAoIlxcLltCYl1bT29dW0dnXVxcJyIg
LiBlc3MtYnVncy1tb2RlKSAoIlxcLltCYl1bVXVdW0dnXVxcJyIgLiBlc3MtYnVncy1tb2RlKSAo
IlxcLnd5XFwnIiAuIHdpc2l0b2tlbi1ncmFtbWFyLW1vZGUpICgiXFwudmNsXFwnIiAuIHZjbC1t
b2RlKSAoIlxcLltWdl1bQ2NdW0ZmXVxcJyIgLiB2Y2FyZC1tb2RlKSAoIlxcLnNcXChtbFxcfGln
XFwpXFwnIiAuIHNtbC1tb2RlKSAoIlxcLmNtXFwnIiAuIHNtbC1jbS1tb2RlKSAoIlxcLmdybVxc
JyIgLiBzbWwteWFjYy1tb2RlKSAoIlxcLnN0XFwnIiAuIHNtYWxsdGFsay1tb2RlKSAoIlxcLnNz
W2ltdF1cXCciIC4gc2lzdS1tb2RlKSAoIlxcLnNoZW5cXCciIC4gc2hlbi1tb2RlKSAoIlxcLnNl
ZFxcJyIgLiBzZWQtbW9kZSkgKCJcXC5ybmNcXCciIC4gcm5jLW1vZGUpICgiXFwucG9tblxcJyIg
LiBvbW4tbW9kZSkgKCJcXC5vbW5cXCciIC4gb21uLW1vZGUpICgiXFwuZWxtY1xcJyIgLiBsbWMt
YXNtLW1vZGUpICgiXFwuanNvblxcJyIgLiBqc29uLW1vZGUpICgiXFwuamdyXFwnIiAuIGpncmFw
aC1tb2RlKSAoIlxcLmdsZVxcJyIgLiBnbGUtbW9kZSkgKCJcXC5mb3VudGFpblxcJyIgLiBmb3Vu
dGFpbi1tb2RlKSAoIlxcLmR0c2k/XFwnIiAuIGR0cy1tb2RlKSAoIlxcLmRqdnVcXCciIC4gZGp2
dS1kdW1teS1tb2RlKSAoIlxcLltDY11bU3NdW1Z2XVxcJyIgLiBjc3YtbW9kZSkgKCJcXC50c3Zc
XCciIC4gdHN2LW1vZGUpICgiXFwuY29mZmVlXFwnIiAuIGNvZmZlZS1tb2RlKSAoIkNha2VmaWxl
IiAuIGNvZmZlZS1tb2RlKSAoIlxcLnBnblxcJyIgLiBjaGVzcy1wZ24tbW9kZSkgKCJcXC5ibmZc
XCciIC4gYm5mLW1vZGUpICgiXFwudHJmP1xcJyIgLiBhcmJpdG9vbHMtbW9kZSkgKCJcXC5cXCg/
Om1kXFx8bWFya2Rvd25cXHxta2RcXHxtZG93blxcfG1rZG5cXHxtZHduXFwpXFwnIiAuIG1hcmtk
b3duLW1vZGUpICgiXFwuZ3BnXFwoflxcfFxcLn5bMC05XSt+XFwpP1xcJyIgbmlsIGVwYS1maWxl
KSAoIlxcLnpzdFxcJyIgbmlsIGprYS1jb21wcikgLi4uKSBuaWwgbmlsKQogIHNldC1hdXRvLW1v
ZGUoKQogIG5vcm1hbC1tb2RlKHQpCiAgYWZ0ZXItZmluZC1maWxlKG5pbCB0KQogIGZpbmQtZmls
ZS1ub3NlbGVjdC0xKCM8YnVmZmVyIHRlc3Quc3FsPiAifi90ZW1wL3Rlc3Quc3FsIiBuaWwgbmls
ICIvZGF0YWRpc2svc3RldmUvdGVtcC90ZXN0LnNxbCIgKDIxNDIwNzY1NSAyMDQ5KSkKICBmaW5k
LWZpbGUtbm9zZWxlY3QoIn4vdGVtcC90ZXN0LnNxbCIgbmlsIG5pbCB0KQogIGZpbmQtZmlsZSgi
fi90ZW1wL3Rlc3Quc3FsIiB0KQogIGZ1bmNhbGwtaW50ZXJhY3RpdmVseShmaW5kLWZpbGUgIn4v
dGVtcC90ZXN0LnNxbCIgdCkKICBjb21tYW5kLWV4ZWN1dGUoZmluZC1maWxlKQo=
--=-=-=--