GNU bug report logs - #73524
29.4; bug-reference-mode matches regexp case-insensitively

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Ulrich Mueller <ulm@HIDDEN>; dated Sat, 28 Sep 2024 06:56:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 73524 <at> debbugs.gnu.org:


Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 18:47:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 14:47:36 2024
Received: from localhost ([127.0.0.1]:38662 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sucTf-0003Bn-Lz
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 14:47:35 -0400
Received: from eggs.gnu.org ([209.51.188.92]:37262)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tsdh@HIDDEN>) id 1sucTd-0003B3-RT
 for 73524 <at> debbugs.gnu.org; Sat, 28 Sep 2024 14:47:34 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tsdh@HIDDEN>)
 id 1sucT4-0007Yu-3T; Sat, 28 Sep 2024 14:46:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=Olt4lYgJvaXxGvxCJNF1FuA3r79P6Jn+9CxP2iGovIU=; b=Ve/EyxljI1YUv4R9OuXJ
 IMJF1RtCnNBBJhf64vjEJOZoJtRZUZkTO2quXskOAQR0gzIdiMjocZaRSGpikDZ77gLOXEBGJBGIl
 SzaD1uKWZ9kLv4E2OyvDOdQ7sJJfLx28w15JRam5vM6nOlyKj7CMmEVog7ssfPNCHMDOKYN8QjueF
 /0yZ3j+xfi6FLkPSXy+X50d2IRTku8pM3HamFSuBxKwG/bU7mSFP6xKPc9HircOVnhkvVzOScIuBx
 mLeBLP0kCj/J60ujSaU+cqVoNotQIw+a8yfT0k4bOD9NqUm+anu2LSk1Wio69x3dj1Pd9WluH33h7
 FtWhgI/9+ZKzng==;
X-ME-Sender: <xms:IE_4ZhXuXleGuwhPLafdcbeKTyLJqv4c0PjjiIMlUEi9dfDJP6rHQw>
 <xme:IE_4ZhlZpHZaLxcGhFsDyGafEBmNb978Nl1Tolr8-bK_C0TASiH52TJhuJcgjXX4E
 iVoRHFrpoCNyQ>
X-ME-Received: <xmr:IE_4Zta9cvRHUZKmJlX66DfuttY7Ns178rL2mPqYNc_-t-lXIEFYec7abHenxxwPCiEMpMabpRdn1nC953JPGuGCCN2cGaKH>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdduuddguddtiecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp
 uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg
 hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt
 necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne
 cuggftrfgrthhtvghrnhepleduvdegfeduvdejkeefteelgeetgfevhefhueffueffgeeh
 gfeufefgvdffgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
 hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei
 jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih
 hlrdhfmhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht
 ohepjeefhedvgeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehulhhmse
 hgvghnthhoohdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh
X-ME-Proxy: <xmx:IU_4ZkWElAU8zNru3pT1hmpPOuZ3Y-LVK_6by1IALz_shBP_wjJmSw>
 <xmx:IU_4ZrkT8tBpHn5jRmODVXGTgfPfL1ib8GNuJWCBTcYjgwHbCY6cdA>
 <xmx:IU_4Zhc4PZI-LfKVCS1CX4NFB6gXf7jIWFOXnxOFTNsAXCOglYCq3w>
 <xmx:IU_4ZlEdR16xcBZIH6aCfgVt0h2W8xTwqmulZ1caDEoezCF0epE5MQ>
 <xmx:IU_4ZlkO-1Ujyvb4eGp10d_QANMmErzJcDZgAhI15CW6gIyAplwtT300>
Feedback-ID: ib2b94485:Fastmail
From: Tassilo Horn <tsdh@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#73524: 29.4; bug-reference-mode matches regexp
 case-insensitively
In-Reply-To: <86ed5364y9.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 28 Sep
 2024 20:52:46 +0300")
References: <ur094z46d@HIDDEN> <86y13c6ukh.fsf@HIDDEN>
 <umsjsyxii@HIDDEN> <87v7yfkaq7.fsf@HIDDEN>
 <86ikuf68rp.fsf@HIDDEN> <87y13bhfg3.fsf@HIDDEN>
 <u8qvbzo5c@HIDDEN> <86ed5364y9.fsf@HIDDEN>
User-Agent: mu4e 1.12.6; emacs 31.0.50
Date: Sat, 28 Sep 2024 20:46:54 +0200
Message-ID: <87msjrhazl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73524
Cc: Ulrich Mueller <ulm@HIDDEN>, 73524 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii <eliz@HIDDEN> writes:

>> >> If we want to always match case-insensitively in bug-reference,
>> >> then we could bind case-fold-search to t in bug-reference-fontify,
>> >> no?
>> 
>> > Sure, if we are convinced that there's really no scenario where bug
>> > references are case-sensitive.  I would think this is very uncommon
>> > but not impossible.
>> 
>> What about the other examples in the default, i.e. "RFE" and "PR"?
>> I'm not completely convinced that matching their lower-case form
>> would be a good thing.
>
> I see in binutils-gdb repository most "PR" are in upper-case, but
> all.
> [...]
> Not sure about RFE (where is that used?)

Request for enhancement?

Anyway, I also think that bug#123 is probably better matched
case-insensitively while RFC 2616 or CVE-2024-5742 are commonly
all-caps.  But in the end it's a user's choice if she prefers to have a
false positive or a false negative when something is or just looks like
a bug reference.  I'd rather have a false positive but that's just me.

So I'd vote for a defcustom bug-reference-case-fold-search defaulting to
t that users can set according to their preference or conventions.

And I wouldn't read too much into the default value of
bug-reference-bug-regexp.  It's just a value that works for us (Emacs or
other GNU projects using debbugs).

Bye,
  Tassilo




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.

Message received at 73524 <at> debbugs.gnu.org:


Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 17:53:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 13:53:30 2024
Received: from localhost ([127.0.0.1]:38616 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1subdK-0008Es-2m
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 13:53:30 -0400
Received: from eggs.gnu.org ([209.51.188.92]:32894)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1subdH-0008Ef-QK
 for 73524 <at> debbugs.gnu.org; Sat, 28 Sep 2024 13:53:28 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1subcg-0001K2-Jo; Sat, 28 Sep 2024 13:52:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=3bXeP1PRCzWjLfRtv3GjjqHF2aZ6sISKYOD9DmkRu/I=; b=jdVKHnsAIkR2
 FcTHsuD/ofq/sRPbtai1N651BFSkdRx7KY8HkphSXw8tyd+vLrfkBPTSlWqiz1oMRz+sqNZZGAAqH
 FSTWOafjCmhuDG+DTU4irLr8Ac6nxj1PFFcjHQ2Sn2Iscugr3HjeXdS8KleAxjFkcy9TU1fZ7VTNZ
 RqmYkntds46xfBNwoYy2mF0ZgqjzldcI7XTJgAIDwlZY0FdiETYy5nXac4cIEMt1c+oDmhY1fJzIM
 P+33+RiXy9ThnnPr1XVBUzEf+K1ek4BmpkzWoaon7F5NUpPj2TPnMOr0X8z6Rs/IugdpMsMV7D5j0
 3TSvW8n2jwR4XhS+A67QFg==;
Date: Sat, 28 Sep 2024 20:52:46 +0300
Message-Id: <86ed5364y9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Ulrich Mueller <ulm@HIDDEN>
In-Reply-To: <u8qvbzo5c@HIDDEN> (message from Ulrich Mueller on Sat, 28
 Sep 2024 19:25:19 +0200)
Subject: Re: bug#73524: 29.4; bug-reference-mode matches regexp
 case-insensitively
References: <ur094z46d@HIDDEN> <86y13c6ukh.fsf@HIDDEN>
 <umsjsyxii@HIDDEN> <87v7yfkaq7.fsf@HIDDEN>
 <86ikuf68rp.fsf@HIDDEN> <87y13bhfg3.fsf@HIDDEN> <u8qvbzo5c@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73524
Cc: 73524 <at> debbugs.gnu.org, tsdh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Ulrich Mueller <ulm@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>,  73524 <at> debbugs.gnu.org
> Date: Sat, 28 Sep 2024 19:25:19 +0200
> 
> >>>>> On Sat, 28 Sep 2024, Tassilo Horn wrote:
> 
> > Eli Zaretskii <eliz@HIDDEN> writes:
> >> 
> >> If we want to always match case-insensitively in bug-reference, then
> >> we could bind case-fold-search to t in bug-reference-fontify, no?
> 
> > Sure, if we are convinced that there's really no scenario where bug
> > references are case-sensitive.  I would think this is very uncommon but
> > not impossible.
> 
> What about the other examples in the default, i.e. "RFE" and "PR"?
> I'm not completely convinced that matching their lower-case form would
> be a good thing.

I see in binutils-gdb repository most "PR" are in upper-case, but
all.  Example:

  commit ecb915b4de7569027ad78bd3e24873bb92cb8e32
  Author:     Nelson Chu <nelson@HIDDEN>
  AuthorDate: Mon Sep 12 09:26:52 2022 +0800
  Commit:     Nelson Chu <nelson@HIDDEN>
  CommitDate: Mon Sep 12 11:31:41 2022 +0800

      RISC-V: PR28509, the default visibility symbol cannot be referenced by R_RIS

      When generating the shared object, the default visibility symbols may bind
      externally, which means they will be exported to the dynamic symbol table,
      and are preemptible by default.  These symbols cannot be referenced by the
      non-pic R_RISCV_JAL and R_RISCV_RVC_JUMP.  However, consider that linker
      may relax the R_RISCV_CALL relocations to R_RISCV_JAL or R_RISCV_RVC_JUMP,
      if these relocations are relocated to the plt entries, then we won't report
      error for them.  Perhaps we also need the similar checks for the
      R_RISCV_BRANCH and R_RISCV_RVC_BRANCH relocations.

      After applying this patch, and revert the following glibc patch,
      riscv: Fix incorrect jal with HIDDEN_JUMPTARGET
      https://sourceware.org/git/?p=glibc.git;a=commit;h=68389203832ab39dd0dbaabbc

      I get the expected errors as follows,
      ld: relocation R_RISCV_RVC_JUMP against `__sigsetjmp' which may bind externa    ld: relocation R_RISCV_JAL against `exit' which may bind externally can not

      Besides, we also have similar changes for libgcc,
      RISC-V: jal cannot refer to a default visibility symbol for shared object
      https://github.com/gcc-mirror/gcc/commit/45116f342057b7facecd3d05c2091ce3a77

      bfd/
	      pr 28509
	      * elfnn-riscv.c (riscv_elf_relocate_section): Report errors when
	      makeing a shard object, and the referenced symbols of R_RISCV_JAL
	      relocations are default visibility.  Besides, we should handle most
	      of the cases here, so don't need the unresolvable check later for
	      R_RISCV_JAL and R_RISCV_RVC_JUMP.
      ld/
	      pr 28509
	      * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated.
	      * testsuite/ld-riscv-elf/lib-nopic-01a.s: Removed.
	      * testsuite/ld-riscv-elf/lib-nopic-01b.d: Likewise.
	      * testsuite/ld-riscv-elf/lib-nopic-01b.s: Likewise.
	      * testsuite/ld-riscv-elf/shared-lib-nopic-01.d: New testcase.
	      * testsuite/ld-riscv-elf/shared-lib-nopic-01.s: Likewise.
	      * testsuite/ld-riscv-elf/shared-lib-nopic-02.d: Likewise.
	      * testsuite/ld-riscv-elf/shared-lib-nopic-02.s: Likewise.
	      * testsuite/ld-riscv-elf/shared-lib-nopic-03.d: Likewise.
	      * testsuite/ld-riscv-elf/shared-lib-nopic-03.s: Likewise.
	      * testsuite/ld-riscv-elf/shared-lib-nopic-04.d: Likewise.
	      * testsuite/ld-riscv-elf/shared-lib-nopic-04.s: Likewise.

Not sure about RFE (where is that used?)




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.

Message received at 73524 <at> debbugs.gnu.org:


Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 17:26:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 13:26:03 2024
Received: from localhost ([127.0.0.1]:38589 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1subCk-0006gM-OL
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 13:26:02 -0400
Received: from woodpecker.gentoo.org ([140.211.166.183]:49844
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ulm@HIDDEN>) id 1subCi-0006fn-Er
 for 73524 <at> debbugs.gnu.org; Sat, 28 Sep 2024 13:26:01 -0400
From: Ulrich Mueller <ulm@HIDDEN>
To: Tassilo Horn <tsdh@HIDDEN>
Subject: Re: bug#73524: 29.4; bug-reference-mode matches regexp
 case-insensitively
In-Reply-To: <87y13bhfg3.fsf@HIDDEN> (Tassilo Horn's message of "Sat, 28 Sep
 2024 19:10:36 +0200")
References: <ur094z46d@HIDDEN> <86y13c6ukh.fsf@HIDDEN>
 <umsjsyxii@HIDDEN> <87v7yfkaq7.fsf@HIDDEN>
 <86ikuf68rp.fsf@HIDDEN> <87y13bhfg3.fsf@HIDDEN>
Date: Sat, 28 Sep 2024 19:25:19 +0200
Message-ID: <u8qvbzo5c@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73524
Cc: Eli Zaretskii <eliz@HIDDEN>, 73524 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>>>> On Sat, 28 Sep 2024, Tassilo Horn wrote:

> Eli Zaretskii <eliz@HIDDEN> writes:
>>> In the wild, bug references are almost always case-insensitive
>>> because URLs are.  So one could say that maybe there should be a
>>> bug-reference-case-fold-search defcustom (defaulting to t) in order
>>> to decouple it from case-fold-search.
>> 
>> If we want to always match case-insensitively in bug-reference, then
>> we could bind case-fold-search to t in bug-reference-fontify, no?

> Sure, if we are convinced that there's really no scenario where bug
> references are case-sensitive.  I would think this is very uncommon but
> not impossible.

What about the other examples in the default, i.e. "RFE" and "PR"?
I'm not completely convinced that matching their lower-case form would
be a good thing.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.

Message received at 73524 <at> debbugs.gnu.org:


Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 17:11:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 13:11:21 2024
Received: from localhost ([127.0.0.1]:38584 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1suayX-0005s0-7O
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 13:11:21 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46784)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tsdh@HIDDEN>) id 1suayW-0005rk-0X
 for 73524 <at> debbugs.gnu.org; Sat, 28 Sep 2024 13:11:20 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tsdh@HIDDEN>)
 id 1suaxv-0003W6-Uv; Sat, 28 Sep 2024 13:10:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=j8wnRWTBbwRh4pHA4SCVVZ1CDNq9LgluDsf/iOS1Mq4=; b=PfZLkfmTJ0DAX5OdN80R
 uQO3vFhwkSTjRAq6j2nAnWFZo+cXNUIV9s38hdKrzaFxLzPMA+U2cexbM4exAFmKWaJA27wONZ/+j
 qCpkjcutSyZfQoQ9DqtDwiQsdwBMQze4w1Qzx5f4HHpmwyH+o0+bR19amQ2W+ry44W0b1cfDB2h2F
 WMAJXnk+1mcI6QvDeDg59ZW9p65hlwdoxmoMFlfqxu4/qlH1gP3NUwXeVjB2SaeUlHg59+DhBZ2Di
 XEN5Ud0J2n4AijQwQ9lFBEEFNfqIHIWcsTofqWJ6tcZfJlZX8vwz9w6PIItI46yjCyVrKO+Jvlaad
 tHaXq8eWSSEGQA==;
X-ME-Sender: <xms:jzj4Zk0wWso08oljhcXDNAKbwl9vEiQAmuQHlRLpz-jXAfT9uJbtMg>
 <xme:jzj4ZvHavcRujm3Rm9VuqImShEEU08wxeH48Ob-C7eSbBVgJc1EoG53hix0fgUeEx
 A9tJKcS-waTPQ>
X-ME-Received: <xmr:jzj4Zs4WFyOGGzlrPHZgVbIKdWRm201VhMUb7DSZccQzbfudlhD_u9Ri7wrOoNC3Vuvo_0vRD1w9jxMv3jHC54K_v3mtB5xg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdduuddgkeehucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
 rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh
 htshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgesthdtredttdertden
 ucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenuc
 ggtffrrghtthgvrhhnpeeluddvgeefuddvjeekfeetleegtefgveehhfeuffeuffeghefg
 ueefgfdvffegtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieej
 feekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilh
 drfhhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthho
 peejfeehvdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepuhhlmhesgh
 gvnhhtohhordhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg
X-ME-Proxy: <xmx:jzj4Zt01HZ5IXOxelDa-hpesYFnMoVL_0peDSTrt5lcY7NH8rjibCA>
 <xmx:jzj4ZnFB1BrPpxNJA8SQi2ZYaEg167yZZJtyr_2bojX9rr7E6us_ng>
 <xmx:jzj4Zm__PfLgLN6gpytJAf9k1egqiMuIv6rB5IwTVOC3M_IKlVPjlw>
 <xmx:jzj4ZskN1QYpKxcbyErk0MbDaUpQXAJzlufSvK_8kTuA-ScdbX5TnQ>
 <xmx:jzj4ZnFBFl_mviI5GYJvlMh2mLhIXinfIZRe07OW60BeXRdG3-tIsG_e>
Feedback-ID: ib2b94485:Fastmail
From: Tassilo Horn <tsdh@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#73524: 29.4; bug-reference-mode matches regexp
 case-insensitively
In-Reply-To: <86ikuf68rp.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 28 Sep
 2024 19:30:18 +0300")
References: <ur094z46d@HIDDEN> <86y13c6ukh.fsf@HIDDEN>
 <umsjsyxii@HIDDEN> <87v7yfkaq7.fsf@HIDDEN>
 <86ikuf68rp.fsf@HIDDEN>
User-Agent: mu4e 1.12.6; emacs 31.0.50
Date: Sat, 28 Sep 2024 19:10:36 +0200
Message-ID: <87y13bhfg3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73524
Cc: ulm@HIDDEN, 73524 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii <eliz@HIDDEN> writes:

>> In the wild, bug references are almost always case-insensitive
>> because URLs are.  So one could say that maybe there should be a
>> bug-reference-case-fold-search defcustom (defaulting to t) in order
>> to decouple it from case-fold-search.
>
> If we want to always match case-insensitively in bug-reference, then
> we could bind case-fold-search to t in bug-reference-fontify, no?

Sure, if we are convinced that there's really no scenario where bug
references are case-sensitive.  I would think this is very uncommon but
not impossible.

Bye,
  Tassilo




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.

Message received at 73524 <at> debbugs.gnu.org:


Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 16:31:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 12:31:07 2024
Received: from localhost ([127.0.0.1]:38532 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1suaLb-0003Nv-3o
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 12:31:07 -0400
Received: from eggs.gnu.org ([209.51.188.92]:51294)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1suaLZ-0003NP-9z
 for 73524 <at> debbugs.gnu.org; Sat, 28 Sep 2024 12:31:05 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1suaKz-0006nG-KJ; Sat, 28 Sep 2024 12:30:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=vliDmBMwJimUk+eS4ylWn69XfeOQWnAxSQch0k8Knyg=; b=L5BHGv15yWng
 ixFel0VdXACUz6Pyq6BvRnuJPAK3HnNRDBL22X6cYXW5uLYzgbrwdXsk566GmCVOS61GLbyy42VAH
 ws4jB4/0Y4kvvF+WOKIC8DSahRZAk+6YcvxvUwjuN8tzNcS5ko4CK7n8hhThkTpMUjrbUn/cfayeM
 EMsejq4UeDH+13b0NkbasbkjdmnUq5VqfUChB0FeS+VBZ0RPDJBQYsapzQRIffXvw8yYmJ0hV9RMQ
 yR3AsfPZR4735TkmTwMWxc0yMqR21TPL44RE2KORAQ0vOlOgRVDYITyX/TZeyPCw2KvvR81IMUnwf
 n1krRmhaNw8TJ+2dGOAqbw==;
Date: Sat, 28 Sep 2024 19:30:18 +0300
Message-Id: <86ikuf68rp.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Tassilo Horn <tsdh@HIDDEN>
In-Reply-To: <87v7yfkaq7.fsf@HIDDEN> (message from Tassilo Horn on Sat, 28
 Sep 2024 18:24:16 +0200)
Subject: Re: bug#73524: 29.4; bug-reference-mode matches regexp
 case-insensitively
References: <ur094z46d@HIDDEN> <86y13c6ukh.fsf@HIDDEN>
 <umsjsyxii@HIDDEN> <87v7yfkaq7.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73524
Cc: ulm@HIDDEN, 73524 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Tassilo Horn <tsdh@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>,  73524 <at> debbugs.gnu.org
> Date: Sat, 28 Sep 2024 18:24:16 +0200
> 
> In the wild, bug references are almost always case-insensitive because
> URLs are.  So one could say that maybe there should be a
> bug-reference-case-fold-search defcustom (defaulting to t) in order to
> decouple it from case-fold-search.

If we want to always match case-insensitively in bug-reference, then
we could bind case-fold-search to t in bug-reference-fontify, no?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.

Message received at 73524 <at> debbugs.gnu.org:


Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 16:25:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 12:25:06 2024
Received: from localhost ([127.0.0.1]:38507 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1suaFm-0002wb-7t
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 12:25:06 -0400
Received: from eggs.gnu.org ([209.51.188.92]:42854)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tsdh@HIDDEN>) id 1suaFk-0002w0-7N
 for 73524 <at> debbugs.gnu.org; Sat, 28 Sep 2024 12:25:05 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tsdh@HIDDEN>)
 id 1suaF9-0005w8-Qf; Sat, 28 Sep 2024 12:24:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=c6GGbPj9+Iix3+tV4JtOdFyY/zay5uUz3ro480QXe6w=; b=ZmGGVl9moSWJkGnhfjEl
 z+5YN4fSaciy0Bp7M05RvIAakLJj2JQlhA4MyIggSmRvJi6YUDEbCEf7sJmScMWtRXg7HlAh5f3/w
 f2kQ3AeAkeu3iipo9V3PoPVhwYoHuIKaPUzz745zaaF4MKnB7FKy/pon1Yiyn3EsegibfzUIe/oum
 nxIaqiRNoHVpEuvO/1IBUXUpsQ2Rp0EPMri9lFMur7RYns3Mjj+wbNOcyXX41vYDa/Vakh0ka3f5H
 lqqpwTvd0+eAoWViEg0hCBK+B47LmZvCsOr5cJ+aGahx5EeV5EyysEUaWWhEopasfu8VokjpMSdCH
 WzkOXk6UiG0tCg==;
X-ME-Sender: <xms:tC34ZocbXK3Gx1jqQWNspg9mq4RoJ9UM2R4yvAKJ1enFEHrbMHqurA>
 <xme:tC34ZqMeXUuJINa84D9fOy6T4G1cYlrIeIO0mRbGtk41Siz9gN_-ZiFPOP_JjsZhn
 XvZew1h0DGFFw>
X-ME-Received: <xmr:tC34ZpjV0E-Su9YUwM1DCsgMwV4y7u2lVUPWCg6T488flXDvnqV3IHOvtBxPrpFZjfcro5DG3-Ajl8ErzCHO9JZRWspzAsdh>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdduuddgjeeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
 rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh
 htshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgesthdtredttdertden
 ucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenuc
 ggtffrrghtthgvrhhnpeeluddvgeefuddvjeekfeetleegtefgveehhfeuffeuffeghefg
 ueefgfdvffegtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieej
 feekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilh
 drfhhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthho
 peejfeehvdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiise
 hgnhhurdhorhhgpdhrtghpthhtohepuhhlmhesghgvnhhtohhordhorhhg
X-ME-Proxy: <xmx:tC34Zt_t1JgnXmkaZTavrad7I2La7Ya90jY1uoqQ2HugzW_4L9FwKQ>
 <xmx:tC34ZktmN0g8Sg51TqZgFzpCAdEUrAOaafV_9T1dI2kKfDN8Th4HBg>
 <xmx:tC34ZkGMiF1BZtvl3I7tjckCh2d8h2UHPR2g1M_OGI54EqD27aewLQ>
 <xmx:tC34ZjOvr51j00dMLW1g8F1kxfkGvroeRIxXK2iYrnm4IF1-Z2sxfA>
 <xmx:tC34ZpM36sArUlBl0cRwyvG7D6GfJWfDbznZ6gCuiYZioSbUYv1c8Et4>
Feedback-ID: ib2b94485:Fastmail
From: Tassilo Horn <tsdh@HIDDEN>
To: Ulrich Mueller <ulm@HIDDEN>
Subject: Re: bug#73524: 29.4; bug-reference-mode matches regexp
 case-insensitively
In-Reply-To: <umsjsyxii@HIDDEN> (Ulrich Mueller's message of "Sat, 28 Sep
 2024 10:48:21 +0200")
References: <ur094z46d@HIDDEN> <86y13c6ukh.fsf@HIDDEN>
 <umsjsyxii@HIDDEN>
User-Agent: mu4e 1.12.6; emacs 31.0.50
Date: Sat, 28 Sep 2024 18:24:16 +0200
Message-ID: <87v7yfkaq7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73524
Cc: Eli Zaretskii <eliz@HIDDEN>, 73524 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ulrich Mueller <ulm@HIDDEN> writes:

Hi!

>>> It will correctly highlight "bug-1234" and "Bug-5678" but also
>>> "bUg-9012" which shouldn't be matched by the regexp.
>
>> I'm not sure I see the harm in that (e.g., what if someone made a
>> mistake while typing the commit log message? these are immutable with
>> Git once pushed), but I've added Tassilo to this discussion in case
>> he has an opinion.
>
> IIUC behaviour depends on case-fold-search in the buffer. If that's
> flipped, the string will no longer match. IMHO it's better to notice
> such typos immediately, instead of being surprised by them later.
>
> If case-independent matching is desired, the regexp can explicitly
> allow it.

Indeed, the matching depends on case-fold-search.  Its value is a
personal preference, so it's advisable to write the regexp such that it
doesn't depend on that setting if you do it publically, e.g., in a
.dir-locals.el.  Bug#123 and bug#123 are both likely while buG#123 is
not.  (That said, I think I don't follow that advice myself in the
auto-setup routines...)

In the wild, bug references are almost always case-insensitive because
URLs are.  So one could say that maybe there should be a
bug-reference-case-fold-search defcustom (defaulting to t) in order to
decouple it from case-fold-search.

WDYT?

Bye,
  Tassilo




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.

Message received at 73524 <at> debbugs.gnu.org:


Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 08:49:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 04:49:04 2024
Received: from localhost ([127.0.0.1]:51759 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1suT8S-00057U-Ev
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 04:49:04 -0400
Received: from woodpecker.gentoo.org ([140.211.166.183]:53262
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ulm@HIDDEN>) id 1suT8Q-00056p-BJ
 for 73524 <at> debbugs.gnu.org; Sat, 28 Sep 2024 04:49:02 -0400
From: Ulrich Mueller <ulm@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#73524: 29.4; bug-reference-mode matches regexp
 case-insensitively
In-Reply-To: <86y13c6ukh.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 28 Sep
 2024 11:39:26 +0300")
References: <ur094z46d@HIDDEN> <86y13c6ukh.fsf@HIDDEN>
Date: Sat, 28 Sep 2024 10:48:21 +0200
Message-ID: <umsjsyxii@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73524
Cc: 73524 <at> debbugs.gnu.org, Tassilo Horn <tsdh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>>>> On Sat, 28 Sep 2024, Eli Zaretskii wrote:

>> It will correctly highlight "bug-1234" and "Bug-5678" but also
>> "bUg-9012" which shouldn't be matched by the regexp.

> I'm not sure I see the harm in that (e.g., what if someone made a
> mistake while typing the commit log message? these are immutable with
> Git once pushed), but I've added Tassilo to this discussion in case he
> has an opinion.

IIUC behaviour depends on case-fold-search in the buffer. If that's
flipped, the string will no longer match. IMHO it's better to notice
such typos immediately, instead of being surprised by them later.

If case-independent matching is desired, the regexp can explicitly
allow it.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.

Message received at 73524 <at> debbugs.gnu.org:


Received: (at 73524) by debbugs.gnu.org; 28 Sep 2024 08:42:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 04:42:22 2024
Received: from localhost ([127.0.0.1]:51718 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1suT1y-0004l8-B6
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 04:42:22 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45992)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1suT1w-0004km-7V
 for 73524 <at> debbugs.gnu.org; Sat, 28 Sep 2024 04:42:20 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1suSzE-0008A9-He; Sat, 28 Sep 2024 04:39:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=nFTBvhFCxEXNwl3zuxHYeLlpmjOwxZCbjmaJIbB2hhY=; b=MlYwQfTBP+C/
 dIniakRUkzCBUU22Xczv1MxOeBLWgW7rjl8rUaEqWFYt0tOegYFw+cWRGQqLGnzFjv21/dxMPkrCV
 uid9Z7PAgmXG1M1Ij8AzrbgH35+njRRXZmka+fX42fsfC1DFtVHw0O3ZUtwjZfhl4N2vL41bM1qcz
 89DRSMRGTHZJRYHuISKxq5eZ8t7DlVUIYHfcUz1H1pq1DePfxYmmt1KjZ9/ds6InlM0mig+mO6rUJ
 ktutM9fpg3gm1XBCfHgApr5WxLVi0pe8l3fH+Wm2Cjd743c7bKka2Ep7JWRNuP/nb4HTUHC1pkuYn
 +CBspA8feXsEqWmiTtZcNQ==;
Date: Sat, 28 Sep 2024 11:39:26 +0300
Message-Id: <86y13c6ukh.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Ulrich Mueller <ulm@HIDDEN>, Tassilo Horn <tsdh@HIDDEN>
In-Reply-To: <ur094z46d@HIDDEN> (message from Ulrich Mueller on Sat, 28
 Sep 2024 08:24:26 +0200)
Subject: Re: bug#73524: 29.4;
 bug-reference-mode matches regexp case-insensitively
References: <ur094z46d@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73524
Cc: 73524 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Ulrich Mueller <ulm@HIDDEN>
> Date: Sat, 28 Sep 2024 08:24:26 +0200
> 
> bug-reference-bug-regexp is matched case-insensitively, while both its
> default value and the example regexp "\\([Bb]ug[#-]\\([0-9]+\\)\\)"
> from the "Bug Reference" section of the manual indicate otherwise.
> 
> To reproduce, save attached file as bugref.txt, then:
> $ emacs -Q bugref.txt
> 
> It will correctly highlight "bug-1234" and "Bug-5678" but also
> "bUg-9012" which shouldn't be matched by the regexp.

I'm not sure I see the harm in that (e.g., what if someone made a
mistake while typing the commit log message? these are immutable with
Git once pushed), but I've added Tassilo to this discussion in case he
has an opinion.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Sep 2024 06:55:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 28 02:55:26 2024
Received: from localhost ([127.0.0.1]:48696 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1suRMS-0006Vu-Dx
	for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 02:55:26 -0400
Received: from lists.gnu.org ([209.51.188.17]:42160)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ulm@HIDDEN>) id 1suR8u-0005Zj-Ff
 for submit <at> debbugs.gnu.org; Sat, 28 Sep 2024 02:41:26 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ulm@HIDDEN>) id 1suQsm-00062K-6l
 for bug-gnu-emacs@HIDDEN; Sat, 28 Sep 2024 02:24:44 -0400
Received: from dev.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]
 helo=smtp.gentoo.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <ulm@HIDDEN>) id 1suQsk-0000AQ-8M
 for bug-gnu-emacs@HIDDEN; Sat, 28 Sep 2024 02:24:43 -0400
From: Ulrich Mueller <ulm@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.4; bug-reference-mode matches regexp case-insensitively
Date: Sat, 28 Sep 2024 08:24:26 +0200
Message-ID: <ur094z46d@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2001:470:ea4a:1:5054:ff:fec7:86e4;
 envelope-from=ulm@HIDDEN; helo=smtp.gentoo.org
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

--=-=-=
Content-Type: text/plain

bug-reference-bug-regexp is matched case-insensitively, while both its
default value and the example regexp "\\([Bb]ug[#-]\\([0-9]+\\)\\)"
from the "Bug Reference" section of the manual indicate otherwise.

To reproduce, save attached file as bugref.txt, then:
$ emacs -Q bugref.txt

It will correctly highlight "bug-1234" and "Bug-5678" but also
"bUg-9012" which shouldn't be matched by the regexp.


In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.18.2) of 2024-09-27 built on localhost
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: Gentoo Linux

Configured using:
 'configure --prefix=/usr --build=x86_64-pc-linux-gnu
 --host=x86_64-pc-linux-gnu --mandir=/usr/share/man
 --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc
 --localstatedir=/var/lib --datarootdir=/usr/share
 --disable-silent-rules --docdir=/usr/share/doc/emacs-29.4
 --htmldir=/usr/share/doc/emacs-29.4/html --libdir=/usr/lib64
 --program-suffix=-emacs-29 --includedir=/usr/include/emacs-29
 --infodir=/usr/share/info/emacs-29 --localstatedir=/var
 --enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp
 --without-compress-install --without-hesiod --without-pop
 --with-file-notification=inotify --with-pdumper --enable-acl
 --with-dbus --with-modules --with-gameuser=:gamestat --with-libgmp
 --with-gpm --without-native-compilation --without-json
 --without-kerberos --without-kerberos5 --with-lcms2 --with-xml2
 --without-mailutils --without-selinux --without-sqlite3 --with-gnutls
 --without-libsystemd --with-threads --without-tree-sitter
 --without-wide-int --with-sound=alsa --with-zlib --with-x
 --without-pgtk --without-ns --without-gconf --with-gsettings
 --without-toolkit-scroll-bars --with-xpm --with-xft --with-cairo
 --with-harfbuzz --with-libotf --with-m17n-flt --with-x-toolkit=lucid
 --with-xaw3d --with-gif --with-jpeg --with-png --with-rsvg --with-tiff
 --without-webp --with-imagemagick --with-dumping=pdumper
 'CFLAGS=-march=native -ggdb -O2 -pipe -fno-fast-math -ffp-contract=off'
 CPPFLAGS= 'LDFLAGS=-Wl,-O1 -Wl,--as-needed
 -Wl,-z,pack-relative-relocs''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF X11 XAW3D XDBE XIM XINPUT2
XPM LUCID ZLIB

Important settings:
  value of $LC_CTYPE: en_GB.UTF-8
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: POSIX
  locale-coding-system: utf-8-unix

Major mode: Text

Minor modes in effect:
  bug-reference-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-hg
vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view pcvs-util vc-git
diff-mode easy-mmode vc cl-loaddefs cl-lib vc-dispatcher bug-reference
byte-opt gv bytecomp byte-compile rmc iso-transl tooltip cconv eldoc
paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty make-network-process emacs)

Memory information:
((conses 16 54606 8541)
 (symbols 48 7145 0)
 (strings 32 21703 1671)
 (string-bytes 1 606203)
 (vectors 16 13609)
 (vector-slots 8 188733 15492)
 (floats 8 38 39)
 (intervals 56 355 0)
 (buffers 976 13))


--=-=-=
Content-Type: text/plain
Content-Disposition: inline; filename=bugref.txt

bug-1234
Bug-5678
bUg-9012
foo-3456

Local Variables:
eval: (bug-reference-mode 1)
bug-reference-bug-regexp: "\\([Bb]ug[#-]\\([0-9]+\\)\\)"
bug-reference-url-format: "https://project.org/issues/%s"
End:

--=-=-=--




Acknowledgement sent to Ulrich Mueller <ulm@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#73524; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.