GNU logs - #73527, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#73527: 30.0.90; Comint rebinds C-d
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 28 Sep 2024 10:50:02 +0000
Resent-Message-ID: <handler.73527.B.172752055915251 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 73527 <at> debbugs.gnu.org
From: Augusto Stoffel <arstoffel@HIDDEN>
Date: Sat, 28 Sep 2024 12:48:37 +0200
Message-ID: <87y13cf3zu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::62a;
 envelope-from=arstoffel@HIDDEN; helo=mail-ej1-x62a.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

comint-mode rebinds C-d (to `comint-delchar-or-maybe-eof') in a way that
is supposed to fall back to the default C-d behavior unless point is on
a blank input line.

If the user rebinds C-d in the global map, e.g. to something sensible
such as `delete-forward-char', this preference is overridden.

Should a menu-item with :filter property be used instead in
comint-mode-map?

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Augusto Stoffel <arstoffel@HIDDEN>
Subject: bug#73527: Acknowledgement (30.0.90; Comint rebinds C-d)
Message-ID: <handler.73527.B.172752055915251.ack <at> debbugs.gnu.org>
References: <87y13cf3zu.fsf@HIDDEN>
X-Gnu-PR-Message: ack 73527
X-Gnu-PR-Package: emacs
Reply-To: 73527 <at> debbugs.gnu.org
Date: Sat, 28 Sep 2024 10:50:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 73527 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
73527: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73527
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#73527: 30.0.90; Comint rebinds C-d
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 29 Sep 2024 16:12:02 +0000
Resent-Message-ID: <handler.73527.B73527.172762626426062 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: 73527 <at> debbugs.gnu.org
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <87y13cf3zu.fsf@HIDDEN> (Augusto Stoffel's message of "Sat, 28
 Sep 2024 12:48:37 +0200")
Organization: LINKOV.NET
References: <87y13cf3zu.fsf@HIDDEN>
Date: Sun, 29 Sep 2024 19:08:03 +0300
Message-ID: <86cykmla4s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> comint-mode rebinds C-d (to `comint-delchar-or-maybe-eof') in a way that
> is supposed to fall back to the default C-d behavior unless point is on
> a blank input line.
>
> If the user rebinds C-d in the global map, e.g. to something sensible
> such as `delete-forward-char', this preference is overridden.
>
> Should a menu-item with :filter property be used instead in
> comint-mode-map?

It would be nice to make such filter customizable.

For example, currently I have to use:

  (define-key shell-mode-map "\C-d" 'my-shell-c-d)
  (defun my-shell-c-d (&optional arg)
    (interactive "p")
    (cond ((and (eobp)
                (save-excursion
                  (let ((inhibit-field-text-motion t))
                    (goto-char (line-beginning-position))
                    (looking-at-p "^iex.*>\s*$"))))
           (let ((process (get-buffer-process (current-buffer))))
             (process-send-string process ":init.stop()\n")))
          ((and (eobp)
                (save-excursion
                  (let ((inhibit-field-text-motion t))
                    (goto-char (line-beginning-position))
                    (looking-at-p "^[a-z:]*cljs\\..*=>\s*$"))))
           (let ((process (get-buffer-process (current-buffer))))
             (process-send-string process ":cljs/quit\n")))
          (t
           (comint-delchar-or-maybe-eof arg))))

But with a filter all these cases could be moved to the filter predicate,
along with its default value extracted from 'comint-delchar-or-maybe-eof':

    (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
	(comint-send-eof)
      (delete-char arg))

Then rebinding `C-d' from `delete-char' to `delete-forward-char'
will be handled automatically.

Also for the users of `delete-selection-mode' this will remove
the need to add more settings:

  (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)
  (put 'my-shell-c-d 'delete-selection 'supersede)

according to this part of delsel.el:

  ;; delete-backward-char and delete-forward-char already delete the selection by
  ;; default, but not delete-char.
  (put 'delete-char 'delete-selection 'supersede)

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#73527: 30.0.90; Comint rebinds C-d
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 05 Oct 2024 14:34:02 +0000
Resent-Message-ID: <handler.73527.B73527.172813882511259 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Juri Linkov <juri@HIDDEN>
Cc: 73527 <at> debbugs.gnu.org
From: Augusto Stoffel <arstoffel@HIDDEN>
In-Reply-To: <86cykmla4s.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 29 Sep 2024 19:08:03 +0300")
References: <87y13cf3zu.fsf@HIDDEN> <86cykmla4s.fsf@HIDDEN>
Date: Sat, 05 Oct 2024 16:32:31 +0200
Message-ID: <87o73ymxhc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Sun, 29 Sep 2024 at 19:08, Juri Linkov wrote:

> It would be nice to make such filter customizable.
>
> For example, currently I have to use:
>
>   (define-key shell-mode-map "\C-d" 'my-shell-c-d)
>   (defun my-shell-c-d (&optional arg)
> [...]

Good point.  How about replacing (delete-char arg) in
comint-delchar-or-maybe-eof with

  (call-interactively
    (lookup-key global-map <something appropriate>))

Not sure this could be made to work reliably.

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.