GNU bug report logs - #73760
[PATCH] gnu: Upgrade googlebenchmark

Previous Next

Package: guix-patches;

Reported by: Aaron Covrig <aaron.covrig.us <at> ieee.org>

Date: Sat, 12 Oct 2024 01:43:02 UTC

Severity: normal

Tags: patch

Done: Greg Hogan <code <at> greghogan.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73760 in the body.
You can then email your comments to 73760 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#73760; Package guix-patches. (Sat, 12 Oct 2024 01:43:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Aaron Covrig <aaron.covrig.us <at> ieee.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 12 Oct 2024 01:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: guix-patches <at> gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Subject: [PATCH] gnu: Upgrade googlebenchmark
Date: Fri, 11 Oct 2024 21:41:43 -0400

* gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.0
---
 gnu/packages/check.scm | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 8d41996c71..e0bd71e6d3 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -105,6 +105,7 @@ (define-module (gnu packages check)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages time)
   #:use-module (gnu packages xml)
+  #:use-module (gnu packages version-control)
   #:use-module (guix utils)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
@@ -1098,24 +1099,25 @@ (define-public googletest-1.8
 (define-public googlebenchmark
   (package
     (name "googlebenchmark")
-    (version "1.8.3")
+    (version "1.9.0")
     (home-page "https://github.com/google/benchmark")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference (url home-page)
-                                  (commit (string-append "v" version))))
-              (file-name (git-file-name "google-benchmark" version))
-              (sha256
-               (base32
-                "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url home-page)
+             (commit (string-append "v" version))))
+       (file-name (git-file-name "google-benchmark" version))
+       (sha256
+        (base32 "0pvv6vww5qgkl821rn6jhh2bmfjqs6amkcj4ybws4pg1i0y7bjg5"))))
     (build-system cmake-build-system)
     (arguments
      '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
-                               (string-append
-                                "-DGOOGLETEST_PATH="
-                                (assoc-ref %build-inputs "googletest")))))
-    (inputs
-     `(("googletest" ,(package-source googletest))))
+                               (string-append "-DGOOGLETEST_PATH="
+                                              (assoc-ref %build-inputs
+                                                         "googletest")))))
+    (inputs `(("git" ,git)
+              ("googletest" ,(package-source googletest))))
     (synopsis "C++ library to support the benchmarking of functions")
     (description
      "The googlebenchmark C++ library support the benchmarking of functions,

base-commit: b8fd792ea267cb920da0651074a533d8abf00488
-- 
2.46.0
Information forwarded to guix-patches <at> gnu.org:
bug#73760; Package guix-patches. (Fri, 21 Mar 2025 13:57:03 GMT) Full text and rfc822 format available.

Message #8 received at 73760 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Cc: 73760 <at> debbugs.gnu.org
Subject: Re: [bug#73760] [PATCH] gnu: Upgrade googlebenchmark
Date: Fri, 21 Mar 2025 09:55:56 -0400

On Fri, Oct 11, 2024 at 9:43 PM Aaron Covrig via Guix-patches via
<guix-patches <at> gnu.org> wrote:
>
> * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.0
> ---
>  gnu/packages/check.scm | 30 ++++++++++++++++--------------
>  1 file changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index 8d41996c71..e0bd71e6d3 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -105,6 +105,7 @@ (define-module (gnu packages check)
>    #:use-module (gnu packages texinfo)
>    #:use-module (gnu packages time)
>    #:use-module (gnu packages xml)
> +  #:use-module (gnu packages version-control)
>    #:use-module (guix utils)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
> @@ -1098,24 +1099,25 @@ (define-public googletest-1.8
>  (define-public googlebenchmark
>    (package
>      (name "googlebenchmark")
> -    (version "1.8.3")
> +    (version "1.9.0")
>      (home-page "https://github.com/google/benchmark")
> -    (source (origin
> -              (method git-fetch)
> -              (uri (git-reference (url home-page)
> -                                  (commit (string-append "v" version))))
> -              (file-name (git-file-name "google-benchmark" version))
> -              (sha256
> -               (base32
> -                "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))))
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url home-page)
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name "google-benchmark" version))
> +       (sha256
> +        (base32 "0pvv6vww5qgkl821rn6jhh2bmfjqs6amkcj4ybws4pg1i0y7bjg5"))))
>      (build-system cmake-build-system)
>      (arguments
>       '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
> -                               (string-append
> -                                "-DGOOGLETEST_PATH="
> -                                (assoc-ref %build-inputs "googletest")))))
> -    (inputs
> -     `(("googletest" ,(package-source googletest))))
> +                               (string-append "-DGOOGLETEST_PATH="
> +                                              (assoc-ref %build-inputs
> +                                                         "googletest")))))
> +    (inputs `(("git" ,git)
> +              ("googletest" ,(package-source googletest))))
>      (synopsis "C++ library to support the benchmarking of functions")
>      (description
>       "The googlebenchmark C++ library support the benchmarking of functions,
>
> base-commit: b8fd792ea267cb920da0651074a533d8abf00488
> --
> 2.46.0

Hi Aaron,

I see there is now a 1.9.1 release.

Why was git added as an input? If it's for the project version
parsing, git is not required for tagged releases:

-- Could NOT find Git (missing: GIT_EXECUTABLE)
-- Google Benchmark version: v1.9.1, normalized to 1.9.1

Also, I think we prefer to leave the formatting unchanged when making
simple changes like this.

Greg
Information forwarded to guix-patches <at> gnu.org:
bug#73760; Package guix-patches. (Fri, 21 Mar 2025 17:25:02 GMT) Full text and rfc822 format available.

Message #11 received at 73760 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 73760 <at> debbugs.gnu.org
Subject: Re: [bug#73760] [PATCH] gnu: Upgrade googlebenchmark
Date: Fri, 21 Mar 2025 13:24:21 -0400

[Message part 1 (text/plain, inline)]
On Fri, 21 Mar 2025 09:55:56 -0400
Greg Hogan <code <at> greghogan.com> wrote:

> On Fri, Oct 11, 2024 at 9:43 PM Aaron Covrig via Guix-patches via
> <guix-patches <at> gnu.org> wrote:
> >
> > * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.0
> > ---
> >  gnu/packages/check.scm | 30 ++++++++++++++++--------------
> >  1 file changed, 16 insertions(+), 14 deletions(-)
> >
> > diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> > index 8d41996c71..e0bd71e6d3 100644
> > --- a/gnu/packages/check.scm
> > +++ b/gnu/packages/check.scm
> > @@ -105,6 +105,7 @@ (define-module (gnu packages check)
> >    #:use-module (gnu packages texinfo)
> >    #:use-module (gnu packages time)
> >    #:use-module (gnu packages xml)
> > +  #:use-module (gnu packages version-control)
> >    #:use-module (guix utils)
> >    #:use-module ((guix licenses) #:prefix license:)
> >    #:use-module (guix packages)
> > @@ -1098,24 +1099,25 @@ (define-public googletest-1.8
> >  (define-public googlebenchmark
> >    (package
> >      (name "googlebenchmark")
> > -    (version "1.8.3")
> > +    (version "1.9.0")
> >      (home-page "https://github.com/google/benchmark")
> > -    (source (origin
> > -              (method git-fetch)
> > -              (uri (git-reference (url home-page)
> > -                                  (commit (string-append "v"
> > version))))
> > -              (file-name (git-file-name "google-benchmark"
> > version))
> > -              (sha256
> > -               (base32
> > -
> > "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))))
> > +    (source
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +             (url home-page)
> > +             (commit (string-append "v" version))))
> > +       (file-name (git-file-name "google-benchmark" version))
> > +       (sha256
> > +        (base32
> > "0pvv6vww5qgkl821rn6jhh2bmfjqs6amkcj4ybws4pg1i0y7bjg5"))))
> > (build-system cmake-build-system) (arguments
> >       '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
> > -                               (string-append
> > -                                "-DGOOGLETEST_PATH="
> > -                                (assoc-ref %build-inputs
> > "googletest")))))
> > -    (inputs
> > -     `(("googletest" ,(package-source googletest))))
> > +                               (string-append "-DGOOGLETEST_PATH="
> > +                                              (assoc-ref
> > %build-inputs
> > +
> > "googletest")))))
> > +    (inputs `(("git" ,git)
> > +              ("googletest" ,(package-source googletest))))
> >      (synopsis "C++ library to support the benchmarking of
> > functions") (description
> >       "The googlebenchmark C++ library support the benchmarking of
> > functions,
> >
> > base-commit: b8fd792ea267cb920da0651074a533d8abf00488
> > --
> > 2.46.0  
> 
> Hi Aaron,
> 
> I see there is now a 1.9.1 release.
> 
> Why was git added as an input? If it's for the project version
> parsing, git is not required for tagged releases:
> 
> -- Could NOT find Git (missing: GIT_EXECUTABLE)
> -- Google Benchmark version: v1.9.1, normalized to 1.9.1
> 
> Also, I think we prefer to leave the formatting unchanged when making
> simple changes like this.
> 
> Greg

It's been a while, but I believe I added it for the project version; I
can push up an update for v1.9.1 that excludes git and uses the
internal project version. As for the formatting, that is likely from
running `guix style` before submitting, I can also drop it though for
the submission.

v/r,

Aaron

[Message part 2 (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#73760; Package guix-patches. (Fri, 21 Mar 2025 17:26:01 GMT) Full text and rfc822 format available.

Message #14 received at 73760 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 73760 <at> debbugs.gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Subject: [PATCH v2] gnu: googlebenchmark: Upgrade to v1.9.1.
Date: Fri, 21 Mar 2025 13:25:25 -0400

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>

* gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.1.
---
 gnu/packages/check.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 4994a10f11..38c10c91be 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -1104,7 +1104,7 @@ (define-public googletest-1.8
 (define-public googlebenchmark
   (package
     (name "googlebenchmark")
-    (version "1.8.3")
+    (version "1.9.1")
     (home-page "https://github.com/google/benchmark")
     (source (origin
               (method git-fetch)
@@ -1113,15 +1113,14 @@ (define-public googlebenchmark
               (file-name (git-file-name "google-benchmark" version))
               (sha256
                (base32
-                "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))))
+                "1ky51j4hbqcaxp7i7sfiyh1435mgyijgbfgc48bbmi52vgay0477"))))
     (build-system cmake-build-system)
     (arguments
      '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
                                (string-append
                                 "-DGOOGLETEST_PATH="
                                 (assoc-ref %build-inputs "googletest")))))
-    (inputs
-     `(("googletest" ,(package-source googletest))))
+    (inputs `(("googletest" ,(package-source googletest))))
     (synopsis "C++ library to support the benchmarking of functions")
     (description
      "The googlebenchmark C++ library support the benchmarking of functions,

base-commit: efac1498c15198afc4f9a2bc700408bde1b3b3ed
-- 
2.48.1
Reply sent to Greg Hogan <code <at> greghogan.com>:
You have taken responsibility. (Fri, 21 Mar 2025 19:46:01 GMT) Full text and rfc822 format available.
Notification sent to Aaron Covrig <aaron.covrig.us <at> ieee.org>:
bug acknowledged by developer. (Fri, 21 Mar 2025 19:46:01 GMT) Full text and rfc822 format available.

Message #19 received at 73760-done <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Cc: 73760-done <at> debbugs.gnu.org
Subject: Re: [bug#73760] [PATCH v2] gnu: googlebenchmark: Upgrade to v1.9.1.
Date: Fri, 21 Mar 2025 15:45:16 -0400

On Fri, Mar 21, 2025 at 1:26 PM Aaron Covrig via Guix-patches via
<guix-patches <at> gnu.org> wrote:
>
> From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
>
> * gnu/packages/check.scm (googlebenchmark): Upgrade to 1.9.1.
> ---
>  gnu/packages/check.scm | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index 4994a10f11..38c10c91be 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -1104,7 +1104,7 @@ (define-public googletest-1.8
>  (define-public googlebenchmark
>    (package
>      (name "googlebenchmark")
> -    (version "1.8.3")
> +    (version "1.9.1")
>      (home-page "https://github.com/google/benchmark")
>      (source (origin
>                (method git-fetch)
> @@ -1113,15 +1113,14 @@ (define-public googlebenchmark
>                (file-name (git-file-name "google-benchmark" version))
>                (sha256
>                 (base32
> -                "1hf8xrdd9k57kw3mpdi68a78fd96vzdqv3179v2yy5dxx336ffw3"))))
> +                "1ky51j4hbqcaxp7i7sfiyh1435mgyijgbfgc48bbmi52vgay0477"))))
>      (build-system cmake-build-system)
>      (arguments
>       '(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
>                                 (string-append
>                                  "-DGOOGLETEST_PATH="
>                                  (assoc-ref %build-inputs "googletest")))))
> -    (inputs
> -     `(("googletest" ,(package-source googletest))))
> +    (inputs `(("googletest" ,(package-source googletest))))
>      (synopsis "C++ library to support the benchmarking of functions")
>      (description
>       "The googlebenchmark C++ library support the benchmarking of functions,
>
> base-commit: efac1498c15198afc4f9a2bc700408bde1b3b3ed
> --
> 2.48.1

Pushed as 5bf7d80535720077aec104a9904480d08b9b4f2b.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 19 Apr 2025 11:24:57 GMT) Full text and rfc822 format available.
This bug report was last modified 85 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.