GNU bug report logs - #73781
[PATCH] Upgrade out-of-date dependencies with package-vc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73781 in the body.
You can then email your comments to 73781 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Upgrade out-of-date dependencies with package-vc
Date: Sun, 13 Oct 2024 01:23:38 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

I noticed this bug when working on hyperdrive.el, which I had installed
with package-vc-install-from-checkout.  I updated the version of its
transient.el dependency in the Package-Requires header and attempted to
reinstall, but it did not attempt to update the dependency.

I think the attached patch may not be the whole solution.  I applied it,
attempted package-vc-install-from-checkout again, and got this error:

package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found

Do we need to call package-refresh-contents at some point inside of
package-vc-install-dependencies?

Thank you!

Joseph

[0001-Upgrade-out-of-date-dependencies.patch (text/patch, attachment)]

Message #8 received at 73781 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 73781 <at> debbugs.gnu.org
Subject: Re: bug#73781: [PATCH] Upgrade out-of-date dependencies with
 package-vc
Date: Wed, 1 Jan 2025 20:14:18 -0600

Joseph Turner <joseph <at> breatheoutbreathe.in> writes:

> Tags: patch
>
> I noticed this bug when working on hyperdrive.el, which I had installed
> with package-vc-install-from-checkout.  I updated the version of its
> transient.el dependency in the Package-Requires header and attempted to
> reinstall, but it did not attempt to update the dependency.
>
> I think the attached patch may not be the whole solution.  I applied it,
> attempted package-vc-install-from-checkout again, and got this error:
>
> package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found
>
> Do we need to call package-refresh-contents at some point inside of
> package-vc-install-dependencies?
>
> Thank you!
>
> Joseph

Philip, any comments?

Message #11 received at 73781 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 73781 <at> debbugs.gnu.org
Subject: Re: bug#73781: [PATCH] Upgrade out-of-date dependencies with
 package-vc
Date: Sun, 23 Feb 2025 00:24:07 +0000

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Joseph Turner <joseph <at> breatheoutbreathe.in> writes:
>
>> Tags: patch
>>
>> I noticed this bug when working on hyperdrive.el, which I had installed
>> with package-vc-install-from-checkout.  I updated the version of its
>> transient.el dependency in the Package-Requires header and attempted to
>> reinstall, but it did not attempt to update the dependency.
>>
>> I think the attached patch may not be the whole solution.  I applied it,
>> attempted package-vc-install-from-checkout again, and got this error:
>>
>> package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found
>>
>> Do we need to call package-refresh-contents at some point inside of
>> package-vc-install-dependencies?
>>
>> Thank you!
>>
>> Joseph
>
> Philip, any comments?

Ping.  Philip, WDYT?

Message #16 received at 73781-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: 73781-done <at> debbugs.gnu.org
Subject: Re: bug#73781: [PATCH] Upgrade out-of-date dependencies with
 package-vc
Date: Sun, 23 Feb 2025 11:22:02 +0000

Joseph Turner <joseph <at> breatheoutbreathe.in> writes:

> Tags: patch
>
> I noticed this bug when working on hyperdrive.el, which I had installed
> with package-vc-install-from-checkout.  I updated the version of its
> transient.el dependency in the Package-Requires header and attempted to
> reinstall, but it did not attempt to update the dependency.
>
> I think the attached patch may not be the whole solution.  I applied it,
> attempted package-vc-install-from-checkout again, and got this error:
>
> package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found
>
> Do we need to call package-refresh-contents at some point inside of
> package-vc-install-dependencies?
>
> Thank you!
>
> Joseph
>
>>From fd05beab4903e3ba9f2a6866a00e924f8bcd5637 Mon Sep 17 00:00:00 2001
> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
> Date: Sun, 13 Oct 2024 01:10:02 +0200
> Subject: [PATCH] Upgrade out-of-date dependencies
>
> * lisp/emacs-lisp/package-vc.el (package-vc-install-dependencies): Pass
> the specified package version when checking if a package is installed.
> ---
>  lisp/emacs-lisp/package-vc.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index e168096e153..58916637008 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -465,7 +465,7 @@ package-vc-install-dependencies
>                    "Attempt to find all dependencies for PKG."
>                    (cond
>                     ((assq (car pkg) to-install)) ;inhibit cycles
> -                   ((package-installed-p (car pkg)))
> +                   ((package-installed-p (car pkg) (cadr pkg)))
>                     ((let* ((pac package-archive-contents)
>                             (desc (cadr (assoc (car pkg) pac))))
>                        (if desc

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Joseph Turner <joseph <at> breatheoutbreathe.in> writes:
>>
>>> Tags: patch
>>>
>>> I noticed this bug when working on hyperdrive.el, which I had installed
>>> with package-vc-install-from-checkout.  I updated the version of its
>>> transient.el dependency in the Package-Requires header and attempted to
>>> reinstall, but it did not attempt to update the dependency.
>>>
>>> I think the attached patch may not be the whole solution.  I applied it,
>>> attempted package-vc-install-from-checkout again, and got this error:
>>>
>>> package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found
>>>
>>> Do we need to call package-refresh-contents at some point inside of
>>> package-vc-install-dependencies?
>>>
>>> Thank you!
>>>
>>> Joseph
>>
>> Philip, any comments?
>
> Ping.  Philip, WDYT?

My apologies for missing the message!  Yes, the change makes sense and I
can push it to master.  If you think it is worthwhile, please
cherry-pick it onto the emacs-30 branch.

Thanks!

Message #19 received at 73781 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>,
 Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: 73781 <at> debbugs.gnu.org
Subject: Re: bug#73781: [PATCH] Upgrade out-of-date dependencies with
 package-vc
Date: Sun, 23 Feb 2025 13:50:58 +0000

Philip Kaludercic <philipk <at> posteo.net> writes:

> My apologies for missing the message!  Yes, the change makes sense and I
> can push it to master.  If you think it is worthwhile, please
> cherry-pick it onto the emacs-30 branch.

If you think it's safe, we can cherry-pick it after Emacs 30.1 is out.

Message #22 received at 73781 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 73781 <at> debbugs.gnu.org, Joseph Turner <joseph <at> breatheoutbreathe.in>
Subject: Re: bug#73781: [PATCH] Upgrade out-of-date dependencies with
 package-vc
Date: Sun, 23 Feb 2025 14:24:31 +0000

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> My apologies for missing the message!  Yes, the change makes sense and I
>> can push it to master.  If you think it is worthwhile, please
>> cherry-pick it onto the emacs-30 branch.
>
> If you think it's safe, we can cherry-pick it after Emacs 30.1 is out.

That is fine with me as well.

Message #25 received at 73781 <at> debbugs.gnu.org (full text, mbox):

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 73781 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#73781: [PATCH] Upgrade out-of-date dependencies with
 package-vc
Date: Sun, 23 Feb 2025 12:13:20 -0800

Philip Kaludercic <philipk <at> posteo.net> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Philip Kaludercic <philipk <at> posteo.net> writes:
>>
>>> My apologies for missing the message!  Yes, the change makes sense and I
>>> can push it to master.  If you think it is worthwhile, please
>>> cherry-pick it onto the emacs-30 branch.
>>
>> If you think it's safe, we can cherry-pick it after Emacs 30.1 is out.
>
> That is fine with me as well.

Thank you!

Message #28 received at 73781-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>,
 Philip Kaludercic <philipk <at> posteo.net>
Cc: 73781-done <at> debbugs.gnu.org
Subject: Re: bug#73781: [PATCH] Upgrade out-of-date dependencies with
 package-vc
Date: Sun, 23 Feb 2025 23:18:51 +0000

Joseph Turner <joseph <at> breatheoutbreathe.in> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> Stefan Kangas <stefankangas <at> gmail.com> writes:
>>
>>> Philip Kaludercic <philipk <at> posteo.net> writes:
>>>
>>>> My apologies for missing the message!  Yes, the change makes sense and I
>>>> can push it to master.  If you think it is worthwhile, please
>>>> cherry-pick it onto the emacs-30 branch.
>>>
>>> If you think it's safe, we can cherry-pick it after Emacs 30.1 is out.
>>
>> That is fine with me as well.
>
> Thank you!

Now done in commit d63b27a416b.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.