Received: (at 73781) by debbugs.gnu.org; 2 Jan 2025 02:14:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 01 21:14:23 2025 Received: from localhost ([127.0.0.1]:41477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tTAj9-00032s-AT for submit <at> debbugs.gnu.org; Wed, 01 Jan 2025 21:14:23 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:43328) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tTAj6-00032j-2J for 73781 <at> debbugs.gnu.org; Wed, 01 Jan 2025 21:14:20 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5d3f57582a2so21065729a12.1 for <73781 <at> debbugs.gnu.org>; Wed, 01 Jan 2025 18:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735784059; x=1736388859; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=YQ6PHSv/EN6LsNavqp5lbbUYcbVpk0/RVWskSTbXRp0=; b=SUGhOpoM3KQkt7xfWBMqF8tdzQ92TSsPeTXnCCbiV7t85+CCp/skJv4+t2r3NLnDHw xijtPcxPtuWJnVrF6AEt46057A3t6BsJz+0foPrS7MDDomN0Kd1uLOkZyul9+kl/eunB ife9BFcRzIVENCyKi/tXetcSRCv5vKu7YFkRpZ2qcid/6ynAxSSJ2HBX4Li1dhE1vDVB 0njAcroGKMwt6HpNMuLdsTgjTkBo0Dzusw3rT19KM0qJgHA50edacrhLa9Bnbyrpx5eW gTo0j9ugJ6hJqQSXVx+jPBoOINUJer+NdBduzkxKMaQY1s+eKBjksOotA4+GemUIM5kw FXEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735784059; x=1736388859; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YQ6PHSv/EN6LsNavqp5lbbUYcbVpk0/RVWskSTbXRp0=; b=E1TGVDghshStrnRHemvk6iu8UCsxcYlyA+0QeriTfZd6JA/sgLn5CTrFF90Cc6b5xf efjGTc9WyArMfzomWNLPcLX296L/O0EcRq+ONYtiDwy/+H1yyZqiTdM/RBO2jw4/UBkE dFHi+IhxAdTtLdN3WiK06TfUS5TctCnVRd8HcaKfyHhbxBWcHGwvUjYaVBVwbw3vM/3x sOVLrgIHa7XLN6/d9TQoITU9Rd6D/GW+36jSphZL6zUwXSfqZ+TO7sqCKZqNnaFU6IIH n80Lhmzf+bKRmGO6zdgk8NOlgxFnPBMfpmYFpvf3MmBISG79MIFUQ+DngF8MbW6/UsQ4 nGHw== X-Gm-Message-State: AOJu0YxhA85lgtjpRlP+Bgjcc1WCauLazR1XYO3a4YNIijDZAqU7PFYV ISy2V8jPzDeAQLfdCRLPofmXDmRu1zDGSGWmQ6aQO3I3c74s9fwadXMJIRYq3XRlhG8gPjCT6oF AIFRVK6txdM8+h2M5+M09WndDbvMER9QpuZw= X-Gm-Gg: ASbGncvENqu3IJRKKic+RrNbm/BaPyCMbuYcnag8dv0V+rc2W/RRS9xASgqex5X+hrT m28el0peukXHr4gbYKzFdYf5GOsF7xinD68LipVa6 X-Google-Smtp-Source: AGHT+IELhkCmz9ReWz9D7+Cwc1oiw/1j/+3jZoE9DMsoYl31iXFB8Q3OQBn+U12XYbgOZTFaEMW3ufOZUpSZeVIkYbM= X-Received: by 2002:a05:6402:51d4:b0:5d0:b61a:89c9 with SMTP id 4fb4d7f45d1cf-5d81e71a1c3mr41980909a12.5.1735784058671; Wed, 01 Jan 2025 18:14:18 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 1 Jan 2025 20:14:18 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87jzechpmt.fsf@HIDDEN> (Joseph Turner's message of "Sun, 13 Oct 2024 01:23:38 +0200") References: <87jzechpmt.fsf@HIDDEN> MIME-Version: 1.0 Date: Wed, 1 Jan 2025 20:14:18 -0600 Message-ID: <CADwFkmkJBJQDOxHLCkvhd9jn80HXfiDufwqjLMjBzYVvhJphxw@HIDDEN> Subject: Re: bug#73781: [PATCH] Upgrade out-of-date dependencies with package-vc To: Joseph Turner <joseph@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73781 Cc: Philip Kaludercic <philipk@HIDDEN>, 73781 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Joseph Turner <joseph@HIDDEN> writes: > Tags: patch > > I noticed this bug when working on hyperdrive.el, which I had installed > with package-vc-install-from-checkout. I updated the version of its > transient.el dependency in the Package-Requires header and attempted to > reinstall, but it did not attempt to update the dependency. > > I think the attached patch may not be the whole solution. I applied it, > attempted package-vc-install-from-checkout again, and got this error: > > package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found > > Do we need to call package-refresh-contents at some point inside of > package-vc-install-dependencies? > > Thank you! > > Joseph Philip, any comments?
bug-gnu-emacs@HIDDEN:bug#73781; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 12 Oct 2024 23:24:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 12 19:24:13 2024
Received: from localhost ([127.0.0.1]:39224 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1szlT2-0003bj-O7
for submit <at> debbugs.gnu.org; Sat, 12 Oct 2024 19:24:13 -0400
Received: from lists.gnu.org ([209.51.188.17]:34582)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <joseph@HIDDEN>) id 1szlT0-0003bX-Eb
for submit <at> debbugs.gnu.org; Sat, 12 Oct 2024 19:24:11 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <joseph@HIDDEN>)
id 1szlSl-0005kR-Ay
for bug-gnu-emacs@HIDDEN; Sat, 12 Oct 2024 19:23:55 -0400
Received: from out-170.mta0.migadu.com ([91.218.175.170])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <joseph@HIDDEN>)
id 1szlSj-0003Uf-5J
for bug-gnu-emacs@HIDDEN; Sat, 12 Oct 2024 19:23:55 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in;
s=key1; t=1728775428;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type;
bh=nx74bcHEA+sI07TdC+Y0Mzj4cTQ32u1XJGUCvCHGNxs=;
b=RdwPd09EFjElFRh99OtQVEpXb13ut+7Cg75o7+QZVRanK4vbe9fRDrVfh4L7NHjf6b0xgg
N0TtG6wDBSZvdX/tp0qciLTAUOir20K4lQoIazZ/8/eKtgIEYPVVLZYSCculxz774vZaMH
Eer/4l9STLNOptGDpLtcYG438L7YDRY=
From: Joseph Turner <joseph@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Upgrade out-of-date dependencies with package-vc
Date: Sun, 13 Oct 2024 01:23:38 +0200
Message-ID: <87jzechpmt.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Migadu-Flow: FLOW_OUT
Received-SPF: pass client-ip=91.218.175.170;
envelope-from=joseph@HIDDEN; helo=out-170.mta0.migadu.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
--=-=-=
Content-Type: text/plain
Tags: patch
I noticed this bug when working on hyperdrive.el, which I had installed
with package-vc-install-from-checkout. I updated the version of its
transient.el dependency in the Package-Requires header and attempted to
reinstall, but it did not attempt to update the dependency.
I think the attached patch may not be the whole solution. I applied it,
attempted package-vc-install-from-checkout again, and got this error:
package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found
Do we need to call package-refresh-contents at some point inside of
package-vc-install-dependencies?
Thank you!
Joseph
--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
filename=0001-Upgrade-out-of-date-dependencies.patch
From fd05beab4903e3ba9f2a6866a00e924f8bcd5637 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Sun, 13 Oct 2024 01:10:02 +0200
Subject: [PATCH] Upgrade out-of-date dependencies
* lisp/emacs-lisp/package-vc.el (package-vc-install-dependencies): Pass
the specified package version when checking if a package is installed.
---
lisp/emacs-lisp/package-vc.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index e168096e153..58916637008 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -465,7 +465,7 @@ package-vc-install-dependencies
"Attempt to find all dependencies for PKG."
(cond
((assq (car pkg) to-install)) ;inhibit cycles
- ((package-installed-p (car pkg)))
+ ((package-installed-p (car pkg) (cadr pkg)))
((let* ((pac package-archive-contents)
(desc (cadr (assoc (car pkg) pac))))
(if desc
--
2.46.0
--=-=-=--
Joseph Turner <joseph@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#73781; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.