GNU logs - #73816, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#73816: python-django's manage.py tries to use a hard-coded python executable
Resent-From: Gabriel Wicki <gabriel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 15 Oct 2024 09:50:02 +0000
Resent-Message-ID: <handler.73816.B.17289857593532 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 73816 <at> debbugs.gnu.org
Date: Tue, 15 Oct 2024 11:48:44 +0200
From: Gabriel Wicki <gabriel@HIDDEN>
Message-ID: <mjgot2cwzzfhicsyobhubmc3dsbviysha56nqt4c3epp3emdrc@4ovou422lxuv>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Received-SPF: permerror client-ip=129.132.148.196;
 envelope-from=gabriel@HIDDEN; helo=cotopaxi.ee.ethz.ch
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

The python-django package makes the admin utility create a manage.py
file with a hard-coded python interpreter.

  $ guix shell python python-django -- django-admin startproject foobar
  $ head -n 1 foobar/manage.py
  #!/gnu/store/my2j5bzapayk59971z2ryzlajdz569f9-python-toolchain-3.10.7/bin/python

I think this is wrong.  The interpreter line should be

  #!/usr/bin/env python3

Or am I wrong?

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Gabriel Wicki <gabriel@HIDDEN>
Subject: bug#73816: Acknowledgement (python-django's manage.py tries to
 use a hard-coded python executable)
Message-ID: <handler.73816.B.17289857593532.ack <at> debbugs.gnu.org>
References: <mjgot2cwzzfhicsyobhubmc3dsbviysha56nqt4c3epp3emdrc@4ovou422lxuv>
X-Gnu-PR-Message: ack 73816
X-Gnu-PR-Package: guix
Reply-To: 73816 <at> debbugs.gnu.org
Date: Tue, 15 Oct 2024 09:50:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 73816 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
73816: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73816
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#73816: python-django's manage.py tries to use a hard-coded python executable
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 10 Dec 2024 16:51:04 +0000
Resent-Message-ID: <handler.73816.B73816.173384942822515 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gabriel Wicki <gabriel@HIDDEN>, 73816 <at> debbugs.gnu.org
From: Simon Tournier <zimon.toutoune@HIDDEN>
In-Reply-To: <mjgot2cwzzfhicsyobhubmc3dsbviysha56nqt4c3epp3emdrc@4ovou422lxuv>
References: <mjgot2cwzzfhicsyobhubmc3dsbviysha56nqt4c3epp3emdrc@4ovou422lxuv>
Date: Tue, 10 Dec 2024 16:59:27 +0100
Message-ID: <877c87zfz4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

On Tue, 15 Oct 2024 at 11:48, Gabriel Wicki <gabriel@HIDDEN> wrote:

> The python-django package makes the admin utility create a manage.py
> file with a hard-coded python interpreter.
>
>   $ guix shell python python-django -- django-admin startproject foobar
>   $ head -n 1 foobar/manage.py
>   #!/gnu/store/my2j5bzapayk59971z2ryzlajdz569f9-python-toolchain-3.10.7/b=
in/python
>
> I think this is wrong.  The interpreter line should be
>
>   #!/usr/bin/env python3

Well, I don=E2=80=99t know if there is a rationale for this choice.  Someho=
w, my
understanding is: 1. python-django is byte-compiled using one specific
Python interpreter and 2. what is the guarantee that the whole code
byte-compiled with different Python interpreter will run?

Hence, that version of the specific Python interpreter is encoded.

Now, if the purpose of =E2=80=99django-admin startproject foobar=E2=80=99 i=
s to only
create generic configuration that does not depends on any Django or
Python version, then maybe it could be considered as wrong. :-)

Else I don=E2=80=99t know.  I remember having a similar discussion about a
similar Python tool but I am not able to find it back.

Cheers,
simon

Message sent to bug-guix@HIDDEN:

Subject: bug#73816: python-django's manage.py tries to use a hard-coded python executable
Resent-From: Gabriel Wicki <gabriel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Wed, 11 Dec 2024 11:49:01 +0000
Resent-Message-ID: <handler.73816.B73816.17339177236347 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Simon Tournier <zimon.toutoune@HIDDEN>
Cc: 73816 <at> debbugs.gnu.org
Date: Wed, 11 Dec 2024 12:48:31 +0100
From: Gabriel Wicki <gabriel@HIDDEN>
Message-ID: <yb2zy4gw4qtgdi7rqqhy4ix52ljbspifh7l2mvstwcodfglfb4@fvmb24btljly>
References: <mjgot2cwzzfhicsyobhubmc3dsbviysha56nqt4c3epp3emdrc@4ovou422lxuv>
 <877c87zfz4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <877c87zfz4.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi!

Thanks for your input!

On Tue, Dec 10, 2024 at 04:59:27PM +0100, Simon Tournier wrote:
> Now, if the purpose of ’django-admin startproject foobar’ is to only
> create generic configuration that does not depends on any Django or
> Python version, then maybe it could be considered as wrong. :-)
I think this is actually the case!  The `startproject' script
initializes a more or less empty project including said `manage.py'
script.  Now when starting and developing a Django project, all these
files will end up in VCS, might be packaged somewhat later on (if at
all) and executed on a different system, which may or may not have Guix
available.  Apart from that, hard-coding that script without any
guarantee whatsoever that this path exists in the system that will run
the code will more likely result in a failure than any kind of success.

If you have any idea on how to patch that and could point me in that
direction, I'll gladly send in a patch or two!

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#73816: python-django's manage.py tries to use a hard-coded python executable
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 13 Dec 2024 11:59:02 +0000
Resent-Message-ID: <handler.73816.B73816.17340911357993 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 73816
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Gabriel Wicki <gabriel@HIDDEN>
Cc: 73816 <at> debbugs.gnu.org
Received: via spool by 73816-submit <at> debbugs.gnu.org id=B73816.17340911357993
          (code B ref 73816); Fri, 13 Dec 2024 11:59:02 +0000
Received: (at 73816) by debbugs.gnu.org; 13 Dec 2024 11:58:55 +0000
Received: from localhost ([127.0.0.1]:41850 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tM4Jr-00024j-3Q
	for submit <at> debbugs.gnu.org; Fri, 13 Dec 2024 06:58:55 -0500
Received: from mail-wm1-f49.google.com ([209.85.128.49]:45363)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1tM4Jn-00024Z-SO
 for 73816 <at> debbugs.gnu.org; Fri, 13 Dec 2024 06:58:53 -0500
Received: by mail-wm1-f49.google.com with SMTP id
 5b1f17b1804b1-4361c705434so11956025e9.3
 for <73816 <at> debbugs.gnu.org>; Fri, 13 Dec 2024 03:58:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1734091071; x=1734695871; darn=debbugs.gnu.org;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=i5VzB2z9ek0RR+JcjyK/7F6+wpnR7nxaRt58CIUmlmc=;
 b=KRZ8NUid06gcv+JUwK+HGkIJMWP63t0bBxKszI54iT+3F3T5gpJkQTn7I6K4RQS5u0
 btaTyzLWeEhD3yc9Dgs0Hk80DZQ1FVHnqm8wivUtkNJUdTUnMwcidN6y/Q7XhGyo2DVM
 2u/rZXVeqzJwBSzEKjnPKrPWHQ0qvoSStiOp50jRJ0qPmYLU6+aGOEGiHCpjp2bVpNGY
 nEdD9hgxsIyRwxzwDPVMFVp55biZLg0017+65yJKyLuMWjSLYzTUcwQrWXPzDqZs0H4D
 D6k82SVP4x5gd6dyTQvQrottjBGcsRPBEiVfM1OAEx+ucohFcfM64ugpjKzEahtCb7fl
 yLJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1734091071; x=1734695871;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=i5VzB2z9ek0RR+JcjyK/7F6+wpnR7nxaRt58CIUmlmc=;
 b=GLdwGgLLV1vLVhTojSGeEJkNxDWnPsISni3nJVm3aAUlvgpyhVumRr+eqUBu2d/zj9
 loFt8qiZTphae+JQ/TTq6t0evP1bIMirFtniQ17VcAiGY6khF79jIgOSngZLBOSKcOpO
 RJfNeDvYRQeuBVdTCd+bRcNnm4Fy6ot4jNo6NO3J2ARwkpH6trW9MdC2uon71SjWt4wR
 Qh6Y3v/twrJ0NcoeZuHR+5C0Wppx/CFmxQNPEbznCrvK9F2HCBFehevBOSfXbbeCf8Kh
 EeIC0Wrbc8GNkQOt03hbGULUxyZ9vdTzVXURxsDv5oLj5fNSli7j576ZOoaMCjBCzQE+
 Ar3A==
X-Gm-Message-State: AOJu0YzImW/pMbwZg2QdkXdr/QYaiDqTh+7zHf+spJL40Y10CLocZtvj
 0Dm7cYdbt5a1nV6QnAF36BfA4jY5PUppenM9yudICBlg+ORNjcs/Q81+Hw==
X-Gm-Gg: ASbGncsW5Xw8+zTFyHE0HqLqokpBAp5d2DHr936IXXMA7Qy5CpNQqaA+G2YPSxmJ124
 QjLEsG3drfcxYK2zUf8z8sVGSbKK4IXDUbxBOA5ve83dx1/Awz/OLmaHLKN+TFV1VyOZhNox6hi
 tVQQi3xzzhGBtyrJPVcNXq8c2Ul1CADhrpeKLnmd/oWc5ewxVBFYDwp4J6VtUUeaSg7gMkhui7c
 EaiMOVKa7/ncwvmxWlI9gCNMQqpIO8XpM+EppLJ8L50B8DX5Ayc
X-Google-Smtp-Source: AGHT+IEyD96/rIQjDZFHieYKobk/tqDyAaeqOHWKMUFdq2rUqpipF+8/Z77Wz9ZH+OOQjmdZHolryw==
X-Received: by 2002:a05:6000:402a:b0:386:459e:655d with SMTP id
 ffacd0b85a97d-38880ad1066mr1657839f8f.20.1734091070876; 
 Fri, 13 Dec 2024 03:57:50 -0800 (PST)
Received: from lili ([148.60.59.223]) by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-3878251bcabsm7088247f8f.87.2024.12.13.03.57.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 13 Dec 2024 03:57:50 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
In-Reply-To: <yb2zy4gw4qtgdi7rqqhy4ix52ljbspifh7l2mvstwcodfglfb4@fvmb24btljly>
References: <mjgot2cwzzfhicsyobhubmc3dsbviysha56nqt4c3epp3emdrc@4ovou422lxuv>
 <877c87zfz4.fsf@HIDDEN>
 <yb2zy4gw4qtgdi7rqqhy4ix52ljbspifh7l2mvstwcodfglfb4@fvmb24btljly>
Date: Fri, 13 Dec 2024 12:57:44 +0100
Message-ID: <87bjxf6bif.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

On Wed, 11 Dec 2024 at 12:48, Gabriel Wicki <gabriel@HIDDEN> wrote:

> If you have any idea on how to patch that and could point me in that
> direction, I'll gladly send in a patch or two!

It needs to replace the phases something like:

--8<---------------cut here---------------start------------->8---
1 file changed, 16 insertions(+)
gnu/packages/django.scm | 16 ++++++++++++++++

modified   gnu/packages/django.scm
@@ -99,6 +99,22 @@ (define-public python-django-4.2
                    (setenv "PYTHONPATH" "..")
                    (apply invoke "python" "runtests.py" test-flags))
                  (format #t "test suite not run~%"))))
+         (replace 'patch-source-shebangs
+           (lambda _
+             (for-each patch-shebang
+                       (find-files "."
+                                   (lambda (file stat)
+                                     (and (eq? 'regular (stat:type stat))
+                                          (not (string-suffix? "py-tpl" file))))
+                                   #:stat lstat))))
+         (replace 'patch-generated-file-shebangs
+           (lambda _
+             (for-each patch-shebang
+                       (find-files "."
+                                   (lambda (file stat)
+                                     (and (eq? 'regular (stat:type stat))
+                                          (not (string-suffix? "py-tpl" file))))
+                                   #:stat lstat))))
          ;; XXX: The 'wrap' phase adds native inputs as runtime dependencies,
          ;; see <https://bugs.gnu.org/25235>.  The django-admin script typically
          ;; runs in an environment that has Django and its dependencies on
--8<---------------cut here---------------end--------------->8---

Feel free to submit a patch. :-)

Cheers,
simon

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.