Received: (at 73827-done) by debbugs.gnu.org; 13 Feb 2025 10:23:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 05:23:12 2025 Received: from localhost ([127.0.0.1]:40755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiWNE-00066j-0F for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:23:12 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:50284) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tiWNB-00066T-6N for 73827-done <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:23:10 -0500 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5deb1b8e1bcso1297991a12.0 for <73827-done <at> debbugs.gnu.org>; Thu, 13 Feb 2025 02:23:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739442183; x=1740046983; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=0cL25/1MH+2nVmpVcGzkA+Eo8Y1xLOEbpkuEXB8bcZU=; b=BmqqU6g9aS+EJ7nRGNmSTpYpYlp6oosVwGEv9hlhvTCpTzVZooMULxAiDWNvSAgI9J OjtS0FgIh2CLFXUanvnbbdfsXGz91tvxTtXk94KwWiKfmcMfQmQu/Xr1/Z/tpX41UW6g u1PfDSGx8s+ILAi+Q/6nz8wijoXszmJPXthfYBdbjd2gRUmoiKeDZLBsBGZG3QcQzCJI 6E/wEhqQAgV3mAgIqrWcPbG71xELktuomp+iHj8PEJzONiQQrBqhsjMNzob1ZgM1PtaN qWAk5zTOgQs48P29GCJvBpJWblGwRFbtXZID6R72ykqI1jo4niwuZgwRgAGVmLac4INv CDbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739442183; x=1740046983; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0cL25/1MH+2nVmpVcGzkA+Eo8Y1xLOEbpkuEXB8bcZU=; b=rGOoYHY4dvBSee04cI6ICENIk3FO68gLq8cVbhInO1XznDe9LBFdx5y3F56sBd45uG gPdDCGaOvFszZRj7mgJaXC0MtQhjUt56+PwPeJSz/S8A+ndaEmXAy5i8O2g4tuEN3VLf WqNs0iPrV6+I5mD/04otBPTgYPiMfJml3rPisKbNPiGzQP1k5IS/Xdf6Zfr5x9z4ltG5 ELlY7ysKLNo1kewzd01tlyWZ+bNcHZaSYZgdyUS/UyjKzxrEqrqoin5nvjujwun2XqJf Rb2xexTM7pVyjFEZnhrcap/GxzOh+a94kJwluFDjXvserx5nQXAp5V7gckJeUX9lu/3n a43A== X-Forwarded-Encrypted: i=1; AJvYcCW4zlZhcIReHdWDdBb+nxH2WGdggZJHtU8ZipjMP8VTsQ+VJphWVS1D3XTBG6rlZLLrswSIx4nLgBDX <at> debbugs.gnu.org X-Gm-Message-State: AOJu0Yz3teJF97jKv1t4jaa5yoOQ7p+EQRc+b09xUOh5Sop8W2OIvKUS EPx3EvcXp3ZLPiA5PTUzjusCt1jZ+jH+AWaSPUgiR6M1uKfFUyKg11zpVoTeOYPYkCQs4gjok3I HsGuQz6a7XR39vA4IIpgpexH1w/I= X-Gm-Gg: ASbGncs4V2d+3w3mFt5sAOa9K8ynsUy0D5xC4Za/8OuzOOfxUOOnbI8JmXaEG5rE+p+ kybAoKp2ITah32eKDc28ee9PU3+yOk4hOpl1d4rKHAD4jAiYUE/i9JQ43jCqBxvKVgbPIgxWYFd 0= X-Google-Smtp-Source: AGHT+IEjYa6aMOEAQJy/qyBN+cSR0xBQflBXS2xMzLAkhHEJhV7PkZOaclfEuEhJsNRaP1jwsd+ryi6BE4yjcHLZYUY= X-Received: by 2002:a05:6402:35d3:b0:5de:aa54:dc30 with SMTP id 4fb4d7f45d1cf-5dec9d3233cmr2005112a12.5.1739442182865; Thu, 13 Feb 2025 02:23:02 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Feb 2025 02:23:02 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CADwFkm=d6=Q=UxvXua7S4SnTP44kXkcFJr4zMpjryX_sZX38Eg@HIDDEN> References: <m2jze9argx.fsf@HIDDEN> <87ldynk8un.fsf@HIDDEN> <m2frov5tzw.fsf@HIDDEN> <m28qt6nch8.fsf@HIDDEN> <87ttbtd6ga.fsf@HIDDEN> <CADwFkm=d6=Q=UxvXua7S4SnTP44kXkcFJr4zMpjryX_sZX38Eg@HIDDEN> MIME-Version: 1.0 Date: Thu, 13 Feb 2025 02:23:02 -0800 X-Gm-Features: AWEUYZmf_zr8sWdffAW0OLKy20-nLOFWrYkZLGl6oJTZO_Amz8qAyrvJ5RcSPQU Message-ID: <CADwFkmkK4kfK0NfR36tdnqP5YTKcTzyHYnBTyQkOUTSRAmAiXg@HIDDEN> Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers To: Jeremy Bryant <jb@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73827-done Cc: Philip Kaludercic <philipk@HIDDEN>, 73827-done <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>, Alex Bochannek <alex@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Kangas <stefankangas@HIDDEN> writes: > Jeremy Bryant <jb@HIDDEN> writes: > >> Alex Bochannek <alex@HIDDEN> writes: >> >>> Anything else that's needed from me here? I have another trivial fix for >>> register-list I would like to submit. >> >> Thanks alex for your contribution. >> >> Adding Philip, any comments or suggestions on this short ELPA patch? > > Ping, Philip and/or Stefan M. Actually, the patch was quite trivial, and there was already an LGTM, so I went ahead and pushed it. Feel free to revert, and so on. Boldly closing this bug report. Thanks Alex, for your contribution to Emacs.
Alex Bochannek <alex@HIDDEN>
:Stefan Kangas <stefankangas@HIDDEN>
:Received: (at 73827) by debbugs.gnu.org; 12 Feb 2025 00:04:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 19:04:20 2025 Received: from localhost ([127.0.0.1]:59578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ti0Em-00028e-1U for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 19:04:20 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47442) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1ti0Eg-00028K-Pv for 73827 <at> debbugs.gnu.org; Tue, 11 Feb 2025 19:04:17 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A9B5044325E; Tue, 11 Feb 2025 19:04:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1739318647; bh=81rCUjfSQWBukE4qxpoyaMK0sz71wzPdimhGOAhmVBI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XkLGM0/sZiVUqPEfGLrvzICWhWqptlvoIp7N9uReWdDPjh/ozxxK6PJ/RKJLPOZpE EoAo9U+rycBJqSgofDB9ST8aOAYnYYFJsShEKwx8jQ0mavH4CGkRO86oHVQKxernih zc92TT4BtoaMeKBTqYGKF88Cu8AGPWIrhjv85DWs3IAdEQV+i2Rl0R2+8MN8Zy+YBN yw0aPzn/nxkEs/jThq+WcWyeolkusl9V9f1vOHjD1NKDa768WCP3mykkFXE/aob39D qYPacMpfpB/yO+W5ZblUiROk2sejRdd/XLVe+er+SgotEwkqWM7HfOHR/HZdpQmzEI ooSApfQpmQ1Xw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B349C443289; Tue, 11 Feb 2025 19:04:07 -0500 (EST) Received: from pastel (104-195-232-86.cpe.teksavvy.com [104.195.232.86]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7D9781201E0; Tue, 11 Feb 2025 19:04:07 -0500 (EST) From: Stefan Monnier <monnier@HIDDEN> To: Philip Kaludercic <philipk@HIDDEN> Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers In-Reply-To: <87mshl7j6m.fsf@HIDDEN> (Philip Kaludercic's message of "Tue, 26 Nov 2024 21:56:49 +0000") Message-ID: <jwv1pw49gud.fsf-monnier+emacs@HIDDEN> References: <m2jze9argx.fsf@HIDDEN> <87mshl7j6m.fsf@HIDDEN> Date: Tue, 11 Feb 2025 19:04:06 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73827 Cc: 73827 <at> debbugs.gnu.org, Alex Bochannek <alex@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) >> @@ -483,8 +483,8 @@ >> (t "error")) >> (cond ((window-configuration-p (car key)) "W") >> ((frame-configuration-p (car key)) "F") >> - ((stringp (car key)) "R") >> ((string= "Unprintable entity" (car key)) "?") > > The change confuses me, are we sure that (car key) must be a string at > this point? If not, should be prefer `equal' over `string='? The `string=` was wrong (if we get to that branch we know it's not a string) and should be `equal`, indeed. It's an orthogonal problem to the one the OP is solving, tho. The patch looks fine to me, tho I have no idea how desktop's "Unprintable entity" can end up in this position: I think this points to a bug elsewhere. Stefan
bug-gnu-emacs@HIDDEN
:bug#73827
; Package emacs
.
Full text available.Received: (at 73827) by debbugs.gnu.org; 11 Feb 2025 19:19:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 14:19:33 2025 Received: from localhost ([127.0.0.1]:58665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thvnA-0003OW-PD for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:19:33 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:58611) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1thvn7-0003OB-KN for 73827 <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:19:30 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5de4f4b0e31so7538214a12.0 for <73827 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 11:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739301563; x=1739906363; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=uHjc4QMIYjF9YRM9deJlo9wW1aedu916eAVKQQh7k0I=; b=Bh2qnhSefHO1EsboBJIoGzo41nx0gM60TSnTdd5MKFWLCRFlHXkGh3iUc8A6F2NrTQ Zjmf+hT35Wu90WRW372p3DC3z2XFM8US+twtZEZRf3rnOxuV+bu9zC6d/kHwc0Cd/vSj neGRlKdd0UqZxxuDOk23NWe/wk8HCrMrD+VtI0PuyW0GuB18DBtwzOpI0yCkJCfeKVce 33Z0Rl3fIRxG3iT9JstX0aQ3eThJKCba3dltKfePImrob4h5HlyLPqFTPPf5RXlLHv8a /zZjoqba8zWXmER0GAhXPHLlNZ76TdZkm6C/tLKrQuAs9s2HwfcjmF7wvNsLROnfJMXu D6ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739301563; x=1739906363; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uHjc4QMIYjF9YRM9deJlo9wW1aedu916eAVKQQh7k0I=; b=br5i0Lm9WDIzX2sodfPQQQUtt6X60gd5qLQ/FdXY2PbZtGUSS1Lv8rLw5qQXKlRs3a UkaHAwocDVZetTwxMY4qlpH56VNAKghLQbcrnGMwv3XIlq2oBombHYMIdO7DE2g5ioFL lP5InfrfoVuUUiAt0wUe+AxvoSsHyOsE7fDcBRFZQws2dpyrLl4Dfm8VgLwuZrhEw2Vl WyhPLB649O3uoeiEHzKBA+Cl5QCI6/4l+Q7wW2f6UgBxP0YdTY0jol+2LFJIf5G2zOay gKInJBeFcgncaH8e4Z/tffzAiFpyn7wf+agGk2dAFNqUfXoyfHT8LUief4iX5ofSwG2n ndEw== X-Forwarded-Encrypted: i=1; AJvYcCXWe2glwmcJm+kvVNtPG4atiolNptltS3m5QP+I7JAxVdMziqLihK/LOOiETyTzkqAqvDvr3g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyUiteaOyXw91n0lv3BveYkyg8r2R00Dgw3k9V970t7RpKhxUsG 8iGJGTVFX6OZK481xAzr5poJqTNDfCXoEacwwUkkJgyLI6GPXpk64EVtpGyX6M1Z715bYAhjFmb AuRLw9HtNtDbNh9Yod8j3SsP7pzs= X-Gm-Gg: ASbGnctqYYKKWGNMSKeMPTN5ADSoVxv7ymGrecetc19qxf6Umr1UgyzfIM7gj3lJTWO UQ4SB0lFZppfy7B7duoTtRM57EUCQg//zuQb8V1dcUybaS1AqdrggDIEpT5jN8YitP89wq3ts4Q == X-Google-Smtp-Source: AGHT+IGuMw5rRPdJ70lO0ByyOla1VR2o0mPJTi6GzqTafzDDbzMZYSbT8EWjgwBzZdQjnV1vs8lhcqdq+QUNgQuVTHU= X-Received: by 2002:a05:6402:238d:b0:5de:a76c:9c7c with SMTP id 4fb4d7f45d1cf-5deaddb918cmr296221a12.17.1739301563412; Tue, 11 Feb 2025 11:19:23 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 11:19:22 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87ttbtd6ga.fsf@HIDDEN> References: <m2jze9argx.fsf@HIDDEN> <87ldynk8un.fsf@HIDDEN> <m2frov5tzw.fsf@HIDDEN> <m28qt6nch8.fsf@HIDDEN> <87ttbtd6ga.fsf@HIDDEN> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 11:19:22 -0800 X-Gm-Features: AWEUYZnMwRDlTqD_d3ayelLf_B21uSJknaOHNN1Np6IO-5u1ENdmt-VI8Q2dAYU Message-ID: <CADwFkm=d6=Q=UxvXua7S4SnTP44kXkcFJr4zMpjryX_sZX38Eg@HIDDEN> Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers To: Jeremy Bryant <jb@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73827 Cc: Philip Kaludercic <philipk@HIDDEN>, 73827 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>, Alex Bochannek <alex@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Jeremy Bryant <jb@HIDDEN> writes: > Alex Bochannek <alex@HIDDEN> writes: > >> Anything else that's needed from me here? I have another trivial fix for >> register-list I would like to submit. > > Thanks alex for your contribution. > > Adding Philip, any comments or suggestions on this short ELPA patch? Ping, Philip and/or Stefan M.
bug-gnu-emacs@HIDDEN
:bug#73827
; Package emacs
.
Full text available.Received: (at 73827) by debbugs.gnu.org; 27 Nov 2024 01:39:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 26 20:39:33 2024 Received: from localhost ([127.0.0.1]:55625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tG71h-0005Tl-32 for submit <at> debbugs.gnu.org; Tue, 26 Nov 2024 20:39:33 -0500 Received: from ns.lapseofthought.com ([50.0.39.240]:12197 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alex@HIDDEN>) id 1tG71c-0005TW-Ah for 73827 <at> debbugs.gnu.org; Tue, 26 Nov 2024 20:39:31 -0500 Received: from awb-mbp-m3.local (c-24-23-131-202.hsd1.ca.comcast.net [24.23.131.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Xyhtz58Nrz3pn9m; Tue, 26 Nov 2024 17:39:23 -0800 (PST) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@HIDDEN From: Alex Bochannek <alex@HIDDEN> To: Philip Kaludercic <philipk@HIDDEN> Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers In-Reply-To: <87mshl7j6m.fsf@HIDDEN> (Philip Kaludercic's message of "Tue, 26 Nov 2024 21:56:49 +0000") References: <m2jze9argx.fsf@HIDDEN> <87mshl7j6m.fsf@HIDDEN> Date: Tue, 26 Nov 2024 17:39:22 -0800 Message-ID: <m2cyihjvzp.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73827 Cc: 73827 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Philip Kaludercic <philipk@HIDDEN> writes: > Alex Bochannek <alex@HIDDEN> writes: > >> --- /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el.~1~ 2023-01-10 19:36:23 >> +++ /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el 2024-10-15 15:49:37 >> @@ -483,8 +483,8 @@ >> (t "error")) >> (cond ((window-configuration-p (car key)) "W") >> ((frame-configuration-p (car key)) "F") >> - ((stringp (car key)) "R") >> ((string= "Unprintable entity" (car key)) "?") > > The change confuses me, are we sure that (car key) must be a string at > this point? If not, should be prefer `equal' over `string='? > >> + ((stringp (car key)) "R") The change simply swaps the stringp and string= predicates in the cond. If there is a register with "Unprintable entity" (which desktop.el produces), it would not show up correctly as a "?" (assuming "?" has been added to register-list-default-type). Looking at register-alist in my .emacs.desktop, it is always the string "Unprintable entity" and never a symbol. Whether it's string= or equal shouldn't matter, because the difference in error handling between the two isn't relevant here. Unrelated, I looked into how to get frameset support in register-list and the way framesets are stored in register-alist is very different. I'll submit another patch for that, although it isn't particularly elegant. > You can try out > > M-x package-vc-install register-list RET > > that should give you a checkout. You can then make your changes as > usual and then prepare a patch using vc-prepare-patch or git-format-patch(1). Perfect, thank you! Didn't know about package-vc-install. -- Alex.
bug-gnu-emacs@HIDDEN
:bug#73827
; Package emacs
.
Full text available.Received: (at 73827) by debbugs.gnu.org; 26 Nov 2024 21:56:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 26 16:56:59 2024 Received: from localhost ([127.0.0.1]:54434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tG3YJ-0003CI-8j for submit <at> debbugs.gnu.org; Tue, 26 Nov 2024 16:56:59 -0500 Received: from mout02.posteo.de ([185.67.36.66]:47553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1tG3YH-0003C3-MS for 73827 <at> debbugs.gnu.org; Tue, 26 Nov 2024 16:56:58 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3A402240103 for <73827 <at> debbugs.gnu.org>; Tue, 26 Nov 2024 22:56:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1732658211; bh=w/e0qxg9VcteuJ/kH2wWj79Lp1RJxJVN0C+z64yAGEI=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=nLVash65LQH1wGLcWMT9t60xUcM4hgfE8otJS34DWhq7HtDP+ZYgkf8cyPHdAb4kU ePpwtnjDkBZ4Ud3zd09vQcEpg2b0GxPJLucoaL4rfraM4qKtZMGM8DVhb1OerSqy6q OQJxyG2uxtdTVEOb7lJxkqQA5axIhBGxxriR44YLNb/0f5gqXs+mncamOooEU96pdR t1ic6AwfkvK6IkbqYhyMOjLQcUnxYfy45dKJh2K8Xq3pDm65u1wIRK/0Fl3HDcf/DS Zx2c+6kYgbaJMoKQTu3t+yPgRC47A3pj1cJBPwKlkLjE5sTbGqEREB4VaDmEJMQzrA NX4hkdGzu9Pbg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XybyB3BPyz6tw3; Tue, 26 Nov 2024 22:56:49 +0100 (CET) From: Philip Kaludercic <philipk@HIDDEN> To: Alex Bochannek <alex@HIDDEN> Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers In-Reply-To: <m2jze9argx.fsf@HIDDEN> (Alex Bochannek's message of "Tue, 15 Oct 2024 16:14:54 -0700") References: <m2jze9argx.fsf@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@HIDDEN; url="https://keys.openpgp.org/vks/v1/by-email/philipk@HIDDEN"; preference=signencrypt Date: Tue, 26 Nov 2024 21:56:49 +0000 Message-ID: <87mshl7j6m.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 73827 Cc: 73827 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Alex Bochannek <alex@HIDDEN> writes: > Hello! > > I have not submitted patches against an ELPA package before, so I hope > this format is OK. I tried to follow the instruction on pulling ELPA > from Git, but the make step failed for me. > > The register-list mode throws an error on start-up when there are > unknown register types in the register-alist. This can happen with > window configurations and saved session state after a restart. The > reason for this is a simple line flip in the register-list-get-type > function. > > --- /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el.~1~ 2023-01-10 19:36:23 > +++ /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el 2024-10-15 15:49:37 > @@ -483,8 +483,8 @@ > (t "error")) > (cond ((window-configuration-p (car key)) "W") > ((frame-configuration-p (car key)) "F") > - ((stringp (car key)) "R") > ((string= "Unprintable entity" (car key)) "?") The change confuses me, are we sure that (car key) must be a string at this point? If not, should be prefer `equal' over `string='? > + ((stringp (car key)) "R") > (t "error")))) > > ;;; Edit key/value of the register > > > Apologies again for the format of this submission. If someone could > point me at instructions for how to make your life easier next time, I'd > appreciate it. You can try out M-x package-vc-install register-list RET that should give you a checkout. You can then make your changes as usual and then prepare a patch using vc-prepare-patch or git-format-patch(1). > Thanks!
bug-gnu-emacs@HIDDEN
:bug#73827
; Package emacs
.
Full text available.Received: (at 73827) by debbugs.gnu.org; 26 Nov 2024 21:35:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 26 16:35:31 2024 Received: from localhost ([127.0.0.1]:53726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tG3DW-0001rj-J1 for submit <at> debbugs.gnu.org; Tue, 26 Nov 2024 16:35:30 -0500 Received: from out-182.mta1.migadu.com ([95.215.58.182]:38792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jb@HIDDEN>) id 1tG3DT-0001rP-7E for 73827 <at> debbugs.gnu.org; Tue, 26 Nov 2024 16:35:28 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1732656921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K7P/R8ErzP9r34e1vNWWPW9BlLoLkka49jITaxEpZi0=; b=hP7QiiGPU6Hni+VRE+G6ePdjsVZxzd5Acu/8IrsWuNOUjaBA7tOpUp4a3TYIylPUrn7UJS cLQ6UvXqqwkcCIEe5gxmVY5VoC7mvc7yoqZZvJ7OTDy0qtT8NsXajoyiKJ2+Efnggl8mAZ S2K9HGLNlqlCHOLDli0Y0XG8XKntSPfp516yRIWfFM9q4w5cR2bhxHTz8MmtSrbh6oAq81 PjHkdH9VSBQpNswAwa9fqGYCDxfIw/zIR9ETSY990pAS1QQow59Rq4+YpicyEKYKfZ3Q7v 0OuUCbw4vLQr69pEzFxSXrOI41xuyZSaZBjjkTbRdqQrCbkTh2ib+mL7Lpqw6A== From: Jeremy Bryant <jb@HIDDEN> To: Alex Bochannek <alex@HIDDEN> Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers In-Reply-To: <m28qt6nch8.fsf@HIDDEN> (Alex Bochannek's message of "Mon, 25 Nov 2024 15:02:43 -0800") References: <m2jze9argx.fsf@HIDDEN> <87ldynk8un.fsf@HIDDEN> <m2frov5tzw.fsf@HIDDEN> <m28qt6nch8.fsf@HIDDEN> Date: Tue, 26 Nov 2024 21:35:17 +0000 Message-ID: <87ttbtd6ga.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 73827 Cc: Philip Kaludercic <philipk@HIDDEN>, 73827 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Alex Bochannek <alex@HIDDEN> writes: > Anything else that's needed from me here? I have another trivial fix for > register-list I would like to submit. Thanks alex for your contribution. Adding Philip, any comments or suggestions on this short ELPA patch? > > Thanks! > > Alex Bochannek <alex@HIDDEN> writes: > >> Jeremy Bryant <jb@HIDDEN> writes: >> >>> Alex Bochannek <alex@HIDDEN> writes: >>> >>>> Hello! >>>> >>>> I have not submitted patches against an ELPA package before, so I hope >>> >>> Philip, any comments? >>> >>>> >>>> Apologies again for the format of this submission. If someone could >>>> point me at instructions for how to make your life easier next time, I'd >>>> appreciate it. >>> >>> Please read the file CONTRIBUTE in the Emacs source tree. >> >> Figured out my issue with populating the ELPA repo (new computer, old >> version of gmake) and I am including the patch in the proper format now. >> >> From dafcff7c7a9cb6952aa740ef34a67eb61fd2a90d Mon Sep 17 00:00:00 2001 >> From: Alex Bochannek <alex@HIDDEN> >> Date: Wed, 16 Oct 2024 19:35:33 -0700 >> Subject: [PATCH] Fix unprintable register display logic >> >> --- >> register-list.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/register-list.el b/register-list.el >> index 846d3efe49..5a81b1b7bb 100644 >> --- a/register-list.el >> +++ b/register-list.el >> @@ -478,8 +478,8 @@ the register or copy its value into the kill ring." >> (t "error")) >> (cond ((window-configuration-p (car key)) "W") >> ((frame-configuration-p (car key)) "F") >> - ((stringp (car key)) "R") >> ((string= "Unprintable entity" (car key)) "?") >> + ((stringp (car key)) "R") >> (t "error")))) >> >> ;;; Edit key/value of the register >> -- >> 2.39.5 (Apple Git-154)
bug-gnu-emacs@HIDDEN
:bug#73827
; Package emacs
.
Full text available.Received: (at 73827) by debbugs.gnu.org; 25 Nov 2024 23:02:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 25 18:02:50 2024 Received: from localhost ([127.0.0.1]:42710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tFi6T-00020p-Qm for submit <at> debbugs.gnu.org; Mon, 25 Nov 2024 18:02:50 -0500 Received: from ns.lapseofthought.com ([50.0.39.240]:62168 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alex@HIDDEN>) id 1tFi6R-00020g-AM for 73827 <at> debbugs.gnu.org; Mon, 25 Nov 2024 18:02:48 -0500 Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:addd:a64e:a406:ac0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Xy1Sh3wGzz3pjJN; Mon, 25 Nov 2024 15:02:44 -0800 (PST) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@HIDDEN From: Alex Bochannek <alex@HIDDEN> To: Jeremy Bryant <jb@HIDDEN> Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers In-Reply-To: <m2frov5tzw.fsf@HIDDEN> (Alex Bochannek's message of "Wed, 16 Oct 2024 19:43:47 -0700") References: <m2jze9argx.fsf@HIDDEN> <87ldynk8un.fsf@HIDDEN> <m2frov5tzw.fsf@HIDDEN> Date: Mon, 25 Nov 2024 15:02:43 -0800 Message-ID: <m28qt6nch8.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73827 Cc: 73827 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Anything else that's needed from me here? I have another trivial fix for register-list I would like to submit. Thanks! Alex Bochannek <alex@HIDDEN> writes: > Jeremy Bryant <jb@HIDDEN> writes: > >> Alex Bochannek <alex@HIDDEN> writes: >> >>> Hello! >>> >>> I have not submitted patches against an ELPA package before, so I hope >> >> Philip, any comments? >> >>> >>> Apologies again for the format of this submission. If someone could >>> point me at instructions for how to make your life easier next time, I'd >>> appreciate it. >> >> Please read the file CONTRIBUTE in the Emacs source tree. > > Figured out my issue with populating the ELPA repo (new computer, old > version of gmake) and I am including the patch in the proper format now. > > From dafcff7c7a9cb6952aa740ef34a67eb61fd2a90d Mon Sep 17 00:00:00 2001 > From: Alex Bochannek <alex@HIDDEN> > Date: Wed, 16 Oct 2024 19:35:33 -0700 > Subject: [PATCH] Fix unprintable register display logic > > --- > register-list.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/register-list.el b/register-list.el > index 846d3efe49..5a81b1b7bb 100644 > --- a/register-list.el > +++ b/register-list.el > @@ -478,8 +478,8 @@ the register or copy its value into the kill ring." > (t "error")) > (cond ((window-configuration-p (car key)) "W") > ((frame-configuration-p (car key)) "F") > - ((stringp (car key)) "R") > ((string= "Unprintable entity" (car key)) "?") > + ((stringp (car key)) "R") > (t "error")))) > > ;;; Edit key/value of the register > -- > 2.39.5 (Apple Git-154) -- Alex.
bug-gnu-emacs@HIDDEN
:bug#73827
; Package emacs
.
Full text available.Received: (at 73827) by debbugs.gnu.org; 17 Oct 2024 02:44:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 16 22:44:17 2024 Received: from localhost ([127.0.0.1]:32842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1t1GUq-0003ty-NL for submit <at> debbugs.gnu.org; Wed, 16 Oct 2024 22:44:16 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:63945 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alex@HIDDEN>) id 1t1GUl-0003tk-1y for 73827 <at> debbugs.gnu.org; Wed, 16 Oct 2024 22:44:14 -0400 Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:b502:e338:b669:d22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4XTXGD1fVcz3pftt; Wed, 16 Oct 2024 19:43:48 -0700 (PDT) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@HIDDEN From: Alex Bochannek <alex@HIDDEN> To: Jeremy Bryant <jb@HIDDEN> Subject: Re: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers In-Reply-To: <87ldynk8un.fsf@HIDDEN> (Jeremy Bryant's message of "Wed, 16 Oct 2024 22:59:12 +0100") References: <m2jze9argx.fsf@HIDDEN> <87ldynk8un.fsf@HIDDEN> Date: Wed, 16 Oct 2024 19:43:47 -0700 Message-ID: <m2frov5tzw.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 73827 Cc: 73827 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Jeremy Bryant <jb@HIDDEN> writes: > Alex Bochannek <alex@HIDDEN> writes: > >> Hello! >> >> I have not submitted patches against an ELPA package before, so I hope > > Philip, any comments? > >> >> Apologies again for the format of this submission. If someone could >> point me at instructions for how to make your life easier next time, I'd >> appreciate it. > > Please read the file CONTRIBUTE in the Emacs source tree. Figured out my issue with populating the ELPA repo (new computer, old version of gmake) and I am including the patch in the proper format now. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-unprintable-register-display-logic.patch From dafcff7c7a9cb6952aa740ef34a67eb61fd2a90d Mon Sep 17 00:00:00 2001 From: Alex Bochannek <alex@HIDDEN> Date: Wed, 16 Oct 2024 19:35:33 -0700 Subject: [PATCH] Fix unprintable register display logic --- register-list.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/register-list.el b/register-list.el index 846d3efe49..5a81b1b7bb 100644 --- a/register-list.el +++ b/register-list.el @@ -478,8 +478,8 @@ the register or copy its value into the kill ring." (t "error")) (cond ((window-configuration-p (car key)) "W") ((frame-configuration-p (car key)) "F") - ((stringp (car key)) "R") ((string= "Unprintable entity" (car key)) "?") + ((stringp (car key)) "R") (t "error")))) ;;; Edit key/value of the register -- 2.39.5 (Apple Git-154) --=-=-= Content-Type: text/plain -- Alex. --=-=-=--
bug-gnu-emacs@HIDDEN
:bug#73827
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 15 Oct 2024 23:25:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 15 19:25:18 2024 Received: from localhost ([127.0.0.1]:57807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1t0quk-0003CE-7y for submit <at> debbugs.gnu.org; Tue, 15 Oct 2024 19:25:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:38464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alex@HIDDEN>) id 1t0quh-0003C2-Ry for submit <at> debbugs.gnu.org; Tue, 15 Oct 2024 19:25:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <alex@HIDDEN>) id 1t0quO-0000yI-Ok for bug-gnu-emacs@HIDDEN; Tue, 15 Oct 2024 19:24:56 -0400 Received: from ns.lapseofthought.com ([50.0.39.240] helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <alex@HIDDEN>) id 1t0quM-0005BM-Rn for bug-gnu-emacs@HIDDEN; Tue, 15 Oct 2024 19:24:56 -0400 Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:25db:c231:73d0:4c41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4XSqgg51dZz3pfcw for <bug-gnu-emacs@HIDDEN>; Tue, 15 Oct 2024 16:14:55 -0700 (PDT) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@HIDDEN From: Alex Bochannek <alex@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers Date: Tue, 15 Oct 2024 16:14:54 -0700 Message-ID: <m2jze9argx.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@HIDDEN; helo=mail.lapseofthought.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello! I have not submitted patches against an ELPA package before, so I hope this format is OK. I tried to follow the instruction on pulling ELPA from Git, but the make step failed for me. The register-list mode throws an error on start-up when there are unknown register types in the register-alist. This can happen with window configurations and saved session state after a restart. The reason for this is a simple line flip in the register-list-get-type function. --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el.~1~ 2023-01-10 19:36:23 +++ /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el 2024-10-15 15:49:37 @@ -483,8 +483,8 @@ (t "error")) (cond ((window-configuration-p (car key)) "W") ((frame-configuration-p (car key)) "F") - ((stringp (car key)) "R") ((string= "Unprintable entity" (car key)) "?") + ((stringp (car key)) "R") (t "error")))) ;;; Edit key/value of the register --=-=-= Content-Type: text/plain Apologies again for the format of this submission. If someone could point me at instructions for how to make your life easier next time, I'd appreciate it. Thanks! -- Alex. --=-=-=--
Alex Bochannek <alex@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#73827
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.