GNU logs - #73930, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#73930] [PATCH] gnu: git-repo: Update to 2.29.7
Resent-From: =?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?= <sepeth@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 21 Oct 2024 13:50:03 +0000
Resent-Message-ID: <handler.73930.B.17295185778847 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 73930 <at> debbugs.gnu.org
Cc: =?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?= <sepeth@HIDDEN>
Feedback-ID: i57994943:Fastmail
From: =?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?= <sepeth@HIDDEN>
Date: Mon, 21 Oct 2024 15:00:11 +0200
Message-ID: <b1b8392ce548bc6cefa04d92331d7a794182813b.1729515611.git.sepeth@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=103.168.172.159; envelope-from=sepeth@HIDDEN;
 helo=fhigh-a8-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Mon, 21 Oct 2024 09:49:25 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Fixes ModuleNotFoundError: No module named 'formatter'.
This module was deprecated, and removed in Python 3.10.

* gnu/packages/android.scm (git-repo): Update to 2.29.7

Change-Id: I74d48fd9a8afc76c18d866b252a139f77b7ab838
---
 gnu/packages/android.scm | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index 11e05dced9..0f41fa8695 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -919,7 +919,7 @@ (define-public etc1tool
 (define-public git-repo
   (package
     (name "git-repo")
-    (version "2.4.1")
+    (version "2.29.7")
     (source
      (origin
        (method git-fetch)
@@ -928,7 +928,7 @@ (define-public git-repo
              (commit (string-append "v" version))))
        (file-name (string-append "git-repo-" version "-checkout"))
        (sha256
-        (base32 "0khg1731927gvin73dcbw1657kbfq4k7agla5rpzqcnwkk5agzg3"))))
+        (base32 "01sl9bz9rnhf9s3h7nlhkpxm0ggc5jzs30n11vlvnv2mqp8r1jvq"))))
     (build-system python-build-system)
     (arguments
      `(#:phases
@@ -1000,12 +1000,11 @@ (define-public git-repo
                (symlink (string-append repo-dir "/repo")
                         (string-append bin-dir "/repo"))
                #t))))))
-    (inputs
      ;; TODO: Add git-remote-persistent-https once it is available in guix
-     `(("git" ,git)
-       ("ssh" ,openssh)))
+    (inputs
+      (list git openssh gnupg))
     (native-inputs
-     `(("pytest" ,python-pytest)))
+      (list python-pytest))
     (home-page "https://code.google.com/p/git-repo/")
     (synopsis "Helps to manage many Git repositories")
     (description "Repo is a tool built on top of Git.  Repo helps manage many

base-commit: 59b2a60d0041882d732e1766e28f0df5a1ef1ac1
-- 
2.46.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: =?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?= <sepeth@HIDDEN>
Subject: bug#73930: Acknowledgement ([PATCH] gnu: git-repo: Update to 2.29.7)
Message-ID: <handler.73930.B.17295185778847.ack <at> debbugs.gnu.org>
References: <b1b8392ce548bc6cefa04d92331d7a794182813b.1729515611.git.sepeth@HIDDEN>
X-Gnu-PR-Message: ack 73930
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 73930 <at> debbugs.gnu.org
Date: Mon, 21 Oct 2024 13:50:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 73930 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
73930: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73930
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#73930] [PATCH] gnu: git-repo: Update to 2.29.7
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Oct 2024 12:50:02 +0000
Resent-Message-ID: <handler.73930.B73930.17296877978079 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?= <sepeth@HIDDEN>
Cc: 73930 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <b1b8392ce548bc6cefa04d92331d7a794182813b.1729515611.git.sepeth@HIDDEN>
 ("=?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?="'s message of "Mon, 21 Oct 2024 15:00:11
 +0200")
References: <b1b8392ce548bc6cefa04d92331d7a794182813b.1729515611.git.sepeth@HIDDEN>
Date: Wed, 23 Oct 2024 21:48:17 +0900
Message-ID: <8734kn0yum.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Do=C4=9Fan =C3=87e=C3=A7en <sepeth@HIDDEN> writes:

> Fixes ModuleNotFoundError: No module named 'formatter'.
> This module was deprecated, and removed in Python 3.10.
>
> * gnu/packages/android.scm (git-repo): Update to 2.29.7
>
> Change-Id: I74d48fd9a8afc76c18d866b252a139f77b7ab838
> ---
>  gnu/packages/android.scm | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
> index 11e05dced9..0f41fa8695 100644
> --- a/gnu/packages/android.scm
> +++ b/gnu/packages/android.scm
> @@ -919,7 +919,7 @@ (define-public etc1tool
>  (define-public git-repo
>    (package
>      (name "git-repo")
> -    (version "2.4.1")
> +    (version "2.29.7")
>      (source
>       (origin
>         (method git-fetch)
> @@ -928,7 +928,7 @@ (define-public git-repo
>               (commit (string-append "v" version))))
>         (file-name (string-append "git-repo-" version "-checkout"))
>         (sha256
> -        (base32 "0khg1731927gvin73dcbw1657kbfq4k7agla5rpzqcnwkk5agzg3"))=
))
> +        (base32 "01sl9bz9rnhf9s3h7nlhkpxm0ggc5jzs30n11vlvnv2mqp8r1jvq"))=
))
>      (build-system python-build-system)
>      (arguments
>       `(#:phases
> @@ -1000,12 +1000,11 @@ (define-public git-repo
>                 (symlink (string-append repo-dir "/repo")
>                          (string-append bin-dir "/repo"))
>                 #t))))))
> -    (inputs
>       ;; TODO: Add git-remote-persistent-https once it is available in gu=
ix
> -     `(("git" ,git)
> -       ("ssh" ,openssh)))
> +    (inputs
> +      (list git openssh gnupg))
>      (native-inputs
> -     `(("pytest" ,python-pytest)))
> +      (list python-pytest))
>      (home-page "https://code.google.com/p/git-repo/")
>      (synopsis "Helps to manage many Git repositories")
>      (description "Repo is a tool built on top of Git.  Repo helps manage=
 many

This looks too simple to be true, given the complex patching going on in
phases (in retrospect this should have been done via a real patch to
avoid silent breakage like is probably happening here).

The idea of the patch was to ensure 'git-repo' wouldn't update itself
when run, as that defeats the immutable principle of Guix packages.

Could you test this property is preserved?  The addition of gnupg makes
me suspect it isn't.

--=20
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

Subject: [bug#73930] [PATCH] gnu: git-repo: Update to 2.29.7
Resent-From: =?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?= <sepeth@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Oct 2024 20:39:02 +0000
Resent-Message-ID: <handler.73930.B73930.172971590427447 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "Maxim Cournoyer" <maxim.cournoyer@HIDDEN>
Cc: 73930 <at> debbugs.gnu.org
Feedback-ID: i57994943:Fastmail
MIME-Version: 1.0
Date: Wed, 23 Oct 2024 20:37:24 +0000
From: =?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?= <sepeth@HIDDEN>
Message-Id: <be2c6e53-a9bd-47dc-a360-636ec3c85711@HIDDEN>
In-Reply-To: <8734kn0yum.fsf@HIDDEN>
References: <b1b8392ce548bc6cefa04d92331d7a794182813b.1729515611.git.sepeth@HIDDEN>
 <8734kn0yum.fsf@HIDDEN>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Maxim,

Thanks for looking into this.

> This looks too simple to be true, given the complex patching going on in
> phases (in retrospect this should have been done via a real patch to
> avoid silent breakage like is probably happening here).

Sorry, I am not following. What do you mean by the complex patching going on in phases and the silent breakage?

> The idea of the patch was to ensure 'git-repo' wouldn't update itself
> when run, as that defeats the immutable principle of Guix packages.

From what I can tell, it doesn't do that. Or, at least, it reports repeatedly the same version when I run `repo --version`, and it says the version I upgraded to, 2.29.7. And, I was able to use the tool successfully after the upgrade.

Note that this is not the latest version of repo tool. The latest version is 2.48, but that failed during the check phase, and 2.30 and upwards fails with the same reason IIRC. I couldn't get to the latest version without upgrading some core python packages. Even though repo now needs python-black, and it didn't work with the version we currently have in Guix. I tried upgrading that and some more but went into the rabbit hole of upgrading some core packages such as python-build and python-packaging-bootstrap etc, then I stopped.

> Could you test this property is preserved?  The addition of gnupg makes
> me suspect it isn't.

No problem, I tried the following and reported the same result, but I am not exactly sure if this is right way to test what you meant:

```
$ ./pre-inst-env guix build --check --no-offload --source --rounds=2 git-repo
...
warning: rewriting hashes in `/gnu/store/agzslk3pvakz9vf66pr49dc7v2xjkf1j-git-repo-2.29.7-checkout'; cross fingers
successfully built /gnu/store/8vwzck1s9d6siph4w3x62w0xdmk95yl8-git-repo-2.29.7-checkout.drv
successfully built /gnu/store/8vwzck1s9d6siph4w3x62w0xdmk95yl8-git-repo-2.29.7-checkout.drv
/gnu/store/agzslk3pvakz9vf66pr49dc7v2xjkf1j-git-repo-2.29.7-checkout
```

Many thanks,
Dogan

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 29 Dec 2024 23:01:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 29 18:01:40 2024
Received: from localhost ([127.0.0.1]:56527 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tS2I0-0002KV-Do
	for submit <at> debbugs.gnu.org; Sun, 29 Dec 2024 18:01:40 -0500
Received: from eggs.gnu.org ([209.51.188.92]:51904)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1tS2Hy-0002KG-TD
 for control <at> debbugs.gnu.org; Sun, 29 Dec 2024 18:01:39 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1tS2Ht-0006NT-GS
 for control <at> debbugs.gnu.org; Sun, 29 Dec 2024 18:01:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=BVp/f5zJlz8nNGyIGmd8AtR/R/sV0qJLY++6GhGK+uA=; b=DpdbZqckD8/2BW
 NyKaz49og9k+4zDU0R56MvVBhdQjXGbRiuKHi9OEgEainaBVDTYkiB2LvGJkKTLgLL0dsNLlm/TgM
 wzCr9naoBI9PegRbks6a3SS7M948YnWadZoro5dPSP7EEyBaZ5we/JKQcXopt4qM4UDURhVhaBWVK
 jCH9Fw5poqlnEBe5gbwygvCVEna1dY3MKnv/GfLntUZA/kG4nY60aIzz+qqVSnohGaWob09hacHHO
 W5D1SMvwd2xMyHRkDBS9JitegqMITFkuXGR8ZkV2RbXhGDVJgqBYjCNpjW/Ik7pau0V87SYHjHksg
 MXigfkucSSe7+WR0gDiA==;
Date: Mon, 30 Dec 2024 00:01:16 +0100
Message-Id: <87h66mnlfn.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #73930
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 73930 + moreinfo
quit

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.