X-Loop: help-debbugs@HIDDEN
Subject: bug#74097: 31.0.50; all-completions is slower on obarrays in emacs-30 than in emacs-29
Resent-From: Dmitry Gutov <dmitry@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: mattiase@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 30 Oct 2024 03:05:02 +0000
Resent-Message-ID: <handler.74097.B.173025749123275 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 74097
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 74097 <at> debbugs.gnu.org
Cc: mattias =?UTF-8?Q?engdeg=C3=A5rd?= <mattiase@HIDDEN>
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
X-Debbugs-Original-Xcc: mattias =?UTF-8?Q?engdeg=C3=A5rd?= <mattiase@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.173025749123275
(code B ref -1); Wed, 30 Oct 2024 03:05:02 +0000
Received: (at submit) by debbugs.gnu.org; 30 Oct 2024 03:04:51 +0000
Received: from localhost ([127.0.0.1]:60613 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1t5z0t-00063L-9b
for submit <at> debbugs.gnu.org; Tue, 29 Oct 2024 23:04:51 -0400
Received: from lists.gnu.org ([209.51.188.17]:54918)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dmitry@HIDDEN>) id 1t5z0p-00063D-1C
for submit <at> debbugs.gnu.org; Tue, 29 Oct 2024 23:04:49 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry@HIDDEN>) id 1t5z0n-0006vf-EF
for bug-gnu-emacs@HIDDEN; Tue, 29 Oct 2024 23:04:46 -0400
Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry@HIDDEN>) id 1t5z0j-0000Tc-OJ
for bug-gnu-emacs@HIDDEN; Tue, 29 Oct 2024 23:04:44 -0400
Received: from phl-compute-03.internal (phl-compute-03.phl.internal
[10.202.2.43])
by mailfout.phl.internal (Postfix) with ESMTP id 99FAB1380459
for <bug-gnu-emacs@HIDDEN>; Tue, 29 Oct 2024 23:04:40 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-03.internal (MEProxy); Tue, 29 Oct 2024 23:04:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
:content-transfer-encoding:content-type:content-type:date:date
:from:from:in-reply-to:message-id:mime-version:reply-to:subject
:subject:to:to; s=fm2; t=1730257480; x=1730343880; bh=Zj5eLGaDqN
70gHkJzVSHZC6G6zV15XAjv3WQqtPCK+g=; b=eFE2IOPkQIcmtKvrPVmkbzlM7h
ntcuxmoTBaIiYT7iStgRe/RtS+cdQbKsyX+SiVeBv1gkkJ51Kub6G5I9Ct447MTr
08oXqjum5p1UrfgRA0XhpZ27kxzKlOqqxCxNvY/CCdmNU4xONfV1uomT5L9ryzyM
siOVUTKYmSb5BPaT1t0Te1CnvSBeThhkHrFTXVx4tBBg8V6c2+hDRQRzGe46s+Vn
ZjufQ04qqMyPmJVyQCtA8s/Lpob53nEPmF3wYoEHRZ4eDbcQfc/Afqps/tgDKKl7
OQ6N5KiPoonHS5qE4Fw2jzmXE1G/ERLLfQb9pRr4UatDErwL+qIlltIaHDWg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:message-id:mime-version:reply-to:subject:subject:to
:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
1730257480; x=1730343880; bh=Zj5eLGaDqN70gHkJzVSHZC6G6zV15XAjv3W
QqtPCK+g=; b=YHjh5DZ53ZRP5wKx2B5Bf9/Ppl1HyCQwqitn+K//JZ11adR0diP
kW3slMfs/5jqEFDcQMwIQbw8WKpdI1rDWRmvCA5AOos3Vnf9BpmGJwIJ5Wy9PxHx
4lrujmIIbXwWUT6OHLgPDTJaNLYYFU88dGGNhJRlFi6JmTVrcyhHOo8HnySV0vIN
4o8Txd657lMfTzSQwqlU0+wQeG80VI+LGQ4rsJjE2f9kPR/b6B9gs2EqK6UNRUQe
uk8zBQhxuiS/nfigzDDYzeTDEM+SmOZKCjq9haAnUYpLWC5M+gxVTbD4Vof7wgmz
XPY2ewYZBQ1tc/xcjXb87DEnClCVCydyprA==
X-ME-Sender: <xms:SKIhZzpzaXp0buCOTjFZDzxYs8OwGfnzRWmjDG5uUXrF3iEa2AQh8Q>
<xme:SKIhZ9pH2qm6pjKEmyXCVEmsj9XOa6EYm99gIAoyZYUpvnwRcIyvEdDy_HSxNkwWI
s-PCfgaeUGJ86NOKj8>
X-ME-Received: <xmr:SKIhZwPM1q6ui-GCifD4SUmf8cJWEZKjJUWmBRZ7eKlzOmO4gnaDw98zNZ6QrUxvOkYb>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekvddgheegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfg
fvuffhtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegu
mhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvghrnhepkedvveetudekhe
dugeeffeeugeehtedtveehtddufeeigeffueehteeghedvieetnecuvehluhhsthgvrhfu
ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrd
guvghvpdhnsggprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthho
pegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg
X-ME-Proxy: <xmx:SKIhZ277Zl73JhPhjdnCwBs2eIH1bpaECTVqbckv-zbQeD9MJJeQQg>
<xmx:SKIhZy6maSHct7TfzX3BbSRWIinFYmZzW5CkB6wB0-awMd4wzY2ydg>
<xmx:SKIhZ-ixl7wWfYV1hriN3l4YtuiiNXp2v3iy7d5EIB6td2pfjnQsDA>
<xmx:SKIhZ07B6jqCc1ktSXwTRKJ_XHxJt6d974_6vtXTPEcXKzWU1w1LRg>
<xmx:SKIhZ4TGrOWS3DAhEhAfNu-DDZSuIMvREt3wxJOJePMjWRsuvouqSgH3>
Feedback-ID: i07de48aa:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
<bug-gnu-emacs@HIDDEN>; Tue, 29 Oct 2024 23:04:39 -0400 (EDT)
Message-ID: <32a2799c-4161-4b23-8d74-6f072b744f28@HIDDEN>
Date: Wed, 30 Oct 2024 05:04:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=103.168.172.145; envelope-from=dmitry@HIDDEN;
helo=fout-a2-smtp.messagingengine.com
X-Spam_score_int: -26
X-Spam_score: -2.7
X-Spam_bar: --
X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.9 (-)
X-Debbugs-Cc: Mattias Engdegård <mattiase@HIDDEN>
This is probably not critical for most uses, but it came up in experiment:
(let* ((my-size 100000)
(my-obarray
(let ((ob (obarray-make 1000)))
(dotimes (i my-size)
(intern (format "%s" i) ob))
ob))
(my-list
(let (list)
(dotimes (i my-size)
(push (format "%s" i) list))
(nreverse list)))
(s 0))
;; Just to verify.
(message "lengths obarray: %s list: %s"
(progn
(obarray-map (lambda (_) (cl-incf s))
my-obarray)
s)
(length my-list))
(message "list %s" (benchmark-run 10 (all-completions "1" my-list)))
(message "obarray %s" (benchmark-run 10 (all-completions "1"
my-obarray))))
In emacs-30 and emacs-31 it's 2-4x slower than on a list of strings:
lengths obarray: 100000 list: 100000
obarray (0.10444341 1 0.01843060800000007)
list (0.038867963 1 0.01855441899999999)
lengths obarray: 100000 list: 100000
obarray (0.082519579 1 0.017577374000000034)
list (0.038507061 1 0.017987661999999904)
lengths obarray: 100000 list: 100000
obarray (0.09489151100000001 1 0.017720256000000045)
list (0.039559388 1 0.01808564800000001)
And in emacs-29 the performance is closer to a list (1.5x difference maybe):
lengths obarray: 100000 list: 100000
obarray (0.04566377 1 0.014927433999999629)
list (0.034239810999999995 1 0.015311175000000787)
lengths obarray: 100000 list: 100000
obarray (0.048750494 1 0.015651392999999736)
list (0.034873387 1 0.015080243999999965)
In GNU Emacs 31.0.50 (build 41, x86_64-pc-linux-gnu, GTK+ Version
3.24.41, cairo version 1.18.0) of 2024-10-29 built on potemkin
Repository revision: fb5915665522f747daa8dfa11e91dc406d18edb7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12302006
System Description: Ubuntu 24.04.1 LTS
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Dmitry Gutov <dmitry@HIDDEN> Subject: bug#74097: Acknowledgement (31.0.50; all-completions is slower on obarrays in emacs-30 than in emacs-29) Message-ID: <handler.74097.B.173025749123275.ack <at> debbugs.gnu.org> References: <32a2799c-4161-4b23-8d74-6f072b744f28@HIDDEN> X-Gnu-PR-Message: ack 74097 X-Gnu-PR-Package: emacs Reply-To: 74097 <at> debbugs.gnu.org Date: Wed, 30 Oct 2024 03:05:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. As you requested using X-Debbugs-CC, your message was also forwarded to mattias engdeg=C3=A5rd <mattiase@HIDDEN> (after having been given a bug report number, if it did not have one). Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 74097 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 74097: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74097 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
Received: (at control) by debbugs.gnu.org; 2 Jan 2025 02:10:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 01 21:10:21 2025 Received: from localhost ([127.0.0.1]:41439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tTAfF-0002tr-2n for submit <at> debbugs.gnu.org; Wed, 01 Jan 2025 21:10:21 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:54279) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tTAfD-0002p4-GY for control <at> debbugs.gnu.org; Wed, 01 Jan 2025 21:10:19 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5d88c355e0dso4185741a12.0 for <control <at> debbugs.gnu.org>; Wed, 01 Jan 2025 18:10:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735783813; x=1736388613; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=S+j1kChy9rCOXTii8nZRb+6qV+bM4LiTp65xk6/tRaE=; b=em+GwPQ9PPozwn+B8Mv/KGBCYOWpfc9TjseKcl/bfXcTruyD7tbCHFXwRc9ScX1jDh VZtYRDX93sOu9CtfAEpKqnxiB2sCSGSdB7MSyqdcP2kkHpXgAKIG9khYG/Z3/himaNec UTX0QcIPKPQDKWwK20CcV8W2Vt3M+Fk41neO2qW3jl1IHjCDQdGpthd3NqZmnI87h8X2 CmwFBmgVLa/4o0b9TvgugquVD8S6y600N80oYD/Mkk2+Dz4JouCbSC5u+tZlKCJ429qu lhZZkLLq3ZrakF5geS7778jxBJrlHYScxYBeFuIh147rkZsbkpW4Hmx0pf8fqihd4pMN 1Pig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735783813; x=1736388613; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=S+j1kChy9rCOXTii8nZRb+6qV+bM4LiTp65xk6/tRaE=; b=dtbJMvLoItvxomiJ5jA/4ooxVIojko0OjpJYL+SU3NtiJMi8e2NeVle5Vp2TMb9qCn ZBK3vG8xgu7fEy9CSKJB1VVNL0wsYu+aQLOtp/lxrKM/o8zUVuJi8r2bs7u1DSV552s6 C6pAa7JkLfgsSM/Xwk30jnvbBPUa0QyooTiAupDSf75iHATuDvjw0QR5X8uRBduJND+T VbZP2Ewy8jukqte9GyDEGzwh+Sy+kTHLk1PbWiFWFXquRY4Ww4G3hyXZHnX1wYbDDrg/ 9qdSGDy4Tw32wLKSqUraqxBeVtuLThEvF1DVc5RNe+JkFsug27u+nkHQBB4ChmcxTa0p 0wAw== X-Gm-Message-State: AOJu0YyWa7uT3A8r4C3tBZErTBjKsy2ezDScT5zmz9IHs8fecIYu/42L km9HloA7iu0apXCZqHqCsnmtoD1FescYRARP18gwyMD9xqpD0k+LP3VFEYZCiRi35xznl6hp+bi hlJ04KFZK6ZbzxnN6eC5XsiUFkvImSEYR6Z0= X-Gm-Gg: ASbGncseMsJIGIesmymgpcEH5oKYStT+t5Hyv+9URnfr47r27KWnPUtPr9kfwnk4z3k U7X/tpwfLLk8z1zuIwz1t9d6W95Axq/oXhGocslQs X-Google-Smtp-Source: AGHT+IFfhU1Sr8q7vYRRfLObDsEQvh1mQhzb6nk0bA1FxnwUre0qNGKhvdia7cPy4Tmg5OwU4NvsHzSDR7vxPHqWsLg= X-Received: by 2002:a05:6402:270d:b0:5d1:2652:42ba with SMTP id 4fb4d7f45d1cf-5d81dd9a22amr41864233a12.16.1735783813419; Wed, 01 Jan 2025 18:10:13 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 1 Jan 2025 20:10:13 -0600 From: Stefan Kangas <stefankangas@HIDDEN> MIME-Version: 1.0 Date: Wed, 1 Jan 2025 20:10:13 -0600 Message-ID: <CADwFkmmH0d_1C-44sDcty-On30DSCsvZW-9-ojtdATAD79HsEA@HIDDEN> Subject: control message for bug #74097 To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) severity 74097 minor quit
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.