GNU bug report logs - #74124
[PATCH] gnu: Add r-shinyvalidate.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74124 in the body.
You can then email your comments to 74124 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: "King, Spencer via Guix-patches via" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add r-shinyvalidate.
Date: Wed, 30 Oct 2024 22:35:31 +0000

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-r-shinyvalidate.patch (application/octet-stream, attachment)]

Message #8 received at 74124 <at> debbugs.gnu.org (full text, mbox):

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: "74124 <at> debbugs.gnu.org" <74124 <at> debbugs.gnu.org>
Cc: "rekado <at> elephly.net" <rekado <at> elephly.net>,
 "laurent.gatto <at> gmail.com" <laurent.gatto <at> gmail.com>,
 "zimon.toutoune <at> gmail.com" <zimon.toutoune <at> gmail.com>
Date: Fri, 3 Jan 2025 17:55:02 +0000

Pinging the R team since this patch has been unreviewed for a couple months. This is my first time pinging a specific team so please let me know if this is inappropriate or if there is something else I should do in the future.

Best,
Spencer

Message #13 received at 74124-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 74124-done <at> debbugs.gnu.org
Cc: "King, Spencer" <spencer.king <at> wustl.edu>,
 "laurent.gatto <at> gmail.com" <laurent.gatto <at> gmail.com>,
 "zimon.toutoune <at> gmail.com" <zimon.toutoune <at> gmail.com>
Subject: [PATCH] gnu: Add r-shinyvalidate.
Date: Fri, 03 Jan 2025 19:20:59 +0100

Hi Spencer,

> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay.  I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do.  It is also recommended to Cc the team when submitting the
patch.  (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

-- 
Ricardo

Message #16 received at 74124-done <at> debbugs.gnu.org (full text, mbox):

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: Ricardo Wurmus <rekado <at> elephly.net>, "74124-done <at> debbugs.gnu.org"
 <74124-done <at> debbugs.gnu.org>
Cc: "laurent.gatto <at> gmail.com" <laurent.gatto <at> gmail.com>,
 "zimon.toutoune <at> gmail.com" <zimon.toutoune <at> gmail.com>
Subject: Re: [PATCH] gnu: Add r-shinyvalidate.
Date: Fri, 3 Jan 2025 18:23:11 +0000

[Message part 1 (text/plain, inline)]

Hi Ricardo,

Thank you for the quick response. Is r-testthat now necessary across the board for all R packages? I do have a couple of other outstanding R patches that I can update if needed and ping the team.

Best,
Spencer
________________________________
From: Ricardo Wurmus <rekado <at> elephly.net>
Sent: Friday, January 3, 2025 12:20 PM
To: 74124-done <at> debbugs.gnu.org <74124-done <at> debbugs.gnu.org>
Cc: King, Spencer <spencer.king <at> wustl.edu>; laurent.gatto <at> gmail.com <laurent.gatto <at> gmail.com>; zimon.toutoune <at> gmail.com <zimon.toutoune <at> gmail.com>
Subject: [PATCH] gnu: Add r-shinyvalidate.

Hi Spencer,

> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay.  I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do.  It is also recommended to Cc the team when submitting the
patch.  (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

--
Ricardo

[Message part 2 (text/html, inline)]

Message #19 received at 74124-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: "King, Spencer" <spencer.king <at> wustl.edu>
Cc: "74124-done <at> debbugs.gnu.org" <74124-done <at> debbugs.gnu.org>,
 "laurent.gatto <at> gmail.com" <laurent.gatto <at> gmail.com>,
 "zimon.toutoune <at> gmail.com" <zimon.toutoune <at> gmail.com>
Subject: Re: [PATCH] gnu: Add r-shinyvalidate.
Date: Fri, 03 Jan 2025 20:56:35 +0100

"King, Spencer" <spencer.king <at> wustl.edu> writes:

> Is r-testthat now necessary across the board for all R packages?

That depends on the package.  Some use r-runit, others r-testit, some
use a combination of these packages, some use none at all.

Prior to my changes the build system would ignore test failures.  Most
test suites simply weren't run at all due to missing inputs.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.