GNU bug report logs - #74136
[PATCH 2/2] gnu: Update emacs-popwin to 1.0.2.-2.58adcd0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74136 in the body.
You can then email your comments to 74136 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Subject: [PATCH 2/2] gnu: Update emacs-popwin to 1.0.2.-2.58adcd0.
Date: Thu, 31 Oct 2024 14:42:48 +0100

* gnu/packages/emacs-xyz.scm (emacs-popwin): Update to 1.0.2.-2.58adcd0.

Change-Id: Ie7ee892b737310a002a6e74bd5138b041eaf30bd
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 46fee0b7d6..d13d92731f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15770,8 +15770,8 @@ (define-public emacs-find-file-in-project
     (license license:gpl3+)))
 
 (define-public emacs-popwin
-  (let ((commit "215d6cb509b11c63394a20666565cd9e9b2c2eab")
-        (revision "1"))
+  (let ((commit "58adcd0ca7c3dbd58626ec7019252d64cbc73042")
+        (revision "2"))
     (package
       (name "emacs-popwin")
       (version (git-version "1.0.2" revision commit))
@@ -15783,7 +15783,7 @@ (define-public emacs-popwin
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "1x1iimzbwb5izbia6aj6xv49jybzln2qxm5ybcrcq7xync5swiv1"))))
+          (base32 "1mqwzc6fwhwq1kl8b3i1hm2ylfh8blrxrw6mzr5wyifbwpg7dq10"))))
       (build-system emacs-build-system)
       (home-page "https://github.com/emacsorphanage/popwin")
       (synopsis "Popup window manager for Emacs")
-- 
2.46.0

Message #8 received at 74136 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 74136 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#74136] [PATCH 2/2] gnu: Update emacs-popwin to
 1.0.2.-2.58adcd0.
Date: Sat, 05 Apr 2025 12:35:29 -0700

Hi Rostislav,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-popwin): Update to 
> 1.0.2.-2.58adcd0.
>
> Change-Id: Ie7ee892b737310a002a6e74bd5138b041eaf30bd
> ---
>  gnu/packages/emacs-xyz.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index 46fee0b7d6..d13d92731f 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -15770,8 +15770,8 @@ (define-public 
> emacs-find-file-in-project
>      (license license:gpl3+)))
>  
>  (define-public emacs-popwin
> -  (let ((commit "215d6cb509b11c63394a20666565cd9e9b2c2eab")
> -        (revision "1"))
> +  (let ((commit "58adcd0ca7c3dbd58626ec7019252d64cbc73042")
> +        (revision "2"))
>      (package
>        (name "emacs-popwin")
>        (version (git-version "1.0.2" revision commit))
> @@ -15783,7 +15783,7 @@ (define-public emacs-popwin
>                 (commit commit)))
>           (file-name (git-file-name name version))
>           (sha256
> -          (base32 
> "1x1iimzbwb5izbia6aj6xv49jybzln2qxm5ybcrcq7xync5swiv1"))))
> +          (base32 
> "1mqwzc6fwhwq1kl8b3i1hm2ylfh8blrxrw6mzr5wyifbwpg7dq10"))))
>        (build-system emacs-build-system)
>        (home-page "https://github.com/emacsorphanage/popwin")
>        (synopsis "Popup window manager for Emacs")

This patch doesn’t apply to Guix master.  The emacs-popwin package 
in master builds the 1.0.2 tag and doesn’t have a `let' around it 
specifying a commit.  Since the guix package hasn’t changed since 
2023, it makes me wonder if your patch is based off a local fork, 
rather than master.

If you’d like to send a v2 that applies to master, I’d be happy to 
push it.  Looks like there have been a few commits since you sent 
this patch, though they don’t change functionality at all -- 
you’re welcome to include them or not.

Thanks,

 -- Ian

Message #13 received at 74136-done <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 74136-done <at> debbugs.gnu.org
Subject: close
Date: Mon, 06 Oct 2025 10:38:06 +0200

[Message part 1 (text/plain, inline)]

See https://codeberg.org/guix/guix/pulls/3344.

--
Cayetano Santos
.
gpg: CCB8 1842 F9D7 058E CD67 377A BF5C DF4D F6BF 6682
key: meta.sr.ht/~csantosb.pgp

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.