GNU bug report logs - #74180
[PATCH] gnu: add bash-preexec

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Javier Olaechea <pirata@HIDDEN>; Keywords: patch; dated Sat, 2 Nov 2024 21:15:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 74180 <at> debbugs.gnu.org:


Received: (at 74180) by debbugs.gnu.org; 4 Nov 2024 04:29:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 03 23:29:05 2024
Received: from localhost ([127.0.0.1]:37106 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t7oi9-0002d4-82
	for submit <at> debbugs.gnu.org; Sun, 03 Nov 2024 23:29:05 -0500
Received: from mail-yw1-f171.google.com ([209.85.128.171]:59443)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pirata@HIDDEN>) id 1t7oi6-0002cf-CK
 for 74180 <at> debbugs.gnu.org; Sun, 03 Nov 2024 23:29:03 -0500
Received: by mail-yw1-f171.google.com with SMTP id
 00721157ae682-6ea7c9227bfso13603157b3.2
 for <74180 <at> debbugs.gnu.org>; Sun, 03 Nov 2024 20:29:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1730694476; x=1731299276; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=hrsvQU+EOyjN2lmuKIei/hkWJMpmyKpixC0L3VVp0Uc=;
 b=S3R93FPOCjVapeRTfqbp2S6C28R0HC2CR8jLxefI3xHylTEzwV/uyZ1SAx4777nNtA
 TP21QTWdQS8WmZ/TEiAnHKjTkHc3CqnOWPxa7N39Yuyu3F7MGM4fZrgX3BS8OwqtWbiG
 kdbM8RStbqp4BTqz78MGMFuxZlAHEBsi1cqudyM5pl6aO+Ot8M/3KvDP2ksuD3BmESGK
 2lokQGPZiDXbR7XTpXZdMhDuO1JHKLdEly7m+hEGvX/limYfLZjN20iNjyDhHRux++Ss
 eJkF9Tmaym1nF3T1Nz7s7x07YalpQ4YyqR18iHRllwFJd7vxySnoYF5rdhGmnKBY8K33
 LL3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1730694476; x=1731299276;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=hrsvQU+EOyjN2lmuKIei/hkWJMpmyKpixC0L3VVp0Uc=;
 b=cf5CCy7WX4fKUVf8TMZWFHfnOhhjOiFkNJMzuTtC8g2JJUP+sy8J3RguMrFl+iW/35
 X9DzunSLeCbPfoUQFgFjZo13H2sJ/M2yQfb9clb4SA6ZLS9VMzrjUihrpViVtIkrFJuE
 lOE+2qIwXqqttjYFZmRRiejkKJLBcMURXdERBtZY1kJhivfgJjJCnU7mzKmx1mfxGWfV
 xSire0/ie/JzgTQXaoH/SpLLwy4E/cFyPR0pgYysSDRz7xuQraTJ7oszIxnE2OVVx8x5
 U6LiF6VP1vgK0WZj7IDIwQ+0wumtoLbi8kESMA39e9y2lGjFgMjnSWaGvgI9v0IrYgfA
 c53w==
X-Gm-Message-State: AOJu0YzSb05jdJD7hHY6ks3K6ChXTinnDxhx5tXyBVWWSsf9FrhLEuYE
 H4H3rkKhNA8TLlpkfjG/RewUXASUVC3wDMa+vQvZy+KiY8xmHcAujt1ui0naqvlMps3bWJPT9Cg
 S9CD31fBZi7OPFOdmaQRDHeljEpVQ2LAS
X-Google-Smtp-Source: AGHT+IGSJv+/zDcuwZFQj4CKwJDh36a54xqkF14IHA28gT56kwrHaAJPXKlc+vX1b62tPw0XUwj8fF3h7wsaC+1w3gE=
X-Received: by 2002:a05:690c:62c5:b0:6ac:ce34:9726 with SMTP id
 00721157ae682-6e9d8a2bd43mr307955537b3.18.1730694476575; Sun, 03 Nov 2024
 20:27:56 -0800 (PST)
MIME-Version: 1.0
References: <CAFVS=zCPdTC7L_fqfsyP8Mzfc=bp4ssSw9Us9q2RgToLVt95vQ@HIDDEN>
 <871pzsozdc.fsf@HIDDEN>
In-Reply-To: <871pzsozdc.fsf@HIDDEN>
From: Javier Olaechea <pirata@HIDDEN>
Date: Mon, 4 Nov 2024 04:27:45 +0000
Message-ID: <CAFVS=zDsu6ykXULk8KV1xOJr+4OB=x2Zbg7=2pqcoCRdYOaVXw@HIDDEN>
Subject: Re: [bug#74180] [PATCH] gnu: add bash-preexec
To: Nicolas Graves <ngraves@HIDDEN>
Content-Type: multipart/mixed; boundary="0000000000007dd4e206260eb59a"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74180
Cc: 74180 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000007dd4e206260eb59a
Content-Type: multipart/alternative; boundary="0000000000007dd4e106260eb598"

--0000000000007dd4e106260eb598
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> > +
> > +       (sha256
> > +        (base32
> "0nx0m1bhm4f4v033ngi2m9zq3vppimsmn8kmwqbvyqr4n6gkjmgq"))))
> > +    (build-system gnu-build-system)
>
> Looks like you can simply use the copy-build-system here, no?
>

Good call, I've updated the the package to do so. One thing I changed as
well is the location for bash-preexec.sh. I saw arch (
https://gitlab.archlinux.org/archlinux/packaging/packages/bash-preexec/-/bl=
ob/main/PKGBUILD?ref_type=3Dheads#L30)
and nix package it under share/ instance of bin/.

Another thing I did was filtering the test files from the package. As they
require the bats package to run.


> > +    (description
> > +     "preexec and precmd hook functions for Bash 3.1+ in the style of
> > Zsh.")
>
> The description should be more descriptive. You can describe the two
> functions like they do in the README.  Use @command{bash/zsh}.  Prefix
> with "This package provides".
>

Updated accordingly. Let me know if there are any other improvements

--=20
"I object to doing things that computers can do." =E2=80=94 Olin Shivers

--0000000000007dd4e106260eb598
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left=
:1px solid rgb(204,204,204);padding-left:1ex">
&gt; +<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32 &quot;0nx0m1bhm4f4v033ngi2m9zq3vp=
pimsmn8kmwqbvyqr4n6gkjmgq&quot;))))<br>
&gt; +=C2=A0 =C2=A0 (build-system gnu-build-system)<br>
<br>
Looks like you can simply use the copy-build-system here, no?<br></blockquo=
te><div><br></div><div>Good call, I&#39;ve updated the the package to do so=
. One thing I changed as well is the location for bash-preexec.sh. I saw ar=
ch (<a href=3D"https://gitlab.archlinux.org/archlinux/packaging/packages/ba=
sh-preexec/-/blob/main/PKGBUILD?ref_type=3Dheads#L30">https://gitlab.archli=
nux.org/archlinux/packaging/packages/bash-preexec/-/blob/main/PKGBUILD?ref_=
type=3Dheads#L30</a>) and nix package it under share/ instance of bin/.=C2=
=A0</div><div><br></div><div>Another thing I did was filtering the test fil=
es from the package. As they require the bats package to run. <br></div><di=
v>=C2=A0<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; +=C2=A0 =C2=A0 (description<br>
&gt; +=C2=A0 =C2=A0 =C2=A0&quot;preexec and precmd hook functions for Bash =
3.1+ in the style of<br>
&gt; Zsh.&quot;)<br>
<br>
The description should be more descriptive. You can describe the two<br>
functions like they do in the README.=C2=A0 Use @command{bash/zsh}.=C2=A0 P=
refix<br>
with &quot;This package provides&quot;.<br clear=3D"all"></blockquote></div=
><div><br></div><div>Updated accordingly. Let me know if there are any othe=
r improvements<br></div><div><br></div><span class=3D"gmail_signature_prefi=
x">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature">&quot;I object =
to doing things that computers can do.&quot; =E2=80=94 Olin Shivers</div></=
div>

--0000000000007dd4e106260eb598--

--0000000000007dd4e206260eb59a
Content-Type: text/x-patch; charset="UTF-8"; name="v2-0001-gnu-add-bash-preexec.patch"
Content-Disposition: attachment; 
	filename="v2-0001-gnu-add-bash-preexec.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m32ir5eo0>
X-Attachment-Id: f_m32ir5eo0

RnJvbSBlNGQ3NjAwYmE5MjA4ZjY4NTBhOTJiYTQxM2VlYzMyYTc2NGE3OWJiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8ZTRkNzYwMGJhOTIwOGY2ODUwYTkyYmE0MTNlZWMz
MmE3NjRhNzliYi4xNzMwNjkzOTYwLmdpdC5waXJhdGFAZ21haWwuY29tPgpGcm9tOiBKYXZpZXIg
T2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRhdGU6IFNhdCwgMiBOb3YgMjAyNCAxNTo1Nzo1
NCAtMDUwMApTdWJqZWN0OiBbUEFUQ0ggdjJdIGdudTogYWRkIGJhc2gtcHJlZXhlYwoKKiBnbnUv
cGFja2FnZXMvYmFzaC5zY206IChiYXNoLXByZWV4ZWMpOiBOZXcgdmFyaWFibGUuCgpDaGFuZ2Ut
SWQ6IEk2NDJiZTM3MGM5MDMxODNjODkxNzRkYTMwNjY2YjA4ZjA3ZDNhMTE4Ci0tLQogZ251L3Bh
Y2thZ2VzL2Jhc2guc2NtIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZp
bGUgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9i
YXNoLnNjbSBiL2dudS9wYWNrYWdlcy9iYXNoLnNjbQppbmRleCA5MzY0MWE3OGQ1Li44YTFkZTVh
MzRjIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvYmFzaC5zY20KKysrIGIvZ251L3BhY2thZ2Vz
L2Jhc2guc2NtCkBAIC00Nyw2ICs0Nyw3IEBAIChkZWZpbmUtbW9kdWxlIChnbnUgcGFja2FnZXMg
YmFzaCkKICAgIzp1c2UtbW9kdWxlIChndWl4IGdleHApCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBt
b25hZHMpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBzdG9yZSkKKyAgIzp1c2UtbW9kdWxlIChndWl4
IGJ1aWxkLXN5c3RlbSBjb3B5KQogICAjOnVzZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIGdu
dSkKICAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSB0cml2aWFsKQogICAjOmF1dG9s
b2FkICAgKGd1aXggZ251cGcpIChnbnVwZy12ZXJpZnkqKQpAQCAtNDg4LDMgKzQ4OSwzMiBAQCAo
ZGVmaW5lLXB1YmxpYyBibGVzaAogd2hpY2ggcmVwbGFjZXMgdGhlIGRlZmF1bHQgR05VIFJlYWRs
aW5lLiAgSXQgYWRkcyBzeW50YXggaGlnaGxpZ2h0aW5nLCBhdXRvCiBzdWdnZXN0aW9ucywgdmlt
IG1vZGVzLCBhbmQgbW9yZSB0byBCYXNoIGludGVyYWN0aXZlIHNlc3Npb25zLiIpCiAgICAgKGxp
Y2Vuc2UgbGljZW5zZTpic2QtMykpKQorCisoZGVmaW5lLXB1YmxpYyBiYXNoLXByZWV4ZWMKKyAg
KHBhY2thZ2UKKyAgICAobmFtZSAiYmFzaC1wcmVleGVjIikKKyAgICAodmVyc2lvbiAiMC41LjAi
KQorICAgIChzb3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQor
ICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAodXJsICJodHRwczovL2dp
dGh1Yi5jb20vcmNhbG9yYXMvYmFzaC1wcmVleGVjIikKKyAgICAgICAgICAgICAoY29tbWl0IHZl
cnNpb24pKSkKKworICAgICAgIChzaGEyNTYKKyAgICAgICAgKGJhc2UzMiAiMG54MG0xYmhtNGY0
djAzM25naTJtOXpxM3ZwcGltc21uOGttd3FidnlxcjRuNmdram1ncSIpKSkpCisgICAgKGJ1aWxk
LXN5c3RlbSBjb3B5LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIChsaXN0Cisg
ICAgICAjOmluc3RhbGwtcGxhbiAjficoKCIuLyIgInNoYXJlL2Jhc2gtcHJlZXhlYy8iCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICM6ZXhjbHVkZS1yZWdleHAgKCIudHJhdmlzLnltbCIgIi5n
aXRodWIvIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiTElD
RU5TRS5tZCIgIlJFQURNRS5tZCIgInRlc3QvIikpKSkpCisgICAgKGhvbWUtcGFnZSAiaHR0cHM6
Ly9naXRodWIuY29tL3JjYWxvcmFzL2Jhc2gtcHJlZXhlYyIpCisgICAgKHN5bm9wc2lzICJwcmVl
eGVjIGFuZCBwcmVjbWQgZnVuY3Rpb25zIGZvciBCYXNoIGp1c3QgbGlrZSBac2giKQorICAgIChk
ZXNjcmlwdGlvbgorICAgICAiVGhpcyBwYWNrYWdlIHByb3ZpZGVzIHByZWV4ZWMgYW5kIHByZWNt
ZCBob29rIGZ1bmN0aW9ucyBmb3IgQGNvbW1hbmR7QmFzaH0gMy4xKyBpbiB0aGUgc3R5bGUgb2Yg
QGNvbW1hbmR7WnNofS4KKwor4oCiIHByZWV4ZWMgRXhlY3V0ZWQganVzdCBhZnRlciBhIGNvbW1h
bmQgaGFzIGJlZW4gcmVhZCBhbmQgaXMgYWJvdXQgdG8gYmUgZXhlY3V0ZWQuIFRoZSBzdHJpbmcg
dGhhdCB0aGUgdXNlciB0eXBlZCBpcyBwYXNzZWQgYXMgdGhlIGZpcnN0IGFyZ3VtZW50Lgor4oCi
IHByZWNtZCBFeGVjdXRlZCBqdXN0IGJlZm9yZSBlYWNoIHByb21wdC4gRXF1aXZhbGVudCB0byBQ
Uk9NUFRfQ09NTUFORCwgYnV0IG1vcmUgZmxleGlibGUgYW5kIHJlc2lsaWVudC4KKyIpCisgICAg
KGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKQoKYmFzZS1jb21taXQ6IGVhMTFkMzYwODU2NjE3NGM0
YmFlNzBmYWE0ZjlkMGM2Nzc0OGQyZGIKLS0gCjIuNDYuMAoK
--0000000000007dd4e206260eb59a--




Information forwarded to guix-patches@HIDDEN:
bug#74180; Package guix-patches. Full text available.

Message received at 74180 <at> debbugs.gnu.org:


Received: (at 74180) by debbugs.gnu.org; 3 Nov 2024 20:07:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 03 15:07:17 2024
Received: from localhost ([127.0.0.1]:34379 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t7gsX-0003Bz-Jj
	for submit <at> debbugs.gnu.org; Sun, 03 Nov 2024 15:07:17 -0500
Received: from 10.mo583.mail-out.ovh.net ([46.105.52.148]:36949)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1t7gsU-0003Bp-9s
 for 74180 <at> debbugs.gnu.org; Sun, 03 Nov 2024 15:07:15 -0500
Received: from director7.ghost.mail-out.ovh.net (unknown [10.109.140.100])
 by mo583.mail-out.ovh.net (Postfix) with ESMTP id 4XhQcJ57q6z1Qv8
 for <74180 <at> debbugs.gnu.org>; Sun,  3 Nov 2024 20:07:12 +0000 (UTC)
Received: from ghost-submission-5b5ff79f4f-2gkmb (unknown [10.110.168.159])
 by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 41BAE1FD2F;
 Sun,  3 Nov 2024 20:07:12 +0000 (UTC)
Received: from ngraves.fr ([37.59.142.105])
 by ghost-submission-5b5ff79f4f-2gkmb with ESMTPSA
 id I2fBBfDXJ2dVixIALo/peQ
 (envelope-from <ngraves@HIDDEN>); Sun, 03 Nov 2024 20:07:12 +0000
Authentication-Results: garm.ovh; auth=pass
 (GARM-105G00656d53d57-9e45-455c-a812-b02d5104dafb,
 AE4F9A324CDBAF4B52618B2723BB28A1C21EBFEF) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 86.246.19.221
From: Nicolas Graves <ngraves@HIDDEN>
To: Javier Olaechea <pirata@HIDDEN>, 74180 <at> debbugs.gnu.org
Subject: Re: [bug#74180] [PATCH] gnu: add bash-preexec
In-Reply-To: <CAFVS=zCPdTC7L_fqfsyP8Mzfc=bp4ssSw9Us9q2RgToLVt95vQ@HIDDEN>
References: <CAFVS=zCPdTC7L_fqfsyP8Mzfc=bp4ssSw9Us9q2RgToLVt95vQ@HIDDEN>
Date: Sun, 03 Nov 2024 21:07:11 +0100
Message-ID: <871pzsozdc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 15559936712930157230
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeftddrvdelgedgudefgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeiteefveduheejhfevueekfeehfffgjeehieekgfevkeetieehjefgleeigffhueenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeduvdejrddtrddtrddupdekiedrvdegiedrudelrddvvddupdefjedrheelrddugedvrddutdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejgedukedtseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkeefpdhmohguvgepshhmthhpohhuth
DKIM-Signature: a=rsa-sha256; bh=wtHDb79A/B0OAS6777tZc9DYq4lyfM+5RyQeB7VgXzg=; 
 c=relaxed/relaxed; d=ngraves.fr; h=From;
 s=ovhmo4487190-selector1; t=1730664432; v=1;
 b=GFMmw5aD/VfrWk+vJbICsF7kyYEYG30TZEOkTxPk5K2D70e8P4k+4irjVIRL8sGMwOH9jKMl
 qYZNNEtPVkLEcvj8BCrc2MrTM6vzR2UQOMs6naItUpBiDEAC4Qb5m2lAXyUczDcAWGFGjt2J5iq
 JUJ72jopelqehnb4Jsor6+Q8mHyT6JP6p9D2BfLMeQJTV8uK4udsJuBgQei+o8WvWGvdNiarxb5
 MkR3T5UWJf0lT7VPn0tXZxS0G4A5f/tO5pHhgebtUqHFiLo6aPVOJaSCQx6p+SGL/KVVF8Xr93t
 06VfqBP2414O4tbh+iIrmJEJGCK5co+36QtadarjqWxyg==
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74180
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 2024-11-02 21:14, Javier Olaechea wrote:

> * gnu/packages/bash.scm: (bash-preexec): New variable.

> +
> +(define-public bash-preexec
> +  (package
> +    (name "bash-preexec")
> +    (version "0.5.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/rcaloras/bash-preexec")
> +             (commit "da64ad4b7bb965d19dbeb5bb7447f1a63e3de2e3")))

You can use version here.

> +
> +       (sha256
> +        (base32 "0nx0m1bhm4f4v033ngi2m9zq3vppimsmn8kmwqbvyqr4n6gkjmgq"))))
> +    (build-system gnu-build-system)

Looks like you can simply use the copy-build-system here, no?

> +    (arguments
> +     (list
> +      #:phases #~(modify-phases %standard-phases
> +                   (delete 'configure)
> +                   (delete 'build)
> +                   (delete 'check)
> +                   (replace 'install
> +                     (lambda _
> +                       (install-file "bash-preexec.sh"
> +                                     (string-append #$output "/bin")))))))
> +    (home-page "https://github.com/rcaloras/bash-preexec")
> +    (synopsis "preexec and precmd functions for Bash just like Zsh")
> +    (description
> +     "preexec and precmd hook functions for Bash 3.1+ in the style of
> Zsh.")

The description should be more descriptive. You can describe the two
functions like they do in the README.  Use @command{bash/zsh}.  Prefix
with "This package provides".

> +    (license license:expat)))
>
> base-commit: ea11d3608566174c4bae70faa4f9d0c67748d2db

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches@HIDDEN:
bug#74180; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 2 Nov 2024 21:14:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 02 17:14:38 2024
Received: from localhost ([127.0.0.1]:55665 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t7LSA-0000rJ-1M
	for submit <at> debbugs.gnu.org; Sat, 02 Nov 2024 17:14:38 -0400
Received: from lists.gnu.org ([209.51.188.17]:60302)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pirata@HIDDEN>) id 1t7LS4-0000r8-VY
 for submit <at> debbugs.gnu.org; Sat, 02 Nov 2024 17:14:36 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <pirata@HIDDEN>) id 1t7LS4-0000U5-5j
 for guix-patches@HIDDEN; Sat, 02 Nov 2024 17:14:32 -0400
Received: from mail-yw1-x112d.google.com ([2607:f8b0:4864:20::112d])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <pirata@HIDDEN>) id 1t7LS2-0003zu-Fm
 for guix-patches@HIDDEN; Sat, 02 Nov 2024 17:14:31 -0400
Received: by mail-yw1-x112d.google.com with SMTP id
 00721157ae682-6e9ba45d67fso28917037b3.1
 for <guix-patches@HIDDEN>; Sat, 02 Nov 2024 14:14:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1730582068; x=1731186868; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=l+FVsLOIzoi0NIB5B3vobK2SSRRi2CxmgwYJoL1xb9Q=;
 b=PRUvsfTe/+HGkZsQtKeFB21JKxjapdGWj1ZklzbEGUBveL8Tab6NrwST2X0ygHI1J3
 5c7IiAt78ed8Fe8JSeS5RkGjJAxTHmsz3GTZHlrrfljYBjyjmBt74rsooFnl37otdzlu
 7urYwS9Hl0+vQHYCK6rVTSsm+SZBK+KjSMOIqkJVEKFZNv10KtiDqaG8eodBCAPkHS1m
 dL2H7dIe8Hp1F/N1KzYbxfxSovnSL4gehZYs1nX7zHvrG9+nGtzxnW0EVauica2oN/+l
 Wb/+zC3wRkA2GFxan4WMDk6sfeoBk7r1CGSO+vdPoqEGX7aA5WhjAksqHrt8aq66YfLV
 ywVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1730582068; x=1731186868;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=l+FVsLOIzoi0NIB5B3vobK2SSRRi2CxmgwYJoL1xb9Q=;
 b=pDXisT2IMdYenogq9LiYnAJHlWIExAQTcfhosl48w5qRo+FqCQRQ3yc74jJ6wC/i9q
 /j+SThgcCIAIxb6iUvTuVA2W3W5r87aLxBYi6Up+YQLyosxwgCr6lc3iiCSpfzW665Vb
 aWcRn5XZugWu7+FzNXM78Oiw+pefvdQ9Rw49Z+p7Wcj6Zm/9Zx7wD95NDpuL7BUKw0ua
 PINcijJeQIrOQ+AUzoztvFQgKstuHow1Y+ZGrv5RXiZ8K67HyWXCG2VKBbmGz984Bs01
 YHtcAwvDcU2E3LyjNc49uyR2kTjG1bCojtLAsfMESxQfKSFKisGNK+de7yIpcLKE3Zp6
 V6+A==
X-Gm-Message-State: AOJu0YxFYOp297766HUyqGBybhwxmz5/g1xZVX7iebzT4DbjU53FjTAK
 aMNRtmMAKWLCfGXbSPF/7oKFif6yVYtW+arIbqXAGyKrakvF/7HL6PKO6MXU+UQuhbYFl+tJUs2
 CbGkEpwhCAJIY9xHeXJjltE1k0ayhSaKs
X-Google-Smtp-Source: AGHT+IH80voSONKAoSCqwRE4ljtFizQDvlFsgWQOPHGeYZBh/0rf1DNpWYxe2XiaHSXngEIqdagNRHyDffRBf/kei7E=
X-Received: by 2002:a05:690c:62c6:b0:6e5:9bc2:53a0 with SMTP id
 00721157ae682-6ea3b9831c7mr171980127b3.41.1730582068513; Sat, 02 Nov 2024
 14:14:28 -0700 (PDT)
MIME-Version: 1.0
From: Javier Olaechea <pirata@HIDDEN>
Date: Sat, 2 Nov 2024 21:14:17 +0000
Message-ID: <CAFVS=zCPdTC7L_fqfsyP8Mzfc=bp4ssSw9Us9q2RgToLVt95vQ@HIDDEN>
Subject: [PATCH] gnu: add bash-preexec
To: guix-patches@HIDDEN
Content-Type: multipart/mixed; boundary="00000000000072ebf30625f489ea"
Received-SPF: pass client-ip=2607:f8b0:4864:20::112d;
 envelope-from=pirata@HIDDEN; helo=mail-yw1-x112d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--00000000000072ebf30625f489ea
Content-Type: multipart/alternative; boundary="00000000000072ebf10625f489e8"

--00000000000072ebf10625f489e8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Attached is a patch to package bash-preexec. It provides hooks that other
programs can use to to register commands to run when one runs a command on
the shell w/o clobbering each other. For example it allows me to use both
direnv and atuin. ej.

(home-environment
 (services
  (list (service home-bash-service-type
                 (home-bash-configuration
                  (bashrc (list (mixed-text-file "source-bash-preexec"
                                                 "source " bash-preexec
"/bin/bash-preexec.sh")
                                (mixed-text-file "eval-direnv"
                                                 "eval \"$(" direnv
"/bin/direnv hook bash)\"")
                                (mixed-text-file
                                 "eval-atuin"
                                 "eval \"$(" atuin-bin "/bin/atuin init
bash --disable-up-arrow)\""))))))))


Cheers





--=20
"I object to doing things that computers can do." =E2=80=94 Olin Shivers

--00000000000072ebf10625f489e8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><div><br></div><div>Attached is a patch to p=
ackage bash-preexec. It provides hooks that other programs can use to to re=
gister commands to run when one runs a command on the shell w/o clobbering =
each other. For example it allows me to use both direnv and atuin. ej.</div=
><div><br></div><div>(home-environment<br>=C2=A0(services<br>=C2=A0 (list (=
service home-bash-service-type<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0(home-bash-configuration<br>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (bashrc (list (mixed-text-file &quot=
;source-bash-preexec&quot;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;source &quot; =
bash-preexec &quot;/bin/bash-preexec.sh&quot;)<br>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 (mixed-text-file &quot;eval-direnv&quot;<br>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0&quot;eval \&quot;$(&quot; direnv &quot;/bin/direnv hook bash)\&q=
uot;&quot;)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (mixed-text-file<br>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;eval-atuin&quot;<br>=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;eval \&quot;$(&quot; atuin-b=
in &quot;/bin/atuin init bash --disable-up-arrow)\&quot;&quot;))))))))</div=
><div><br></div><div><br></div><div>Cheers<br></div><div><br></div><div><br=
></div><div><br></div><div><br></div><div><br><span class=3D"gmail_signatur=
e_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature" data-sma=
rtmail=3D"gmail_signature">&quot;I object to doing things that computers ca=
n do.&quot; =E2=80=94 Olin Shivers</div></div></div>

--00000000000072ebf10625f489e8--

--00000000000072ebf30625f489ea
Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-add-bash-preexec.patch"
Content-Disposition: attachment; filename="0001-gnu-add-bash-preexec.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m30ni4xc0>
X-Attachment-Id: f_m30ni4xc0

RnJvbSA3N2VlNGE1YTU3MjcxZjY5ZjgwMTI3MGE3ZDA0NWUzZmRlOTgyZTk5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8NzdlZTRhNWE1NzI3MWY2OWY4MDEyNzBhN2QwNDVl
M2ZkZTk4MmU5OS4xNzMwNTgxNDI4LmdpdC5waXJhdGFAZ21haWwuY29tPgpGcm9tOiBKYXZpZXIg
T2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRhdGU6IFNhdCwgMiBOb3YgMjAyNCAxNTo1Nzo1
NCAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIGdudTogYWRkIGJhc2gtcHJlZXhlYwoKKiBnbnUvcGFj
a2FnZXMvYmFzaC5zY206IChiYXNoLXByZWV4ZWMpOiBOZXcgdmFyaWFibGUuCgpDaGFuZ2UtSWQ6
IEk2NDJiZTM3MGM5MDMxODNjODkxNzRkYTMwNjY2YjA4ZjA3ZDNhMTE4Ci0tLQogZ251L3BhY2th
Z2VzL2Jhc2guc2NtIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUg
Y2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9iYXNo
LnNjbSBiL2dudS9wYWNrYWdlcy9iYXNoLnNjbQppbmRleCA5MzY0MWE3OGQ1Li5iZTJmMDMwOTJk
IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvYmFzaC5zY20KKysrIGIvZ251L3BhY2thZ2VzL2Jh
c2guc2NtCkBAIC00ODgsMyArNDg4LDMzIEBAIChkZWZpbmUtcHVibGljIGJsZXNoCiB3aGljaCBy
ZXBsYWNlcyB0aGUgZGVmYXVsdCBHTlUgUmVhZGxpbmUuICBJdCBhZGRzIHN5bnRheCBoaWdobGln
aHRpbmcsIGF1dG8KIHN1Z2dlc3Rpb25zLCB2aW0gbW9kZXMsIGFuZCBtb3JlIHRvIEJhc2ggaW50
ZXJhY3RpdmUgc2Vzc2lvbnMuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmJzZC0zKSkpCisKKyhk
ZWZpbmUtcHVibGljIGJhc2gtcHJlZXhlYworICAocGFja2FnZQorICAgIChuYW1lICJiYXNoLXBy
ZWV4ZWMiKQorICAgICh2ZXJzaW9uICIwLjUuMCIpCisgICAgKHNvdXJjZQorICAgICAob3JpZ2lu
CisgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQor
ICAgICAgICAgICAgICh1cmwgImh0dHBzOi8vZ2l0aHViLmNvbS9yY2Fsb3Jhcy9iYXNoLXByZWV4
ZWMiKQorICAgICAgICAgICAgIChjb21taXQgImRhNjRhZDRiN2JiOTY1ZDE5ZGJlYjViYjc0NDdm
MWE2M2UzZGUyZTMiKSkpCisKKyAgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIgIjBueDBt
MWJobTRmNHYwMzNuZ2kybTl6cTN2cHBpbXNtbjhrbXdxYnZ5cXI0bjZna2ptZ3EiKSkpKQorICAg
IChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIChs
aXN0CisgICAgICAjOnBoYXNlcyAjfihtb2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMKKyAg
ICAgICAgICAgICAgICAgICAoZGVsZXRlICdjb25maWd1cmUpCisgICAgICAgICAgICAgICAgICAg
KGRlbGV0ZSAnYnVpbGQpCisgICAgICAgICAgICAgICAgICAgKGRlbGV0ZSAnY2hlY2spCisgICAg
ICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2luc3RhbGwKKyAgICAgICAgICAgICAgICAgICAgIChs
YW1iZGEgXworICAgICAgICAgICAgICAgICAgICAgICAoaW5zdGFsbC1maWxlICJiYXNoLXByZWV4
ZWMuc2giCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBl
bmQgIyRvdXRwdXQgIi9iaW4iKSkpKSkpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHVi
LmNvbS9yY2Fsb3Jhcy9iYXNoLXByZWV4ZWMiKQorICAgIChzeW5vcHNpcyAicHJlZXhlYyBhbmQg
cHJlY21kIGZ1bmN0aW9ucyBmb3IgQmFzaCBqdXN0IGxpa2UgWnNoIikKKyAgICAoZGVzY3JpcHRp
b24KKyAgICAgInByZWV4ZWMgYW5kIHByZWNtZCBob29rIGZ1bmN0aW9ucyBmb3IgQmFzaCAzLjEr
IGluIHRoZSBzdHlsZSBvZiBac2guIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmV4cGF0KSkpCgpi
YXNlLWNvbW1pdDogZWExMWQzNjA4NTY2MTc0YzRiYWU3MGZhYTRmOWQwYzY3NzQ4ZDJkYgotLSAK
Mi40Ni4wCgo=
--00000000000072ebf30625f489ea--




Acknowledgement sent to Javier Olaechea <pirata@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#74180; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.