GNU bug report logs - #74192
[PATCH] build: update gnulib to latest, to enable faster crc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74192 in the body.
You can then email your comments to 74192 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sam Russell <sam.h.russell <at> gmail.com>
To: bug-gzip <at> gnu.org
Subject: [PATCH] build: update gnulib to latest, to enable faster crc
Date: Sun, 3 Nov 2024 10:52:39 +0100

[Message part 1 (text/plain, inline)]

Hi,

This patch updates to the latest version of gnulib and speeds up gzip by
about ~35%:

$ time ./gzip_old -c -d -k large_file.gz > /dev/null

real    0m0.502s
user    0m0.473s
sys     0m0.030s
$ time ./gzip_new -c -d -k large_file.gz > /dev/null

real    0m0.318s
user    0m0.303s
sys     0m0.010s

I'm not sure what your conventions are around updating submodules, I see
the last update was September 8, also related to CRC code.

A quick browse showed this commit might be an issue:

commit 134978bd830b73d9bd7698f8ec2442d541056df1
Author: Bruno Haible <bruno <at> clisp.org>
Date:   Mon Sep 9 15:46:44 2024 +0200

    striconv, striconveh: Drop workaround for glibc 2.1.

    * lib/striconv.c (str_iconv): Remove glibc-2.1 bug workaround.
    * lib/striconveh.c (iconveh_open): Likewise.

Not sure if that means glibc 2.1 is deprected, or what impact that might
have for gzip, but that seemed like the main thing that could be of concern.

Cheers
Sam

[Message part 2 (text/html, inline)]

[0001-build-update-gnulib-to-latest-to-enable-faster-crc.patch (application/octet-stream, attachment)]

Message #8 received at 74192 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Sam Russell <sam.h.russell <at> gmail.com>, 74192 <at> debbugs.gnu.org
Subject: Re: bug#74192: [PATCH] build: update gnulib to latest, to enable
 faster crc
Date: Sun, 3 Nov 2024 11:57:42 -0800

On 2024-11-03 01:52, Sam Russell wrote:
>      * lib/striconv.c (str_iconv): Remove glibc-2.1 bug workaround.
>      * lib/striconveh.c (iconveh_open): Likewise.
> 
> Not sure if that means glibc 2.1 is deprected,

I think it does, but we don't need to worry about that.

Thanks for the heads-up. I have a few more Gnulib changes (in memory 
allocation) that I want to commit before syncing Gnulib to other projects.

Message #11 received at 74192 <at> debbugs.gnu.org (full text, mbox):

From: Sam Russell <sam.h.russell <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 74192 <at> debbugs.gnu.org
Subject: Re: bug#74192: [PATCH] build: update gnulib to latest, to enable
 faster crc
Date: Sun, 3 Nov 2024 21:03:19 +0100

[Message part 1 (text/plain, inline)]

perfect, no rush, just wanted to confirm that I have a local build from
head that works

On Sun, Nov 3, 2024, 20:57 Paul Eggert <eggert <at> cs.ucla.edu> wrote:

> On 2024-11-03 01:52, Sam Russell wrote:
> >      * lib/striconv.c (str_iconv): Remove glibc-2.1 bug workaround.
> >      * lib/striconveh.c (iconveh_open): Likewise.
> >
> > Not sure if that means glibc 2.1 is deprected,
>
> I think it does, but we don't need to worry about that.
>
> Thanks for the heads-up. I have a few more Gnulib changes (in memory
> allocation) that I want to commit before syncing Gnulib to other projects.
>

[Message part 2 (text/html, inline)]

Message #16 received at 74192-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Sam Russell <sam.h.russell <at> gmail.com>
Cc: 74192-done <at> debbugs.gnu.org
Subject: Re: bug#74192: [PATCH] build: update gnulib to latest, to enable
 faster crc
Date: Mon, 10 Feb 2025 22:06:12 -0800

Marking this bug report as done because Jim updated gzip to the latest 
Gnulib on December 13, after this patch was submitted.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.