GNU logs - #74236, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#74236: emacs-guix: guix-command-popup not displaying argument improvers
Resent-From: Christopher Howard <christopher@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Wed, 06 Nov 2024 23:53:02 +0000
Resent-Message-ID: <handler.74236.B.173093713223113 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74236 <at> debbugs.gnu.org
From: Christopher Howard <christopher@HIDDEN>
Date: Wed, 06 Nov 2024 14:51:49 -0900
Message-ID: <87pln7ncoa.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: none client-ip=212.103.80.155;
 envelope-from=christopher@HIDDEN; helo=mx.kolabnow.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,
 SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Note that to even display the guix-command-popup, you have to either set gu=
ix-repl-use-server to nil, or apply the patch from bug#73462.

The magit popup code for the guix-command-popup (M-x guix c) appears to be =
broken so that it skips the popup menu where you would construct your comma=
nd line argument. Instead, it assumes an empty argument, and jumps to the p=
opup where you select whether you want to run the command in the REPL or fr=
om a shell.

This code is in guix-command.el, and uses the old magit-popup interface (no=
w superceded by transient). Presumably either something has changed in magi=
t-popup since the code was written (2015-2020) or some Emacs change has bro=
ken guix-command.el. I hope to investigate this further. My hope is that so=
me minor fix can be made to guix-command.el rather than having to rewrite e=
verything for transient.

One part I am fuzzy on is how to debug it as it is apparently not possible =
to run edebug-instrument-function on guix-command-popup, as guix-command-po=
pup is a function generated by other code. If anybody has any advice concer=
ning this, that would be helpful.

Testing this on GNU Emacs 30.0.92 (build 2, x86_64-pc-linux-gnu, GTK+ Versi=
on 3.24.41, cairo version 1.18.0) of 2024-10-29.

--=20
=F0=9F=93=9B Christopher Howard
=F0=9F=9A=80 gemini://gem.librehacker.com
=F0=9F=8C=90 http://gem.librehacker.com

=D7=91=D7=A8=D7=90=D7=A9=D7=99=D7=AA =D7=91=D7=A8=D7=90 =D7=90=D7=9C=D7=94=
=D7=99=D7=9D =D7=90=D7=AA =D7=94=D7=A9=D7=9E=D7=99=D7=9D =D7=95=D7=90=D7=AA=
 =D7=94=D7=90=D7=A8=D7=A5

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Christopher Howard <christopher@HIDDEN>
Subject: bug#74236: Acknowledgement (emacs-guix: guix-command-popup not
 displaying argument improvers)
Message-ID: <handler.74236.B.173093713223113.ack <at> debbugs.gnu.org>
References: <87pln7ncoa.fsf@HIDDEN>
X-Gnu-PR-Message: ack 74236
X-Gnu-PR-Package: guix
Reply-To: 74236 <at> debbugs.gnu.org
Date: Wed, 06 Nov 2024 23:53:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 74236 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74236: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74236
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#74236: [PATCH] Tweaks command parsing regex to address debbugs bug#74236
References: <87pln7ncoa.fsf@HIDDEN>
Resent-From: Christopher Howard <christopher@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 07 Nov 2024 21:26:02 +0000
Resent-Message-ID: <handler.74236.B.173101473819367 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74236 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, guix-patches@HIDDEN, Andrew Tropin <andrew@HIDDEN>
From: Christopher Howard <christopher@HIDDEN>
In-Reply-To: Christopher Howard's message of "Wed, 06 Nov 2024 14:51:49 -0900
 (21 hours, 27 minutes, 34 seconds ago)"
Date: Thu, 07 Nov 2024 12:25:18 -0900
Message-ID: <87o72q7n41.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: none client-ip=212.103.80.155;
 envelope-from=christopher@HIDDEN; helo=mx.kolabnow.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,
 SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: attachment;
 filename=0001-Tweaks-command-parsing-regex-to-address-debbugs-bug-.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: 0001-Tweaks-command-parsing-regex-to-address-debbugs-bug-.patch

From faa152608c418086af8e79d4bb578de4243d8fd2 Mon Sep 17 00:00:00 2001
From: Christopher Howard <christopher@HIDDEN>
Date: Thu, 7 Nov 2024 12:14:43 -0900
Subject: [PATCH] Tweaks command parsing regex to address debbugs bug#74236

---
 elisp/guix-help-vars.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/elisp/guix-help-vars.el b/elisp/guix-help-vars.el
index 0dc0bc6..b30938a 100644
--- a/elisp/guix-help-vars.el
+++ b/elisp/guix-help-vars.el
@@ -1,6 +1,7 @@
 ;;; guix-help-vars.el --- Variables related to Guix --help output
=20
 ;; Copyright =C2=A9 2015, 2017, 2018 Alex Kost <alezost@HIDDEN>
+;; Copyright =C2=A9 2024 Christopher Howard <christopher@HIDDEN>
=20
 ;; This file is part of Emacs-Guix.
=20
@@ -42,7 +43,7 @@
   "Common regexp used to find command options.")
=20
 (defvar guix-help-parse-command-regexp
-  (rx bol "   "
+  (rx bol "    "
       (group wordchar (one-or-more (or wordchar "-"))))
   "Regexp used to find guix commands.
 'Command' means any option not prefixed with '-'.  For example,
--=20
2.46.0


--=-=-=
Content-Type: text/plain

See also bug#73462 for a patch which ideally would be applied first, but is not strictly speaking a prerequisite.

-- 
Christopher Howard

--=-=-=--

Message sent to bug-guix@HIDDEN:

Subject: bug#74236: [PATCH] Tweaks command parsing regex to address debbugs bug#74236
References: <87pln7ncoa.fsf@HIDDEN>
Resent-From: Christopher Howard <christopher@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 07 Nov 2024 21:26:02 +0000
Resent-Message-ID: <handler.74236.B74236.173101473619353 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74236 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, guix-patches@HIDDEN, Andrew Tropin <andrew@HIDDEN>
From: Christopher Howard <christopher@HIDDEN>
In-Reply-To: Christopher Howard's message of "Wed, 06 Nov 2024 14:51:49 -0900
 (21 hours, 27 minutes, 34 seconds ago)"
Date: Thu, 07 Nov 2024 12:25:18 -0900
Message-ID: <87o72q7n41.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: attachment;
 filename=0001-Tweaks-command-parsing-regex-to-address-debbugs-bug-.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: 0001-Tweaks-command-parsing-regex-to-address-debbugs-bug-.patch

From faa152608c418086af8e79d4bb578de4243d8fd2 Mon Sep 17 00:00:00 2001
From: Christopher Howard <christopher@HIDDEN>
Date: Thu, 7 Nov 2024 12:14:43 -0900
Subject: [PATCH] Tweaks command parsing regex to address debbugs bug#74236

---
 elisp/guix-help-vars.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/elisp/guix-help-vars.el b/elisp/guix-help-vars.el
index 0dc0bc6..b30938a 100644
--- a/elisp/guix-help-vars.el
+++ b/elisp/guix-help-vars.el
@@ -1,6 +1,7 @@
 ;;; guix-help-vars.el --- Variables related to Guix --help output
=20
 ;; Copyright =C2=A9 2015, 2017, 2018 Alex Kost <alezost@HIDDEN>
+;; Copyright =C2=A9 2024 Christopher Howard <christopher@HIDDEN>
=20
 ;; This file is part of Emacs-Guix.
=20
@@ -42,7 +43,7 @@
   "Common regexp used to find command options.")
=20
 (defvar guix-help-parse-command-regexp
-  (rx bol "   "
+  (rx bol "    "
       (group wordchar (one-or-more (or wordchar "-"))))
   "Regexp used to find guix commands.
 'Command' means any option not prefixed with '-'.  For example,
--=20
2.46.0


--=-=-=
Content-Type: text/plain

See also bug#73462 for a patch which ideally would be applied first, but is not strictly speaking a prerequisite.

-- 
Christopher Howard

--=-=-=--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 10 Dec 2024 16:51:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 10 11:51:01 2024
Received: from localhost ([127.0.0.1]:59352 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tL3Rt-0005u7-Ae
	for submit <at> debbugs.gnu.org; Tue, 10 Dec 2024 11:51:01 -0500
Received: from mail-wr1-f53.google.com ([209.85.221.53]:50297)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1tL3Rp-0005tE-Cz
 for control <at> debbugs.gnu.org; Tue, 10 Dec 2024 11:50:57 -0500
Received: by mail-wr1-f53.google.com with SMTP id
 ffacd0b85a97d-382610c7116so3012845f8f.0
 for <control <at> debbugs.gnu.org>; Tue, 10 Dec 2024 08:50:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1733849392; x=1734454192; darn=debbugs.gnu.org;
 h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id
 :reply-to; bh=ZySUOS4fUxXqxZDo9BZwhSmklwSmXLIC5vJrmCYWyBs=;
 b=FAPiY+jIutHs75OJM9xMVlKdL9mF1OY5rC54QHUkhVnJ80gbgis8ybsXk9M7isJZSh
 DEtvbzZqMWpRFQI6HjJd/Mo7XyJYyzUxvMUTw2wCgIBrnH7t32pXzBiMG53JRfHnw2/y
 zlcr6yqnEh9pewnyBZ4Hk6vi69omvPJf6Y4OtqfFOoB5Dvx25B3BNElI8h9nOc7f2Ln2
 zy8FyVning97jpd00FAEiO7ikRzD4aleLOJ186C8zeVsxa8IS1bUzeBqd4S8fn8q0PDq
 UYneZeL1s8b1mxQLmn6eaWqMKHmuyBoMAFa0sMaZ7zzTjAdHEoK+B7t3ZqVNpljcJXYI
 9mEQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1733849392; x=1734454192;
 h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=ZySUOS4fUxXqxZDo9BZwhSmklwSmXLIC5vJrmCYWyBs=;
 b=em+JbDV0j3kuni9KVjClbyT4OCtxtJ1hFi1di5Or/g/qfY6SLIOMMxpjAFjpgCYy5z
 JUoIyK6PLed7Ec3/z8AoK3dqFS8o75Fpbg5/rKwi1EleIXb6uzo9d9OobEJqB0zc1FAf
 fhxoLTk2//uUmyXiy1+yqwLjtbpWtCD3UtqqVf3nqen8EoXRRMTtQ5m5F59HYu0pSf/2
 KlG6t4RopOtsLdAXEQ9yDJtXhdUE9yjwKIwu4vIIselSLjwHebcbit/WoUppy5sHLgKO
 4yhLGDVHZSg5M+TKNw0A+lCgGZsP5LEzlL1WU0VU6qFssHWXgOJHN4xLWsWhVzNTefIi
 Sqkg==
X-Gm-Message-State: AOJu0YzluQjcqF8KUfDGQh+cQatdqXUm10oR5UtjbXdCGUcjSi3mw7ta
 OFYl7R2RyI1dAk8y/XoqTFDf3r5IT34oEPHA5nS29avYRPC+ffh3lvN2vA==
X-Gm-Gg: ASbGncvl3KAWN22ITAVr+mRW1q1xFUl8gftNQS/CHAB87Lm42MSGrE9xMFOo8C3C7q6
 DmifvpY8z66KcqNuDb842z5upXRVm7zspVCj5ZIFQAkmtc18wD7tFz0QTmR0t11+uKsTBUvtvUK
 X7RlcnyXExO28eGfDUZ1IBchS1mulxIWkKnoyWPHSv7jyNVJgNQLCGHwySAyWwu0282IC2atQyL
 S+5okwICIHnKyKFBOxpFXiYPgZETLmyfUQZ9A4tl75JY6Xqlw==
X-Google-Smtp-Source: AGHT+IHHHJE610wGsni9OGlVdNKBTjGnSmubLBb5TW4KAKz96BvYhXEjHY4bfGyqHYxTIqG4pX63/A==
X-Received: by 2002:a5d:6daa:0:b0:385:fac7:89ba with SMTP id
 ffacd0b85a97d-386453f9d59mr4342164f8f.47.1733849391725; 
 Tue, 10 Dec 2024 08:49:51 -0800 (PST)
Received: from lili ([148.60.59.223]) by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-38621fbbc08sm16555888f8f.86.2024.12.10.08.49.50
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 10 Dec 2024 08:49:51 -0800 (PST)
Date: Tue, 10 Dec 2024 17:33:26 +0100
Message-Id: <87h67bxzu1.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: control message for bug #74236
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 74236 + patch
quit

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.