Received: (at 74276) by debbugs.gnu.org; 14 Nov 2024 15:36:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 14 10:36:32 2024
Received: from localhost ([127.0.0.1]:46802 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tBbtY-0004wl-2J
for submit <at> debbugs.gnu.org; Thu, 14 Nov 2024 10:36:32 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20723)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1tBbtV-0004wY-QZ
for 74276 <at> debbugs.gnu.org; Thu, 14 Nov 2024 10:36:30 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 32D7E100180;
Thu, 14 Nov 2024 10:36:24 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1731598583;
bh=d/6237MF6zqtQ/y+Iq5wrwXcn/3MyHTww6zIWLTncx0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=Fvijo3TJmBuEKIFTpxtvQeMdDt8M7Brf+oWy3y0dWhyhXFwmp0UE76jZZ/LIZ+nKt
PLySUaAaK5ve0AJCymqvBnzWaMGZ5TiXSz/JSWcqdqKdjn0JU3ZlkLMcYLQPQGsoed
eVlsArVpdiupvdG/Kce/pCdfUNv9jFfEOeEOYu8yldSmvmtd04Y5Ctr9PW4x5T3j5x
PfWpWmIBEDHxyGUP1BUmW6kVjhrHuEyNHgKMKiQIblIR5qNP2gh2rHf1+u7LynJoLj
JcApQRUdIk75rH8ZUTt65SOBYbKHFaCOkd+Hm7j+2UhextpSh6LKRzqf8dGLZ8M9D/
vuPuBU8xR0f4g==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 79885100043;
Thu, 14 Nov 2024 10:36:23 -0500 (EST)
Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4E0D9120426;
Thu, 14 Nov 2024 10:36:23 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#74276: 30.0.90; undo does not account for overlays now that
markers are not used
In-Reply-To: <865xowmmo8.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 09 Nov
2024 17:50:15 +0200")
Message-ID: <jwvh689ub0c.fsf-monnier+emacs@HIDDEN>
References: <86jzdcsyc1.fsf@HIDDEN> <86fro0omey.fsf@HIDDEN>
<jwv7c9c1men.fsf-monnier+emacs@HIDDEN> <865xowmmo8.fsf@HIDDEN>
Date: Thu, 14 Nov 2024 10:36:22 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.266 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 74276
Cc: karthikchikmagalur@HIDDEN, 74276 <at> debbugs.gnu.org, jimjoe@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> > Stefan, does undo restore overlays, and if so, how?
>> No, I don't think `undo` has ever tried to restore overlays.
>> But it does attempt to restore marker positions, so I guess there can be
>> cases where the switch to itree has caused overlays' boundaries to be
>> restored less well than before.
> Well, in this particular recipe Emacs 29 and 30 behave exactly like
> Emacs 25, do at least in this case there was no regression.
Which suggests that maybe the code we have to save/restore the position of
markers in `buffer-undo-list` doesn't(didn't?) really do its job.
> But maybe we should add to undo the capability of restoring the
> overlays.
Maybe.
Stefan
PS: Reading the `record_marker_adjustments` in Emacs-28, it seems that
this code would happily add to the `buffer-undo-list` markers that were
"internal" to overlays. That reminds me of a discussion many years ago
where I suggested we add functions to return the begin/end markers of an
overlay so that ELisp code could use `set-marker-insertion-type` to
change the insertion type of the beginning/end of an overlay (which is
currently otherwise fixed at creation). This was rejected because
exposing such internals would be undesirable (e.g. making
backward-incompatible the change we implemented in Emacs-29) and risky
(allowing inconsistencies like overlays whose beg and end don't point to
the same buffer). It turns out that such functions could have been
hacked all along in ELisp by (ab)using this `record_marker_adjustments`
code:
(defun overlay-markers (ol)
"Return the two markers of an overlay as (BEG . END)."
(with-temp-buffer
(insert "aa")
(let ((beg (point))
(_ (insert "bbb"))
(end (point)))
(insert "cccc")
(move-overlay ol beg end (current-buffer))
(let ((buffer-undo-list ()))
(delete-region (point-min) (point-max))
(cons (car (rassq -2 buffer-undo-list))
(car (rassq -5 buffer-undo-list)))))))
=F0=9F=99=82
bug-gnu-emacs@HIDDEN:bug#74276; Package emacs.
Full text available.Received: (at 74276) by debbugs.gnu.org; 9 Nov 2024 15:52:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 10:52:39 2024 Received: from localhost ([127.0.0.1]:54088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1t9nlO-00025l-Rz for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 10:52:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1t9nlM-00025W-O5 for 74276 <at> debbugs.gnu.org; Sat, 09 Nov 2024 10:52:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1t9nj9-0004Im-Sp; Sat, 09 Nov 2024 10:50:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GMxe6pEBmDH4kK9Bk4OEZKVNp1VBQSBBU9RgF+rUTxo=; b=iPLkPTCVfNdW Rzxgdhd4Uz5sEtCI9+rlGcSJpUoFsjSoUd0YbgpI/BOSHhWlqW9K4c1AuCoEwIDtRWEqmKEB0k6ui Yge9XQb1OAZPXwwWoA8ny//eg+t+YuwBI3/1N4P4bwK+x03gP344YTtUQQ3LG23wjBKR53I6xAmmr 4De07z3Ul35k68ziDynrsHpnHYecJiiLFrRcR9+G/37EfX/LXnJxdDV9TjdLt6cKWj0MDllFvA7Xt UBDWZZGVHnpEK/4j0waDjhUZ4Ek8ffhh1nCAUmr6DRGRf8pjM7+MRyTIdVE5zyQ8uL2x8Cs8nAOY1 n7ExdvRkVaKm83hQVWktfA==; Date: Sat, 09 Nov 2024 17:50:15 +0200 Message-Id: <865xowmmo8.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <jwv7c9c1men.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Sat, 09 Nov 2024 10:05:51 -0500) Subject: Re: bug#74276: 30.0.90; undo does not account for overlays now that markers are not used References: <86jzdcsyc1.fsf@HIDDEN> <86fro0omey.fsf@HIDDEN> <jwv7c9c1men.fsf-monnier+emacs@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74276 Cc: karthikchikmagalur@HIDDEN, 74276 <at> debbugs.gnu.org, jimjoe@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Monnier <monnier@HIDDEN> > Cc: James Thomas <jimjoe@HIDDEN>, 74276 <at> debbugs.gnu.org, > karthikchikmagalur@HIDDEN > Date: Sat, 09 Nov 2024 10:05:51 -0500 > > > Stefan, does undo restore overlays, and if so, how? > > No, I don't think `undo` has ever tried to restore overlays. > But it does attempt to restore marker positions, so I guess there can be > cases where the switch to itree has caused overlays' boundaries to be > restored less well than before. Well, in this particular recipe Emacs 29 and 30 behave exactly like Emacs 25, do at least in this case there was no regression. But maybe we should add to undo the capability of restoring the overlays.
bug-gnu-emacs@HIDDEN:bug#74276; Package emacs.
Full text available.
Received: (at 74276) by debbugs.gnu.org; 9 Nov 2024 15:06:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 10:06:11 2024
Received: from localhost ([127.0.0.1]:54024 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1t9n2Q-00006F-Lg
for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 10:06:10 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36829)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1t9n2N-00005j-Er
for 74276 <at> debbugs.gnu.org; Sat, 09 Nov 2024 10:06:09 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DF5D1440BBC;
Sat, 9 Nov 2024 10:05:59 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1731164759;
bh=7U5UfsafOQVW/R5TjjqTufDtJSpwLLsIYyyXrqyvvrk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=hnfhuBu5PMKSiaEf3JKreEnq7xj3UrN2CxiEWeIDKnEgr5l3Y612sKpFI9q7NNpOX
eTlaj1TuL44oO7BleCfcUkR5U5WzY/m7+RwnEp2z45/uLEHFJ1bKjQdaSVcrmL1ogl
1McXnnFGR+W/FlVYoEa58mKIBMSFlamSl4uEuAp2b7XLBOVxOcgTcRONQ6PwrOmFVj
kq0uPLyAAAVE15s6OK/BZIkxV1y6i/yjG6iDfRU8/YQf93NBreguuq6jdXJa1xIz1l
0Oi+jHdph6XJNc6jkZA2ua3nP5OsEhKjXdOnL9NuCh65BAj7Eh2F0VkQPlFMvCme9s
t7NQQxStBOuPw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0AE2D440B62;
Sat, 9 Nov 2024 10:05:59 -0500 (EST)
Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C96B91203E2;
Sat, 9 Nov 2024 10:05:58 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#74276: 30.0.90; undo does not account for overlays now that
markers are not used
In-Reply-To: <86fro0omey.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 09 Nov
2024 10:12:53 +0200")
Message-ID: <jwv7c9c1men.fsf-monnier+emacs@HIDDEN>
References: <86jzdcsyc1.fsf@HIDDEN> <86fro0omey.fsf@HIDDEN>
Date: Sat, 09 Nov 2024 10:05:51 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.043 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 74276
Cc: karthikchikmagalur@HIDDEN, 74276 <at> debbugs.gnu.org,
James Thomas <jimjoe@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Stefan, does undo restore overlays, and if so, how?
No, I don't think `undo` has ever tried to restore overlays.
But it does attempt to restore marker positions, so I guess there can be
cases where the switch to itree has caused overlays' boundaries to be
restored less well than before.
Stefan
bug-gnu-emacs@HIDDEN:bug#74276; Package emacs.
Full text available.Received: (at 74276) by debbugs.gnu.org; 9 Nov 2024 08:13:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 03:13:09 2024 Received: from localhost ([127.0.0.1]:53267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1t9gaj-00078n-5B for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 03:13:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1t9gag-00078J-Cv for 74276 <at> debbugs.gnu.org; Sat, 09 Nov 2024 03:13:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1t9gaX-0002gj-BH; Sat, 09 Nov 2024 03:12:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dWfTItxOBgG3n9BMfpulPoc2taL2OU3djjzR4JE27DQ=; b=SUNP2ohOcAcV hz7Jev/QiSNh5gJsTAN3fmYZ5bUl0tmQf3ikLiyh5/b5YLgFGT8JfxO1fMMlf5SowMONiixwbEPoi O1wKgNKMRQrBBenf3f2PRrjfX7LFkeHkZBvazB+qmQpSnxhKPVwGQdlZDkkopEO9YSunM8GmKZ8Jr 1muxlBCHCfbGSEc4wJY/w1CkcKVoXsmggZ7x1qD5uNVwHUbj/efn9FR5JkZKXqeZJTyYeRlm5SKDO 4yhYSGKAOv6svN/n9I+W+Sn4aYqkaNhLED80sMm08RtGCIiq0UFSiNz5wPXsdJPdx7FS6QEZYktTl 9JWQxxzsgRpCj+cwNX7V2w==; Date: Sat, 09 Nov 2024 10:12:53 +0200 Message-Id: <86fro0omey.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: James Thomas <jimjoe@HIDDEN>, Stefan Monnier <monnier@HIDDEN> In-Reply-To: <86jzdcsyc1.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#74276: 30.0.90; undo does not account for overlays now that markers are not used References: <86jzdcsyc1.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74276 Cc: karthikchikmagalur@HIDDEN, 74276 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: karthikchikmagalur@HIDDEN > Date: Sat, 09 Nov 2024 12:11:50 +0530 > From: James Thomas via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > - emacs -Q > - Type: abcdef > - C-a > - M-: (overlay-put (make-overlay (point) (+ (point) 3)) 'face 'highlight) > - Mark the text 'bcd' and delete it > - M-x undo (does not restore overlay correctly) > > (The solution seems to me to be for undo to also store the overlay, > adjustment, and whether left, right or both boundaries are involved, and > use it) This didn't work with the old implementation of overlays, either. I just tested in Emacs 25 and I see the same results there. Stefan, does undo restore overlays, and if so, how? I don't see anything pertinent in the Undo section of the ELisp manual except the reference to markers (which overlays don't have anymore). Did that ever work, and if so, how? And how should it work now?
bug-gnu-emacs@HIDDEN:bug#74276; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 9 Nov 2024 06:42:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 01:42:25 2024 Received: from localhost ([127.0.0.1]:53158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1t9fAv-0003I3-Fo for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 01:42:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:48168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jimjoe@HIDDEN>) id 1t9fAt-0003Hn-Dx for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 01:42:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jimjoe@HIDDEN>) id 1t9fAV-0006aU-Fw for bug-gnu-emacs@HIDDEN; Sat, 09 Nov 2024 01:42:02 -0500 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jimjoe@HIDDEN>) id 1t9fAT-0002en-7D for bug-gnu-emacs@HIDDEN; Sat, 09 Nov 2024 01:41:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1731134515; x=1731739315; i=jimjoe@HIDDEN; bh=UYMhjdpeKqX2/i1q++T7I7er8rDskFjE3XckLR8Cqd0=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=sjGin2EKkXqZLS05ScVOmXjFTiDOMo10zKuCFjw9/93HYgx26wtYYugdl3s/s1ZX +clo3NVuOFhD4F9F+5ijBupZOgD+UBlSXnWJ043OrycX4Lv3NgQF5zp/shYA39sOp vwdPPF8Kd+t8TY8r5MpCX/pdXoLRkxegU6litf1JPrwlhxey/eLP1CmqVUYE68KAn eTf6TMY/dXpnt6xIYw4bwy+8OYeTNmd8pGm4raAW8uhMuT+7D7HxxgG3+cw0+O3T1 5RAC1xTtIBv7qKjcOpiZGNuY1eRoABOWgrGCS5El22bNCtU+mZlzgzi/ybsyfTXSg WJApzrwKJlnGUgy4qA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([42.108.12.69]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MJmKX-1tOrjn35x3-00HgHA for <bug-gnu-emacs@HIDDEN>; Sat, 09 Nov 2024 07:41:55 +0100 From: James Thomas <jimjoe@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 30.0.90; undo does not account for overlays now that markers are not used X-Debbugs-Cc: karthikchikmagalur@HIDDEN Date: Sat, 09 Nov 2024 12:11:50 +0530 Message-ID: <86jzdcsyc1.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:xrNczKuRIro1zV7EBjGUlKY6vfr5YpGu9QWqukNgHTr/ZxHIzBu 4/t86JA0MSS0LRBEG9e8w4yf3r4QIixvUY3OrooErDzy91bTKpAYchyySuPy6tP48d2pWv3 jSj7GLCFAYc4iYEI66efKb2wMHY0s8kgmUlBxwMxcTH7MH6dDS5Kjs5vKPaeXpatNH8QYYc 5AIrhkZiBBgm47of5PSkw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:43Do7FE+bec=;EAOLtLzL0A/RHxF9zJeKUyb7nCn wn0PG+PBlB39w/RO0xxx2yfyXR/hw7V3SQaq0gRoiZpk/zYOITnJrFmi51pJ6q1um3qVxZodm GGj5gvYI58gj4aD3uZcuYyu1+w9SeU5yxQcdazaC/fq/KInqkZ0HkB07ZHvPXXio0zaR2H91d vZ2eZYZQuZzuRn/LbPVMOCw5Tw4rTnZVG1hMcN4tyfGNSMSsGl8uUMYIaPJ/w22KEDqQMMZql 45zwSuXfZmub5dCsPqaEMFH4QZzMeJn7kDiMB5ZEzc/x3I7zmrUKr7hiVb132FE14TrAhGTeU 7kDFu2188Mzd/2vd6MsCTHBJSmqDbGdt3w7nGoAy+WeA//8H9S3lkGi4Z8JH/eL4kV/gVmQhr QX32IW13KX4Qq0lYbH1FNECJH6JHiPN8PO/XYiouGFxImWocpL+QJpK9y2Zva+jyIAvIFjSGR qqnmFm8wTZlNadG5k+hx9kxFJ4R7cizOTzL5vZuYGms7DsA3BMv1uNT8gH+vrys8YvJvwMUSu DEuhAohKfQcCQ5FbWQtAcn0zvV9Z7JwaaP8VZjSKNMunKJ+CUj37Q1YWhGqlxXhncNB5y30Q9 SukR0aCXugE99baOKbfUqUz7tZ9d8jG3d27fPPSSIpGl3/daUNYecM3kZQw+QqzSwJiNv4L5M 1NnfjcCjhrGC+C2Be/Of/XdjV74uBGJhQYpedQgoc3stSfPWPybVCTOZ0l0JMwvl9nxdIWgZi 0avItGXgZm76a6vkQdZn6jLRKXaNuabw1xeIzi62m58nUxGqISv6fpuzqRxV240l1N9YNi01N Lz3LnUW67DCqqp11nrZrSJNqRVpnOUOk/54nnQcy7KaDpzbJ9PgYxOnDlfvuGZDHxJN1b0sh4 Pi6ivxPPC4RGRLRaGzMrZhmKvWlIxJs76tMlQGRYgNLYVmCmXHyFZ7NSD Received-SPF: pass client-ip=212.227.17.21; envelope-from=jimjoe@HIDDEN; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) - emacs -Q - Type: abcdef - C-a - M-: (overlay-put (make-overlay (point) (+ (point) 3)) 'face 'highlight) - Mark the text 'bcd' and delete it - M-x undo (does not restore overlay correctly) (The solution seems to me to be for undo to also store the overlay, adjustment, and whether left, right or both boundaries are involved, and use it) --
James Thomas <jimjoe@HIDDEN>:karthikchikmagalur@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.karthikchikmagalur@HIDDEN, bug-gnu-emacs@HIDDEN:bug#74276; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.