Received: (at 74385) by debbugs.gnu.org; 13 Dec 2024 16:17:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 13 11:17:06 2024
Received: from localhost ([127.0.0.1]:43860 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tM8Lc-0006jP-Kv
for submit <at> debbugs.gnu.org; Fri, 13 Dec 2024 11:17:06 -0500
Received: from wolfsden.cz ([37.205.8.62]:36680)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <~@wolfsden.cz>) id 1tM8LT-0006j4-TJ
for 74385 <at> debbugs.gnu.org; Fri, 13 Dec 2024 11:16:59 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 2B90A35E4E8; Fri, 13 Dec 2024 16:16:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1734106610; bh=c2kbFjZMcvY0EXvv/dUskKW38/EgkcgXdXFS2krqoMk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=uHJuPuV5dIOdw5zqb9q6m+Gqjbbth8GGj+OXowgwkF2TmT5zcQagfdOXuwRbpyj2M
O8JR2bdCLcpDSyXXWZ8/FEy1ITPzKhEaBp6ejp1MAu8+GbtH9p3a16VKAHcGnCds0K
x1rvMcHLX2Fp5rPF+31b/j8g3x5HV3Bdd6YVsnaYjJGOD4USAUQk26aaLJA6bqAJyD
AlToBqkvgxgNYJ6arNaOdiFy5oeDeN0xaputaBw0htWg7NvIE3ivrB4ZavO2yUeeeL
xqozcsbNoY8yFnf1OQr/JEO6HzNLHkzMCCQw2EYV5bnKZgIHPerM8LgsWff2q4QJnz
h0J/6RQut5y7gaUryiOLnhlkw3fBiHsu+0xUrs+n/BgWAZp3vbhAdOQPeR52b0S91V
yisiwyK19BzPR+dD/vGaw/1oQrraOHnReJbd7L4vh1b+h1ElOE1qk+Jt5AFur0O/wF
FVayMiLs4zB643k6r82IVI3DE2s0F6L0lUOJSp+Q0qn9luWlisXfSOxiece/d70j6M
mirQbzvs0qJZ7shEn3dOX7/XgUuleNfVxvAJud8cGM+kfVYpW003LSsmIPclh40uqe
b+i5k9hpjxCeSvUmUE12TgeRIFAgev4CoaqMjnJvyuPO7yYij2N40sq0hpHuCNyKZl
/blNHXaK1lFQj6aql2k7Q2Rk=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=unavailable autolearn_force=no version=3.4.6
Received: from localhost (unknown [193.32.127.159])
by wolfsden.cz (Postfix) with ESMTPSA id 1A13035FFA9;
Fri, 13 Dec 2024 16:16:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1734106609; bh=c2kbFjZMcvY0EXvv/dUskKW38/EgkcgXdXFS2krqoMk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=OPUZlThRN2ZmDFkX2Nvw4f/7d/nzFUgLp0oKs1XBxg4xq74R0S9bRb/AI77u5Bxo0
9MZ8UfrJa2qgYj9Y+Jm2xn6D8ewasuqbYxTymHSqA+TRTuU1CMHp7ZRqpuTUBw7hUZ
ZvSRN7cITYn7Xf9u2Z2mHQUc3wYmKodbd0Iu7VVav0N/P6kBwADiEYTiAwiC78jqGY
Q6vnQvwbkEsNmduDNGUpe+e4z1x9KuVrfYSvWSytg75nRWfXDEhGyHvEELCa548Z9y
fRewVxK+A/IaKFQhD8icgZ5SIkEbxiHaeNwfmBQ9EJRvIhoslNk8Hc4JL6dKuNMMbe
7uaH6izVb4SNjjabOg3WQBCccDumUjBRuHLy0R78UrJZF7A5gXuvkkk2AmhIfXygRb
h+8oQXi3/9/qkycIGYSEIqI1NF71aMPbPYST5xIL1heoC2zWRvfHO8DNwypQVLjlIp
ch6sxcL5KAx60/iUZjIR6vGE48uovOj3BC4MDDk1vmTvDbv/ejKY9Q+0MHwwMg4fT7
KTmGYtCHIImHsi2u1YBZIzgqiH7aJnQwDivMRIGmSZdz3atJJkBU8KuJqqr41Z4xqs
LVJwrnzuSZON4vCFra9OBNxTn6SFtOiw5JYLbppXYDA8ekIXKKUuQyMdYztnWf8dny
jylRhp2qzbVeYG3HYk1H/nnE=
From: Tomas Volf <~@wolfsden.cz>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#74385: [PATCH 3/4] srfi-64: Export define-equality-test.
In-Reply-To: <87jzc8n63o.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
=?utf-8?Q?s?= message of "Mon, 09 Dec 2024 18:01:15 +0100")
References: <20241116174210.9160-1-~@wolfsden.cz>
<20241116174210.9160-3-~@wolfsden.cz> <87jzc8n63o.fsf@HIDDEN>
Date: Fri, 13 Dec 2024 17:16:47 +0100
Message-ID: <87y10jlfrk.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74385
Cc: 74385 <at> debbugs.gnu.org, Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
> Hi Tomas,
>
> Tomas Volf <~@wolfsden.cz> skribis:
>
>> +(define-syntax define-equality-test
>> (syntax-rules ()
>> ((_ name test-proc)
>> (define-syntax name
>> (=CE=BB (x)
>> (syntax-case x ()
>> ((_ test-name expected test-expr)
>> - #`(%%test-2 #,x test-proc test-name expected test-expr))
>> + #`(%test-2 #,x test-proc test-name expected test-expr))
>> ((_ expected test-expr)
>> - #`(%%test-2 #,x test-proc #f expected test-expr)))))=
)))
>> + #`(%test-2 #,x test-proc #f expected test-expr))))))=
))
>> +(set-documentation! 'define-equality-test
>> + "@defspec define-equality-test identifier proc
>> +Define a new test form named @var{identifier} with same signature and u=
sage as
>> +@code{test-eq} but using @var{proc} instead of @code{eq?}.
>
> I didn=E2=80=99t notice earlier, but you can add docstrings like this:
>
> (define-syntax define-equality-test
> (syntax-rules ()
> "This is the docstring."
> =E2=80=A6))
Ah, good catch. Since that works just for syntax-rules and not
syntax-case, I probably did not moved the documentation string around
when switching between them. Will update.
>
> As for exporting =E2=80=98define-equality-test=E2=80=99, I would clearly =
mark it as a
> =E2=80=9CGNU extension=E2=80=9D.
>
> The way this was done before is by having more exports in a separate
> module, like (srfi srfi-9 gnu).
>
> Whether or not you pick this approach, please make sure to document it
> in the manual and to prominently mark it as a GNU extension.
I personally think that leaving it in one module is fine, and I agree it
should be documented. There are other GNU extensions already in the new
SRFI-64, and I plan to document all once #71300 is merged. I will wait
for v2 until that happens and will include the documentation changes
required.
Have a nice day,
Tomas
=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmdcXe8OHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wamW/w//Q3qyLCBbtd7GYPsmX4n5znOq6RzOdW+2ePZS
85/x5sW8yoMyO99UPGYy08i1S+yqhttlh4Nd3NRenhHgyQy9a2MD8pbRHlxbLlXY
Jl2XR9Ze6GQDs5xA6EZf3bsHd4H4rou7zLpX7xPV1RvTFncYL6j6yt03oaAt5Z1p
+/eQc/dhWNzLq8ibWzvOF4m2yBbhgOlcS2vE1z8rLOJbY4cLUO+w9jl8nVVQHEdO
aTmhM/9P7b9OuhlDZPWbEzxmXtR9Bk+ICQqFO+k2zSBhF+9e0YF6537Se81urv21
J4DJpSHzOfj5reEKA+WwRI26SaSx4P97vQo2k9w0Z8AfhkgMFU315ACUK62y9io3
nREEL9qeLGPnvsnIcAbc2FwnPPYjBL1xR58h/B2Z+LvEeakQCRSew30tU653qMDy
gZvUmYPAtndEzx+c37R6jsv0F0FEbrBDvPigSKGAjrFI8rk91NnpmRiEsVegsZpq
iK4nRIcGxLIfaBanKUNOca6MO2EZwaieIU4uI5AZAlNZlw45fE+Z+uoBAo5qV6C1
4T3BLlrswNmAB2tLGZX+9fp9JGNTMLEvD/ZgvM1uFeihEYv32IJZ3bq/ew9KquLR
4wvMk7LHEcOqsKXewXAarCluan0Ppklr7/yKDKJLgKlJV1ZTiDIUrVseOYLwvZvk
OtS+Ivw=
=PuRf
-----END PGP SIGNATURE-----
--=-=-=--
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.
Received: (at 74385) by debbugs.gnu.org; 13 Dec 2024 16:06:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 13 11:06:16 2024
Received: from localhost ([127.0.0.1]:43835 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tM8BA-000696-0i
for submit <at> debbugs.gnu.org; Fri, 13 Dec 2024 11:06:16 -0500
Received: from wolfsden.cz ([37.205.8.62]:60314)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <~@wolfsden.cz>) id 1tM8B2-00068k-BL
for 74385 <at> debbugs.gnu.org; Fri, 13 Dec 2024 11:06:09 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 79FDC360429; Fri, 13 Dec 2024 16:06:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1734105962; bh=Cp7pCM1Mcz3CMwth2pJfhwvRF4XOLhn2P406j/DmTr8=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=a3V/Ef2f1U8cmkcesCLC6beDzLVZY7vuaQOITz1fFYoX9p0Z2ra2M8D5zpJ+gKxSF
d3hNbp8tmi6MdfDBP/7jFPpZL6g//DDLFen1p4iZE3QzPjhJE9m7RKZYVHsy0+88gf
ynFPzZQhfUfb2jVJEwGvEtj21vaA6xAw22XDUxLumHZua2WPIrPCvzYDgtryam5+IR
4k9Khmc6m/yCo+Ia+I9/TMw41chx3gC6u6fSQHZeiATcsk8ylq6cHRJUlKqt8y6vy2
MF6woCLTSXJlXIwJ2WIDhQvEFISr6sJsb69S10cR4OBjKDPjVuVnWMiTVyc8JaJTuU
uv/EODtAKpJSPbPYEkgQYDzbTf4f2R+V12nwMQbtkx+m5kzOT1TVczJd3ZMcGq/075
IEnAhSTX4D+v/lJXRwmCDoL4s5CJjCoP/WTIgmGaRuV0yI7mvntWwu2+gPubaaU4q6
PrwjzDYHu6GG1IZgEbjugS2zJPZrNstKJQLc3lL02vRzystIsWa2i/BCqKRgu4HVOj
oYFFpmTvyI+iIAy/4CAfko4ziepDqrF6wPzw8THF6cgT1S1D6bSvGaEUO4zslKnMAL
j+kQih45zxgdZ6A49lcW0MAQNB9ySWd140k8PU7pWo7/iisIl5i9EtxvgjtMJIPp3/
CHaUS/ScGMALkL40V5g9MCDM=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [193.32.127.159])
by wolfsden.cz (Postfix) with ESMTPSA id 8887335FD21;
Fri, 13 Dec 2024 16:06:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1734105961; bh=Cp7pCM1Mcz3CMwth2pJfhwvRF4XOLhn2P406j/DmTr8=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=ph8fP9PnHQN4WE1aK4rYLGA9MBO7dqLu/AfoG/4e73L/IZQdiHsFUFK2jBaD15bIV
jpZBWZoaBXvhaugtgX7lfDK9l8FZFWhYrHEiR7YHwMlXGGkfMkXigNy6peV2oDYswM
4Vev3K+ymKIR9Ka+fzZfBXZjx21fLdNTAj5vUJjzr0r56GBx3bpaZ2hN667MKd+iGx
Y6aHJepbmQG2M0UIQokaxZF/pmdYOeqdmJBFEHAXX5cLpuMzHTUo27of+a/jYHcWEu
3rWJsEApod+YN49DJuFdYQr5wgU5R2/nHi/6GC9qKrHhb6N0FPFPeWyrQ40id2mkrU
jG4zNAtb2JMsvT7x1PukdyH6gw9RVVJA6X/UjLfDlMUHhYgdpQO9xdvRp4jmy0kgIC
4oUq7lbH0LkeV4JApVHRLFE9aMPjTJHcyJeujFLv3yGuSCnx4EUpLdGWNwD5VlUMuQ
hUaos1O6XisIMukgTyW1Y475mx96jUHUgoth6EqPGiYtcQ6gYS/7ffMGfp32bOb1+r
bz1JitH0QJE6+71bg1j1AcxZRLdyq4V1yMZln8sVY4CWRPif9nEoEibo+/7p262REs
PmImmQ/DxUpSGzfftLMm8jxU7kOjFo+x59gNHr/B+CeOnBm/FwG+I0w2Xr8/ANZWmC
GGEqx42+GkgAkxKLZ7+WoHW4=
From: Tomas Volf <~@wolfsden.cz>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#74385: [PATCH 4/4] srfi-64: Report failed tests in
(standards)Errors format.
In-Reply-To: <87ed2gn60u.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
=?utf-8?Q?s?= message of "Mon, 09 Dec 2024 18:02:57 +0100")
References: <20241116174210.9160-1-~@wolfsden.cz>
<20241116174210.9160-4-~@wolfsden.cz> <87ed2gn60u.fsf@HIDDEN>
Date: Fri, 13 Dec 2024 17:05:59 +0100
Message-ID: <875xnnmuu0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74385
Cc: 74385 <at> debbugs.gnu.org, Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
> Tomas Volf <~@wolfsden.cz> skribis:
>
>> There is a page in the GNU Standards document regarding the format of er=
ror
>> messages. Both GNU Emacs and Vim are able to parse it and support jumpi=
ng to
>> next/previous error. My version did not produce a line in this format f=
or
>> failed tests and this commit rectifies that.
>>
>> * module/srfi/srfi-64.scm (test-on-test-end-simple)[non-passed]: Write
>> out (standards)Errors compatible line.
>>
>> Reported-by: Janneke Nieuwenhuizen <janneke@HIDDEN>
>
> I personally like this but my gut feeling is that we may want to stick
> to whatever the previous SRFI-64 implementation was doing, to avoid
> disruption or breakage for users (remember we=E2=80=99re applying this to=
a
> stable series).
I agree that the output of the simple test runner of the current and the
reference versions do differ, by necessity. I tested the change in
Emacs and it seems to work out of the box, the compilation buffer
correctly navigates to the locations.
However I understand your worries regarding the stable series. What I
would suggest is that I can extract the test runner from the reference
implementation, and package it as reference/test-runner-simple. User
then could, with a simple code change, use it instead of the new
compliant runner.
I would even go as far as to provide a mechanism to select the runner by
environment, so GUILE_SRFI64_DEFAULT_TEST_RUNNER=3Dreference would cause
test-runner-factory to return reference/test-runner-simple. If unset or
empty value, it would use the new runner as it does now. This will
allow restoring the previous output format even with no code changes.
Combined with NEWS entry, that could be sufficient? What do you think?
Tomas
=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmdcW2cOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wakEng/+M29jVvhfByzd4JpTyRq6t8IEn4VflPeodCox
sIv2pWrP/rIUeOxCHpHKnvEaQhtIwmOlKAYJogJE0h/3Vdb+0x/mEdZEI0yPHmp+
nhbX+TpNYs6XoYh3fV7fhq9yfR8wBIBZB4uVCnqUsooQVt4biZz1OIe33mj7kUQG
IUYNs6c3MXn3iwBsBZsrk0nFqu9WSCtQDlRdequ4A9AiOle0WwXja+jXdZGmLKtl
vKPJTX40w2PH6HgetDW/cQCfXzZywvNBoh+UGd1aC2zYlMdLxefG8wYEdGb1F5pr
ZaydyI8t0KZ3890g5Aw/tYWHl0jW8LYq2pndSXQU3VJdzT8DvGpTB0IsTO9y7OfI
LdcfOW2VCCnZfXuN9JI8V84T8yupt8GMY9IX8ugWdP3NPfPSwMZvBw/8Z7DDxF8O
VLf9eT1/tvGjQHw8nV9pUDUeI/C55TkejPeRO+u4P4nlppBiZL9f6yQS9Cl41A5N
PkHr03POzvew8GkNOGBggjly70FGaDtpYE8c+f94YHQfSLyOI9jGIh6bL3z41e9i
K3/tZsHUZtTqW5AGC9uOBaDOL50zOeuoF2x1efQDjfmLQrlWASSzPe6k/kRmT4AR
pCwZXmhL/OKzvmvlxp37elDx/CVZFixQd8+EcehGRdph0Ygs6MEJH30Y6lBFpmqr
f0ckqks=
=vB1C
-----END PGP SIGNATURE-----
--=-=-=--
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.Received: (at 74385) by debbugs.gnu.org; 9 Dec 2024 17:04:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 09 12:04:48 2024 Received: from localhost ([127.0.0.1]:55393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tKhBf-0008OQ-RI for submit <at> debbugs.gnu.org; Mon, 09 Dec 2024 12:04:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1tKhBd-0008O7-Bi for 74385 <at> debbugs.gnu.org; Mon, 09 Dec 2024 12:04:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1tKhBW-0001EX-UG; Mon, 09 Dec 2024 12:04:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=bK6Vb3Ev9ryH+YOdwCLuaM24sOYUpdJaw4ghiF4yuD4=; b=LH0QNz58hAgMeogZ4gev 3YUUKRY4NfzQo1dyWhtG7iNQJ9dZP81VXaM94mp9gldY+1WMgW2+DDPl71jZz4TUXccRFkbRChCav LgjQVZX7LHCZ0BCXGsGOZiHLbbLrNYkSh/MMjbSHRsyeIzy3tbH5t/ye5ZLmOQt//CjQMHBezCORU uD18H5kDrz5EnHMtWuS7lSxuGvmUhq9QcUE4PF4j9iPKPZuct+1tKHxy6GnKtUxY+VA38P+oUkZXD DnPnqeigKnLy3YAjusOEdCtdF7kC1mr0Da1uexqb0UTAAcWsvTPchI1WDak2Rcb6l6zgnxwfGRPxF ZbTTKMnwABhgKA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Tomas Volf <~@wolfsden.cz> Subject: Re: bug#74385: [PATCH 1/4] srfi-64: Fix maybe-print-prop. In-Reply-To: <20241116174210.9160-1-~@wolfsden.cz> (Tomas Volf's message of "Sat, 16 Nov 2024 18:42:04 +0100") References: <20241116173954.8972-1-~@wolfsden.cz> <20241116174210.9160-1-~@wolfsden.cz> Date: Mon, 09 Dec 2024 18:04:01 +0100 Message-ID: <87a5d4n5z2.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74385 Cc: 74385 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Tomas Volf <~@wolfsden.cz> skribis: > Previously it always printed the property, regardless of whether it was set or > not. > > * module/srfi/srfi-64.scm (test-on-test-end-simple)[maybe-print-prop]: > Print only set properties. [...] > This will help to properly debug failing tests like: > > (test-equal "some failing test" "a b " "a b") > > Before there was no way to tell that one "a b" as extra trailing space, now > there is. > > * module/srfi/srfi-64.scm (test-on-test-end-simple)['expected-value] > ['expected-error, 'actual-value, 'actual-error]: Print using ~s. > [maybe-print-prop]: Take the code for format as a parameter. These two LGTM. Thanks!
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.Received: (at 74385) by debbugs.gnu.org; 9 Dec 2024 17:03:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 09 12:03:11 2024 Received: from localhost ([127.0.0.1]:55387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tKhA7-0008LQ-DI for submit <at> debbugs.gnu.org; Mon, 09 Dec 2024 12:03:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1tKhA5-0008LB-1t for 74385 <at> debbugs.gnu.org; Mon, 09 Dec 2024 12:03:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1tKh9y-0000YQ-Kb; Mon, 09 Dec 2024 12:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Ttcfw+Eu1MMRfnOOAA/RwHd2aGCPWK6OkG1wmQdVf/g=; b=MyRZSsYPgQ57CKAsA4K2 ey20pzKJ1R72r/3z07ZnvYgh/FQIHJ8AalxzTfobwreAuZA4uq/u97RlQ77YM79pG5NRFBkBjt4Fq hUJjYtDKXRe/gl8HIZ/+dTIp+pDXYTfjMTwrlwGBJ2tfHbWEsMhqnXNve1bCzmyeTepsaC+ox3mpb rXBrPeoOse0RcuK+TFqFwxSwIoKuI9Uj4X5ZWXB54gOa2sQ/CUJqKy+MnCvFKKKt/C5DJal3o+vlY i/YuEi18MXFrSsF5c0it1y0ubG/BAQZp3/l5p16OrTcDSx3hPX1gpaj6yL6G4sC2b3RKQ4zMaMQ4w XV5q7TJNZuFqxA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Tomas Volf <~@wolfsden.cz> Subject: Re: bug#74385: [PATCH 4/4] srfi-64: Report failed tests in (standards)Errors format. In-Reply-To: <20241116174210.9160-4-~@wolfsden.cz> (Tomas Volf's message of "Sat, 16 Nov 2024 18:42:07 +0100") References: <20241116174210.9160-1-~@wolfsden.cz> <20241116174210.9160-4-~@wolfsden.cz> Date: Mon, 09 Dec 2024 18:02:57 +0100 Message-ID: <87ed2gn60u.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74385 Cc: 74385 <at> debbugs.gnu.org, Janneke Nieuwenhuizen <janneke@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Tomas Volf <~@wolfsden.cz> skribis: > There is a page in the GNU Standards document regarding the format of err= or > messages. Both GNU Emacs and Vim are able to parse it and support jumpin= g to > next/previous error. My version did not produce a line in this format for > failed tests and this commit rectifies that. > > * module/srfi/srfi-64.scm (test-on-test-end-simple)[non-passed]: Write > out (standards)Errors compatible line. > > Reported-by: Janneke Nieuwenhuizen <janneke@HIDDEN> I personally like this but my gut feeling is that we may want to stick to whatever the previous SRFI-64 implementation was doing, to avoid disruption or breakage for users (remember we=E2=80=99re applying this to a stable series).
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.
Received: (at 74385) by debbugs.gnu.org; 9 Dec 2024 17:01:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 09 12:01:44 2024
Received: from localhost ([127.0.0.1]:55378 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tKh8h-0008I7-R2
for submit <at> debbugs.gnu.org; Mon, 09 Dec 2024 12:01:44 -0500
Received: from eggs.gnu.org ([209.51.188.92]:54370)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1tKh8d-0008Hi-R9
for 74385 <at> debbugs.gnu.org; Mon, 09 Dec 2024 12:01:43 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1tKh8T-0008JL-RS; Mon, 09 Dec 2024 12:01:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
From; bh=e9VKFPo/gppIn4ejtCOZMrUvwWtOc050vKBYu2XqQBI=; b=cV5uE2es1nncDdL0+RM1
HhBiDcYWFzy/xN8zJ7Fnl0L27iG25p4oheS3yqJckHWysRZoAcT2GeV6WGyX9mgjN9mjbck16xWDw
olbIR7/KYlbvZlnjTd8WF5Rt61bRQpIiVI40JidSJcE6MpeAb6m7hixM/H+JtZOOP0Wibnci8Hr9Y
UR4Bvsdj+uJN5RwFl1gO0WmsLdf/LOyLCiUJaExyHCOMJu3KCIlfKbooSimgAlD4xf9VpFdOEmIad
xx+Uge9Q7YWs32LNUCe5h6AQV0hZLqL2oIxwI/kuRSYOZlfrV93apuy/W9fS3tSsm/ilZpzzXWnUN
kUzjU0RY8g82BQ==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Tomas Volf <~@wolfsden.cz>
Subject: Re: bug#74385: [PATCH 3/4] srfi-64: Export define-equality-test.
In-Reply-To: <20241116174210.9160-3-~@wolfsden.cz> (Tomas Volf's message of
"Sat, 16 Nov 2024 18:42:06 +0100")
References: <20241116174210.9160-1-~@wolfsden.cz>
<20241116174210.9160-3-~@wolfsden.cz>
Date: Mon, 09 Dec 2024 18:01:15 +0100
Message-ID: <87jzc8n63o.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 74385
Cc: 74385 <at> debbugs.gnu.org, Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi Tomas,
Tomas Volf <~@wolfsden.cz> skribis:
> +(define-syntax define-equality-test
> (syntax-rules ()
> ((_ name test-proc)
> (define-syntax name
> (=CE=BB (x)
> (syntax-case x ()
> ((_ test-name expected test-expr)
> - #`(%%test-2 #,x test-proc test-name expected test-expr))
> + #`(%test-2 #,x test-proc test-name expected test-expr))
> ((_ expected test-expr)
> - #`(%%test-2 #,x test-proc #f expected test-expr))))))=
))
> + #`(%test-2 #,x test-proc #f expected test-expr))))))))
> +(set-documentation! 'define-equality-test
> + "@defspec define-equality-test identifier proc
> +Define a new test form named @var{identifier} with same signature and us=
age as
> +@code{test-eq} but using @var{proc} instead of @code{eq?}.
I didn=E2=80=99t notice earlier, but you can add docstrings like this:
(define-syntax define-equality-test
(syntax-rules ()
"This is the docstring."
=E2=80=A6))
As for exporting =E2=80=98define-equality-test=E2=80=99, I would clearly ma=
rk it as a
=E2=80=9CGNU extension=E2=80=9D.
The way this was done before is by having more exports in a separate
module, like (srfi srfi-9 gnu).
Whether or not you pick this approach, please make sure to document it
in the manual and to prominently mark it as a GNU extension.
Ludo=E2=80=99.
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.
Received: (at 74385) by debbugs.gnu.org; 16 Nov 2024 17:42:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 16 12:42:24 2024
Received: from localhost ([127.0.0.1]:54684 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tCMoS-0006eM-Gy
for submit <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:42:24 -0500
Received: from wolfsden.cz ([37.205.8.62]:40564)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <~@wolfsden.cz>) id 1tCMoM-0006dm-IM
for 74385 <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:42:19 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 11144351E3E; Sat, 16 Nov 2024 17:42:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1731778938; bh=xogna9WNsghT9bQUuaw4XetlDSxE1qGqODsEB6hlo3c=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=aavp7suRSWvKjfOGk9e5sJjsRIv8s+2Bp4VTr6PBNLKmamVT8eQk8toCl5URBf1xc
A2vlLdO+ybVvz1bw6evNgRQovqzyENRWGhLDAbrlm52RWHwNxYHtIsLArQN56i2aLr
fTTAz1O/lzUUiIcEJm57IgD3gMmcX5h6wvGS00Dy56PZZpEWMorvOqiI6odt1MkbXB
HStf1iJoRTeSQ3IcuuGDCpBsjqByITRj0O9Ehk2UGIgk+yyMLnSc7TIOUUmcETcqpn
/Vi7qbsZ8Tcy47hgRYIKIUYaIflDajUdg8gq/+nje/9uoTBkoMWgRfnfOe1fj3Me1N
GWGogSEPS5EJW/VFD+csQerO7rarpuqqxSzN/3sz4GaCSQINcKRPLk6N2rM/Z+i/L+
5lWuCrrWIn0BbFwFrMXgECHExhpH93lgcXLecvpjT4DxQ2gPsl7Fky4pOAMGmlLjRQ
tDOtHkzMWUPURp1He2v/NkiwqERRITREEtW1j/7Yfm1cQo5CsV3o8IZz/x6ZnGKEj/
rvPs6c/PcLb++BPLcY+MmMzchjEacCwgYI3zzh9RQO2QfgQMk461TN6bKVhpDXejY3
LfhrWmPKS4hVEAkNTA4IIgFQ6Xf3Hjj0Efl8hq+hjVSM1GHsDmsII4zZBILvynicCV
26COfBOdRGWPvqa0T3ykB4/g=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=unavailable autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id 0545835302E;
Sat, 16 Nov 2024 17:42:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1731778937; bh=xogna9WNsghT9bQUuaw4XetlDSxE1qGqODsEB6hlo3c=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=tPvxk4kJylu+CMZDAxdkLzl+WYKS8hfHO9n+t8rck17HVGZ+Tf3B+7HFo49SB1YdZ
J1vOD2DeJR5uiQbn5aV66FK5ENG69N5sGQIbc/8+PucmPAU/1IpMjBuCDmDRhJe1LJ
H8aBaM05qNJ1olr/f2tZcYP80I9hVtH71geHzdxQaMo/07a42sxlL/Z4O56/Xo+VEF
MmzQfOsJbG4WZTEPwDWfJlhR/nHLs3yZI4ERfceBt7MhCmhvc1zMpEb+YDsZ7hx/3/
GtcdGQhmqBkpGEa7CqCnKuWMggvaCsD/UNLya+tPRPYnrqFrfIKpTbYxCRAZQjWzt9
H0nbDRnoaKKD2i5wsZ6PUWAbH8dwrF3F1TsBaClpue7IzGInEsIBEK3gARfUe5DkB9
3BvAq0K7UfXyYd6FewkSlteRt29b17jstAhHaU3h3iofU5mgYO4UzTh8ph9p8ww6xE
tw3nwDc1SQNA//WZ5wZSoMpnWcbicz+xsxIx9DLjsy26lz84vlHBooXgZQJ0FkMy1t
T9ZFdUdUA90Kio6+vGYGKSQHESZEx1WD2erwzCQS0bEyMx58/GJZsRc2B439c4Bu3R
et5dwvPdjFeTY30sCrTUzSYbNd3UQ0IbyUe7l/T6HtANI90ABEAghYDW0UtpDhvaq+
LqccXCVP+GMaoI/DbV4Ec3CI=
From: Tomas Volf <~@wolfsden.cz>
To: 74385 <at> debbugs.gnu.org
Subject: [PATCH 4/4] srfi-64: Report failed tests in (standards)Errors format.
Date: Sat, 16 Nov 2024 18:42:07 +0100
Message-ID: <20241116174210.9160-4-~@wolfsden.cz>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <20241116174210.9160-1-~@wolfsden.cz>
References: <20241116174210.9160-1-~@wolfsden.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74385
Cc: Tomas Volf <~@wolfsden.cz>, Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
There is a page in the GNU Standards document regarding the format of error
messages. Both GNU Emacs and Vim are able to parse it and support jumping to
next/previous error. My version did not produce a line in this format for
failed tests and this commit rectifies that.
* module/srfi/srfi-64.scm (test-on-test-end-simple)[non-passed]: Write
out (standards)Errors compatible line.
Reported-by: Janneke Nieuwenhuizen <janneke@HIDDEN>
---
module/srfi/srfi-64.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/module/srfi/srfi-64.scm b/module/srfi/srfi-64.scm
index 203db49ea..98f6c8114 100644
--- a/module/srfi/srfi-64.scm
+++ b/module/srfi/srfi-64.scm
@@ -28,6 +28,7 @@
#:use-module (ice-9 format)
#:use-module (ice-9 match)
#:use-module (srfi srfi-1)
+ #:use-module (srfi srfi-2)
#:use-module (srfi srfi-9)
#:use-module (srfi srfi-26)
#:use-module (srfi srfi-71)
@@ -431,6 +432,10 @@ instead."
result-kind
(test-runner-test-name runner))
(unless (member result-kind '(pass xfail))
+ (and-let* ((file (test-result-ref runner 'source-file))
+ (line (test-result-ref runner 'source-line)))
+ ;; Satisfy (standards)Errors
+ (format #t "~a:~a: unexpected result~%" file line))
(maybe-print-prop 'source-file #f "~a")
(maybe-print-prop 'source-line #f "~a")
(maybe-print-prop 'source-form #t "~y")
--
2.46.0
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.
Received: (at 74385) by debbugs.gnu.org; 16 Nov 2024 17:42:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 16 12:42:24 2024
Received: from localhost ([127.0.0.1]:54682 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tCMoS-0006eJ-2M
for submit <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:42:24 -0500
Received: from wolfsden.cz ([37.205.8.62]:40558)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <~@wolfsden.cz>) id 1tCMoL-0006dX-JO
for 74385 <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:42:18 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 1760D35339B; Sat, 16 Nov 2024 17:42:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1731778937; bh=iOUYaAROjpk3szYZQyTJjNFGRSvljo1KUFKxPo9zKjM=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=zGtFEmwUVxUxaOHQjHms992Fv5sdZ+qA/PAw0/kzH/mSdQ102gsODz6KEPjX6K6ky
RI1E03xJxzZHWoCdxKwrAv1CW+wn8PIIv1egjX8yLT/HF4sl1omERPcOogCgJG8KEp
1O0H6sFUCSfJ43nRJQCJRY6+NLHOIOX/dVtgl4EtTcGVIaBArlBZ230ohVb1V365NS
Klgcq3HcTbLdmP/yAcZ4iKkuv51aAsqUNyrLT43mfQvL5WyA7Z82Kjd0FL/UFPv0Om
zfnMxOIrdOzUp1wO5m05GKAfWOZL9NtCKfKdFIbtdebfJ085h44YzoaT9hAPymKrMD
fDdzkLefk/VR85AFi9BWz8u/uyMtnPJZKdpfA3VVDfpDMHnZTm99+wYurxnn558FHt
fDSdCkBuCJEzpfjVTKPMvm8QmarpKUaWyHxhcMg3ocFHpQ3rhypGbk7LHnBwe8eExr
S641WRSww1EHGbuB+M9988JzB7d0JUa9/At/tCDAiUPd7lXzo45nRUfqSKlaWfb8yH
28XqNNIKStzJZ85jdOEU3QWvm4kk7/Svu8P7fm2G2UHYcbPzAocRhB27th7swvOWrW
jLwCPdPk3f1RJhdggP8GM16Jk6gYt63eDfQSFTNuZrhxX14Fi9ZSjreCjtpMzbpJbi
YS9vRO46PADxoSKThheboEJ4=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id A85F835302B;
Sat, 16 Nov 2024 17:42:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1731778936; bh=iOUYaAROjpk3szYZQyTJjNFGRSvljo1KUFKxPo9zKjM=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=AkOH1yFlKW+EKPVBKcPV9GZ+f8aXp8yZszMs9ttl4bh94tKBY63+XJ/vW8l5+dEoM
scHV2SpZe68X7XGnnkb5DFJNxLtG/b5laRldASqmu6mmBOR+oWKxIQfwYaNUq8TFHu
Pu4G+qi2v6N7Tj3+jmWsBZkED+78nRaq9Z/p4xsKxyza3NqpW0PZxwXt0tdgrA07W1
OeUT5Bv/S/9qXBTnLAPKwojj25UPCEY/+3/X5BfbXLhv1G0nLuYxcTHB7Q7mR1VwHL
ZO4U1hc0v4CQ4Z14SP3bvVQ6a031UsKCixFN+4APHYaMA0cuKu5SR3CZOv5NGfhGqI
6wZlD6pLnhKSm3jNR7oz5XVLS5LzTob0bSrVFf+4gav4xwMRSm4rtpEAmP3+g0wPTA
kLofl/CI9tM7Aa4XbJQ1y0tTmZepyImN6J0ZPcfARL3G2WYr+tyXEH9ilDOBj/XMOJ
uxXHJdNkkvMgwXg/roZDD85rXp/s2Ip5Mxqd1ebwchYpzxgT/gY5vnib5HEf6l0ohk
BbiCW0MC915M8ZGCj7PGCSVz8fbqzxileC6puz1IqMGtZ0V1NTlf7z93h9LcoLcUnU
2+B7337xq+tklhgbcwLeCZsfzifUFEXo7e3skMgqH37DLl71J31BpNDm1HurK/715/
YsjqL4sQ8feY222cP+nfLLC0=
From: Tomas Volf <~@wolfsden.cz>
To: 74385 <at> debbugs.gnu.org
Subject: [PATCH 3/4] srfi-64: Export define-equality-test.
Date: Sat, 16 Nov 2024 18:42:06 +0100
Message-ID: <20241116174210.9160-3-~@wolfsden.cz>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <20241116174210.9160-1-~@wolfsden.cz>
References: <20241116174210.9160-1-~@wolfsden.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74385
Cc: Tomas Volf <~@wolfsden.cz>, Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Interest was expressed on the mailing list to have %test-2 as a part of the
public API. So rename it and export from the module.
* module/srfi/srfi-64.scm (define-equality-test): Rename from %test-2.
(%test-2): Rename from %%test-2.
(test-eq, test-eqv, test-equal): Adjust.
(define-module)<#:export>: Export it.
Reported-by: Janneke Nieuwenhuizen <janneke@HIDDEN>
---
module/srfi/srfi-64.scm | 30 +++++++++++++++++++++++-------
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/module/srfi/srfi-64.scm b/module/srfi/srfi-64.scm
index 7b3341bf0..203db49ea 100644
--- a/module/srfi/srfi-64.scm
+++ b/module/srfi/srfi-64.scm
@@ -118,6 +118,8 @@
test-procedure?
test-thunk
+ define-equality-test
+
&bad-end-name
bad-end-name?
bad-end-name-begin-name
@@ -728,7 +730,7 @@ to invoke @code{test-assert} if there is no current test runner.
@end defspec")
-(define-syntax %%test-2
+(define-syntax %test-2
(λ (x)
(syntax-case x ()
((_ syn test-proc test-name expected test-expr)
@@ -742,20 +744,34 @@ to invoke @code{test-assert} if there is no current test runner.
(test-result-set! r 'actual-value a)
(test-proc e a))))))))
-(define-syntax %test-2
+(define-syntax define-equality-test
(syntax-rules ()
((_ name test-proc)
(define-syntax name
(λ (x)
(syntax-case x ()
((_ test-name expected test-expr)
- #`(%%test-2 #,x test-proc test-name expected test-expr))
+ #`(%test-2 #,x test-proc test-name expected test-expr))
((_ expected test-expr)
- #`(%%test-2 #,x test-proc #f expected test-expr))))))))
+ #`(%test-2 #,x test-proc #f expected test-expr))))))))
+(set-documentation! 'define-equality-test
+ "@defspec define-equality-test identifier proc
+Define a new test form named @var{identifier} with same signature and usage as
+@code{test-eq} but using @var{proc} instead of @code{eq?}.
-(%test-2 test-eq eq?)
-(%test-2 test-eqv eqv?)
-(%test-2 test-equal equal?)
+For example, the provided equality checks are defined as:
+
+@lisp
+(define-equality-test test-eq eq?)
+(define-equality-test test-eqv eqv?)
+(define-equality-test test-equal equal?)
+@end lisp
+
+@end defspec")
+
+(define-equality-test test-eq eq?)
+(define-equality-test test-eqv eqv?)
+(define-equality-test test-equal equal?)
(set-documentation! 'test-eq
"@defspec test-eq test-name expected test-expr
--
2.46.0
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.
Received: (at 74385) by debbugs.gnu.org; 16 Nov 2024 17:42:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 16 12:42:19 2024
Received: from localhost ([127.0.0.1]:54678 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tCMoM-0006dt-MB
for submit <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:42:18 -0500
Received: from wolfsden.cz ([37.205.8.62]:40528)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <~@wolfsden.cz>) id 1tCMoL-0006dS-3i
for 74385 <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:42:17 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 4FBE3352E25; Sat, 16 Nov 2024 17:42:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1731778936; bh=AmcocLMOPUbQs4KwUJFnUmFXT9NeHGxj3hg6LPUJuxw=;
h=From:To:Cc:Subject:Date;
b=ywJ+OSYTSe6ceGCPTvlb0oK4rznUkVKlTTkO4LWYNLmsE4ghAJ3PSolxmCB/dXnKi
PWaXGKQbIpDo1LN4MDPyjqm4WP1QWaCfuNlqGsscBwaMdFlfPQOR9rm8w+8EIKIqge
Ub49nImkroyN/zRM4JCP2/jfX4XqwQxWvI85Ts/571W+jZQC1xAT/KIe114/QsSphG
g0AoZkx9N5XYmzhgbSg7ayx+IHNZeT4olHyvk1w54bWrLdGO3/+EGB+WGT9Ws6lJgy
6WaG4NE+sOz53JQ0JDb6ifyyMxYfwnOT7JaIHFp+AYGTVyPCD+Dezp6Uh1TX6Q6qld
uQ6cDR4d2BeaqigiD8LW4Ep9RXkj1pcD9S2kLG0qLW4mv8UT40rBIazYYABSHVKOTo
juBDEcz7WwZlc62jSarBA7FOfm0MM5s3EwUW9Wb4IFyO2jlZCDIUBen9fFfTHXGaAb
qMPOGGGQbCNfvKbomwhbYxTxbFiZjmQzYMu1VOA+8b1LofGQ7SFqgNRxtIg40gESH0
TMa5eo5ZCNRqst9sSlRwrPVKxQmmHtvZ7ZsysuBn05IBAtBTacHbROZI6cq+MZAO9c
Ox65l+8jOHLcm7iHloxbXFoHxL9+jNFVlInN4M8vM1CPBkTdT545P82Y+gpvxuwsNg
Yl5yAwPAxxxWxLtPYdId9TcE=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id 07C4F35360C;
Sat, 16 Nov 2024 17:42:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1731778936; bh=AmcocLMOPUbQs4KwUJFnUmFXT9NeHGxj3hg6LPUJuxw=;
h=From:To:Cc:Subject:Date;
b=ywJ+OSYTSe6ceGCPTvlb0oK4rznUkVKlTTkO4LWYNLmsE4ghAJ3PSolxmCB/dXnKi
PWaXGKQbIpDo1LN4MDPyjqm4WP1QWaCfuNlqGsscBwaMdFlfPQOR9rm8w+8EIKIqge
Ub49nImkroyN/zRM4JCP2/jfX4XqwQxWvI85Ts/571W+jZQC1xAT/KIe114/QsSphG
g0AoZkx9N5XYmzhgbSg7ayx+IHNZeT4olHyvk1w54bWrLdGO3/+EGB+WGT9Ws6lJgy
6WaG4NE+sOz53JQ0JDb6ifyyMxYfwnOT7JaIHFp+AYGTVyPCD+Dezp6Uh1TX6Q6qld
uQ6cDR4d2BeaqigiD8LW4Ep9RXkj1pcD9S2kLG0qLW4mv8UT40rBIazYYABSHVKOTo
juBDEcz7WwZlc62jSarBA7FOfm0MM5s3EwUW9Wb4IFyO2jlZCDIUBen9fFfTHXGaAb
qMPOGGGQbCNfvKbomwhbYxTxbFiZjmQzYMu1VOA+8b1LofGQ7SFqgNRxtIg40gESH0
TMa5eo5ZCNRqst9sSlRwrPVKxQmmHtvZ7ZsysuBn05IBAtBTacHbROZI6cq+MZAO9c
Ox65l+8jOHLcm7iHloxbXFoHxL9+jNFVlInN4M8vM1CPBkTdT545P82Y+gpvxuwsNg
Yl5yAwPAxxxWxLtPYdId9TcE=
From: Tomas Volf <~@wolfsden.cz>
To: 74385 <at> debbugs.gnu.org
Subject: [PATCH 1/4] srfi-64: Fix maybe-print-prop.
Date: Sat, 16 Nov 2024 18:42:04 +0100
Message-ID: <20241116174210.9160-1-~@wolfsden.cz>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74385
Cc: Tomas Volf <~@wolfsden.cz>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Previously it always printed the property, regardless of whether it was set or
not.
* module/srfi/srfi-64.scm (test-on-test-end-simple)[maybe-print-prop]:
Print only set properties.
---
module/srfi/srfi-64.scm | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/module/srfi/srfi-64.scm b/module/srfi/srfi-64.scm
index 98fcef645..13ae26d48 100644
--- a/module/srfi/srfi-64.scm
+++ b/module/srfi/srfi-64.scm
@@ -418,15 +418,16 @@ instead."
(define (test-on-test-end-simple runner)
"Log that test is done."
(define (maybe-print-prop prop pretty?)
- (let* ((val (test-result-ref runner prop))
- (val (string-trim-both
- (with-output-to-string
- (λ ()
- (if pretty?
- (pretty-print val #:per-line-prefix " ")
- (display val)))))))
- (when val
- (format #t "~a: ~a~%" prop val))))
+ (let* ((default (list))
+ (val (test-result-ref runner prop default)))
+ (unless (eq? val default)
+ (let ((val (string-trim-both
+ (with-output-to-string
+ (λ ()
+ (if pretty?
+ (pretty-print val #:per-line-prefix " ")
+ (display val)))))))
+ (format #t "~a: ~a~%" prop val)))))
(let ((result-kind (test-result-kind runner)))
;; Skip tests not executed due to run list.
--
2.46.0
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.
Received: (at 74385) by debbugs.gnu.org; 16 Nov 2024 17:42:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 16 12:42:18 2024
Received: from localhost ([127.0.0.1]:54675 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tCMoM-0006dl-8y
for submit <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:42:18 -0500
Received: from wolfsden.cz ([37.205.8.62]:40544)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <~@wolfsden.cz>) id 1tCMoL-0006dU-8L
for 74385 <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:42:17 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id B97CE35339A; Sat, 16 Nov 2024 17:42:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1731778936; bh=2RC8ToKAnVyQnvpGsv3zf3uwQMgkb6+EHSYdWFxoSl8=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=OUhSZmZf6BkENpkXmneuHjQS38TUjw8gHAkiVnPZc3ysTOWIum1jUT/wF3tE69rJG
WtVaq0nw2nW4knyP6ZfSd+tSvR3gumFmzl3k89hbqXYtEnHf8DfGUAs2ObzVlXYpCQ
FJG7NxPruolKpr2ohL0pmX8CaCDK+ZJHPJdRrZE9JToD/iEpxOg/+YFkTXtCiPxux/
LXcRGm8kyReDWLBlVku0oIEQGu21FgRbap8MpRxLwv0AXcYtRptkYq0+/ErtaLx7BF
6YCiMock+cTPvg0CxINQttitaxDzn2LGdziCoQqMvcY7arA+RRe5DCY5r6Gq+vGy3V
6wfWg66r5F+mWjV3OMP8RX5J+I28p8AfbZrW9K/U6v3ED3jdi4tKOoKMFY6BA3lFx8
4WY6o181LyI3LoYjcYVUP9qj/F5FTRA/W0kEYr3kQrISzYX0W4xLQJqXNzbUI/QryG
F3G62VeiXsrYKVC0DcH7u4jVBMWlhAvKMnAFWIOcpyr7wFBJfxtjVAi+a3ekf7XNJp
P4SL3I+H8Ai29Tdq9gZ5ROcz4T3GAfWlsJ5fmx1vaT49rxC0/jWnI1JFj8HRRAeQy5
EUhaUltQTE1mJ7ssMbbcdsR1LJA67gt6dG555gRJK9mdCBenTuysuWIYVj8vqcdTdB
ytlioJ8XaGhxBzRsv69hwR+M=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id 58967351F74;
Sat, 16 Nov 2024 17:42:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1731778936; bh=2RC8ToKAnVyQnvpGsv3zf3uwQMgkb6+EHSYdWFxoSl8=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=OUhSZmZf6BkENpkXmneuHjQS38TUjw8gHAkiVnPZc3ysTOWIum1jUT/wF3tE69rJG
WtVaq0nw2nW4knyP6ZfSd+tSvR3gumFmzl3k89hbqXYtEnHf8DfGUAs2ObzVlXYpCQ
FJG7NxPruolKpr2ohL0pmX8CaCDK+ZJHPJdRrZE9JToD/iEpxOg/+YFkTXtCiPxux/
LXcRGm8kyReDWLBlVku0oIEQGu21FgRbap8MpRxLwv0AXcYtRptkYq0+/ErtaLx7BF
6YCiMock+cTPvg0CxINQttitaxDzn2LGdziCoQqMvcY7arA+RRe5DCY5r6Gq+vGy3V
6wfWg66r5F+mWjV3OMP8RX5J+I28p8AfbZrW9K/U6v3ED3jdi4tKOoKMFY6BA3lFx8
4WY6o181LyI3LoYjcYVUP9qj/F5FTRA/W0kEYr3kQrISzYX0W4xLQJqXNzbUI/QryG
F3G62VeiXsrYKVC0DcH7u4jVBMWlhAvKMnAFWIOcpyr7wFBJfxtjVAi+a3ekf7XNJp
P4SL3I+H8Ai29Tdq9gZ5ROcz4T3GAfWlsJ5fmx1vaT49rxC0/jWnI1JFj8HRRAeQy5
EUhaUltQTE1mJ7ssMbbcdsR1LJA67gt6dG555gRJK9mdCBenTuysuWIYVj8vqcdTdB
ytlioJ8XaGhxBzRsv69hwR+M=
From: Tomas Volf <~@wolfsden.cz>
To: 74385 <at> debbugs.gnu.org
Subject: [PATCH 2/4] srfi-64: Use ~s when printing some properties.
Date: Sat, 16 Nov 2024 18:42:05 +0100
Message-ID: <20241116174210.9160-2-~@wolfsden.cz>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <20241116174210.9160-1-~@wolfsden.cz>
References: <20241116174210.9160-1-~@wolfsden.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74385
Cc: Tomas Volf <~@wolfsden.cz>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This will help to properly debug failing tests like:
(test-equal "some failing test" "a b " "a b")
Before there was no way to tell that one "a b" as extra trailing space, now
there is.
* module/srfi/srfi-64.scm (test-on-test-end-simple)['expected-value]
['expected-error, 'actual-value, 'actual-error]: Print using ~s.
[maybe-print-prop]: Take the code for format as a parameter.
---
module/srfi/srfi-64.scm | 25 +++++++++----------------
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/module/srfi/srfi-64.scm b/module/srfi/srfi-64.scm
index 13ae26d48..7b3341bf0 100644
--- a/module/srfi/srfi-64.scm
+++ b/module/srfi/srfi-64.scm
@@ -27,7 +27,6 @@
#:use-module (ice-9 exceptions)
#:use-module (ice-9 format)
#:use-module (ice-9 match)
- #:use-module (ice-9 pretty-print)
#:use-module (srfi srfi-1)
#:use-module (srfi srfi-9)
#:use-module (srfi srfi-26)
@@ -417,17 +416,11 @@ instead."
(define (test-on-test-end-simple runner)
"Log that test is done."
- (define (maybe-print-prop prop pretty?)
+ (define (maybe-print-prop prop pretty? code)
(let* ((default (list))
(val (test-result-ref runner prop default)))
(unless (eq? val default)
- (let ((val (string-trim-both
- (with-output-to-string
- (λ ()
- (if pretty?
- (pretty-print val #:per-line-prefix " ")
- (display val)))))))
- (format #t "~a: ~a~%" prop val)))))
+ (format #t "~a: ~@?~&" prop code val))))
(let ((result-kind (test-result-kind runner)))
;; Skip tests not executed due to run list.
@@ -436,13 +429,13 @@ instead."
result-kind
(test-runner-test-name runner))
(unless (member result-kind '(pass xfail))
- (maybe-print-prop 'source-file #f)
- (maybe-print-prop 'source-line #f)
- (maybe-print-prop 'source-form #t)
- (maybe-print-prop 'expected-value #f)
- (maybe-print-prop 'expected-error #t)
- (maybe-print-prop 'actual-value #f)
- (maybe-print-prop 'actual-error #t)))))
+ (maybe-print-prop 'source-file #f "~a")
+ (maybe-print-prop 'source-line #f "~a")
+ (maybe-print-prop 'source-form #t "~y")
+ (maybe-print-prop 'expected-value #f "~s")
+ (maybe-print-prop 'expected-error #t "~s")
+ (maybe-print-prop 'actual-value #f "~s")
+ (maybe-print-prop 'actual-error #t "~s")))))
(define (test-runner-simple)
"Creates a new simple test-runner, that prints errors and a summary on the
--
2.46.0
bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.Received: (at submit) by debbugs.gnu.org; 16 Nov 2024 17:40:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 16 12:40:11 2024 Received: from localhost ([127.0.0.1]:54659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tCMmI-0006UJ-Iv for submit <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:40:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:44300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tCMmG-0006U8-7j for submit <at> debbugs.gnu.org; Sat, 16 Nov 2024 12:40:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tCMmF-0007IL-U3 for bug-guile@HIDDEN; Sat, 16 Nov 2024 12:40:07 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tCMmD-0008ED-Pl for bug-guile@HIDDEN; Sat, 16 Nov 2024 12:40:07 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 4BED4351DC8; Sat, 16 Nov 2024 17:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1731778801; bh=j+/5DQrAEbwixM05mn61ij6huXmjuecbjXfpnH2giqM=; h=From:To:Cc:Subject:Date; b=Mp7uHQ0WEAPBF5fp47NND7YY0AoxG7gHyeAQ1z16ULzJfW9b6ZzLRqqiv6bI76ix1 DQOXAGX009G/QpOUpwzXTnixayPJJAmwIVdz45TmHkmNGzYjy8LpzMmsMHT0N2KOo+ SJ9Fxsxq1G16LeofE+Eu1IpdvcfTevQ0OR/bWYEkbaw/8LJZOFhpMdwsJLivrDoDdQ BrT5gw9bgqcIf+eRSldMqFlSn4e/HL07eJJJCMLpne5UTu+ZasfvLlQsvVq3LeEWAX vVgYQFDiKrN00wVwU6i6r2eWGSAlRH/hIeyy6tOHbyXgUleTj1Z0kLJBmIsowIZBlZ l2B9IkvsI0niUs+JfMNc7rA5V9ui95VZZcJI637EY4h3ceqIXDLhhu1SsTJxioSsVM p2Q8/z9/6jBvDYnjk0E6WdRvK4i1PeuY/l0BXdeEKW+eq3du6JOp72HNRPQUh26R79 jS5WdRykFnagTksvYb+5reECBJSQYfYNxoK41Ao2GcYsMkZuX9RnOj8TbCJVmLPJDM Qb5PMxYVWSt/uvjkYi/oUmhRmRkuwCYY+No6ZzT21chRhegzTVyiFZDd2GciL9nqa0 dnIP73lxxUYvvWNtgkkI/OOZSDRKL7KQvU32hdWytF4ojMeTU9uLOsi5gOOF0ZiUeC VYdbulWCNOWdy/zVbPWqVxYY= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 6B422352AAA; Sat, 16 Nov 2024 17:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1731778800; bh=j+/5DQrAEbwixM05mn61ij6huXmjuecbjXfpnH2giqM=; h=From:To:Cc:Subject:Date; b=ouhBP7Dct8jcPo0nGPLauXFLWsHu7ZsGek5bm/6+0HJblhCTERvrlFPTPTh3SiyWQ unWVt1ogc8U2cz2BpqeqQQMB+Rw/189+MnwcO06SirJ+Tba6gDfYgGDAdc8QXsEPNk uXLeZWnkzGpVrW6NsXspqCPA192SzdI0u8UFZSRjUxek7bVcNksk9HSOx1SKTQujmR zeuUXmuWW6hPS607eJ44+bNzFFEGcF/tlaXzFXFBdDfwBbnUctULmE7Lm/5pu6bpoB ua/ZAdMRCNGfchCV4TQPQsrzeatPu6TmNovLWr7BJVnBPEzDwGrX4jVIxN1tf0GS38 M6NG0faLTkOIQxvL+IWuFDWuQAMvV/hTa5fdZyhZFkA4iU77DBGp2jyJ0w8wbJgFW+ 4Bd9mTLv9l/eNGV2qBvju/NQB8V74JO/YJAGBBMHSlAJPauJcx/sy32uV2GQupLqH5 PCUCxs3f+R/pSixD+/MN/ZHDnsi1e6zf9IwAURAtksfPjKEJIsiRFnfaSrlQUvAYB+ iso6sMBz8S3eAcdrcAo/NqaCgvbuctLcPFpYov/prUfJpIGWL+lwfskkwdlAOusFXD 61GGELD46dcPTIh8XjmO1xpnDpJqoIRN8lfNifIke8Hk25YkA0pKljmluj52qINytZ 2ZS31zQDYH8TEmVUAwKVBIxE= From: Tomas Volf <~@wolfsden.cz> To: bug-guile@HIDDEN Subject: [PATCH 0/4] Patches for SRFI-64 Date: Sat, 16 Nov 2024 18:39:54 +0100 Message-ID: <20241116173954.8972-1-~@wolfsden.cz> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Tomas Volf <~@wolfsden.cz> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) Few patches resolving either problems I have noticed or that were reported on the mailing list. Tomas Volf (4): srfi-64: Fix maybe-print-prop. srfi-64: Use ~s when printing some properties. srfi-64: Export define-equality-test. srfi-64: Report failed tests in (standards)Errors format. module/srfi/srfi-64.scm | 65 +++++++++++++++++++++++++---------------- 1 file changed, 40 insertions(+), 25 deletions(-) -- 2.46.0
Tomas Volf <~@wolfsden.cz>:bug-guile@HIDDEN.
Full text available.bug-guile@HIDDEN:bug#74385; Package guile.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.